D24466: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH deprecatedapi REVISION DETAIL https://phabricator.kde.org/D24466 To: kossebau, #frameworks, dfaure, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D23802: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D23802 To: kossebau, #frameworks, dfaure, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe marked an inline comment as done. guoyunhe added inline comments. INLINE COMMENTS > dfaure wrote in krun.cpp:1101 > should this be in ifdef Q_OS_WIN? > > On windows, *.exe is executed, not opened (with e.g. wine) Yes, I updated this part. REPOSITORY R241 KIO REVISION DETAIL

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

guoyunhe updated this revision to Diff 67761. guoyunhe added a comment. *.exe should be normal executable in Windows REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24463?vs=67458=67761 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24463

D24468: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24468 To: kossebau, #frameworks, cfeck, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2,

D24467: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R306 KParts BRANCH deprecatedapi REVISION DETAIL https://phabricator.kde.org/D24467 To: kossebau, #frameworks, dfaure, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24578: Meson: Add a comment section for comment/uncomment with Kate

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Please increase the version number and commit. REPOSITORY R216 Syntax Highlighting BRANCH meson (branched from master) REVISION DETAIL https://phabricator.kde.org/D24578 To:

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven updated this revision to Diff 67763. meven added a comment. Fix slavebase.cpp following QVariant changes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23523?vs=67762=67763 BRANCH arcpatch-D23523 REVISION DETAIL https://phabricator.kde.org/D23523

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven updated this revision to Diff 67762. meven added a comment. Update since, use QVariant as mapConfig value REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23523?vs=65991=67762 BRANCH arcpatch-D23523 REVISION DETAIL https://phabricator.kde.org/D23523

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven updated this revision to Diff 67768. meven added a comment. Replace more config() calls, fixes, code cleanup REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24582?vs=67767=67768 BRANCH next-D23523 REVISION DETAIL https://phabricator.kde.org/D24582

D24294: Port KSslCertificateManager to QSslError

vkrause updated this revision to Diff 67780. vkrause added a comment. bump version to 5.64 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24294?vs=67019=67780 BRANCH arcpatch-D24294 REVISION DETAIL https://phabricator.kde.org/D24294 AFFECTED FILES

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 126 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/126/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 12 Oct 2019 10:10:53 + Build duration: 8 min 59 sec and counting JUnit Tests Name:

D24590: Port KSslErrorUiData to QSslError

vkrause created this revision. vkrause added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24590 AFFECTED

T11859: Understanding and reducing bad performance impact of running Baloo under certain conditions

hurikhan77 updated the task description. TASK DETAIL https://phabricator.kde.org/T11859 To: hurikhan77 Cc: #frameworks, bruns, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, abrahams

D24593: Modified breeze shadows

davidedmundson added a comment. Please write what you've changed and why REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

niccolove added a comment. I'm sorry, when I use scour on svg files, it looks like git does not recognize that the file has changed. How can I fix that? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: davidedmundson,

D24568: Provide clang-format target with a common KDE style file

cullmann updated this revision to Diff 67796. cullmann added a comment. - fix coding style issue, we don't want indented case labels REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24568?vs=67739=67796 BRANCH master REVISION DETAIL

D19088: Use propertymap to store properties in Baloo::Result

astippich added a comment. ping @bruns are you going to land this series? REPOSITORY R293 Baloo BRANCH propertymap REVISION DETAIL https://phabricator.kde.org/D19088 To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich Cc: kde-frameworks-devel, hurikhan77, lots0logs,

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

ahmadsamir added a dependent revision: D24597: Port from deprecated KTcpSocket to QSslSocket. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24588 To: ahmadsamir, dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24597: Port from deprecated KTcpSocket to QSslSocket

ahmadsamir added reviewers: hein, mlaurent. ahmadsamir added subscribers: Konversation, kde-frameworks-devel. REPOSITORY R7 Konversation REVISION DETAIL https://phabricator.kde.org/D24597 To: ahmadsamir, #konversation, hein, mlaurent Cc: kde-frameworks-devel, #konversation

D24597: Port from deprecated KTcpSocket to QSslSocket

ahmadsamir added a task: T11577: Port Konversation away from KTcpSocket. REPOSITORY R7 Konversation REVISION DETAIL https://phabricator.kde.org/D24597 To: ahmadsamir, #konversation, hein, mlaurent Cc: kde-frameworks-devel, #konversation

D24593: Modified breeze shadows

niccolove added a reviewer: VDG. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH breeze-shadows (branched from master) REVISION DETAIL

D24593: Modified breeze shadows

niccolove updated this revision to Diff 67790. niccolove added a comment. Used scour on svg files REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24593?vs=67789=67790 BRANCH breeze-shadows (branched from master) REVISION DETAIL

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/13/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 12 Oct 2019 15:32:00 + Build duration: 59 sec and counting JUnit Tests Name: projectroot

D23951: Improve and clean up panel options menu entries

GB_2 retitled this revision from "Improve desktop layout and panel editing UX" to "Improve and clean up panel options menu entries". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23951 To: GB_2, #plasma, #vdg, mart Cc: ngraham, #vdg,

D24263: edit mode action

GB_2 added inline comments. INLINE COMMENTS > corona.cpp:419 > +} else { > +editAction->setText(i18n("Customize Layout")); > +} Missing ellipsis (...) REPOSITORY R242 Plasma Framework (Library) BRANCH phab/editModeActionwq! REVISION DETAIL

D24593: Modified breeze shadows

niccolove added a comment. Uhm, I probably got Scour wrong. Sorry. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

niccolove edited the summary of this revision. niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D24595: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added reviewers: Frameworks, mlaurent. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KTextWidgets to hide deprecated API

D24568: Provide clang-format target with a common KDE style file

cullmann updated this revision to Diff 67797. cullmann added a comment. - add initial docs REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24568?vs=67796=67797 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24568 AFFECTED

D24568: Provide clang-format target with a common KDE style file

cullmann marked an inline comment as done. cullmann added inline comments. INLINE COMMENTS > ognarb wrote in KDEClangFormat.cmake:11 > need doc Added some initial docs REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24568 To: cullmann Cc: davidedmundson,

D24568: Provide clang-format target with a common KDE style file

cullmann added a reviewer: Frameworks. cullmann marked an inline comment as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24568 To: cullmann, #frameworks Cc: davidedmundson, dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n,

D24568: Provide clang-format target with a common KDE style file

cullmann added a comment. If there are more deviations from the kdelibs/frameworks coding style, please tell me. Otherwise, I am happy with the output of this file for KTextEditor & Kate. For the .clang-format instantiation question: I think it makes sense to instantiate it on

D24568: Provide clang-format target with a common KDE style file

dhaumann added a comment. I'm all for it. This would unify how we can reformat any KDE module, which is very much desirable. Being able to just reformat a patch sounds interesting, too, but can be added later still. Don't let the perfect be the enemy of the good... The example

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven updated this revision to Diff 67767. meven added a comment. Replace more config() calls, fixes, code cleanup REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24582?vs=67765=67767 BRANCH next-D23523 REVISION DETAIL https://phabricator.kde.org/D24582

D24568: Provide clang-format target with a common KDE style file

davidedmundson added inline comments. INLINE COMMENTS > KDEClangFormat.cmake:48 > +if(KDE_CLANG_FORMAT_EXECUTABLE) > +configure_file(${CMAKE_CURRENT_LIST_DIR}/clang-format.cmake > ${CMAKE_CURRENT_SOURCE_DIR}/.clang-format @ONLY) > +endif() it's a bit weird to put new files in the source

D24400: Make hours qint64

aacid abandoned this revision. aacid added a comment. Meh, just realized this patch is useless since we end up passing the quint variable to formatSingleDuration that passes it to QObject::tr and that one only supports int, so at some point there's a potential loss of range anyway

D24584: Add a few const

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Seems good to me REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D24584 To: aacid, meven Cc: meven, kde-frameworks-devel, #baloo, hurikhan77,

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

ahmadsamir created this revision. ahmadsamir added reviewers: dfaure, vkrause. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY This is needed as part of porting Koversation to use QSslSocket instead of KTcpSocket. TEST PLAN The code

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

ahmadsamir added a task: T11577: Port Konversation away from KTcpSocket. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24588 To: ahmadsamir, dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24294: Port KSslCertificateManager to QSslError

This revision was automatically updated to reflect the committed changes. Closed by commit R241:4bfbdad31fdc: Port KSslCertificateManager to QSslError (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24294?vs=67780=67781 REVISION DETAIL

D24382: Port (most of) the interface of KSslCertificateRule to QSslError

This revision was automatically updated to reflect the committed changes. Closed by commit R241:524023533886: Port (most of) the interface of KSslCertificateRule to QSslError (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D24382: Port (most of) the interface of KSslCertificateRule to QSslError

vkrause updated this revision to Diff 67782. vkrause added a comment. bump version number to 5.64 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24382?vs=67247=67782 BRANCH arcpatch-D24382 REVISION DETAIL https://phabricator.kde.org/D24382 AFFECTED

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 139 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/139/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 12 Oct 2019 10:10:54 + Build duration: 10 min and counting BUILD ARTIFACTS

D24590: Port KSslErrorUiData to QSslError

vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24590 To: vkrause, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24568: Provide clang-format target with a common KDE style file

cullmann added inline comments. INLINE COMMENTS > davidedmundson wrote in KDEClangFormat.cmake:48 > it's a bit weird to put new files in the source directory when running cmake. > > Copying when running the target clang-format would probably be ok as there > you're already doing an explicit

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven updated this revision to Diff 67772. meven added a comment. Clean up a QVariant() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24582?vs=67771=67772 BRANCH next-D23523 REVISION DETAIL https://phabricator.kde.org/D24582 AFFECTED FILES

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven updated this revision to Diff 67771. meven added a comment. Fixes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24582?vs=67768=67771 BRANCH next-D23523 REVISION DETAIL https://phabricator.kde.org/D24582 AFFECTED FILES src/ioslaves/file/file.cpp

D24400: Make hours qint64

aacid added inline comments. INLINE COMMENTS > aacid wrote in kformatprivate.cpp:339 > because its unnecessary, qint64 / number don't need a quint64 to store it. sorry i just realized ms is quint64, so yes sshould b quint64 REPOSITORY R244 KCoreAddons REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 128 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/128/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 12 Oct 2019 10:32:07 + Build duration: 11 min and counting JUnit Tests Name: projectroot

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

meven added a dependent revision: D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig(). REPOSITORY R241 KIO BRANCH arcpatch-D23523 REVISION DETAIL https://phabricator.kde.org/D23523 To: meven, davidedmundson, dfaure, #frameworks Cc: broulik, kde-frameworks-devel,

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven created this revision. meven added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Depends on D23523 Now that

D24582: Replace usage of SlaveBase::config() by SlaveBase::mapConfig()

meven planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24582 To: meven, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24584: Add a few const

aacid created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY These things aren't super expensive to copy, but const & is less expensive REPOSITORY R293 Baloo BRANCH

D24568: Provide clang-format target with a common KDE style file

cullmann added a comment. In D24568#545736 , @apol wrote: > I'm not sure how this works, but would it be possible to have a target that only works on a patch? You usually want to make sure what you modified didn't diverge from the code.

D24419: Implement KSslCertificateRule with QSslError instead of KSslError

This revision was automatically updated to reflect the committed changes. Closed by commit R241:41a209b2b6ce: Implement KSslCertificateRule with QSslError instead of KSslError (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 127 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/127/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 12 Oct 2019 10:23:28 + Build duration: 8 min 31 sec and counting JUnit Tests Name:

D24598: Update elisa icon

astippich added a comment. old icons 22px F7580424: elisaSmallOld.png 48px F7580438: elisaBigOld.png updated icons 22px F7580429: elisaSmall.png 48px

D24598: Update elisa icon

GB_2 added a comment. I don't think it makes sense to change the icon here if D12992 already does it. If you want it to progress then take over the revision and work on the completely new style there or make a ping comment and have some patience.

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

GB_2 added a dependent revision: D24533: Draw categories in iconview in a similiar style as Kirigami and new KCategoryDrawer. REPOSITORY R276 KItemViews BRANCH newcategorystyle (branched from master) REVISION DETAIL https://phabricator.kde.org/D24453 To: davidre, #frameworks, #vdg,

D24372: Compile without deprecated foreach

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ahmadsamir wrote in job.cpp:181 > IIUC, subjobs() returns a const QList &, do we still need a local const var? >

D24466: Use ECMGenerateExportHeader to manage deprecated API better

dfaure added inline comments. INLINE COMMENTS > kactioncollection.h:278 > */ > +KXMLGUI_DEPRECATED_VERSION(5, 0, "Do not rely on") > QT_MOC_COMPAT void removed(QAction *action); Does this work? It's a signal. Won't this only warn at emit time? (while QT_MOC_COMPAT is what leads

D23802: Use ECMGenerateExportHeader to manage deprecated API better

dfaure added inline comments. INLINE COMMENTS > ktoolinvocation.h:152 > */ > -KSERVICE_DEPRECATED static void invokeBrowser(const QString , > +KSERVICE_DEPRECATED_VERSION(5, 0, "Use QDesktopServices::openUrl(const > QUrl&)") > +static void invokeBrowser(const QString , No #if

D23802: Use ECMGenerateExportHeader to manage deprecated API better

kossebau updated this revision to Diff 67803. kossebau marked an inline comment as done. kossebau added a comment. add missing #if/#endif for KToolInvocation::invokeBrowser REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23802?vs=67731=67803 BRANCH

D24600: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KItemModels to hide deprecated API up

D24372: Compile without deprecated foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R241:7c0402ed9fd7: Compile without deprecated foreach (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24372?vs=67804=67808 REVISION DETAIL

D23802: Use ECMGenerateExportHeader to manage deprecated API better

This revision was automatically updated to reflect the committed changes. Closed by commit R309:ce11545c51ec: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/38/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 12 Oct 2019 21:17:43 + Build duration: 1 min 38 sec and counting JUnit Tests Name:

D23579: port ftp slave to new error reporting system

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Excellent work! INLINE COMMENTS > ftp.cpp:2635 > + > +#pragma message "was this useful? I have no clue where or how keepalive > would work with ftp" > +//

D24558: fix proxy setting loading

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Err, yeah, the call to `setPort(-1)` serves no purpose at all otherwise... REPOSITORY R241 KIO BRANCH fix-proxy-load REVISION DETAIL https://phabricator.kde.org/D24558 To: sitter,

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 43 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/43/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 12 Oct 2019 21:22:06 + Build duration: 18 min and counting JUnit Tests Name:

D24568: Provide clang-format target with a common KDE style file

aacid added a comment. > common KDE style file There's no such thing as a common KDE style REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24568 To: cullmann, #frameworks Cc: aacid, davidedmundson, dhaumann, apol, ognarb, kde-frameworks-devel,

D24487: fix password error condition handling of smb mount

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH Applications/19.08 REVISION DETAIL https://phabricator.kde.org/D24487 To: sitter, dfaure Cc: kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe,

D24318: Make 32px document-save icon colorful

GB_2 added a comment. In D24318#542048 , @ndavis wrote: > Yeah, that was a feature of the original icon that I didn't remove. I wasn't so sure about it either. If you don't like it then remove it :P REPOSITORY R266 Breeze Icons

D24467: Use ECMGenerateExportHeader to manage deprecated API better

dfaure accepted this revision. REPOSITORY R306 KParts BRANCH deprecatedapi REVISION DETAIL https://phabricator.kde.org/D24467 To: kossebau, #frameworks, dfaure, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24372: Compile without deprecated foreach

dfaure accepted this revision. REPOSITORY R241 KIO BRANCH arcpatch-D24372 (branched from master) REVISION DETAIL https://phabricator.kde.org/D24372 To: ahmadsamir, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 129 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/129/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 12 Oct 2019 21:18:23 + Build duration: 9 min 54 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/14/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 12 Oct 2019 21:21:40 + Build duration: 13 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/14/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 12 Oct 2019 21:22:45 + Build duration: 23 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/35/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 12 Oct 2019 21:22:33 + Build duration: 26 min and counting JUnit Tests Name:

D24598: Update elisa icon

astippich created this revision. astippich added reviewers: VDG, ngraham, mgallien. astippich added a project: Elisa. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Since D12992

D24598: Update elisa icon

astippich added a comment. I have no intention on taking over D12992 as I would like rather like to code for Elisa. I am no designer. I was unsatisfied with the icon and @mgallien agreed on some slight adjustments to the current one. D12992

D24466: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added inline comments. INLINE COMMENTS > dfaure wrote in kactioncollection.h:314 > (pre-existing) QT_MOC_COMPAT for a slot? Any idea what this might do? No idea. I started a few times to look up what QT_MOC_COMPAT actually is about, but never had quick results, so delayed into the

D23802: Use ECMGenerateExportHeader to manage deprecated API better

kossebau marked an inline comment as done. kossebau added inline comments. INLINE COMMENTS > dfaure wrote in ktoolinvocation.h:152 > No #if for this one? I cannot remember this was left out on purpose, so far assume I was just confused by the existing if/endif spanning multiple methods, and

D24599: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KCodecs to hide deprecated API up to a given

D24372: Compile without deprecated foreach

ahmadsamir updated this revision to Diff 67804. ahmadsamir added a comment. Rebase REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24372?vs=67510=67804 BRANCH arcpatch-D24372 (branched from master) REVISION DETAIL https://phabricator.kde.org/D24372

D24372: Compile without deprecated foreach

ahmadsamir added a comment. I had to fix one conflict when rebasing, and basically D24419 ate the foreach src/core/ksslcertificatemanager.cpp@line 128 (by returning the result of calling contains() on the container, neater :)). REPOSITORY R241 KIO

D24466: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added inline comments. INLINE COMMENTS > dfaure wrote in kactioncollection.h:278 > Does this work? It's a signal. Won't this only warn at emit time? (while > QT_MOC_COMPAT is what leads to a warning at connect time) > > Asking because you didn't do this in D24465 >

D23802: Use ECMGenerateExportHeader to manage deprecated API better

dfaure accepted this revision. REPOSITORY R309 KService BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D23802 To: kossebau, #frameworks, dfaure, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24467: Use ECMGenerateExportHeader to manage deprecated API better

This revision was automatically updated to reflect the committed changes. Closed by commit R306:b8bc88232471: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE

D24466: Use ECMGenerateExportHeader to manage deprecated API better

dfaure added inline comments. INLINE COMMENTS > kossebau wrote in kactioncollection.h:314 > No idea. I started a few times to look up what QT_MOC_COMPAT actually is > about, but never had quick results, so delayed into the future. > > Just had a look again, but as before stranding with

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 93 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/93/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 12 Oct 2019 21:22:13 + Build duration: 31 min and counting BUILD ARTIFACTS

D24588: [SslUi] Overload askIgnoreSslErrors() to take a QSslSocket

dfaure added a comment. Hmm, why not just do `KSslErrorUiData uiData(socket);` in the caller, or even just `askIgnoreSslErrors(KSslErrorUiData(socket), storedRules)`. Don't know, just wondering (not objecting). @vkrause, any opinion? INLINE COMMENTS > sslui.h:42 > RulesStorage

D24584: Add a few const

aacid closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24584 To: aacid, meven Cc: meven, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 39 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/39/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 12 Oct 2019 21:25:23 + Build duration: 51 min and counting JUnit Tests Name:

D24568: Provide clang-format target with a common KDE style file

cullmann added a comment. In D24568#546227 , @aacid wrote: > > common KDE style file > > There's no such thing as a common KDE style Shall we name it kdelibs coding style? But actually the idea is to have one, as opt in, for the

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 24 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/24/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 12 Oct 2019 21:25:51 + Build duration: 1 hr 2 min and counting JUnit Tests Name:

D24590: Port KSslErrorUiData to QSslError

aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Looks good, maybe i can even convince you to make fatalErrors and remainingErrors const? REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24590 To:

  1   2   >