D25039: Fix Clazy performance issues, const

kossebau added inline comments. INLINE COMMENTS > ahmadsamir wrote in ftp.cpp:1376 > IIUC, the compiler will use a temporary object to hold the return of > tempurl.fileName(). > > The temporary is used to initialize filename, and then it's gone: > const QString filename = tempurl.filename(); >

D25067: Fix the header layouts for EntryDetails and Page components

ngraham added a comment. Now that's fixed on the main page but it's missing margins on the right side: F7702718: Screenshot_20191031_081429.png And it's still broken on details pages: F7702721: Screenshot_20191031_081517.png

D23801: Port kpac from QtScript

kossebau added inline comments. INLINE COMMENTS > carewolf wrote in script.cpp:316 > Invokables can be called asynchronously (queued), if you take a reference and > the isn't evaluated immediatly the reference might be invalid by the time the > call is evaluated. With queued signals, any

D25039: Fix Clazy performance issues, const

kossebau added inline comments. INLINE COMMENTS > ftp.cpp:1376 > QString parentDir; > -QString filename = tempurl.fileName(); > +const QString = tempurl.fileName(); > Q_ASSERT(!filename.isEmpty()); `QUrl::fileName()` returns a value QString, so just const QString filename

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25079 To: meven, dfaure, #frameworks, davidedmundson Cc: ahmadsamir, sitter, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25088: Use X-KDE-NoGlobalShortcut instead of NoDisplay to store that a component is disabled

davidre added inline comments. INLINE COMMENTS > kserviceactioncomponent.cpp:36 > m_serviceStorageId(serviceStorageId), > > m_desktopFile(QStandardPaths::locate(QStandardPaths::GenericDataLocation, > QStringLiteral("kglobalaccel/") + serviceStorageId)) > { Related to

D25084: Allow a Multiple instances to become Unique

ngraham added a comment. Put this on invent maybe? REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D25084 To: tcanabrava Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25039: Fix Clazy performance issues, const

ahmadsamir added inline comments. INLINE COMMENTS > kossebau wrote in ftp.cpp:1376 > `QUrl::fileName()` returns a value QString, so just > > const QString filename = empurl.fileName(); > > While > > const QString = empurl.fileName(); > > also is fine code IIRC, as I once learned to my

D24726: Fix null pointer reference when extraction fails

apol added a comment. Have you looked into creating a unit test for this? REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D24726 To: pvuorela, davidllewellynjones, dfaure, aacid Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24726: Fix null pointer reference when extraction fails

pvuorela added a comment. Haven't looked and to be honest a little skeptical if anyone removing a null check is likely enough to protect against. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D24726 To: pvuorela, davidllewellynjones, dfaure, aacid Cc: apol,

D25039: Fix Clazy performance issues, const

meven updated this revision to Diff 69121. meven marked 7 inline comments as done. meven added a comment. Review feedback REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25039?vs=69083=69121 BRANCH arcpatch-D25039 REVISION DETAIL

D23801: Port kpac from QtScript

carewolf added inline comments. INLINE COMMENTS > kossebau wrote in script.cpp:316 > With queued signals, any const-reference arguments are passed via an internal > value-copy IIRC, so references are not out-dated. > Can the same technique not be expected with any usages of invocables, like >

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 77 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/77/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 31 Oct 2019 18:55:56 + Build duration: 1 min 29 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 82 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/82/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 31 Oct 2019 18:55:56 + Build duration: 1 min 34 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 81 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/81/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 31 Oct 2019 18:10:17 + Build duration: 4 min 59 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 192 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/192/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 31 Oct 2019 19:01:57 + Build duration: 2 min 45 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 190 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/190/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 31 Oct 2019 18:10:17 + Build duration: 2 min 21 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 76 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/76/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 31 Oct 2019 18:10:17 + Build duration: 2 min 16 sec and counting JUnit Tests Name:

T11950: Reduce the pain of working on monochrome Breeze icons

ngraham added a project: Frameworks. ngraham added a subscriber: Frameworks. TASK DETAIL https://phabricator.kde.org/T11950 To: ngraham Cc: #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, LeGast00n, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas,

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 191 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/191/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 31 Oct 2019 18:55:56 + Build duration: 6 min 0 sec and counting JUnit Tests Name: (root)

D25049: Conditionally show navigation buttons in the header for multi-page KCMs

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R295:47f23c0f6ad1: Conditionally show navigation buttons in the header for multi-page KCMs (authored by ngraham).

D25049: Conditionally show navigation buttons in the header for multi-page KCMs

ngraham added a comment. No regressions found and seems low-risk. Landing now to get it into 5.64 ahead of tagging on Nov 2nd. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D25049 To: ngraham, #vdg, #plasma, mart Cc: GB_2, kde-frameworks-devel, LeGast00n,

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 83 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/83/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 31 Oct 2019 18:58:46 + Build duration: 1 min 40 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 78 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/78/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 31 Oct 2019 18:58:46 + Build duration: 1 min 26 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.13 - Build # 57 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.13/57/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Thu, 31 Oct 2019 19:09:23 + Build duration: 7 min 2 sec and counting JUnit Tests

D25084: Allow a Multiple instances to become Unique

adridg accepted this revision. adridg added a comment. This revision is now accepted and ready to land. This has been applied to FreeBSD ports because it works. +1 (with the other konsole patch that **is** on invent). REPOSITORY R271 KDBusAddons BRANCH multiple_to_unique REVISION

D25088: Use X-KDE-NoGlobalShortcut instead of NoDisplay to store that a component is disabled

meven added inline comments. INLINE COMMENTS > davidedmundson wrote in kserviceactioncomponent.cpp:36 > I don't think I follow. > > We're editing the .desktop file inside > {XDG_DATA_DIRS}/kglobalaccel/someName.desktop > The menu only reads from XDG_DATA_DIRS/applications/someName.desktop > >

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/38/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 01 Nov 2019 04:24:30 + Build duration: 3 min 50 sec and counting JUnit Tests

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 164 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/164/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 01 Nov 2019 04:24:55 + Build duration: 11 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 138 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/138/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 01 Nov 2019 04:25:32 + Build duration: 19 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.13 - Build # 41 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.13/41/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 01 Nov 2019 04:24:30 + Build duration: 7 min 6 sec and counting BUILD ARTIFACTS

T11950: Reduce the pain of working on monochrome Breeze icons

mglb added a comment. Inserting and applying styles can be done with icon template file with predefined swatches. Swatches (which are internally one-stop gradients) would be converted into style later with a script. Not trivial (i.e. not one line sed) to write due to indirect gradient use

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 54 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/54/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 01 Nov 2019 01:46:55 + Build duration: 2 min 35 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 163 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/163/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 31 Oct 2019 21:54:54 + Build duration: 12 min and counting JUnit Tests Name: projectroot

D25084: Allow a Multiple instances to become Unique

davidedmundson added a comment. I don't follow this patch. Say I'm starting a unique app (like org.kde.PlasmaShell) If another bus name already exists, which with the same prefix (such as "org.kde.PlasmaShellasdfasdf") then my new unique app will try to register as

D22946: Include API to generically implement --replace arguments

apol updated this revision to Diff 69147. apol added a comment. Rebase and get inspiration from 5bf091ee07ac44ed1bf1e75a4d07847edb86c5d6 as suggested by David REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE

D24726: Fix null pointer reference when extraction fails

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH upstream_master REVISION DETAIL https://phabricator.kde.org/D24726 To: pvuorela, davidllewellynjones, dfaure, aacid Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D22946: Include API to generically implement --replace arguments

apol marked an inline comment as done. REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D22946 To: apol, #frameworks, davidedmundson Cc: davidedmundson, broulik, kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

T11950: Reduce the pain of working on monochrome Breeze icons

ndavis added a comment. I don't trust optimizers unless it's `scour`. That's the only one I know of that doesn't seem to cause problems occasionally. Inkscape's Optimized SVG save option actually uses `scour` to do the optimization. I'm somewhat open to the idea of only requiring

D22946: Include API to generically implement --replace arguments

davidedmundson added a comment. I think I didn't explain myself properly. There's a way to do a version that has no race conditions. Order of events needs to be 1. We try to register our service name with the queued flag 2. We see if we succeeded to register it immediately 3. If

D24621: [RFC] New Konsole and Yakuake icons

ngraham added a comment. In D24621#547787 , @ngraham wrote: > I really like the Yakuake icon that has a subtle "Y" in it. If everyone else does too, maybe that should be moved into a separate patch so we can get it in quickly and then

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/47/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 31 Oct 2019 05:58:39 + Build duration: 23 min and counting JUnit Tests Name:

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 53 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/53/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 31 Oct 2019 06:01:44 + Build duration: 24 min and counting JUnit Tests Name:

D25039: Fix Clazy performance issues, const

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25039 To: meven, #frameworks, dfaure Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25039: Fix Clazy performance issues, const

meven updated this revision to Diff 69082. meven edited the summary of this revision. meven added a comment. amend commit message REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25039?vs=69081=69082 BRANCH arcpatch-D25039 REVISION DETAIL

D25039: Fix Clazy performance issues, const

meven retitled this revision from "Fix Clazy performance issues, const &, noexcept" to "Fix Clazy performance issues, const &". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25039 To: meven, #frameworks, dfaure Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2,

D25039: Fix Clazy performance issues, const &, noexcept

meven updated this revision to Diff 69081. meven marked 5 inline comments as done. meven added a comment. Remove noexcept changes, avoid touching kpac, some code formatting REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25039?vs=68955=69081 BRANCH

D25039: Fix Clazy performance issues, const

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25039 To: meven, #frameworks, dfaure Cc: kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25039: Fix Clazy performance issues, const

meven updated this revision to Diff 69083. meven edited the summary of this revision. meven added a comment. amend commit message REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25039?vs=69082=69083 BRANCH arcpatch-D25039 REVISION DETAIL

D25003: [KDesktopFile] Add a property and propertyKde functions to access custom properties

broulik added a comment. `KDesktopFile::desktopGroup()` just gives you a `KConfigGroup` of the ´[Desktop Entry]` section at which point you can read whatever you want REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25003 To: meven, #frameworks, apol Cc: broulik,

D25003: [KDesktopFile] Add a property and propertyKde functions to access custom properties

meven added a comment. In D25003#555366 , @apol wrote: > Hi Meven, I guess I didn't make myself clear, sorry about that. This is not what I meant. > > What I meant was here D24956 you can query the

D25003: [KDesktopFile] Add a property and propertyKde functions to access custom properties

meven abandoned this revision. meven added a comment. In D25003#557100 , @broulik wrote: > `KDesktopFile::desktopGroup()` just gives you a `KConfigGroup` of the ´[Desktop Entry]` section at which point you can read whatever you want

D25088: Use X-KDE-NoGlobalShortcut instead of NoDisplay to store that a component is disabled

meven created this revision. meven added reviewers: Plasma, broulik, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Needed to allow apps to not be visible in menus but have shortcuts (i.e

D25039: Fix Clazy performance issues, const

meven added a comment. In D25039#557004 , @anthonyfieroni wrote: > Not using references is not a big problem with QString nor QUrl since they are reference counting objects, say if you don't change their content they are immutable, so > >

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven planned changes to this revision. meven added a comment. I don't expect this to make to KF5.64, will update the @since and all. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n,

D25039: Fix Clazy performance issues, const

anthonyfieroni added a comment. Not using references is not a big problem with QString nor QUrl since they are reference counting objects, say if you don't change their content they are immutable, so const QString s = other; // it's fine void func(QString s) { const

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25079 To: meven, dfaure, #frameworks, davidedmundson Cc: ahmadsamir, sitter, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23801: Port kpac from QtScript

carewolf added inline comments. INLINE COMMENTS > kossebau wrote in script.cpp:316 > So why would it be preferable to have the value be copied there? In general, > one prefers to avoid copies, so what is the different motvation here? Invokables can be called asynchronously (queued), if you

D24726: Fix null pointer reference when extraction fails

pvuorela updated this revision to Diff 69086. pvuorela added a comment. Also remove the empty target file on error REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24726?vs=68119=69086 BRANCH upstream_master REVISION DETAIL

D24726: Fix null pointer reference when extraction fails

pvuorela added reviewers: davidllewellynjones, dfaure, aacid. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D24726 To: pvuorela, davidllewellynjones, dfaure, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25088: Use X-KDE-NoGlobalShortcut instead of NoDisplay to store that a component is disabled

davidedmundson added inline comments. INLINE COMMENTS > kserviceactioncomponent.cpp:36 > m_serviceStorageId(serviceStorageId), > > m_desktopFile(QStandardPaths::locate(QStandardPaths::GenericDataLocation, > QStringLiteral("kglobalaccel/") + serviceStorageId)) > { I