D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

ndavis added inline comments. INLINE COMMENTS > kpropertiesdialog.cpp:1120 > +QPushButton *goThereButton = new QPushButton(d->m_frame); > +goThereButton->setIcon(QIcon::fromTheme(QStringLiteral("go-next"))); > + `go-jump` is more semantically correct. REPOSITORY R241 KIO

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.13 - Build # 79 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.13/79/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 11 Nov 2019 04:23:02 + Build duration: 15 min and counting BUILD ARTIFACTS

D25249: KDirModel: port to qCDebug, with its own category

dfaure created this revision. dfaure added reviewers: mlaurent, sandsmark. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. TEST PLAN Builds, and I was able to enable this category in kdebugsettings and see the

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

ndavis added a comment. In D25226#560363 , @ngraham wrote: > Or maybe should the UI be changed to show a clickable link and an "edit" button that temporarily turns it into a text field that lets you edit it? So like this?

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 176 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/176/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 10 Nov 2019 11:14:24 + Build duration: 10 min and counting JUnit Tests Name: projectroot

D24828: KRun: don't override user preferred app when opening local *.*html and co. files

ahmadsamir added a comment. Ping. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24828 To: ahmadsamir, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

ahmadsamir added a comment. Ping. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24951 To: ahmadsamir, dfaure, ngraham, #frameworks, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

ahmadsamir added reviewers: Frameworks, VDG. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24951 To: ahmadsamir, dfaure, ngraham, #frameworks, #vdg Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24873: [http kio slave] use QSslSocket instead of KTcpSocket (deprecated)

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f39eb884fecc: [http kio slave] use QSslSocket instead of KTcpSocket (deprecated) (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 191 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/191/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 10 Nov 2019 11:14:25 + Build duration: 14 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 177 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/177/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 10 Nov 2019 11:28:05 + Build duration: 9 min 37 sec and counting JUnit Tests Name:

Re: New Framework Review: KDAV

On samedi 9 novembre 2019 21:14:46 CET Alexander Potashev wrote: > сб, 9 нояб. 2019 г. в 14:37, Volker Krause : > > during Akademy there was a request to promote KDAV from KDE PIM to > > Frameworks for use by Plasma Mobile. KDAV is a framework that implements > > the CalDav/ CardDav/GroupDav

KDE CI: Frameworks » kitemmodels » kf5-qt5 WindowsMSVCQt5.13 - Build # 22 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20WindowsMSVCQt5.13/22/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 10 Nov 2019 06:06:08 + Build duration: 6 hr 37 min and counting JUnit Tests

KDE CI: Frameworks » kpeople » kf5-qt5 WindowsMSVCQt5.13 - Build # 26 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kpeople/job/kf5-qt5%20WindowsMSVCQt5.13/26/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 10 Nov 2019 06:37:14 + Build duration: 6 hr 47 min and counting JUnit Tests

D25223: Avoid side effects during menu initialization

cgiboudeaux added a comment. tested successfully locally. I don't see menus opening on the top left corner when running vlc or hp-systray. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D25223 To: kmaterka, #plasma, #frameworks,

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

This revision was automatically updated to reflect the committed changes. Closed by commit R241:14c6c0007c42: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

Windows CI Breakages

Hi all, Apologies for the recent crop of CI failures on Windows. These were caused by Windows Defender's engine eating a significant proportion of the system memory (to the extent the builders were swapping to disk even though they have 24GB of RAM available to them) I have now rebooted the

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Let's get this in now that 5.64 is out. REPOSITORY R241 KIO BRANCH ahmad/tcpslavebase (branched from master) REVISION DETAIL https://phabricator.kde.org/D24928 To: ahmadsamir,

D24873: [http kio slave] use QSslSocket instead of KTcpSocket (deprecated)

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH ahmad/kio_http-ktcpsocket (branched from master) REVISION DETAIL https://phabricator.kde.org/D24873 To: ahmadsamir, dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2,

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

vkrause updated this revision to Diff 69514. vkrause added a comment. add comment requested during review REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24980?vs=68817=69514 BRANCH next REVISION DETAIL https://phabricator.kde.org/D24980 AFFECTED FILES

D25149: Add a new template for KCMs

GB_2 added a comment. In D25149#559684 , @tcanabrava wrote: > We need a better icon. it's the icon for the `Plasmoid` template. Why not use the system settings icon as it's a KCM template? REPOSITORY R242 Plasma Framework (Library)

D25149: Add a new template for KCMs

GB_2 added reviewers: Plasma, Frameworks. GB_2 added a project: Plasma. GB_2 added a subscriber: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25149 To: tcanabrava, #plasma, #frameworks Cc: #plasma, GB_2, yurchor, davidedmundson, ognarb,

KDE CI: Frameworks » attica » kf5-qt5 WindowsMSVCQt5.13 - Build # 20 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/attica/job/kf5-qt5%20WindowsMSVCQt5.13/20/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 10 Nov 2019 03:57:34 + Build duration: 6 hr 32 min and counting JUnit Tests Name:

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.13 - Build # 64 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.13/64/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 10 Nov 2019 07:30:43 + Build duration: 6 hr 24 min and counting JUnit Tests

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.13 - Build # 26 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.13/26/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 10 Nov 2019 08:12:35 + Build duration: 5 hr 55 min and counting JUnit Tests

KDE CI: Frameworks » kdoctools » kf5-qt5 WindowsMSVCQt5.13 - Build # 18 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kdoctools/job/kf5-qt5%20WindowsMSVCQt5.13/18/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 10 Nov 2019 08:12:37 + Build duration: 5 hr 58 min and counting JUnit Tests

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 151 - Successful!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/151/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 10 Nov 2019 08:37:39 + Build duration: 5 hr 46 min and counting

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

vkrause updated this revision to Diff 69526. vkrause added a comment. rebase to latest master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24980?vs=69514=69526 BRANCH next REVISION DETAIL https://phabricator.kde.org/D24980 AFFECTED FILES

D25236: Remove the last traces of KSslError from TCPSlaveBase

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D25236 AFFECTED FILES src/core/tcpslavebase.cpp

D25234: Deprecate KTcpSocket overload of KSslErrorUiData ctor

This revision was automatically updated to reflect the committed changes. Closed by commit R241:8b206d84efb6: Deprecate KTcpSocket overload of KSslErrorUiData ctor (authored by nicolasfella). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25234?vs=69528=69529

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

nicolasfella added inline comments. INLINE COMMENTS > ksslinfodialog.h:113 > > -static QList > errorsFromString(const QString > ); > +#if KIOCORE_ENABLE_DEPRECATED_SINCE(5, 64) > +/** @deprecated since 5.64, use certificateErrorsFromString */ Shouldn't this be 65 now? REPOSITORY

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

vkrause updated this revision to Diff 69531. vkrause added a comment. bump deprecation version REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24980?vs=69526=69531 BRANCH pending REVISION DETAIL https://phabricator.kde.org/D24980 AFFECTED FILES

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

nicolasfella added inline comments. INLINE COMMENTS > ksslinfodialog.h:113 > > -static QList > errorsFromString(const QString > ); > +#if KIOCORE_ENABLE_DEPRECATED_SINCE(5, 64) > +/** @deprecated since 5.64, use certificateErrorsFromString */ You missed a spot REPOSITORY R241 KIO

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

nicolasfella accepted this revision. REPOSITORY R241 KIO BRANCH pending REVISION DETAIL https://phabricator.kde.org/D24980 To: vkrause, nicolasfella Cc: ahmadsamir, nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 178 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/178/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 10 Nov 2019 16:03:23 + Build duration: 1 hr 36 min and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 179 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/179/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 10 Nov 2019 17:40:22 + Build duration: 26 min and counting JUnit Tests Name: projectroot

D25244: Implement ISpellChecker backend for Windows >= 8

cullmann added reviewers: Frameworks, vonreth. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25244 To: cullmann, #frameworks, vonreth Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25244: Implement ISpellChecker backend for Windows >= 8

cullmann created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cullmann requested review of this revision. REVISION SUMMARY Provide ISpellChecker backend for Sonnet on Windows This avoids to ship all the hunspell dictionaries for Windows.

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.13 - Build # 154 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.13/154/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 10 Nov 2019 16:55:18 + Build duration: 1 hr 44 min and counting CONSOLE OUTPUT

D25233: [kded] Port plugin metadata to JSON

nicolasfella added a task: T11919: Port KDED modules from .desktop files to JSON metadata. REPOSITORY R363 Print Manager REVISION DETAIL https://phabricator.kde.org/D25233 To: nicolasfella, #frameworks, dantti Cc: kde-utils-devel

D25233: [kded] Port plugin metadata to JSON

nicolasfella edited the summary of this revision. nicolasfella edited the test plan for this revision. nicolasfella added reviewers: Frameworks, dantti. REPOSITORY R363 Print Manager REVISION DETAIL https://phabricator.kde.org/D25233 To: nicolasfella, #frameworks, dantti Cc: kde-utils-devel

KDE CI: Frameworks » kinit » kf5-qt5 WindowsMSVCQt5.13 - Build # 16 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kinit/job/kf5-qt5%20WindowsMSVCQt5.13/16/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 10 Nov 2019 08:12:34 + Build duration: 5 hr 52 min and counting

KDE CI: Frameworks » kcalendarcore » kf5-qt5 WindowsMSVCQt5.13 - Build # 25 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20WindowsMSVCQt5.13/25/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 10 Nov 2019 07:43:34 + Build duration: 6 hr 33 min and counting JUnit Tests

D20508: [udisks2] fix media change detection for external optical drives

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I'm very sorry that this patch appears to have been lost along the way. I've tested it and it works for me. @bruns, are you okay with this? REPOSITORY R245 Solid REVISION DETAIL

D25234: [WIP] Deprecate KTcpSocket overload of KSslErrorUiData ctor

nicolasfella updated this revision to Diff 69528. nicolasfella added a comment. - Add 5.65 to deprecation versions REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25234?vs=69522=69528 BRANCH dpe REVISION DETAIL https://phabricator.kde.org/D25234 AFFECTED

D25234: Deprecate KTcpSocket overload of KSslErrorUiData ctor

nicolasfella edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25234 To: nicolasfella, #frameworks Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25234: Deprecate KTcpSocket overload of KSslErrorUiData ctor

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH dpe REVISION DETAIL https://phabricator.kde.org/D25234 To: nicolasfella, #frameworks, vkrause Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25234: Deprecate KTcpSocket overload of KSslErrorUiData ctor

nicolasfella retitled this revision from "[WIP] Deprecate KTcpSocket overload of KSslErrorUiData ctor" to "Deprecate KTcpSocket overload of KSslErrorUiData ctor". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25234 To: nicolasfella, #frameworks Cc: vkrause,

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

vkrause updated this revision to Diff 69534. vkrause added a comment. bump the right version numbers, sorry REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24980?vs=69531=69534 BRANCH pending REVISION DETAIL https://phabricator.kde.org/D24980 AFFECTED

KDE CI: Frameworks » kirigami » kf5-qt5 WindowsMSVCQt5.13 - Build # 87 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20WindowsMSVCQt5.13/87/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 10 Nov 2019 08:12:33 + Build duration: 5 hr 46 min and counting

KDE CI: Frameworks » kcmutils » kf5-qt5 WindowsMSVCQt5.13 - Build # 31 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20WindowsMSVCQt5.13/31/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Sun, 10 Nov 2019 08:12:38 + Build duration: 6 hr 1 min and counting

D25234: [WIP] Deprecate KTcpSocket overload of KSslErrorUiData ctor

nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY This does not build as-is, but I don't understand why REPOSITORY

D25225: Symlink microphone to audio-input-microphone on all sizes

This revision was automatically updated to reflect the committed changes. Closed by commit R267:99f892b26058: Symlink microphone to audio-input-microphone on all sizes (authored by ltoscano). REPOSITORY R267 Oxygen Icons CHANGES SINCE LAST UPDATE

D25234: [WIP] Deprecate KTcpSocket overload of KSslErrorUiData ctor

vkrause added a comment. I suspect src/core/CMakeLists.txt:139 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25234 To: nicolasfella, #frameworks Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25237: Deprecated KTcpSocket and KSsl* classes

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY We have ported usage of those to their Qt equivalents now, so what remains here is just the removal of all this with

D25236: Remove the last traces of KSslError from TCPSlaveBase

vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25236 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24980: Port ssl_cert_errors meta data from KSslError to QSslError

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d074873f4703: Port ssl_cert_errors meta data from KSslError to QSslError (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24980?vs=69534=69536

D25237: Deprecated KTcpSocket and KSsl* classes

vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25237 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25237: Deprecated KTcpSocket and KSsl* classes

vkrause added a task: T11544: Remove KTcpSocket. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25237 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25223: Avoid side effects during menu initialization

kmaterka updated this revision to Diff 69548. kmaterka added a comment. Use QVariant for tri-state boolean. This way atributes are set only when they were really changed in the past. REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D25223: Avoid side effects during menu initialization

kmaterka added inline comments. INLINE COMMENTS > kdeplatformsystemtrayicon.cpp:191 > +if (!m_visible.isNull()) { > +m_menu->setVisible(m_visible.value()); > +} This line was causing issues, even if menu is (or should be) visible, setting true has side effects. I checked the