D23787: [baloo_file_extractor] Improve handling of large plain-text files

poboiko added a comment. Ping? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D23787 To: poboiko, #baloo, bruns, ngraham Cc: davidedmundson, broulik, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh,

D23787: [baloo_file_extractor] Improve handling of large plain-text files

bruns added a comment. In D23787#541963 , @poboiko wrote: > > and another example which: > > > > - is currently skipped though it should be indexed > > - is indexed after this change > > There shouldn't be any. I mean,

D22801: [KIO] silence a QFileInfo warning

meven added a comment. The issue could be as well located in previewjob.cpp. Could you debug why KMountPoint::List::findByPath is called with an empty string or non-existing file. We might want to prevent this to happen instead. REPOSITORY R241 KIO REVISION DETAIL

D23787: [baloo_file_extractor] Improve handling of large plain-text files

bruns added a comment. In D23787#541963 , @poboiko wrote: > In D23787#537891 , @bruns wrote: > > > Can you please provide an example which: > > > > - is currently indexed though it should be

D25132: Use an eyedropper for color-picker icons

ngraham edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25132 To: ngraham, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25132: Use an eyedropper for color-picker icons

ngraham updated this revision to Diff 69699. ngraham added a comment. Thicken side lines REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25132?vs=69471=69699 BRANCH eyedropper-style-color-picker-icon (branched from master) REVISION DETAIL

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

ngraham added a comment. Last question: give the button text, or stick with the icon only? I ask because `go-jump` is kind of an odd icon IMO: F7761220: Screenshot_20191113_093303.png REPOSITORY R241 KIO REVISION DETAIL

D25291: Add "all applications" category icon

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH all-apps-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D25291 To: ngraham, #vdg, broulik, ndavis Cc: kde-frameworks-devel, LeGast00n, GB_2,

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

ngraham updated this revision to Diff 69684. ngraham marked an inline comment as done. ngraham added a comment. Use more semantically correct icon REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25226?vs=69493=69684 BRANCH

D25291: Add "all applications" category icon

ngraham updated this revision to Diff 69687. ngraham added a comment. Optimize icons with scour REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25291?vs=69686=69687 BRANCH all-apps-icon (branched from master) REVISION DETAIL

D25291: Add "all applications" category icon

This revision was automatically updated to reflect the committed changes. Closed by commit R266:f249a14c70b4: Add all applications category icon (authored by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25291?vs=69687=69695 REVISION DETAIL

D24959: Add new preferences search icons

astippich added a comment. any more comments? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24959 To: astippich, #vdg, ngraham, trickyricky26 Cc: ndavis, trickyricky26, bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D25226: [KPropertiesDialog] provide a way of showing the target of a symlink

ngraham added a comment. Actually I played with that and in retrospect I don't think it would work. If we give it a "link-like" appearance, that would suggest that clicking on it would actually open the destination file/folder (i.e. the typical link behavior), which is not what we want

D25291: Add "all applications" category icon

ngraham created this revision. ngraham added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY We currently have no accepted "all apps" icon. This patch creates one, inspired by the

D25291: Add "all applications" category icon

ngraham added a reviewer: broulik. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25291 To: ngraham, #vdg, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25210: Prepare KConfigSkeletonItem to allow inheriting its private class

This revision was automatically updated to reflect the committed changes. Closed by commit R237:44cfa0631d25: Prepare KConfigSkeletonItem to allow inheriting its private class (authored by ervin). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D25211: Add KPropertySkeletonItem

This revision was automatically updated to reflect the committed changes. Closed by commit R237:d63955cfe547: Add KPropertySkeletonItem (authored by ervin). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25211?vs=69628=69674 REVISION DETAIL

D25286: Allow to disable autosave behavior in ConfigPropertyMap

This revision was automatically updated to reflect the committed changes. Closed by commit R296:40b94af6f0f4: Allow to disable autosave behavior in ConfigPropertyMap (authored by ervin). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25286?vs=69676=69677

D22801: [KIO] silence a QFileInfo warning

rjvbb added a comment. Are you not seeing these for instance when browsing an MSWin share in Dolphin (with the same or newer versions of kio-extras, Samba and MSWin)? I tried to figure out where they came from but failed because of the async nature of the chain of events. I presume the

D23787: [baloo_file_extractor] Improve handling of large plain-text files

poboiko edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D23787 To: poboiko, #baloo, bruns, ngraham Cc: davidedmundson, broulik, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov,

D25286: Allow to disable autosave behavior in ConfigPropertyMap

ervin created this revision. ervin added reviewers: Plasma, Frameworks, mart, davidedmundson, bport. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY This is especially important when ConfigPropertyMap

D25286: Allow to disable autosave behavior in ConfigPropertyMap

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25286 To: ervin, #plasma, #frameworks, mart, davidedmundson, bport Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23787: [baloo_file_extractor] Improve handling of large plain-text files

poboiko added a comment. @bruns: I've missed D16593: [ExtractorCollection] Use only best matching extractor plugin , and had in mind previous situation where we've matched all extractors based on inheritance. In that case, "Secondly" part indeed does not

D25132: Use an eyedropper for color-picker icons

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. LGTM, but I noticed that there is a 32px monochrome icon. Should we keep using 32px monochrome icons for now? It seems like we can't make up our minds on this issue and the amount of work

D24959: Add new preferences search icons

trickyricky26 accepted this revision. trickyricky26 added a comment. This revision is now accepted and ready to land. Sorry, I kind of forgot about this revision. But looks all good now! REPOSITORY R266 Breeze Icons BRANCH newSearchIcon REVISION DETAIL

D25132: Use an eyedropper for color-picker icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:b9dd7fd5a672: Use an eyedropper for color-picker icons (authored by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25132?vs=69699=69708 REVISION

D24957: Add new baloo icons

ngraham accepted this revision. REPOSITORY R266 Breeze Icons BRANCH newBalooIcon REVISION DETAIL https://phabricator.kde.org/D24957 To: astippich, #vdg, ngraham, bruns Cc: trickyricky26, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25149: Add a new template for KCMs

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D25149 REVISION DETAIL https://phabricator.kde.org/D25149 To: tcanabrava, #plasma, #frameworks, mart Cc: #plasma, GB_2, yurchor, davidedmundson,

D24959: Add new preferences search icons

ngraham accepted this revision. ngraham added a comment. LGTM, let's try not to torture this icon to death. :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24959 To: astippich, #vdg, ngraham, trickyricky26 Cc: ndavis, trickyricky26, bruns,

D25149: Add a new template for KCMs

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > %{APPNAMELC}settings.kcfgc:5 > +DefaultValueGetters=true > +GenerateProperties=true You also want "ParentInConstructor=true" in here. > kcm.cpp:32 > +:

D25296: [RFC] Fix Display Configuration icon margins

ngraham created this revision. ngraham added reviewers: VDG, ndavis. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY The icon's old margins were too large, causing it to stick out. However in

KDE CI: Frameworks » syndication » kf5-qt5 WindowsMSVCQt5.13 - Build # 19 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syndication/job/kf5-qt5%20WindowsMSVCQt5.13/19/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Thu, 14 Nov 2019 06:57:15 + Build duration: 3 min 30 sec and counting JUnit Tests

KDE CI: Frameworks » syndication » kf5-qt5 SUSEQt5.12 - Build # 49 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syndication/job/kf5-qt5%20SUSEQt5.12/49/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 14 Nov 2019 06:57:15 + Build duration: 7 min 9 sec and counting BUILD ARTIFACTS

D25149: Add a new template for KCMs

tcanabrava added inline comments. INLINE COMMENTS > ervin wrote in kcm.cpp:43 > Shouldn't be needed anymore (and likely wrong in most cases). What's the correct form then? No need to connect the settings *at all*? > ervin wrote in main.qml:39 > What about disabling it if the setting is

KDE CI: Frameworks » syndication » kf5-qt5 SUSEQt5.13 - Build # 28 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syndication/job/kf5-qt5%20SUSEQt5.13/28/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 14 Nov 2019 06:28:55 + Build duration: 2 min 2 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » syndication » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syndication/job/kf5-qt5%20FreeBSDQt5.13/26/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 14 Nov 2019 06:28:55 + Build duration: 1 min 46 sec and counting JUnit Tests Name:

KDE CI: Frameworks » syndication » kf5-qt5 WindowsMSVCQt5.13 - Build # 18 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syndication/job/kf5-qt5%20WindowsMSVCQt5.13/18/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Thu, 14 Nov 2019 06:28:55 + Build duration: 6 min 42 sec and counting JUnit Tests

KDE CI: Frameworks » syndication » kf5-qt5 SUSEQt5.12 - Build # 48 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syndication/job/kf5-qt5%20SUSEQt5.12/48/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 14 Nov 2019 06:28:55 + Build duration: 7 min 23 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » syndication » kf5-qt5 FreeBSDQt5.13 - Build # 27 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syndication/job/kf5-qt5%20FreeBSDQt5.13/27/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 14 Nov 2019 06:57:15 + Build duration: 3 min 39 sec and counting JUnit Tests Name:

KDE CI: Frameworks » syndication » kf5-qt5 SUSEQt5.13 - Build # 29 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syndication/job/kf5-qt5%20SUSEQt5.13/29/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 14 Nov 2019 06:57:15 + Build duration: 3 min 57 sec and counting BUILD ARTIFACTS