D25304: Fix the OpenEXR >= 2.4 detection

cgiboudeaux created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. cgiboudeaux requested review of this revision. REVISION SUMMARY Newer OpenEXR versions add a suffix to the libraries file names. ECM can now

D25303: Expose KDescendantsProxyModel to QML

ahiemstra accepted this revision. This revision is now accepted and ready to land. REPOSITORY R275 KItemModels BRANCH master REVISION DETAIL https://phabricator.kde.org/D25303 To: davidedmundson, ahiemstra Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25307: kwriteconfig: add delete option

esjeon created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. esjeon requested review of this revision. REVISION SUMMARY Add a simple delete option to kwriteconfig. A possible usecase of this option is to delete unused shortcut bindings.

D25304: Fix the OpenEXR >= 2.4 detection

cgiboudeaux added a comment. Note: openEXR >= 2.4 provides CMake configuration modules (OpenEXRConfig.cmake and IlmBaseConfig.cmake). We could also look for those and use the current code as a fallback if the modules can't be found REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D25015: Update breeze theme shadows

ngraham added a comment. In D25015#562362 , @niccolove wrote: > Meanwhile, I tried to do a more sparse and equal-all-around shadow (to address Nate+Filip), but I'm not 100% okay with it. Opinions? > > F7762929:

D24959: Add new preferences search icons

bruns accepted this revision. REPOSITORY R266 Breeze Icons BRANCH newSearchIcon REVISION DETAIL https://phabricator.kde.org/D24959 To: astippich, #vdg, ngraham, trickyricky26, bruns Cc: ndavis, trickyricky26, bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D25303: Expose KDescendantsProxyModel to QML

This revision was automatically updated to reflect the committed changes. Closed by commit R275:59dedec38d8a: Expose KDescendantsProxyModel to QML (authored by davidedmundson). REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25303?vs=69744=69751 REVISION

D25304: Fix the OpenEXR >= 2.4 detection

arojas added a comment. > I don't see how that commit is related. > openEXR 2.3 installs libXXX.so and 2.4 installs libXXX-2_4.so > > This is expected afaics. No, it's not. That line in openexr is supposed to link libXXX-2_4.so (${verlibname}) to libXXX.so (${baselibname}) but it

D25308: when kioslave5 couldn't be found in libexec-ish locations try $PATH

sitter created this revision. sitter added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY on windows we install the binary to bin/ where software that uses kio can find it

D20766: Use appropriate background color for text previews

meven added a comment. I believe the issue currently is that for text files or files without associated definition we end up with an invalid definition that prevents SyntaxHighlighter::setDefinition to call rehighlight(). QTextDocument uses then whatever it get from the theme I guess.

D25311: Add KColumnHeadersProxyModel

ahiemstra created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ahiemstra requested review of this revision. REVISION SUMMARY It converts a model's column headers into a simple list model. It is mainly useful as a helper to create headers

Re: New Framework Review: KDAV

вс, 10 нояб. 2019 г. в 15:44, David Faure : > > On samedi 9 novembre 2019 21:14:46 CET Alexander Potashev wrote: > > сб, 9 нояб. 2019 г. в 14:37, Volker Krause : > > > during Akademy there was a request to promote KDAV from KDE PIM to > > > Frameworks for use by Plasma Mobile. KDAV is a framework

D19498: loadLibrary: Use enum values to define what type of plugin we load

aspotashev added a comment. ping? REPOSITORY R317 Kross REVISION DETAIL https://phabricator.kde.org/D19498 To: aspotashev, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25307: kwriteconfig: add delete option

ngraham added reviewers: Frameworks, davidre, dfaure, meven, cfeck. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25307 To: esjeon, #frameworks, davidre, dfaure, meven, cfeck Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25304: Fix the OpenEXR >= 2.4 detection

cgiboudeaux added a comment. In D25304#562561 , @arojas wrote: > > I don't see how that commit is related. > > openEXR 2.3 installs libXXX.so and 2.4 installs libXXX-2_4.so > > > > This is expected afaics. > > No, it's not. That line

D25304: Fix the OpenEXR >= 2.4 detection

arojas added a comment. > The pkgconfig file disagrees: > it contains `libsuffix=-2_4` and later `Libs: -L${libdir} -lIlmImf${libsuffix}` > For me, that library name is correct I didn't say that the suffixed .so shouldn't exist. They are *both* supposed to be installed: the

D25270: Correctly set i18n arguments in one pass

davidedmundson added a reviewer: leinir. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D25270 To: davidedmundson, leinir Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25311: Add KColumnHeadersProxyModel

ahiemstra updated this revision to Diff 69765. ahiemstra added a comment. - Add @since for the class REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25311?vs=69764=69765 BRANCH columnheadersmodel REVISION DETAIL https://phabricator.kde.org/D25311

D25304: Fix the OpenEXR >= 2.4 detection

cgiboudeaux added a comment. In D25304#562553 , @arojas wrote: > This is a bug in openexr. It does actually try to install the unsuffixed symlinks, but it doesn't take DESTDIR into account, so it tries to install them to the root filesystem

D25307: kwriteconfig: add delete option

esjeon added a comment. > What shortcuts had you in mind to delete? My specific interest is deleting shortcuts of removed KWin scripts. ( e.g. https://github.com/esjeon/krohnkite/issues/31 ) Such shortcuts keep appearing on Global Shortcuts dialog unless manually deleted. Also, while

D25307: kwriteconfig: add delete option

davidre added a comment. I don't think deleting a entry from a config file makes sense. If you delete an entry you will get the default value on the next read. For shortcuts it's a bit more complicated. What shortcuts had you in mind to delete? REPOSITORY R237 KConfig REVISION

D25307: kwriteconfig: add delete option

davidre added a comment. In D25307#562613 , @esjeon wrote: > > What shortcuts had you in mind to delete? > > My specific interest is deleting shortcuts of removed KWin scripts. ( e.g. https://github.com/esjeon/krohnkite/issues/31 ) Such

D25304: Fix the OpenEXR >= 2.4 detection

arojas added a comment. This is a bug in openexr. It does actually try to install the unprefixed symlinks, but it doesn't take DESTDIR into account, so it tries to install them to the root filesystem instead of doing so inside DESTDIR as it should. It is fixed in

D25236: Remove the last traces of KSslError from TCPSlaveBase

vkrause added a comment. ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25236 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25312: Document configuration file path on Android

jbbgameich added a reviewer: vkrause. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D25312 To: jbbgameich, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25307: kwriteconfig: add delete option

ngraham added a comment. In D25307#562652 , @esjeon wrote: > Also, I don't see anything wrong with adding this, since it merely exposes `deleteEntry` method already in the API. Some projects do rely on it, so why should it be kept away from

D25307: kwriteconfig: add delete option

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Shortcuts aside, the patch makes sense. In general, I want to encourage people to wipe config entries rather than write in the current default as it makes several other

D25307: kwriteconfig: add delete option

ngraham added a comment. Can you provide your email address so we can land this patch with correct authorship information? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25307 To: esjeon, #frameworks, davidre, dfaure, meven, cfeck, davidedmundson Cc:

D25307: kwriteconfig: add delete option

esjeon added a comment. In D25307#562618 , @davidre wrote: > In D25307#562613 , @esjeon wrote: > > > > What shortcuts had you in mind to delete? > > > > My specific interest is deleting shortcuts

D25312: Document configuration file path on Android

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D25312 To: jbbgameich, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25307: kwriteconfig: add delete option

ngraham added a comment. Thanks very much for the nice patch. May it be the first of many! :) REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25307 To: esjeon, #frameworks, davidre, dfaure, meven, cfeck, davidedmundson Cc: davidedmundson, ngraham,

D25307: kwriteconfig: add delete option

This revision was automatically updated to reflect the committed changes. Closed by commit R237:9b8ef694412c: kwriteconfig: add delete option (authored by esjeon, committed by ngraham). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25307?vs=69754=69770

D25304: Fix the OpenEXR >= 2.4 detection

cgiboudeaux abandoned this revision. cgiboudeaux added a comment. I applied the patch to our openexr package instead. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D25304 To: cgiboudeaux Cc: arojas, kde-frameworks-devel, kde-buildsystem, LeGast00n,

D25307: kwriteconfig: add delete option

davidre added a comment. In D25307#562652 , @esjeon wrote: > Also, I don't see anything wrong with adding this, since it merely exposes `deleteEntry` method already in the API. Some projects do rely on it, so why should it be kept away from

D25307: kwriteconfig: add delete option

esjeon added a comment. > Do you have commit access? I don't think so. I'm a first timer around here. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25307 To: esjeon, #frameworks, davidre, dfaure, meven, cfeck, davidedmundson Cc: davidedmundson, ngraham,

D25307: kwriteconfig: add delete option

esjeon added a comment. > Can you provide your email address Eon S. Jeon REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25307 To: esjeon, #frameworks, davidre, dfaure, meven, cfeck, davidedmundson Cc: davidedmundson, ngraham, kde-frameworks-devel, LeGast00n,

D25312: Document configuration file path on Android

jbbgameich created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jbbgameich requested review of this revision. REVISION SUMMARY It's pretty hard right now to find out the search path on android for new developers. REPOSITORY R289

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew updated this revision to Diff 69769. feverfew added a comment. - Align function arguments - Remove hack - Get rid of iterator REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23384?vs=69201=69769 BRANCH KDEDModule (branched from master) REVISION

D25307: kwriteconfig: add delete option

esjeon added a comment. Thanks all. I hope I can be of help. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25307 To: esjeon, #frameworks, davidre, dfaure, meven, cfeck, davidedmundson Cc: davidedmundson, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25313: Add autotest for QML KConcatenateRowsProxyModel

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. TEST PLAN Test passes REPOSITORY R275 KItemModels BRANCH master REVISION DETAIL

D25313: Add autotest for QML KConcatenateRowsProxyModel

davidedmundson added a comment. The unit test was requested on the original revision, I wrote it at the time, but I only realised I hadn't uploaded it just now :/ REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D25313 To: davidedmundson Cc: kde-frameworks-devel,

D25311: Add KColumnHeadersProxyModel

davidedmundson added a comment. We should probably have a unit test, even if it just covers the basic case. This currently assumes the source model's columns are static. At a minimum that needs a comment. INLINE COMMENTS > kcolumnheadersproxymodel.h:30 > + * > + * This model will

D25313: Add autotest for QML KConcatenateRowsProxyModel

davidedmundson updated this revision to Diff 69773. davidedmundson added a comment. whitespace REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25313?vs=69772=69773 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25313 AFFECTED FILES

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 183 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/183/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 15 Nov 2019 04:25:40 + Build duration: 48 min and counting JUnit Tests Name: projectroot

D25313: Add autotest for QML KConcatenateRowsProxyModel

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R275 KItemModels BRANCH master REVISION DETAIL https://phabricator.kde.org/D25313 To: davidedmundson, vkrause Cc: kde-frameworks-devel, apol, LeGast00n, GB_2, michaelh, ngraham, bruns

D21235: Add handling of fuseiso filesystem type

hallas added a comment. @bruns - ping ;) REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D21235 To: hallas, bruns, ngraham Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23205: [KProcessList] Optimize KProcessList::processInfo

hallas added a comment. @davidedmundson - ping ;) REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23205 To: hallas, davidedmundson, broulik Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25315: KDirModel: implement showing "/" as a root node, optionally

dfaure created this revision. dfaure added reviewers: stefanocrocco, elvisangelaccio, meven, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY The API for this is to call openUrl(QUrl()), which

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew updated this revision to Diff 69774. feverfew added a comment. - Get rid of unnecessary copying of URLs - Switch to interface generated at compile time - Delete unused interfaces - Merge branch 'master' into arcpatch-D23384 - remove kiofuseinterface from build REPOSITORY

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew marked 8 inline comments as done. feverfew added inline comments. INLINE COMMENTS > sitter wrote in desktopexecparser.cpp:317 > There's nothing wrong with this. But wouldn't using > `QHash, QUrl>` make for easier to read code all in > all since you don't have to mess with pairs? > >

D24962: [DeleteJob] Use a separate worker thread to run actual IO operation

This revision was automatically updated to reflect the committed changes. Closed by commit R241:80d5f52b0675: [DeleteJob] Use a separate worker thread to run actual IO operation (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D25117: file ioslave: stop copying as soon as the ioslave is killed

meven added a comment. Anyone to review this ? 30 lines change + test REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25117 To: meven, #frameworks, dfaure, ngraham, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 182 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/182/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 14 Nov 2019 08:35:51 + Build duration: 10 min and counting JUnit Tests Name: projectroot

D22801: [KIO] silence a QFileInfo warning

meven added a subscriber: dfaure. meven added a comment. In D22801#561989 , @rjvbb wrote: > Are you not seeing these for instance when browsing an MSWin share in Dolphin (with the same or newer versions of kio-extras, Samba and MSWin)?ç

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven marked 5 inline comments as done. meven added a comment. friendly ping Is https://phabricator.kde.org/D25010#inline-142132 satisfactory ? I think names are now explicit enough. I still wonder if the granularity level is enough. REPOSITORY R241 KIO REVISION DETAIL

D25015: Update breeze theme shadows

niccolove added a comment. In D25015#560514 , @ndavis wrote: > > Remember that there are third party desktop themes with SVG that we probably want to support. Wouldn't using KWin for shadows break those? > > If we remove the code for using

D25149: Add a new template for KCMs

ervin added inline comments. INLINE COMMENTS > tcanabrava wrote in kcm.cpp:43 > What's the correct form then? No need to connect the settings *at all*? No need indeed... it's *magic*! ;-) > tcanabrava wrote in main.qml:39 > The default fake setting will not be immutable, or you mean that you

D25170: make the libssh finder ensure the new ssh target is set

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R320:24506c2af8d1: make the libssh finder ensure the new ssh target is set (authored by sitter). REPOSITORY R320 KIO

D22801: [KIO] silence a QFileInfo warning

rjvbb added a comment. > I disagree since it will change the current precondition of the function for the need of one of its users. In that case the warning could be made to be a qDebug, and that user can configure his/her logging setting so the category used will always be printed.

D25223: Avoid side effects during menu initialization

kmaterka added a comment. In D25223#561638 , @nicolasfella wrote: > My long-term goal is to get rid of the application side KStatusNotifierItem and amend the QSystemTrayIcon API OK, I will think about this. This change is only to fix

D21328: Add qml import for KItemModels

This revision was automatically updated to reflect the committed changes. Closed by commit R275:adb9b0e9cd3a: Add qml import for KItemModels (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D21328?vs=64882=69738#toc REPOSITORY R275 KItemModels CHANGES SINCE

D25301: Move createUDSEntry from file.cpp to file_unix.cpp

meven created this revision. meven added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY This was a unix only function in the shared file protocol cpp This has not

D25237: Deprecated KTcpSocket and KSsl* classes

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D25237 To: vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25302: Remove stale symlink

sandsmark created this revision. sandsmark added a reviewer: dfaure. Herald added a project: Frameworks. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. sandsmark requested review of this revision. REVISION SUMMARY When receiving a symlink, QFile::link will refuse

D25303: Expose KDescendantsProxyModel to QML

davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REPOSITORY R275 KItemModels BRANCH master REVISION DETAIL https://phabricator.kde.org/D25303 AFFECTED FILES