D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

davidedmundson updated this revision to Diff 69918. davidedmundson marked 3 inline comments as done. davidedmundson added a comment. asdf REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25326?vs=69917=69918 BRANCH master REVISION DETAIL

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.12 - Build # 67 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.12/67/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 18 Nov 2019 09:54:19 + Build duration: 2 min 20 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.13 - Build # 44 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.13/44/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 18 Nov 2019 09:54:19 + Build duration: 2 min 16 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kitemmodels » kf5-qt5 FreeBSDQt5.13 - Build # 41 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20FreeBSDQt5.13/41/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 18 Nov 2019 09:54:19 + Build duration: 1 min 37 sec and counting JUnit Tests Name:

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

davidedmundson marked 3 inline comments as done. davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in sortfiltermodel.cpp:84 > Can we also just have it send `source_row` and `source_parent` since we have > proper `QModelIndex` handling now? We could. Though means everyone

D20261: Fix Plasma themes' quassel icon to match current quassel icon names

zzag added a comment. In D20261#443859 , @broulik wrote: > This is a bug in Quassel, a violation of the FDO spec, it should have ebeen `quassel-tray-inactive` or something See https://github.com/quassel/quassel/pull/515 REPOSITORY

D25364: KNumberModel: gracefully handle a stepSize of 0

kossebau created this revision. kossebau added reviewers: Frameworks, davidedmundson, vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY While setting a stepSize of 0 is undefined in the API

D25364: KNumberModel: gracefully handle a stepSize of 0

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R275 KItemModels BRANCH knumbermodelhandlestepsizezero REVISION DETAIL https://phabricator.kde.org/D25364 To: kossebau, #frameworks, davidedmundson, vkrause Cc: kde-frameworks-devel,

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in sortfiltermodel.h:43 > It's not listed in https://doc.qt.io/qt-5/qtqml-cppintegration-data.html > > We need to test Bummer. I tried, a JS `RegExp` (both `new RegExp()` and `/literal syntax/`) get turned into a `QRegExp`.

D25360: Conditionally set SH_ScrollBar_LeftClickAbsolutePosition based on kdeglobals setting

broulik added inline comments. INLINE COMMENTS > kstyle.cpp:504 > +KConfigGroup g(KSharedConfig::openConfig(), "KDE"); > +return !g.readEntry("LeftClickNavigatesByPage", true); > +} `ScrollBarLeftClick...`? REPOSITORY R252 Framework Integration REVISION DETAIL

D25331: Duplicate QML installation for unit tests

This revision was automatically updated to reflect the committed changes. Closed by commit R275:6b05ca4afbda: Duplicate QML installation for unit tests (authored by davidedmundson). REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25331?vs=69896=69911

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

sitter added inline comments. INLINE COMMENTS > feverfew wrote in krun.cpp:598 > That's within the same loop though? > > I explicitly want to change the QUrl in that list, so that I can simply > return the same list without having to do a copy of it all. > > I can't get this to work. I need

KDE CI: Frameworks » kitemmodels » kf5-qt5 FreeBSDQt5.13 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20FreeBSDQt5.13/40/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 18 Nov 2019 08:59:48 + Build duration: 2 min 46 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.13 - Build # 43 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.13/43/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 18 Nov 2019 08:59:48 + Build duration: 3 min 21 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kitemmodels » kf5-qt5 SUSEQt5.12 - Build # 66 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20SUSEQt5.12/66/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 18 Nov 2019 08:59:48 + Build duration: 4 min 10 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kitemmodels » kf5-qt5 WindowsMSVCQt5.13 - Build # 31 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kitemmodels/job/kf5-qt5%20WindowsMSVCQt5.13/31/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 18 Nov 2019 09:54:19 + Build duration: 6 min 46 sec and counting JUnit Tests

D25364: KNumberModel: gracefully handle a stepSize of 0

This revision was automatically updated to reflect the committed changes. Closed by commit R275:13a039441fdb: KNumberModel: gracefully handle a stepSize of 0 (authored by kossebau). REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25364?vs=69909=69916

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

davidedmundson updated this revision to Diff 69917. davidedmundson edited the summary of this revision. davidedmundson added a comment. Only some changes done, not all Updating now to share added unit test REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

davidedmundson marked an inline comment as done. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D25326 To: davidedmundson Cc: broulik, ahiemstra, mart, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25355: [Samba] Improve warning message about netbios name

meven updated this revision to Diff 69921. meven added a comment. Improve reliability REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25355?vs=69878=69921 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25355 AFFECTED FILES

D25223: Avoid side effects during menu initialization

This revision was automatically updated to reflect the committed changes. Closed by commit R135:3c78453b: Avoid side effects during menu initialization (authored by kmaterka). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 186 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/186/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 18 Nov 2019 13:10:10 + Build duration: 10 min and counting JUnit Tests Name: projectroot

D25355: [Samba] Improve warning message about netbios name

This revision was automatically updated to reflect the committed changes. Closed by commit R241:3874f9f8a4b7: [Samba] Improve warning message about netbios name (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25355?vs=69921=69923 REVISION

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/28/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 18 Nov 2019 13:28:35 + Build duration: 1 min 38 sec and counting JUnit Tests Name:

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in sortfiltermodel.h:78 > > presumably for some reason. > > Either because someone was too lazy to use the respective property on the > `Repeater` or `ListView` or before `rowCount()` was `Q_INVOKABLE`. Not sure > it's

D25223: Avoid side effects during menu initialization

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D25223 To: kmaterka, #plasma, #frameworks, broulik Cc: nicolasfella, davidedmundson,

D25360: Conditionally set SH_ScrollBar_LeftClickAbsolutePosition based on kdeglobals setting

ngraham updated this revision to Diff 69932. ngraham marked an inline comment as done. ngraham added a comment. Improve config file entry name REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25360?vs=69898=69932 BRANCH

D25328: Always rehiglhight() after definition was changed

meven added a comment. In D25328#563637 , @cullmann wrote: > Hmm, the use case is that it re-highlights if you set an invalid definition? Here it rehighlight if the definition has changed `definition() != def`. But since the current

D25371: Remove porting scaffolding, this is entirely on QSslError now

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25371 AFFECTED FILES

D25371: Remove porting scaffolding, this is entirely on QSslError now

vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25371 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25149: Add a new template for KCMs

tcanabrava updated this revision to Diff 69941. tcanabrava marked an inline comment as done. tcanabrava added a comment. - Adapt to ManagedConfigModule REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25149?vs=69649=69941 BRANCH

D25149: Add a new template for KCMs

tcanabrava updated this revision to Diff 69942. tcanabrava added a comment. - Handle immutability REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25149?vs=69941=69942 BRANCH arcpatch-D25149 REVISION DETAIL

D25371: Remove porting scaffolding, this is entirely on QSslError now

aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25371 To: vkrause, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 318 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/318/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 19 Nov 2019 04:29:49 + Build duration: 15 min and counting BUILD ARTIFACTS

D25389: Verify modes of the session config file

nibags edited the summary of this revision. nibags edited the test plan for this revision. nibags added reviewers: KTextEditor, cullmann, dhaumann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D25389 To: nibags, #ktexteditor, cullmann, dhaumann Cc: kwrite-devel,

D25390: KateModeManager::updateFileType(): validate modes and reload menu of the status bar

nibags created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REPOSITORY R39 KTextEditor BRANCH verify-katefiletypes REVISION DETAIL https://phabricator.kde.org/D25390

D25389: Verify modes of the session config file

nibags created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REPOSITORY R39 KTextEditor BRANCH verify-session-modes REVISION DETAIL https://phabricator.kde.org/D25389

D25390: KateModeManager::updateFileType(): validate modes and reload menu of the status bar

nibags edited the summary of this revision. nibags added reviewers: KTextEditor, cullmann, dhaumann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D25390 To: nibags, #ktexteditor, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson,

D25390: KateModeManager::updateFileType(): validate modes and reload menu of the status bar

nibags updated this revision to Diff 69971. nibags added a comment. - Fix format REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25390?vs=69970=69971 BRANCH verify-katefiletypes REVISION DETAIL https://phabricator.kde.org/D25390 AFFECTED FILES

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 187 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/187/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 19 Nov 2019 04:29:49 + Build duration: 13 min and counting JUnit Tests Name: projectroot

D25388: Make constructor explicit and cleanup QWebPluginFactory #include.

jhayes created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jhayes requested review of this revision. REPOSITORY R300 KDEWebKit BRANCH master REVISION DETAIL https://phabricator.kde.org/D25388 AFFECTED FILES src/kwebpluginfactory.h