D24046: Allow triggering sort from QML

broulik added inline comments. INLINE COMMENTS > personssortfilterproxymodel.h:53 > bool filterAcceptsRow(int source_row, const QModelIndex _parent) > const override; > +Q_INVOKABLE void sortNow(); > Can you just forward the entire thing: Q_INVOKABLE void sort(int column,

D25485: Remove KIconThemes use

This revision was automatically updated to reflect the committed changes. Closed by commit R39:c7d64230aa34: Remove KIconThemes use (authored by broulik). Herald added a project: Kate. Herald added a subscriber: kwrite-devel. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D25015: Update breeze theme shadows

niccolove added a comment. F7780181: image.png I just can't get the padding right on angles when changing their size. What size should I change of the colored rectangles? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D24884: I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)

dfaure added a comment. I don't exactly mind if we resurrect NOOP2 or rename it to STRIP, but STRIP kind of makes sense because the name explicitly says something is being stripped (and the documentation should warn loudly about the risks of doing that). It's a better name than "2" where

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 201 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/201/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 23 Nov 2019 13:52:43 + Build duration: 7 min 36 sec and counting JUnit Tests Name:

D25491: Remove kdeinit dependency from kded.

dfaure created this revision. dfaure added reviewers: mart, cordlandwehr. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY Just make it a normal executable. REPOSITORY R297 KDED BRANCH master

D24046: Allow triggering sort from QML

broulik added inline comments. INLINE COMMENTS > broulik wrote in personssortfilterproxymodel.h:53 > ... which people say is ABI-compatible "You can ... reimplement virtual functions defined in the primary base class hierarchy (that is, virtuals defined in the first non-virtual base class, or

D24046: Allow triggering sort from QML

broulik added inline comments. INLINE COMMENTS > broulik wrote in personssortfilterproxymodel.h:53 > Can you just forward the entire thing: > > Q_INVOKABLE void sort(int column, Qt::SortOrder order = Qt::AscendingOrder) > override; ... which people say is ABI-compatible REPOSITORY R307

D25485: Remove KIconThemes use

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D25485 To: broulik, #frameworks, cullmann Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25485: Remove KIconThemes use

broulik created this revision. broulik added reviewers: Frameworks, cullmann. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It was effectively unused. TEST PLAN - help button on the variable

D25485: Remove KIconThemes use

dhaumann added a comment. Makes sense, thanks. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D25485 To: broulik, #frameworks, cullmann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars

D24884: Provide I18NC_NOOP_STRIP as a new name for the deprecated I18N_NOOP2

dfaure updated this revision to Diff 70212. dfaure retitled this revision from "I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)" to "Provide I18NC_NOOP_STRIP as a new name for the deprecated I18N_NOOP2". dfaure edited the summary of

D24884: Provide I18NC_NOOP_STRIP as a new name for the deprecated I18N_NOOP2

dfaure commandeered this revision. dfaure edited reviewers, added: mlaurent; removed: dfaure. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D24884 To: dfaure, ilic, aacid, mlaurent Cc: kossebau, aacid, vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 215 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/215/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 23 Nov 2019 13:35:59 + Build duration: 22 min and counting BUILD ARTIFACTS

D25490: Remove legacy plugin loading code

nicolasfella updated this revision to Diff 70219. nicolasfella added a comment. - Remove REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25490?vs=70218=70219 BRANCH service REVISION DETAIL https://phabricator.kde.org/D25490 AFFECTED FILES

D25448: EBN cleanup of autotests transfer protocol

jhayes updated this revision to Diff 70220. jhayes retitled this revision from "EBN cleanup of autests transfer protocol" to "EBN cleanup of autotests transfer protocol". jhayes added a comment. Corrected summary typo REPOSITORY R267 Oxygen Icons CHANGES SINCE LAST UPDATE

D25492: Remove a redundant check

waqar created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. waqar requested review of this revision. REVISION SUMMARY Removed a redundant check from textbreaks.cpp REPOSITORY R246 Sonnet BRANCH perf (branched from master) REVISION

D25340: Added background colors to active and inactive icon view

niccolove updated this revision to Diff 70207. niccolove added a comment. Changed opacity of inactive vs non-visible application background color REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25340?vs=69882=70207 BRANCH

D25489: Deprecate KonqBookmarkMenu and KonqBookmarkContextMenu

dfaure created this revision. dfaure added reviewers: vkrause, kossebau. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY I copied them into Konqueror (the only user), after adding namespacing there

D25489: Deprecate KonqBookmarkMenu and KonqBookmarkContextMenu

dfaure updated this revision to Diff 70210. dfaure added a comment. Oops the next version is 65, not 64. You'd think *I* would know that... :-) Yes I did mean "next version", I just picked the wrong number. REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE

KF6 Blogs

Hi everyone, could you who currently are at the KF6 sprint blog a bit more? Even if it's just about small details like "app X does not depend on Y anymore and this is how we got rid of the dependency" already is valuable information, since it helps other contributors to not introduce such code

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 332 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/332/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 23 Nov 2019 13:54:40 + Build duration: 7 min 9 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 216 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/216/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 23 Nov 2019 13:58:05 + Build duration: 6 min 40 sec and counting BUILD ARTIFACTS

D25334: Added transparent blue background to tabbars

niccolove added a comment. F7780227: Screenshot_20191123_130602.png I'm sorry, isn't this right? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25334 To: niccolove, #vdg, ngraham, ndavis Cc: ngraham,

D25340: Added background colors to active and inactive icon view

niccolove added a comment. > Might be too subtle, maybe more opacity would be needed This should have a 13% vs 23% opacity, what do you think? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove, #vdg, ngraham Cc: manueljlin,

D17595: Upstream Dolphin's file rename dialog

meven updated this revision to Diff 70224. meven added a comment. Update copyright/licensing, update @since, add a TODO KF6 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17595?vs=63895=70224 BRANCH arcpatch-D17595_1 REVISION DETAIL

D7010: KSqueezedTextLabel: call updateGeometry() when text changes

dfaure added a comment. @cfeck Can you review this again? I guess this could be improved with `if (text == d->fullText) return;` but the patch is already an improvement as is. REVISION DETAIL https://phabricator.kde.org/D7010 To: brauch, cfeck, dfaure Cc: rkflx, dfaure, dhaumann,

Re: KInit - Current state and benchmarks

On Mittwoch, 19. Juni 2019 19:57:56 CET Albert Astals Cid wrote: > El dimarts, 18 de juny de 2019, a les 12:04:38 CEST, David Edmundson va escriure: > > > Are we sure it's fair to assume people have SSD? our of the 4 laptops i > > > own, only 2 have SSD.> > > It's at least safe to assume it's

D25489: Deprecate KonqBookmarkMenu and KonqBookmarkContextMenu

kossebau added a comment. That should be upcoming 5.65 here though, not 5.64. Moving things into visibility-protection guards of recent versions will break things for people who used DISABLE_DEPRECATED_BEFORE_AND_AT after having properly checked their source is properly building against

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 331 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/331/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 23 Nov 2019 13:35:59 + Build duration: 18 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 200 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/200/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 23 Nov 2019 13:35:59 + Build duration: 16 min and counting JUnit Tests Name: projectroot

D25490: Remove legacy plugin loading code

nicolasfella created this revision. nicolasfella added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY All plugins (even ktp) use the proper system now. This allows to get rid

D24884: Provide I18NC_NOOP_STRIP as a new name for the deprecated I18N_NOOP2

aacid added a comment. As mentioned i don't see the point. Doint this won't work, since needs an associated change in scripty, just undeprecated NOOP2 if you'll agree that this is what you want REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D24884 To: dfaure,

D24884: Provide I18NC_NOOP_STRIP as a new name for the deprecated I18N_NOOP2

dfaure added a comment. OK, to avoid having to change scripty, I'll stick to the 2 name. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D24884 To: dfaure, ilic, aacid, mlaurent Cc: kossebau, aacid, vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D24884: Undeprecate I18N_NOOP2

dfaure updated this revision to Diff 70234. dfaure retitled this revision from "Provide I18NC_NOOP_STRIP as a new name for the deprecated I18N_NOOP2" to "Undeprecate I18N_NOOP2". dfaure added a comment. keep old macro name REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE

D25495: Fix Sonnet autodetect failing on Indian langs

waqar edited the summary of this revision. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25495 To: waqar Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25492: Remove a redundant check

ngraham added a reviewer: broulik. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25492 To: waqar, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25495: Fix Sonnet autodetect failing on Indian langs

waqar created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. waqar requested review of this revision. REVISION SUMMARY Fixes Bug 176537. Sonnet fails to autodetect a language if there are no trigrams available for the language. In some

D25432: Fix HTTP proxy settings

dfaure added a comment. This doesn't appear to fix the bug for me. I get a stringlist with one empty string in it, which goes to the "else" branch on line 2712. This is very probably the reason for the ftp and http tests being broken in CI too. I'll a SkipEmptyParts to the split(),

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 202 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/202/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 23 Nov 2019 19:12:05 + Build duration: 7 min 49 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 217 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/217/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 23 Nov 2019 19:12:05 + Build duration: 2 hr 16 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 334 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/334/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 23 Nov 2019 22:08:37 + Build duration: 13 min and counting BUILD ARTIFACTS

D25489: Deprecate KonqBookmarkMenu and KonqBookmarkContextMenu

kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. Seems fine by pure patch reading. INLINE COMMENTS > konqbookmarkmenu.h:51 > * @param collec parent collection for the KActions. > */ > +KBOOKMARKS_DEPRECATED_VERSION(5,

KDE CI: Frameworks » kparts » kf5-qt5 SUSEQt5.12 - Build # 65 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20SUSEQt5.12/65/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 23 Nov 2019 20:48:25 + Build duration: 15 min and counting CONSOLE OUTPUT [...truncated 450

KDE CI: Frameworks » kparts » kf5-qt5 SUSEQt5.12 - Build # 66 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kparts/job/kf5-qt5%20SUSEQt5.12/66/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 23 Nov 2019 21:45:03 + Build duration: 4 min 41 sec and counting BUILD ARTIFACTS

D25493: EBN kmoretools cleanup transport protocol

jhayes created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jhayes requested review of this revision. REVISION SUMMARY Cleanup of kmoretools tranport protocol from http to https REPOSITORY R304 KNewStuff BRANCH ebn-cleanup (branched

D25495: Fix Sonnet autodetect failing on Indian langs

waqar updated this revision to Diff 70238. waqar edited the summary of this revision. waqar added a comment. Fix Sonnet autodetect completely failing when no trigrams found REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25495?vs=70237=70238 BRANCH

D25432: Fix HTTP proxy settings

dfaure added a comment. Done in https://commits.kde.org/kio/48b8cab8da5e264f233d59cf2aff2b981255f6bf Please check if other places are affected. This code could be simplified by using `configValue()` instead, no? Right now the QString() argument serves no purpose, it gets converted

D25334: Added transparent blue background to tabbars

ndavis added a comment. In D25334#566524 , @niccolove wrote: > F7780227: Screenshot_20191123_130602.png > I'm sorry, isn't this right? > The top one was like that before, and I just edited the bottom

D25058: Add KAboutPluginDialog, to be used with KPluginMetaData

dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kaboutapplicationdialog.cpp:72 > q->setWindowTitle(i18n("About %1", aboutData.displayName())); > q->setModal(false); > (this line does nothing, dialogs

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 333 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/333/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 23 Nov 2019 19:12:05 + Build duration: 1 hr 44 min and counting CONSOLE OUTPUT [...truncated 2930

D25340: Added background colors to active and inactive icon view

ndavis added a comment. In that case, maybe 5% opacity for minimized? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove, #vdg, ngraham Cc: manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D25340: Added background colors to active and inactive icon view

ngraham added a comment. I can accept this as-is, but I think I'd still prefer the background color of minimized apps/windows to be a bit lighter or more transparent. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25340 To: niccolove, #vdg,

D25495: Fix Sonnet autodetect failing on Indian langs

cullmann added a reviewer: mludwig. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25495 To: waqar, mludwig Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 33 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/33/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 24 Nov 2019 00:31:45 + Build duration: 1 min 0 sec and counting CONSOLE OUTPUT

D25493: EBN kmoretools cleanup transport protocol

dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH ebn-cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D25493 To: jhayes, dhaumann Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D25489: Deprecate KonqBookmarkMenu and KonqBookmarkContextMenu

dfaure added a comment. I doubt anyone will read that docu, but sure, done :-) REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D25489 To: dfaure, vkrause, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25489: Deprecate KonqBookmarkMenu and KonqBookmarkContextMenu

dfaure closed this revision. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D25489 To: dfaure, vkrause, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25500: Remove dependency on QtWidgets

meven created this revision. meven added reviewers: mart, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Remove unnecessary dependency on QtWidgets. It should allow the kde daemons to

D25500: Remove dependency on QtWidgets

meven planned changes to this revision. meven added a comment. In D25500#566823 , @broulik wrote: > -1 There's UI shown by kded, like network manager prompts and other bits. Also, some bits probably need windowing capabilities. > Certainly

D25495: Fix Sonnet autodetect failing on Indian langs

waqar edited the summary of this revision. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25495 To: waqar, mludwig Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25500: Remove dependency on QtWidgets

broulik added a comment. -1 There's UI shown by kded, like network manager prompts and other bits. Also, some bits probably need windowing capabilities. Certainly something to look into (e.g. use `QGuiApplication` and turn off platform awareness) but not something we can "just" do in a

D17595: Upstream Dolphin's file rename dialog

dhaumann added a comment. In D17595#542142 , @meven wrote: > I received the agreements of all contributors including the original code author, to relicense this code and hence upstream it. Playing the bad guy here: where are these