D25546: Deprecate KRecursiveFilterProxyModel

This revision was automatically updated to reflect the committed changes. Closed by commit R275:68f3b292ca03: Deprecate KRecursiveFilterProxyModel (authored by davidre). REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25546?vs=70426=70479 REVISION DETAIL

D25590: support for user removing background and automatic shadow

davidedmundson added a comment. That ended up quite nice in the end ++ INLINE COMMENTS > appletinterface.cpp:414 > emit backgroundHintsChanged(); > +if (!m_userBackgroundHintsInitialized || !(m_backgroundHints & > Plasma::Types::ConfigurableBackground)) { > +emit

D25590: support for user removing background and automatic shadow

ndavis added inline comments. INLINE COMMENTS > davidedmundson wrote in configuration-icons.svg:17 > @ndavis can you review this icon change please I couldn't see any issues in the SVG code. @mart Where is `showbackground` used in the UI so that I can test it? REPOSITORY R242 Plasma

D25530: Sonnet: Add locales that are missing in QLocale

aacid added a comment. In D25530#568705 , @waqar wrote: > Can you give examples of places where an iso_code (cv_RU) could pop up? KLanguageButton does iso code to lang name translation

D25605: Port to QRegularExpression

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port to QRegularExpression REPOSITORY R243 KArchive BRANCH port_to_qregularexpression (branched from master)

D25605: Port to QRegularExpression

mlaurent added a reviewer: dfaure. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D25605 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 63 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/63/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 29 Nov 2019 06:14:08 + Build duration: 2 min 51 sec and counting JUnit Tests Name:

D25590: support for user removing background and automatic shadow

mart edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25590 To: mart, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25572: [KFileWidget] Allow double quotes in filenames

meven updated this revision to Diff 70489. meven added a comment. Clean include, update comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25572?vs=70442=70489 BRANCH arcpatch-D25572 REVISION DETAIL https://phabricator.kde.org/D25572 AFFECTED FILES

D25590: support for user removing background and automatic shadow

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY add the ability for the user to override the background hints anddecide about applets having

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

kossebau added a comment. In D24990#564667 , @kossebau wrote: > Hm, only noticed now that this actually has an unwanted sideeffects: it triggers deprecation warnings for all deprecated warning also inside each library itself. Which is not what

D25590: support for user removing background and automatic shadow

mart added a dependent revision: D25591: support for the shadow and effectiveBackgroundhints. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25590 To: mart, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25590: support for user removing background and automatic shadow

mart added a dependent revision: D25592: handle action for custom shadow background hint. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25590 To: mart, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25590: support for user removing background and automatic shadow

mart added inline comments. INLINE COMMENTS > plasma.h:285 > +ImmutableBackground = 8, /** The user shouldn't have the possibility > to */ > DefaultBackground = StandardBackground /**< Default settings: both > standard background */ > }; DefaultBackground should be

D25572: [KFileWidget] Allow double quotes in filenames

meven updated this revision to Diff 70499. meven added a comment. Avoid using unnecessarly QRegularExpression REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25572?vs=70490=70499 BRANCH arcpatch-D25572 REVISION DETAIL https://phabricator.kde.org/D25572

D25015: Update breeze theme shadows

niccolove added a comment. Got it. The shape is actually rounded BUT the desktop contract effect is applied in the whole rectangle underneath, and it makes everything look like a rectangle. Here's the widget with fully transparent background, but with the contract effect on: F7788618:

D25583: Quit baloo_file_extractor if DB transaction fails

meven added inline comments. INLINE COMMENTS > app.cpp:145 > +} else { > +QCoreApplication::quit(); > +} Add a Warning/log message ? `qCWarning(BALOO) << "Could not save data to DB"` or similar REPOSITORY R293 Baloo REVISION DETAIL

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/44/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 28 Nov 2019 10:58:23 + Build duration: 3 min 49 sec and counting JUnit Tests

D25585: Fix i18n syntax to avoid runtime errors

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. ...wow, ok, right, that's a fun bit of api difference right there ;) Thanks for those! REPOSITORY R304 KNewStuff BRANCH fix-i18n-usage (branched from master) REVISION DETAIL

D25572: [KFileWidget] Allow double quotes in filenames

meven updated this revision to Diff 70490. meven added a comment. Add comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25572?vs=70489=70490 BRANCH arcpatch-D25572 REVISION DETAIL https://phabricator.kde.org/D25572 AFFECTED FILES

D25583: Quit baloo_file_extractor if DB transaction fails

davidedmundson added inline comments. INLINE COMMENTS > meven wrote in app.cpp:145 > Add a Warning/log message ? `qCWarning(BALOO) << "Could not save data to DB"` > or similar There's a tonne in the transaction code REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25583

D25583: Quit baloo_file_extractor if DB transaction fails

meven added inline comments. INLINE COMMENTS > davidedmundson wrote in app.cpp:145 > There's a tonne in the transaction code Alright but since the program exits here, I am concerned it may not be clear enough to the user/caller as to why it exited ? Adding a log here will add a different

D25575: remove unused kgesturemap from kaction

This revision was automatically updated to reflect the committed changes. Closed by commit R239:d09cd978559c: remove unused kgesturemap from kaction (authored by davidedmundson). REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25575?vs=70454=70487

D25583: Quit baloo_file_extractor if DB transaction fails

davidedmundson updated this revision to Diff 70488. davidedmundson added a comment. New output: _TXN: Transaction must abort, has a child, or is invalid 12:35:09.167 org.kde.baloo.engine: Baloo::PositionDB::put|Baloo::WriteTransaction::commit|Baloo::Transaction::commit PositionDB::put

D25589: ECMGenerateExportHeader: add NO_BUILD_SET_DEPRECATED_WARNINGS_SINCE flag

kossebau created this revision. kossebau added reviewers: Build System, Frameworks, dfaure. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY The original intention has

D25590: support for user removing background and automatic shadow

mart updated this revision to Diff 70513. mart added a comment. - ImmutableBackground->configurableBackground REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25590?vs=70503=70513 BRANCH mart/effectiveBackgroundHints REVISION DETAIL

D25599: Fix plugin-metadata translations on windows

sars created this revision. sars added a project: Windows. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sars requested review of this revision. REVISION SUMMARY On Windows, the plugin metadata always follows the current region setting and any language

D24884: Undeprecate I18N_NOOP2

This revision was automatically updated to reflect the committed changes. Closed by commit R249:64862a642ddd: Undeprecate I18N_NOOP2 (authored by dfaure). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24884?vs=70234=70519 REVISION DETAIL

D25572: [KFileWidget] Allow double quotes in filenames

meven added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25572 To: meven, #frameworks, ngraham, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 45 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/45/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 28 Nov 2019 17:48:38 + Build duration: 3 min 31 sec and counting JUnit Tests

D25590: support for user removing background and automatic shadow

davidedmundson added subscribers: ndavis, davidedmundson. davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > colorscope.cpp:52 > > -QQuickItem *parentItem = qobject_cast(parentObject); >

D25590: support for user removing background and automatic shadow

mart updated this revision to Diff 70503. mart marked 3 inline comments as done. mart added a comment. - adress comments REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25590?vs=70496=70503 BRANCH mart/effectiveBackgroundHints

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 70522. meven added a comment. Rebasing REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=70521=70522 BRANCH arcpatch-D25010_1 REVISION DETAIL https://phabricator.kde.org/D25010 AFFECTED FILES

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 70521. meven added a comment. Lower the amount of data pulled by directory size job (avoids resolving symlinks notably) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=70088=70521 BRANCH arcpatch-D25010_1

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > dfaure wrote in directorysizejob.cpp:137 > Now that I look at this again, we do NOT want to follow symlinks here. > > This was a bug in the existing code. > > In Dolphin we want to display the size of the

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven marked 5 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

dfaure added inline comments. INLINE COMMENTS > meven wrote in directorysizejob.cpp:137 > The previous code did (details of 3) I'm confused by what you mean here... and I think I found more problems: Indeed the old code used 3. In your patch, you changed this to 2, in the legacy field for old