D25583: Quit baloo_file_extractor if DB transaction fails

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D25583 To: davidedmundson, bruns, ngraham Cc: meven, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n,

D21769: Use directory listing qmldir format for private modules used by dir import

kossebau abandoned this revision. kossebau added a comment. Seems there is no interest. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D21769 To: kossebau, #plasma, mart Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23550: CMake config files: use as min dep version the Qt version we built against

kossebau added a comment. ping :) No-one any opinion? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23550 To: kossebau, #frameworks, #build_system Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25620: Register ActionType enum with metaobject system

jbbgameich created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jbbgameich requested review of this revision. REPOSITORY R307 KPeople BRANCH actions-meta-enum (branched from master) REVISION DETAIL https://phabricator.kde.org/D25620

D25620: Register ActionType enum with metaobject system

jbbgameich added a reviewer: apol. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D25620 To: jbbgameich, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25622: partial solution to accept accentuated characters on windows

bruns added a reviewer: Windows. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25622 To: mgallien, bruns, #windows Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,

D15318: Automatically re-upload saved files located on remote locations instead of asking first

ngraham abandoned this revision. ngraham added a comment. This is rendered moot by the far superior FUSE-based solution at D23384 ! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15318 To: ngraham, #frameworks, broulik, jtamate Cc:

D16770: [ftp kio-slave] Fix deletion of directory with non-latin1/utf8 parent path

kossebau abandoned this revision. kossebau added a comment. Solved by D24349 meanwhile in the same way. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16770 To: kossebau, dfaure Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2,

KDE CI: Frameworks » kquickcharts » kf5-qt5 SUSEQt5.13 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20SUSEQt5.13/1/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 29 Nov 2019 19:13:15 + Build duration: 1 min 35 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kquickcharts » kf5-qt5 SUSEQt5.12 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20SUSEQt5.12/1/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 29 Nov 2019 19:13:12 + Build duration: 1 min 18 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kquickcharts » kf5-qt5 FreeBSDQt5.13 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20FreeBSDQt5.13/1/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 29 Nov 2019 19:13:09 + Build duration: 45 sec and counting JUnit Tests Name:

D25622: partial solution to accept accentuated characters on windows

mgallien added a reviewer: bruns. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25622 To: mgallien, bruns Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D25622: partial solution to accept accentuated characters on windows

mgallien created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. mgallien requested review of this revision. REVISION SUMMARY If filename contains accentuated characters, taglib fails to open it on windows if the QString is

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, dfaure, ngraham Cc: sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns

D23550: CMake config files: use as min dep version the Qt version we built against

kossebau added a comment. In D23550#569552 , @cgiboudeaux wrote: > In D23550#569485 , @kossebau wrote: > > > ping :) No-one any opinion? > > > Sure :) > -1. The Config file is supposed to

D25583: Quit baloo_file_extractor if DB transaction fails

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Please allow some time for reviewing ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25583 To: davidedmundson, bruns, ngraham Cc: meven,

D25572: [KFileWidget] Allow double quotes in filenames

ngraham added a comment. This isn't working for me. When I create a file named `"foobar".txt`, the file dialog is still unable to open it, saying: > The file "/home/nate/Desktop/Foobar" could not be found INLINE COMMENTS > kfilewidgettest_saving_gui.cpp:31 > KFileWidget*

D19939: Avoid failing installation via temporary dir due to file name clashes

kossebau abandoned this revision. kossebau added a comment. Not having looked more at this for some months, and will not do in foreseeable future, so abandoning to clean up stack. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D19939 To: kossebau, #frameworks,

[sysadmin/repo-metadata] projects/frameworks/kquickcharts: Move KQuickCharts into Frameworks.

Git commit 81bc7c68537639a739d0f89f103a1c26b61d by Ben Cooksley. Committed on 29/11/2019 at 18:49. Pushed by bcooksley into branch 'master'. Move KQuickCharts into Frameworks. Ref T12022 CCMAIL: kde-frameworks-devel@kde.org CCMAIL: kde-core-de...@kde.org R +0-0

D23550: CMake config files: use as min dep version the Qt version we built against

cgiboudeaux added a comment. In D23550#569485 , @kossebau wrote: > ping :) No-one any opinion? Sure :) -1. The Config file is supposed to look for the lowest supported version. REPOSITORY R244 KCoreAddons REVISION DETAIL

D23550: CMake config files: use as min dep version the Qt version we built against

cgiboudeaux added a comment. In D23550#569554 , @kossebau wrote: > In D23550#569552 , @cgiboudeaux wrote: > > > In D23550#569485 , @kossebau wrote: > >

D23550: CMake config files: use as min dep version the Qt version we built against

kossebau added a comment. Just, the built binary no longer has that theoretical minimum dependency, it needs at least the Qt version the very instance of kcoreaddons was built against. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23550 To: kossebau,

D25583: Quit baloo_file_extractor if DB transaction fails

davidedmundson added a comment. Ack, was going to wait for you :) REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D25583 To: davidedmundson, bruns, ngraham Cc: meven, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson,

KDE CI: Frameworks » kquickcharts » kf5-qt5 WindowsMSVCQt5.13 - Build # 1 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kquickcharts/job/kf5-qt5%20WindowsMSVCQt5.13/1/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Fri, 29 Nov 2019 19:13:18 + Build duration: 2 min 10 sec and counting JUnit Tests

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. I tested this today with a variety of files on a Windows Samba share with fairly slow 6 Mb/sec bandwidth and it's almost perfect for all files and use cases. However I ran into

D25015: Update breeze theme shadows

ngraham added subscribers: broulik, mart. ngraham added a comment. So I guess we can either fix the Background Contrast effect, or stop using it and do the opacity entirely within the Plasma Breeze theme (e.g. by bumping it up from 0.6 to 0.9 or 0.95 or so). Probably needs #plasma

D25530: Sonnet: Add locales that are missing in QLocale

waqar added a comment. Yes, I think so too. @aacid thank you for your patience and guidance. Should I withdraw this or wait for further review? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25530 To: waqar Cc: cullmann, aspotashev, aacid, yurchor,

D12164: Add overloads to Value/Unit::toString/toSymbolString taking a QLocale

kossebau abandoned this revision. kossebau added a comment. Sadly lost track of things, and no plans to look soon again at it, so cleaning up from stack for now. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D12164 To: kossebau, ilic Cc: aacid,

D25590: support for user removing background and automatic shadow

mart added inline comments. INLINE COMMENTS > ndavis wrote in configuration-icons.svg:17 > I couldn't see any issues in the SVG code. @mart Where is `showbackground` > used in the UI so that I can test it? in the patch, it adds a new icon in the handle, tough you need this plus D25591

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

meven updated this revision to Diff 70543. meven added a comment. Do not forget to get UDS_DEVICE_ID UDS_INODE REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25010?vs=70522=70543 BRANCH arcpatch-D25010 REVISION DETAIL https://phabricator.kde.org/D25010

D25590: support for user removing background and automatic shadow

mart updated this revision to Diff 70544. mart added a comment. - better effectiveBackgroundHints comparizon REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25590?vs=70513=70544 BRANCH mart/effectiveBackgroundHints REVISION DETAIL

D25590: support for user removing background and automatic shadow

mart marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25590 To: mart, #plasma, davidedmundson Cc: davidedmundson, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25530: Sonnet: Add locales that are missing in QLocale

cullmann added a comment. I am with Albert, that we better improve what Qt has instead of replicating this here. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25530 To: waqar Cc: cullmann, aspotashev, aacid, yurchor, kde-frameworks-devel, LeGast00n, GB_2,

D25590: support for user removing background and automatic shadow

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH mart/effectiveBackgroundHints REVISION DETAIL https://phabricator.kde.org/D25590 To: mart, #plasma, davidedmundson Cc: davidedmundson, ndavis,

D25605: Port to QRegularExpression

This revision was automatically updated to reflect the committed changes. Closed by commit R243:25070fcdff6c: Port to QRegularExpression (authored by mlaurent). REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25605?vs=70538=70565 REVISION DETAIL

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 23 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/23/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 29 Nov 2019 12:56:43 + Build duration: 1 min 8 sec and counting JUnit Tests Name:

D25585: Fix i18n syntax to avoid runtime errors

This revision was automatically updated to reflect the committed changes. Closed by commit R304:dd5c9d461d86: Fix i18n syntax to avoid runtime errors (authored by ngraham). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25585?vs=70475=70566 REVISION DETAIL

D25590: support for user removing background and automatic shadow

This revision was automatically updated to reflect the committed changes. Closed by commit R242:57fdb5679081: support for user removing background and automatic shadow (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D25605: Port to QRegularExpression

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R243 KArchive BRANCH port_to_qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D25605 To: mlaurent, dfaure, apol Cc: apol,

D25451: [KCMultiDialog] Remove most special margins handling; it's done in KPageDialog now

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH fix-margins (branched from master) REVISION DETAIL https://phabricator.kde.org/D25451 To: ngraham, #frameworks, mart, cfeck Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25444: Unify KPageDialog margin handling into KPageDialog itself

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH fix-assistant-dialog-margins (branched from master) REVISION DETAIL https://phabricator.kde.org/D25444 To: ngraham, #frameworks, cfeck, mart Cc: kossebau,

D25451: [KCMultiDialog] Remove most special margins handling; it's done in KPageDialog now

This revision was automatically updated to reflect the committed changes. Closed by commit R295:0ca212481fab: [KCMultiDialog] Remove most special margins handling; its done in KPageDialog… (authored by ngraham). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE

D25444: Unify KPageDialog margin handling into KPageDialog itself

This revision was automatically updated to reflect the committed changes. Closed by commit R236:969ec7f2e964: Unify KPageDialog margin handling into KPageDialog itself (authored by ngraham). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

feverfew edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, dfaure, ngraham Cc: sitter, davidedmundson, kde-frameworks-devel, ngraham, LeGast00n, GB_2, michaelh, bruns

D25360: Conditionally set SH_ScrollBar_LeftClickAbsolutePosition based on kdeglobals setting

ngraham edited the test plan for this revision. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D25360 To: ngraham, #frameworks, #plasma Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns