This revision was automatically updated to reflect the committed changes.
Closed by commit R39:92e5b0b9aac0: Avoid unwanted horizontal scrolling
(authored by sars).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26071?vs=71736=72239
REVISION DETAIL
shubham updated this revision to Diff 72254.
shubham marked 2 inline comments as done.
shubham edited the summary of this revision.
shubham added a comment.
Fix above mentioned issues, now works perfectly fine
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R264:816abe85ad6a: Display fully qualified class/namespace
name as page header (authored by davidre).
CHANGED PRIOR TO
davidre added inline comments.
INLINE COMMENTS
> kcolorschememanager.h:130
> +void followSystemScheme();
> +
> private:
I thought it would be nice to have as a convenience function if an application
has changed the scheme to easily go back to the system color scheme. I don't
know if it
davidre updated this revision to Diff 72251.
davidre marked 3 inline comments as done.
davidre added a comment.
- Use "Default" as string
- index.row() == 0
REPOSITORY
R265 KConfigWidgets
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D25877?vs=71976=72251
BRANCH
systemthem
shubham edited the summary of this revision.
shubham edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24932
To: shubham, ngraham, #frameworks
Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns
Hi,
Volker Krause schrieb am Fr., 27. Dez. 2019, 11:04:
> On Thursday, 26 December 2019 19:25:09 CET Albert Astals Cid wrote:
> > El dimarts, 24 de desembre de 2019, a les 13:05:23 CET, Friedrich W. H.
> Kossebau va escriure:
> > > Am Montag, 23. Dezember 2019, 09:57:57 CET schrieb Volker
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/239/
Project:
kf5-qt5 FreeBSDQt5.13
Date of build:
Fri, 27 Dec 2019 15:20:30 +
Build duration:
8 min 28 sec and counting
JUnit Tests
Name:
shubham edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24932
To: shubham, ngraham, #frameworks
Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns
shubham retitled this revision from "[WIP]: Add Button to open the folder in
filelight for more details" to "Add Button to open the folder in filelight for
more details".
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24932
To: shubham, ngraham, #frameworks
Cc:
ngraham added a comment.
@davidedmundson ping. This needs to make it into Frameworks 5.66 this is
tagged in a week if the dependent patches are to land in Plasma 5.18.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D25743
To: davidedmundson, #baloo
Cc:
shubham marked an inline comment as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24932
To: shubham, ngraham, #frameworks
Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns
shubham updated this revision to Diff 72263.
shubham added a comment.
Remove the use of variable
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24932?vs=72261=72263
BRANCH
file
REVISION DETAIL
https://phabricator.kde.org/D24932
AFFECTED FILES
ahmadsamir updated this revision to Diff 72266.
ahmadsamir edited the summary of this revision.
ahmadsamir added a comment.
Address comments
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D26236?vs=72213=72266
BRANCH
l-qregularexpression (branched from
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ee88418ec827: Port QRegExp to QRegularExpression (and
some QStringRef optimisation) (authored by ahmadsamir).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
We're getting there, but this code now causes a crash that must be fixed.
Please make sure you are testing your changes for all conditions (i.e. don't
just make sure that it
shubham updated this revision to Diff 72261.
shubham edited the summary of this revision.
shubham added a comment.
Fix whitespaces and crash condition
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D24932?vs=72254=72261
BRANCH
file
REVISION DETAIL
shubham marked 9 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24932
To: shubham, ngraham, #frameworks
Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns
shubham retitled this revision from "Add Button to open the folder in filelight
for more details" to "Add Button to open the folder in filelight to view more
details".
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24932
To: shubham, ngraham, #frameworks
Cc:
shubham retitled this revision from "Add Button to open the folder in filelight
to view more details" to "Add button to open the folder in filelight to view
more details".
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24932
To: shubham, ngraham, #frameworks
Cc:
pwojcik created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
pwojcik requested review of this revision.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D26245
AFFECTED FILES
pwojcik retitled this revision from "Set SYSCONFDIR to /etc when
CMAKE_INSTALL_PREFIX is /usr AND " to "Set SYSCONFDIR to /etc when
CMAKE_INSTALL_SYSCONFDIR is etc relative to /usr".
pwojcik edited the summary of this revision.
pwojcik added reviewers: kossebau, alexmerry.
REPOSITORY
R240
ngraham added a comment.
@bruns?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D25991
To: broulik, #frameworks, dfaure, ngraham, bruns
Cc: bruns, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,
zachus, fbampaloukas, GB_2, ragreen, ZrenBot,
ngraham added a comment.
Much better now, thanks. There's just one more thing I only notices now,
sorry. Then I think it'll be good to go.
INLINE COMMENTS
> kpropertiesdialog.cpp:1452
> +{
> +const QUrl url = properties->url();
> +
Instead of defining this as a variable that's used
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.
Ship it!
REPOSITORY
R241 KIO
BRANCH
file
REVISION DETAIL
https://phabricator.kde.org/D24932
To: shubham, ngraham, #frameworks
Cc: kde-frameworks-devel, #frameworks, LeGast00n,
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/240/
Project:
kf5-qt5 FreeBSDQt5.13
Date of build:
Fri, 27 Dec 2019 20:57:16 +
Build duration:
9 min 9 sec and counting
JUnit Tests
Name:
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R283 KAuth
BRANCH
port_to_QRandomGenerator (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D26227
To: mlaurent, dfaure, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,
apol added a comment.
Not saying that this patch is wrong, would have to look into it more closely.
But for knsrc files you want to use KDE_INSTALL_KNSRCDIR anyway, which will
fall into /usr.
INLINE COMMENTS
> KDEInstallDirs.cmake:376
> +list(FIND _gnu_install_special_vars
kossebau created this revision.
kossebau added a reviewer: leinir.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.
REPOSITORY
R304 KNewStuff
BRANCH
moredetailsaboutKDE_INSTALL_KNSRCDIR
REVISION DETAIL
kossebau added inline comments.
INLINE COMMENTS
> README.md:60
> +where KNewStuffCore expects it to be found. Do this by using the CMake
> variable
> +KDE_INSTALL_KNSRCDIR as provided by the KNewStuffCore module. You can also
> handle this
> +yourself, which means you will need to feed
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/136/
Project:
kf5-qt5 SUSEQt5.12
Date of build:
Fri, 27 Dec 2019 09:20:21 +
Build duration:
4 min 38 sec and counting
BUILD ARTIFACTS
On Thursday, 26 December 2019 19:25:09 CET Albert Astals Cid wrote:
> El dimarts, 24 de desembre de 2019, a les 13:05:23 CET, Friedrich W. H.
Kossebau va escriure:
> > Am Montag, 23. Dezember 2019, 09:57:57 CET schrieb Volker Krause:
> > > On Sunday, 22 December 2019 09:46:02 CET Dominik Haumann
rikmills added a comment.
Fails to build.
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/135/console
https://launchpadlibrarian.net/457575337/buildlog_ubuntu-eoan-amd64.kcoreaddons_5.65.0+p19.10+git20191227.0406-0_BUILDING.txt.gz
REPOSITORY
R244
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/84/
Project:
kf5-qt5 FreeBSDQt5.13
Date of build:
Fri, 27 Dec 2019 09:20:20 +
Build duration:
1 min 52 sec and counting
JUnit Tests
Name:
dfaure added a comment.
Thanks for the notice. Pushed a fix (#include ).
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D26226
To: ahmadsamir, #frameworks, mpyne, dfaure, apol
Cc: rikmills, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/241/
Project:
kf5-qt5 FreeBSDQt5.13
Date of build:
Sat, 28 Dec 2019 05:32:19 +
Build duration:
7 min 37 sec and counting
JUnit Tests
Name:
shubham closed this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D24932
To: shubham, ngraham, #frameworks
Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns
37 matches
Mail list logo
