D27603: KDNSSD: Convert license headers to SPDX statements

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license headers to SPDX statements and add license files as required by SPDX specification

D27603: KDNSSD: Convert license headers to SPDX statements

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R272 KDNSSD REVISION DETAIL https://phabricator.kde.org/D27603 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27601: KConfig: Convert to SPDX license statements

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27601 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27601: KConfig: Convert to SPDX license statements

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license headers to SPDX statements and add license files as required by REUSE specification.

D27596: Load QM files from assets: URLs on Android

vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This works with both the old and the new way of Qt's asset deployment, ie. with Qt 5.13

D27597: KRunner: Refactor deprecated toSet() method

ahmadsamir added a comment. Hi there. Since KF5 min. supported Qt version is 5.12, you have to make the code conditional so that it still build on Qt < 5.14. (Qt 5.14 is where range-iterators-based constructors were introduced to Qt containers including QList

T11950: Reduce the pain of working on monochrome Breeze icons

ngraham added a revision: D27605: Also auto-generate 24@2x compatibility symlinks. TASK DETAIL https://phabricator.kde.org/T11950 To: ngraham Cc: mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, manueljlin, Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh,

D27605: Also auto-generate 24@2x compatibility symlinks

ngraham added a task: T11950: Reduce the pain of working on monochrome Breeze icons. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27605 To: ngraham, #vdg, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27597: KRunner: Refactor deprecated toSet() method

alex added a reviewer: Plasma. alex added a comment. Thanks :-) REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D27597 To: alex, mlaurent, apol, #plasma Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27587: templates: Convert license statements to SPDX headers

cordlandwehr accepted this revision. cordlandwehr added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R39 KTextEditor BRANCH spdxlicensefortemplate REVISION DETAIL https://phabricator.kde.org/D27587 To: kossebau, #kate, cordlandwehr Cc: kwrite-devel,

D27596: Load QM files from assets: URLs on Android

vkrause added a task: T12520: Qt 5.14. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D27596 To: vkrause Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, michaelh, ngraham, bruns

D27597: KRunner: Refactor deprecated toSet() method

alex created this revision. alex added reviewers: mlaurent, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY The deprecated toSet method of the QList class has been refactored as in the

D27602: KDbusAddons: Convert license statement to SPDX

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license statements to SPDX and add license files as required by REUSE. REPOSITORY R271

D27602: KDbusAddons: Convert license statement to SPDX

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D27602 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27589: Try to apply the colorscheme of the current theme to QIcons

ngraham accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH qiconcolor (branched from master) REVISION DETAIL https://phabricator.kde.org/D27589 To: davidre, #plasma, cblack, ngraham Cc: wbauer, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D27589: Try to apply the colorscheme of the current theme to QIcons

wbauer added a comment. Confirmed. I tried out the patch now, and that problem is gone. REPOSITORY R242 Plasma Framework (Library) BRANCH qiconcolor (branched from master) REVISION DETAIL https://phabricator.kde.org/D27589 To: davidre, #plasma, cblack Cc: wbauer, cblack,

D27557: Auto-generate 24px monochrome icons

ngraham updated this revision to Diff 76228. ngraham added a comment. Rebase (thanks for the icon fixes, @ndavis) REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27557?vs=76129=76228 BRANCH autogenerate-24px-icons (branched from master) REVISION

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 250 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/250/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 23 Feb 2020 16:45:24 + Build duration: 1 min 12 sec and counting CONSOLE OUTPUT

D27557: Auto-generate 24px monochrome icons

This revision was automatically updated to reflect the committed changes. Closed by commit R266:d0582a4f16bd: Auto-generate 24px monochrome icons (authored by ngraham). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27557?vs=76228=76229 REVISION DETAIL

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 135 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/135/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 23 Feb 2020 16:45:24 + Build duration: 25 sec and counting CONSOLE OUTPUT

T11950: Reduce the pain of working on monochrome Breeze icons

ngraham updated the task description. TASK DETAIL https://phabricator.kde.org/T11950 To: ngraham Cc: mglb, #frameworks, mart, trickyricky26, ndavis, #vdg, ngraham, manueljlin, Orage, LeGast00n, cblack, konkinartem, ian, jguidon, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes,

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 142 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/142/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 23 Feb 2020 16:45:24 + Build duration: 53 sec and counting CONSOLE OUTPUT [...truncated

D27605: Also auto-generate 24@2x compatibility symlinks

ngraham created this revision. ngraham added reviewers: VDG, ndavis. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Missed this in D27557 , sorry. TEST PLAN

D27605: Also auto-generate 24@2x compatibility symlinks

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R266 Breeze Icons BRANCH create-2x-compatibility-dirs (branched from master) REVISION DETAIL https://phabricator.kde.org/D27605 To: ngraham, #vdg, ndavis Cc:

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

dhaumann added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kateviewhelpers.cpp:1963 > You should keep devicePixelRatioF calls This is true. But in this case a non-answer: Maybe QIcon::paint does it correct as well. In other words, the code can very likely be improved, but also

D27597: KRunner: Refactor deprecated toSet() method

alex updated this revision to Diff 76219. alex added a comment. Keep compatibility with Qt < 5.14 REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27597?vs=76213=76219 BRANCH deprecation_fix (branched from master) REVISION DETAIL

D27586: templates: Convert license statements to SPDX headers

cordlandwehr requested changes to this revision. cordlandwehr added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > main.cpp:31 > KAboutLicense::GPL, > -i18n("Copyright %{CURRENT_YEAR} %{AUTHOR}")); > +i18n("SPDX-FileCopyrightText:

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

anthonyfieroni accepted this revision. anthonyfieroni added a comment. This revision is now accepted and ready to land. No, just to not reviewed only by me. REPOSITORY R252 Framework Integration BRANCH messagewidget (branched from master) REVISION DETAIL

D27557: Auto-generate 24px monochrome icons

kossebau added a comment. Seems FreeBSD has an issue with the generation code. Please check https://build.kde.org/view/Failing/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/135/console REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27557 To:

D27614: build: fix the build where install prefix is not user-writable

bshah created this revision. bshah added reviewers: ngraham, lbeltrame. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bshah requested review of this revision. REVISION SUMMARY - Validate only the files and symlinks - Fix target names, they were swapped

D27614: build: fix the build where install prefix is not user-writable

lbeltrame added a comment. +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27614 To: bshah, ngraham, lbeltrame Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

kossebau added inline comments. INLINE COMMENTS > dhaumann wrote in kateviewhelpers.cpp:1963 > This is true. But in this case a non-answer: Maybe QIcon::paint does it > correct as well. In other words, the code can very likely be improved, but > also ok as is. @anthonyfieroni Why exactly do

D27038: [KMessageWidget] Allow the style to change our palette

davidre added a comment. In D27038#616095 , @apol wrote: > But then now we are not refreshing the palette when it changes outside, no? > > How about adding a boolean value when it's already happening to prevent the infinite recursion?

D27589: Try to apply the colorscheme of the current theme to QIcons

davidre edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH qiconcolor (branched from master) REVISION DETAIL https://phabricator.kde.org/D27589 To: davidre, #plasma, cblack Cc: wbauer, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D27589: Try to apply the colorscheme of the current theme to QIcons

davidre added a comment. In D27589#616106 , @wbauer wrote: > Sounds like it would fix https://bugs.kde.org/show_bug.cgi?id=417780 ? Yes seems like the exact bug REPOSITORY R242 Plasma Framework (Library) BRANCH qiconcolor (branched

D27588: templates: Convert license statements to SPDX headers

cordlandwehr accepted this revision. This revision is now accepted and ready to land. REPOSITORY R308 KRunner BRANCH spdxlicensefortemplate REVISION DETAIL https://phabricator.kde.org/D27588 To: kossebau, cordlandwehr, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27591: KAbstractFileItemActionPlugin: Add missing quotes in code example

alex created this revision. alex added a reviewer: elvisangelaccio. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY The quotes around the json file name were added. Without these the moc process would

D27591: KAbstractFileItemActionPlugin: Add missing quotes in code example

alex added a reviewer: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27591 To: alex, elvisangelaccio, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27594: Remove unused KDBusConnectionPool include

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY KDBusConnectionPool is about to be deprecated. REPOSITORY R241 KIO BRANCH master REVISION DETAIL

D27596: Load QM files from assets: URLs on Android

apol added a comment. Don't we need an if Qt 5.13 elseif Qt 5.14? In other Qt versions it won't be in the assets... REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D27596 To: vkrause Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack,

D27594: Remove unused KDBusConnectionPool include

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27594 To: vkrause, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27038: [KMessageWidget] Allow the style to change our palette

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Meh, right. I guess it doesn't matter that much. REPOSITORY R236 KWidgetsAddons BRANCH polish (branched from master) REVISION DETAIL https://phabricator.kde.org/D27038 To: davidre,

D27607: Deprecate KDBusConnectionPool

kossebau added inline comments. INLINE COMMENTS > CMakeLists.txt:45 > +DEPRECATION_VERSIONS 5.68 > +EXCLUDE_DEPRECATED_BEFORE_AND_AT ${EXCLUDE_DEPRECATED_BEFORE_AND_AT} > +) `${EXCLUDE_DEPRECATED_BEFORE_AND_AT}` is not defined by default. You want to add an option (or actually cached

D27607: Deprecate KDBusConnectionPool

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY As per T12722 this is no longer needed, QDBusConnection now behaves correctly

D27588: templates: Convert license statements to SPDX headers

This revision was automatically updated to reflect the committed changes. Closed by commit R308:1db8ad9e2a2a: templates: Convert license statements to SPDX headers (authored by kossebau). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27588?vs=76196=76234

D27476: [KDBusConnectionPool] Handle the case of no qApp

davidedmundson abandoned this revision. davidedmundson added a comment. Also fixed by D27607 REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D27476 To: davidedmundson Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27591: KAbstractFileItemActionPlugin: Add missing quotes in code example

apol accepted this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27591 To: alex, elvisangelaccio, #frameworks, mlaurent, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27587: templates: Convert license statements to SPDX headers

This revision was automatically updated to reflect the committed changes. Closed by commit R39:fdd98f815ace: templates: Convert license statements to SPDX headers (authored by kossebau). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27587?vs=76195=76233

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 136 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/136/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 23 Feb 2020 18:55:14 + Build duration: 23 sec and counting CONSOLE OUTPUT

D27586: templates: Convert license statements to SPDX headers

kossebau updated this revision to Diff 76236. kossebau marked an inline comment as done. kossebau added a comment. remove unwanted change in KAboutData copyright string REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27586?vs=76194=76236 BRANCH

D27586: templates: Convert license statements to SPDX headers

kossebau marked an inline comment as done. kossebau added inline comments. INLINE COMMENTS > cordlandwehr wrote in main.cpp:31 > I do not think that we should change this Hmpf, that slipped me. The regular expression overdoing its job :) I guess that will be hit in more KAboutData instances.

D27605: Also auto-generate 24@2x compatibility symlinks

This revision was automatically updated to reflect the committed changes. Closed by commit R266:67f60a7322ac: Also auto-generate 24@2x compatibility symlinks (authored by ngraham, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 143 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/143/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sun, 23 Feb 2020 18:55:14 + Build duration: 1 min 58 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 251 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/251/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 23 Feb 2020 18:55:14 + Build duration: 2 min 3 sec and counting JUnit Tests Name: (root)

D27591: KAbstractFileItemActionPlugin: Add missing quotes in code example

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27591 To: alex, elvisangelaccio, #frameworks, mlaurent Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27597: KRunner: Refactor deprecated toSet() method

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Makes sense. It would be ideal to have a way to do an unsorted comparison without having to create 2 temporary sets every time, although I guess it's out of scope here. REPOSITORY R308