D23339: Fix memory leak in ConfigView and Dialog

2020-02-26 Thread Daniel Vrátil
dvratil added a dependent revision: D27671: Dialog: disconnect from QWindow signals in destructor. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23339 To: dvratil, #plasma, #frameworks, apol, davidedmundson Cc: nicolasfella, kde-frameworks-devel,

D27671: Dialog: disconnect from QWindow signals in destructor

2020-02-26 Thread Daniel Vrátil
dvratil added a dependency: D23339: Fix memory leak in ConfigView and Dialog. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27671 To: dvratil, #plasma, nicolasfella Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

2020-02-26 Thread Kevin Ottens
ervin added inline comments. INLINE COMMENTS > meven wrote in kcoreconfigskeleton.h:764 > Something I have noticed while testing this. > Since it changes the memory of a very common data struct in a very common > lib, it creates a lot of crashes if apps are not compiled with the installed >

KDE CI: Frameworks » kconfig » kf5-qt5 FreeBSDQt5.13 - Build # 86 - Fixed!

2020-02-26 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20FreeBSDQt5.13/86/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 26 Feb 2020 10:04:37 + Build duration: 1 min 23 sec and counting JUnit Tests Name:

D27672: Fix tests after D27497

2020-02-26 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R237:ed960455a112: Fix tests after D27497 (authored by meven). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27672?vs=76444=76445 REVISION DETAIL

D27463: KconfigXT: Add a value attribute to Enum field choices

2020-02-26 Thread Kevin Ottens
ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > ervin wrote in kcoreconfigskeleton.h:764 > Oh right, stupid me, this obviously breaks binary compatibility, we need to > find another way to store this. Most

D27497: Fix code generation for entries with min/max

2020-02-26 Thread Méven Car
meven added inline comments. INLINE COMMENTS > test_properties_minmax.h.ref:43 > +Q_PROPERTY(int bar READ bar WRITE setBar NOTIFY barChanged) > +Q_PROPERTY(bool isBarImmutable CONSTANT) > +/** This is incorrrect since D27496 , too bad this was

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.13 - Build # 210 - Still Unstable!

2020-02-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.13/210/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 26 Feb 2020 09:59:47 + Build duration: 2 min 20 sec and counting BUILD ARTIFACTS

D27672: Fix tests after D27497

2020-02-26 Thread Henri Chain
hchain accepted this revision. hchain added a comment. This revision is now accepted and ready to land. Can confirm this works REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D27672 To: meven, hchain, ervin, bport, crossi, #frameworks Cc:

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 357 - Still Unstable!

2020-02-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/357/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 26 Feb 2020 09:59:47 + Build duration: 2 min 23 sec and counting BUILD ARTIFACTS

D21795: [KAuth] Add support for action details in Polkit1 backend.

2020-02-26 Thread Harald Sitter
sitter requested changes to this revision. sitter added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > Polkit1Backend.cpp:4 > * Copyright (C) 2009 Radek Novacek > * Copyright (C) 2009-2010 Dario Freddi > * According to the diff of the diff you seem to

D27671: Dialog: disconnect from QWindow signals in destructor

2020-02-26 Thread Daniel Vrátil
dvratil created this revision. dvratil added reviewers: Plasma, nicolasfella. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dvratil requested review of this revision. REVISION SUMMARY When Dialog is being destroyed, its QWindow super-class may still emit

KDE CI: Frameworks » kconfig » kf5-qt5 SUSEQt5.12 - Build # 124 - Fixed!

2020-02-26 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20SUSEQt5.12/124/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 26 Feb 2020 10:04:37 + Build duration: 2 min 46 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kconfig » kf5-qt5 SUSEQt5.13 - Build # 92 - Fixed!

2020-02-26 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kconfig/job/kf5-qt5%20SUSEQt5.13/92/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 26 Feb 2020 10:04:37 + Build duration: 3 min 44 sec and counting BUILD ARTIFACTS

D27672: Fix tests after D27497

2020-02-26 Thread Méven Car
meven created this revision. meven added reviewers: hchain, ervin, bport. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY See https://phabricator.kde.org/D27497#618156 TEST PLAN ctest REPOSITORY

D27672: Fix tests after D27497

2020-02-26 Thread Méven Car
meven added reviewers: crossi, Frameworks. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27672 To: meven, hchain, ervin, bport, crossi, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27463: KconfigXT: Add a value attribute to Enum field choices

2020-02-26 Thread Méven Car
meven updated this revision to Diff 76446. meven added a comment. Move construct of QRegularExpression out of loop REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27463?vs=76405=76446 BRANCH arcpatch-D27463 REVISION DETAIL

D27463: KconfigXT: Add a value attribute to Enum field choices

2020-02-26 Thread Méven Car
meven marked an inline comment as done. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27463 To: meven, ervin, bport, crossi, #frameworks Cc: ngraham, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D23339: Fix memory leak in ConfigView and Dialog

2020-02-26 Thread Daniel Vrátil
dvratil added a comment. Fix for the crash: https://phabricator.kde.org/D27671 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23339 To: dvratil, #plasma, #frameworks, apol, davidedmundson Cc: nicolasfella, kde-frameworks-devel, LeGast00n, cblack,

D27671: Dialog: disconnect from QWindow signals in destructor

2020-02-26 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D27671 To: dvratil, #plasma, nicolasfella, davidedmundson Cc: kde-frameworks-devel, LeGast00n,

D27671: Dialog: disconnect from QWindow signals in destructor

2020-02-26 Thread Daniel Vrátil
This revision was automatically updated to reflect the committed changes. Closed by commit R242:b6213cdd59cc: Dialog: disconnect from QWindow signals in destructor (authored by dvratil). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D27647: throw out the windows variant of the smb slave

2020-02-26 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R320:60c9ac5a089a: smb: throw out the windows variant of the slave (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27647?vs=76357=76450

D27616: [UrlHandler] Handle opening the online docs for KCM modules

2020-02-26 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 76463. ahmadsamir retitled this revision from "[UrlHandler] optimise the code and less if nesting" to "[UrlHandler] Handle opening the online docs for KCM modules". ahmadsamir edited the summary of this revision. ahmadsamir edited the test plan for this

D27615: [UrlHandler] Handle opening the online docs for KCM modules

2020-02-26 Thread Ahmad Samir
ahmadsamir abandoned this revision. ahmadsamir added a comment. See D27616 REPOSITORY R273 KGuiAddons REVISION DETAIL https://phabricator.kde.org/D27615 To: ahmadsamir, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D17205: Build kio_nfs against standalone libtirpc

2020-02-26 Thread Harald Sitter
sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Fine by me to land as-is, it can't be worse than what the current state of afairs in master is... which is to say in master nothing is working for me :'< REPOSITORY R320 KIO Extras

D27654: [kio] Fix running konsole on Wayland

2020-02-26 Thread Wolfgang Bauer
wbauer added a comment. In D27654#617946 , @dfaure wrote: > Wait, you're actually passing the icon of the command being executed now (while the old code would end up using the stuff from konsole.desktop I think) AFAICT passing the

D27644: do not hide enum warnings via switch default label

2020-02-26 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R320:d0e16b8326d4: smb: do not hide enum warnings via switch default label (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27644?vs=76352=76449

D27646: smb: apply a whole bunch of static analyzer improvements

2020-02-26 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R320:70f2dc8521ff: smb: apply a whole bunch of static analyzer improvements (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27646?vs=76354=76451

D27153: port sftp to Result system to force serialization of error/finish condition

2020-02-26 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R320:74850eb21654: sftp: port to Result system to force serialization of error/finish condition (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D21795: [KAuth] Add support for action details in Polkit1 backend.

2020-02-26 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > sitter wrote in Polkit1Backend.cpp:239 > M. M. I don't really have a suggestion here, but this is an > incredibly dangerous change. Nested event loops can cause all sorts of > negative effects. That's why the isValid had a note in the

D27676: smb: ecm clang-format the entire code base

2020-02-26 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY over the past 20 years smb has gathered a whole bunch of different

D27616: [UrlHandler] Handle opening the online docs for KCM modules

2020-02-26 Thread Aleix Pol Gonzalez
apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. We can't add new dependencies to a tier1 framework, it would break the whole dependency system. Just make it a qCWarning. REPOSITORY R273 KGuiAddons REVISION DETAIL

D21795: [KAuth] Add support for action details in Polkit1 backend.

2020-02-26 Thread Alexander Saoutkin
feverfew planned changes to this revision. feverfew added a comment. Ok, I see what's going on here. Earlier I mucked up the diff a bit and had to go back to different diff id and reapply my changes. In the process I forgot to rebase onto master. Once I do that David's copyright will be back

D21795: [KAuth] Add support for action details in Polkit1 backend.

2020-02-26 Thread Alexander Saoutkin
feverfew added a comment. I believe most of your (@sitter) comments (apart from the misaligned `&` probably were caused by me forgetting to rebase), lmk if otherwise. INLINE COMMENTS > sitter wrote in Polkit1Backend.cpp:75 > Is there a reason you use stringy connection syntax instead of

D21795: [KAuth] Add support for action details in Polkit1 backend.

2020-02-26 Thread Alexander Saoutkin
feverfew updated this revision to Diff 76497. feverfew added a comment. - Merge branch 'master' into arcpatch-D21795_1 - Update version REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21795?vs=76419=76497 BRANCH arcpatch-D21795_1 REVISION DETAIL

D27616: [UrlHandler] Handle opening the online docs for KCM modules

2020-02-26 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > CMakeLists.txt:33 > target_compile_definitions(KF5GuiAddons INTERFACE > "$") > -target_link_libraries(KF5GuiAddons PUBLIC Qt5::Gui) > +target_link_libraries(KF5GuiAddons PUBLIC Qt5::Widgets) > +target_link_libraries(KF5GuiAddons PUBLIC KF5::I18n)

D27502: Create ConfigView an unmanaged ConfigWidget

2020-02-26 Thread Benjamin Port
bport updated this revision to Diff 76517. bport added a comment. rename check uppercase to skip uppercase REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27502?vs=76384=76517 REVISION DETAIL https://phabricator.kde.org/D27502 AFFECTED FILES

D27665: Support SAE in securityTypeFromConnectionSetting

2020-02-26 Thread Jan Grulich
This revision was automatically updated to reflect the committed changes. Closed by commit R282:8142b3cfa66a: Support SAE in securityTypeFromConnectionSetting (authored by Haochen Tong i...@hexchain.org, committed by jgrulich). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE

D27692: TypeScript: add private fields and type-only imports/exports, and some fixes

2020-02-26 Thread Nibaldo González
nibags updated this revision to Diff 76518. nibags added a comment. - Update TypeScript REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27692?vs=76511=76518 BRANCH update-typescript REVISION DETAIL https://phabricator.kde.org/D27692

D26983: Enable adding place as first child

2020-02-26 Thread George Vogiatzis
gvgeo added a comment. ping REPOSITORY R241 KIO BRANCH after (branched from master) REVISION DETAIL https://phabricator.kde.org/D26983 To: gvgeo, #frameworks, meven, broulik, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27692: TypeScript: add private fields and type-only imports/exports, and some fixes

2020-02-26 Thread Nibaldo González
nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY - Add private-named

D27693: Add syntax highlighting for Java Properties

2020-02-26 Thread Nibaldo González
nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY

D17816: Support for xattrs on kio copy/move

2020-02-26 Thread Nathaniel Graham
ngraham added a comment. @tmarshall would you like to finish this up? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: tmarshall, dfaure, chinmoyr, bruns, #frameworks, cochise Cc: scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann,

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 361 - Still Unstable!

2020-02-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/361/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 26 Feb 2020 18:09:10 + Build duration: 2 min 39 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.13 - Build # 214 - Still Unstable!

2020-02-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.13/214/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 26 Feb 2020 18:09:10 + Build duration: 4 min 12 sec and counting BUILD ARTIFACTS

D27616: [UrlHandler] Handle opening the online docs for KCM modules

2020-02-26 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 76474. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Don't change dependencies for a low tier framework REPOSITORY R273 KGuiAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27616?vs=76463=76474 BRANCH

D27616: [UrlHandler] Handle opening the online docs for KCM modules

2020-02-26 Thread Ahmad Samir
ahmadsamir added a comment. In D27616#618382 , @apol wrote: > We can't add new dependencies to a tier1 framework, it would break the whole dependency system. > > Just make it a qCWarning. I opted for qDebug() for now, and will change

D26749: WIP: Support NDK r20 and Qt 5.14

2020-02-26 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > apol wrote in Android.cmake:173 > I did some testing and for me it works for arm64 but not for arm32. I actually didn't test 64bit ARM here, only armv7 and x86, both work. What does break for you there? REPOSITORY R240 Extra CMake Modules

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.13 - Build # 211 - Still Unstable!

2020-02-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.13/211/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 26 Feb 2020 17:13:02 + Build duration: 2 min 4 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 358 - Still Unstable!

2020-02-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/358/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 26 Feb 2020 17:13:02 + Build duration: 2 min 49 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 359 - Still Unstable!

2020-02-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/359/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 26 Feb 2020 17:15:53 + Build duration: 2 min 40 sec and counting BUILD ARTIFACTS

D27363: KHolidays: Convert license statements to SPDX expressions

2020-02-26 Thread Andreas Cord-Landwehr
This revision was automatically updated to reflect the committed changes. Closed by commit R175:1bc908a8cfea: KHolidays: Convert license statements to SPDX expressions (authored by cordlandwehr). REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE

D27596: Load QM files from assets: URLs on Android

2020-02-26 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R240:040504da64aa: Load QM files from assets: URLs on Android (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27596?vs=76212=76476

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.12 - Build # 99 - Still Unstable!

2020-02-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.12/99/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 26 Feb 2020 17:10:07 + Build duration: 3 min 13 sec and counting JUnit Tests Name:

KDE CI: Frameworks » extra-cmake-modules » kf5-qt5 SUSEQt5.13 - Build # 65 - Still Unstable!

2020-02-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/extra-cmake-modules/job/kf5-qt5%20SUSEQt5.13/65/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 26 Feb 2020 17:10:07 + Build duration: 3 min 14 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.13 - Build # 212 - Still Unstable!

2020-02-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.13/212/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 26 Feb 2020 17:15:09 + Build duration: 2 min 9 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.13 - Build # 213 - Still Unstable!

2020-02-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.13/213/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 26 Feb 2020 17:46:27 + Build duration: 2 min 52 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 360 - Still Unstable!

2020-02-26 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/360/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 26 Feb 2020 17:46:27 + Build duration: 2 min 8 sec and counting BUILD ARTIFACTS