D27617: [breeze-icons] Add telegram-desktop tray icons

rocka added a comment. Are we ready for some reviews? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27617 To: rocka, #vdg, Fuchs Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27628: Buttons: allow to scale up icons

This revision was automatically updated to reflect the committed changes. Closed by commit R242:0b89e7f3f089: Buttons: allow to scale up icons (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27628?vs=76310=76769 REVISION

D27662: Rewrite nextcloud plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R495:bea001a564b1: Rewrite nextcloud plugin (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27662?vs=76421=76772 REVISION DETAIL

D27787: Remove 48px telegram icons

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The style doesn't preserve the original branding very well and the official telegram icon

D27777: Fix clicking thumb-only delegate

leinir edited the test plan for this revision. leinir added reviewers: Frameworks, ngraham. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D2 To: leinir, #frameworks, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27589: Try to apply the colorscheme of the current theme to QIcons

This revision was automatically updated to reflect the committed changes. Closed by commit R242:b7fa6e0e916b: Try to apply the colorscheme of the current theme to QIcons (authored by davidre). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 445 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/445/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 02 Mar 2020 10:10:10 + Build duration: 10 min and counting BUILD ARTIFACTS

D27589: Try to apply the colorscheme of the current theme to QIcons

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH qiconcolor (branched from master) REVISION DETAIL https://phabricator.kde.org/D27589 To: davidre, #plasma, cblack, ngraham, mart Cc: mart, wbauer, cblack,

D27464: Add application menu dbus paths to org_kde_plasma_window interface

zzag requested changes to this revision. zzag added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > plasmawindowmanagement.cpp:363 > > +void PlasmaWindow::Private::appmenuChangedCallback(void *data, > org_kde_plasma_window *window, const char* service_name,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 320 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/320/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 02 Mar 2020 10:10:10 + Build duration: 8 min 58 sec and counting BUILD ARTIFACTS

D27724: Syncronise setNeedsSave between KCModule and ConfigModule in both directions

davidedmundson edited the summary of this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D27724 To: davidedmundson Cc: iasensio, crossi, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 311 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/311/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 02 Mar 2020 10:10:10 + Build duration: 7 min 21 sec and counting JUnit Tests Name:

D27735: [KConfigGui] Clear styleName font property for Regular font sytles

This revision was automatically updated to reflect the committed changes. Closed by commit R237:a2774ff5b419: [KConfigGui] Clear styleName font property for Regular font sytles (authored by ahmadsamir). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D27777: Fix clicking thumb-only delegate

leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY This fixes a call to an attached property which only exists on the delegate root, not the children. BUG:418368

D27451: Drop KToolInvocation support from KRun::runService

This revision was automatically updated to reflect the committed changes. Closed by commit R241:f7cf3b676a4e: [krun] Drop KToolInvocation support from KRun::runService (authored by davidedmundson). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D27620: [krun] Share implementation of runService and runApplication

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a35cbeabc162: [krun] Share implementation of runService and runApplication (authored by davidedmundson). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D26749: Support NDK r20 and Qt 5.14

vkrause retitled this revision from "WIP: Support NDK r20 and Qt 5.14" to "Support NDK r20 and Qt 5.14". REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D26749 To: vkrause, apol Cc: flherne, apol, kde-frameworks-devel, kde-buildsystem,

D27557: Auto-generate 24px monochrome icons

kossebau added a comment. There is also the issue that the `breeze-generate-24px-versions` target is not set as dependency for the `breeze-validate-svg` target. As a result both targets will be processed in parallel if multiple jobs are possible. And on KDE CI, where the "build/" directory

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 154 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/154/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 02 Mar 2020 17:56:21 + Build duration: 3 min 0 sec and counting JUnit Tests Name: (root)

D27617: [breeze-icons] Add telegram-desktop tray icons

ndavis added a comment. Sorry, I've been busy lately. I noticed some issues: 1. The distinguishing part of the icon doesn't take up much space, so too much of it gets hidden behind the notification badge. - I'd suggest removing the circle and making the distinguishing part

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 148 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/148/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 02 Mar 2020 17:56:20 + Build duration: 1 min 44 sec and counting JUnit Tests Name:

D27133: kconfig_compiler : generate kconfig settings with subgroup

crossi planned changes to this revision. crossi added a comment. Thanks for your comments. A new attribute to the group element would be more readable and easier to edit/maintain. To generate code like : KConfig config; KConfigGroup generalGroup( , "General" );

D27557: Auto-generate 24px monochrome icons

kossebau added a comment. Pushed 004cf12a2fdb09ab8b62e3f8d84e1584fe08ebab as intermediate hotfix to help CI and other parallel builds. The whole logic needs a clean rework though, e.g. to make sure the generated

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 262 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/262/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 02 Mar 2020 17:56:21 + Build duration: 3 min 14 sec and counting JUnit Tests Name:

D27148: update d->m_file in ReadOnlyPart::setUrl()

pdabrowski abandoned this revision. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D27148 To: pdabrowski, elvisangelaccio, ngraham, #frameworks, dfaure Cc: ahmadsamir, marten, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27475: Make kwapper/kshell spawn klauncher5 if needed

This revision was automatically updated to reflect the committed changes. Closed by commit R303:f3264622f96d: Make kwrapper/kshell spawn klauncher5 if needed (authored by davidedmundson). REPOSITORY R303 KInit CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27475?vs=75924=76757

D27557: Auto-generate 24px monochrome icons

ndavis added a comment. Sorry for all the trouble. Unfortunately, neither Nate or I have much experience with CMake or the gotchas of cross platform shellscript and Unix tool support. We'll have to be a lot more careful next time and stick to something with fewer gotchas like Python.

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack marked 6 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27464 To: cblack, #kwin, zzag Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack updated this revision to Diff 76804. cblack added a comment. Address feedback REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27464?vs=76035=76804 BRANCH cblack/appmenu-listener REVISION DETAIL https://phabricator.kde.org/D27464 AFFECTED

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack marked an inline comment as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27464 To: cblack, #kwin, zzag Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack updated this revision to Diff 76811. cblack added a comment. Coding style REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27464?vs=76805=76811 BRANCH cblack/appmenu-listener REVISION DETAIL https://phabricator.kde.org/D27464 AFFECTED FILES

D27794: Fix symlink problem because of using relative path instead of full path

ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Relative links are actually necessary. Otherwise, they won't work when the source repository isn't present. REPOSITORY R266 Breeze Icons REVISION DETAIL

D27152: Introduce FilesystemEntry class

hallas added a comment. Hi @bruns - I have updated this patch with the changes you requested and would really like your feedback :) REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D27152 To: hallas, #frameworks, bruns, meven Cc: kde-frameworks-devel, LeGast00n,

D27794: Fix symlink problem because of using relative path instead of full path

ndavis added a comment. Example: F8146162: Screenshot_20200302_233811.PNG I renamed the original breeze-icons repo to breeze-icons2 and the symlinks broke because they were pointing to the source folder instead of the installation folder.

D27430: [PATCH] General update for CartoCSS syntax highlighting

This revision was automatically updated to reflect the committed changes. Closed by commit R216:c13aa9c31167: [PATCH] General update for CartoCSS syntax highlighting (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27430?vs=75757=76793#toc REPOSITORY R216 Syntax

D27787: Remove 48px telegram icons

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:8fb85eb7cca0: Remove 48px telegram icons (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST

D27795: Expose capture signal on KeySequenceItem

iasensio updated this revision to Diff 76808. iasensio marked an inline comment as done. iasensio added a comment. Add API comment REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27795?vs=76807=76808 BRANCH expose_capture REVISION DETAIL

D27464: Add application menu dbus paths to org_kde_plasma_window interface

zzag added inline comments. INLINE COMMENTS > plasmawindowmanagement_interface.cpp:85 > void setGeometry(const QRect ); > +void setApplicationMenuPaths(const QString& service, const QString& > object); > wl_resource *resourceForParent(PlasmaWindowInterface *parent, > wl_resource

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 263 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/263/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 02 Mar 2020 19:20:00 + Build duration: 4 min 29 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 155 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/155/ Project: kf5-qt5 SUSEQt5.13 Date of build: Mon, 02 Mar 2020 19:19:59 + Build duration: 2 min 38 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 149 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/149/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 02 Mar 2020 19:19:59 + Build duration: 3 min 22 sec and counting JUnit Tests Name:

D27795: Expose capture signal on KeySequenceItem

iasensio created this revision. iasensio added reviewers: Plasma, mart, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. iasensio requested review of this revision. REVISION SUMMARY Expose the signal `captureFinished` from the private helper

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack marked 3 inline comments as done. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27464 To: cblack, #kwin, zzag Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27464: Add application menu dbus paths to org_kde_plasma_window interface

cblack updated this revision to Diff 76805. cblack added a comment. Tick up PWM version REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27464?vs=76804=76805 BRANCH cblack/appmenu-listener REVISION DETAIL https://phabricator.kde.org/D27464 AFFECTED

D27794: Fix symlink problem because of using relative path instead of full path

usta created this revision. usta added reviewers: ngraham, kossebau, ndavis. usta added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. usta requested review of this revision. REVISION SUMMARY generate script was trying to read the source of symlinked files base but it

D27795: Expose capture signal on KeySequenceItem

davidedmundson added inline comments. INLINE COMMENTS > KeySequenceItem.qml:13 > > +signal captureFinished() > If you could add API docs that'd be really great REPOSITORY R296 KDeclarative BRANCH expose_capture REVISION DETAIL https://phabricator.kde.org/D27795 To: iasensio,

D27795: Expose capture signal on KeySequenceItem

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH expose_capture REVISION DETAIL https://phabricator.kde.org/D27795 To: iasensio, #plasma, mart, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D27795: Expose capture signal on KeySequenceItem

This revision was automatically updated to reflect the committed changes. Closed by commit R296:1a838e468d05: Expose capture signal on KeySequenceItem (authored by iasensio). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27795?vs=76808=76810 REVISION

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 80 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/80/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 02 Mar 2020 22:19:10 + Build duration: 7 min 20 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.13 - Build # 81 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.13/81/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 03 Mar 2020 05:55:49 + Build duration: 1 min 52 sec and counting JUnit Tests Name:

D27797: Agda: keywords updated to 2.6.0 and fix float points

nibags created this revision. nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nibags requested review of this revision. REVISION SUMMARY New keywords are added,

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 63 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/63/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 03 Mar 2020 07:03:59 + Build duration: 1 min 19 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 446 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/446/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 03 Mar 2020 07:05:06 + Build duration: 6 min 22 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 312 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/312/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 03 Mar 2020 07:05:05 + Build duration: 6 min 58 sec and counting JUnit Tests Name:

D27430: [PATCH] General update for CartoCSS syntax highlighting

sommer added a comment. Thanks! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D27430 To: sommer, #framework_syntax_highlighting, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, gennad, GB_2, bmortimer, domson,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 321 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/321/ Project: kf5-qt5 SUSEQt5.13 Date of build: Tue, 03 Mar 2020 07:05:05 + Build duration: 9 min 32 sec and counting BUILD ARTIFACTS

D27464: Add application menu dbus paths to org_kde_plasma_window interface

zzag added inline comments. INLINE COMMENTS > plasma-window-management.xml:20 > > > version="10" > plasma-window-management.xml:87 > > - > + > version="10" > plasma-window-management.xml:312 > > + > + and this one should be > davidedmundson