D27828: [server] Introduce SurfaceInterface::boundingRect()

2020-03-04 Thread Vlad Zahorodnii
zzag added a comment. I'll merge this patch after 5.68 is tagged. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27828 To: zzag, #kwin, davidedmundson Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27833: Add an accessor to get the last load value for KConfigSkeletonItem

2020-03-04 Thread Méven Car
meven updated this revision to Diff 76938. meven added a comment. Clean qDebug traces REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27833?vs=76937=76938 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27833 AFFECTED FILES

D27833: Add an accessor to get the last loaded value for KConfigSkeletonItem

2020-03-04 Thread Méven Car
meven retitled this revision from "Add an accessor to get the last load value for KConfigSkeletonItem" to "Add an accessor to get the last loaded value for KConfigSkeletonItem". REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27833 To: meven, ervin, bport, crossi,

D27804: smb: add hack to support spaces in workgroup names

2020-03-04 Thread Thiago Macieira
thiago added a comment. Still want to see that round-trip. INLINE COMMENTS > smburltest.cpp:112 > +// % character - run through .url() to simulate behavior of our > listDir() > + > QCOMPARE(SMBUrl(QUrl(QUrl("smb://?kio-workgroup=HAX%MAX").url())).toSmbcUrl(), > +

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-04 Thread Niccolò Venerandi
niccolove added a comment. Two questions: - I know we should not assume it's a Layout, but margins should be defined inside the file as they compensate the inset; is it possible to both define them with Layout and anchors, or something that would work with both? - Is code on line 51

D27787: Remove 48px telegram icons

2020-03-04 Thread Nathaniel Graham
ngraham added a comment. Here's one problem from simply removing the existing Breeze theme SVG icons: the icons shipped in Telegram are raster .pngs which can scale poorly, and the circular effect seems quite badly done for the 48px version in particular. For example here's how Telegram's

D27833: Add an accessor to get the last load value for KConfigSkeletonItem

2020-03-04 Thread Méven Car
meven updated this revision to Diff 76937. meven added a comment. Avoid some space changes REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27833?vs=76936=76937 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27833 AFFECTED FILES

D27833: Add an accessor to get the last load value for KConfigSkeletonItem

2020-03-04 Thread Méven Car
meven added a comment. Inspired by 4c3d3751968422ff5cba56b5da2036a1bceba314 REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27833 To: meven, ervin, bport, crossi, #frameworks Cc:

D27802: smb: fix ipv6 support

2020-03-04 Thread Thiago Macieira
thiago added a comment. looks good to me. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27802 To: sitter, ngraham Cc: thiago, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela,

D27828: [server] Introduce SurfaceInterface::boundingRect()

2020-03-04 Thread Vlad Zahorodnii
zzag added a comment. In D27828#621821 , @apol wrote: > Maybe producing the patch that is meant to consume this will help see what's the use for this patch. D27831 REPOSITORY R127 KWayland

D27828: [server] Introduce SurfaceInterface::boundingRect()

2020-03-04 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27828 To: zzag, #kwin, davidedmundson Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27801: smb: add a unit test for smburl

2020-03-04 Thread Harald Sitter
sitter updated this revision to Diff 76935. sitter added a comment. make cdup void REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27801?vs=76861=76935 BRANCH smb-smburl-static-autotest REVISION DETAIL https://phabricator.kde.org/D27801 AFFECTED

D27617: [breeze-icons] Add telegram-desktop tray icons

2020-03-04 Thread Rocket Aaron
rocka updated this revision to Diff 76942. rocka edited the test plan for this revision. rocka added a comment. I've re-make the distinguishing part of the icons following the official one, it would be easy to recognize now. See the "Update" part in "Test Plan". Since the name for tray

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-03-04 Thread Niccolò Venerandi
niccolove updated this revision to Diff 76947. niccolove added a comment. Moved TopArea to PlasmoidHeading and various fixes in it REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27695?vs=76862=76947 BRANCH master REVISION DETAIL

D27804: smb: add hack to support spaces in workgroup names

2020-03-04 Thread Harald Sitter
sitter updated this revision to Diff 76934. sitter added a comment. extend test coverage to % character in wg and umlaut in wg. I've also changed the construction in browse.cpp to use QUrlQuery so it does not trip over potential hash or question marks in the workgroup libsmbc is

D27617: [breeze-icons] Add telegram-desktop tray icons

2020-03-04 Thread Rocket Aaron
rocka updated this revision to Diff 76946. rocka added a comment. Fix attention dot color and remove accidentally added patch file REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27617?vs=76942=76946 REVISION DETAIL

D27828: [server] Introduce SurfaceInterface::boundingRect()

2020-03-04 Thread Aleix Pol Gonzalez
apol added a comment. Maybe producing the patch that is meant to consume this will help see what's the use for this patch. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D27828 To: zzag, #kwin Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27835: sftp: fix free space query for urls with empty path

2020-03-04 Thread Méven Car
meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH sftp-free-path REVISION DETAIL https://phabricator.kde.org/D27835 To: sitter, ngraham, meven Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n,

D27833: Add an accessor to get the last load value for KConfigSkeletonItem

2020-03-04 Thread Méven Car
meven created this revision. meven added reviewers: ervin, bport, crossi, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY It allows to know the last load values from KConfig, for some edge

D27835: sftp: fix free space query for urls with empty path

2020-03-04 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY e.g. `sftp://localhost` has an empty path fall back to assume it

D27777: Fix clicking thumb-only delegate

2020-03-04 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH fix-thumbnail-only-view (branched from master) REVISION DETAIL https://phabricator.kde.org/D2 To: leinir, #frameworks, ngraham Cc: kde-frameworks-devel, LeGast00n,

D27444: Added top area

2020-03-04 Thread Nathaniel Graham
ngraham added a comment. Maybe run it through an SVG optimizer; See https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Scour REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: mart,

D27801: smb: add a unit test for smburl

2020-03-04 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH smb-smburl-static-autotest REVISION DETAIL https://phabricator.kde.org/D27801 To: sitter, ngraham Cc: apol, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice,

D27730: Add API to check whether a barcode is one- or two-dimensional

2020-03-04 Thread Volker Krause
vkrause added a reviewer: svuorela. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D27730 To: vkrause, svuorela Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27727: Remove empty/unused private classes on internal types

2020-03-04 Thread Volker Krause
vkrause added a reviewer: svuorela. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D27727 To: vkrause, svuorela Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27844: Store and fetch complete view config in and from session config

2020-03-04 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Kate, loh.tar, cullmann, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. kossebau requested review of this revision. REVISION SUMMARY The manual "Dynamic Word Wrap" config

D27730: Add API to check whether a barcode is one- or two-dimensional

2020-03-04 Thread Sune Vuorela
svuorela requested changes to this revision. svuorela added a comment. This revision now requires changes to proceed. I'm not sure I like the implementation. The current AbstractBarcode can also be implemented, at least theoretically, by software providing other barcodes that forever reason

D27727: Remove empty/unused private classes on internal types

2020-03-04 Thread Sune Vuorela
svuorela accepted this revision. svuorela added a comment. This revision is now accepted and ready to land. These are leftovers from when all constructor was public. REPOSITORY R280 Prison BRANCH master REVISION DETAIL https://phabricator.kde.org/D27727 To: vkrause, svuorela Cc:

D27727: Remove empty/unused private classes on internal types

2020-03-04 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R280:10054afd8243: Remove empty/unused private classes on internal types (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27727?vs=76657=76965

D27842: [breeze-icons] New 48px telegram icon

2020-03-04 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a reviewer: ndavis. ngraham added a comment. This revision is now accepted and ready to land. This looks great to me! IMO it's definitely better than the original, but in subtle ways. REPOSITORY R266 Breeze Icons REVISION DETAIL

D27840: Introduce SettingState* elements to ease KCM writing

2020-03-04 Thread Kevin Ottens
ervin edited the summary of this revision. ervin added reviewers: Frameworks, Plasma. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27840 To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, #frameworks, #plasma Cc: kde-frameworks-devel,

D27841: Port desktoptheme, icons and workspace KCMs to SettingStateBinding

2020-03-04 Thread Kevin Ottens
ervin edited the summary of this revision. ervin added reviewers: Frameworks, Plasma, VDG. ervin added a dependency: D27840: Introduce SettingState* elements to ease KCM writing. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27841 To: ervin, crossi, hchain,

D27840: Introduce SettingState* elements to ease KCM writing

2020-03-04 Thread Kevin Ottens
ervin added a dependent revision: D27841: Port desktoptheme, icons and workspace KCMs to SettingStateBinding. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27840 To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, #frameworks, #plasma Cc:

D27794: Fix symlink problem because of using relative path instead of full path

2020-03-04 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. Yes, the generation of relative symlinks is intentional and necessary. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27794 To: usta, ngraham, kossebau, ndavis Cc: kde-frameworks-devel,

D27804: smb: add hack to support spaces in workgroup names

2020-03-04 Thread Harald Sitter
sitter added a comment. In D27804#621970 , @thiago wrote: > Still want to see that round-trip. But why? Converting an smbcUrl to a QUrl would literally be useless code. REPOSITORY R320 KIO Extras REVISION DETAIL

D27839: Properly name the content of the kcmcontrols project

2020-03-04 Thread Kevin Ottens
ervin added reviewers: Frameworks, Plasma. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27839 To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, #frameworks, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27838: Port to new QML Connections syntax

2020-03-04 Thread Jonah Brüchert
jbbgameich added a reviewer: Frameworks. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D27838 To: jbbgameich, #frameworks Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D27842: [breeze-icons] New 48px telegram icon

2020-03-04 Thread Rocket Aaron
rocka created this revision. rocka added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. rocka requested review of this revision. REVISION SUMMARY Since 48px telegram icon was removed in D27787 , I made a

D27844: Store and fetch complete view config in and from session config

2020-03-04 Thread Friedrich W. H. Kossebau
kossebau added a comment. I am a bit surprised this was not already done before? Did I miss something? Settings like color scheme & zoom are not yet covered, but they might want to be restored as well fpr completeness, or? If someone changed them from the general settings, they might

D27839: Properly name the content of the kcmcontrols project

2020-03-04 Thread Kevin Ottens
ervin created this revision. ervin added reviewers: crossi, hchain, meven, bport, davidedmundson, mart, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY Looks like it was copied from

D27840: Introduce SettingState* elements to ease KCM writing

2020-03-04 Thread Kevin Ottens
ervin created this revision. ervin added reviewers: crossi, hchain, meven, bport, davidedmundson, mart, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY This is the QML based counterpart of

D27152: Introduce FilesystemEntry class

2020-03-04 Thread Stefan Brüns
bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > filesystem_entry_test.h:6 > + * it under the terms of the GNU General Public License as published by * > + * the Free Software Foundation; either version 2

D27839: Properly name the content of the kcmcontrols project

2020-03-04 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27839 To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, #frameworks, #plasma Cc: kde-frameworks-devel,

D27802: smb: fix ipv6 support

2020-03-04 Thread Christoph Feck
cfeck added a comment. Should this be in 19.12 branch? I am doing a respin of kio-extras anyway. REPOSITORY R320 KIO Extras BRANCH smb-smburl-static-autotest-ipv6 REVISION DETAIL https://phabricator.kde.org/D27802 To: sitter, ngraham Cc: cfeck, thiago, kde-frameworks-devel,

D27846: Fix KNewFileMenuTest

2020-03-04 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Commit ebbfe14309c54476fac changed

D27846: Fix KNewFileMenuTest

2020-03-04 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R241 KIO BRANCH l-KNewFileMenuTest (branched from master) REVISION DETAIL https://phabricator.kde.org/D27846 To: ahmadsamir, #frameworks, dfaure Cc:

D27851: Add rss icons in action

2020-03-04 Thread Carl Schwan
This revision was automatically updated to reflect the committed changes. Closed by commit R266:861f6ab52dc3: Add rss icons in action (authored by ognarb). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27851?vs=76976=76979 REVISION DETAIL

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 264 - Still Unstable!

2020-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/264/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 05 Mar 2020 00:06:28 + Build duration: 3 min 25 sec and counting JUnit Tests Name:

D27854: [Debug] Correct output of *::toTestMap(), silence non-error

2020-03-04 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY MDB_NOTFOUND is the mdb_cursor_get(.., MDB_NEXT) break condition, not an

D27838: Port to new QML Connections syntax

2020-03-04 Thread Aleix Pol Gonzalez
apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. Yes, can't be done until 5.14 is required in frameworks. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D27838 To: jbbgameich,

D25407: EBN cleanup to change quotes and transport protocol

2020-03-04 Thread John Hayes
jhayes abandoned this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25407 To: jhayes Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25865: kfilemetadata EBN transport protocol cleanup

2020-03-04 Thread John Hayes
jhayes abandoned this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25865 To: jhayes Cc: vkrause, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,

D27842: [breeze-icons] New 48px telegram icon

2020-03-04 Thread Rocket Aaron
rocka added a comment. Yes, I submitted it via the Web UI. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27842 To: rocka, #vdg, ngraham, ndavis Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27765: [FileContentIndexer] Remove duplicate condition check for loop break

2020-03-04 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:ed8cdf3d32f1: [FileContentIndexer] Remove duplicate condition check for loop break (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D27853: [WriteTransactionTest] Test removal of positions only

2020-03-04 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Test keeping the term, but removing all associated positions. Depends on

D27772: [WriteTransaction] Extend position test case

2020-03-04 Thread Stefan Brüns
bruns added a dependent revision: D27853: [WriteTransactionTest] Test removal of positions only. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D27772 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2,

D27848: Remove the panel tooltip icon

2020-03-04 Thread Aleix Pol Gonzalez
apol accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH remove-tooltip-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D27848 To: ngraham, #vdg, #plasma, cblack, niccolove, apol Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D27842: [breeze-icons] New 48px telegram icon

2020-03-04 Thread Noah Davis
ndavis accepted this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27842 To: rocka, #vdg, ngraham, ndavis Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 267 - Still Unstable!

2020-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/267/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 05 Mar 2020 03:51:12 + Build duration: 2 min 44 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 153 - Still Unstable!

2020-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/153/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 05 Mar 2020 03:51:12 + Build duration: 3 min 53 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 159 - Still Unstable!

2020-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/159/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 05 Mar 2020 03:51:12 + Build duration: 4 min 36 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.14 - Build # 42 - Fixed!

2020-03-04 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.14/42/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Thu, 05 Mar 2020 03:51:12 + Build duration: 6 min 31 sec and counting JUnit Tests

D27557: Auto-generate 24px monochrome icons

2020-03-04 Thread Nathaniel Graham
ngraham added a comment. Sorry, I was busy at a hackathon this weekend and am only just now catching up on KDE stuff. Thanks for the hotfix. To echo what Noah said, we'll be more careful in the future. This script probably needs to be rewritten in Python and the loop moved into CMake,

D27855: [Debug] Improve readability of positioninfo debug format

2020-03-04 Thread Stefan Brüns
bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The docId in hex is shorter and can be better compared with the serialized

D27833: Add an accessor to get the last loaded value for KConfigSkeletonItem

2020-03-04 Thread Aleix Pol Gonzalez
apol added a comment. What's the use-case? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27833 To: meven, ervin, bport, crossi, #frameworks Cc: apol, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25757: EBN purpose constructor cleanup

2020-03-04 Thread John Hayes
jhayes abandoned this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D25757 To: jhayes, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26089: baloo EBN transport protocol cleanup

2020-03-04 Thread John Hayes
jhayes abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D26089 To: jhayes, ngraham, bruns Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,

D26096: kio filewidgets EBN constructor cleanup

2020-03-04 Thread John Hayes
jhayes abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26096 To: jhayes Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 265 - Still Unstable!

2020-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/265/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 05 Mar 2020 03:18:42 + Build duration: 2 min 45 sec and counting JUnit Tests Name:

D27842: [breeze-icons] New 48px telegram icon

2020-03-04 Thread Noah Davis
ndavis added a comment. That's weird. It should say authored by @rocka, not me. @rocka, how did you submit this patch? Did you submit it via the web UI? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27842 To: rocka, #vdg, ngraham, ndavis Cc: ngraham,

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 157 - Still Unstable!

2020-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/157/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 05 Mar 2020 03:18:42 + Build duration: 2 min 5 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 158 - Still Unstable!

2020-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/158/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 05 Mar 2020 03:40:27 + Build duration: 2 min 23 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 266 - Still Unstable!

2020-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/266/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 05 Mar 2020 03:40:27 + Build duration: 2 min 33 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 152 - Still Unstable!

2020-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/152/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 05 Mar 2020 03:40:27 + Build duration: 1 min 55 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.14 - Build # 41 - Unstable!

2020-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.14/41/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Thu, 05 Mar 2020 03:40:27 + Build duration: 2 min 44 sec and counting JUnit Tests

D25827: kcodecs EBN transport protocol cleanup

2020-03-04 Thread John Hayes
jhayes abandoned this revision. REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D25827 To: jhayes, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27617: [breeze-icons] Add telegram-desktop tray icons

2020-03-04 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. You're pretty good at this. Most newbies struggle with all the little things that can bite you when making breeze icons. REPOSITORY R266 Breeze Icons REVISION DETAIL

D27617: [breeze-icons] Add telegram-desktop tray icons

2020-03-04 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:27740ce26135: [breeze-icons] Add telegram-desktop tray icons (authored by rocka, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D27617: [breeze-icons] Add telegram-desktop tray icons

2020-03-04 Thread Noah Davis
ndavis updated this revision to Diff 76987. ndavis edited the test plan for this revision. ndavis added a comment. Update author info REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27617?vs=76946=76987 BRANCH arcpatch-D27617_1 REVISION DETAIL

D27842: [breeze-icons] New 48px telegram icon

2020-03-04 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:38dc1aa148d7: [breeze-icons] New 48px telegram icon (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27842?vs=76956=76986 REVISION DETAIL

D27842: [breeze-icons] New 48px telegram icon

2020-03-04 Thread Noah Davis
ndavis added a comment. In D27842#622396 , @rocka wrote: > Yes, I submitted it via the Web UI. :/ that happens when people submit via the web UI for whatever reason. It'll no longer be an issue when we move KF5 to GitLab, but try to use

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 314 - Still Unstable!

2020-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/314/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 04 Mar 2020 22:02:23 + Build duration: 8 min 24 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 448 - Still Unstable!

2020-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/448/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 04 Mar 2020 22:02:22 + Build duration: 9 min 35 sec and counting BUILD ARTIFACTS

D27765: [FileContentIndexer] Remove duplicate condition check for loop break

2020-03-04 Thread Nathaniel Graham
ngraham added a comment. Hmm, changing the loop to `while (true)` would seem to reduce some safety if none of the break conditions are reached. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D27765 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77,

D27851: Add rss icons in action

2020-03-04 Thread Carl Schwan
ognarb edited the test plan for this revision. ognarb added a reviewer: ndavis. ognarb added a project: Breeze. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27851 To: ognarb, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, fbampaloukas, GB_2, trickyricky26,

D27839: Properly name the content of the kcmcontrols project

2020-03-04 Thread Nathaniel Graham
ngraham accepted this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27839 To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, #frameworks, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27802: smb: fix ipv6 support

2020-03-04 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH smb-smburl-static-autotest-ipv6 REVISION DETAIL https://phabricator.kde.org/D27802 To: sitter, ngraham Cc: thiago, kde-frameworks-devel, kfm-devel, pberestov, iasensio,

D27765: [FileContentIndexer] Remove duplicate condition check for loop break

2020-03-04 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > filecontentindexer.cpp:69 > #else > if (idList.isEmpty() || m_stop.loadRelaxed()) { > #endif @ngraham - you mean this condition, which comes immediately after? REPOSITORY R293 Baloo REVISION DETAIL

D27851: Add rss icons in action

2020-03-04 Thread Carson Black
cblack edited reviewers, added: VDG, Breeze; removed: ndavis. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27851 To: ognarb, #vdg, #breeze, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, fbampaloukas, GB_2, trickyricky26, michaelh, ngraham, bruns

D27851: Add rss icons in action

2020-03-04 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. In D27851#622296 , @cblack wrote: > SVG-wise, optimization here seems suboptimal. There's excess elements that could be removed. > >

D27848: Remove the tooltip icon

2020-03-04 Thread Niccolò Venerandi
niccolove accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH remove-tooltip-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D27848 To: ngraham, #vdg, #plasma, cblack, niccolove Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D27848: Remove the tooltip icon

2020-03-04 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY As discussed in T12778 , the icon can never

D27848: Remove the tooltip icon

2020-03-04 Thread Carson Black
cblack accepted this revision. cblack added a comment. This revision is now accepted and ready to land. Visually, LGTM. REPOSITORY R242 Plasma Framework (Library) BRANCH remove-tooltip-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D27848 To: ngraham, #vdg,

D27848: Remove the panel tooltip icon

2020-03-04 Thread Nathaniel Graham
ngraham added a comment. If the #plasma people accept, this would need to wait until Frameworks 5.70 to land or else rolling release distros will lose icons in half their tooltips, but not the rest. REPOSITORY R242 Plasma Framework (Library)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.13 - Build # 323 - Still Unstable!

2020-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.13/323/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 04 Mar 2020 22:02:23 + Build duration: 6 min 39 sec and counting BUILD ARTIFACTS

D27848: Remove the panel tooltip icon

2020-03-04 Thread Nathaniel Graham
ngraham retitled this revision from "Remove the tooltip icon" to "Remove the panel tooltip icon". REPOSITORY R242 Plasma Framework (Library) BRANCH remove-tooltip-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D27848 To: ngraham, #vdg, #plasma, cblack, niccolove

D27851: Add rss icons in action

2020-03-04 Thread Carl Schwan
ognarb created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ognarb requested review of this revision. TEST PLAN Soon REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27851 AFFECTED FILES

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 150 - Still Unstable!

2020-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/150/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 05 Mar 2020 00:06:28 + Build duration: 2 min 49 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 156 - Still Unstable!

2020-03-04 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/156/ Project: kf5-qt5 SUSEQt5.13 Date of build: Thu, 05 Mar 2020 00:06:28 + Build duration: 2 min 56 sec and counting JUnit Tests Name:

D27846: Fix KNewFileMenuTest

2020-03-04 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R241:b40856730534: Fix KNewFileMenuTest (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27846?vs=76968=76973 REVISION DETAIL

  1   2   >