D28121: Use libcanberra as primary means of previewing the sound

2020-03-18 Thread Harald Sitter
sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Your `if(` style is now inconsistent with the `endif(`. Code LGTM REPOSITORY R305 KNotifyConfig REVISION DETAIL https://phabricator.kde.org/D28121 To: broulik, #frameworks, sitter

D28114: Add call-incoming/missed/outgoing

2020-03-18 Thread Noah Davis
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:3e095e86bfae: Add call-incoming/missed/outgoing (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

2020-03-18 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:f4a6bf060b0c: [breeze-icons] fix shadow in some user (applets/128) icons (authored by rocka, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

2020-03-18 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. lgtm REPOSITORY R266 Breeze Icons BRANCH fix-user-icon-shadow_2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D28094 To: rocka, #vdg, ndavis Cc: ndavis,

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

2020-03-18 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, davidedmundson, cfeck, broulik, ervin, meven, bport. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY - Drop relative size bits, seems not that used - Use a

D28121: Use libcanberra as primary means of previewing the sound

2020-03-18 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Frameworks, sitter. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY So it matches what `KNotification` is doing, especially since Phonon

Re: Problems in KWayland causes by API and ABI compatibility promises

2020-03-18 Thread Vlad Zahorodnii
On 3/17/20 12:27 PM, David Edmundson wrote: IMHO we're lacking a "what actually is kwayland?" and an accurate definition of what's the added value compared to just using the auto generated classes directly. That's a good question! On one hand, it's nice to have Qt-friendly wrappers for

D28123: move setErrorMessage definition out of the linux ifdef

2020-03-18 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R285:91129f291efd: move setErrorMessage definition out of the linux ifdef (authored by sitter). REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28123?vs=77910=77913

D28112: [WIP] Expose application menu via KWindowInfo

2020-03-18 Thread Carson Black
cblack updated this revision to Diff 77915. cblack marked 8 inline comments as done. cblack added a comment. Address feedback REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28112?vs=77875=77915 BRANCH appmenu-x11 (branched from master) REVISION

D14910: Pass a dedicated fd to each keyboard for the xkb keymap

2020-03-18 Thread Vlad Zahorodnii
zzag updated this revision to Diff 77916. zzag added a comment. Rebase on master REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14910?vs=39945=77916 BRANCH arcpatch-D14910 REVISION DETAIL https://phabricator.kde.org/D14910 AFFECTED FILES

D26983: Enable adding place as first child

2020-03-18 Thread Nathaniel Graham
ngraham added a comment. That's not how this works; reviewers being slow is not a good reason to abandon a patch. If you've lost interest in it, you can ask someone else can take it over, but just throwing away the work is pretty sad. REPOSITORY R241 KIO REVISION DETAIL

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 283 - Still Unstable!

2020-03-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/283/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 18 Mar 2020 11:45:27 + Build duration: 2 min 1 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 169 - Still Unstable!

2020-03-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/169/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Mar 2020 11:45:27 + Build duration: 1 min 39 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 176 - Still Unstable!

2020-03-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/176/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 18 Mar 2020 11:45:27 + Build duration: 1 min 51 sec and counting JUnit Tests Name:

D28121: Use libcanberra as primary means of previewing the sound

2020-03-18 Thread Kai Uwe Broulik
broulik closed this revision. broulik added a comment. https://phabricator.kde.org/R305:4caaf107f1d4f45ff28d0de1b7e7e541e5827e3a REPOSITORY R305 KNotifyConfig REVISION DETAIL https://phabricator.kde.org/D28121 To: broulik, #frameworks, sitter Cc: kde-frameworks-devel, LeGast00n, cblack,

D27617: [breeze-icons] Add telegram-desktop tray icons

2020-03-18 Thread Alexey Min
alexeymin added a comment. F8182957: изображение.png Without badge... Same problem? I'm using dark plasma theme (but not Breeze-dark specifically, it is Sweet KDE) and normal Breeze for apps REPOSITORY R266 Breeze Icons REVISION DETAIL

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

2020-03-18 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 77904. ahmadsamir added a task: T12760: Port/move KFontDialog from KDELibs4Support to KWidgetAddons. ahmadsamir added a comment. Link to KF6 task REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D28123: move setErrorMessage definition out of the linux ifdef

2020-03-18 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY rather obvious in retrospect. the definition is OS-independent, the declaration

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 62 - Still Unstable!

2020-03-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/62/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Mar 2020 14:20:21 + Build duration: 6 min 51 sec and counting JUnit Tests Name:

D28112: Expose application menu via KWindowInfo

2020-03-18 Thread Vlad Zahorodnii
zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH appmenu-x11 (branched from master) REVISION DETAIL https://phabricator.kde.org/D28112 To: cblack, #plasma, broulik, zzag, #kwin Cc: zzag, kde-frameworks-devel, LeGast00n,

D28112: Expose application menu via KWindowInfo

2020-03-18 Thread Carson Black
This revision was automatically updated to reflect the committed changes. Closed by commit R278:93814b513d45: Expose application menu via KWindowInfo (authored by cblack). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28112?vs=77921=77922 REVISION

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 284 - Still Unstable!

2020-03-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/284/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 18 Mar 2020 11:57:42 + Build duration: 2 min 1 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 177 - Still Unstable!

2020-03-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/177/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 18 Mar 2020 11:57:42 + Build duration: 2 min 18 sec and counting JUnit Tests Name:

D27635: Restore kio-webdav plugin

2020-03-18 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. This revision is now accepted and ready to land. REPOSITORY R155 KAccounts Integration BRANCH arcpatch-D27635 REVISION DETAIL https://phabricator.kde.org/D27635 To: nicolasfella, bshah, leinir, #frameworks

D28112: Expose application menu via KWindowInfo

2020-03-18 Thread Carson Black
cblack retitled this revision from "[WIP] Expose application menu via KWindowInfo" to "Expose application menu via KWindowInfo". REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D28112 To: cblack, #plasma, broulik, zzag, #kwin Cc: zzag, kde-frameworks-devel,

D28112: Expose application menu via KWindowInfo

2020-03-18 Thread Carson Black
cblack marked 2 inline comments as done. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D28112 To: cblack, #plasma, broulik, zzag, #kwin Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28112: [WIP] Expose application menu via KWindowInfo

2020-03-18 Thread Carson Black
cblack updated this revision to Diff 77921. cblack added a comment. Plonk a space REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28112?vs=77915=77921 BRANCH appmenu-x11 (branched from master) REVISION DETAIL https://phabricator.kde.org/D28112

D28128: Add force save behavior to KEntryMap

2020-03-18 Thread Benjamin Port
bport created this revision. bport added reviewers: ervin, dfaure, meven, crossi, hchain. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bport requested review of this revision. REVISION SUMMARY Fix the following bug, if an entry is set on

D26858: Provide an implementation for the tablet interface

2020-03-18 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 77926. apol added a comment. Only delete when all the subscribed resources are gone. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26858?vs=77861=77926 BRANCH arcpatch-D26858 REVISION DETAIL

D28112: [WIP] Expose application menu via KWindowInfo

2020-03-18 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > netwm.cpp:3554 > + > +const char* NETWinInfo::appMenuObjectPath() const > +{ nit: add whitespace before `*` > netwm.cpp:3559 > + > +const char* NETWinInfo::appMenuServiceName() const > +{ ditto REPOSITORY R278 KWindowSystem REVISION DETAIL

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 170 - Still Unstable!

2020-03-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/170/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Mar 2020 11:57:42 + Build duration: 1 min 39 sec and counting JUnit Tests Name:

D28124: Port away from deprecated QSet methods

2020-03-18 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, apol, cfeck. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN make && ctest (some unit tests fail but are unrelated, as they fail on master too). REPOSITORY R236

D28123: move setErrorMessage definition out of the linux ifdef

2020-03-18 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R285 KCrash BRANCH master REVISION DETAIL https://phabricator.kde.org/D28123 To: sitter, apol Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27985: Include s_kcrashErrorMessage in our traces

2020-03-18 Thread Kai Uwe Broulik
broulik added a comment. When this symbol isn't present, gdb just aborts and you don't get any back trace anymore: Error in sourced command file: No symbol "s_kcrashErrorMessage" in current context. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D27985

D27828: [server] Introduce SurfaceInterface::boundingRect()

2020-03-18 Thread Vlad Zahorodnii
This revision was automatically updated to reflect the committed changes. Closed by commit R127:deb476e47d47: [server] Introduce SurfaceInterface::boundingRect() (authored by zzag). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27828?vs=76922=77918

D28112: Expose application menu via KWindowInfo

2020-03-18 Thread Carson Black
cblack edited the summary of this revision. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D28112 To: cblack, #plasma, broulik, zzag, #kwin Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28033: Create ExpandableListItem

2020-03-18 Thread Nathaniel Graham
ngraham added a comment. Will beef up the docs next INLINE COMMENTS > davidedmundson wrote in ExpandableListItem.qml:230 > I meant the duration Not sure what you mean by "random." It's a multiple of a standard duration that I chose to look good (IMO). REPOSITORY R242 Plasma Framework

D28033: Create ExpandableListItem

2020-03-18 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > ngraham wrote in ExpandableListItem.qml:2 > Where should it live? PC2? Kirigami? Definitely can't be in PC2. Kirigami is doable, but it'd require some code changes to not use any Plasma.* imports and go through relevant abstractions

D28124: Port away from deprecated QSet methods

2020-03-18 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R236:8d993d727fce: Port away from deprecated QSet methods (authored by ahmadsamir). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28124?vs=77911=77928 REVISION

D28033: Create ExpandableListItem

2020-03-18 Thread Nathaniel Graham
ngraham updated this revision to Diff 77947. ngraham added a comment. Fix a whitespace thingy REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28033?vs=77946=77947 BRANCH ExpandableListItem (branched from master) REVISION DETAIL

D25517: Add an option to extract image data and add front cover property

2020-03-18 Thread Alexander Stippich
astippich updated this revision to Diff 77954. astippich added a comment. - fix label comment - tweaks - rename flag to ImageData - adress review comments - udpate since tag - update since tag REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D27617: [breeze-icons] Add telegram-desktop tray icons

2020-03-18 Thread Nathaniel Graham
ngraham added a comment. Would it help this use case if we moved the Telegram icon into the Plasma theme for now, pending a fix in Telegram itself? On that subject, has anyone submitted a bug report to them about their inappropriate use of pixmaps? REPOSITORY R266 Breeze Icons REVISION

D28129: Read the new message string after rather than before

2020-03-18 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. <3 REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D28129 To: apol, #frameworks, broulik, sitter Cc: plasma-devel, Orage, LeGast00n,

D28129: Read the new message string after rather than before

2020-03-18 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Frameworks, broulik, sitter. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY This way if we're linking against an old KF5, we still generate a backtrace

D28112: Expose application menu via KWindowInfo

2020-03-18 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > kwindowinfo.h:579 > + * > + * Requires NET::WMPid passed as properties parameter to the constructor. > + * Copy paste error, requires `NET::WM2ApplicationMenuServiceName` > kwindowinfo.h:588 > + * > + * Requires NET::WMPid

D28033: Create ExpandableListItem

2020-03-18 Thread Nathaniel Graham
ngraham added a comment. (WRT duration) What should I do then? Hardcode something? Add a new duration in a separate patch? The only standard durations we have are all quite short; neither one feels suitable for the animation I'm using here. Also we multiply distance units by factors all

D28130: Introduce api for passive notifications

2020-03-18 Thread Marco Martin
mart edited the summary of this revision. mart edited the test plan for this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D28130 To: mart Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28131: listen to passiveNotificationRequested

2020-03-18 Thread Marco Martin
mart created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY show passive notifications when the kcm asks to see D28130 REPOSITORY R295 KCMUtils

KDE CI: Frameworks » kwidgetsaddons » kf5-qt5 FreeBSDQt5.13 - Build # 79 - Unstable!

2020-03-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwidgetsaddons/job/kf5-qt5%20FreeBSDQt5.13/79/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Mar 2020 15:21:51 + Build duration: 3 min 53 sec and counting JUnit Tests

D26983: Enable adding place as first child

2020-03-18 Thread George Vogiatzis
gvgeo added a comment. In D26983#629925 , @ngraham wrote: > That's not how this works; reviewers being slow is not a good reason to abandon a patch. If you've lost interest in it, you can ask someone else can take it over, but just throwing

D28129: Read the new message string after rather than before

2020-03-18 Thread Aleix Pol Gonzalez
apol planned changes to this revision. apol added a comment. Just tested it properly, it fails to generate a backtrace altogether :( REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D28129 To: apol, #frameworks, broulik, sitter Cc: plasma-devel, Orage, LeGast00n,

D26858: Provide an implementation for the tablet interface

2020-03-18 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > tablet_interface.cpp:58 > +if (resourceMap().isEmpty()) { > +delete q; > +} This is still potentially crashy: if all clients remove their tablet support we would have a dangling pointer in m_tablets.

D28130: Introduce api for passive notifications

2020-03-18 Thread Marco Martin
mart created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mart requested review of this revision. REVISION SUMMARY showPassiveNotification which mirrors ApplicationWindow.showPassiveNotification some kcms need to show a tiny non

D28033: Create ExpandableListItem

2020-03-18 Thread Marco Martin
mart added a comment. to me it should be in plasma extracomponents (and with a warning in the docs that such an item should be used only in lists that are known to have always very few items) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D28020: New class ProcessLauncherJob in KIOGui

2020-03-18 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kprocessrunner.cpp:194 > +{ > +return m_process->waitForStarted(); > +} It's the DBus calls that come before start that I want to get async, not

D28124: Port away from deprecated QSet methods

2020-03-18 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH l-qset-deprecated-methods (branched from master) REVISION DETAIL https://phabricator.kde.org/D28124 To: ahmadsamir, #frameworks, apol, cfeck Cc: kde-frameworks-devel,

D26858: Provide an implementation for the tablet interface

2020-03-18 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > davidedmundson wrote in tablet_interface.cpp:58 > This is still potentially crashy: > if all clients remove their tablet support we would have a dangling pointer > in m_tablets. > > Personally I would remove this delete q, and have the

D28033: Create ExpandableListItem

2020-03-18 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > ngraham wrote in ExpandableListItem.qml:230 > Not sure what you mean by "random." It's a multiple of a standard duration > that I chose to look good (IMO). If it's multiplied by a factor it's not a "standard duration" anymore. REPOSITORY

D28033: Create ExpandableListItem

2020-03-18 Thread Nathaniel Graham
ngraham updated this revision to Diff 77935. ngraham marked 4 inline comments as done. ngraham added a comment. Move to PlasmaExtraComponents REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28033?vs=77702=77935 BRANCH

D28131: listen to passiveNotificationRequested

2020-03-18 Thread Marco Martin
mart edited the test plan for this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28131 To: mart Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28033: Create ExpandableListItem

2020-03-18 Thread Nathaniel Graham
ngraham updated this revision to Diff 77946. ngraham added a comment. Add API docs REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28033?vs=77935=77946 BRANCH ExpandableListItem (branched from master) REVISION DETAIL

D25518: Extract front cover in the taglib extractor

2020-03-18 Thread Alexander Stippich
astippich updated this revision to Diff 77956. astippich added a comment. - adapt to changes REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25518?vs=73098=77956 BRANCH taglibBinaryExtraction REVISION DETAIL https://phabricator.kde.org/D25518

D17816: Support for xattrs on kio copy/move

2020-03-18 Thread Cochise César
cochise added inline comments. INLINE COMMENTS > dfaure wrote in jobtest.cpp:118 > typo in Xatr, and in "foud". I suggest: > > qWarning() << "Neither getfattr, getextattr nor xattr was found"; > > Although I have to wonder why this looks for all three, to then only use > getfattr and skip

D28020: New class ProcessLauncherJob in KIOGui

2020-03-18 Thread David Faure
dfaure added a comment. Ah there was still the WId question. I'll remove it before anyone starts using this API. We can always add a setter later if we want to (but if it's just for the unused setLaunchedBy, I'm not convinced...) REPOSITORY R241 KIO REVISION DETAIL

D17816: Support for xattrs on kio copy/move

2020-03-18 Thread Cochise César
cochise updated this revision to Diff 77962. cochise added a comment. Tried to make a function to feed m_keyList on BSD, but the result was somewhat ugly. I don't like to use buffers if I can have typed data, but libc uses buffers, so maybe I was putting the sqare piece on the circle hole.

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 127 - Still Unstable!

2020-03-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/127/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 18 Mar 2020 20:35:31 + Build duration: 4 min 24 sec and counting BUILD ARTIFACTS

D27617: [breeze-icons] Add telegram-desktop tray icons

2020-03-18 Thread Nathaniel Graham
ngraham added a comment. So... how do we fix this so that you can use a nice monochrome Breeze icon in your system tray? Whose code needs to change? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27617 To: rocka, #vdg, Fuchs, ndavis Cc: broulik, alexeymin,

D27635: Restore kio-webdav plugin

2020-03-18 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R155:693d7361428e: Restore kio-webdav plugin (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27635?vs=77280=77965#toc REPOSITORY R155 KAccounts Integration CHANGES

D28033: Create ExpandableListItem

2020-03-18 Thread Nathaniel Graham
ngraham edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To: ngraham, #vdg, #plasma, davidedmundson Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, kde-frameworks-devel, LeGast00n, GB_2,

D25679: Implement writing of front cover in taglibwriter

2020-03-18 Thread Alexander Stippich
astippich updated this revision to Diff 77959. astippich added a comment. - adapt to changes - use QMimeDatabase REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25679?vs=73099=77959 BRANCH tagLibBinaryWrite REVISION DETAIL

D27617: [breeze-icons] Add telegram-desktop tray icons

2020-03-18 Thread Noah Davis
ndavis added a subscriber: broulik. ndavis added a comment. In D27617#629987 , @ngraham wrote: > Would it help this use case if we moved the Telegram icon into the Plasma theme for now, pending a fix in Telegram itself? On that subject, has

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 336 - Still Unstable!

2020-03-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/336/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Mar 2020 20:17:11 + Build duration: 8 min 45 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 97 - Fixed!

2020-03-18 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/97/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Mar 2020 21:11:02 + Build duration: 14 min and counting JUnit Tests Name: projectroot

D28093: [breeze-icons] add TeamViewer tray icons

2020-03-18 Thread Nathaniel Graham
ngraham added a comment. I didn't notice it before, but this patch makes TeamViewer's app icon always use the monochrome version now: F8183406: Screenshot_20200318_132426.png We already have a Breeze icon for TeamViewer called `teamviewer` note the

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 337 - Still Unstable!

2020-03-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/337/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Mar 2020 20:34:46 + Build duration: 8 min 0 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.12 - Build # 128 - Fixed!

2020-03-18 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.12/128/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 18 Mar 2020 21:11:01 + Build duration: 4 min 18 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kservice » kf5-qt5 SUSEQt5.13 - Build # 101 - Fixed!

2020-03-18 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20SUSEQt5.13/101/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 18 Mar 2020 21:11:01 + Build duration: 6 min 31 sec and counting BUILD ARTIFACTS

D28020: New class ProcessLauncherJob in KIOGui

2020-03-18 Thread David Faure
dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28020 To: dfaure, apol, davidedmundson, nicolasfella, vkrause, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D17816: Support for xattrs on kio copy/move

2020-03-18 Thread Cochise César
cochise marked 9 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika,

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

2020-03-18 Thread David Faure
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. OK with me, but check with the fuse people. You test ssh, telnet etc but hasSchemeHandler is also true for at least http. REPOSITORY R241 KIO BRANCH l-krun-ssh (branched from

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

2020-03-18 Thread Ahmad Samir
ahmadsamir added a comment. In D27999#630193 , @dfaure wrote: > OK with me, but check with the fuse people. > > You test ssh, telnet etc but hasSchemeHandler is also true for at least http. While I was debugging this issue, I found

D17816: Support for xattrs on kio copy/move

2020-03-18 Thread Cochise César
cochise updated this revision to Diff 77955. cochise marked 9 inline comments as done. cochise added a comment. Small fixes. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=77804=77955 BRANCH arcpatch-D17816_1 REVISION DETAIL

D25517: Add an option to extract image data and add front cover property

2020-03-18 Thread Alexander Stippich
astippich added a comment. Since I got one accept and no other response, I will merge on the weekend REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D25517 To: astippich, #baloo, bruns, mgallien, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs,

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

2020-03-18 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 77964. ahmadsamir added a comment. Rebase on master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27999?vs=77538=77964 BRANCH l-krun-ssh (branched from master) REVISION DETAIL https://phabricator.kde.org/D27999

D27951: Allow users to change dropAction to MoveAction through kdeglobals

2020-03-18 Thread Tranter Madi
trmdi added a comment. Friendly ping. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27951 To: trmdi, ngraham, dfaure, meven, #vdg, davidedmundson Cc: elvisangelaccio, davidedmundson, meven, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28093: [breeze-icons] add TeamViewer tray icons

2020-03-18 Thread Rocket Aaron
rocka added a comment. Could we just create a symlink TeamViewer.svg points to 48px teamviewer.svg? And I noticed that in their latest version, they changed the Icon in desktop entry file to TeamViewer, and all the installed icons were named TeamViewer. After creating that symlink, the

D28093: [breeze-icons] add TeamViewer tray icons

2020-03-18 Thread Nathaniel Graham
ngraham added a comment. That will help for people using thick panels who see larger icons, but users of thin panels will still get the monochrome icon. It's yet another example of our inability to deterministically T10413: Find a way to specify whether to use monochrome or color icons

D28020: New class ProcessLauncherJob in KIOGui

2020-03-18 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > davidedmundson wrote in kprocessrunner.cpp:194 > It's the DBus calls that come before start that I want to get async, not the > tiny bit between fork and the child process exec()'ing. > > Obviously we can do that piecemeal later, and it isn't a

D28108: Handle busybox's sed like GNU sed

2020-03-18 Thread Heiko Becker
This revision was automatically updated to reflect the committed changes. Closed by commit R266:0855a40a1131: Handle busyboxs sed like GNU sed (authored by heikobecker). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28108?vs=77864=77880 REVISION DETAIL

D28114: Add call-incoming/missed/outgoing

2020-03-18 Thread Bhushan Shah
bshah added a subscriber: jbbgameich. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28114 To: ndavis, #vdg Cc: jbbgameich, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28114: Add call-incoming/missed/outgoing

2020-03-18 Thread Carson Black
cblack requested changes to this revision. cblack added a comment. This revision now requires changes to proceed. The 16px icons should probably drop the phone, as the distinguishing elements between them are so small as to impair the ease of telling the icons apart. Legibility should be

D26983: Enable adding place as first child

2020-03-18 Thread George Vogiatzis
gvgeo abandoned this revision. gvgeo added a comment. Thanks for your help @meven, but I 'll close this patch now. It doesn't seem to be high in priorities. And to be honest among other reasons, after I found how problematic the code is, I'm not so keen on building on top of it.

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 168 - Still Unstable!

2020-03-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/168/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 18 Mar 2020 07:13:44 + Build duration: 1 min 35 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 282 - Still Unstable!

2020-03-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/282/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 18 Mar 2020 07:13:44 + Build duration: 2 min 37 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 175 - Still Unstable!

2020-03-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/175/ Project: kf5-qt5 SUSEQt5.13 Date of build: Wed, 18 Mar 2020 07:13:44 + Build duration: 1 min 49 sec and counting JUnit Tests Name:

D28114: Add call-incoming/missed/outgoing

2020-03-18 Thread Noah Davis
ndavis edited the summary of this revision. ndavis edited the test plan for this revision. ndavis added a subscriber: bshah. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28114 To: ndavis, #vdg Cc: bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28114: Add call-incoming/missed/outgoing

2020-03-18 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH call-history (branched from master) REVISION DETAIL

D28112: [WIP] Expose application menu via KWindowInfo

2020-03-18 Thread Vlad Zahorodnii
zzag added inline comments. INLINE COMMENTS > netwm.cpp:4697-4707 > if (dirty2 & WM2GTKFrameExtents) { > p->gtk_frame_extents = NETStrut(); > > QVector data = get_array_reply(p->conn, > cookies[c++], XCB_ATOM_CARDINAL); > if (data.count() == 4) { >

D28002: [WIP]Allow disabling of data collection

2020-03-18 Thread George Vogiatzis
gvgeo abandoned this revision. gvgeo added a comment. Don't see any interest (or response), made a bug report instead. https://bugs.kde.org/show_bug.cgi?id=418981 REPOSITORY R849 User Feedback Collection Framework REVISION DETAIL https://phabricator.kde.org/D28002 To: gvgeo,

D28114: Add call-incoming/missed/outgoing

2020-03-18 Thread Noah Davis
ndavis updated this revision to Diff 77889. ndavis added a comment. - Move to status category - Make phone size better and more consistent at 16px REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28114?vs=77877=77889 BRANCH call-history (branched

  1   2   >