D27504: smb faster copy to local

2020-03-20 Thread Méven Car
meven added a comment. Looks good to me. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27504 To: sitter, ngraham, cfeck, #frameworks, #dolphin Cc: meven, hallas, anthonyfieroni, asturmlechner, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice,

D28128: Add force save behavior to KEntryMap

2020-03-20 Thread Méven Car
meven added inline comments. INLINE COMMENTS > kconfigdata.cpp:139 > > +// If overidded entry is global and not default. And it's overrided by a > non global > +if (e.bGlobal && !(options & EntryGlobal) && !k.bDefault) s/overidded/overridden REPOSITORY R237 KConfig REVISION

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

2020-03-20 Thread Méven Car
meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Seems good to me. Please wait for me review. REPOSITORY R236 KWidgetsAddons BRANCH l-kfontdlg (branched from master) REVISION DETAIL https://phabricator.kde.org/D28122 To:

Re: 2 kirigami fixes for a point release

2020-03-20 Thread David Edmundson
>> > Kirigami seems to be rather unstable, I wonder if anything can be done to >> > improve upon that [*]. > >> One important thing seems to have been getting sloppy in those repos; >> mandatory code reviews. >> That's an easy thing to enforce, and we know it makes a huge difference to >> code. >>

D27235: add calindori icon in the new pm style

2020-03-20 Thread Mathis Brüchert
mbruchert updated this revision to Diff 78085. mbruchert added a comment. - remove hole REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27235?vs=75236=78085 BRANCH calindori (branched from master) REVISION DETAIL

D27246: add buho icon

2020-03-20 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R266 Breeze Icons BRANCH buho (branched from master) REVISION DETAIL https://phabricator.kde.org/D27246 To: mbruchert, camiloh, #vdg, ndavis Cc: cblack, ndavis,

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 287 - Still Unstable!

2020-03-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/287/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 20 Mar 2020 11:46:20 + Build duration: 2 min 3 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 173 - Still Unstable!

2020-03-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/173/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 20 Mar 2020 11:46:20 + Build duration: 2 min 38 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 180 - Still Unstable!

2020-03-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/180/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 20 Mar 2020 11:46:20 + Build duration: 2 min 44 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 286 - Still Unstable!

2020-03-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/286/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 20 Mar 2020 11:34:09 + Build duration: 2 min 20 sec and counting JUnit Tests Name:

D27235: add calindori icon in the new pm style

2020-03-20 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:e715ff69549e: add calindori icon in the new pm style (authored by mbruchert, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D27235: add calindori icon in the new pm style

2020-03-20 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH calindori (branched from master) REVISION DETAIL https://phabricator.kde.org/D27235 To: mbruchert, dkardarakos, #vdg, ndavis Cc: ngraham, kde-frameworks-devel, LeGast00n,

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 179 - Still Unstable!

2020-03-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/179/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 20 Mar 2020 11:34:09 + Build duration: 2 min 20 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 172 - Still Unstable!

2020-03-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/172/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 20 Mar 2020 11:34:09 + Build duration: 2 min 22 sec and counting JUnit Tests Name:

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

2020-03-20 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: dfaure, sitter, apol. Herald added projects: Dolphin, Frameworks. Herald added a subscriber: kfm-devel. ahmadsamir requested review of this revision. TEST PLAN Showing man pages in konqueror still works REPOSITORY R320 KIO Extras

KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.12 - Build # 108 - Fixed!

2020-03-20 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.12/108/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 20 Mar 2020 11:15:03 + Build duration: 6 min 11 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kcmutils » kf5-qt5 SUSEQt5.13 - Build # 75 - Fixed!

2020-03-20 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20SUSEQt5.13/75/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 20 Mar 2020 11:15:21 + Build duration: 6 min 2 sec and counting BUILD ARTIFACTS

D27255: nota

2020-03-20 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R266 Breeze Icons BRANCH nota (branched from master) REVISION DETAIL https://phabricator.kde.org/D27255 To: mbruchert, camiloh, #vdg, ngraham, ndavis Cc: ngraham,

D27210: add KDEconnect Icons

2020-03-20 Thread Noah Davis
ndavis added a comment. Hmm. I'm not into the color icon. These combinations of colors and shapes just seem very foreign to Breeze. If KDE Connect wants to change its icon branding, maybe they should have some elements that are a bit more abstract/stylized than the current color icon? I

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

2020-03-20 Thread Ahmad Samir
ahmadsamir added a comment. (Also could some one with more power than me clang-format this whole repo (there's a clang-format.cmake in extra-cmake-modules)? just note that some hand-formatted char* definitions blow up :)). REPOSITORY R320 KIO Extras REVISION DETAIL

D24895: [RFC] Drop implicit size from PC buttons

2020-03-20 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Marking as request changes as per my comments above REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24895 To:

D28131: listen to passiveNotificationRequested

2020-03-20 Thread Kai Uwe Broulik
broulik added a comment. Depends on kdeclarative, if that is rebuilt, a rebuild of kcmutil should fix that REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28131 To: mart, broulik Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28131: listen to passiveNotificationRequested

2020-03-20 Thread David Faure
dfaure added a comment. CI is not happy: https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kcmutils/job/kf5-qt5%20SUSEQt5.12/107/console REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28131 To: mart, broulik Cc: dfaure, kde-frameworks-devel,

D27255: Add nota icon

2020-03-20 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:c40434acbf70: Add nota icon (authored by mbruchert, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27255?vs=78083=78084 REVISION DETAIL

D27210: add KDEconnect Icons

2020-03-20 Thread Mathis Brüchert
mbruchert added a comment. hmm I don't think that It is a problem because both devices the app can run on are depicted REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27210 To: mbruchert, #vdg, #kde_connect, ngraham Cc: ngraham, albertvaka, nicolasfella,

D27255: Add nota icon

2020-03-20 Thread Noah Davis
ndavis retitled this revision from "nota" to "Add nota icon". REPOSITORY R266 Breeze Icons BRANCH nota (branched from master) REVISION DETAIL https://phabricator.kde.org/D27255 To: mbruchert, camiloh, #vdg, ngraham, ndavis Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack,

D27246: add buho icon

2020-03-20 Thread Mathis Brüchert
mbruchert updated this revision to Diff 78086. mbruchert added a comment. - fix shadows REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27246?vs=75269=78086 BRANCH buho (branched from master) REVISION DETAIL https://phabricator.kde.org/D27246

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.13 - Build # 174 - Still Unstable!

2020-03-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.13/174/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 20 Mar 2020 11:50:45 + Build duration: 2 min 28 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.13 - Build # 181 - Still Unstable!

2020-03-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.13/181/ Project: kf5-qt5 SUSEQt5.13 Date of build: Fri, 20 Mar 2020 11:50:45 + Build duration: 2 min 13 sec and counting JUnit Tests Name:

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 288 - Still Unstable!

2020-03-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/288/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 20 Mar 2020 11:50:45 + Build duration: 2 min 24 sec and counting JUnit Tests Name:

D27214: add puremaps icon

2020-03-20 Thread Mathis Brüchert
mbruchert added a comment. there is only a puremaps flatpak and the icon there is called 'io.github.rinigus.PureMaps.png' should it be renamed to that? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27214 To: mbruchert, #vdg, ndavis Cc: kde-frameworks-devel,

D28128: Add force save behavior to KEntryMap

2020-03-20 Thread Méven Car
meven accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28128 To: bport, ervin, dfaure, meven, crossi, hchain Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27255: nota

2020-03-20 Thread Mathis Brüchert
mbruchert updated this revision to Diff 78083. mbruchert added a comment. - update dotted lines REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27255?vs=75271=78083 BRANCH nota (branched from master) REVISION DETAIL

D27246: add buho icon

2020-03-20 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:01354ce40243: add buho icon (authored by mbruchert, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27246?vs=78086=78088 REVISION DETAIL

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

2020-03-20 Thread David Faure
dfaure added a comment. This commit breaks krununittest in CI, can you take a look? https://build.kde.org/job/Frameworks/view/Platform%20-%20SUSEQt5.12/job/kio/job/kf5-qt5%20SUSEQt5.12/471/testReport/junit/projectroot/autotests/kiowidgets_krununittest/ Thanks. REPOSITORY R241 KIO

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

2020-03-20 Thread Friedrich W. H. Kossebau
kossebau added a comment. Please also add a note in the documentation when to use KFontDialog and when QFontDialog, i.e. in which use-cases KFontDialog is superior and not using the non-platform one is justified. REPOSITORY R236 KWidgetsAddons BRANCH l-kfontdlg (branched from master)

D28144: Make animation durations consistent with Kirigami values

2020-03-20 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH improved-durations (branched from master) REVISION DETAIL https://phabricator.kde.org/D28144 To: ngraham, #plasma, davidedmundson, mart Cc:

D28144: Make animation durations consistent with Kirigami values

2020-03-20 Thread Nathaniel Graham
ngraham added a dependent revision: D28033: Create ExpandableListItem. REPOSITORY R242 Plasma Framework (Library) BRANCH improved-durations (branched from master) REVISION DETAIL https://phabricator.kde.org/D28144 To: ngraham, #plasma, davidedmundson, mart Cc: kde-frameworks-devel,

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

2020-03-20 Thread Friedrich W. H. Kossebau
kossebau added a comment. Moving a class (and thus its exported symbols) from a library to another one in its public dependency interface should be doable I guess (no actual experience in having done that though). But you sadly cannot change/remove exported symbols and the data layout,

D28033: Create ExpandableListItem

2020-03-20 Thread Nathaniel Graham
ngraham edited the summary of this revision. ngraham added a dependency: D28144: Make animation durations consistent with Kirigami values. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To: ngraham, #vdg, #plasma, davidedmundson Cc: mart,

D28033: Create ExpandableListItem

2020-03-20 Thread Nathaniel Graham
ngraham updated this revision to Diff 78104. ngraham added a comment. Use the new `veryLongDuration` duration instead a multiple of `longDuration` REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28033?vs=78103=78104 BRANCH

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

2020-03-20 Thread Ahmad Samir
ahmadsamir added a comment. In D27999#631255 , @dfaure wrote: > This commit breaks krununittest in CI, can you take a look? > >

D28033: Create ExpandableListItem

2020-03-20 Thread Nathaniel Graham
ngraham marked 4 inline comments as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To: ngraham, #vdg, #plasma, davidedmundson Cc: mart, davidedmundson, bruns, niccolove, cblack, davidre, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D28144: Make animation durations consistent with Kirigami values

2020-03-20 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R242:049978008b12: Make animation durations consistent with Kirigami values (authored by ngraham). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

2020-03-20 Thread Ahmad Samir
ahmadsamir added a comment. In D28122#631237 , @kossebau wrote: > Moving a class (and thus its exported symbols) from a library to another one in its public dependency interface should be doable I guess (no actual experience in having done that

D28033: Create ExpandableListItem

2020-03-20 Thread Nathaniel Graham
ngraham updated this revision to Diff 78103. ngraham added a comment. Rebase REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28033?vs=77947=78103 BRANCH ExpandableListItem (branched from master) REVISION DETAIL

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

2020-03-20 Thread Ahmad Samir
ahmadsamir added a comment. OK, I see why it's failing. KMimeTypeTrader::self()->preferredService() (from schemeService()) can't find ktelnetservice5.desktop in /usr/share/applications/ since KIO isn't installed on the CI system; so skip the test in that case? REPOSITORY R241 KIO

D28164: Add test for application menu in PWM interface

2020-03-20 Thread Carson Black
This revision was automatically updated to reflect the committed changes. Closed by commit R127:4f4142d3d3a8: Add test for application menu in PWM interface (authored by cblack). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28164?vs=78109=78111 REVISION

D28164: Add test for application menu in PWM interface

2020-03-20 Thread Carson Black
cblack created this revision. cblack added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cblack requested review of this revision. TEST PLAN See that the test works as expected. REPOSITORY R127 KWayland BRANCH cblack/appmenu-tests

D28163: Add input-dialpad and call-voicemail

2020-03-20 Thread Nathaniel Graham
ngraham added a comment. The 22px dialpad icon looks a bit stretched horizontally to me to my eyes. The others look fine. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28163 To: ndavis, #vdg Cc: ngraham, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D28163: Add input-dialpad and call-voicemail

2020-03-20 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28163 To: ndavis, #vdg Cc: bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28164: Add test for application menu in PWM interface

2020-03-20 Thread Vlad Zahorodnii
zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH cblack/appmenu-tests (branched from master) REVISION DETAIL https://phabricator.kde.org/D28164 To: cblack, #kwin, zzag Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D28163: Add input-dialpad and call-voicemail

2020-03-20 Thread Noah Davis
ndavis added a comment. In D28163#631343 , @ngraham wrote: > The 22px dialpad icon looks a bit stretched horizontally to me to my eyes. The others look fine. I agree, but it's really hard to get the proportions right and have it respect

D28163: Add input-dialpad and call-voicemail

2020-03-20 Thread Nathaniel Graham
ngraham added a comment. I thought the margins were maximums. Making the icon skinnier seems fine to me. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28163 To: ndavis, #vdg Cc: ngraham, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28163: Add input-dialpad and call-voicemail

2020-03-20 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Requested by @bshah for Plasma Mobile REPOSITORY R266 Breeze Icons BRANCH

D28163: Add input-dialpad and call-voicemail

2020-03-20 Thread Noah Davis
ndavis added a comment. In D28163#631346 , @ngraham wrote: > I thought the margins were maximums. Making the icon skinnier seems fine to me. they are maximums. those guides are at the canvas size. At the correct proportion, it's 22px

D28129: Read the new message string after rather than before

2020-03-20 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 78117. apol added a comment. This revision is now accepted and ready to land. Fix it in a theoretically better but more convoluted way REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28129?vs=77929=78117 BRANCH master

Re: 2 kirigami fixes for a point release

2020-03-20 Thread David Faure
On vendredi 20 mars 2020 12:16:09 CET David Edmundson wrote: > >> > Kirigami seems to be rather unstable, I wonder if anything can be done > >> > to > >> > improve upon that [*]. > >> > >> One important thing seems to have been getting sloppy in those repos; > >> mandatory code reviews. > >>

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

2020-03-20 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 78124. ahmadsamir added a comment. - Rename to KFontChooserDialog to prevent conflict with the one from KDELibs4Support - Document "features" REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D28168: Broadcast application menu to resources when registering them

2020-03-20 Thread Carson Black
cblack created this revision. cblack added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cblack requested review of this revision. REVISION SUMMARY Previously, KWayland wasn't hanging onto the application menu to broadcast it when

D28169: [DesktopExecParser] Let the service open protocols is claims to support

2020-03-20 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, sitter, feverfew, ngraham. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY This reverts commit 14b7f2c7ee72b

D28169: [DesktopExecParser] Let the service open protocols is claims to support

2020-03-20 Thread David Faure
dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > desktopexecparser.cpp:350 > const QUrl url = d->urls.at(i); > -if (hasSchemeHandler(url)) { > + // if the app/service

D27999: [DesktopExecParser] Open {ssh, telnet, rlogin}:// urls with ktelnetservice

2020-03-20 Thread Ahmad Samir
ahmadsamir added a comment. See D28169 . REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D27999 To: ahmadsamir, #frameworks, dfaure, sitter, meven, feverfew, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28122: Move/port KFontDialog from KDELibs4Support to KWidgetAddons

2020-03-20 Thread Ahmad Samir
ahmadsamir added a comment. In D28122#631254 , @kossebau wrote: > Please also add a note in the documentation when to use new-name-of-KFontDialog and when QFontDialog, i.e. in which use-cases new-name-of-KFontDialog is superior and not

D28169: [DesktopExecParser] Let the service open protocols is claims to support

2020-03-20 Thread Ahmad Samir
ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in desktopexecparser.cpp:350 > Doesn't this break the special case in the comment below? > VLC claims to support smb:// but if we have a password, we need to be able to > pass it, so we want to use KIOFuse? > > And then if you

D28163: Add input-dialpad and call-voicemail

2020-03-20 Thread Nathaniel Graham
ngraham added a comment. Maybe we could keep the dots 2x2 for the 22px version? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28163 To: ndavis, #vdg Cc: ngraham, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28168: Broadcast application menu to resources when registering them

2020-03-20 Thread Vlad Zahorodnii
zzag accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH cblack/broadcast-appmenu-on-resource-register (branched from master) REVISION DETAIL https://phabricator.kde.org/D28168 To: cblack, #kwin, zzag Cc: kde-frameworks-devel, zzag,

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 68 - Still Unstable!

2020-03-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/68/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 21 Mar 2020 01:25:48 + Build duration: 33 min and counting JUnit Tests Name:

D28163: Add input-dialpad and call-voicemail

2020-03-20 Thread Nathaniel Graham
ngraham added a comment. Well, I'm out of ideas REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28163 To: ndavis, #vdg Cc: ngraham, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28163: Add input-dialpad and call-voicemail

2020-03-20 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28163 To: ndavis, #vdg Cc: ngraham, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28163: Add input-dialpad and call-voicemail

2020-03-20 Thread Noah Davis
ndavis updated this revision to Diff 78136. ndavis added a comment. - Use evenly distributed and proportioned style for dialpad REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28163?vs=78107=78136 BRANCH dialpad-voicemail (branched from master)

D28163: Add input-dialpad and call-voicemail

2020-03-20 Thread Bhushan Shah
bshah added a comment. Hmm yeah I am also not a fan of the stretched out dialpad icon REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28163 To: ndavis, #vdg Cc: ngraham, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 75 - Unstable!

2020-03-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/75/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 21 Mar 2020 01:25:48 + Build duration: 6 min 20 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 67 - Still Unstable!

2020-03-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/67/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 20 Mar 2020 16:59:31 + Build duration: 8 hr 4 min and counting JUnit Tests Name:

KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.13 - Build # 66 - Still Unstable!

2020-03-20 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.13/66/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 20 Mar 2020 12:33:25 + Build duration: 11 hr and counting JUnit Tests Name:

D28168: Broadcast application menu to resources when registering them

2020-03-20 Thread Carson Black
This revision was automatically updated to reflect the committed changes. Closed by commit R127:8032cb0f0e9a: Broadcast application menu to resources when registering them (authored by cblack). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D28163: Add input-dialpad and call-voicemail

2020-03-20 Thread Noah Davis
ndavis added a comment. In D28163#631474 , @ngraham wrote: > Maybe we could keep the dots 2x2 for the 22px version? You can't get even spacing unless you make it way smaller than a normal 22px icon. REPOSITORY R266 Breeze Icons