D27951: Allow users to change dropAction to MoveAction through kdeglobals

trmdi added a comment. In D27951#639350 , @meven wrote: > Anything that concerns a kdeconnet:/ url is handled by the kdeconnect ioslave, including the stat call made in `KIO::StatJob`. > It is in the kdeconnect code base, the issue you point

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 177 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/177/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 01 Apr 2020 14:36:03 + Build duration: 3 min 12 sec and counting BUILD ARTIFACTS

D17816: Support for xattrs on kio copy/move

ngraham added a comment. @bruns? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino,

D28488: [Fstab] Ensure uniqueness for all filesystem types

bruns created this revision. bruns added reviewers: Frameworks, meven. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Commit a99c6136da2d

D28476: Samba: Ensure to differenciate mounts sharing the same source

meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY `getmntent` for samba returns fsname of the form "//server/folder" (same as `mount`)

D28476: Samba: Ensure to differenciate mounts sharing the same source

meven updated this revision to Diff 79023. meven added a comment. Fix comment REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28476?vs=79022=79023 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28476 AFFECTED FILES

D28472: [DirectorySizeJob] Fix sub-dirs count when resolving symlinks to dirs

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Yay for unittests (and my bad for not running them when making that change). Thanks for the fix! REPOSITORY R241 KIO BRANCH l-dirsizejob (branched from master) REVISION DETAIL

D28476: Samba: Ensure to differenciate mounts sharing the same source

ahmadsamir added a subscriber: sitter. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28476 To: meven, #frameworks Cc: sitter, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28472: [DirectorySizeJob] Fix sub-dirs count when resolving symlinks to dirs

This revision was automatically updated to reflect the committed changes. Closed by commit R241:e247985be433: [DirectorySizeJob] Fix sub-dirs count when resolving symlinks to dirs (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D28476: Samba: Ensure to differenciate mounts sharing the same source

meven updated this revision to Diff 79025. meven added a comment. Use a char instead of char* REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28476?vs=79023=79025 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28476 AFFECTED FILES

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 26 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/26/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 01 Apr 2020 08:53:33 + Build duration: 8 min 47 sec and counting JUnit Tests Name:

D28478: [FileProtocol] change statx stat_dev() to use device major + minor

meven added a comment. In D28478#639294 , @ahmadsamir wrote: > I'll address the comments, but one point which I couldn't figure out is that HAVE_STATX isn't available for the unit tests, any examples on how to make it work there too? I

D27951: Allow users to change dropAction to MoveAction through kdeglobals

meven added a comment. In D27951#637792 , @trmdi wrote: > In D27951#637690 , @meven wrote: > > > Look into kde connect kioslave. > > That does not concern this diff much though. > > > I

D28478: [FileProtocol] change statx stat_dev() to use device major + minor

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY On Linux systems that have statx available, stat_dev() returned stx_dev_major, which could be the same

D28478: [FileProtocol] change statx stat_dev() to use device major + minor

meven added inline comments. INLINE COMMENTS > jobtest.cpp:1382 > const QUrl url(QUrl::fromLocalFile(filePath)); > -KIO::StatJob *job = KIO::stat(url, KIO::HideProgressInfo); > +KIO::StatJob *job = KIO::statDetails(url, KIO::StatJob::SourceSide, > KIO::StatDefaultDetails |

D27951: Allow users to change dropAction to MoveAction through kdeglobals

meven added a comment. In D27951#639350 , @meven wrote: > > Another question, will UDSEntry::UDS_DEVICE_ID be available on Windows? > > I am not a Windows specialist but I imagine we could hack together an equivalent solution (I am saying

D28476: Samba: Ensure to differenciate mounts sharing the same source

meven updated this revision to Diff 79032. meven marked an inline comment as done. meven added a comment. Use QLatin1Char REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28476?vs=79030=79032 BRANCH master REVISION DETAIL

D28476: Samba: Ensure to differenciate mounts sharing the same source

This revision was automatically updated to reflect the committed changes. Closed by commit R245:a99c6136da2d: Samba: Ensure to differenciate mounts sharing the same source (authored by meven). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28476?vs=79035=79036

D28476: Samba: Ensure to differenciate mounts sharing the same source

anthonyfieroni added inline comments. INLINE COMMENTS > fstabhandling.cpp:127 > return fstype + mountpoint; > +} else if (fstype == "cifs") { > +// append mountpoints to samba device name as they don't contain it > in getmntent use `QLatin1String` REPOSITORY R245

D28476: Samba: Ensure to differenciate mounts sharing the same source

ahmadsamir added inline comments. INLINE COMMENTS > fstabhandling.cpp:131 > +return source + ':' + mountpoint; > } > return source; Nitpick: QLatin1Char. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28476 To: meven, #frameworks Cc: ahmadsamir,

D27455: FileWidgets: Ignore Return events from KDirOperator

meven updated this revision to Diff 79039. meven added a comment. Use a single if statement, handle for Qt::Key_Enter as well REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27455?vs=78142=79039 BRANCH arcpatch-D27455 REVISION DETAIL

D28476: Samba: Ensure to differenciate mounts sharing the same source

meven updated this revision to Diff 79030. meven marked an inline comment as done. meven added a comment. Use QLatin1String REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28476?vs=79025=79030 BRANCH master REVISION DETAIL

D28476: Samba: Ensure to differenciate mounts sharing the same source

meven updated this revision to Diff 79035. meven added a comment. Correct typo in comment REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28476?vs=79032=79035 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28476 AFFECTED FILES

D28478: [FileProtocol] change statx stat_dev() to use device major + minor

ahmadsamir added a comment. I'll address the comments, but one point which I couldn't figure out is that HAVE_STATX isn't available for the unit tests, any examples on how to make it work there too? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28478 To: ahmadsamir,

Re: Problems in KWayland causes by API and ABI compatibility promises

Here is a list of active uses of the KWayland::Client API. frameworks plasma-framework (for window positioning) apps: spectacle (for window positioning) kdeconnect-kde (for fake input) yakuake (for window positioning) extragear latte-dock (for window positioning, custom

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.14 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/2/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 01 Apr 2020 10:28:58 + Build duration: 32 min and counting JUnit Tests Name: projectroot

Re: Problems in KWayland causes by API and ABI compatibility promises

FWIW I ported KDE Connect away from it here: https://invent.kde.org/kde/kdeconnect-kde/-/merge_requests/199 Leaving the rest as plasma-specific components. Aleix On Wed, Apr 1, 2020 at 2:04 PM David Edmundson wrote: > > Here is a list of active uses of the KWayland::Client API. > > frameworks

D17816: Support for xattrs on kio copy/move

cochise marked an inline comment as done. cochise added a comment. Hi, @usta and @bruns We still have some change pending? Thanks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta Cc: usta,

D17816: Support for xattrs on kio copy/move

usta added a comment. is there a KDE policy about usage of qCWarning( , qCDebug( ? Because afaik debug one can be ignored by system and some of those might be important to show to user to see So for example this one looks like a warning instead of a debug info for me ( but not sure what

D28476: Samba: Ensure to differenciate mounts sharing the same source

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. You know, I may have noticed this when working on kinfocenter and then quickly forgotten about it again  Good stuff! REPOSITORY R245 Solid BRANCH master REVISION DETAIL

D28472: [DirectorySizeJob] Fix sub-dirs count when resolving symlinks to dirs

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY After 730a6ddd828fb1fbdf0f3 ,

D17816: Support for xattrs on kio copy/move

bruns added a comment. There are still several comments which have not yet been addressed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd,

D28476: Samba: Ensure to differenciate mounts sharing the same source

bruns added a comment. The comment and commit message are lacking required information. One should not have to go to the bug report to actually see why this is needed. While the summary has the BR reference, the code comment is totally unclear. REPOSITORY R245 Solid REVISION DETAIL

D28488: [Fstab] Ensure uniqueness for all filesystem types

broulik added a comment. +1 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28488 To: bruns, #frameworks, meven Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

ahmadsamir updated this revision to Diff 79071. ahmadsamir retitled this revision from "[FileProtocol] change statx stat_dev() to use device major + minor" to "[FileProtocol] change statx stat_dev() to return makedev(major, minor)". ahmadsamir edited the summary of this revision. ahmadsamir

D28478: [FileProtocol] change statx stat_dev() to use device major + minor

ahmadsamir updated this revision to Diff 79044. ahmadsamir marked 2 inline comments as done. ahmadsamir edited the summary of this revision. ahmadsamir added a comment. Address comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28478?vs=79031=79044

D28457: kdirwatch: fix a recently introduced crash

This revision was automatically updated to reflect the committed changes. Closed by commit R244:0ee65124c0f6: kdirwatch: fix a recently introduced crash (authored by meven). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28457?vs=79002=79048 REVISION

D17816: Support for xattrs on kio copy/move

bruns added inline comments. INLINE COMMENTS > file_unix.cpp:149 > +if (listlen == -1) { > +qCWarning(KIO_FILE) << "libc failed to extract list of xattr from > file"; > +return false; Now try this when the source is e.g. FAT formatted ... Make this dependent on errno.

D17816: Support for xattrs on kio copy/move

ngraham added a comment. In D17816#639272 , @usta wrote: > is there a KDE policy about usage of qCWarning( , qCDebug( ? > Because afaik debug one can be ignored by system and some of those might be important to show to user to see > So for

D28478: [FileProtocol] change statx stat_dev() to use device major + minor

ahmadsamir added inline comments. INLINE COMMENTS > meven wrote in jobtest.cpp:1382 > Please add a separate test dedicated for Inode like `statWithInode()` like > `statSymlink` does for instance. > Here you change the purpose of this test : default stat behavior with stat(), > to default +

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/5/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 01 Apr 2020 14:36:03 + Build duration: 1 min 46 sec and counting JUnit Tests Name:

D28478: [FileProtocol] change statx stat_dev() to use device major + minor

bruns added inline comments. INLINE COMMENTS > file_unix.cpp:286 > inline static uint16_t stat_mode(struct statx ) { return buf.stx_mode; } > -inline static uint32_t stat_dev(struct statx ) { return > buf.stx_dev_major; } > +inline static uint32_t stat_dev(struct statx ) { return >

D28478: [FileProtocol] change statx stat_dev() to use device major + minor

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28478 To: ahmadsamir, #frameworks, dfaure, meven, bruns Cc: bruns, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham

D17816: Support for xattrs on kio copy/move

usta accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino,

D17816: Support for xattrs on kio copy/move

cochise updated this revision to Diff 79054. cochise added a comment. qCDebug -> qCWarning REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=78777=79054 BRANCH arcpatch-D17816_2 REVISION DETAIL https://phabricator.kde.org/D17816 AFFECTED FILES

D17816: Support for xattrs on kio copy/move

bruns added a comment. In D17816#639272 , @usta wrote: > is there a KDE policy about usage of qCWarning( , qCDebug( ? > Because afaik debug one can be ignored by system and some of those might be important to show to user to see > So for

D28478: [FileProtocol] change statx stat_dev() to return makedev(major, minor)

ahmadsamir marked 3 inline comments as done. ahmadsamir added inline comments. INLINE COMMENTS > ahmadsamir wrote in file_unix.cpp:304 > This buf.st_dev is the decimal part in: > $ stat /usr/bin/file | grep Device > Device: 804h/2052d Inode: 9168 Links: 1 > that would be "2052" > > whereas with

D28220: Switch to using Kirigami's ShadowedRectangle

ahiemstra added a comment. It's fine with me but I'm going to leave the final call to @broulik since he did a more in-depth review. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28220 To: leinir, #knewstuff, #frameworks, #plasma, ahiemstra, broulik, mart, #vdg

D27504: smb faster copy to local

mmustac added a comment. Those look very lovely. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27504 To: sitter, ngraham, cfeck, #frameworks, #dolphin Cc: mmustac, meven, hallas, anthonyfieroni, asturmlechner, kde-frameworks-devel, kfm-devel, nikolaik,

D27951: Allow users to change dropAction to MoveAction through kdeglobals

bruns added a comment. In D27951#639352 , @meven wrote: > In D27951#639350 , @meven wrote: > > > > Another question, will UDSEntry::UDS_DEVICE_ID be available on Windows? > > > > I am not a

D27504: smb faster copy to local

ngraham added a comment. @sitter Well, master is now 20.08. Shall we land this if nobody has any objections? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27504 To: sitter, ngraham, cfeck, #frameworks, #dolphin Cc: mmustac, meven, hallas, anthonyfieroni,

D28494: [KItemModels/KLinkItemSelectionModelTest] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, broulik. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Use QSortFilterProxyModel::setFilterRegularExpression() instead of setFitlerRegExp(). TEST PLAN make

D28220: Switch to using Kirigami's ShadowedRectangle

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH switch-to-kirigami-shadowedrectangle (branched from master) REVISION DETAIL https://phabricator.kde.org/D28220 To: leinir, #knewstuff, #frameworks, #plasma, ahiemstra,

D28494: [KItemModels/KLinkItemSelectionModelTest] Port QRegExp to QRegularExpression

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R275 KItemModels BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D28494 To: ahmadsamir, #frameworks, dfaure, broulik, apol Cc: kde-frameworks-devel,