D28682: rename and export done signal in filecontentindexer

astippich updated this revision to Diff 79904. astippich added a comment. - implement feedback REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28682?vs=79751=79904 BRANCH exportSignal REVISION DETAIL https://phabricator.kde.org/D28682 AFFECTED FILES

D28682: rename and export done signal in filecontentindexer

astippich marked 2 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun,

D28682: rename and export done signal in filecontentindexer

bruns accepted this revision. bruns added a comment. This revision is now accepted and ready to land. thx REPOSITORY R293 Baloo BRANCH exportSignal REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien, kde-frameworks-devel, hurikhan77,

Re: Update on Status of Gitlab Migration

On Sun, Apr 12, 2020 at 1:06 AM Ben Cooksley wrote: > > On Sun, Apr 12, 2020 at 11:04 AM Johan Ouwerkerk > wrote: > > > > On Sun, Apr 12, 2020 at 12:49 AM Johan Ouwerkerk > > wrote: > > > > > > Yes the only reason why a cleanup script might be needed is if the > > > logical path used to

D28682: rename and export newBatchTime signal in filecontentindexer

This revision was automatically updated to reflect the committed changes. Closed by commit R293:19e71b3e4a5f: rename and export newBatchTime signal in filecontentindexer (authored by astippich). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D28682: rename and export newBatchTime signal in filecontentindexer

astippich added a comment. Thanks REPOSITORY R293 Baloo BRANCH exportSignal REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh,

D28682: rename and export newBatchTime signal in filecontentindexer

astippich retitled this revision from "rename and export done signal in filecontentindexer" to "rename and export newBatchTime signal in filecontentindexer". astippich edited the summary of this revision. REPOSITORY R293 Baloo BRANCH exportSignal REVISION DETAIL

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

dfaure updated this revision to Diff 79906. dfaure added a comment. Use @warning. Thanks for the tip! REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28765?vs=79893=79906 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28765 AFFECTED

D27632: Implement UString operator= to make gcc happy

This revision was automatically updated to reflect the committed changes. Closed by commit R314:e637e721e40e: Implement UString operator= to make gcc happy (authored by aacid). REPOSITORY R314 KJs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27632?vs=76323=79911 REVISION DETAIL

D28769: Add Icelandic Krona

sandsmark created this revision. sandsmark added a reviewer: Frameworks. sandsmark added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sandsmark requested review of this revision. REVISION SUMMARY Was doing some other stuff in kunitconversion so added some warnings on

D27152: Introduce FilesystemEntry class

bruns added inline comments. INLINE COMMENTS > hallas wrote in fstabhandling.cpp:374 > No problem, I really appreciate the thorough review feedback you provide. I > definitely prefer to take more time and get things right, then to rush things > and potentially get them wrong. > > So, have you

D28770: Avoid blocking the UI thread

sandsmark created this revision. sandsmark added reviewers: ngraham, Frameworks, broulik. sandsmark added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sandsmark requested review of this revision. REVISION SUMMARY Not entirely sure about this approach (and the stuff to

D7563: Add privilegeExecution field to file protocol description

elvisangelaccio added a comment. In D7563#645172 , @ngraham wrote: > The outstanding security issues have been resolved (see T8075 ). We have requested a re-review from the SUSE security team, but have not

D24367: Some sanity verification

sandsmark marked an inline comment as done. sandsmark added inline comments. INLINE COMMENTS > cfeck wrote in pcx.cpp:312 > If `p` indeed could be zero, the next statements need to be in an `else` > block (or a add a `return`). good catch, thanks REPOSITORY R287 KImageFormats REVISION

D24367: Some sanity verification

sandsmark updated this revision to Diff 79917. sandsmark added a comment. Added missing return. REPOSITORY R287 KImageFormats CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24367?vs=67201=79917 REVISION DETAIL https://phabricator.kde.org/D24367 AFFECTED FILES

D25267: Improve XCF support

sandsmark updated this revision to Diff 79925. sandsmark added a comment. Fixed the layer composition modes, so now my fruit pilot got colors. Now I think this is fairly complete, it should support most "normal" XCF files (as opposed to before, the current master only supports v0 files).

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > bruns wrote in fstabdevice.cpp:145 > use `FstabHandling::mountPoints(m_device).first()` instead of m_storageAccess. I don't think that it is necessary : m_storageAccess already equals to

D8274: Don't create new symlinks when copying symlinks - copy the file's contents - like /usr/bin/cp

dfaure added a comment. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. @shlomif any plans on redoing this another way? Otherwise can you close the review request, to clean up dashboards? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8274

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

bruns added inline comments. INLINE COMMENTS > meven wrote in fstabdevice.cpp:145 > I don't think that it is necessary : m_storageAccess already equals to > `FstabHandling::mountPoints(m_device).first()`, looking at > `FstabStorageAccess::FstabStorageAccess` and >

D28774: [KFontRequester] Port from QFontDialog to KFontChooserDialog

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, cfeck. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN The kfontrequestertest app still works REPOSITORY R236 KWidgetsAddons BRANCH l-kfontreq (branched from

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

bruns added inline comments. INLINE COMMENTS > fstabdevice.cpp:63 > } > > +if (m_storageType == StorageType::NetworkShare) { the `if (m_displayName.isEmpty())` block belongs here > fstabdevice.cpp:145 > +} > +const auto filePath = m_storageAccess->filePath(); > +if

D28208: Move sni icon handling logic from data engine to applet

kmaterka added a reviewer: Frameworks. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28208 To: davidre, kmaterka, broulik, mart, #plasma, #vdg, #frameworks Cc: bruns, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D25267: Improve XCF support

sandsmark updated this revision to Diff 79920. sandsmark added a comment. Added test files (my own beautiful drawing). REPOSITORY R287 KImageFormats CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25267?vs=69618=79920 REVISION DETAIL https://phabricator.kde.org/D25267 AFFECTED

D24367: Some sanity verification

sandsmark marked 2 inline comments as done. REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D24367 To: sandsmark, aacid, cfeck Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

meven updated this revision to Diff 79922. meven added a comment. Fix m_displayName variable naming, move block to constructor REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28590?vs=79807=79922 BRANCH master REVISION DETAIL

D25267: Improve XCF support

sandsmark updated this revision to Diff 79924. sandsmark added a comment. Implemented the last few properties that were missing for my beautiful XCF (not actually using them, though, I'm not in the mood to implement blending in the LAB color space). REPOSITORY R287 KImageFormats CHANGES

D25267: Improve XCF support

aacid added a comment. the files are not uploaded correctly to phabricator so i can't check they work. Given we just released KF 5.69 *yesterday* i'm going to go crazy and say commit this and we have a "whole month" to fix regressions if it has any... REPOSITORY R287 KImageFormats

D28755: Breeze Icons cannot be built from read-only source location

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice improvement. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28755 To: marten, #breeze, ngraham Cc: ngraham, pino, kde-frameworks-devel, LeGast00n,

D28779: [Fstab] Use new style connect API

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28779 To: bruns, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

meven updated this revision to Diff 79942. meven added a comment. This revision is now accepted and ready to land. Improve latest modification time of trash implementation, fix case when a symlink is in the trash returning incorrect trash size REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D28779: [Fstab] Use new style connect API

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Depends on D28778 TEST PLAN No functional

D28778: [FstabWatcher] Use static QStringLiteral instead of macro

bruns added a dependent revision: D28779: [Fstab] Use new style connect API. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28778 To: bruns, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28780: [FstabWatcher] Fix loosing of fstab watcher

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY In case the fstab is deleted (caused by editing it), the watch will be removed. The

D28535: [KIO-MTP] Fix null pointer dereference

feverfew added a comment. In D28535#642298 , @feverfew wrote: > In D28535#642289 , @elvisangelaccio wrote: > > > In D28535#640833 , @fvogt wrote: > >

D28535: [KIO-MTP] Fix null pointer dereference

elvisangelaccio added a comment. In D28535#642298 , @feverfew wrote: > In D28535#642289 , @elvisangelaccio wrote: > > > In D28535#640833 , @fvogt wrote:

D28777: FstabDevice: Reevaluate emblems only when state changes

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Instead of evaluating the mount state on each call just evaluate it when it changes,

D28778: [FstabWatcher] Use static QStringLiteral instead of macro

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY QFilesystemWatcher::addPath takes a QString as argument, so avoid construction of

D24773: kio_trash: Add size, modification, access and create date for trash:/

meven updated this revision to Diff 79943. meven added a comment. Improve naming of struct CacheData to SizeAndModTime REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24773?vs=79942=79943 BRANCH arcpatch-D24773_1 REVISION DETAIL

D28782: [Fstab] Do not emit deviceAdded twice on fstab/mtab changes

apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > fstabmanager.cpp:122 > + > +qCDebug(FSTAB) << oldlist << "->" << newlist; > + The debug seems wrong and probably unnecessary. I'd remove it. REPOSITORY R245 Solid

D28776: FstabDevice: Avoid recurrent construction of emblems QStringList

bruns added a dependent revision: D28777: FstabDevice: Reevaluate emblems only when state changes. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28776 To: bruns, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28776: FstabDevice: Avoid recurrent construction of emblems QStringList

bruns created this revision. bruns added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY emblems can return exactly two different values. Construct the two possible values

D28779: [Fstab] Use new style connect API

bruns added a dependent revision: D28780: [FstabWatcher] Fix loosing of fstab watcher. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28779 To: bruns, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28779: [Fstab] Use new style connect API

bruns added a dependent revision: D28782: [Fstab] Do not emit deviceAdded twice on fstab/mtab changes. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28779 To: bruns, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28782: [Fstab] Do not emit deviceAdded twice on fstab/mtab changes

bruns created this revision. bruns added reviewers: Frameworks, afiestas. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The deviceAdded signal was emitted twice, once with the old device list in

D8274: Don't create new symlinks when copying symlinks - copy the file's contents - like /usr/bin/cp

shlomif abandoned this revision. shlomif added a comment. Closing then. I don't have any immediate plans for reworking this patch. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8274 To: shlomif, dfaure Cc: kde-frameworks-devel, ngraham, rkflx, dfaure, bcooksley,

D28778: [FstabWatcher] Use static QStringLiteral instead of macro

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28778 To: bruns, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28745: Skipping catching of thumbnails on encrytped filesystems

ngraham added reviewers: ivan, broulik, Dolphin. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde,

D28746: Show previews on encrypted filesystems

ngraham added reviewers: ivan, Frameworks, dfaure. ngraham added a comment. General idea looks sane to me. Thanks for working on this; it's been one of those minor annoyances of mine. INLINE COMMENTS > previewjob.cpp:718 > } > - > if (save) { unrelated change REPOSITORY R241

D28746: Show previews on encrypted filesystems

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Works and looks good to me modulo one comment, but let's wait for the other reviewers too. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28746 To: marcingu,

D28787: Fix PC3 BusyIndicator binding loop

ngraham created this revision. ngraham added reviewers: Plasma, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY Without this, the Busy Indicator generates binding loops for me when

D28745: Skipping catching of thumbnails on encrypted filesystems

ngraham retitled this revision from "Skipping catching of thumbnails on encrytped filesystems" to "Skipping catching of thumbnails on encrypted filesystems". ngraham edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To:

D28776: FstabDevice: Avoid recurrent construction of emblems QStringList

apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. Address the scope of the statics as kai mentioned in D28778 . Or use Q_GLOBAL_STATIC. REPOSITORY R245 Solid REVISION DETAIL

D28770: Avoid blocking the UI thread

ngraham added inline comments. INLINE COMMENTS > currency.cpp:40 > #include > +#include > +#include Unused? > currency.cpp:884 > + > +#include "currency.moc" why? REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D28770 To: sandsmark, ngraham, #frameworks,

D28780: [FstabWatcher] Fix loosing of fstab watcher

apol added inline comments. INLINE COMMENTS > fstabwatcher.cpp:110 > emit fstabChanged(); > if (!m_fileSystemWatcher->files().contains(s_fstabFile)) { > +m_isFstabWatched = m_fileSystemWatcher->addPath(s_fstabFile); Use m_isFstabWatched? Or maybe m_isFstabWatched

D28776: FstabDevice: Avoid recurrent construction of emblems QStringList

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28776 To: bruns, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28778: [FstabWatcher] Use static QStringLiteral instead of macro

broulik added a comment. Don't use global statics in library code REPOSITORY R245 Solid BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28778 To: bruns, #frameworks, apol Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28780: [FstabWatcher] Fix loosing of fstab watcher

bruns added inline comments. INLINE COMMENTS > apol wrote in fstabwatcher.cpp:110 > Use m_isFstabWatched? Or maybe m_isFstabWatched isn't necessary altogether > and we can check in other places too. No. QFileSystemWatcher looses the watch when the file is deleted/renamed, so m_isFstabWatched

Re: Update on Status of Gitlab Migration

On Sun, Apr 12, 2020 at 12:49 AM Johan Ouwerkerk wrote: > > > > > We may need to do on-the-fly conversion of the kde: repo paths if they > > won't be expressible as 'kde:foo' in the future, but we should have the > > information needed to do this in kdesrc-build to make this happen > >

D28769: Add Icelandic Krona

ngraham added a comment. Hmm, this patch doesn't apply for me. REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D28769 To: sandsmark, #frameworks Cc: ngraham, kde-frameworks-devel, #frameworks, LeGast00n, cblack, michaelh, bruns

D28778: [FstabWatcher] Use static QStringLiteral instead of macro

apol added a comment. In D28778#646791 , @broulik wrote: > Don't use global statics in library code in case it gets statically compiled? REPOSITORY R245 Solid BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28778 To:

D28782: [Fstab] Do not emit deviceAdded twice on fstab/mtab changes

bruns added inline comments. INLINE COMMENTS > apol wrote in fstabmanager.cpp:122 > The debug seems wrong and probably unnecessary. I'd remove it. What do you think is wrong with it? And its the only debug output there is on this level, and always having to add debug statements in case of