D28862: [Extractor] Remove IdleStateMonitor wrapper class

2020-04-16 Thread Kai Uwe Broulik
broulik added a comment. It used to be 2 minutes, now it's 1? INLINE COMMENTS > app.cpp:59 > +static int s_idleTimeout = 1000 * 60; // 1 min > +m_idleTime = KIdleTime::instance(); > +m_idleTime->addIdleTimeout(s_idleTimeout); Why the member variable? It's a singleton after all

D28862: [Extractor] Remove IdleStateMonitor wrapper class

2020-04-16 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > broulik wrote in app.cpp:63 > Coding style Side note - both the Frameworks and the reference Qt coding style say nothing about lambdas. If you read the `connect(...);` as a single statement, it should stay as is. If you read the lambda as a

D28745: Skip caching thumbnails on encrypted filesystems

2020-04-16 Thread Stefan Brüns
bruns added inline comments. INLINE COMMENTS > thumbnail.cpp:726 > > +const auto mountsList = KMountPoint::currentMountPoints(); > +const auto mount = mountsList.findByPath(filePath); Calling currentMountPoints() for every created file is definitely a bad idea ...

D28701: Add KPackage support to KNewStuffCore

2020-04-16 Thread Dan Leinir Turthra Jensen
leinir edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28701 To: leinir, #plasma, #knewstuff, #frameworks, ngraham, mart, davidedmundson Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D28862: [Extractor] Remove IdleStateMonitor wrapper class

2020-04-16 Thread Stefan Brüns
bruns updated this revision to Diff 80295. bruns added a comment. add line break before closing brace in lambda, use 2 minutes REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28862?vs=80236=80295 BRANCH master REVISION DETAIL

D28864: [Extractor] Better balance idle and busy mode

2020-04-16 Thread Nathaniel Graham
ngraham added a comment. Can you explain the conceptual reasoning behind this change? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28864 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson,

Re: KDE CI: Administration » Dependency Build Extragear stable-kf5-qt5 AndroidQt5.14 - Build # 10 - Still Failing!

2020-04-16 Thread Ben Cooksley
On Fri, Apr 17, 2020 at 6:37 AM Johan Ouwerkerk wrote: > > > On Thu, Apr 16, 2020 at 10:51 AM Ben Cooksley wrote: >> >> Hi all, >> >> Does anyone know why the below would have suddenly started failing a little >> while back? >> >> Thanks, >> Ben > > > Based on the error message I would expect

D28864: [Extractor] Better balance idle and busy mode

2020-04-16 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:ef3535630914: [Extractor] Better balance idle and busy mode (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28864?vs=80297=80300 REVISION DETAIL

D28865: [PhraseAndIterator] Remove temporary arrays when checking matches

2020-04-16 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:a27a2282da3f: [PhraseAndIterator] Remove temporary arrays when checking matches (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D27840: Introduce SettingState* elements to ease KCM writing

2020-04-16 Thread Kevin Ottens
ervin updated this revision to Diff 80305. ervin added a comment. Fix issues found with Cyril's patches on various KCMs. REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27840?vs=78698=80305 REVISION DETAIL https://phabricator.kde.org/D27840

D28874: Taiwanese holidays

2020-04-16 Thread Chris Holland
Zren added a comment. There's a few extra spaces at the end of `"植樹節 "` and `"中秋節 補假 "` too. Not sure how well you know `git`, but make sure to run `git add holidays/plan2/holiday_tw_zh` again after making your changes, before running `git diff --staged` to upload the modified diff.

D28864: [Extractor] Better balance idle and busy mode

2020-04-16 Thread Stefan Brüns
bruns updated this revision to Diff 80297. bruns edited the summary of this revision. bruns added a comment. extend summary REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28864?vs=80296=80297 BRANCH submit REVISION DETAIL

D28865: [PhraseAndIterator] Remove temporary arrays when checking matches

2020-04-16 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28865 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson,

D28862: [Extractor] Remove IdleStateMonitor wrapper class

2020-04-16 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:bd502bf0af46: [Extractor] Remove IdleStateMonitor wrapper class (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28862?vs=80295=80298 REVISION

D28863: [Extractor] Fix idle monitoring

2020-04-16 Thread Stefan Brüns
This revision was automatically updated to reflect the committed changes. Closed by commit R293:0d56f65f03c3: [Extractor] Fix idle monitoring (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28863?vs=80237=80299 REVISION DETAIL

D28864: [Extractor] Better balance idle and busy mode

2020-04-16 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks, makes sense to me! REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28864 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77,

D28874: Taiwanese holidays

2020-04-16 Thread Ricky Lindén
shrapnel updated this revision to Diff 80303. shrapnel added a comment. Fixed the typos REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28874?vs=80288=80303 REVISION DETAIL https://phabricator.kde.org/D28874 AFFECTED FILES

D28874: Taiwanese holidays

2020-04-16 Thread Chris Holland
Zren added a comment. Phab only understands `.diff`. Phab does not recognize `.patch`. git diff --staged > D28874.diff Or: git diff origin/master > D28874.diff REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren,

Re: KDE CI: Administration » Dependency Build Extragear stable-kf5-qt5 AndroidQt5.14 - Build # 10 - Still Failing!

2020-04-16 Thread Johan Ouwerkerk
On Thu, Apr 16, 2020 at 10:51 AM Ben Cooksley wrote: > Hi all, > > Does anyone know why the below would have suddenly started failing a > little while back? > > Thanks, > Ben > Based on the error message I would expect this to be related to the effort to fix Android pkgs not being generated for

D28863: [Extractor] Fix idle monitoring

2020-04-16 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28863 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson,

D28864: [Extractor] Better balance idle and busy mode

2020-04-16 Thread Stefan Brüns
bruns updated this revision to Diff 80296. bruns added a comment. Extend commit message, reduce idle timeout REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28864?vs=80238=80296 REVISION DETAIL https://phabricator.kde.org/D28864 AFFECTED FILES

D28862: [Extractor] Remove IdleStateMonitor wrapper class

2020-04-16 Thread Nathaniel Graham
ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D28862 To: bruns, #baloo, ngraham Cc: broulik, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas,

D28883: Add wrapper for wl_global_remove

2020-04-16 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D28883 To: davidedmundson, #plasma, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28819: [KRichTextEdit] Always treat key press as single modification in undo stack

2020-04-16 Thread Igor Poboiko
poboiko added a comment. @dfaure There seem to be a regression caused by this patch: if I reach the end of current view, and then press Enter so it has to scroll down, it scrolls to the very beginning of the document instead. This is the same issue as in ancient bug 195828

D19913: [plasma-framework] make it compiles without foreach

2020-04-16 Thread Laurent Montel
mlaurent added a comment. Ping ?:) REPOSITORY R242 Plasma Framework (Library) BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19913 To: mlaurent, dfaure Cc: ahmadsamir, nicolasfella, broulik, apol, kde-frameworks-devel, LeGast00n,

D28874: Taiwanese holidays

2020-04-16 Thread Allen Winter
winterz added a comment. you need to add the change to holidays.qrc to this patch REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren Cc: winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28874: Taiwanese holidays

2020-04-16 Thread Ricky Lindén
shrapnel updated this revision to Diff 80288. shrapnel added a comment. Hopefully the changes to both files are there now REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28874?vs=80277=80288 REVISION DETAIL https://phabricator.kde.org/D28874 AFFECTED

D28745: Skip caching thumbnails on encrypted filesystems

2020-04-16 Thread Stefan Brüns
bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > thumbnail.cpp:729 > +const auto thumbRootMount = > mountsList.findByPath(m_thumbBasePath); > +//If file is on the same filesystem as

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.14 - Build # 20 - Unstable!

2020-04-16 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.14/20/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 16 Apr 2020 14:48:35 + Build duration: 2 min 47 sec and counting BUILD ARTIFACTS

D28745: Skip caching thumbnails on encrypted filesystems

2020-04-16 Thread Marcin Gurtowski
marcingu added a comment. Ok, Thanks! I'll check it this weekend. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns Cc: bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, azyx, nikolaik,

D28874: Taiwanese holidays

2020-04-16 Thread Allen Winter
winterz requested changes to this revision. winterz added a comment. This revision now requires changes to proceed. testing fails. don't know why yet. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren, winterz Cc: winterz,

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

2020-04-16 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, blaze. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY QRegularExpression::wildcardToRegularExpression() mainly handles file pattern globbing (e.g. "*.txt")

D28882: Create protocol to manage video feeds

2020-04-16 Thread Aleix Pol Gonzalez
apol added a dependent revision: D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin, jgrulich Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28874: Taiwanese holidays

2020-04-16 Thread Ricky Lindén
shrapnel updated this revision to Diff 80277. shrapnel edited the summary of this revision. shrapnel added a comment. Added holiday_tw_zh to holidays.qrc-file (I'm new to git/phabricator so hopefully it makes sense) REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE

KDE CI: Frameworks » kirigami » kf5-qt5 FreeBSDQt5.14 - Build # 24 - Unstable!

2020-04-16 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20FreeBSDQt5.14/24/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 16 Apr 2020 14:48:36 + Build duration: 1 min 16 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 417 - Unstable!

2020-04-16 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/417/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 Apr 2020 14:48:35 + Build duration: 1 min 53 sec and counting BUILD ARTIFACTS

D28854: [KRichTextWidget] Add support for headings

2020-04-16 Thread Igor Poboiko
poboiko marked 3 inline comments as done. poboiko added a comment. In D28854#649189 , @abstractdevelop wrote: > Hey, thanks for this @poboiko I used to have to implement this myself, so this will be very useful in my app, O20.Word. ;)

D28883: Add wrapper for wl_global_remove

2020-04-16 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Removes the Global from the registry, but does not delete the

D28874: Taiwanese holidays

2020-04-16 Thread Allen Winter
winterz added a comment. problems: - "religous" should be "religious" - missing ':' at the start of Constitution Day - missing ':' at the start of Christmas Day REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren, winterz Cc:

D28882: Create protocol to manage video feeds

2020-04-16 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: KWin, jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Creates a protocol based on Pipewire that allows us to request feeds to be set up by

D28874: Taiwanese holidays

2020-04-16 Thread Chris Holland
Zren added a comment. Now you're missing `holidays/plan2/holiday_tw_zh` which can still be seen here: https://phabricator.kde.org/D28874?id=80260 git add holidays/holidays.qrc git add holidays/plan2/holiday_tw_zh git diff --staged > D28874.diff REPOSITORY R175 KHolidays

D28882: Create protocol to manage video feeds

2020-04-16 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 80284. apol added a subscriber: zzag. apol added a comment. renamed protocol as per @zzag's suggestion REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80278=80284 BRANCH master REVISION DETAIL

D28701: Add KPackage support to KNewStuffCore

2020-04-16 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 80289. leinir added a comment. Address @ngraham's (and my own) worry about the synchronous behaviour exhibited by KPackage... Something a bit like this probably wants to go into KPackage itself, perhaps we can consider this after we've done a bit of

D28892: [autotests] Optimistic attempt to fix RemoteAccessTest reilability

2020-04-16 Thread David Edmundson
davidedmundson updated this revision to Diff 80311. davidedmundson added a comment. spelling REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28892?vs=80310=80311 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28892 AFFECTED FILES

D28892: [autotests] Optimistic attempt to fix RemoteAccessTest reilability

2020-04-16 Thread David Edmundson
davidedmundson updated this revision to Diff 80312. davidedmundson added a comment. update REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28892?vs=80311=80312 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28892 AFFECTED FILES

D28891: Nicaragua Holidays

2020-04-16 Thread Carlos Arguello
carguello added a comment. Thank you for your time and support.  REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28891 To: carguello, winterz, #frameworks Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns

D28891: Nicaragua Holidays

2020-04-16 Thread Nathaniel Graham
ngraham added a comment. You're very welcome. Thank you for the patch! REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28891 To: carguello, winterz, #frameworks Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns

D28900: Fix wayland scanner warnings

2020-04-16 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Build System, KWin, Frameworks. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Tells cmake not to automoc certain files

D19913: [plasma-framework] make it compiles without foreach

2020-04-16 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added inline comments. INLINE COMMENTS > dropmenu.cpp:80 > } else if (m_menu) { > -foreach (QAction *action, m_dropActions) { > +for (QAction *action : qAsConst(m_dropActions)) { > m_menu->addAction(action);

D24773: kio_trash: Add size, modification, access and create date for trash:/

2020-04-16 Thread David Faure
dfaure added a comment. Yep, that's it. Renaming trash:/A to trash:/B calls KIO::moveAs which stats trash:/ [useful to resolve desktop:/ to a local dir for instance], which now updates the on-disk cache... with 'A', before it gets renamed to 'B'. I think I know what the best solution

D28902: CopyJob: when stat'ing the dest, use StatBasic.

2020-04-16 Thread David Faure
dfaure created this revision. dfaure added a reviewer: meven. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY However the StatDetail enum doesn't specify which enum value will get us UDS_LOCAL_PATH

D28874: Taiwanese holidays

2020-04-16 Thread Ricky Lindén
shrapnel updated this revision to Diff 80346. shrapnel added a comment. Uploaded .diff instead of .patch REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28874?vs=80303=80346 REVISION DETAIL https://phabricator.kde.org/D28874 AFFECTED FILES

D7563: Add privilegeExecution field to file protocol description

2020-04-16 Thread Nathaniel Graham
ngraham added a comment. Thanks @chinmoyr! REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D7563 To: chinmoyr, #frameworks, dfaure Cc: kde-frameworks-devel, feverfew, mreeves, mati865, ngraham, elvisangelaccio, LeGast00n, cblack, michaelh, bruns

D7563: Add privilegeExecution field to file protocol description

2020-04-16 Thread Nathaniel Graham
ngraham updated this revision to Diff 80343. ngraham added a comment. Set the patch base REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7563?vs=80342=80343 BRANCH arcpatch-D7563 REVISION DETAIL https://phabricator.kde.org/D7563 AFFECTED FILES

D7563: Add privilegeExecution field to file protocol description

2020-04-16 Thread Nathaniel Graham
ngraham commandeered this revision. ngraham added a reviewer: chinmoyr. ngraham added a comment. Yoink! REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D7563 To: ngraham, #frameworks, dfaure, chinmoyr Cc: kde-frameworks-devel, feverfew, mreeves, mati865,

D7563: Add privilegeExecution field to file protocol description

2020-04-16 Thread Nathaniel Graham
ngraham updated this revision to Diff 80342. ngraham added a comment. - Fix build failure - Add more stuff (thanks @chinmoyr) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7563?vs=80341=80342 BRANCH arcpatch-D7563 REVISION DETAIL

Re: Problems in KWayland causes by API and ABI compatibility promises

2020-04-16 Thread Kevin Ottens
Hello, On Thursday, 16 April 2020 23:38:23 CEST David Edmundson wrote: > On Wed, Apr 8, 2020 at 5:10 PM Kevin Ottens wrote: > > On Wednesday, 1 April 2020 14:04:10 CEST David Edmundson wrote: > > > Here is a list of active uses of the KWayland::Client API. > > > > > > frameworks > > > > > >

D17816: Support for xattrs on kio copy/move

2020-04-16 Thread Stefan Brüns
bruns requested changes to this revision. bruns added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > file_unix.cpp:141 > +// Get the list of keys > +ssize_t listlen = 512; > +QByteArray keylist(listlen, Qt::Uninitialized); The idea is almost right,

D19913: [plasma-framework] make it compiles without foreach

2020-04-16 Thread Laurent Montel
mlaurent updated this revision to Diff 80344. mlaurent added a comment. Use m_menu->addActions(m_dropActions); REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19913?vs=80182=80344 BRANCH compile_without_foreach (branched from master)

D19913: [plasma-framework] make it compiles without foreach

2020-04-16 Thread Laurent Montel
This revision was automatically updated to reflect the committed changes. Closed by commit R242:48f60533b922: [plasma-framework] make it compiles without foreach (authored by mlaurent). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D7563: Add privilegeExecution field to file protocol description

2020-04-16 Thread Chinmoy Ranjan Pradhan
chinmoyr updated this revision to Diff 80341. chinmoyr marked an inline comment as done. chinmoyr added a comment. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. Rebased on master. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D7563: Add privilegeExecution field to file protocol description

2020-04-16 Thread Chinmoy Ranjan Pradhan
chinmoyr requested changes to this revision. chinmoyr added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > file_unix.cpp:1331 > +KAuth::Action::DetailsMap details; > +details.insert(KAuth::Action::AuthDetail::DetailMessage, >

D7563: Add privilegeExecution field to file protocol description

2020-04-16 Thread Nathaniel Graham
ngraham added a comment. [insert I-have-no-idea-what-I'm-doing dog meme here] When trying to create items in root-owned locations, I'm getting an errors saying "The process for the file protocol died unexpectedly." or else Dolphin simply crashes with a totally unhelpful backtrace.

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.14 - Build # 27 - Fixed!

2020-04-16 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.14/27/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 17 Apr 2020 04:47:27 + Build duration: 3 min 11 sec and counting JUnit Tests

D28891: Nicaragua Holidays

2020-04-16 Thread Carlos Arguello
carguello created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. carguello requested review of this revision. REVISION SUMMARY Added file containing Nicaragua holidays in holidays/plan2/holiday_ni_es REPOSITORY R175 KHolidays BRANCH

D28892: [autotests] Optimistic attempt to fix RemoteAccessTest reilability

2020-04-16 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY In this test we are waiting on 4 events. 2 things via 2 threads.

D28891: Nicaragua Holidays

2020-04-16 Thread Nathaniel Graham
ngraham added a comment. Great job! I'll hand it over to @winterz and other reviewers now. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28891 To: carguello, winterz, #frameworks Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns

D28811: Add drawer on mobile and clean code

2020-04-16 Thread Olivier Churlaud
ochurlaud accepted this revision. ochurlaud added a comment. In D28811#649209 , @ognarb wrote: > I now generate the CSS from aether-sass. The code can be found https://invent.kde.org/websites/aether-sass/-/blob/master/css/aether-sidebar.scss.

D28808: [ExpandableListItem] make it touch-friendly

2020-04-16 Thread Niccolò Venerandi
niccolove added a comment. This generically works, except for: would it be possible to make it so that clicking on an empty point will drop the list and button hover status? otherwise, you kind of get stuck to this situation: F8242311: Screenshot_20200416_224831.png

Re: KDE CI: Administration » Dependency Build Extragear stable-kf5-qt5 AndroidQt5.14 - Build # 10 - Still Failing!

2020-04-16 Thread Nicolas Fella
Hi, this looks like a simple prison build failure to me. However, I cannot reprocuce this with the binary factory container and the current Prison Android CI builds is blue. There is a single red Android build in the Prison CI history (https://build.kde.org/job/Frameworks/

D26888: work around to fully support the windows backend

2020-04-16 Thread Albert Vaca Cintora
albertvaka added a comment. @vonreth @broulik Can you folks give this a final review? We have been building KDE Connect for Windows off a custom branch with this patch, but I would like to use official builds of KNotifications so it would be great if we can merge it. REPOSITORY R289

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 62 - Still Unstable!

2020-04-16 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/62/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 16 Apr 2020 23:43:51 + Build duration: 7 min 51 sec and counting JUnit Tests Name:

D28891: Nicaragua Holidays

2020-04-16 Thread Carlos Arguello
carguello updated this revision to Diff 80319. carguello added a comment. Previously messed up holidays/holidays.qrc I have fixed it now REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28891?vs=80318=80319 BRANCH master REVISION DETAIL

D28891: Nicaragua Holidays

2020-04-16 Thread Nathaniel Graham
ngraham added a comment. Now the new file you wanted to add is gone. :) With Phabricator, you need to include all commits in your patch, not just the latest one. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28891 To: carguello, winterz, #frameworks Cc:

D26888: work around to fully support the windows backend

2020-04-16 Thread Piyush Aggarwal
brute4s99 marked 2 inline comments as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26888 To: brute4s99, vonreth, broulik, #kde_connect Cc: albertvaka, meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D26888: work around to fully support the windows backend

2020-04-16 Thread Piyush Aggarwal
brute4s99 updated this revision to Diff 80333. brute4s99 added a comment. work around to fully support the windows backend REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26888?vs=74291=80333 BRANCH arcpatch-D26888 REVISION DETAIL

Re: Problems in KWayland causes by API and ABI compatibility promises

2020-04-16 Thread David Edmundson
> Given Doodle's take forever and everyone's probably quarantined > anyway, I propose we do it just after the Monday Plasma meeting. If > someone is eager to share an opinion and can't make that, message here > and we'll choose something more formally. That didn't really work out. Doodle it is!

D28891: Nicaragua Holidays

2020-04-16 Thread Nathaniel Graham
ngraham removed a reviewer: VDG. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28891 To: carguello, winterz, #frameworks Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns

D28891: Nicaragua Holidays

2020-04-16 Thread Carlos Arguello
carguello added a reviewer: VDG. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28891 To: carguello, #vdg Cc: kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, ngraham, bruns

D28891: Nicaragua Holidays

2020-04-16 Thread Nathaniel Graham
ngraham added reviewers: winterz, Frameworks. ngraham added a comment. Thanks for the patch! You need to update the `holidays/holidays.qrc` file too, to mention this new file that you're adding. Also I don't think you need to have the `.qrc` extension on the file you're adding. REPOSITORY

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 54 - Still Unstable!

2020-04-16 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/54/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 16 Apr 2020 23:43:51 + Build duration: 11 min and counting BUILD ARTIFACTS

D28808: [ExpandableListItem] make it touch-friendly

2020-04-16 Thread Niccolò Venerandi
niccolove added a reviewer: niccolove. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28808 To: ngraham, #plasma, apol, #vdg, niccolove Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28891: Nicaragua Holidays

2020-04-16 Thread Carlos Arguello
carguello updated this revision to Diff 80318. carguello added a comment. Remove file extension .qrc per instructions REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28891?vs=80309=80318 BRANCH master REVISION DETAIL

Re: Problems in KWayland causes by API and ABI compatibility promises

2020-04-16 Thread David Edmundson
On Wed, Apr 8, 2020 at 5:10 PM Kevin Ottens wrote: > > Hello, > > On Wednesday, 1 April 2020 14:04:10 CEST David Edmundson wrote: > > Here is a list of active uses of the KWayland::Client API. > > > > frameworks > > plasma-framework (for window positioning) > > > > apps: > > spectacle

D28891: Nicaragua Holidays

2020-04-16 Thread Carlos Arguello
carguello added a comment. I think I messed up  REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28891 To: carguello, winterz, #frameworks Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns

D28891: Nicaragua Holidays

2020-04-16 Thread Nathaniel Graham
ngraham added a comment. git add [the path to the new file you want to add]` arc diff --update D28891 REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28891 To: carguello, winterz, #frameworks Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack,

D28891: Nicaragua Holidays

2020-04-16 Thread Carlos Arguello
carguello added a comment.  How can I add it back? Sorry this is my first time using git and Phabricator REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28891 To: carguello, winterz, #frameworks Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack,

D28900: Fix wayland scanner warnings

2020-04-16 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D28900 To: apol, #build_system, #kwin, #frameworks, davidedmundson Cc: kde-frameworks-devel,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 553 - Still Unstable!

2020-04-16 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/553/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 16 Apr 2020 23:43:51 + Build duration: 5 min 44 sec and counting BUILD ARTIFACTS

D28808: [ExpandableListItem] make it touch-friendly

2020-04-16 Thread Nathaniel Graham
ngraham added a comment. Good question. I'm not sure it's possible here; the list views that use this component as a delegate might have to learn how to unset the selection with their own `TapHandler`. I'm not 100% sure on that though. REPOSITORY R242 Plasma Framework (Library) REVISION

D28891: Nicaragua Holidays

2020-04-16 Thread Carlos Arguello
carguello updated this revision to Diff 80322. carguello added a comment. Adding Nicaragua Holidays file back REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28891?vs=80319=80322 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28891

D28891: Nicaragua Holidays

2020-04-16 Thread Carlos Arguello
carguello added a comment. Okay, I'm confident it went through this time REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28891 To: carguello, winterz, #frameworks Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, cblack, michaelh, bruns

D28901: Add KIO::StatRecursiveSize detail value so kio_trash only does this on demand

2020-04-16 Thread David Faure
dfaure created this revision. dfaure added reviewers: meven, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY This indirectly fixes the testtrash unittest which noticed that the directory

D17816: Support for xattrs on kio copy/move

2020-04-16 Thread Cochise César

D5173: Fix 'Installation of ksendbugmail.exe conflicts with related KDE4 package'.

2020-04-16 Thread Ralf Habacker
habacker added a comment. Looking into the bug report gaves the answer: file /usr/i686-w64-mingw32/sys-root/mingw/bin/ksendbugmail.exe from install of mingw32-libKF5XmlGui5-5.26.0-3.1.noarch conflicts with file from package mingw32-kdelibs4-4.14.60-11.4.noarch For the recored:

D28856: Save disabling of desktop file components in kglobalshortcutsrc

2020-04-16 Thread David Redondo
davidre marked 4 inline comments as done. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D28856 To: davidre, davidedmundson, fvogt, meven Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28856: Save disabling of desktop file components in kglobalshortcutsrc

2020-04-16 Thread David Redondo
davidre updated this revision to Diff 80265. davidre added a comment. Don't parse the disabledGroup as component REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28856?vs=80206=80265 BRANCH disable (branched from master) REVISION DETAIL

D28701: Add KPackage support to KNewStuffCore

2020-04-16 Thread Dan Leinir Turthra Jensen
leinir added a comment. In D28701#649012 , @ngraham wrote: > This has fixed the issues I was seeing with installation and uninstallation, nice! However I'm not seeing a very long hang when installing certain global themes--for example Sweet KDE

Fwd: KDE CI: Administration » Dependency Build Extragear stable-kf5-qt5 AndroidQt5.14 - Build # 10 - Still Failing!

2020-04-16 Thread Ben Cooksley
Hi all, Does anyone know why the below would have suddenly started failing a little while back? Thanks, Ben -- Forwarded message - From: CI System Date: Thu, Apr 16, 2020 at 6:59 AM Subject: KDE CI: Administration » Dependency Build Extragear stable-kf5-qt5 AndroidQt5.14 -

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.14 - Build # 20 - Fixed!

2020-04-16 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.14/20/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 16 Apr 2020 09:48:20 + Build duration: 6 min 55 sec and counting JUnit Tests Name: (root)

  1   2   >