D29091: [NetworkManager-qt] Replace foreach with range/index for loop, third pass

This revision was automatically updated to reflect the committed changes. Closed by commit R282:6d7caf3468ed: [NetworkManager-qt] Replace foreach with range/index for loop, third pass (authored by ahmadsamir). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde

D29093: [NetworkManager-qt] Replace foreach with range for, hopefully last pass

This revision was automatically updated to reflect the committed changes. Closed by commit R282:ee827d8efba2: [NetworkManager-qt] Replace foreach with range for, hopefully last pass (authored by ahmadsamir). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.o

KDE CI: Frameworks » networkmanager-qt » kf5-qt5 SUSEQt5.14 - Build # 8 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/networkmanager-qt/job/kf5-qt5%20SUSEQt5.14/8/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 23 Apr 2020 08:39:16 + Build duration: 1 min 5 sec and counting CONSOLE OUTPUT [...trun

KDE CI: Frameworks » networkmanager-qt » kf5-qt5 SUSEQt5.12 - Build # 93 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/networkmanager-qt/job/kf5-qt5%20SUSEQt5.12/93/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 23 Apr 2020 08:39:10 + Build duration: 59 sec and counting CONSOLE OUTPUT [...truncate

D29121: Replace foreach with range-for

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, jgrulich. Herald added a project: Frameworks. Herald added 1 blocking reviewer(s): jgrulich. ahmadsamir requested review of this revision. REVISION SUMMARY I missed one file before, now it should actually build with -DQT_N

D29121: Replace foreach with range-for

jgrulich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R282 NetworkManagerQt BRANCH l-foreach-5 (branched from master) REVISION DETAIL https://phabricator.kde.org/D29121 To: ahmadsamir, #frameworks, jgrulich Cc: kde-frameworks-devel, LeGast00n, cblack

D29121: Replace foreach with range-for

This revision was automatically updated to reflect the committed changes. Closed by commit R282:b53859b89a13: Replace foreach with range-for (authored by ahmadsamir). REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29121?vs=80963&id=80965 REVISION DET

D29123: WIP BUG: 420312. Do not mark entry as uninstalled if uninstallation script failed

alex created this revision. alex added reviewers: KNewStuff, meven, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY As described in the bug report the uninstallation failed, but the service w

KDE CI: Frameworks » networkmanager-qt » kf5-qt5 SUSEQt5.14 - Build # 9 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/networkmanager-qt/job/kf5-qt5%20SUSEQt5.14/9/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 23 Apr 2020 09:11:44 + Build duration: 8 min 7 sec and counting BUILD ARTIFACTS acc/KF5

KDE CI: Frameworks » networkmanager-qt » kf5-qt5 SUSEQt5.12 - Build # 94 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/networkmanager-qt/job/kf5-qt5%20SUSEQt5.12/94/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 23 Apr 2020 09:11:44 + Build duration: 10 min and counting BUILD ARTIFACTS acc/KF5Netw

D29123: WIP BUG: 420312. Do not mark entry as uninstalled if uninstallation script failed

leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. The reporting side of this seems based on a misunderstanding of what the UI-less Core is supposed to be doing... The conceptual intention in general isn't bad, but it needs a bit

D29123: WIP BUG: 420312. Do not mark entry as uninstalled if uninstallation script failed

leinir added a comment. (and now i've done it myself, terribly sorry about that, missed the WIP at the start of the title! Hope some of my comments were useful, though :) ) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29123 To: alex, #knewstuff, meven, ngraham,

D29051: Add ecm_generate_dbus_service_file

davidedmundson added a dependent revision: D28305: Systemd Startup. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29051 To: broulik, #frameworks, davidedmundson, kossebau, kfunk, habacker Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencrea

D29034: Add systemd user service file for kded

davidedmundson added a dependent revision: D28305: Systemd Startup. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29034 To: broulik, #plasma, #frameworks Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29035: Install service files for kwin

davidedmundson added a dependent revision: D28305: Systemd Startup. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D29035 To: broulik, #plasma, #frameworks Cc: davidedmundson, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, mkulin

D28355: Introduce function ecm_install_configured_file

davidedmundson added a dependent revision: D28305: Systemd Startup. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D28355 To: davidedmundson Cc: apol, kossebau, pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh, ngraham, bru

D29123: WIP BUG: 420312. Do not mark entry as uninstalled if uninstallation script failed

alex added a comment. No problem :-). And good to know that the concept of this patch makes sense ^^. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29123 To: alex, #knewstuff, meven, ngraham, leinir Cc: leinir, kde-frameworks-devel, LeGast00n, cblack, michaelh,

D29095: New much simpler mouse icon that works in both light and dark breeze

saligari updated this revision to Diff 80971. saligari added a comment. Changed the icon, with ndavis' help, so that it better fits its 64px place. I also tried joystick's/input gaming colors but didn't like it much, here's a comparison in 64px: REPOSITORY R266 Breeze Icons CHANGES SI

D29062: Port KToolInvocation::kdeinitExecWait to QProcess

This revision was automatically updated to reflect the committed changes. Closed by commit R297:37137cec3a92: Port KToolInvocation::kdeinitExecWait to QProcess (authored by broulik). REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29062?vs=80785&id=80973 REVISION

D29126: KNewStuff: port from KRun::runApplication to KIO::ApplicationLauncherJob

dfaure created this revision. dfaure added reviewers: ngraham, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY The plan is to deprecate KRun::run* TEST PLAN Builds REPOSITORY R304 KNewS

D29123: WIP BUG: 420312. Do not mark entry as uninstalled if uninstallation script failed

alex updated this revision to Diff 80976. alex added a comment. Use internal question system PS: I am not sure on which branch this should land, thats why I haven't edited the translations. REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29123?vs=80

D29123: WIP BUG: 420312. Do not mark entry as uninstalled if uninstallation script failed

alex marked 3 inline comments as done. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29123 To: alex, #knewstuff, meven, ngraham, leinir Cc: leinir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29126: KNewStuff: port from KRun::runApplication to KIO::ApplicationLauncherJob

leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Was /just/ about to be all "nooo, widgets in core, crying forever" but this isn't core, so go for it ;) REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.k

D29126: KNewStuff: port from KRun::runApplication to KIO::ApplicationLauncherJob

dfaure added a comment. And KRun was widgets based too. At least now you can get rid of widgets completely (for this bit about starting apps) by connecting to the result() signal yourself instead of using a dialog ui delegate. There's also a knotifications based ui delegate, but not sure it'

D29126: KNewStuff: port from KRun::runApplication to KIO::ApplicationLauncherJob

dfaure closed this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29126 To: dfaure, ngraham, broulik, leinir Cc: leinir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29126: KNewStuff: port from KRun::runApplication to KIO::ApplicationLauncherJob

leinir added a comment. In D29126#655523 , @dfaure wrote: > And KRun was widgets based too. At least now you can get rid of widgets completely (for this bit about starting apps) by connecting to the result() signal yourself instead of using a di

D29096: Prefix includes and libs dir with QT_SYSROOT

kossebau added a comment. Thanks for the explanation, fear though I am missing some details and thus have not yet understood the problem and the solution. Not having done much cross-compilation-library-setups naively I would have thought that when building a library which uses ECMGeneratePri

D29096: Prefix includes and libs dir with QT_SYSROOT

kossebau added reviewers: Build System, apol, vkrause, kfunk. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29096 To: ablu, #build_system, apol, vkrause, kfunk Cc: kossebau, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh, ngr

D28355: Introduce function ecm_install_configured_file

kossebau added a reviewer: Build System. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D28355 To: davidedmundson, #build_system Cc: apol, kossebau, pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh, ngraham, bruns

D28882: Create protocol to manage video feeds

apol updated this revision to Diff 80984. apol added a comment. Also propagate the buffer size, it's important for the client to know what buffer size it will have. REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28882?vs=80801&id=80984 BRANCH master R

D29096: Prefix includes and libs dir with QT_SYSROOT

ablu added a comment. > Not having done much cross-compilation-library-setups naively I would have thought that when building a library which uses ECMGeneratePriFile and preparing it for cross-compilation, the installation prefix would be hardcoded into the generated artifacts.. Seems that i

D29065: [KFontChooser] Add a DisplayFlag to allow not showing fixedOnly checkbox

ahmadsamir updated this revision to Diff 80988. ahmadsamir added a comment. - Use a proper flag set, 0/1/2/4/8, from dfaure - When checking a flag is set use bitwise &, not bitwise ^, the latter would fail if another flag was set - As per dfaure's suggestion, when FixedFontsOnly is set, do

D29065: [KFontChooser] Add new DisplayFlag; modify how flags are used

ahmadsamir updated this revision to Diff 80989. ahmadsamir marked 2 inline comments as done. ahmadsamir retitled this revision from "[KFontChooser] Add a DisplayFlag to allow not showing fixedOnly checkbox" to "[KFontChooser] Add new DisplayFlag; modify how flags are used". ahmadsamir edited the

D28355: Introduce function ecm_install_configured_file

kossebau added a comment. A bit unsure if the arg name "TEMPLATES" is good, or if perhaps should be renamed to "INPUT". Just mentioning, not preferring one over the other. So far have not found existing samples to take as lead for consistent argument naming. For completeness, would be go

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added a comment. In D28353#655226 , @ngraham wrote: > It's okay. :) > > This is gonna seem like a really dumb question, but which images are the befores and which are the afters? Not a dumb question! They are all before-afte

KDE CI: Frameworks » kdeclarative » kf5-qt5 FreeBSDQt5.14 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdeclarative/job/kf5-qt5%20FreeBSDQt5.14/10/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 23 Apr 2020 13:03:44 + Build duration: 2 min 7 sec and counting JUnit Tests Name: pr

D29051: Add ecm_generate_dbus_service_file

kossebau added a comment. Any chance for a simple unit test to check the generation does what is expected (or catches bad input)? :) INLINE COMMENTS > ECMGenerateDBusServiceFile.cmake:22 > +# are to be installed in the same directory as the D-Bus daemon. On other > platforms > +# must

D28582: KRunner: Show error message for Actions in dbus runner

alex added a comment. I am also going to try a friendly ping here :-). REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D28582 To: alex, #plasma, davidedmundson, broulik, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29065: [KFontChooser] Add new DisplayFlag; modify how flags are used

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH l-kfontchooser-onlyfixed-display-flag (branched from master) REVISION DETAIL https://phabricator.kde.org/D29065 To: ahmadsamir, #frameworks, dfaure, cfeck, bport Cc: kde-f

D29065: [KFontChooser] Add new DisplayFlag; modify how flags are used

dfaure added inline comments. INLINE COMMENTS > kfontchooser.h:87 > +NoDisplayFlags = 0, ///< No flags set > +FixedFontsOnly = 1, ///< Only show fixed fonts, excluding > proportional fonts > +DisplayFrame = 2, ///< Show a visual frame around the chooser may

D27860: [server] Add some sub-surface life cycle signals

This revision was automatically updated to reflect the committed changes. Closed by commit R127:8945c1f7baaf: [server] Add some sub-surface life cycle signals (authored by zzag). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27860?vs=76996&id=80998#toc REPOSITORY R127 KWayland CHANGE

D29065: [KFontChooser] Add new DisplayFlag; modify how flags are used

kossebau added inline comments. INLINE COMMENTS > kfontchooser.h:90 > +ShowDifferences = 4,///< Display the font differences interfaces > +NoFixedCheckBox = 8 ///< Do not Show a checkbox to toggle > showing only fixed fonts > }; I would add a final ",", so you do no

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.14 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.14/11/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 23 Apr 2020 13:38:54 + Build duration: 7 min 26 sec and counting JUnit Tests Name: proje

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

ngraham added a comment. To be honest, I kinda prefer the befores since the afters are significantly darker. Is there a way to preserve the desired level of translucency without causing the background to darken like that? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https:

D29095: New much simpler mouse icon that works in both light and dark breeze

ngraham added a comment. Hmm yeah, that gray color is probably too dark. Also a color that dark likely wouldn't need an outline as it would be visible on both light and dark backgrounds. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29095 To: saligari, #vdg

D29065: [KFontChooser] Add new DisplayFlag; modify how flags are used

ahmadsamir marked an inline comment as done. ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kfontchooser.h:87 > maybe document that FixedFontsOnly implies NoFixedCheckBox? > > (as in, the widget will behave as if NoFixedCheckBox was set) Yes, will do (less surprises for use

D29034: Add systemd user service file for kded

bruns added inline comments. INLINE COMMENTS > davidedmundson wrote in plasma-kded.service.in:5 > @CMAKE_INSTALL_FULL_BINDIR@ How about using some LIBEXEC dir instead, this should never be called directly, or am I missing something? REPOSITORY R297 KDED REVISION DETAIL https://phabricator

D29034: Add systemd user service file for kded

broulik added inline comments. INLINE COMMENTS > bruns wrote in plasma-kded.service.in:5 > How about using some LIBEXEC dir instead, this should never be called > directly, or am I missing something? This is unrelated and kded has been there forever REPOSITORY R297 KDED REVISION DETAIL ht

D29065: [KFontChooser] Add new DisplayFlag; modify how flags are used

kossebau added inline comments. INLINE COMMENTS > ahmadsamir wrote in kfontchooser.h:90 > Wouldn't that look a bit weird as if something has been removed or missing? I might perhaps while getting used to if you are coming from old code habits, but the syntax of C++ has been extra extended to al

D29065: [KFontChooser] Add new DisplayFlag; modify how flags are used

dfaure added a comment. I agree, it's now common practice to have a final comma. REPOSITORY R236 KWidgetsAddons BRANCH l-kfontchooser-onlyfixed-display-flag (branched from master) REVISION DETAIL https://phabricator.kde.org/D29065 To: ahmadsamir, #frameworks, dfaure, cfeck, bport Cc:

D29065: [KFontChooser] Add new DisplayFlag; modify how flags are used

ahmadsamir updated this revision to Diff 81007. ahmadsamir marked an inline comment as done. ahmadsamir added a comment. More docs, and a trailing comma in the enum to ease git diff/blame if more flags are added REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator

D29065: [KFontChooser] Add new DisplayFlag; modify how flags are used

ahmadsamir marked an inline comment as done. REPOSITORY R236 KWidgetsAddons BRANCH l-kfontchooser-onlyfixed-display-flag (branched from master) REVISION DETAIL https://phabricator.kde.org/D29065 To: ahmadsamir, #frameworks, dfaure, cfeck, bport Cc: kossebau, kde-frameworks-devel, LeGast00

D28882: Create protocol to manage video feeds

jgrulich added a comment. I have tested this and it now works as before, tested with Chromium, while checking all the values we pass to the portal and PipeWire which seem to be correct. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin, jgrulic

D29095: New much simpler mouse icon that works in both light and dark breeze

bruns added a comment. The new one looks very oldschool. Some ideas how to improve that: - buttons are typically only separated from each other, but not from the body, try removing the horizontal line - the body should be narrower at the center - the gradient does not match the shape.

D29065: [KFontChooser] Add new DisplayFlag; modify how flags are used

This revision was automatically updated to reflect the committed changes. Closed by commit R236:0004e5c89a24: [KFontChooser] Add new DisplayFlag; modify how flags are used (authored by ahmadsamir). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29065?vs

D29095: New much simpler mouse icon that works in both light and dark breeze

bruns added a comment. F8255905: bitmap.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29095 To: saligari, #vdg Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh

D29095: New much simpler mouse icon that works in both light and dark breeze

ouwerkerk added a comment. In D29095#655214 , @ngraham wrote: > FWIW all the mice in my house have this exact shape, but they're black, not gray. So I don't think the shape is too old-fashioned per se. It's the gray color that's anacrhonistic pa

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added a comment. In D28353#655680 , @ngraham wrote: > To be honest, I kinda prefer the befores since the afters are significantly darker. Is there a way to preserve the desired level of translucency without causing the background to da

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

kmaterka updated this revision to Diff 81031. kmaterka added a comment. Rebase to master (includes D29102 ) REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28470?vs=80148&id=81031 BRANCH master REVIS

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

kmaterka added a reviewer: Frameworks. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28470 To: kmaterka, #plasma, broulik, apol, davidedmundson, #frameworks Cc: mart, davidre, cblack, kde-frameworks-devel, #plasma, LeGast00n, michaelh, ngraham, brun

D29095: New much simpler mouse icon that works in both light and dark breeze

saligari updated this revision to Diff 81032. saligari added a comment. - tried to change the shape into something more modern (though I quite like the old-ish look) - changed the gradient as bruns said, can't say I see much difference - removed the middle curve REPOSITORY R266 Breeze I

D29095: New much simpler mouse icon that works in both light and dark breeze

bruns added a comment. > Bruns's comment about right-handed mice (gradient) is due to the quite asymmetrical shape many modern mice use for ergonomic reasons (RSI). No, even for a ball bottom right is darkest. Shapes should be drawn as if there were a light at the top left, i.e. with a s

D29136: Use non-deprecated KDEInstallDir

heikobecker created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. heikobecker requested review of this revision. REVISION SUMMARY I noticed that when installeding marble, which sets KDE_INSTALL_DIRS_NO_DEPRECATED, which then invalidates a p

D29136: Use non-deprecated KDEInstallDir

heikobecker updated this revision to Diff 81035. heikobecker added a comment. Added missing parentheses REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29136?vs=81033&id=81035 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29136 AFFECTED FIL

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

ngraham added a comment. Yeah, to me the third version looks better than the status quo for some wallpapers, but worse for others. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added a comment. Same. I will try some half-way that works everywhere more consistenly. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28353 To: niccolove, #vdg, #plasma, cblack Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, micha

D29138: [Solid] Replace foreach (deprecated) with range/index for

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, apol, meven. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY src/imports/devices.cpp src/solid/devices/backends/fakehw/* src/solid/devices/backends/fstab/* TE

D29095: New much simpler mouse icon that works in both light and dark breeze

saligari updated this revision to Diff 81041. saligari added a comment. - corrected hard edges - aaand that's it probably for me, I'm reasonably happy with this and I think I've learned quite a bit - Here it is ^_^ REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabri

D29095: New much simpler mouse icon that works in both light and dark breeze

ngraham added a comment. That's much better! I think I'd use a slightly darker shade of gray though. Not much, just a bit. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29095 To: saligari, #vdg Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGa

D28882: Create protocol to manage video feeds

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. In future, it might be faster to put up just the interface xml for review first. -- In terms of wayland protocols this is non-standard. All clien

Re: Problems in KWayland causes by API and ABI compatibility promises

We had a meeting. It resulted in some final action decisions. These will affect the kwayland folder in frameworks. The meeting was attended by: Kevin Ottens, Vlad Zahorodnii, Aleix Pol, Myself, Benjamin Port who all approved the plan. *Protocols:* We make a new repo. It will contain just protoco

D28811: Add drawer on mobile and clean code

This revision was automatically updated to reflect the committed changes. Closed by commit R264:e7645ba24570: Add drawer on mobile and clean code (authored by ognarb). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28811?vs=80229&id=81051#toc REPOSITORY R264 KApiDox CHANGES SINCE LAST

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D28470 To: kmaterka, #plasma, broulik, apol, davidedmundson, #frameworks Cc: mart, davidre, cblack,

D29138: [Solid] Replace foreach (deprecated) with range/index for

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Wow those iterations over map.keys() were awful. REPOSITORY R245 Solid BRANCH l-foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D29138 To: ahmadsamir, #fr

D29138: [Solid] Replace foreach (deprecated) with range/index for

bruns added inline comments. INLINE COMMENTS > fakecdrom.cpp:48 > + > +for (auto it = map.cbegin(); it != map.cend(); ++it) { > +if (supported_medialist.contains(it.value())) { The obviously better solution is to iterate over `supported_medialist` and swap the key and value of the m

D29138: [Solid] Replace foreach (deprecated) with range/index for

bruns added inline comments. INLINE COMMENTS > fakeopticaldisc.cpp:38 > + > +for (auto it = map.cbegin(); it != map.cend(); ++it) { > +if (content_typelist.contains(it.value())) { dito REPOSITORY R245 Solid BRANCH l-foreach (branched from master) REVISION DETAIL https://phab

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

meven added a comment. In D28590#654139 , @bruns wrote: > Do not create m_storageAccess in the constructor Hmm, you told me `the f (m_displayName.isEmpty()) block belongs here`, I don't see why instantiating `m_storageAccess` here is bad

D28590: Add a QString Solid::Device::displayName, used in Fstab Device for network mounts

meven updated this revision to Diff 81061. meven added a comment. avoid instanciating m_storageAccess in FstabDevice::FstabDevice REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28590?vs=79922&id=81061 BRANCH arcpatch-D28590 REVISION DETAIL https://phabr

D29138: [Solid] Replace foreach (deprecated) with range/index for

meven added a comment. In D29138#656094 , @dfaure wrote: > Wow those iterations over map.keys() were awful. We still have a few of those in solid : $ rg ".keys\(\)" src/tools/solid-hardware/solid-hardware.cpp 151:Q_FOREA

D29101: WIP BUG: 420312 Fix file path and process call

alex updated this revision to Diff 81062. alex added a comment. Use KShell to split args REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29101?vs=80907&id=81062 BRANCH bugfix_uninstall (branched from master) REVISION DETAIL https://phabricator.kde.or

D29101: WIP BUG: 420312 Fix file path and process call

alex edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29101 To: alex, #knewstuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29101: WIP Fix file path and process call

meven retitled this revision from "WIP BUG: 420312 Fix file path and process call" to "WIP Fix file path and process call". meven edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29101 To: alex, #knewstuff, ngraham, nicolasfella, el