KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 249 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/249/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 25 Apr 2020 13:42:54 + Build duration: 3 min 59 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.14 - Build # 41 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.14/41/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 25 Apr 2020 13:39:52 + Build duration: 6 min 7 sec and counting JUnit

D29153: Move handling of untrusted programs to ApplicationLauncherJob.

dfaure added a comment. > The question is how that will work in conjunction with KNotificationJobUiDelegate? In principle we could also make it emit a KNotification with buttons We would need a KIO::NotificationJobUiDelegate subclass of KNotificationJobUiDelegate in KIOGui, which also

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.14 - Build # 9 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.14/9/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 25 Apr 2020 13:43:55 + Build duration: 4 min 7 sec and counting BUILD ARTIFACTS

D26342: Allow overriding to disable auto language detection

aacid added a comment. You need to update the \since markers? After that i guess you can commit unless anyone really disagrees? @mludwig @cullmann ? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D26342 To: sdepiets, #frameworks, cullmann, mlaurent, mludwig

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.14 - Build # 10 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.14/10/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 25 Apr 2020 13:42:03 + Build duration: 2 min 16 sec and counting JUnit Tests

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.14 - Build # 8 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.14/8/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sat, 25 Apr 2020 13:39:52 + Build duration: 4 min 0 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 248 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/248/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 25 Apr 2020 13:39:52 + Build duration: 3 min 1 sec and counting BUILD ARTIFACTS

D26342: Allow overriding to disable auto language detection

sdepiets updated this revision to Diff 81176. sdepiets added a comment. - Merge branch 'master' of git.kde.org:sonnet REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26342?vs=76992=81176 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26342

Re: changing icon sizes no longer emits signal

Am Samstag, 25. April 2020, 15:10:37 CEST schrieb Martin Koller: > Hi, > > in liquidshell I'm using > > connect(KIconLoader::global(), ::iconLoaderSettingsChanged, > this, ::adjustIconSize); > > to be informed whenever the icon sizes get changed in systemsettings. > I don't know since when

D29138: [Solid] Replace foreach (deprecated) with range/index for

ahmadsamir added inline comments. INLINE COMMENTS > bruns wrote in fakeopticaldisc.cpp:43 > Just use `0`. It doesn't make the code more readable; and using QMap::constFind() while iterating is more recognizable/widely-used. REPOSITORY R245 Solid BRANCH l-foreach (branched from master)

D28796: Update Logtalk language syntax support

This revision was automatically updated to reflect the committed changes. Closed by commit R216:bf2664ea7907: Update Logtalk language syntax support (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28796?vs=80017=81172

D29181: Use KFileMetaData for XAttr support instead of private reimplementation

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY This removes a lot of duplicate code, and on top it actually works as it no

changing icon sizes no longer emits signal

Hi, in liquidshell I'm using connect(KIconLoader::global(), ::iconLoaderSettingsChanged, this, ::adjustIconSize); to be informed whenever the icon sizes get changed in systemsettings. I don't know since when but at least in version Operating System: openSUSE Tumbleweed 20200419 KDE Plasma

D28909: smb: port to Result system to force serialization of error/finish condition

meven added inline comments. INLINE COMMENTS > dfaure wrote in kio_smb.h:96 > Excellent idea, but why wait for KF6? > > We could implement a subclass of SlaveBase, in KIO, let's call it > SlaveBaseV2, which > > - Reimplements all the virtual methods from SlaveBase, in a private section > -

D29138: [Solid] Replace foreach (deprecated) with range/index for

bruns added inline comments. INLINE COMMENTS > ahmadsamir wrote in fakeopticaldisc.cpp:43 > It doesn't make the code more readable; and using QMap::constFind() while > iterating is more recognizable/widely-used. You are contradicting yourself. You use value() for content, but for

D28745: Skip caching thumbnails on encrypted filesystems

marcingu updated this revision to Diff 81167. marcingu added a comment. Limiting usage of KMountPoint and lstat to max once per directory. REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28745?vs=80526=81167 REVISION DETAIL

D28745: Skip caching thumbnails on encrypted filesystems

marcingu marked 2 inline comments as done. marcingu added a comment. Unless there's way to get rid of KMountPoint completely, this should reduce number of calls to minimum. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik,

KAcceleratorManager, Kirigami and accelerator key translations

Hello, I have reported Bug #420488 and got to know that similar bugs have been reported such as #407386, #417467. This was supposed to be fixed by #406035 but the fix was not effective at all. Inspired by this, I have checked how other languages are translating the accelerator keys and found

D29153: Move handling of untrusted programs to ApplicationLauncherJob.

dfaure updated this revision to Diff 81173. dfaure added a comment. Make UntrustedProgramHandlerInterface async. This required a nasty QEventLoop for KRun though, since it has a sync API. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29153?vs=81158=81173

D28956: [QML Monitor] Show remaining time as soon as possible

bruns added a comment. Ping! REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28956 To: bruns, #baloo, ngraham Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D28932: Store filename terms just once

bruns added a comment. Ping! REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28932 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D29138: [Solid] Replace foreach (deprecated) with range/index for

bruns added inline comments. INLINE COMMENTS > ahmadsamir wrote in fakeopticaldisc.cpp:43 > I was talking about something like Solid::OpticalDrive::MediumType(0); > ContentType has Solid::OpticalDisc::NoContent whereas MediumType has nothing > similar. > > IIUC named casts are preferred over

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.14 - Build # 42 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.14/42/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sat, 25 Apr 2020 13:46:09 + Build duration: 6 min 2 sec and counting JUnit Tests

D26342: Allow overriding to disable auto language detection

sdepiets updated this revision to Diff 81177. sdepiets added a comment. Bump since + autotest checks the language as well REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26342?vs=81176=81177 BRANCH master REVISION DETAIL

D29138: [Solid] Replace foreach (deprecated) with range/index for

D29175: DBus Runner: Add service property to request actions once

alex created this revision. alex added reviewers: Plasma, meven, ngraham, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY With the `X-Plasma-Request-Actions-Once` property the plugin can

D28796: Update Logtalk language syntax support

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, I see, there is an extra request for the new hl test file. Then let's approve this one. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D28796

D28777: FstabDevice: Reevaluate emblems only when state changes

bruns added a comment. Ping! REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28777 To: bruns, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28776: FstabDevice: Avoid recurrent construction of emblems QStringList

bruns added a comment. Ping! REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D28776 To: bruns, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.14 - Build # 9 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.14/9/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sat, 25 Apr 2020 13:39:52 + Build duration: 2 min 8 sec and counting JUnit Tests

D28932: Store filename terms just once

ngraham added a comment. I'll get around to reviewing this soon. I'm trying to figure out of I think the loss is acceptable. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28932 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n,

D29050: WIP KRunner fix prepare/teardown signals

alex retitled this revision from "WIP KRunner: Fix Bug 420311" to "WIP KRunner fix prepare/teardown signals". REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29050 To: alex, meven, ngraham, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28932: Store filename terms just once

bruns added a comment. In D28932#657011 , @ngraham wrote: > I'll get around to reviewing this soon. I'm trying to figure out of I think the loss is acceptable. There is no loss, there is even a gain (queries work correctly in all

D29170: Detect executables without +x permission in $PATH to improve error message

ahmadsamir added inline comments. INLINE COMMENTS > kprocessrunner.cpp:53 > +// This is a *very* simplified version of > QStandardPaths::findExecutable > +const QStringList searchPaths = > QString::fromLocal8Bit(qgetenv("PATH")).split(QDir::listSeparator(), >

D28956: [QML Monitor] Show remaining time as soon as possible

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28956 To: bruns, #baloo, ngraham Cc: apol, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas,

D28956: [QML Monitor] Show remaining time as soon as possible

This revision was automatically updated to reflect the committed changes. Closed by commit R293:60766d57999c: [QML Monitor] Show remaining time as soon as possible (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28956?vs=80489=81179

D28980: Revert "add Baloo DBus signals for moved or removed files"

This revision was automatically updated to reflect the committed changes. Closed by commit R293:c2865b207907: Revert add Baloo DBus signals for moved or removed files (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28980?vs=80540=81180

D29171: Add 16px konversation icon

manueljlin created this revision. manueljlin added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. manueljlin requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH konversation16px (branched from master) REVISION DETAIL

building KF5 projects against a different Qt5 version (than the one the KF5 frameworks were built against)

Hi, A priori Qt guarantees that you can run binaries against a different, newer Qt version than they were built against, as long as no private APIs are used. This also works if that newer Qt version is installed elsewhere, provided you set LD_LIBRARY_PATH correctly (and possibly LD_PRELOAD). I

D28909: smb: port to Result system to force serialization of error/finish condition

dfaure added inline comments. INLINE COMMENTS > sitter wrote in kio_smb.h:96 > Sure, if you think it's solid enough from an API POV. > > I was thinking that we should amend the slavebase API for KF6 in general. > Instead of having error/finished/opened all functions on an API level should >

D28870: Updated test file for Logtalk syntax highlighting

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D28870 To: pmoura, cullmann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns,

D28870: Updated test file for Logtalk syntax highlighting

This revision was automatically updated to reflect the committed changes. Closed by commit R216:559cda73cf57: Updated test file for Logtalk syntax highlighting (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D29188: [FileWatch] Remove redundant watchIndexedFolders() slot

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY updateIndexedFoldersWatches() has the same effect, so there is no need for

D29171: Add 16px konversation icon

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH konversation16px (branched from master) REVISION DETAIL https://phabricator.kde.org/D29171 To: manueljlin, #vdg, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack,

D29190: [FileWatchTest] Extend coverage to config updates

bruns updated this revision to Diff 81207. bruns added a comment. whitespace REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29190?vs=81205=81207 BRANCH fwtest REVISION DETAIL https://phabricator.kde.org/D29190 AFFECTED FILES

D29170: Detect executables without +x permission in $PATH to improve error message

dfaure updated this revision to Diff 81213. dfaure added a comment. Resolve relative executables using the directory of the .desktop file referring to them Not useful for /usr/share/applications stuff, but useful for custom setups where a custom desktop file refers to a local

D29181: Use KFileMetaData for XAttr support instead of private reimplementation

This revision was automatically updated to reflect the committed changes. Closed by commit R293:774bd228b749: Use KFileMetaData for XAttr support instead of private reimplementation (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D29189: [KInotify] Fix path matching when removing watches

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY As in removeWatch the path is passed in with a trailing slash, no path is

D29170: Detect executables without +x permission in $PATH to improve error message

dfaure updated this revision to Diff 81209. dfaure added a comment. Better support for relative vs absolute executable names, with unittest. But I'll look into relative-to-desktop-file instead of relative-to-QDir::current. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D29095: New much simpler mouse icon that works in both light and dark breeze

ndavis added a comment. In D29095#656819 , @saligari wrote: > Oh the shame! I had forgotten to center it (and I do know how to)! > > One thing I don't know is: since I centered it and used the guidelines my 1px line centered sits on a 0,5 to

D29170: Detect executables without +x permission in $PATH to improve error message

dfaure marked an inline comment as done. dfaure added inline comments. INLINE COMMENTS > ahmadsamir wrote in kprocessrunner.cpp:53 > KProcessRunner tries finding the executable in the current dir too, so to be > precise in the reported error message maybe append currentDir.absolutePath() > to

D29095: Change mouse icon to have better dark theme contrast.

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29095 To: ndavis, #vdg, saligari Cc: bruns, ouwerkerk, ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh

D29181: Use KFileMetaData for XAttr support instead of private reimplementation

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D29181 To: bruns, #baloo, ngraham, apol Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov,

D29095: Change mouse icon to have better dark theme contrast.

ndavis retitled this revision from "New much simpler mouse icon that works in both light and dark breeze" to "Change mouse icon to have better dark theme contrast.". ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons

D29190: [FileWatchTest] Extend coverage to config updates

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Currently, config changes are not covered in the tests, add a test case

D29190: [FileWatchTest] Extend coverage to config updates

bruns added a dependent revision: D29191: [FileWatch] Fix watch updates on config changes. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D29190 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson,

D29189: [KInotify] Fix path matching when removing watches

bruns edited the summary of this revision. bruns added a dependency: D29190: [FileWatchTest] Extend coverage to config updates. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D29189 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n,

D29190: [FileWatchTest] Extend coverage to config updates

bruns added a dependent revision: D29189: [KInotify] Fix path matching when removing watches. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D29190 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson,

D29191: [FileWatch] Fix watch updates on config changes

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Track the current list of include/exclude folders, and on a config change

D29095: New much simpler mouse icon that works in both light and dark breeze

ndavis commandeered this revision. ndavis added a reviewer: saligari. ndavis added a comment. Saligari is Ok with me taking over this patch. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29095 To: ndavis, #vdg, saligari Cc: bruns, ouwerkerk, ndavis, ngraham,

D29095: Change mouse icon to have better dark theme contrast

ndavis retitled this revision from "Change mouse icon to have better dark theme contrast." to "Change mouse icon to have better dark theme contrast". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29095 To: ndavis, #vdg, saligari Cc: bruns, ouwerkerk, ndavis,

D29095: Change mouse icon to have better dark theme contrast.

ndavis updated this revision to Diff 81211. ndavis added a comment. - Change style REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29095?vs=81156=81211 BRANCH arcpatch-D29095 REVISION DETAIL https://phabricator.kde.org/D29095 AFFECTED FILES

D27216: [KProcessRunner] Improve error messages on failure

dfaure added a comment. Note that D29153 affects this since it will detect the lack of +x ahead of time in ApplicationLauncherJob and prompt the user [if the application uses KIOWidgets' JobUiDelegate -- oh I need to do this in KRun, will do right away].

D29153: Move handling of untrusted programs to ApplicationLauncherJob.

dfaure updated this revision to Diff 81158. dfaure added a comment. Also set a KIO::JobUiDelegate in KRun itself (which simplifies its code) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29153?vs=8=81158 BRANCH 2020_04_UntrustedProgramHandler REVISION

D27216: [KProcessRunner] Improve error messages on failure

dfaure added a comment. Please ignore my previous comment. When launching gwenview by clicking on an image (and not on the gwenview executable itself), we indeed do end up with KProcessRunner failing to find the executable because of the missing -x. I'll implement the proper investigation

D29153: Move handling of untrusted programs to ApplicationLauncherJob.

broulik added a comment. The question is how that will work in conjunction with `KNotificationJobUiDelegate`? In principle we could also make it emit a `KNotification` with buttons INLINE COMMENTS > untrustedprogramhandlerinterface.h:79 > + */ > +bool

D29153: Move handling of untrusted programs to ApplicationLauncherJob.

dfaure added inline comments. INLINE COMMENTS > broulik wrote in untrustedprogramhandlerinterface.h:79 > I was wondering if this should be done async? Nested event loops are quite a > problem when QML is involved. I don't see a nested event loop in makeServiceFileExecutable. I guess your

D29170: Detect executables without +x permission in $PATH to improve error message

dfaure created this revision. dfaure added a reviewer: ahmadsamir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY QStandardPaths::findExecutable will not return to us a non-executable binary. So

D27216: [KProcessRunner] Improve error messages on failure

dfaure added a comment. Done in D29170 . Now we can start discussing the other part of the bug, executable doesn't launch due to missing libs. Ah BTW the unittest leads to "cp" failing because it deletes the temporary dir under cp's feet. This could

D29095: New much simpler mouse icon that works in both light and dark breeze

saligari updated this revision to Diff 81156. saligari added a comment. Oh the shame! I had forgotten to center it (and I do know how to)! One thing I don't know is: since I centered it and used the guidelines my 1px line centered sits on a 0,5 to 0,5 line. I don't know if that's bad or