D29238: Use Standard "Show/Hide Hidden files" shortcuts in directory chooser dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R135:f9f3f6ca260a: Use Standard Show/Hide Hidden files shortcuts in directory chooser dialog (authored by ngraham). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D29479: Fix rounded borders

This revision was automatically updated to reflect the committed changes. Closed by commit R242:1bc004e5c65f: Fix rounded borders (authored by niccolove). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29479?vs=82133=82147#toc REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE

D29479: Fix rounded borders

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D29479 To: niccolove, #plasma, broulik Cc: broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack,

D29479: Fix rounded borders

niccolove marked 2 inline comments as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29479 To: niccolove, #plasma, broulik Cc: broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29238: Use Standard "Show/Hide Hidden files" shortcuts in directory chooser dialog

ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH use-standard-show-hide-files-shortcuts (branched from master) REVISION DETAIL https://phabricator.kde.org/D29238 To: ngraham, #plasma,

D29479: Fix rounded borders

niccolove added inline comments. INLINE COMMENTS > broulik wrote in PlasmoidHeading.qml:74 > Where is `plasmoid` defined? It's not necessary to define it, when you use this in a plasmoid it takes it from the context REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

fakefred added a comment. In D25339#665351 , @xuetianweng wrote: > ... or you could give me some hint on that? Too bad I can't; it's been no more than a month since I began my study into KDE applications. I'd love to test out if someone

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng updated this revision to Diff 82170. xuetianweng added a comment. Use actual line height instead of representitive character. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25339?vs=80607=82170 BRANCH arcpatch-D25339 REVISION DETAIL

D25339: update lineHeight if boundingRect indicates a larger value.

anthonyfieroni added inline comments. INLINE COMMENTS > katerenderer.cpp:1192 > +// trigger view update, if any! > +QMetaObject::invokeMethod(m_view, "updateRendererConfig", > Qt::QueuedConnection); > +} Can you use functor here, instead of string. REPOSITORY R39

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng added a comment. In D25339#663915 , @fakefred wrote: > I second the as-an-option proposal. Hey, why not automatically increase the line height when CJK characters are detected? So the thing is we need to maintain a such

D25339: update lineHeight if boundingRect indicates a larger value.

xuetianweng retitled this revision from "KateRenderer: Use representitive character in CJK to estimate the fontHeight." to "update lineHeight if boundingRect indicates a larger value.". xuetianweng edited the summary of this revision. xuetianweng edited the test plan for this revision.

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

xuetianweng added a comment. I'm not sure if this is the right way to do it or it might cause any glitch, but here we go. Upon line rendering, update the maximum height we've ever seen. Though line height won't shrink during the edit phase, it will back to the actual value upon save.

D29461: Fix kio-extras build on Windows

meven requested changes to this revision. meven added a comment. This revision now requires changes to proceed. We have : kio-extras/cmake/Findlibssh.cmake To do that. I don't think copy/pasting code to `sftp/CMakeLists.txt` is necessary. REPOSITORY R320 KIO Extras REVISION DETAIL

D29381: Thumbnail text: use libmagic to detect encoding

meven added a comment. Perhaps it'd make sense to refactor this a bit and construct some test cases around encoding detection so we get a sense of reliablity? The way I am looking at this: either libmagic always does the best job at detecting encodings, at which point we'll want

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

dfaure updated this revision to Diff 82058. dfaure added a comment. -void KIO::OpenUrlJob::setRunFlags(KIO::ApplicationLauncherJob::RunFlags runFlags) +void KIO::OpenUrlJob::setDeleteTemporaryFile(bool b) The more I think about it, the least I like the use of flags here. 1. they

D29397: KPreviewJob : Support for DeviceRatioPixel

meven added a comment. In D29397#663800 , @dfaure wrote: > Oh, I thought it was sent as an int. But 8 is QImage::Format_ARGB8565_Premultiplied. Did you mean 0x80? No I meant 8, since format is passed as quint8 (a single byte, 8-bit) and

D29397: KPreviewJob : Support for DeviceRatioPixel

meven updated this revision to Diff 82056. meven added a comment. Add a static setDefaultDevicePixelRatio method to PreviewJob REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29397?vs=81982=82056 BRANCH preview-dpr REVISION DETAIL

D29397: KPreviewJob : Support for DeviceRatioPixel

broulik added inline comments. INLINE COMMENTS > meven wrote in previewjob.cpp:433 > Maybe make this static, so that apps have to do it once per app sort of like > we do with `Qt::AA_UseHighDpiPixmaps`, rather than by KPreviewJob. Not a fan. You can have different dpi per screen. Maybe instead

D29397: KPreviewJob : Support for DeviceRatioPixel

meven marked 2 inline comments as done. meven added a comment. I have pretty much the patch in kio-extras ready. So I am seeking INLINE COMMENTS > broulik wrote in previewjob.cpp:433 > Not a fan. You can have different dpi per screen. > Maybe instead we should have a `QWindow*` method or

D29447: Fix showing updates when the option is selected

This revision was automatically updated to reflect the committed changes. Closed by commit R304:25d391c6f36b: Fix showing updates when the option is selected (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29447?vs=82021=82064 REVISION

D29397: KPreviewJob : Support for DeviceRatioPixel

dfaure added a comment. In D29397#664536 , @meven wrote: > In D29397#663800 , @dfaure wrote: > > > Oh, I thought it was sent as an int. But 8 is QImage::Format_ARGB8565_Premultiplied. Did you mean

D25814: [KColorScheme] Add SeparatorColor

ahiemstra added a comment. I actually ran into this with the new Card designs I implemented in Kirigami. Kirigami right now does a lot of `tint(backgroundColor, textColor)` to generate separator colours. However, this leads to potential differences when the color set is View vs. Window or

D29397: KPreviewJob : Support for DeviceRatioPixel

meven updated this revision to Diff 82071. meven marked an inline comment as done. meven added a comment. Add @since to setDefaultDevicePixelRatio REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29397?vs=82056=82071 BRANCH preview-dpr REVISION DETAIL

D29461: Fix kio-extras build on Windows

brute4s99 updated this revision to Diff 82069. brute4s99 added a comment. updated the diff REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29461?vs=82039=82069 BRANCH arcpatch-D29461 REVISION DETAIL https://phabricator.kde.org/D29461 AFFECTED

D29461: Fix kio-extras build on Windows

brute4s99 added a subscriber: sitter. brute4s99 added a comment. @sitter could you please review this change as well? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29461 To: brute4s99, vonreth, meven Cc: sitter, meven, kde-frameworks-devel, kfm-devel, azyx,

D29461: Fix kio-extras build on Windows

sitter added a comment. Pid changes look fine, though perhaps we should just throw those two lines away? With Qt5 logging the pid is fairly pointless because one can simply set QT_MESSAGE_PATTERN to include the pid when necessary https://doc.qt.io/qt-5/qtglobal.html#qSetMessagePattern

D29397: KPreviewJob : Support for DeviceRatioPixel

meven planned changes to this revision. meven added a comment. In D29397#664605 , @dfaure wrote: > In D29397#664536 , @meven wrote: > > > In D29397#663800 ,

D29461: Fix kio-extras build on Windows

brute4s99 added inline comments. INLINE COMMENTS > sitter wrote in CMakeLists.txt:26 > Hm, I am a bit hazy on the details but I think this changes makes no sense. > libssh (upstream) introduced an imported target `ssh`. For backwards > compatibility we also inject this target when building

D29461: Fix kio-extras build on Windows

vonreth added inline comments. INLINE COMMENTS > brute4s99 wrote in CMakeLists.txt:26 > I just built libssh 0.9.4, and kio-extras builds fine without this line > change. Maybe we should try getting latest libssh onboard. Can I help in that > somehow @vonreth ? yes pls update libssh

D29223: Update Taiwanese holidays

cgiboudeaux added a comment. If everything is sorted and both of you agree, please accept one of the reviews and we'll happily push it if necessary. REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: weisi, #kde_pim, kde-frameworks-devel,

D29479: Fix rounded borders

niccolove edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29479 To: niccolove, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29451: KNS: Do not mark entry as installed if install script failed

leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. A bit nitpicky, that first one, the second's more serious (i'd like to avoid that in new code), but looks good otherwise :) INLINE COMMENTS > installation.cpp:355 >

D29479: Fix rounded borders

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. Notifications don't use `PlasmoidHeading` INLINE COMMENTS > PlasmoidHeading.qml:71 > +enabledBorders: { > +var borders = new Array() > +borders

D29455: KNS: Deprecate isRemote method and handle parse error properly

alex marked 2 inline comments as done. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29455 To: alex, #knewstuff, ngraham, leinir Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29451: KNS: Do not mark entry as installed if install script failed

alex updated this revision to Diff 82100. alex added a comment. Make lambda inline, capture variables REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29451?vs=82004=82100 BRANCH handle_install_script_error (branched from master) REVISION DETAIL

D29483: [knewfilemenu] Show inline warning when creating items with leading or trailing spaces

ngraham updated this revision to Diff 82102. ngraham added a comment. Spell "oddities" correctly REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29483?vs=82101=82102 BRANCH

D29223: Update Taiwanese holidays

nhiga updated this revision to Diff 82085. nhiga added a comment. Added 植樹節. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29223?vs=81833=82085 REVISION DETAIL https://phabricator.kde.org/D29223 AFFECTED FILES holidays/holidays.qrc holidays/plan2/holiday_tw_zh

D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error

broulik added inline comments. INLINE COMMENTS > ahmadsamir wrote in kopenwithdialog.cpp:1008 > Why not QFileInfo::isAbsolute()? Forgot that also existed, will update REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29445 To: broulik, #frameworks, #vdg Cc: ahmadsamir,

D25814: [KColorScheme] Add SeparatorColor

cfeck added a comment. There is QPalette::Button, but I don't see any hover/focus colors in QPalette. If we want more roles, we seriously need to contribute them upstream. Qt 6 is a chance to avoid diverging more. REPOSITORY R265 KConfigWidgets REVISION DETAIL

D29123: Do not mark entry as uninstalled if uninstallation script failed

leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. Sorry about missing that bic issue before... INLINE COMMENTS > leinir wrote in installation.cpp:653 > Unless you report the entry as changed, the cache will not be updated and

D29479: Fix rounded borders

niccolove created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. niccolove requested review of this revision. REVISION SUMMARY This makes borders of elements using plasmoidHeading rounded again REPOSITORY R242 Plasma Framework (Library)

D29397: KPreviewJob : Support for DeviceRatioPixel

meven updated this revision to Diff 82079. meven added a comment. Fix bitmask check REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29397?vs=82071=82079 BRANCH preview-dpr REVISION DETAIL https://phabricator.kde.org/D29397 AFFECTED FILES

D29455: KNS: Deprecate isRemote method and handle parse error properly

alex updated this revision to Diff 82098. alex marked an inline comment as done. alex added a comment. Typo and error message If the error message is on two lines they aren't very readable, but that is an issue for another day :-). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D29372: Taiwan: Use "zh_TW" language code

weisi abandoned this revision. weisi added a comment. Closing this revision. Let's get D29223 in. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29372 To: weisi, winterz Cc: nhiga, cgiboudeaux, kde-frameworks-devel,

D29373: Taiwan: Hardcoding holidays based on the Lunar Calendar; Minor update to the holiday list

weisi abandoned this revision. weisi added a comment. Closing this revision. Let's get D29223 in. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29373 To: weisi, winterz, cgiboudeaux Cc: nhiga, kde-frameworks-devel,

D29479: Fix rounded borders

niccolove edited the test plan for this revision. niccolove added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29479 To: niccolove, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D25814: [KColorScheme] Add SeparatorColor

davidedmundson added a comment. Relevant link on that last comment: https://bugreports.qt.io/browse/QTBUG-63331 They actively seeked our opinion on colour roles REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis, #frameworks, #vdg Cc:

D29455: KNS: Deprecate isRemote method and handle parse error properly

leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. Apart from these couple of details, it looks pretty good :) (i'd say just fix and commit, but one of them's a tiny bit larger than just a typo fix ;) ) INLINE COMMENTS >

D25814: [KColorScheme] Add SeparatorColor

ndavis added a comment. OK, I can agree with contributing upstream. I'll try talking on that bug report. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis, #frameworks, #vdg Cc: ahiemstra, broulik, manueljlin, alexde, ngraham, davidedmundson,

D29223: Update Taiwanese holidays

nhiga added a comment. Officially-recognized days (including 言論自由日) and the dates for 2020 can be found in this document

D29479: Fix rounded borders

ngraham added a comment. This fixes the square corners on tray popups for me, but not notifications. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29479 To: niccolove, #plasma Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29483: [knewfilemenu] Show inline warning when creating items with leading or trailing spaces

ngraham created this revision. ngraham added reviewers: Frameworks, VDG, cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY This is a somewhat unusual thing for a user to do intentionally, so

D29123: Do not mark entry as uninstalled if uninstallation script failed

alex added inline comments. INLINE COMMENTS > leinir wrote in installation.h:124 > Hmm... i find myself wondering what effect this has on BIC... something tells > me it might not be so great... Specifically, >

D29479: Fix rounded borders

niccolove updated this revision to Diff 82131. niccolove added a comment. Address some feedback REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29479?vs=82078=82131 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29479

D29479: Fix rounded borders

niccolove marked 2 inline comments as done. niccolove added a comment. In D29479#664767 , @broulik wrote: > Notifications don't use `PlasmoidHeading` Heh, it was actually an unrelated mistake: D29490

D29434: Use small font for ExpandableListItem subtitle

This revision was automatically updated to reflect the committed changes. Closed by commit R242:416f82f8f7f5: Use small font for ExpandableListItem subtitle (authored by ngraham). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven, sitter. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Use KIO::FileSystemFreeSpaceJob to check free space for remote urls. Thanks to sitter for

D29123: Do not mark entry as uninstalled if uninstallation script failed

alex updated this revision to Diff 82114. alex added a comment. Ensure bic REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29123?vs=81918=82114 BRANCH arcpatch-D29123_1 REVISION DETAIL https://phabricator.kde.org/D29123 AFFECTED FILES

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.14 - Build # 38 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.14/38/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Wed, 06 May 2020 14:56:08 + Build duration: 4 min 15 sec and counting JUnit Tests

D29238: Use Standard "Show/Hide Hidden files" shortcuts in directory chooser dialog

ngraham added a comment. Ping. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D29238 To: ngraham, #plasma, #frameworks Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot,

D29479: Fix rounded borders

niccolove updated this revision to Diff 82133. niccolove added a comment. Round things up again REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29479?vs=82131=82133 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29479

D29479: Fix rounded borders

niccolove marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29479 To: niccolove, #plasma, broulik Cc: broulik, ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

ahmadsamir added a comment. I couldn't seem to test the m_privilegeExecutionEnabled stuff, i.e. using dolphin, the paste action is disabled if the dir isn't owned by me. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29485 To: ahmadsamir, #frameworks, dfaure, meven,

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

ngraham added a comment. In D29485#664977 , @ahmadsamir wrote: > I couldn't seem to test the m_privilegeExecutionEnabled stuff, i.e. using dolphin, the paste action is disabled if the dir isn't owned by me. See D7563