D18380: KIO: make file dialog columns resizable again (and movable)

meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18380 To: rjvbb, ngraham, #frameworks, #dolphin, apol, dfaure, ahartmetz, markg Cc: markg, cfeck, dhaumann, kwrite-devel, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

D28379: KWidgetsAddons: Convert copyright headers to SPDX expressions

cordlandwehr added a comment. Ping :) REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D28379 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Fwd: KDE CI: Administration » Dependency Build Calligra stable-kf5-qt5 WindowsMSVCQt5.14 - Build # 24 - Still Failing!

Can someone investigate the below please? Thanks, Ben -- Forwarded message - From: CI System Date: Sun, May 10, 2020 at 8:01 PM Subject: KDE CI: Administration » Dependency Build Calligra stable-kf5-qt5 WindowsMSVCQt5.14 - Build # 24 - Still Failing! To: *BUILD FAILURE* Build

D29223: Update Taiwanese holidays

winterz added a comment. all opposed to this patch please speak up soon REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: weisi, #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, fbampaloukas, michaelh, ngraham, bruns, dvasin,

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 95 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/95/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sun, 10 May 2020 14:18:01 + Build duration: 6 min 0 sec and counting BUILD ARTIFACTS

D29600: Fix build with KF set to EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT

kossebau created this revision. kossebau added reviewers: Plasma, mart, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY NO_CHANGELOG REPOSITORY R242 Plasma Framework (Library) BRANCH

D29599: [CopyJob] Try to fix windows build

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d026227574b8: [CopyJob] Try to fix windows build (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29599?vs=82444=82447 REVISION DETAIL

D29600: Fix build with KF set to EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT

kossebau added a comment. Building all of KF with EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT set, so dropping any deprecated API from the build, serves as a small sanity check to see if the future (like KF6) is well prepared and there is no hidden undeprecated functional dependency on

D29599: [CopyJob] Try to fix windows build

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY The windows build is failing on the CI because of S_IWUSR; include kioglobal_p.h to try and fix that.

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 190 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/190/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 10 May 2020 15:18:48 + Build duration: 3 min 2 sec and counting

D23875: KCoreDirLister: fix crash when creating new folders from kfilewidget

dfaure added a subscriber: chinmoyr. dfaure added a comment. In D23875#532045 , @dhaumann wrote: > @dfaure: D21197 can be closed / abandoned? Yes, but @chinmoyr has disappeared, it seems? REPOSITORY

D29547: KRun: deprecate all static 'run*' methods, with full porting instructions

ahmadsamir added inline comments. INLINE COMMENTS > krun.h:216 > + * @deprecated since 5.6, use runApplication instead. > + * @deprecated since 5.71, use ApplicationLauncherJob instead. > + * @code I don't think you want both @deprecated? > krun.h:229 > */ > -

D29597: file extractor: fix linking

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Your build system seems to be broken. The "missing" methods are statically linked, see src/file/extractor/CMakeFiles/baloo_file_extractor.dir/baloosettings.cpp.o REPOSITORY R293

D29575: holidayregion.cpp - provide translatable strings for the German regions.

winterz updated this revision to Diff 82442. winterz added a comment. QLatin1-ify REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29575?vs=82398=82442 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29575 AFFECTED FILES

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 189 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/189/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 10 May 2020 14:18:01 + Build duration: 1 min 57 sec and counting CONSOLE OUTPUT

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 96 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/96/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sun, 10 May 2020 15:18:48 + Build duration: 8 min 33 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 594 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/594/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 10 May 2020 15:18:47 + Build duration: 8 min 59 sec and counting BUILD ARTIFACTS

D24367: Some sanity verification

This revision was automatically updated to reflect the committed changes. Closed by commit R287:8562ce18f1ab: Add some sanity and bounds checking (authored by sandsmark). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24367?vs=79917=82450#toc REPOSITORY R287 KImageFormats CHANGES

D29599: [CopyJob] Try to fix windows build

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Bonus points for keeping an eye on CI, I wish everyone did that ;-) REPOSITORY R241 KIO BRANCH l-fix-win-build (branched from master) REVISION DETAIL

D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog

dfaure added a reviewer: svuorela. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29558 To: dfaure, ahmadsamir, broulik, svuorela Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28760: KSettings::Dialog: avoid duplicate entries due cascading $XDG_DATA_DIRS

dfaure added a comment. ping? REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28760 To: dfaure, apol, broulik, davidedmundson, kossebau, svuorela Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29547: KRun: deprecate all static 'run*' methods, with full porting instructions

dfaure added a reviewer: svuorela. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29547 To: dfaure, ahmadsamir, broulik, svuorela Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29597: file extractor: fix linking

eszlari created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. eszlari requested review of this revision. REVISION SUMMARY [291/397] Linking CXX executable bin/baloo_file_extractor FAILED: bin/baloo_file_extractor : &&

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 103 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/103/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 10 May 2020 14:18:01 + Build duration: 9 min 15 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 593 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/593/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 10 May 2020 14:18:01 + Build duration: 18 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 104 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/104/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 10 May 2020 15:18:48 + Build duration: 7 min 38 sec and counting JUnit Tests Name:

Re: RFC: relative executables in desktop files

On Sun, Apr 26, 2020 at 1:36 PM David Faure wrote: > > During the review of https://phabricator.kde.org/D29170 the following > question surfaced again: should it be possible for a desktop file to refer to > an executable that is in the "current directory", for some definition of that > term.

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

patrickelectric added a comment. Just some small tips. INLINE COMMENTS > kcolorcombo.cpp:74 > bool paletteBrush = (k_colorcombodelegate_brush(index, > Qt::BackgroundRole).style() == Qt::NoBrush); > -if (isSelected) { > -innercolor =

D29610: [CopyJob] Use stricter conditions when using QFile::rename in slotResultRenaming

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. OK for now, to fix the unittests. The *real* fix however is to use QFile::rename in kio_file so that this failure to rename doesn't even happen in the first place. In this commit can

Re: Fwd: KDE CI: Administration » Dependency Build Calligra stable-kf5-qt5 WindowsMSVCQt5.14 - Build # 24 - Still Failing!

On Sunday, May 10, 2020 11:53:31 AM CEST Ben Cooksley wrote: > Can someone investigate the below please? Fixed by Ahmad today in https://phabricator.kde.org/D29599 -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis updated this revision to Diff 82476. araujoluis marked 2 inline comments as done. araujoluis added a comment. - kwidgetsaddons: kcolorcombo: set QRect colorRect as constant REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis updated this revision to Diff 82479. araujoluis added a comment. - kwidgetsaddons: kcolorcombo: fix comments REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29502?vs=82478=82479 BRANCH named_color_support REVISION DETAIL

D29511: Label: Add ping-pong logic

apol added a comment. I feel like this could break Labels unknowingly. Maybe it would make sense to have an extra scrollToFit (?) property or even another separate component to do that. Seeing things bouncing without the author intending could be worse than having the text cut off.

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 97 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/97/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sun, 10 May 2020 18:02:48 + Build duration: 5 min 11 sec and counting BUILD ARTIFACTS

D28033: Create ExpandableListItem

meven added a comment. Great consistency work ! CC @niccolove REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To: ngraham, #vdg, #plasma, davidedmundson Cc: meven, dfaure, mart, davidedmundson, bruns, niccolove, cblack, davidre,

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis updated this revision to Diff 82475. araujoluis added a comment. - kwidgetsaddons: kcolorcombo: rename a set constant for innerColor REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29502?vs=82219=82475 BRANCH named_color_support

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis updated this revision to Diff 82480. araujoluis marked an inline comment as done. araujoluis added a comment. - kwidgetsaddons: kcolorcombo: fix comments REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29502?vs=82479=82480 BRANCH

D29547: KRun: deprecate all static 'run*' methods, with full porting instructions

dfaure updated this revision to Diff 82453. dfaure marked 2 inline comments as done. dfaure added a comment. take review into account REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29547?vs=82325=82453 BRANCH 2020_05_deprecate_KRun_run_methods REVISION

D29547: KRun: deprecate all static 'run*' methods, with full porting instructions

dfaure marked 2 inline comments as done. dfaure added inline comments. INLINE COMMENTS > ahmadsamir wrote in krun.h:216 > I don't think you want both @deprecated? I did, but Friedrich had a less confusing suggestion: @deprecated since 5.6. Since 5.71 use ApplicationLauncherJob, otherwise

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

kossebau added inline comments. INLINE COMMENTS > dfaure wrote in kcmoduleinfo.h:131 > It's complicated. > > 1. If you use the QString constructor, you know service() is usable. That's > the case for all users of KCModuleInfo except KCModuleLoader. [Not that there > are many] > > 2. Even

D29511: Label: Add ping-pong logic

ngraham requested changes to this revision. ngraham added a comment. Yeah, This should be a new component, or at most enabled by an off-by-default property. The default behavior should not change. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D29547: KRun: deprecate all static 'run*' methods, with full porting instructions

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29547 To: dfaure, ahmadsamir, broulik, svuorela Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 595 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/595/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 10 May 2020 18:02:48 + Build duration: 12 min and counting BUILD ARTIFACTS

D29597: file extractor: fix linking

eszlari added a comment. Indeed. It failed with cmake 3.15.2 + ninja 1.9.0 and worked with make (4.2.1). REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D29597 To: eszlari, bruns Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack,

D29597: file extractor: fix linking

eszlari abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D29597 To: eszlari, bruns Cc: bruns, kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis updated this revision to Diff 82477. araujoluis marked an inline comment as done. araujoluis added a comment. - kwidgetsaddons: kcolorcombo: rename innerrect to innerRect REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29502?vs=82476=82477

D28760: KSettings::Dialog: avoid duplicate entries due cascading $XDG_DATA_DIRS

svuorela accepted this revision. svuorela added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > dialog.cpp:317 > const QStringList dirs = > QStandardPaths::locateAll(QStandardPaths::DataLocation, > QStringLiteral("ksettingsdialog"),

D28760: KSettings::Dialog: avoid duplicate entries due cascading $XDG_DATA_DIRS

dfaure closed this revision. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28760 To: dfaure, apol, broulik, davidedmundson, kossebau, svuorela Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28760: KSettings::Dialog: avoid duplicate entries due cascading $XDG_DATA_DIRS

dfaure added inline comments. INLINE COMMENTS > svuorela wrote in dialog.cpp:317 > I think I read once that whenever you used a ordered map over an unordered > map, you need to justify it by talking to your manager about it. But that's > also a bit from the bucket of nitpickery unless we are

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis updated this revision to Diff 82478. araujoluis marked an inline comment as done. araujoluis added a comment. - kwidgetsaddons: update comments REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29502?vs=82477=82478 BRANCH

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis updated this revision to Diff 82481. araujoluis marked an inline comment as done. araujoluis added a comment. - kwidgetsaddons: kcolorcombo: fix comments REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29502?vs=82480=82481 BRANCH

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 105 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/105/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 10 May 2020 18:02:48 + Build duration: 8 min 16 sec and counting JUnit Tests Name:

D29547: KRun: deprecate all static 'run*' methods, with full porting instructions

ahmadsamir accepted this revision. ahmadsamir added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > dfaure wrote in krun.h:216 > I did, but Friedrich had a less confusing suggestion: > > @deprecated since 5.6. Since 5.71 use ApplicationLauncherJob, otherwise

D29597: file extractor: fix linking

eszlari added a comment. Strange. It worked with gmake locally, but failed on the Flathub buildbot again (https://flathub.org/builds/#/builders/32/builds/19809, only x86_64 failed, not arm or aarch64). What really fixed it at the end, was switching to an out of source build.

D29357: Display rich text notification messages on Android (API level 24+)

tfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH pending REVISION DETAIL https://phabricator.kde.org/D29357 To: vkrause, tfella Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29610: [CopyJob] Use stricter conditions when using QFile::rename in slotResultRenaming

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY The code now uses QFile::rename() only if direct renaming fails and we're moving a file/dir e.g. 'A' to 'a' on a

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis marked an inline comment as done. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D29502 To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham Cc: broulik, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

cblack added inline comments. INLINE COMMENTS > kcolorcombo.cpp:90 > +innerColor.getHsv(, , ); > +textColor = v > 128 ? Qt::black : Qt::white; > +} I would probably do what Kirigami does for `ColorUtils::brightnessForColor` here: `((0.299 * color.red() + 0.587 *

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis added inline comments. INLINE COMMENTS > cfeck wrote in kcolorcombo.h:61 > The comment still says "struct". Maybe clarify that this list is actually > used as a map. > > (I guess since mapping would happen in both directions, using a QMap isn't > useful?) Using QMap would cause me

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis updated this revision to Diff 82483. araujoluis added a comment. - kwidgetsaddons: kcolorcombo: fix comments REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29502?vs=82482=82483 BRANCH named_color_support REVISION DETAIL

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis marked an inline comment as done. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D29502 To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham Cc: broulik, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis marked 3 inline comments as done. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D29502 To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham Cc: broulik, cfeck, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis updated this revision to Diff 82482. araujoluis marked an inline comment as done. araujoluis added a comment. - kwidgetsaddons: kcolorcombo: rename variable REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29502?vs=82481=82482 BRANCH

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

cblack added inline comments. INLINE COMMENTS > kcolorcombo.h:52 > Q_PROPERTY(QList colors READ colors WRITE setColors) > +Q_PROPERTY(QList> namedColors READ namedColors > WRITE setNamedColors) > Is a simple tuple list really the best way to represent colours? Knowing what most

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis marked 14 inline comments as done. araujoluis added inline comments. INLINE COMMENTS > patrickelectric wrote in kcolorcombo.h:52 > This is just a suggestion and not something that's necessary to do, but maybe > it could help to create a simple class to replace QPair: > > class

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis marked an inline comment as done. araujoluis added inline comments. INLINE COMMENTS > cblack wrote in kcolorcombo.h:52 > Is a simple tuple list really the best way to represent colours? Knowing what > most designers like, a better data structure would encapsulate named groups > of

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis marked 2 inline comments as done. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D29502 To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham Cc: cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis marked an inline comment as done. araujoluis added inline comments. INLINE COMMENTS > patrickelectric wrote in kcolorcombo.cpp:74 > Missing const, also the name should be `innerColor` with a capital C if we > are following the code style from this file. Done! > patrickelectric

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis updated this revision to Diff 82484. araujoluis added a comment. - kwidgetsaddons: kcolorcombo: fix comments REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29502?vs=82483=82484 BRANCH named_color_support REVISION DETAIL

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

araujoluis marked an inline comment as done. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D29502 To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham Cc: cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns