BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20WindowsMSVCQt5.14/40/
Project:
kf5-qt5 WindowsMSVCQt5.14
Date of build:
Sat, 23 May 2020 03:19:51 +
Build duration:
2 min 38 sec and counting
JUnit Tests
broulik marked 3 inline comments as done.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D29051
To: broulik, #frameworks, davidedmundson, kossebau, kfunk, habacker
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy,
michaelh, ngraham,
broulik updated this revision to Diff 83108.
broulik added a comment.
- Use `After` instead of `Wants`
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29035?vs=80723=83108
REVISION DETAIL
https://phabricator.kde.org/D29035
AFFECTED FILES
CMakeLists.txt
poboiko created this revision.
poboiko added reviewers: aacid, mart, broulik.
Herald added a project: Frameworks.
poboiko requested review of this revision.
REVISION SUMMARY
This is alternative approach to D22488: invoke QIcon::setFallbackThemeName a
bit later
alex added a comment.
Thanks and I get why it is hard to review.
Could @broulik please help/have a look at this.
A issue I have with understanding some of the KRunner stuff is that I don't
know where exactly
the runner "backend" is used (from the QML side of things).
Thanks
broulik updated this revision to Diff 83105.
broulik added a comment.
- Clarify docs
REPOSITORY
R240 Extra CMake Modules
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29051?vs=80776=83105
REVISION DETAIL
https://phabricator.kde.org/D29051
AFFECTED FILES
broulik created this revision.
broulik added reviewers: Frameworks, davidedmundson, kossebau.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
Using the new `ECMGenerateDBusServiceFile` of D29051
broulik added a comment.
I'm sorry, I don't really know how this teardown stuff all works :/
REPOSITORY
R308 KRunner
BRANCH
krunner_signal_bugfix (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29050
To: alex, meven, ngraham, broulik
Cc: cfeck,
vkrause updated this revision to Diff 83104.
vkrause added a comment.
Rename visibility hint.
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29358?vs=81734=83104
BRANCH
pending
REVISION DETAIL
https://phabricator.kde.org/D29358
AFFECTED FILES
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kcmutils/job/kf5-qt5%20WindowsMSVCQt5.14/35/
Project:
kf5-qt5 WindowsMSVCQt5.14
Date of build:
Fri, 22 May 2020 10:30:10 +
Build duration:
2 min 12 sec and counting
JUnit Tests
alex added a comment.
> Repo is called milou
Thanks!
REPOSITORY
R308 KRunner
BRANCH
krunner_signal_bugfix (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29050
To: alex, meven, ngraham, broulik
Cc: davidedmundson, cfeck, kde-frameworks-devel, Orage,
kossebau added inline comments.
INLINE COMMENTS
> abstractrunner.h:154
> * is called, the runner should return true
> + * @deprecated Since 5,0, this feature has been defunct
> */
Should be "5.0", not "5,0" here in the API dox text and elsewhere, no? (dot
instead of
nicolasfella accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R289 KNotifications
BRANCH
pending
REVISION DETAIL
https://phabricator.kde.org/D29358
To: vkrause, nicolasfella
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
davidedmundson added a comment.
> the runner "backend" is used (from the QML side of things).
Repo is called milou
REPOSITORY
R308 KRunner
BRANCH
krunner_signal_bugfix (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29050
To: alex, meven, ngraham, broulik
Cc:
broulik marked an inline comment as done.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D29035
To: broulik, #plasma, #frameworks
Cc: davidedmundson, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack,
jraleigh, zachus, fbampaloukas, mkulinski, ragreen,
alex updated this revision to Diff 83110.
alex added a comment.
Change deprecation version from 5.70 to 5.71
REPOSITORY
R308 KRunner
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29281?vs=81546=83110
BRANCH
deprecations (branched from master)
REVISION DETAIL
alex added a comment.
Now I understand where it is called and how it works exactly.
May I ship this?
REPOSITORY
R308 KRunner
BRANCH
krunner_signal_bugfix (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29050
To: alex, meven, ngraham, broulik
Cc: davidedmundson,
alex added a comment.
But can you please explain, where in the QML code the actual KRunner backend
is used?
Maybe then I can understand it better .
REPOSITORY
R308 KRunner
BRANCH
krunner_signal_bugfix (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29050
To:
alex edited the summary of this revision.
REPOSITORY
R308 KRunner
BRANCH
krunner_signal_bugfix (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29050
To: alex, meven, ngraham, broulik
Cc: davidedmundson, cfeck, kde-frameworks-devel, Orage, LeGast00n,
The-Feren-OS-Dev,
alex added a reviewer: meven.
REPOSITORY
R308 KRunner
REVISION DETAIL
https://phabricator.kde.org/D29281
To: alex, #plasma, broulik, davidedmundson, vkrause, meven
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
meven updated this revision to Diff 83112.
meven added a comment.
Update @since, improve doc
REPOSITORY
R245 Solid
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D28590?vs=81061=83112
BRANCH
arcpatch-D28590_1
REVISION DETAIL
https://phabricator.kde.org/D28590
AFFECTED FILES
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
;=) Actually, I just missed this request, sorry.
I think there is no issue with have an extra example.
REPOSITORY
R216 Syntax Highlighting
BRANCH
master
REVISION DETAIL
meven added a comment.
@pino ping
REPOSITORY
R320 KIO Extras
REVISION DETAIL
https://phabricator.kde.org/D29805
To: meven, #frameworks, broulik, ngraham, pino
Cc: pino, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik,
pberestov, iasensio, aprcela, fprice, LeGast00n,
apol added a comment.
hmmm. Ping @mart. :) what do you suggest we do?
REPOSITORY
R296 KDeclarative
REVISION DETAIL
https://phabricator.kde.org/D26524
To: apol, #plasma, #frameworks
Cc: mart, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh,
ngraham, bruns
meven added a subscriber: ervin.
meven added a comment.
@ervin perhaps you might review this as @bruns seems too busy.
REPOSITORY
R245 Solid
REVISION DETAIL
https://phabricator.kde.org/D28590
To: meven, #frameworks, bruns, sitter
Cc: ervin, kde-frameworks-devel, LeGast00n, cblack,
poboiko edited the summary of this revision.
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D29826
To: poboiko, aacid, mart, broulik
Cc: mart, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
apol closed this revision.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
https://phabricator.kde.org/D28235
To: apol, vkrause, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack,
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann
alex updated this revision to Diff 83115.
alex added a comment.
Fix comma, KRUNNER_DEPRECATED_VERSION_BELATED macro
REPOSITORY
R308 KRunner
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29281?vs=83110=83115
BRANCH
deprecations (branched from master)
REVISION DETAIL
alex added inline comments.
INLINE COMMENTS
> kossebau wrote in abstractrunner.h:154
> Should be "5.0", not "5,0" here in the API dox text and elsewhere, no? (dot
> instead of comma)
Yes. I accidentally did it this way, because in German you use a comma :D
> kossebau wrote in
alex marked 9 inline comments as done.
REPOSITORY
R308 KRunner
REVISION DETAIL
https://phabricator.kde.org/D29281
To: alex, #plasma, broulik, davidedmundson, vkrause, meven
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
poboiko added a comment.
My main motivation here is following:
https://gerrit.libreoffice.org/c/core/+/94691.
If it gets accepted, it would fix long-standing issue that people aren't able
to use Libreoffice with KF5 integration plugin together with dark color scheme
(and "breeze-dark"
apol added a comment.
Should I understand this is not desired and that I should abandon it?
I know it's not going to make a big difference to the project but it was hard
for me to adopt it in the first place.
REPOSITORY
R216 Syntax Highlighting
REVISION DETAIL
Hi,
I was looking through some Plasma code and I saw that we have some
fairly old emoticons KCM using KF5Emoticons.
Now while I know why this exists, it feels like it's more of a thing
of the past from when people wrote :) instead of . While keeping it
around for the few apps that might still
meven added inline comments.
INLINE COMMENTS
> querymatch.cpp:338
> {
> -return d->runner && d->runner.data()->hasRunOptions();
> }
Did you really need to remove this code ?
> querymatch.cpp:343
>
> +#if KRUNNER_BUILD_DEPRECATED_SINCE(5, 1)
> void
alex added inline comments.
INLINE COMMENTS
> meven wrote in querymatch.cpp:338
> Did you really need to remove this code ?
The question this method should answer is: Does this match have a configuration
interface?
And the answer is no, because the functionality does not exist anymore.
And if
alex updated this revision to Diff 83119.
alex added a comment.
Fix typo in version number
REPOSITORY
R308 KRunner
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29281?vs=83115=83119
BRANCH
deprecations (branched from master)
REVISION DETAIL
alex marked an inline comment as done.
REPOSITORY
R308 KRunner
REVISION DETAIL
https://phabricator.kde.org/D29281
To: alex, #plasma, broulik, davidedmundson, vkrause, meven
Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/21/
Project:
kf5-qt5 FreeBSDQt5.14
Date of build:
Fri, 22 May 2020 18:10:01 +
Build duration:
58 min and counting
JUnit Tests
Name: projectroot
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/22/
Project:
kf5-qt5 FreeBSDQt5.14
Date of build:
Fri, 22 May 2020 19:08:32 +
Build duration:
1 hr 24 min and counting
JUnit Tests
Name:
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/134/
Project:
kf5-qt5 FreeBSDQt5.14
Date of build:
Fri, 22 May 2020 17:54:08 +
Build duration:
57 min and counting
JUnit Tests
Name: projectroot
mthw added a comment.
@davidedmundson What do you think about this patch?
REPOSITORY
R297 KDED
REVISION DETAIL
https://phabricator.kde.org/D29815
To: mthw, #frameworks, davidedmundson
Cc: anthonyfieroni, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh,
ngraham, bruns
aacid added a comment.
I don't think moving this code from KIconThemes to kmainwindow makes sense,
what about all the apps that use KIconThemes but no KMainWindow?
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D29826
To: poboiko, aacid, mart, broulik
Cc: mart,
aacid added a comment.
Wouldn't it make more sense to fix in Qt?
Something like
diff --git a/src/gui/image/qicon.cpp b/src/gui/image/qicon.cpp
index 41fe649fc5..f86ad3c760 100644
--- a/src/gui/image/qicon.cpp
+++ b/src/gui/image/qicon.cpp
@@ -1260,7 +1260,7 @@
aacid added a comment.
Not sure if you're subscribed to https://phabricator.kde.org/D22488 see my
last comment there i think it's the way to go
REPOSITORY
R263 KXmlGui
REVISION DETAIL
https://phabricator.kde.org/D29826
To: poboiko, aacid, mart, broulik
Cc: mart, kde-frameworks-devel,
aacid added a comment.
https://codereview.qt-project.org/c/qt/qtbase/+/301588
REPOSITORY
R302 KIconThemes
REVISION DETAIL
https://phabricator.kde.org/D22488
To: mart, #frameworks, #plasma
Cc: aacid, mlaurent, broulik, kde-frameworks-devel, LeGast00n, cblack,
michaelh, ngraham, bruns
aacid added a comment.
Now i understand this is causing relatively several issues, sorry for
dropping the ball, so we should probably fix for users before Qt 5.15.1
What about something like
diff --git a/src/kicontheme.cpp b/src/kicontheme.cpp
index 4f5d9d5..62fc9d7 100644
BUILD SUCCESS
Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/135/
Project:
kf5-qt5 FreeBSDQt5.14
Date of build:
Fri, 22 May 2020 20:03:33 +
Build duration:
57 min and counting
JUnit Tests
Name: projectroot
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.14/23/
Project:
kf5-qt5 FreeBSDQt5.14
Date of build:
Fri, 22 May 2020 20:32:51 +
Build duration:
59 min and counting
JUnit Tests
Name: projectroot
48 matches
Mail list logo
