D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

aacid added a comment. It didn't really land on Qt 5.15 yet, so we may need to update the comment to say 5.15.1 or something https://codereview.qt-project.org/c/qt/qtbase/+/302581 But as said i think this is reasonable for now REPOSITORY R263 KXmlGui REVISION DETAIL

D29814: Fix segfault on no restart args

jpalecek updated this revision to Diff 83214. jpalecek added a comment. Polished the style as requested REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29814?vs=83138=83214 BRANCH for-upstream REVISION DETAIL https://phabricator.kde.org/D29814

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

poboiko updated this revision to Diff 83215. poboiko added a comment. Right, 5.15.1. REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29826?vs=83212=83215 BRANCH icon-load (branched from master) REVISION DETAIL https://phabricator.kde.org/D29826

D29809: Don't invoke qstring localized stuff in critical section

jpalecek updated this revision to Diff 83213. jpalecek added a comment. Renamed the socketpath variable to s_socketpath, and make it static as requested REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29809?vs=83136=83213 BRANCH for-upstream REVISION

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R263:899c0f7fa457: [KMainWindow] Invoke QIcon::setFallbackThemeName (later) (authored by poboiko). REPOSITORY R263

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 161 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/161/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Fri, 05 Jun 2020 02:17:45 + Build duration: 10 min and counting JUnit Tests Name: projectroot

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

aacid added a comment. oh i think i'm too late :D INLINE COMMENTS > kmainwindow.cpp:253 > +// TODO: remove this once we depend on Qt 5.15.1, where this is fixed > +#if QT_VERSION >= QT_VERSION_CHECK(5, 12, 0) > +if (QIcon::fallbackThemeName().isEmpty()) { should this be #if

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

aacid added a comment. In D29826#674634 , @aacid wrote: > oh i think i'm too late :D Let's wait for the fix to actually land and then i'll propose that change REPOSITORY R263 KXmlGui REVISION DETAIL

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

poboiko added a comment. In D29826#674634 , @aacid wrote: > oh i think i'm too late :D Whoops, sorry :S Actually, I thought that if this piece of code is executed with Qt >= 5.15.1 (or whenever the proper fix is landed), it

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.14 - Build # 160 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.14/160/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 05 Jun 2020 02:17:45 + Build duration: 7 min 51 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 659 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/659/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 05 Jun 2020 02:17:45 + Build duration: 7 min 51 sec and counting BUILD ARTIFACTS

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

poboiko updated this revision to Diff 83212. poboiko added a comment. Seems like the Qt fix was landed ... another one (https://codereview.qt-project.org/c/qt/qtbase/+/302341), but whatever. So I've removed link to the old one and added note to remove this after we depend on Qt 5.15.