D29810: Don't use the setenv function after fork

2020-06-07 Thread Jiří Paleček
jpalecek added a comment. In D29810#674815 , @dfaure wrote: > This breaks FreeBSD compilation. Please check: https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20FreeBSDQt5.14/17/ I see. It needs the declaration of `environ`,

D29017: WIP: Introduce three new methods that return all "entries" in a folder

2020-06-07 Thread Ahmad Samir
ahmadsamir abandoned this revision. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D29017 To: ahmadsamir, #frameworks, dfaure Cc: blaze, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29017: WIP: Introduce three new methods that return all "entries" in a folder

2020-06-07 Thread Ahmad Samir
ahmadsamir reopened this revision. ahmadsamir marked an inline comment as done. ahmadsamir added a comment. Move to gitlab https://invent.kde.org/frameworks/kwallet/-/merge_requests/2 REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D29017 To: ahmadsamir, #frameworks,

D28745: Skip caching thumbnails on encrypted filesystems

2020-06-07 Thread Stefan Brüns
bruns added a comment. And can you please use arc to upload the patch - it is nearly impossible to do a review with the missing context REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns Cc: thiago,

D28745: Skip caching thumbnails on encrypted filesystems

2020-06-07 Thread Stefan Brüns
bruns requested changes to this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28745 To: marcingu, ivan, broulik, #dolphin, ngraham, meven, bruns Cc: thiago, bruns, meven, ngraham, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov,

D27034: Fix message box when passing a remote url that includes a file

2020-06-07 Thread Martin Tobias Holmedahl Sandsmark
sandsmark added a comment. This is wrong, isn't it? The logic was: if setDirectory is passed something that _isn't_ a directory, try to strip the filename. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D27034 To: apol,

Add loop device interface to Solid framework

2020-06-07 Thread Kwon-Young Choi
Hello, I have recently made a plugin for dolphin to mount and unmount iso files: https://invent.kde.org/sdk/dolphin-plugins/-/merge_requests/1 This plugin uses DBus calls to directly communicate with UDisks2 to attach and detach a loop device backed by an iso file. While writing the plugin, I

KDE CI: Frameworks » ki18n » kf5-qt5 SUSEQt5.12 - Build # 96 - Unstable!

2020-06-07 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ki18n/job/kf5-qt5%20SUSEQt5.12/96/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 07 Jun 2020 19:26:06 + Build duration: 2 min 5 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » ki18n » kf5-qt5 SUSEQt5.14 - Build # 13 - Unstable!

2020-06-07 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ki18n/job/kf5-qt5%20SUSEQt5.14/13/ Project: kf5-qt5 SUSEQt5.14 Date of build: Sun, 07 Jun 2020 19:26:07 + Build duration: 2 min 45 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » ki18n » kf5-qt5 FreeBSDQt5.14 - Build # 12 - Unstable!

2020-06-07 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ki18n/job/kf5-qt5%20FreeBSDQt5.14/12/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 07 Jun 2020 19:26:06 + Build duration: 42 sec and counting JUnit Tests Name: projectroot

D28745: Skip caching thumbnails on encrypted filesystems

2020-06-07 Thread Stefan Brüns
bruns added a comment. In D28745#674711 , @meven wrote: > > Solid does not provide straight `folder => StorageVolume` yet, but I think Solid could have such a utility feature added. > Something like

D29810: Don't use the setenv function after fork

2020-06-07 Thread Ahmad Samir
ahmadsamir added a comment. In D29810#674824 , @jpalecek wrote: > In D29810#674815 , @dfaure wrote: > > > This breaks FreeBSD compilation. Please check:

D29258: Don't use notifybysnore.h on MSYS2

2020-06-07 Thread Piyush Aggarwal
brute4s99 added inline comments. INLINE COMMENTS > CMakeLists.txt:75 > if (WIN32) > -find_package(LibSnoreToast REQUIRED) > -set_package_properties(LibSnoreToast PROPERTIES TYPE REQUIRED please maintain the REQUIRED call for normal Windows builds. You can use the OS specific build

D29525: Make Previews devicePixelRatio aware

2020-06-07 Thread Elvis Angelaccio
elvisangelaccio accepted this revision. REPOSITORY R318 Dolphin BRANCH arcpatch-D29525 REVISION DETAIL https://phabricator.kde.org/D29525 To: meven, #dolphin, #frameworks, dfaure, ngraham, elvisangelaccio Cc: kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice,

D29814: Fix segfault on no restart args

2020-06-07 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R285 KCrash BRANCH for-upstream REVISION DETAIL https://phabricator.kde.org/D29814 To: jpalecek, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29050: KRunner fix prepare/teardown signals

2020-06-07 Thread Kai Uwe Broulik
broulik added a comment. I now have runner queries never "finish". I type "plasmashell", get the results I expect, and the busy indicator keeps spinning forever. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29050 To: alex, meven, ngraham, broulik Cc:

D29814: Fix segfault on no restart args

2020-06-07 Thread David Faure
dfaure closed this revision. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29814 To: jpalecek, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29810: Don't use the setenv function after fork

2020-06-07 Thread David Faure
dfaure closed this revision. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29810 To: jpalecek, #frameworks, dfaure Cc: bruns, apol, anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham

KDE CI: Frameworks » kcrash » kf5-qt5 FreeBSDQt5.14 - Build # 17 - Failure!

2020-06-07 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20FreeBSDQt5.14/17/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 07 Jun 2020 09:24:53 + Build duration: 15 sec and counting CONSOLE OUTPUT [...truncated

D29810: Don't use the setenv function after fork

2020-06-07 Thread David Faure
dfaure added a comment. This breaks FreeBSD compilation. Please check: https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20FreeBSDQt5.14/17/ REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D29810 To: jpalecek, #frameworks, dfaure Cc: bruns, apol,

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 19 - Still Unstable!

2020-06-07 Thread Christoph Cullmann
On 2020-05-25 16:34, Christoph Cullmann wrote: On 2020-05-25 16:29, David Faure wrote: Isn't this fixed by https://codereview.qt-project.org/c/qt/qtdeclarative/+/300911 ? (This fix happened because I reported this ktexteditor CI ASAN failure to Simon Haussman, who fixed qtdeclarative) IIUC

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.14 - Build # 27 - Still Unstable!

2020-06-07 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.14/27/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 07 Jun 2020 13:29:24 + Build duration: 1 min 38 sec and counting JUnit Tests Name:

D28745: Skip caching thumbnails on encrypted filesystems

2020-06-07 Thread Méven Car
meven added a comment. In D28745#674827 , @bruns wrote: > In D28745#674711 , @meven wrote: > > > > > > > > > Solid does not provide straight `folder => StorageVolume` yet, but I think