D28745: Skip caching thumbnails on encrypted filesystems

2020-06-30 Thread Marcin Gurtowski
marcingu added a comment. > How often do I have to repeat the thumbnailer has to use the canonical path anyway? Please use that. `storageAccessFromPath` converts given path into canonical. I figured it should do so anyway, so I'm not doing it again here. REPOSITORY R320 KIO Extras

D17816: Support for xattrs on kio copy/move

2020-06-30 Thread Gleb Popov
arrowd updated this revision to Diff 83319. arrowd marked an inline comment as done. arrowd added a comment. - Remove extraneous debugging output. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=83318=83319 BRANCH arcpatch-D17816 REVISION DETAIL

D17816: Support for xattrs on kio copy/move

2020-06-30 Thread Gleb Popov
arrowd added inline comments. INLINE COMMENTS > bruns wrote in jobtest.cpp:487 > not done ... There are no arrays of `512` size anymore. Or am I missing something? REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 716 - Fixed!

2020-06-30 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/716/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 30 Jun 2020 09:49:16 + Build duration: 5 min 45 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.15 - Build # 30 - Unstable!

2020-06-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.15/30/ Project: kf5-qt5 SUSEQt5.15 Date of build: Tue, 30 Jun 2020 09:49:16 + Build duration: 5 min 57 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 29 - Still Unstable!

2020-06-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/29/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Tue, 30 Jun 2020 09:49:17 + Build duration: 4 min 18 sec and counting JUnit Tests Name:

D28856: Save disabling of desktop file components in kglobalshortcutsrc

2020-06-30 Thread Méven Car
meven added a comment. ping Would be important to land with https://invent.kde.org/frameworks/kglobalaccel/-/merge_requests/2 REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D28856 To: davidre, davidedmundson, fvogt, meven Cc: kde-frameworks-devel,

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 306 - Fixed!

2020-06-30 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/306/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Tue, 30 Jun 2020 09:49:16 + Build duration: 2 min 55 sec and counting

D28745: Skip caching thumbnails on encrypted filesystems

2020-06-30 Thread Stefan Brüns
bruns added a comment. In D28745#675698 , @marcingu wrote: > > How often do I have to repeat the thumbnailer has to use the canonical path anyway? Please use that. > > `storageAccessFromPath` converts given path into canonical. I figured it

D27197: Add symbolic screenshot icons

2020-06-30 Thread Mathis Brüchert
mbruchert updated this revision to Diff 83320. mbruchert added a comment. Fix colors REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27197?vs=75125=83320 BRANCH sreenshot REVISION DETAIL https://phabricator.kde.org/D27197 AFFECTED FILES

Syndication: Relicense notice

2020-06-30 Thread Christophe Giboudeaux
Hi, While porting the syndication files to use the SPDX license format, some files added by Frerich Raabe which originally lived in 'librss' (> 15 years ago) were marked as problematic. dataretriever.{cpp,h} and loader.{cpp,h} only have a partial license header pointing to a COPYING file

Re: Deprecate KRandomSequence ?

2020-06-30 Thread Albert Astals Cid
El dimarts, 30 de juny de 2020, a les 1:21:48 CEST, Aleix Pol va escriure: > On Mon, Jun 29, 2020 at 10:27 PM Albert Astals Cid wrote: > > > > QRandomGenerator is very similar in which you can give it a seed and get > > randomness out of it. > > > > Things that QRandomGenerator doesn't have: > >

Re: Deprecate KRandomSequence ?

2020-06-30 Thread Albert Astals Cid
El dimarts, 30 de juny de 2020, a les 22:17:56 CEST, Johan Ouwerkerk va escriure: > On Tue, Jun 30, 2020 at 7:32 PM Albert Astals Cid wrote: > > > > > > > > If an application was relying on the random application sequence, it > > > probably has bigger problems. > > > > Why? It's exactly what

Re: Deprecate KRandomSequence ?

2020-06-30 Thread Johan Ouwerkerk
On Tue, Jun 30, 2020 at 7:32 PM Albert Astals Cid wrote: > > > > > If an application was relying on the random application sequence, it > > probably has bigger problems. > > Why? It's exactly what KRandomSequence (and QRandomGenerator) promise to do. > > And at least on KPat this is really

D27197: Add symbolic screenshot icons

2020-06-30 Thread Nathaniel Graham
ngraham added a comment. Thanks, that's better now. However the camera silhouette still doesn't match that of other monochrome camera images we have. I'd like to stick to standard iconography if possible. Do you think we should switch the other related icons to use your new camera icon, or

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.15 - Build # 31 - Fixed!

2020-06-30 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.15/31/ Project: kf5-qt5 SUSEQt5.15 Date of build: Wed, 01 Jul 2020 03:57:23 + Build duration: 8 min 9 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 717 - Unstable!

2020-06-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/717/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 01 Jul 2020 03:57:24 + Build duration: 6 min 11 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 30 - Still Unstable!

2020-06-30 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/30/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Wed, 01 Jul 2020 03:57:23 + Build duration: 4 min 26 sec and counting JUnit Tests Name: