D28745: Skip caching thumbnails on encrypted filesystems

2020-10-18 Thread Marcin Gurtowski
marcingu added a comment. I think I have the Solid part done, but as I don't know this code well, I'd be grateful if someone more advanced on the subject checked it. https://invent.kde.org/frameworks/solid/-/merge_requests/19 Unfortunately, I wasn't able to test it on LUKS device,

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 246 - Unstable!

2020-10-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/246/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Sun, 18 Oct 2020 20:24:00 + Build duration: 10 min and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 245 - Fixed!

2020-10-18 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/245/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Sun, 18 Oct 2020 18:46:27 + Build duration: 5 min 7 sec and counting JUnit Tests Name:

D22764: Stabilize test KFileWidgetTest::testDropFile

2020-10-18 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > kfilewidgettest.cpp:481 > +KDirLister *dirLister = fileWidget.dirOperator()->dirLister(); > +QSignalSpy spy(dirLister, SIGNAL(completed(const QUrl &_url))); > + For the record, this is broken, it should have been `completed(QUrl)`.

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 247 - Fixed!

2020-10-18 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/247/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Sun, 18 Oct 2020 21:49:21 + Build duration: 5 min 7 sec and counting JUnit Tests Name:

Re: Windows CI Updated to Qt 5.15 - Temporarily KO due to Breeze Icons Breakage

2020-10-18 Thread David Faure
On mardi 6 octobre 2020 11:59:34 CEST Ben Cooksley wrote: > Hi all, > > This evening i've completed updates to the Windows CI system, bringing it > from the previous Qt 5.14 setup it was using up to the more recent Qt 5.15. > As part of this various other libraries will have also been updated. >

D23694: Add support for sshfs to the fstab backend

2020-10-18 Thread Elvis Angelaccio
elvisangelaccio added a comment. In D23694#676610 , @lbeltrame wrote: > @elvisangelaccio Thanks, first of all. If that's the case, do you think it's better to touch KIO first before landing this? Yeah this should probably wait for the

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.15 - Build # 244 - Unstable!

2020-10-18 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.15/244/ Project: kf5-qt5 FreeBSDQt5.15 Date of build: Sun, 18 Oct 2020 18:34:35 + Build duration: 11 min and counting JUnit Tests Name: projectroot

T8349: Improve Places panel usability and presentation

2020-10-18 Thread Nathaniel Graham
ngraham updated the task description. TASK DETAIL https://phabricator.kde.org/T8349 To: ngraham Cc: #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, jtamate, rkflx, #dolphin, ngraham, fabiogomes, waitquietly, azyx, dmenig, nikolaik, pberestov, manueljlin, iasensio, Orage,

T8349: Improve Places panel usability and presentation

2020-10-18 Thread Ahmad Samir
ahmadsamir added subscribers: sitter, ahmadsamir. ahmadsamir added a comment. ATM, the behaviour is that if you go to /foo/bar/baz/ and "bar" is present in the places panel, then while you're at baz or any of its sub-folders then "bar" is highlighted in the places panel, i.e the "closest"

T8349: Improve Places panel usability and presentation

2020-10-18 Thread Nathaniel Graham
ngraham added a comment. Yeah, that's weird. Let's throw it on the pile. TASK DETAIL https://phabricator.kde.org/T8349 To: ngraham Cc: ahmadsamir, sitter, #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, jtamate, rkflx, #dolphin, ngraham, fabiogomes, waitquietly, azyx,

T8349: Improve Places panel usability and presentation

2020-10-18 Thread Nathaniel Graham
ngraham updated the task description. TASK DETAIL https://phabricator.kde.org/T8349 To: ngraham Cc: ahmadsamir, sitter, #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, jtamate, rkflx, #dolphin, ngraham, fabiogomes, waitquietly, azyx, dmenig, nikolaik, pberestov,

D17816: Support for xattrs on kio copy/move

2020-10-18 Thread Nathaniel Graham
ngraham added a comment. @bruns? REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham,