D16049: Added missing Icons to Places Panel code from KIO

alexde created this revision. alexde added reviewers: VDG, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alexde requested review of this revision. REVISION SUMMARY The items "Hide", "Hide Entry" and "Show All Entries" of the places panel did not

D16049: Added missing Icons to Places Panel code from KIO

alexde abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16049 To: alexde, #vdg, ngraham, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16091: Added missing Icons to Places Panel code from KIO

alexde created this revision. alexde added a reviewer: ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alexde requested review of this revision. REVISION SUMMARY The items "Hide", "Hide Entry" and "Show All Entries" of the places panel did not have

D16049: Added missing Icons to Places Panel code from KIO

alexde added a comment. > Also, you might want to set up arc, which makes it much simpler and faster to submit patches, and easier for me too. I tried it again, but I forgot to add the "Differential Revision" and did not expect //arc diff// to automatically upload the diff. That is why

D23464: Add breeze icons for ROOT cern files

alexde added a reviewer: ngraham. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis, ngraham Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

alexde added a comment. In D23464#522270 , @trickyricky26 wrote: > As @noahdvs mentioned above, the white background should be removed and the entire symbol should be made up of one filled path with no outline (!). This is important to keep

D23464: Add breeze icons for ROOT cern files

alexde updated this revision to Diff 65307. alexde added a comment. 16px: add 2px margins to top and bottom 22px: add 3px margins to top and bottom 32px: use existing and approved 32px icon as template instead of shrinking the 64px version REPOSITORY R266 Breeze Icons CHANGES SINCE

D23464: Add breeze icons for ROOT cern files

alexde edited the test plan for this revision. REPOSITORY R266 Breeze Icons BRANCH ROOT (branched from master) REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis, ngraham Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

alexde added a comment. In D23464#524994 , @ndavis wrote: > Looks like you've got everything Thank you all for mentoring me! :) REPOSITORY R266 Breeze Icons BRANCH ROOT (branched from master) REVISION DETAIL

D23464: Add breeze icons for ROOT cern files

alexde updated this revision to Diff 64946. alexde added a comment. Add new 32px icons. The root is now less faint and uses the original color. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23464?vs=64944=64946 BRANCH ROOT (branched from

D23464: Add breeze icons for ROOT cern files

alexde updated this revision to Diff 64935. alexde added a comment. Improve the root logo layout and change the root's color to the offical color 1ED4E5 REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23464?vs=64668=64935 BRANCH ROOT (branched from

D23464: Add breeze icons for ROOT cern files

alexde updated this revision to Diff 64944. alexde added a comment. Also add the new 64px breeze icon. Add new 22 px icons. Transparent background, less faint, original color. REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23464?vs=64935=64944

D23464: Add breeze icons for ROOT cern files

alexde edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

alexde edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

alexde added a comment. In D23464#521662 , @ndavis wrote: > I think we should use `#1ed4e5` for the color instead since that's what the official logo uses. Normally, I'd say to use a similar Breeze-like color, but mimetype icons are a mess

D23464: Add breeze icons for ROOT cern files

alexde edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

alexde edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

alexde added a comment. > The 16 and 22 px versions aren't supposed to have backgrounds and the root symbols are pretty faint. Rethinking it, I think it's wrong. The white background belongs to the logo and should not be removed as the white circle and the root symbol belong together,

D23450: Icons for ROOT cern files.

alexde created this revision. alexde added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alexde requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH root-cern-icons (branched from master) REVISION DETAIL

D23450: Icons for ROOT cern files.

alexde edited the summary of this revision. alexde edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23450 To: alexde, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23450: Icons for ROOT cern files.

alexde added a comment. For some reason if I try to set the icons for ".root" files, they are shown in the dialog box, the icon can be set, but they are not shown in Dolphin. Has anyone an idea what I am doing wrong? Those files I have submitted are compressed. I attach the uncompressed

D23450: Icons for ROOT cern files.

alexde added reviewers: ngraham, ndavis. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23450 To: alexde, #vdg, ngraham, ndavis Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23465: Add new non standard mime type for ROOT cern files

alexde added a comment. In D23465#519586 , @yurchor wrote: > Yes. The maintainers of shared-mime-info will tell you if the type is right (I think, that it would be better to use , similar to PDF, but I might be wrong). Alright, I have

D23450: Icons for ROOT cern files.

alexde abandoned this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23450 To: alexde, #vdg, ngraham, ndavis Cc: yurchor, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

alexde created this revision. alexde added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alexde requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH ROOT (branched from master) REVISION DETAIL

D23465: Add new non standard mime type for ROOT cern files

alexde created this revision. alexde added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alexde requested review of this revision. REPOSITORY R244 KCoreAddons BRANCH ROOT (branched from master) REVISION DETAIL

D23465: Add new non standard mime type for ROOT cern files

alexde added a comment. Here's a testfile for the defined mime type: F7282186: testfile.root REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23465 To: alexde, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D23464: Add breeze icons for ROOT cern files

alexde edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

alexde edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23450: Icons for ROOT cern files.

alexde added a comment. Sorry, for some reason it was easier for me to abandon this revision and to reopen another one here: https://phabricator.kde.org/D23464 > Personally, I like these icons Thanks :) > they can be easily used on the system (shared-mime-info) or KDE level

D23465: Add new non standard mime type for ROOT cern files

alexde added a subscriber: yurchor. alexde added a comment. In D23465#519544 , @ltoscano wrote: > The idea is good, but it should be proposed to shared-mime-info repository instead. As far as I remember from the previous discussions, this file

D23464: Add breeze icons for ROOT cern files

alexde edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis, ngraham Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23464: Add breeze icons for ROOT cern files

alexde updated this revision to Diff 65264. alexde edited the test plan for this revision. alexde added a comment. Remove all circles and only use root symbol. This makes the root symbol less faint and the icons fit better to Breeze overall. REPOSITORY R266 Breeze Icons CHANGES SINCE

D23848: Add Breeze icons for Jupyter Notebook files

alexde created this revision. alexde added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alexde requested review of this revision. REVISION SUMMARY This patch adds icons for Jupyter Notebook files. It uses the offical SVG logo. As far I

D23848: Add Breeze icons for Jupyter Notebook files

alexde edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23848 To: alexde, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27544: Fix update scenarios with no explicit downloadlink selected

alexde added a comment. In D27544#622272 , @ngraham wrote: > (...) there has to be a way to (...) label everything properly etc. In D27544#622501 , @leinir wrote: > We are at least two

D23465: Add new non standard mime type for ROOT cern files

alexde abandoned this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23465 To: alexde, #vdg Cc: yurchor, ltoscano, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

alexde added a comment. Does this patch also fix indirectly #274629? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg Cc: alexde, ndavis, iasensio, davidre, kde-frameworks-devel, LeGast00n,

D23848: Add Breeze icons for Jupyter Notebook files

alexde abandoned this revision. alexde added a comment. I unfortunately no longer have time for this. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23848 To: alexde, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26600: Refactor fstab handling

alexde retitled this revision from "Refator fstab handling" to "Refactor fstab handling". REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D26600 To: hallas, #frameworks, bruns, meven Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns