Kross in Porting Aids

2014-05-29 Thread Andreas Cord-Landwehr
Hi, I just noticed that Kross is marked as porting aid in KF5. Since I am pondering to use Kross for a Qt5/KF5 app, I wonder if that would be a future-proof decision. Is there a technical reason (like a successor or a competing framework) why it got to the porting aids? Or is it simply the

Review Request 120514: Add snippet extractor comments.

2014-10-06 Thread Andreas Cord-Landwehr
--- For using the example in the KF5 cookbook, we need some snippet extractor comments as well as lines of a decent length. Diffs - examples/KIdleTest.cpp 6d1d1d8 Diff: https://git.reviewboard.kde.org/r/120514/diff/ Testing --- Thanks, Andreas Cord-Landwehr

Re: Review Request 120514: Add snippet extractor comments.

2014-10-10 Thread Andreas Cord-Landwehr
://git.reviewboard.kde.org/r/120514/diff/ Testing --- Thanks, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121289: Fix Documentation for KPluginLoader::instantiatePlugins(...)

2014-11-29 Thread Andreas Cord-Landwehr
--- Return type is QList and not QVector for this method. Diffs - src/lib/plugin/kpluginloader.h 855786b Diff: https://git.reviewboard.kde.org/r/121289/diff/ Testing --- Thanks, Andreas Cord-Landwehr ___ Kde-frameworks-devel

Re: Review Request 121289: Fix Documentation for KPluginLoader::instantiatePlugins(...)

2014-11-29 Thread Andreas Cord-Landwehr
, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121712: Add install target for the KF5 Book

2014-12-28 Thread Andreas Cord-Landwehr
--- Install the book to /usr/share/doc/frameworks5 Diffs - CMakeLists.txt 4e10120 Diff: https://git.reviewboard.kde.org/r/121712/diff/ Testing --- manual testing Thanks, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list

Re: Review Request 121712: Add install target for the KF5 Book

2015-01-08 Thread Andreas Cord-Landwehr
of the book on our CI system, as well as providing up-to-date builds of the book. Diffs - CMakeLists.txt 4e10120 Diff: https://git.reviewboard.kde.org/r/121712/diff/ Testing --- manual testing Thanks, Andreas Cord-Landwehr ___ Kde

Re: Review Request 125936: Update KProtocolManager after configuration change.

2015-11-10 Thread Andreas Cord-Landwehr
- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125936/#review88081 --- On Nov. 4, 2015, 6:28 vorm., Andreas Cord-Landwehr wrote: > > --- > This is an automatically generated e-mail. To reply

Review Request 126017: Provide debug output by default.

2015-11-10 Thread Andreas Cord-Landwehr
6623c77ff5 src/ui/itemsviewbasedelegate.cpp e89068939c3c41ce281dbd4b628a218b022a3afb tests/khotnewstuff.cpp 2bfff35b136faf22bb41c92136f5bed96c1c9efe Diff: https://git.reviewboard.kde.org/r/126017/diff/ Testing --- Thanks, Andreas Cord-Landwehr _

Re: kcrash when started from terminal

2015-11-14 Thread Andreas Cord-Landwehr
Hey, so do I understand it right that for all applications we have to check for two things: 1. the application must link against KF5::Crash 2. there must be a call to some (dummy) function in KCrash like "KCrash::setCrashHandler(KCrash::defaultCrashHandler);" to ensure that the linker actually

Re: Review Request 125936: Update KProtocolManager after configuration change.

2015-11-03 Thread Andreas Cord-Landwehr
two different KSharedConfig objects. Now force second KSharedData to sync once settings are saved. Diffs - src/kcms/kio/cache.cpp 8f2f4e8 Diff: https://git.reviewboard.kde.org/r/125936/diff/ Testing --- manual testing Thanks, Andreas

Re: Review Request 125144: Provide enabled property for QIconItem.

2015-09-11 Thread Andreas Cord-Landwehr
marked as submitted. Review request for KDE Frameworks and Marco Martin. Changes --- Submitted with commit 8a992d4e4c48c058066f9aa7faca1384c74b24af by Andreas Cord-Landwehr to branch master. Repository: kdeclarative Description --- Adds the standard boolean property "en

Review Request 125144: Provide enabled property for QIconItem.

2015-09-10 Thread Andreas Cord-Landwehr
ef0083e2c2 Diff: https://git.reviewboard.kde.org/r/125144/diff/ Testing --- manual testing Thanks, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KTabWidget vs QTabWidget

2015-09-24 Thread Andreas Cord-Landwehr
On Wednesday, September 23, 2015 4:12:01 PM CEST Jeremy Whiting wrote: > Yes, the two authors of that code are Michel Ludwig and Andreas > Cord-Landwehr who both are listed in relicensecheck.pl as giving > permission to change to lgpl+ So I think we should be fine to > move/copy that

Re: [kde-promo] Stall Posters

2015-09-20 Thread Andreas Cord-Landwehr
initial mail attached, which explains who the target audience for the poster is On Tuesday, August 11, 2015 10:10:50 PM CEST Andreas Cord-Landwehr wrote: > Hey all, > > I would like to start a small initiative to update/create some stall posters > that can be used at KDE stalls. My ma

Re: Review Request 128114: do not load and debug in the same line

2016-06-07 Thread Andreas Cord-Landwehr
into this issue :) - Andreas Cord-Landwehr On Juni 7, 2016, 8:48 vorm., Harald Sitter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Review Request 128119: Explicitly declare methods as overridden

2016-06-07 Thread Andreas Cord-Landwehr
/ Testing --- Thanks, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128120: Use KRun for open Url.

2016-06-07 Thread Andreas Cord-Landwehr
: knewstuff Description --- Port away from QDesktopServices as David's comment says. Diffs - src/core/installation.cpp 69a9ac50d275712a1ded0dd3ef45bfaa273431c0 Diff: https://git.reviewboard.kde.org/r/128120/diff/ Testing --- manual testing Thanks, Andreas Cord-Landwehr

Re: Review Request 126017: Provide debug output by default.

2016-06-06 Thread Andreas Cord-Landwehr
marked as submitted. Review request for KDE Frameworks and Jeremy Whiting. Changes --- Submitted with commit c15b1404887020da65b4ba478bface6f827d58e1 by Andreas Cord-Landwehr to branch master. Repository: knewstuff Description --- The debug output is provided as categorized debug

Re: Review Request 128121: Use scoped pointer for complicated delete logic

2016-06-07 Thread Andreas Cord-Landwehr
marked as submitted. Review request for KDE Frameworks and Jeremy Whiting. Changes --- Submitted with commit d56207480607e80927c24ef84bc746cfd4dafd69 by Andreas Cord-Landwehr to branch master. Repository: knewstuff Description --- Use scoped pointer for complicated delete logic

Re: Review Request 128119: Explicitly declare methods as overridden

2016-06-07 Thread Andreas Cord-Landwehr
marked as submitted. Review request for KDE Frameworks and Jeremy Whiting. Changes --- Submitted with commit 2ba435376571f1c85457353260b7bc2fcf4f5b9c by Andreas Cord-Landwehr to branch master. Repository: knewstuff Description --- Also remove virtual, since this is inheritated

Review Request 128121: Use scoped pointer for complicated delete logic

2016-06-07 Thread Andreas Cord-Landwehr
: knewstuff Description --- Use scoped pointer for complicated delete logic Diffs - src/core/installation.cpp 69a9ac50d275712a1ded0dd3ef45bfaa273431c0 Diff: https://git.reviewboard.kde.org/r/128121/diff/ Testing --- manual testing Thanks, Andreas Cord-Landwehr

Review Request 128185: Ensure extraction location to be in subfolder

2016-06-14 Thread Andreas Cord-Landwehr
4b7ecff66c9db54239bb2f82cdf0b96e901880ca autotests/karchivetest.cpp c8abddfc370a283c56766e5a437f3ba69c575563 src/karchive.cpp 5a7cfc6c92d74c77157dd3fd829eb9b98a90936e Diff: https://git.reviewboard.kde.org/r/128185/diff/ Testing --- See added unit test Thanks, Andreas Cord-Landwehr

Re: Review Request 128185: Ensure extraction location to be in subfolder

2016-06-14 Thread Andreas Cord-Landwehr
Attachments test file to be located in autotests/tar_relative_path_outside_archive.tar.bz2 https://git.reviewboard.kde.org/media/uploaded/files/2016/06/14/3a2388ab-b6a6-4c40-a7c0-083d05be2344__tar_relative_path_outside_archive.tar.bz2 Thanks, Andreas Cord-Landwehr

Re: Review Request 128185: Ensure extraction location to be in subfolder

2016-06-14 Thread Andreas Cord-Landwehr
marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 0cb243f64eef45565741b27364cece7d5c349c37 by Andreas Cord-Landwehr to branch master. Repository: karchive Description --- Behavior change: Switch to Tar's default behavior

Re: Review Request 128185: Ensure extraction location to be in subfolder

2016-06-14 Thread Andreas Cord-Landwehr
, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128196: Add Android to supported platforms

2016-06-15 Thread Andreas Cord-Landwehr
: kapidox Description --- The individual frameworks will pick that platform up once the platform is specified in their metainfo files. Diffs - metainfo.yaml 16811ca Diff: https://git.reviewboard.kde.org/r/128196/diff/ Testing --- Thanks, Andreas Cord-Landwehr

Re: Replacing the "- name: All" platform wildcard

2016-06-15 Thread Andreas Cord-Landwehr
On Wednesday, June 15, 2016 11:01:14 AM CEST Martin Graesslin wrote: > On Wednesday, June 15, 2016 10:16:19 AM CEST Andreas Cord-Landwehr wrote: > > Hey all, > > > > in preparation for getting information about Android as supported platform > > on api.kde.org, I woul

Re: Replacing the "- name: All" platform wildcard

2016-06-15 Thread Andreas Cord-Landwehr
On Wednesday, June 15, 2016 11:45:18 AM CEST Martin Graesslin wrote: > On Wednesday, June 15, 2016 11:18:40 AM CEST Andreas Cord-Landwehr wrote: > > On Wednesday, June 15, 2016 11:01:14 AM CEST Martin Graesslin wrote: > > > On Wednesday, June 15, 2016 10:16:19 AM CEST Andreas Co

Replacing the "- name: All" platform wildcard

2016-06-15 Thread Andreas Cord-Landwehr
Hey all, in preparation for getting information about Android as supported platform on api.kde.org, I would like to purge the "- name: All" platform wildcard from all metainfo.yaml files and replace it by: - name: Linux - name: Windows - name: MacOSX I did this change by running

Re: Review Request 126017: Provide debug output by default.

2016-05-27 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126017/#review95918 --- ping - Andreas Cord-Landwehr On Nov. 10, 2015, 8:57 nachm

Re: KF5 repositories in Phabricator/Diffusion

2016-06-16 Thread Andreas Cord-Landwehr
On Thursday, June 16, 2016 7:58:15 PM CEST Ben Cooksley wrote: [...] > Until recently it would have also been slightly difficult to setup > repositories as Phabricator's Conduit API lacked proper support for > setting up repositories (something which was recently added). Hey Ben, only to make

Adding Android Platform Availability to Frameworks

2016-06-16 Thread Andreas Cord-Landwehr
Hi, after the recent preparations, finally I would like to get permission to add the line " - name: Android" to the platforms section in the metainfo.yaml files of the following frameworks: attica kapidox karchive kcodecs kconfig kcoreaddons kguiaddons ki18n kimageformats kitemmodels kitemviews

Re: Review Request 128210: Enable Threadweaver to build on Android

2016-06-17 Thread Andreas Cord-Landwehr
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit fefcb009de4387f9a536388d6095c3b9f5647e5d by Andreas Cord-Landwehr to branch master. Repository: threadweaver Description --- Make Threadweaver available on Android Diffs - examples

Review Request 128234: Name provided platforms

2016-06-18 Thread Andreas Cord-Landwehr
--- Specify provided platforms Diffs - metainfo.yaml cbc2c3bf2540d1a16ce5bb9b6325614029cbaa82 Diff: https://git.reviewboard.kde.org/r/128234/diff/ Testing --- Thanks, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 128120: Use KRun for open Url.

2016-06-18 Thread Andreas Cord-Landwehr
://git.reviewboard.kde.org/r/128120/diff/ Testing --- manual testing Thanks, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128235: Specify supported platforms

2016-06-18 Thread Andreas Cord-Landwehr
://git.reviewboard.kde.org/r/128235/diff/ Testing --- Thanks, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Adding Android Platform Availability to Frameworks

2016-06-16 Thread Andreas Cord-Landwehr
On Thursday, June 16, 2016 4:12:14 PM CEST Aleix Pol wrote: > On Thu, Jun 16, 2016 at 3:47 PM, Andreas Cord-Landwehr > > <cordlandw...@kde.org> wrote: > > Hi, after the recent preparations, finally I would like to get permission > > to add the line " - name: A

Review Request 128210: Enable Threadweaver to build on Android

2016-06-16 Thread Andreas Cord-Landwehr
, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128235: Specify supported platforms

2016-06-23 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128235/#review96823 --- ping... - Andreas Cord-Landwehr On Juni 18, 2016, 7:37

Re: Review Request 128234: Name provided platforms

2016-06-23 Thread Andreas Cord-Landwehr
: https://git.reviewboard.kde.org/r/128234/diff/ Testing --- Thanks, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128249: Add switch to disable KParts' handling of window titles

2016-06-23 Thread Andreas Cord-Landwehr
stay in the createGUI method, though. Diffs (updated) - src/mainwindow.h 61a92e3 src/mainwindow.cpp be0b7dd Diff: https://git.reviewboard.kde.org/r/128249/diff/ Testing --- Thanks, Andreas Cord-Landwehr ___ Kde-frameworks-devel

Re: Review Request 128249: Add switch to disable KParts' handling of window titles

2016-06-24 Thread Andreas Cord-Landwehr
. Sending such an event should stay in the createGUI method, though. Diffs (updated) - src/mainwindow.h 61a92e3 src/mainwindow.cpp be0b7dd src/part.h 29791d5 Diff: https://git.reviewboard.kde.org/r/128249/diff/ Testing --- Thanks, Andreas Cord-Landwehr

Re: Review Request 128249: Add switch to disable KParts' handling of window titles

2016-06-24 Thread Andreas Cord-Landwehr
marked as submitted. Review request for KDE Frameworks, David Faure and Kevin Funk. Changes --- Submitted with commit 9df94c71504b23781b0d327269ca95cbd4069aa0 by Andreas Cord-Landwehr to branch master. Repository: kparts Description --- Applications that use several KParts, like

Re: Review Request 128234: Name provided platforms

2016-06-24 Thread Andreas Cord-Landwehr
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 5146e2d0918abd22f3444b00cc88ab63b33e1067 by Andreas Cord-Landwehr to branch master. Repository: kded Description --- Specify provided platforms. This is only a guess, though. Currently

Re: Review Request 128235: Specify supported platforms

2016-06-24 Thread Andreas Cord-Landwehr
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit d42402a0b5581707d019bb9db0b074b1775083a1 by Andreas Cord-Landwehr to branch master. Repository: kcmutils Description --- Linux as only supported platform is a guess, coming from the fact

Re: Review Request 128196: Add Android to supported platforms

2016-06-16 Thread Andreas Cord-Landwehr
marked as submitted. Review request for KDE Frameworks and Olivier Churlaud. Changes --- Submitted with commit f72884d9f031e2239004e6df0ba2569b33b86b14 by Andreas Cord-Landwehr to branch master. Repository: kapidox Description --- The individual frameworks will pick that platform

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

2016-02-12 Thread Andreas Cord-Landwehr
t.reviewboard.kde.org/r/127048/#review92280 ------- On Feb. 11, 2016, 7:11 nachm., Andreas Cord-Landwehr wrote: > > --- > This is an automatically generated e-mail. To repl

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

2016-02-12 Thread Andreas Cord-Landwehr
compilation on Android and Linux. Thanks, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

2016-02-12 Thread Andreas Cord-Landwehr
ed e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127048/#review92301 --- On Feb. 12, 2016, 3:47 nachm., Andreas Cord-Landwehr wrote: > > --- > This is an automatically

Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

2016-02-11 Thread Andreas Cord-Landwehr
gettext implementation. Diffs - src/kcatalog.cpp 095a6beec721729537a89214a1fbdb661fbfb548 Diff: https://git.reviewboard.kde.org/r/127048/diff/ Testing --- Tested compilation on Android and Linux. Thanks, Andreas Cord-Landwehr ___ Kde

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

2016-02-13 Thread Andreas Cord-Landwehr
and Linux. Thanks, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126934: Reduce use of gettext API.

2016-02-01 Thread Andreas Cord-Landwehr
/126934/diff/ Testing --- Unit tests still pass. Thanks, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126934: Reduce use of gettext API.

2016-01-31 Thread Andreas Cord-Landwehr
. Thanks, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126934: Reduce use of gettext API.

2016-02-02 Thread Andreas Cord-Landwehr
marked as submitted. Review request for KDE Frameworks, Aleix Pol Gonzalez and Chusslove Illich. Changes --- Submitted with commit c375e0d4e84837707bd9b12b5209b638dc777ca2 by Andreas Cord-Landwehr to branch master. Repository: ki18n Description --- This change removes usage

Review Request 127205: Add stubs to allow compilation on Android.

2016-02-28 Thread Andreas Cord-Landwehr
, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127048: Restrict _nl_msg_cat_cntr use to GNU gettext implentations.

2016-02-14 Thread Andreas Cord-Landwehr
marked as submitted. Review request for KDE Frameworks, Aleix Pol Gonzalez and Chusslove Illich. Changes --- Submitted with commit cdfad77bc9fc21aee1b0d4ca3ea3589552ed03c8 by Andreas Cord-Landwehr to branch master. Repository: ki18n Description --- On Android, we do not have

Proposal for moving KColorScheme from KConfigWidgets to KGuiAddons

2016-02-20 Thread Andreas Cord-Landwehr
Hi, I want to propose to move the KColorScheme class from the KConfigWidgets famework to the KGuiAddons framework. Reasons: * that would reduce dependencies of KIconThemes and make it - a Tier 2 framework (currently Tier 3) and - make it easier to use KIconThemes on Android * KGuiAddons

Re: Proposal for moving KColorScheme from KConfigWidgets to KGuiAddons

2016-02-20 Thread Andreas Cord-Landwehr
ET David Faure wrote: > On Saturday 20 February 2016 11:22:48 Andreas Cord-Landwehr wrote: > > Hi, I want to propose to move the KColorScheme class from the > > KConfigWidgets famework to the KGuiAddons framework. > > Impossible, this would require adding a dependency

Re: Review Request 127205: Add stubs to allow compilation on Android.

2016-02-29 Thread Andreas Cord-Landwehr
ed e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127205/#review92959 --- On Feb. 28, 2016, 10:14 vorm., Andreas Cord-Landwehr wrote: > > --- > This is an automatic

Re: Review Request 127205: Add stubs to allow compilation on Android.

2016-03-01 Thread Andreas Cord-Landwehr
://git.reviewboard.kde.org/r/127205/diff/ Testing --- Compilation tested on Linux and Android. Thanks, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127205: Add stubs to allow compilation on Android.

2016-03-15 Thread Andreas Cord-Landwehr
marked as submitted. Review request for KDE Frameworks, Aleix Pol Gonzalez and Alex Richardson. Changes --- Submitted with commit 3bcdff64ccaf545ea9ff05495a2069bc053ae672 by Andreas Cord-Landwehr to branch master. Repository: kcoreaddons Description --- Android's libc

Re: Review Request 127205: Add stubs to allow compilation on Android.

2016-03-02 Thread Andreas Cord-Landwehr
Diff: https://git.reviewboard.kde.org/r/127205/diff/ Testing --- Compilation tested on Linux and Android. Thanks, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 127265: Fix windows build of Ki18n

2016-03-03 Thread Andreas Cord-Landwehr
rg/r/127265/ > ----------- > > (Updated März 3, 2016, 5:49 nachm.) > > > Review request for KDE Frameworks, Andreas Cord-Landwehr and Kåre Särs. > > > Repository: ki18n > > > Description > --- > >

Re: Review Request 127205: Add stubs to allow compilation on Android.

2016-03-08 Thread Andreas Cord-Landwehr
. Thanks, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127560: Remove U(...) macro.

2016-04-03 Thread Andreas Cord-Landwehr
where out of KF5. Removing this macro also fixes my build of Kalzium, where the macro crashes with Eigen headers. Thanks, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-

Re: Review Request 127560: Remove U(...) macro.

2016-04-03 Thread Andreas Cord-Landwehr
l. To reply, visit: https://git.reviewboard.kde.org/r/127560/#review94214 --- On April 3, 2016, 9:06 vorm., Andreas Cord-Landwehr wrote: > > --- > This is an automatically generate

Review Request 127514: Skip category test if no restriction is set.

2016-03-28 Thread Andreas Cord-Landwehr
://git.reviewboard.kde.org/r/127514/diff/ Testing --- Manual testing in Parley. Thanks, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127560: Remove U(...) macro.

2016-04-04 Thread Andreas Cord-Landwehr
marked as submitted. Review request for KDE Frameworks and John Layt. Changes --- Submitted with commit 3a5db6d8301dd323137fd4fa2c06332b08b833f1 by Andreas Cord-Landwehr to branch master. Repository: kunitconversion Description --- This unprefixed macro in a public header causes

Re: Review Request 127514: Skip category test if no restriction is set.

2016-04-04 Thread Andreas Cord-Landwehr
marked as submitted. Review request for KDE Frameworks and Alex Richardson. Changes --- Submitted with commit ac16eeacb5a0fb8d5e1357bef3a810d5c4e22f40 by Andreas Cord-Landwehr to branch master. Repository: kcmutils Description --- Align the method's logic with the API documentation

Review Request 127900: Fix redirection of absolut Urls

2016-05-12 Thread Andreas Cord-Landwehr
. This patch adds a case distinction for redirecting absolut and relative paths. BUG: 354748 Diffs - src/atticabasejob.cpp f73cb432212be63cff2ae1118c602cc3bae6d615 Diff: https://git.reviewboard.kde.org/r/127900/diff/ Testing --- Thanks, Andreas Cord-Landwehr

Re: Review Request 127900: Fix redirection of absolut Urls

2016-05-12 Thread Andreas Cord-Landwehr
) --- Manual testing with GHNS for documentation in KDevelop. Thanks, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127900: Fix redirection of absolut Urls

2016-05-13 Thread Andreas Cord-Landwehr
for documentation in KDevelop. Thanks, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127900: Fix redirection of absolut Urls

2016-05-13 Thread Andreas Cord-Landwehr
/127900/diff/ Testing --- Manual testing with GHNS for documentation in KDevelop. Thanks, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127900: Fix redirection of absolut Urls

2016-05-14 Thread Andreas Cord-Landwehr
marked as submitted. Review request for KDE Frameworks, Cornelius Schumacher and Kevin Funk. Changes --- Submitted with commit d6118e0d79fc5b1abda3e2d1e506bb7bde160747 by Andreas Cord-Landwehr to branch master. Bugs: 354748 http://bugs.kde.org/show_bug.cgi?id=354748 Repository

Review Request 128420: Name supported platforms in YAML file.

2016-07-10 Thread Andreas Cord-Landwehr
--- Thanks, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128420: Name supported platforms in YAML file.

2016-07-10 Thread Andreas Cord-Landwehr
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit bcf4b0962d984be8720179b37d3c9c8ffaa15e84 by Andreas Cord-Landwehr to branch master. Repository: knotifications Description --- There are ifdefs for the platforms Windows and MacOSX, besides

Review Request 128344: Add initial categorized debug output.

2016-07-02 Thread Andreas Cord-Landwehr
, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128336: KNS3::Entry::size: Make sure we offer a size

2016-07-02 Thread Andreas Cord-Landwehr
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128336/#review97028 --- Ship it! Ship It! - Andreas Cord-Landwehr On Juli 2

Re: Review Request 128344: Add initial categorized debug output.

2016-07-02 Thread Andreas Cord-Landwehr
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 35478a2607f13b43504d50e6abe8bcf730b13160 by Andreas Cord-Landwehr to branch master. Repository: attica Description --- Attica has zero debug output, which makes it very hard debugging

Review Request 129202: Handle faulty provider as initialized

2016-10-16 Thread Andreas Cord-Landwehr
- src/attica/atticaprovider.cpp bc590ce2a2170f69d0b6d8049f7d5da5d0c1d0cd Diff: https://git.reviewboard.kde.org/r/129202/diff/ Testing --- manual testing Thanks, Andreas Cord-Landwehr

Re: Review Request 129202: Handle faulty provider as initialized

2017-01-08 Thread Andreas Cord-Landwehr
xt 7 days. - Andreas --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129202/#review100066 --- On Okt. 16, 2016, 5:50 nachm., Andreas Cord

[Differential] [Accepted] D3646: Ignore host libs/includes/cmakeconfig files in Android toolchain

2016-12-18 Thread cordlandwehr (Andreas Cord-Landwehr)
cordlandwehr accepted this revision. cordlandwehr added a comment. The patch absolutely goes into the right direction. All changes look fine to me. However, I did not test the patch yet, since I am currently in the process of updating my cross-compilation setup. IMO it is also fine to not

D6976: Make ECM a dependency for all frameworks

2017-07-30 Thread Andreas Cord-Landwehr
cordlandwehr accepted this revision. This revision is now accepted and ready to land. REPOSITORY R868 Yocto: KDE Frameworks Packaging BRANCH master REVISION DETAIL https://phabricator.kde.org/D6976 To: vkrause, cordlandwehr Cc: #frameworks

D7118: Add KPeople recipe

2017-08-07 Thread Andreas Cord-Landwehr
cordlandwehr accepted this revision. This revision is now accepted and ready to land. REPOSITORY R868 Yocto: KDE Frameworks Packaging BRANCH kpeople REVISION DETAIL https://phabricator.kde.org/D7118 To: vkrause, cordlandwehr Cc: #frameworks

D13970: Handle empty preview lists

2018-07-08 Thread Andreas Cord-Landwehr
cordlandwehr removed reviewers: gregormi, nicolasfella, dhaumann, Frameworks. cordlandwehr added a comment. This revision now requires review to proceed. I had a crash at the respective locations while porting Artikulate to the QtQuick based API, since those KNS resource files do not provide

D13970: Handle empty preview lists

2018-07-08 Thread Andreas Cord-Landwehr
cordlandwehr created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Do not access the first list's element if the list possibly might be empty.

D13970: Handle empty preview lists

2018-07-12 Thread Andreas Cord-Landwehr
cordlandwehr added a reviewer: dhaumann. cordlandwehr added a comment. Somehow removed all reviewers with my last message (sorry!) Trying to fix this now. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D13970 To: cordlandwehr, dhaumann Cc: kde-frameworks-devel,

D13970: Handle empty preview lists

2018-07-12 Thread Andreas Cord-Landwehr
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R304:c4275aaf79fc: Handle empty preview lists (authored by cordlandwehr). REPOSITORY R304 KNewStuff CHANGES SINCE LAST

D17139: Add highlighting file for Wayland Debug Traces

2018-11-24 Thread Andreas Cord-Landwehr
cordlandwehr updated this revision to Diff 46148. cordlandwehr added a comment. - Fix detection of interface names with numbers - Fix reference for nomal text itemData - Add test data for Wayland trace highlighting REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D17139: Add highlighting file for Wayland Debug Traces

2018-11-24 Thread Andreas Cord-Landwehr
cordlandwehr created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cordlandwehr requested review of this revision. REVISION SUMMARY When running a Wayland application with parameter WAYLAND_DEBUG=1, all communication

D17139: Add highlighting file for Wayland Debug Traces

2018-11-25 Thread Andreas Cord-Landwehr
This revision was automatically updated to reflect the committed changes. Closed by commit R216:abb86831466b: Add highlighting file for Wayland Debug Traces (authored by cordlandwehr). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

T11542: Remove KHTML

2019-09-10 Thread Andreas Cord-Landwehr
cordlandwehr closed subtask T11575: Port Parley away from KHTML as Resolved. TASK DETAIL https://phabricator.kde.org/T11542 To: cordlandwehr Cc: cordlandwehr, ngraham, #konqueror, #plasma, #okular, #kde_applications, #frameworks, knauss, GB_2, kpiwowarski, asturmlechner, vkrause, dfaure

T11542: Remove KHTML

2019-11-21 Thread Andreas Cord-Landwehr
cordlandwehr added a subtask: T12086: Port Kile away from KHTML. TASK DETAIL https://phabricator.kde.org/T11542 To: cordlandwehr Cc: cordlandwehr, ngraham, #konqueror, #plasma, #okular, #kde_applications, #frameworks, knauss, manuelal, davidre, GB_2, ahmadsamir, kpiwowarski, asturmlechner,

D25632: Fix module imports with Python3

2019-11-30 Thread Andreas Cord-Landwehr
cordlandwehr created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY The broken module import was covered by the missleading warning "WARNING

D25632: Fix module imports with Python3

2019-12-01 Thread Andreas Cord-Landwehr
cordlandwehr added a reviewer: ochurlaud. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D25632 To: cordlandwehr, ochurlaud Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D25632: Fix module imports with Python3

2019-12-01 Thread Andreas Cord-Landwehr
This revision was automatically updated to reflect the committed changes. Closed by commit R264:f8ff31dc9af0: Fix module imports with Python3 (authored by cordlandwehr). REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25632?vs=70625=70721 REVISION DETAIL

D27245: Ki18n: Convert license headers to SPDX statements

2020-02-13 Thread Andreas Cord-Landwehr
cordlandwehr added inline comments. INLINE COMMENTS > cgiboudeaux wrote in LGPL-3.0-only.txt:15-17 > why are there so many empty lines? Actually, I have no idea. But according to the REUSE specification, the license files must no be changed and used exactly as provided by SPDX. All license

D27245: Ki18n: Convert license headers to SPDX statements

2020-02-13 Thread Andreas Cord-Landwehr
cordlandwehr updated this revision to Diff 75591. cordlandwehr added a comment. Unify license comment header style REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27245?vs=75246=75591 BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27245

D27245: Ki18n: Convert license headers to SPDX statements

2020-02-13 Thread Andreas Cord-Landwehr
cordlandwehr updated this revision to Diff 75592. cordlandwehr added a comment. Remove unneeded whitespace REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27245?vs=75591=75592 BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27245 AFFECTED

  1   2   3   >