D6513: Add support for Attica tags support

2018-07-28 Thread Arjen Hiemstra
ahiemstra accepted this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6513 To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent Cc: mlaurent, ngraham, ahiemstra, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, bruns

D6512: Add support for proposed tags addition in OCS 1.7

2018-07-24 Thread Arjen Hiemstra
ahiemstra added a comment. Right, so leave it to application users how to deal with that, maybe later on add some convenience functions. Sounds sensible. :) REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D6512 To: leinir, #knewstuff, apol, whiting, #kde_store Cc:

D6512: Add support for proposed tags addition in OCS 1.7

2018-07-24 Thread Arjen Hiemstra
ahiemstra accepted this revision. This revision is now accepted and ready to land. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D6512 To: leinir, #knewstuff, apol, whiting, #kde_store, ahiemstra Cc: ahiemstra, ngraham, kde-frameworks-devel, #kde_store, michaelh,

D6513: Add support for Attica tags support

2018-07-24 Thread Arjen Hiemstra
ahiemstra requested changes to this revision. ahiemstra added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > atticaprovider.cpp:283 > +} > +if(filterAcceptsDownloads && checker.filterAccepts(content.tags())) { > +

D6512: Add support for proposed tags addition in OCS 1.7

2018-07-23 Thread Arjen Hiemstra
ahiemstra added a comment. T6133 suggests that tags are formatted as "group##key=value" or something similar. Wouldn't it make sense to handle parsing that format here as well? Or are tags more intended as exact matches? REPOSITORY R235 Attica REVISION

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-08-28 Thread Arjen Hiemstra
ahiemstra requested changes to this revision. ahiemstra added a comment. This revision now requires changes to proceed. I have probably missed stuff, but here are my initial comments. INLINE COMMENTS > atticaprovider.cpp:355 > + > +QList> getCommentsList(const > Attica::Comment::List ,

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-08-29 Thread Arjen Hiemstra
ahiemstra added inline comments. INLINE COMMENTS > leinir wrote in atticaprovider.cpp:355 > That'd be good, except the rest of the KNewStuff API is all QList based. > It'll want doing for KF6, but since QList is being deprecated for that > anyway, i'm thinking we'll end up with a general

Proposing Quick Charts as a new framework

2019-09-02 Thread Arjen Hiemstra
Hi, I have been working on a library the past few months that provides a QtQuick module for rendering gpu-accelerated charts. It currently lives in a playground repository, here: https://invent.kde.org/kde/kf5quickcharts . I would like for this library to be included as a Tier 1 Framework.

Re: Proposing Quick Charts as a new framework

2019-09-05 Thread Arjen Hiemstra
On 02-09-2019 19:26, Luigi Toscano wrote: Arjen Hiemstra ha scritto: Hi, I have been working on a library the past few months that provides a QtQuick module for rendering gpu-accelerated charts. It currently lives in a playground repository, here: https://invent.kde.org/kde/kf5quickcharts

Re: Proposing Quick Charts as a new framework

2019-09-07 Thread Arjen Hiemstra
On 06-09-2019 02:49, Aleix Pol wrote: On Thu, Sep 5, 2019 at 10:53 PM Arjen Hiemstra wrote: On 02-09-2019 19:26, Luigi Toscano wrote: > Arjen Hiemstra ha scritto: >> Hi, >> >> I have been working on a library the past few months that provides a >> QtQuick

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-09-18 Thread Arjen Hiemstra
ahiemstra accepted this revision. ahiemstra added a comment. This revision is now accepted and ready to land. I went over it again and found a few more small things and also added some suggestions. Feel free to apply or ignore the suggestions. Once the other items have been taken care of, I

Re: Proposing Quick Charts as a new framework

2019-09-18 Thread Arjen Hiemstra
On 18-09-2019 12:06, Arjen Hiemstra wrote: On 06-09-2019 11:02, Semke, Alexander wrote: Am 06.09.2019 um 02:49 schrieb Aleix Pol : Does it really have the same features? Otherwise it doesn't make sense to deprecate anything. It will just frustrate the users of the framework. Qt has https

Re: Proposing Quick Charts as a new framework

2019-09-18 Thread Arjen Hiemstra
On 06-09-2019 11:02, Semke, Alexander wrote: Am 06.09.2019 um 02:49 schrieb Aleix Pol : Does it really have the same features? Otherwise it doesn't make sense to deprecate anything. It will just frustrate the users of the framework. Qt has https://doc.qt.io/qt-5/qtcharts-index.html. Does

Re: Proposing Quick Charts as a new framework

2019-09-18 Thread Arjen Hiemstra
On 09-09-2019 10:24, Dominik Haumann wrote: Hi, On Sat, Sep 7, 2019 at 3:59 PM Arjen Hiemstra wrote: On 06-09-2019 02:49, Aleix Pol wrote: On Thu, Sep 5, 2019 at 10:53 PM Arjen Hiemstra wrote: On 02-09-2019 19:26, Luigi Toscano wrote: Arjen Hiemstra ha scritto: [...] That's

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2019-09-20 Thread Arjen Hiemstra
ahiemstra added inline comments. INLINE COMMENTS > leinir wrote in Button.qml:112 > Humhum, yes... so it needs to be possible to change enabled from outside, but > it also needs to be locked to disabled if allowedByKiosk is false... i'm > thinking this probably won't be the prettiest thing,

Re: Quick Charts in KDE Review

2019-11-07 Thread Arjen Hiemstra
On 07-11-2019 15:34, Friedrich W. H. Kossebau wrote: Am Montag, 21. Oktober 2019, 15:22:23 CET schrieb Arjen Hiemstra: Hi, Quick Charts has been moved to KDE review. The intent is to make it a Tier 1 framework. Any chance the official name can be "KQuickCharts"? "Quick Chart

Re: Quick Charts in KDE Review

2019-11-07 Thread Arjen Hiemstra
On 21-10-2019 15:22, Arjen Hiemstra wrote: Hi, Quick Charts has been moved to KDE review. The intent is to make it a Tier 1 framework. Quick Charts is a QML module that implements a set of high-performance, GPU accelerated charts. Currently the main user of it is a new KSysGuard UI I have been

Re: Quick Charts in KDE Review

2019-11-07 Thread Arjen Hiemstra
On 07-11-2019 15:24, Alexander Potashev wrote: чт, 7 нояб. 2019 г. в 13:53, Arjen Hiemstra : On 21-10-2019 15:22, Arjen Hiemstra wrote: > Hi, > > Quick Charts has been moved to KDE review. The intent is to make it a > Tier 1 framework. > > Quick Charts is a QML module tha

D25067: Fix the header layouts for EntryDetails and Page components

2019-10-30 Thread Arjen Hiemstra
ahiemstra added inline comments. INLINE COMMENTS > ngraham wrote in EntryDetails.qml:95 > I don't think this works, since it's not inside another layout. Instead maybe > `anchors.fill: parent` would work better? It does not. I am also unsure whether `anchors.fill` will work, since the

D25303: Expose KDescendantsProxyModel to QML

2019-11-14 Thread Arjen Hiemstra
ahiemstra accepted this revision. This revision is now accepted and ready to land. REPOSITORY R275 KItemModels BRANCH master REVISION DETAIL https://phabricator.kde.org/D25303 To: davidedmundson, ahiemstra Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25311: Add KColumnHeadersProxyModel

2019-11-14 Thread Arjen Hiemstra
ahiemstra created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ahiemstra requested review of this revision. REVISION SUMMARY It converts a model's column headers into a simple list model. It is mainly useful as a helper to create headers

D25311: Add KColumnHeadersProxyModel

2019-11-14 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 69765. ahiemstra added a comment. - Add @since for the class REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25311?vs=69764=69765 BRANCH columnheadersmodel REVISION DETAIL https://phabricator.kde.org/D25311

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

2019-11-15 Thread Arjen Hiemstra
ahiemstra added inline comments. INLINE COMMENTS > sortfiltermodel.h:63 > + */ > +Q_PROPERTY(QString filterRole READ filterRole WRITE setFilterRole) > + This (and sortRole below) hides the properties from QSortFilterProxy with the same name. Maybe it is a better idea to use

D25311: Add KColumnHeadersProxyModel

2019-11-15 Thread Arjen Hiemstra
ahiemstra marked an inline comment as done. ahiemstra added a comment. > We should probably have a unit test, even if it just covers the basic case. Done. > This currently assumes the source model's columns are static. At a minimum that needs a comment. Oops. That was not the

D25311: Add KColumnHeadersProxyModel

2019-11-15 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 69807. ahiemstra added a comment. - Add a unit test for KColumnHeadersProxyModel REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25311?vs=69806=69807 BRANCH columnheadersmodel REVISION DETAIL

D25311: Add KColumnHeadersProxyModel

2019-11-15 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 69806. ahiemstra added a comment. - Forward column change singals as row change signals - Forward header data change signals as dataChanged - Add a unit test for KColumnHeadersProxyModel REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE

D25067: Fix the header layouts for EntryDetails and Page components

2019-11-05 Thread Arjen Hiemstra
ahiemstra added inline comments. INLINE COMMENTS > EntryDetails.qml:94 > title: i18nc("Combined title for the entry details page made of the name > of the entry, and the author's name", "%1 by > %2").arg(component.name).arg(entryAuthor.name) > titleDelegate: QtLayouts.RowLayout { > +

D25311: Add KColumnHeadersProxyModel

2019-12-10 Thread Arjen Hiemstra
This revision was automatically updated to reflect the committed changes. Closed by commit R275:241e9dec6896: Add KColumnHeadersProxyModel (authored by ahiemstra). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25311?vs=70948=71204#toc REPOSITORY R275 KItemModels CHANGES SINCE LAST

Quick Charts in KDE Review

2019-10-21 Thread Arjen Hiemstra
Hi, Quick Charts has been moved to KDE review. The intent is to make it a Tier 1 framework. Quick Charts is a QML module that implements a set of high-performance, GPU accelerated charts. Currently the main user of it is a new KSysGuard UI I have been working on, but once it is part of

Re: Quick Charts in KDE Review

2019-10-21 Thread Arjen Hiemstra
On 21-10-2019 15:22, Arjen Hiemstra wrote: Hi, Quick Charts has been moved to KDE review. The intent is to make it a Tier 1 framework. Quick Charts is a QML module that implements a set of high-performance, GPU accelerated charts. Currently the main user of it is a new KSysGuard UI I have been

D24630: Replace all qWarning and related calls with categorised logging

2019-10-15 Thread Arjen Hiemstra
This revision was automatically updated to reflect the committed changes. Closed by commit R249:b45c3cea521e: Replace all qWarning and related calls with categorised logging (authored by ahiemstra). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE

Re: Quick Charts in KDE Review

2019-10-22 Thread Arjen Hiemstra
For ticks, assuming with those you mean some marker on the chart data points, these are not currently implemented. I do have some ideas regarding these but I did not need them yet. - Arjen пн, 21 окт. 2019 г. в 16:46, Arjen Hiemstra : On 21-10-2019 15:22, Arjen Hiemstra wrote: > Hi, > &g

Re: Quick Charts in KDE Review

2019-10-23 Thread Arjen Hiemstra
On 22-10-2019 18:09, Luigi Toscano wrote: Jonathan Riddell ha scritto: There's a file called LICENSE which contains a copy of the LGPL 2.1 But all the files with an explicit licence seem to be GPL 2+3+KDEeV Please decide which licence you want to apply and if it's GPL 2+3+KDEeV remove

D25311: Add KColumnHeadersProxyModel

2019-11-26 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 70359. ahiemstra added a comment. - Change to using QAbstractListModel as base REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25311?vs=69807=70359 BRANCH columnheadersmodel REVISION DETAIL

D25311: Add KColumnHeadersProxyModel

2019-11-27 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 70405. ahiemstra added a comment. - Do not use nested Private class REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25311?vs=70359=70405 BRANCH columnheadersmodel REVISION DETAIL

D25311: Add KColumnHeadersProxyModel

2019-11-27 Thread Arjen Hiemstra
ahiemstra marked an inline comment as done. ahiemstra added inline comments. INLINE COMMENTS > kossebau wrote in kcolumnheadersmodel.h:57 > For consistency I would prefer having a full Q_SIGNALS section: > > Q_SIGNALS: > void sourceModelChanged(); > > That matches the usual pattern and

D25311: Add KColumnHeadersProxyModel

2019-11-27 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 70437. ahiemstra added a comment. - Use separate Q_SIGNALS for consistency REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25311?vs=70405=70437 BRANCH columnheadersmodel REVISION DETAIL

D25311: Add KColumnHeadersProxyModel

2019-12-02 Thread Arjen Hiemstra
ahiemstra marked an inline comment as done. ahiemstra added a comment. @vkrause Is the updated version more what you expected? REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D25311 To: ahiemstra Cc: kossebau, vkrause, davidedmundson, kde-frameworks-devel,

D25683: KDirOperator: Use a fixed line height for scroll speed

2019-12-02 Thread Arjen Hiemstra
ahiemstra created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ahiemstra requested review of this revision. REVISION SUMMARY This patch intends to do mostly the same as D19190 , but for KDirOperator.

D25683: KDirOperator: Use a fixed line height for scroll speed

2019-12-02 Thread Arjen Hiemstra
ahiemstra edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25683 To: ahiemstra Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24630: Replace all qWarning and related calls with categorised logging

2019-10-14 Thread Arjen Hiemstra
ahiemstra created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ahiemstra requested review of this revision. REVISION SUMMARY This replaces all uncategorised qWarning() calls with calls to qCWarning(), using the kf5.ki18n category for

D25311: Add KColumnHeadersProxyModel

2019-12-05 Thread Arjen Hiemstra
ahiemstra marked an inline comment as done. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D25311 To: ahiemstra Cc: kossebau, vkrause, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25311: Add KColumnHeadersProxyModel

2019-12-05 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 70948. ahiemstra added a comment. - Add missing layoutChanged/reset signals REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25311?vs=70437=70948 BRANCH columnheadersmodel REVISION DETAIL

D25311: Add KColumnHeadersProxyModel

2019-12-05 Thread Arjen Hiemstra
ahiemstra added a comment. Sure, I can land it after saturday. REPOSITORY R275 KItemModels BRANCH columnheadersmodel REVISION DETAIL https://phabricator.kde.org/D25311 To: ahiemstra, davidedmundson Cc: kossebau, vkrause, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2,

D27805: Add a screenshot capture item and use it to test rendering

2020-03-03 Thread Arjen Hiemstra
ahiemstra created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ahiemstra requested review of this revision. REVISION SUMMARY This adds the ItemCapture item to the test runner, which can be used to capture images of items and compare them

D27695: WIP: Create a new TopArea element using widgets/toparea svg

2020-02-27 Thread Arjen Hiemstra
ahiemstra added inline comments. INLINE COMMENTS > TopArea.qml:40 > +rightInset: -topAreaSvg.margins.right > +topInset: -topAreaSvg.margins.bottom ? flipped : -topAreaSvg.margins.top > +bottomInset: -topAreaSvg.margins.bottom ? flipped : > -topAreaSvg.margins.top This conditional

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

2020-01-29 Thread Arjen Hiemstra
ahiemstra added a comment. Something I noticed just now while trying to use this: the `filterString` property has disappeared. PlasmaCore.SortFilterProxy does have this. I think we should restore it, otherwise you need to manually call QSFPM::setFilterFixedString or hope that you can set it

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

2020-01-29 Thread Arjen Hiemstra
ahiemstra added inline comments. INLINE COMMENTS > kmaterka wrote in ksortfilterproxymodel_qml.cpp:111 > Can you add a test for sortColumn? It might be useful for newcomers (like me) > to understand how it works. I had real trouble understanding when it is > needed and when not

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

2020-01-29 Thread Arjen Hiemstra
ahiemstra added inline comments. INLINE COMMENTS > ksortfilterproxymodel.cpp:85 > +QJSValueList args = {QJSValue(source_column), > engine->toScriptValue(source_parent)}; > +return const_cast *>(this)->m_filterCallback.call(args).toBool(); > +} This is using the wrong

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

2020-01-29 Thread Arjen Hiemstra
ahiemstra added inline comments. INLINE COMMENTS > ksortfilterproxymodel.cpp:74 > +QJSValueList args = {QJSValue(source_row), > engine->toScriptValue(source_parent)}; > +return const_cast *>(this)->m_filterCallback.call(args).toBool(); > +} Suggestion: Instead of directly

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

2020-01-29 Thread Arjen Hiemstra
ahiemstra updated this revision to Diff 74601. ahiemstra added a comment. - Use QQmlParserStatus to slightly delay syncing of role names REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25326?vs=74592=74601 BRANCH arcpatch-D25326 REVISION DETAIL

D25794: ArraySourceTest: Use QTEST_GUILESS_MAIN

2020-02-17 Thread Arjen Hiemstra
ahiemstra added a comment. @heikobecker This patch has been open for a long time... Do you have commit access or do you need someone to commit it for you? BRANCH master REVISION DETAIL https://phabricator.kde.org/D25794 To: heikobecker, #frameworks, ahiemstra, davidedmundson

D25795: Rename kf5quickcharts_example to kquickcharts_example

2020-02-17 Thread Arjen Hiemstra
ahiemstra added a comment. @heikobecker This patch has been open for a long time... Do you have commit access or do you need someone to commit it for you? BRANCH master REVISION DETAIL https://phabricator.kde.org/D25795 To: heikobecker, #frameworks, ahiemstra, davidedmundson

D26431: Fix build of python bindings for kcolumnheadersmodel

2020-01-05 Thread Arjen Hiemstra
ahiemstra accepted this revision. ahiemstra added a comment. This revision is now accepted and ready to land. Silly sip :/ REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D26431 To: arojas, dfaure, ahiemstra, davidedmundson Cc: kde-frameworks-devel, LeGast00n,

D28372: Added a merged look to the plasmoidheading and remove roundedborders

2020-03-30 Thread Arjen Hiemstra
ahiemstra added subscribers: ndavis, ahiemstra. ahiemstra added a comment. The same thing was actually proposed by I think @ndavis a while back, see https://phabricator.kde.org/T10470#219994 . To summarize, it's perfectly technically possible and I actually rather like it. REPOSITORY

D28220: Switch to using Kirigami's ShadowedRectangle

2020-04-01 Thread Arjen Hiemstra
ahiemstra added a comment. It's fine with me but I'm going to leave the final call to @broulik since he did a more in-depth review. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28220 To: leinir, #knewstuff, #frameworks, #plasma, ahiemstra, broulik, mart, #vdg

D29534: Implement scroll and drag adjustment of values for SpinBox control

2020-05-11 Thread Arjen Hiemstra
ahiemstra added inline comments. INLINE COMMENTS > SpinBox.qml:54 > +// Because we're stomping the Text Input's own mouse handling > +textField.forceActiveFocus() > +} You can do `mouse.accepted = false` instead of forceActiveFocus to allow the mouse

D29527: Add MapProxySource

2020-05-08 Thread Arjen Hiemstra
ahiemstra created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ahiemstra requested review of this revision. REVISION SUMMARY A source that provides values from a map based on keys from a different source. TEST PLAN The auto test

D27805: Add a screenshot capture item and use it to test rendering

2020-05-19 Thread Arjen Hiemstra
ahiemstra abandoned this revision. ahiemstra added a comment. Will continue this on Gitlab. REPOSITORY R1049 KQuickCharts REVISION DETAIL https://phabricator.kde.org/D27805 To: ahiemstra Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29742: Avoid potential disconnect of all signals in IconItem

2020-05-14 Thread Arjen Hiemstra
ahiemstra accepted this revision. ahiemstra added a comment. This revision is now accepted and ready to land. This fixes bug 421170 for me. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D29742 To: davidedmundson, #plasma,

D29527: Add MapProxySource

2020-05-08 Thread Arjen Hiemstra
This revision was automatically updated to reflect the committed changes. Closed by commit R1049:fa334cf9e809: Add MapProxySource (authored by ahiemstra). REPOSITORY R1049 KQuickCharts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29527?vs=82256=82278 REVISION DETAIL

D25814: [KColorScheme] Add SeparatorColor

2020-05-06 Thread Arjen Hiemstra
ahiemstra added a comment. I actually ran into this with the new Card designs I implemented in Kirigami. Kirigami right now does a lot of `tint(backgroundColor, textColor)` to generate separator colours. However, this leads to potential differences when the color set is View vs. Window or

D27544: Fix update scenarios with no explicit downloadlink selected

2020-03-19 Thread Arjen Hiemstra
ahiemstra accepted this revision. REPOSITORY R304 KNewStuff BRANCH fix-update (branched from master) REVISION DETAIL https://phabricator.kde.org/D27544 To: leinir, #knewstuff, #frameworks, #plasma, ngraham, apol, #discover_software_store, ahiemstra Cc: ahiemstra, alexde,

D28220: Switch to using Kirigami's ShadowedRectangle

2020-03-24 Thread Arjen Hiemstra
ahiemstra added inline comments. INLINE COMMENTS > EntryScreenshots.qml:134 > +Kirigami.Theme.colorSet: Kirigami.Theme.View > +shadow.xOffset: 0 > +shadow.yOffset: 0 The x and y offsets should be 0 by default, so there's little reason

D27544: Fix update scenarios with no explicit downloadlink selected

2020-03-17 Thread Arjen Hiemstra
ahiemstra added inline comments. INLINE COMMENTS > engine.cpp:614 > +QString identifiedLink; > +const QString& payloadToIdentify = d->payloadToIdentify[entry]; > +const QStringList& payloads = d->payloads[entry]; Code style: & attaches to the name, not the

D29534: Implement scroll and drag adjustment of values for SpinBox control

2020-05-20 Thread Arjen Hiemstra
ahiemstra accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH implement-spinbox-wheel-adjustment (branched from master) REVISION DETAIL https://phabricator.kde.org/D29534 To: ngraham, #vdg, #plasma, ahiemstra Cc: