Re: KCoreAddons forward headers

2013-12-29 Thread Christoph Cullmann
in kate.git/ktexteditor/include/CMakelists.txt and need still to install the normal headers manually. Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel

Frameworks Performance Question

2013-12-29 Thread Christoph Cullmann
what I could try to fix that would be really great. Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken

Re: Frameworks Performance Question

2013-12-30 Thread Christoph Cullmann
On Sun, Dec 29, 2013 at 08:07:38PM +0100, Christoph Cullmann wrote: if I play around with Kate on KF5, it laggs like hell the whole time. I tried to profile, but guess I am stuck a bit. How did you profile? I'd recommend using 'perf', it's pretty simple to use: - perf record ./kate

Re: Frameworks Performance Question

2013-12-30 Thread Christoph Cullmann
On Sunday 29 December 2013 20:07:38 Christoph Cullmann wrote: Hi, if I play around with Kate on KF5, it laggs like hell the whole time. I tried to profile, but guess I am stuck a bit. #10 0x73fbeaa0 in KConfig::reparseConfiguration (this=0x688130) at /home/cullmann

Re: Frameworks Performance Question

2013-12-31 Thread Christoph Cullmann
;) Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANY

Re: What are the plans with CamelCase includes?

2014-01-02 Thread Christoph Cullmann
Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANY

Re: What are the plans with CamelCase includes?

2014-01-02 Thread Christoph Cullmann
:-) What do you think? Yeah, that sounds sane enough, even if in my case it would look duplicated ;) But the benefit of not found headers if wrong link flags is really nice! Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH

KDE4Support Headers

2014-01-03 Thread Christoph Cullmann
Hi, KDE4Support installs still stuff like kmimetype.h in the KF5 directory, shall it not better install all its compat headers in some KDE4Support prefix to avoid that one can use them without using KF4::KDE4Support? Greetings Christoph -- - Dr.-Ing. Christoph

Re: KF5 include problems on the build.kde.org?

2014-01-04 Thread Christoph Cullmann
Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123

KTextEditor Frameworks question

2014-01-04 Thread Christoph Cullmann
, or shall that be split again into a khtml like framework? Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken

Re: KTextEditor Frameworks question

2014-01-04 Thread Christoph Cullmann
On Saturday 04 January 2014 19:18:56 Christoph Cullmann wrote: Hi, I cleanup the frameworks branch in kate.git to only have libktexteditor lib and the KTextEditor/ktexteditor includes to be installed as public API. Now, for 5.x, if others port over, like KDevelop, is it a good idea

Re: KTextEditor Frameworks question

2014-01-04 Thread Christoph Cullmann
On Saturday 04 January 2014 19:40:46 Christoph Cullmann wrote: What would be required to have the ktexteditor stuff be frameworks ready? Using all the cmake stuff from other frameworks ;) I just updated and moved the framework template we had in kdelibs to kdeexamples/framework-template

Re: KTextEditor Frameworks question

2014-01-04 Thread Christoph Cullmann
On Saturday 04 January 2014 22:40:13 Christoph Cullmann wrote: On Saturday 04 January 2014 19:40:46 Christoph Cullmann wrote: What would be required to have the ktexteditor stuff be frameworks ready? Using all the cmake stuff from other frameworks ;) I just updated

Re: KTextEditor Frameworks question

2014-01-05 Thread Christoph Cullmann
On Saturday 04 January 2014 19:40:46 Christoph Cullmann wrote: On Saturday 04 January 2014 19:18:56 Christoph Cullmann wrote: Hi, I cleanup the frameworks branch in kate.git to only have libktexteditor lib and the KTextEditor/ktexteditor includes to be installed as public

Re: KTextEditor Frameworks question

2014-01-06 Thread Christoph Cullmann
hope, with grafting able history, at least I was able to graft against kate.git using the howto. The structure should fit a framework, only the tests dir is missing as empty atm. Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte

Re: KTextEditor Frameworks question

2014-01-07 Thread Christoph Cullmann
On Tuesday 07 January 2014 07:12:40 Christoph Cullmann wrote: I tried my luck with splitting/grafting/kdeexamples template. Could somebody take a look what ended up in the master branch of g...@git.kde.org:scratch/cullmann/ktexteditor.git Any feedback welcome, if I

Re: KTextEditor Frameworks question

2014-01-07 Thread Christoph Cullmann
- Ursprüngliche Mail - On Tuesday 07 January 2014 07:12:40 Christoph Cullmann wrote: I tried my luck with splitting/grafting/kdeexamples template. Could somebody take a look what ended up in the master branch of g...@git.kde.org:scratch/cullmann/ktexteditor.git Any

Re: KTextEditor Frameworks question

2014-01-07 Thread Christoph Cullmann
On Tuesday 07 January 2014 19:57:56 Christoph Cullmann wrote: Hi, I just tried to fix the naming issues. Does that try here look better http://quickgit.kde.org/?p=scratch%2Fcullmann%2Fktexteditor.git I see a ${FooBar_HEADERS} in src/CMakeLists.txt which is used but not set

Re: KTextEditor Frameworks question

2014-01-07 Thread Christoph Cullmann
. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANYWWW: http://www.AbsInt.com

Re: KTextEditor Frameworks question

2014-01-07 Thread Christoph Cullmann
On Tuesday 07 January 2014 20:55:19 Christoph Cullmann wrote: * run astyle-kdelibs (requires some patching, so I can do it if you want) Sure, that would be nice. OK. Can you give a quick look at http://www.davidfaure.fr/2014/ktexteditor-astyled.diff and give me a green light

Re: KTextEditor Frameworks question

2014-01-07 Thread Christoph Cullmann
Fixed :P - Ursprüngliche Mail - Am Dienstag, 7. Januar 2014, 19:57:56 schrieb Christoph Cullmann: Hi, I just tried to fix the naming issues. Does that try here look better http://quickgit.kde.org/?p=scratch%2Fcullmann%2Fktexteditor.git If yes, I would ask sysadmin

Re: Jenkins build became unstable: ktexteditor_master_qt5 #20

2014-01-12 Thread Christoph Cullmann
mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360

Re: kate5 won't build with latest ktexteditor

2014-01-19 Thread Christoph Cullmann
-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49

Re: Review Request 115197: Allow compiling KTextEditor on Windows

2014-01-21 Thread Christoph Cullmann
, thought, need to look at that. - Christoph Cullmann On Jan. 21, 2014, 10:21 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115197

Re: Review Request 115197: Allow compiling KTextEditor on Windows

2014-01-21 Thread Christoph Cullmann
On Jan. 21, 2014, 10:24 p.m., Christoph Cullmann wrote: ++ for platformsdefs, still no idea why we need winsock, thought, need to look at that. Alexander Richardson wrote: gethostname is called, I am not familiar enough with the code to say whether that is necessary I see

Re: Review Request 115207: Improve integration QCommandLineParser - KAboutData

2014-01-21 Thread Christoph Cullmann
code - Christoph Cullmann On Jan. 21, 2014, 11:36 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115207

Re: kate (frameworks) build failure

2014-01-22 Thread Christoph Cullmann
___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm

Re: Review Request 115262: Split Mainpage.dox up

2014-01-23 Thread Christoph Cullmann
;) - Christoph Cullmann On Jan. 23, 2014, 4:09 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115262/ --- (Updated

Re: Build failed in Jenkins: kde4support_master_qt5 #32

2014-01-23 Thread Christoph Cullmann
. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANYWWW: http://www.AbsInt.com

Re: Build failed in Jenkins: kde4support_master_qt5 #32

2014-01-23 Thread Christoph Cullmann
On Fri, Jan 24, 2014 at 8:36 AM, Christoph Cullmann cullm...@absint.com wrote: Hi, I think the problem is the -std=iso9899:1990 in our KDECompilerSettings.cmake, that causes at least this error on my machine locally. (openSUSE 13.1, gcc 4.8.1) Without that, the configure

Re: Build failed in Jenkins: kde4support_master_qt5 #32

2014-01-24 Thread Christoph Cullmann
-modules/repository/revisions/8b055d7f229d6596cf15d045b85ec937f8e2abe8 Could it be, that now, as we use add_definitions in that file before the C/CXX FLAGS are set again, we loose these defines? Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt

Re: Review Request 115292: Do Configure Checks in the Correct Language

2014-01-24 Thread Christoph Cullmann
is needed for kjs. - Christoph Cullmann On Jan. 24, 2014, 1:55 p.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115292

Re: Build failed in Jenkins: kde4support_master_qt5 #32

2014-01-24 Thread Christoph Cullmann
Hmm, see https://git.reviewboard.kde.org/r/115292/ that fixes it for me ;) - Ursprüngliche Mail - On 24/01/14 13:30, Alex Merry wrote: On 24/01/14 13:22, Christoph Cullmann wrote: I recreated my build directories and now I'm hitting it too. I guess it a matter of time

Re: Review Request 115293: Statusbar: double click on INSERT/OVERWRITE label toggles

2014-01-24 Thread Christoph Cullmann
icon for the not handled case, will look at that after you pushed it. - Christoph Cullmann On Jan. 24, 2014, 4:06 p.m., Gregor Mi wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Review Request 115392: Fix compilation with clang

2014-01-29 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115392/#review48574 --- Ship it! Ship It! - Christoph Cullmann On Jan. 29, 2014

Re: X11 usage in kdeinit/kinit.cpp

2014-02-17 Thread Christoph Cullmann
user desktop) but still use X11 as default? Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken

Re: KF5 alpha2

2014-03-17 Thread Christoph Cullmann
On Wednesday 12 March 2014 12:21:36 Christoph Cullmann wrote: David Faure wrote: On Wednesday 05 March 2014 19:29:34 Michael Palimaka wrote: Hi, KTextEditor is listed as tier 3, but is missing from this (and previous) releases. It is not part of the KF 5.0 release

Re: Releasing Deprecated modules and Tier 4 Definition

2014-03-17 Thread Christoph Cullmann
in KDE Porting Aids? Hi, perhaps I am wrong, but is not kross as good candidate to be added to this list, too? Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1

Re: KF5 alpha2

2014-03-19 Thread Christoph Cullmann
On Wednesday 12 March 2014 12:21:36 Christoph Cullmann wrote: David Faure wrote: On Wednesday 05 March 2014 19:29:34 Michael Palimaka wrote: Hi, KTextEditor is listed as tier 3, but is missing from this (and previous) releases. It is not part of the KF 5.0 release

Re: Review Request 116994: Use KPluginLoader::findPlugin and QLibrary instead of KLibrary

2014-03-23 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116994/#review53815 --- Ship it! Ship It! - Christoph Cullmann On March 23, 2014

Re: Review Request 117017: Remove forward headers for KTextEditor

2014-03-24 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117017/#review53970 --- Ship it! Ship It! - Christoph Cullmann On March 24, 2014

Re: Build failed in Jenkins: ktexteditor_master_qt5 #335

2014-03-25 Thread Christoph Cullmann
, somehow that is unrelated to my code work, or? I didn't touch the CMake find parts :/ Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681

Re: Build failed in Jenkins: ktexteditor_master_qt5 #335

2014-03-25 Thread Christoph Cullmann
On 25/03/14 19:52, Christoph Cullmann wrote: CMake Error at /srv/jenkins/install/linux/x86_64/g++/shared/general/cmake/share/cmake-3.0/Modules/CMakeFindDependencyMacro.cmake:65 (find_package): Could not find a configuration file for package KF5Notifications that is compatible

Re: Build failed in Jenkins: ktexteditor_master_qt5 #335

2014-03-25 Thread Christoph Cullmann
-- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANYWWW

Re: build qt5 stable (changed subject from: qt5 stable: qengineio: fatal: remote error: access denied or repository not exported)

2014-04-01 Thread Christoph Cullmann
5.0 is released. Looking at the qt list, it might be, that they reconsider to merge all gits into one again which will make tracking easy once again after 5.3. Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email

Re: build qt5 stable (changed subject from: qt5 stable: qengineio: fatal: remote error: access denied or repository not exported)

2014-04-01 Thread Christoph Cullmann
once again after 5.3. Ignore me, I hate april fools .P Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken

Re: Review Request 117695: change where dynamic replace tabs is performed

2014-05-19 Thread Christoph Cullmann
the old code was :) insertText should not modify the text more than needed. - Christoph Cullmann On May 3, 2014, 12:57 a.m., Sven Brauch wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org

Re: Review Request 118484: Move katepart into a kf5/parts subdir of plugin dir

2014-06-03 Thread Christoph Cullmann
;) Thanks for taking care! - Christoph Cullmann On June 2, 2014, 9:19 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118484

KAction Warning

2014-07-19 Thread Christoph Cullmann
. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANYWWW: http://www.AbsInt.com

Re: Review Request 119377: Add highlighting commands

2014-07-20 Thread Christoph Cullmann
. What would be nice before you add that: rename the file from katehighlightreload to katehighlightingcmds or so, as it contains more than just the reload, and later might get more. - Christoph Cullmann On July 20, 2014, 12:29 p.m., Christoph Rüßler wrote

Re: Review Request 119377: Add highlighting commands

2014-07-23 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119377/#review62977 --- Ship it! Ship It! - Christoph Cullmann On July 23, 2014

Re: Questions about KDE 4.14 and later + branches

2014-07-24 Thread Christoph Cullmann
(at least I hope). Do I need to do anything else in addition? for kate.git master is now KF5 based, last Qt4 variant will be 4.14. Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com

Re: KAction Warning

2014-08-05 Thread Christoph Cullmann
On Saturday 19 July 2014 23:57:15 Christoph Cullmann wrote: Hi, perhaps that is a stupid question, but last time I read up in the docs, they didn't help me: KatePart spits out a lot of: kate(15138)/(default) KXMLGUIFactoryPrivate::saveDefaultActionProperties: Shortcut

Re: KAction Warning

2014-08-06 Thread Christoph Cullmann
()), Q_ARG(QAction *, pAction)); } just with setShortcut(s), but that won't work for the cases with parent 0. Any idea? Greetings Christoph - Ursprüngliche Mail - On Saturday 19 July 2014 23:57:15 Christoph Cullmann wrote: Hi, perhaps that is a stupid question, but last time I read up

Re: Review Request 120062: KActionCollection::setDefaultShortcuts now makes the shortcut active too.

2014-09-05 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120062/#review65826 --- Looks like good idea. - Christoph Cullmann On Sept. 5

Review Request 120088: Fix the warning about setDefaultShortcut for stdactions

2014-09-07 Thread Christoph Cullmann
--- Standard actions use lead to that warning, as the internally use just setShortcuts (as they can't use KActionCollection). KWrite now starts up with close to zero warnings (and none for standard actions, I think). Thanks, Christoph Cullmann ___ Kde

Re: Review Request 120088: Fix the warning about setDefaultShortcut for stdactions

2014-09-07 Thread Christoph Cullmann
to that warning, as the internally use just setShortcuts (as they can't use KActionCollection). KWrite now starts up with close to zero warnings (and none for standard actions, I think). Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 120088: Fix the warning about setDefaultShortcut for stdactions

2014-09-07 Thread Christoph Cullmann
think). Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 120093: Guard too verbose 'KDirWatchPrivate::addEntry: Added File...' message

2014-09-07 Thread Christoph Cullmann
File... output for any opened file. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120093: Guard too verbose 'KDirWatchPrivate::addEntry: Added File...' message + use same method to output available methods

2014-09-07 Thread Christoph Cullmann
verbose Added File... output for any opened file. Available methods are gone in output, too. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120093: Guard too verbose 'KDirWatchPrivate::addEntry: Added File...' message + use same method to output available methods

2014-09-08 Thread Christoph Cullmann
of that output. Diffs - src/lib/io/kdirwatch.cpp 7abb32a Diff: https://git.reviewboard.kde.org/r/120093/diff/ Testing --- Tested with Kate, removed the super verbose Added File... output for any opened file. Available methods are gone in output, too. Thanks, Christoph Cullmann

Review Request 120099: RFC: UI-Files inside resources instead of filesystem

2014-09-08 Thread Christoph Cullmann
--- Compiles if I package ui file in kate into resource, works. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 120196: Find-Module to detect libgit2

2014-09-14 Thread Christoph Cullmann
://git.reviewboard.kde.org/r/120196/diff/ Testing --- Tested with KTextEditor, version detection is here important, as libgit2 did change API a lot, seems to work on Linux, hope it works on Windows, too. Thanks, Christoph Cullmann ___ Kde-frameworks

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120196/#review66567 --- On Sept. 14, 2014, 10:19 a.m., Christoph Cullmann wrote

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Christoph Cullmann
On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote: Shouldn't it be called FindLibGit2? Git2 and LibGit2 seem different things to me. Christoph Cullmann wrote: I can rename it, but then it is inconsistent with most other FindXXX.cmake's, as they skip the lib prefix

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Christoph Cullmann
On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote: Shouldn't it be called FindLibGit2? Git2 and LibGit2 seem different things to me. Christoph Cullmann wrote: I can rename it, but then it is inconsistent with most other FindXXX.cmake's, as they skip the lib prefix

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Christoph Cullmann
. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Christoph Cullmann
On Sept. 15, 2014, 3:15 p.m., Aleix Pol Gonzalez wrote: Shouldn't it be called FindLibGit2? Git2 and LibGit2 seem different things to me. Christoph Cullmann wrote: I can rename it, but then it is inconsistent with most other FindXXX.cmake's, as they skip the lib prefix

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Christoph Cullmann
, too. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120196: Find-Module to detect libgit2

2014-09-15 Thread Christoph Cullmann
, too. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: changelog for KF 5.3

2014-10-05 Thread Christoph Cullmann
-framework (I didn't even try for that one). Hi, yeah, sorry :/ need to get used to CHANGELOG :/ Most stuff in KTextEditor is bugfixing, anyways, hope 5.3 will have lot less bugs than we had before :-) Greetings Christoph -- - Dr.-Ing. Christoph Cullmann

Re: Review Request 120099: RFC: UI-Files inside resources instead of filesystem

2014-10-05 Thread Christoph Cullmann
/kxmlguifactory.cpp c4ad97b Diff: https://git.reviewboard.kde.org/r/120099/diff/ Testing --- Compiles if I package ui file in kate into resource, works. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 120099: RFC: UI-Files inside resources instead of filesystem

2014-10-05 Thread Christoph Cullmann
., Christoph Cullmann wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120099/ --- (Updated Oct. 5, 2014, 5:32 p.m.) Review

Re: Review Request 120099: RFC: UI-Files inside resources instead of filesystem

2014-10-06 Thread Christoph Cullmann
to administrators. Christoph Cullmann wrote: Actually that is a big benefit in my eyes, if you ship software with compiled in resources, you don't want people mingling around with them, IMHO. E.g. in ktexteditor I could use this and be sure that no actions or stuff is missing only

Re: Review Request 120099: RFC: UI-Files inside resources instead of filesystem

2014-10-06 Thread Christoph Cullmann
to administrators. Christoph Cullmann wrote: Actually that is a big benefit in my eyes, if you ship software with compiled in resources, you don't want people mingling around with them, IMHO. E.g. in ktexteditor I could use this and be sure that no actions or stuff is missing only

Re: Review Request 120099: RFC: UI-Files inside resources instead of filesystem

2014-10-07 Thread Christoph Cullmann
/kxmlguifactory.cpp c4ad97b Diff: https://git.reviewboard.kde.org/r/120099/diff/ Testing --- Compiles if I package ui file in kate into resource, works. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Supporting MSVC2010 in ktexteditor framework

2014-11-05 Thread Christoph Cullmann
think, beside the unit tests, but thats fixable) or we raise the bar for all frameworks. Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49

Re: Review Request 120760: Fix bug #340212: incorrect soft-tabs alignment after beginning-of-line

2014-11-12 Thread Christoph Cullmann
ok. Perhaps you could add a comment to the eventuallyReplaceTabs function explaining what it does. Would make it later easier to understand. Perhaps even with some ref to bug . But it had no comment before, so that is no stopper and not your fault ;) - Christoph Cullmann On Nov. 12, 2014

Re: Review Request 121160: Add libgit2 compile-time check for threads support

2014-11-17 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121160/#review70541 --- Ship it! Ship It! - Christoph Cullmann On Nov. 17, 2014

Re: Review Request 121263: Prevent API abuse of calling setters on temporary objects.

2014-11-26 Thread Christoph Cullmann
. If that is just to make porting easier, you can use that locally as a patch until the kdevplatform code is cleaned up. - Christoph Cullmann On Nov. 27, 2014, 1:15 a.m., Milian Wolff wrote: --- This is an automatically generated e-mail

Re: Review Request 121263: Prevent API abuse of calling setters on temporary objects.

2014-12-08 Thread Christoph Cullmann
On Nov. 27, 2014, 7:29 a.m., Christoph Cullmann wrote: I actually would prefer no such hack in the public headers. If that is just to make porting easier, you can use that locally as a patch until the kdevplatform code is cleaned up. Milian Wolff wrote: I still don't get why you

Re: Review Request 121263: Prevent API abuse of calling setters on temporary objects.

2015-02-08 Thread Christoph Cullmann
On Nov. 27, 2014, 7:29 a.m., Christoph Cullmann wrote: I actually would prefer no such hack in the public headers. If that is just to make porting easier, you can use that locally as a patch until the kdevplatform code is cleaned up. Milian Wolff wrote: I still don't get why you

Re: OSX/CI: konsole fails to build on branch master

2015-01-06 Thread Christoph Cullmann
Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANY

Re: OSX/CI: konsole fails to build on branch master

2015-01-06 Thread Christoph Cullmann
On Tuesday 06 January 2015 22:14:06 Marko Käning wrote: Hi Christoph, On 06 Jan 2015, at 22:10 , Christoph Cullmann cullm...@absint.com wrote: I think the problem is that it should be KF5_INSTALL_TARGETS_DEFAULT_ARGS, the prefix is missing in many cmake files. yep, now I do

Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS

2015-01-06 Thread Christoph Cullmann
. --- ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel -- Kevin Funk | kf...@kde.org | http://kfunk.org -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte

Re: Review Request 122498: Register with dbus to wake up KRun, and unregister then

2015-02-15 Thread Christoph Cullmann
, but if it works around the current nasty bug, please commit and close the bug! Thanks for taking care of the patch. - Christoph Cullmann On Feb. 9, 2015, 11:04 a.m., Martin Klapetek wrote: --- This is an automatically generated e-mail

Re: Some more projects in need of respecting KF5_INSTALL_TARGETS_DEFAULT_ARGS

2015-01-07 Thread Christoph Cullmann
://mail.kde.org/mailman/listinfo/kde-frameworks-devel -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax

Re: Review Request 123075: do not require X11 on Mac OS X

2015-03-20 Thread Christoph Cullmann
On March 20, 2015, 7:07 a.m., Martin Gräßlin wrote: as in other similar requests: -2 from my side Martin Gräßlin wrote: To extend: I think the way is wrong. If it now builds on MacOS the required is wrong. It should be an optional find_package properly ifdefed. Christoph Cullmann

Re: Review Request 123075: do not require X11 on Mac OS X

2015-03-20 Thread Christoph Cullmann
On March 20, 2015, 7:07 a.m., Martin Gräßlin wrote: as in other similar requests: -2 from my side Martin Gräßlin wrote: To extend: I think the way is wrong. If it now builds on MacOS the required is wrong. It should be an optional find_package properly ifdefed. Actually, you don't

Re: Review Request 123075: do not require X11 on Mac OS X

2015-03-20 Thread Christoph Cullmann
On March 20, 2015, 7:07 a.m., Martin Gräßlin wrote: as in other similar requests: -2 from my side Martin Gräßlin wrote: To extend: I think the way is wrong. If it now builds on MacOS the required is wrong. It should be an optional find_package properly ifdefed. Christoph Cullmann

Re: Review Request 123075: do not require X11 on Mac OS X

2015-03-20 Thread Christoph Cullmann
On March 20, 2015, 7:07 a.m., Martin Gräßlin wrote: as in other similar requests: -2 from my side Martin Gräßlin wrote: To extend: I think the way is wrong. If it now builds on MacOS the required is wrong. It should be an optional find_package properly ifdefed. Christoph Cullmann

Re: Review Request 122875: Fix KIconEngine::paint to handle different devicePixelRatios

2015-03-09 Thread Christoph Cullmann
list (thought the project plugin tree view is still pixelated, guess need to take a look at the Kate code for that myself ;=) - Christoph Cullmann On March 9, 2015, 5:54 p.m., David Edmundson wrote: --- This is an automatically generated

Re: Review Request 123677: Bring back use of KEncodingFileDialog

2015-05-08 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123677/#review80080 --- Ship it! Ship It! - Christoph Cullmann On May 7, 2015, 8

Re: Review Request 123677: Bring back use of KEncodingFileDialog

2015-05-08 Thread Christoph Cullmann
is not something that Christoph Cullmann would agree with. Hmm, otherwise, as this is a regression, I can live with the non-native save dialogs as long as we have no other fix, please commit. - Christoph --- This is an automatically

Re: Versioning of Frameworks

2015-05-05 Thread Christoph Cullmann
and one number is all you need ;=) Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax

Re: How to port KGlobalSettings::fixedFont et. al?

2015-06-05 Thread Christoph Cullmann
...@milianw.de http://milianw.de ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte

Re: Review Request 124133: Add dedicated Version tab to KAboutApplicationDialog

2015-06-20 Thread Christoph Cullmann
would get that info submitted for bugs, too? (which is a different thingy, I know, just came to mind) - Christoph Cullmann On June 20, 2015, 4:30 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit

Re: [ktexteditor] src/utils: only output warnings and above per default

2015-07-28 Thread Christoph Cullmann
Hi, ok, will fix the #if and will remove that if the cmake solution is there ;=) Greetings Christoph - Ursprüngliche Mail - On Tuesday 28 July 2015 07:54:54 Christoph Cullmann wrote: -Q_LOGGING_CATEGORY(LOG_PART, katepart) +Q_LOGGING_CATEGORY(LOG_PART, katepart, QtWarningMsg

Re: Review Request 124505: Add API to use QIcon for KMultiTabBar to avoid problems with wrong sized QPixmaps on HiDPI screens

2015-07-30 Thread Christoph Cullmann
marked as submitted. Review request for KDE Frameworks and David Edmundson. Changes --- Submitted with commit df8b48c6c910540b1fe3f3a45392fe0286145e8e by Christoph Cullmann to branch master. Repository: kwidgetsaddons Description --- New API with QIcon parameters, deprecate

Review Request 124584: Introduce categorized debug output

2015-08-01 Thread Christoph Cullmann
::close: Closing notification 1 kwrite(11559)/(default) NotifyByPopupPrivate::closeGalagoNotification: not found dbus id to close 1 kwrite(11559)/(default) NotifyByAudio::stateChanged: Changing audio state from Phonon::PlayingState to Phonon::StoppedState Thanks, Christoph Cullmann

  1   2   3   4   5   6   7   8   9   10   >