[Differential] [Accepted] D4226: [KNS] Take into account the distribution type

2017-01-23 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Yup, this is fairly clearly what this is really supposed to be doing... REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D4226 EMAIL PREFERENCES

[Differential] [Accepted] D4118: if is not an archive, always copy

2017-01-18 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Right. I think we can sensibly pick this. I would like a comment added, though, that future "don't simply install things" logic should go into the section above this one, rather than into

[Differential] [Accepted] D4156: sort alphabetically category list

2017-01-18 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. LGTM :) REPOSITORY R304 KNewStuff BRANCH phab/sort REVISION DETAIL https://phabricator.kde.org/D4156 EMAIL PREFERENCES

[Differential] [Accepted] D4065: Don't ask if we're getting the file in /tmp

2017-01-19 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Go for it REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D4065 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

Re: Review Request 129298: KPackage dependencies support

2016-11-18 Thread Dan Leinir Turthra Jensen
rg/r/129298/ > ------- > > (Updated Nov. 17, 2016, 4 p.m.) > > > Review request for KDE Frameworks, Plasma, Dan Leinir Turthra Jensen, and > Marco Martin. > > > Repository: kpackage > > > Description >

Re: Review Request 129298: RFC: supporting dependencies on KPackage

2016-11-01 Thread Dan Leinir Turthra Jensen
-- > > (Updated Oct. 31, 2016, 5:09 p.m.) > > > Review request for KDE Frameworks, Plasma, Dan Leinir Turthra Jensen, and > Marco Martin. > > > Repository: kpackage > > > Description > --- > > Make

Re: Review Request 129298: RFC: supporting dependencies on KPackage

2016-11-01 Thread Dan Leinir Turthra Jensen
I don't think it should be server-dependent. If anything, if the user > changes the contents server, it might not find the component. > > Dan Leinir Turthra Jensen wrote: > Hmm... a knsrc points to a providers file, which in turn can hold more > than one provider. The providers in

Re: Review Request 129642: Introduce org.kde.kconfig QML import with KAuthorized

2016-12-14 Thread Dan Leinir Turthra Jensen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129642/#review101438 --- Ship it! Ship It! - Dan Leinir Turthra Jensen On Dec

Re: Review Request 129654: Introduce the resource name in the knsrc file

2016-12-16 Thread Dan Leinir Turthra Jensen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129654/#review101473 --- Ship it! Ship It! - Dan Leinir Turthra Jensen On Dec

[Differential] [Accepted] D4121: add support for display_name in categories

2017-01-13 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. This being an extension of ocs, we will need to prepare a proposal of this at some point in the not too far distant future. However, as other things (tags etc) are also going to be

[Differential] [Accepted] D4120: add support for display_name in categories

2017-01-13 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. We will need to consider the implications of adding functionality into ocs, but technically this would be fine. REPOSITORY R304 KNewStuff BRANCH phab/displayname REVISION DETAIL

[Differential] [Accepted] D4048: Support some of the KNSCore questions using notifications

2017-01-10 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. That works, yup :) REPOSITORY R252 Framework Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D4048 EMAIL PREFERENCES

Re: Review Request 129628: knewstuff - install missing headers

2016-12-19 Thread Dan Leinir Turthra Jensen
you very much for pointing out it existed! i've finally got around to sorting it, and things should now be working much more as they are supposed to if you do a pull from master. - Dan Leinir Turthra Jensen On Dec. 9, 2016, 1:28 a.m., José Manuel Santamaría Lema wrote

Re: Review Request 129660: Fix set up of the KNSCore::Engine when created with an absolute config file path

2016-12-16 Thread Dan Leinir Turthra Jensen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129660/#review101475 --- Ship it! Ship It! - Dan Leinir Turthra Jensen On Dec

D5402: always close the downloaded file after downloading

2017-04-12 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Yes, good catch. I am unsure of why that happened, but i quite agree, that certainly needs to happen whether or not a redirection has been involved. REPOSITORY R304 KNewStuff BRANCH

D5003: Update docs to Frameworks API

2017-03-10 Thread Dan Leinir Turthra Jensen
leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. Thinking this is... well under way, with a couple of details :) INLINE COMMENTS > kauthactionreply.h:338 > -* > -* In case of errors coming from the library, the type() is > -*

D5003: Update docs to Frameworks API

2017-03-13 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. That looks about right to me! :) REPOSITORY R283 KAuth BRANCH docs REVISION DETAIL https://phabricator.kde.org/D5003 To: jriddell, leinir Cc: #frameworks

D5001: Add support for killing a KAuth::ExecuteJob

2017-03-13 Thread Dan Leinir Turthra Jensen
leinir closed this revision. leinir added a comment. Closed by commit https://commits.kde.org/kauth/39621f485f434fb4453a1fd6af2796cde23eec53 REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D5001 To: leinir, #frameworks, jriddell Cc: jriddell

D5001: Add support for killing a KAuth::ExecuteJob

2017-03-10 Thread Dan Leinir Turthra Jensen
leinir created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY This implements the standard method for stopping a KJob in KAuth::ExecuteJob. It is done using a minimal-intrusion approach, and is supposed to feel familiar to people already used to working

D6492: Also use m_currentRequest when checking for installed and updates

2017-07-04 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. That is indeed a very good point. I think we might possibly have an issue here, though, in that since these two searches are no longer stand-alone, if the filter is not explicitly reset

D6492: Also use m_currentRequest when checking for installed and updates

2017-07-04 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Different approach, but yeah, telling people what'll actually happen works :) REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D6492 To: apol,

D6492: Also use m_currentRequest when checking for installed and updates

2017-07-04 Thread Dan Leinir Turthra Jensen
leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. derp, not accepted, my bad... REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6492 To: apol, #frameworks, leinir

D5902: Expand KNewStuff documentation

2017-06-27 Thread Dan Leinir Turthra Jensen
leinir added inline comments. INLINE COMMENTS > apol wrote in README.md:35 > Still it shouldn't be looked-for, should it? It still need to be found before you can set it as runtime (unless i am fundamentally misunderstanding something of course) - like how it's done in Discover... or am i

D6512: Add support for proposed tags addition in OCS 1.7

2017-07-05 Thread Dan Leinir Turthra Jensen
leinir created this revision. leinir added a project: KDE Store. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This patch is to add support for the proposed addition of tags to the OCS standard version 1.7, as seen

D6513: Add support for Attica tags support

2017-07-05 Thread Dan Leinir Turthra Jensen
leinir created this revision. leinir added a project: KNewStuff. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This is to add support for the new tags support in Attica found in https://phabricator.kde.org/D6512,

D6512: Add support for proposed tags addition in OCS 1.7

2017-07-05 Thread Dan Leinir Turthra Jensen
leinir added a dependent revision: D6513: Add support for Attica tags support. REPOSITORY R235 Attica REVISION DETAIL https://phabricator.kde.org/D6512 To: leinir, #knewstuff, apol, whiting, #kde_store Cc: #kde_store, #frameworks, ZrenBot, akiraohgaki, alexanderschmidt, siyuandong,

D6512: Add support for proposed tags addition in OCS 1.7

2017-07-05 Thread Dan Leinir Turthra Jensen
leinir added a comment. In https://phabricator.kde.org/D6512#121834, @apol wrote: > +1 looks sensible to me. Sweet :) > What's the OCS state in this regard? When will 1.7 be a thing? OCS 1.7 will be a thing hopefully in the not too distant future... Incidentally, i need

D6532: When requesting from the cache, report all entries at bulk

2017-07-07 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Hmm... i was thinking this //could// cause issues, i don't see anywhere assumptions are made about page size on the consumption side (damn we're lucky this whole split thing's so new ;) ).

D5587: Improvements

2017-04-26 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Looks good to me :) REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D5587 To: apol, #frameworks, leinir

D5639: Internal cache for provider data on initialisation

2017-04-28 Thread Dan Leinir Turthra Jensen
leinir created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This is a two layer approach to creating less network traffic when initialising a KNSCore::Engine: - Firstly, cache the xml documents

D5638: Use a single QNAM (and a disk cache) for HTTP jobs

2017-04-28 Thread Dan Leinir Turthra Jensen
leinir created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Use a single QNetworkAccessManager instance for all our HTTP jobs, and also add a simple diskcache to that qnam. Further ensure there is

D7194: Detach before setting the d pointer

2017-08-23 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Ah, yes, good catch :) REPOSITORY R304 KNewStuff BRANCH detach REVISION DETAIL https://phabricator.kde.org/D7194 To: apol, leinir Cc: broulik, #frameworks

D7190: Don't complain the knsregistry file is not present before it's useful

2017-08-23 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Good call, yes - gets rid of a lump of irrelevant and technically correct but subjectively incorrect information. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL

D5811: Improve error notification

2017-05-11 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. lgtm :) REPOSITORY R235 Attica BRANCH master REVISION DETAIL https://phabricator.kde.org/D5811 To: apol, #frameworks, leinir

D5638: Use a single QNAM (and a disk cache) for HTTP jobs

2017-05-11 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R304:b8d0bc8818ff: Use a single QNAM (and a disk cache) for HTTP jobs (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5638?vs=14244=14404

D5639: Internal cache for provider data on initialisation

2017-05-11 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R304:6207a87b71d7: Internal cache for provider data on initialisation (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5639?vs=14243=14403

D5902: Expand KNewStuff documentation

2017-05-18 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 14660. leinir marked 2 inline comments as done. REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5902?vs=14634=14660 REVISION DETAIL https://phabricator.kde.org/D5902 AFFECTED FILES README.md src/core/engine.h

D5902: Expand KNewStuff documentation

2017-05-18 Thread Dan Leinir Turthra Jensen
leinir marked 2 inline comments as done. leinir added inline comments. INLINE COMMENTS > apol wrote in README.md:30 > I'd say that it looks better to have `CONFIG` rather than `NO_MODULE`. Both > should work. > > Also `find_package(KF5 COMPONENTS NewStuffCore)` reads better to my eye. It

D5902: Expand KNewStuff documentation

2017-05-17 Thread Dan Leinir Turthra Jensen
leinir created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Add mention of KNewStuffCore and KNewStuffQuick to the base documentation, and expand the API documentation to mention some of the new

D5902: Expand KNewStuff documentation

2017-05-17 Thread Dan Leinir Turthra Jensen
leinir added a reviewer: KNewStuff. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D5902 To: leinir, #knewstuff Cc: #frameworks

D6190: Expose and use Engine's page size variable

2017-06-12 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 15377. leinir added a comment. Don't const & an int, that's just silly. REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6190?vs=15373=15377 REVISION DETAIL https://phabricator.kde.org/D6190 AFFECTED FILES

D6190: Expose and use Engine's page size variable

2017-06-12 Thread Dan Leinir Turthra Jensen
leinir created this revision. leinir added a project: KNewStuff. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Engine has a pageSize variable which has been mostly unused, but which comes in very handy when getting

D6190: Expose and use Engine's page size variable

2017-06-12 Thread Dan Leinir Turthra Jensen
leinir added a comment. As far as i can gather, it was simply never added because, well, it was never used in a lot of places... This really is more a case of equalising some features between requestData and other parts of the engine (so they can all be paginated by the size they really

D6340: Fix incorrect error detection for missing knsrc files

2017-06-22 Thread Dan Leinir Turthra Jensen
leinir created this revision. leinir added a project: KNewStuff. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This fixes the error detection for knsrc files, which previously would report missing files only if the

D6340: Fix incorrect error detection for missing knsrc files

2017-06-23 Thread Dan Leinir Turthra Jensen
leinir marked an inline comment as done. leinir added inline comments. INLINE COMMENTS > apol wrote in engine.cpp:130 > are you sure the `endl` is necessary? i am, in fact, reasonably certain it is not required - leftovers are fun, i'll get rid of that :) REPOSITORY R304 KNewStuff REVISION

D6340: Fix incorrect error detection for missing knsrc files

2017-06-23 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. leinir marked an inline comment as done. Closed by commit R304:eb2e65a882f0: Fix incorrect error detection for missing knsrc files (authored by leinir). CHANGED PRIOR TO COMMIT

D6049: Extend unittests to test stable sort.

2017-06-05 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Sorting correctness (and more thorough testing) is good, yes. LGTM! :) As to the missing arcconfig... will need someone to produce one of those who actually uses arc to fix that ;)

D6104: Use the right scope for the installpath variable

2017-06-06 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Personally less fond of auto than you are... But, that is just me, and this is a framework, and it's fine :) A massive reduction in allocations is a very good thing, go for it :)

D6067: Make it possible to use QXmlStreamReader to read a KNS registry file

2017-06-06 Thread Dan Leinir Turthra Jensen
leinir added a comment. On a similar note to handling comments, how does it now handle unknown/garbage tags? While it won't affect the cache code, it would potentially affect other things (ocs is not guaranteed to be perfectly formed, and it's one of the ways the framework's retained

D6190: Expose and use Engine's page size variable

2017-06-14 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R304:2f8580b9e604: Expose and use Engine's page size variable (authored by leinir). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6190?vs=15377=15443#toc REPOSITORY R304 KNewStuff CHANGES

D5638: Use a single QNAM (and a disk cache) for HTTP jobs

2017-05-07 Thread Dan Leinir Turthra Jensen
leinir marked 4 inline comments as done. leinir added inline comments. INLINE COMMENTS > dfaure wrote in httpworker.cpp:41 > 0.1% of the partition size is a rather arbitrary value, no? It could go from > something very tiny to something really big... > > On my 470GB partition this would lead

D5639: Internal cache for provider data on initialisation

2017-05-07 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 14243. leinir added a comment. Static var naming change, for consistency and whatnot REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5639?vs=14236=14243 REVISION DETAIL https://phabricator.kde.org/D5639 AFFECTED

D5639: Internal cache for provider data on initialisation

2017-05-07 Thread Dan Leinir Turthra Jensen
leinir added inline comments. INLINE COMMENTS > dfaure wrote in engine.cpp:58 > The uppercase first letter on variable name is unusual. > > I personally use a s_ prefix for static vars. Hmm. Right, there is no established way of naming them in KNS already, so while i am not personally so keen

D5638: Use a single QNAM (and a disk cache) for HTTP jobs

2017-05-07 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 14244. leinir added a comment. Work some numbers a bit REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5638?vs=14242=14244 REVISION DETAIL https://phabricator.kde.org/D5638 AFFECTED FILES

D5638: Use a single QNAM (and a disk cache) for HTTP jobs

2017-05-07 Thread Dan Leinir Turthra Jensen
leinir marked 2 inline comments as done. leinir added inline comments. INLINE COMMENTS > dfaure wrote in httpworker.cpp:41 > 50 bytes? isn't that a bit small? :) Yes, yes it is ;) > dfaure wrote in httpworker.cpp:57 > the uppercase first letter is weird, for a variable. Good point, yes. Not

D5639: Internal cache for provider data on initialisation

2017-05-07 Thread Dan Leinir Turthra Jensen
leinir marked 3 inline comments as done. leinir added inline comments. INLINE COMMENTS > dfaure wrote in engine.cpp:206 > This connect (and the following) could be done outside of the if/else, so > avoid being repeated, no? > Or is there a risk that load() will emit those signals immediately?

D5638: Use a single QNAM (and a disk cache) for HTTP jobs

2017-05-07 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 14235. leinir marked an inline comment as done. leinir added a comment. Some style fixes, and set a reasonable maximum size for the cache REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5638?vs=14146=14235 REVISION

D5639: Internal cache for provider data on initialisation

2017-05-07 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 14236. leinir marked an inline comment as done. leinir added a comment. Simplify the xmlloader cache logic a touch REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5639?vs=14080=14236 REVISION DETAIL

D5739: Improve some error messages

2017-05-07 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D5739 To: apol, #frameworks, whiting, leinir

D5638: Use a single QNAM (and a disk cache) for HTTP jobs

2017-05-07 Thread Dan Leinir Turthra Jensen
leinir added a comment. In https://phabricator.kde.org/D5638#107645, @dfaure wrote: > 5 is 50kB. > You wrote 50 megs which would be 5000 or 50*1024*1024. Yes, i certainly did. I should remember to drink less caffeine sometimes. REPOSITORY R304 KNewStuff REVISION

D5639: Internal cache for provider data on initialisation

2017-05-02 Thread Dan Leinir Turthra Jensen
leinir added a comment. In https://phabricator.kde.org/D5639#105620, @apol wrote: > Won't caching already fix the problem of traffic there? This change adds quite some complexity (all these QMutex make me cringe, these methods should always be called from the same thread anyway...)

D5638: Use a single QNAM (and a disk cache) for HTTP jobs

2017-05-05 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 14146. leinir marked 2 inline comments as done. leinir added a comment. Unpointerify the internals, as agreed REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5638?vs=14079=14146 REVISION DETAIL

D5638: Use a single QNAM (and a disk cache) for HTTP jobs

2017-05-02 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 14079. leinir marked an inline comment as done. leinir added a comment. Simpler logic, with the global qnam (etc) stored in a locally defined class, so we only have the one global static, and also allowing the qnam access to be more pleasantly locked.

D5638: Use a single QNAM (and a disk cache) for HTTP jobs

2017-05-02 Thread Dan Leinir Turthra Jensen
leinir marked an inline comment as done. leinir added inline comments. INLINE COMMENTS > apol wrote in httpworker.cpp:33 > How about getting a class with these 3 attributes? Looks like we're juggling > here... You know, that sounds like a good plan. Updated diff incoming :) REPOSITORY R304

D5639: Internal cache for provider data on initialisation

2017-05-02 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 14080. leinir edited the summary of this revision. leinir added a comment. Simplify the logic, and only do the xmlloader caching, not the documents themselves which (as apol points out) should be cached already anyway. Not only that, but that codepath was

D6067: Make it possible to use QXmlStreamReader to read a KNS registry file

2017-06-06 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. In https://phabricator.kde.org/D6067#114528, @apol wrote: > In https://phabricator.kde.org/D6067#114498, @leinir wrote: > > > On a similar note to handling comments, how does it now

D5902: Expand KNewStuff documentation

2017-06-27 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 15908. leinir added a comment. Add/fix a whole bunch of more documentation, identified as missing (or incorrect) by Aniketh REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5902?vs=14660=15908 REVISION DETAIL

D8311: Require the same internal version as you're building

2017-10-15 Thread Dan Leinir Turthra Jensen
leinir created this revision. leinir added a reviewer: KNewStuff. leinir added a project: KNewStuff. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Previously the KNewStuff sub-frameworks would require the dependency

D8111: Require Kirigami 2.1 instead of 1.0 for KNewStuffQuick

2017-10-02 Thread Dan Leinir Turthra Jensen
leinir created this revision. leinir added a reviewer: KNewStuff. leinir added a project: KNewStuff. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This reduces the amount of things which require the by now quite out

D8111: Require Kirigami 2.1 instead of 1.0 for KNewStuffQuick

2017-10-02 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R304:aad1ca02f183: Require Kirigami 2.1 instead of 1.0 for KNewStuffQuick (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8111?vs=20248=20251

D9018: Don't cause circular linking on Windows

2017-11-27 Thread Dan Leinir Turthra Jensen
leinir created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY When building plugins, don't arbitrarily rename the output files (as this will occasionally result in circular dependencies). In this

D9018: Don't cause circular linking on Windows

2017-11-27 Thread Dan Leinir Turthra Jensen
leinir added a reviewer: Frameworks. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D9018 To: leinir, #frameworks Cc: #frameworks

D9012: Revert "Detach before setting the d pointer"

2017-11-27 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH unbreakEntryInternalDataSyncing REVISION DETAIL https://phabricator.kde.org/D9012 To: kossebau, whiting, leinir, apol Cc: #frameworks

D9012: Revert "Detach before setting the d pointer"

2017-11-27 Thread Dan Leinir Turthra Jensen
leinir added a comment. Quicker is better here, i think... Perhaps it is worth adding the documentation we discussed as well in this review? Thinking about making it easier to track the history and whatnot of what happened and why... REPOSITORY R304 KNewStuff REVISION DETAIL

D9018: Don't cause circular linking on Windows

2017-11-28 Thread Dan Leinir Turthra Jensen
leinir added a comment. In https://phabricator.kde.org/D9018#172789, @alexeymin wrote: > So it resulted in something like aspell.dll requiring aspell.dll? Exactly that, yes... took me running it through Dependency Walker to work out what was going on :P > What is the

D8311: Require the same internal version as you're building

2017-12-18 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R304:e33d06f9857a: Require the same internal version as youre building (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8311?vs=20791=24076

D9398: Fix TagLib detection and build on Windows

2017-12-18 Thread Dan Leinir Turthra Jensen
leinir added a reviewer: Frameworks. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D9398 To: leinir, #frameworks

D9018: Don't cause circular linking on Windows

2017-12-19 Thread Dan Leinir Turthra Jensen
leinir added a comment. Would it be possible to get an accept here, or is there something people fundamentally disagree with about it? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D9018 To: leinir, #frameworks Cc: vonreth, cgiboudeaux, alexeymin, apol, #frameworks

D9018: Don't cause circular linking on Windows

2017-12-20 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R246:bdc6562faf73: Dont cause circular linking on Windows (authored by leinir). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9018?vs=23028=24150 REVISION DETAIL

D9421: Remove anchient and broken workaround

2017-12-20 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. Ha, yes, i concur with Aleix there, workaround-be-gone! ;) (i have a suspicion the reason i thought this worked before is because i was testing on my local machine... which also explains nicely why the packages from BF don't have

D8811: [knewstuff] Do not leak ImageLoader on error

2017-11-16 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Looks good to me :) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D8811 To: anthonyfieroni, leinir, dfaure Cc: broulik, #frameworks, ZrenBot

D8811: [knewstuff] Do not leak ImageLoader on error

2017-11-15 Thread Dan Leinir Turthra Jensen
leinir added inline comments. INLINE COMMENTS > engine.cpp:536 > +connect(l, ::signalError, this, [=]() { > +qCDebug(KNEWSTUFFCORE) << "ERROR preview: " << entry.name() << type; > +--m_numPictureJobs; A more descriptive error message would be good, but this is already an

D8811: [knewstuff] Do not leak ImageLoader on error

2017-11-15 Thread Dan Leinir Turthra Jensen
leinir added inline comments. INLINE COMMENTS > anthonyfieroni wrote in engine.cpp:536 > Job can be nullptr, so signal can be a text, it can capture entry by > reference? i guess you could extend the signal further with the error text added in instead of capturing l in the lambda, yes

D8811: [knewstuff] Do not leak ImageLoader on error

2017-11-15 Thread Dan Leinir Turthra Jensen
leinir added inline comments. INLINE COMMENTS > engine.cpp:536 > +connect(l, ::signalError, this, [this, l](const > KNSCore::EntryInternal , EntryInternal::PreviewType type) { > +qCDebug(KNEWSTUFFCORE) << "ERROR preview: " << entry.name() << type; > +--m_numPictureJobs; You

D7194: Detach before setting the d pointer

2017-10-25 Thread Dan Leinir Turthra Jensen
leinir added a subscriber: sitter. leinir added a comment. Damn... Well spotted, @kossebau. Right, so immediate (at least temporary solution) to make things not broken would annoyingly enough be to revert the patch, yes... I am now thinking that another oddity noticed by @sitter last week

D13515: Remove KNS::Engine d-pointer hack

2018-06-13 Thread Dan Leinir Turthra Jensen
leinir added a comment. H... this is tricky, but... yes, it seems reasonable to me that replacing one pointer with another would cause no BIC issues... and i certainly am happy to get rid of the d-pointer hack, so... if we're absolutely super-sure that this is BC, i'm all for it...

D6513: Add support for Attica tags support

2018-07-02 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 37047. leinir edited the summary of this revision. leinir edited the test plan for this revision. leinir added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. - add test tool - add support for

D6513: Add support for Attica tags support

2018-07-02 Thread Dan Leinir Turthra Jensen
leinir added a comment. Test tool using the default settings, and with QT__LOGGING_RULES="org.kde.knewstuff.*=true" F5998853: image.png REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6513 To: leinir, #knewstuff, apol,

D13714: Fix broken url to API specification

2018-06-25 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. This revision is now accepted and ready to land. REPOSITORY R235 Attica BRANCH master REVISION DETAIL https://phabricator.kde.org/D13714 To: habacker, mlaurent, leinir Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13733: Add provider auto test

2018-06-26 Thread Dan Leinir Turthra Jensen
leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. Autotests are good, but so is documentation - in principle this is good, but new public functions without documentation isn't really acceptable :) Apart from that, though, looks

D13743: Migrate build system to use find_package in autotests/ki18n_install

2018-06-27 Thread Dan Leinir Turthra Jensen
leinir added a comment. This seems quite sensible to me, a cleanup and simplification of the test build system is not bad... That said, i'm unsure why you think i'm qualified to speak about ki18n and the general cmake build system to a level high enough that you highlight me

D13732: Add debug output for all network requests

2018-06-27 Thread Dan Leinir Turthra Jensen
leinir requested changes to this revision. leinir added a comment. This revision now requires changes to proceed. Straight-up qDebug would cause quite a lot of spam... I'd be much happier if this was done using qCDebug (which is already used in other parts of the code, so just need to

D13733: Add provider auto test

2018-06-27 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. This revision is now accepted and ready to land. REPOSITORY R235 Attica BRANCH master REVISION DETAIL https://phabricator.kde.org/D13733 To: habacker, leinir Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D7194: Detach before setting the d pointer

2017-10-27 Thread Dan Leinir Turthra Jensen
leinir added a comment. This already went into one release, and it would be quite useful to get it sorted before the next one rolls around, and the consensus seems to be reverting, as leaving kns with this patch in has some fairly unfortunate side effects. Could we get it reverted before

D8188: Remove PreferCache from network requests

2017-10-27 Thread Dan Leinir Turthra Jensen
leinir accepted this revision. leinir added a comment. This revision is now accepted and ready to land. Right, yes, i think that was a bit of left over from working on it all. Go for it. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D8188 To:

D10017: Find Aspell dictionaries on Windows

2018-01-22 Thread Dan Leinir Turthra Jensen
leinir created this revision. leinir added a reviewer: vonreth. leinir added a project: Frameworks. Restricted Application added a subscriber: Frameworks. leinir requested review of this revision. REVISION SUMMARY This feeds the sonnet aspell plugin some information to assist it in locating

D6513: Add support for Attica tags support

2018-07-26 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 38489. leinir marked 4 inline comments as done. leinir added a comment. Address ahiemstra's comments REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6513?vs=37047=38489 REVISION DETAIL

D6513: Add support for Attica tags support

2018-07-26 Thread Dan Leinir Turthra Jensen
leinir marked 7 inline comments as done. leinir added inline comments. INLINE COMMENTS > ahiemstra wrote in atticaprovider.cpp:283 > Wouldn't it be simpler to first check if the content should be considered at > all, and then check if one of the downloads is valid? So something like: > >

D6513: Add support for Attica tags support

2018-08-01 Thread Dan Leinir Turthra Jensen
leinir added a comment. @mlaurent quick ping? :) Also in general, sorry, would really like to get this merged in asap - i realise it's the summer holidays for a lot of people ;) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6513 To: leinir, #knewstuff,

D6513: Add support for Attica tags support

2018-07-26 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 38506. leinir marked an inline comment as done. leinir added a comment. Address mlaurent's comments REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6513?vs=38489=38506 REVISION DETAIL

  1   2   3   4   5   6   >