D16677: Add BrightScript syntax

2018-11-05 Thread Daniel Levin
dlevin added a comment. There are various reasons I was using 1-element keyword lists instead of StringDetect: 1. keyword properly recognizes value surrounded by non-word characters, StringDetect does not. 2. BrightScript language is case insensitive, adding insensitive="true" to

D16677: Add BrightScript syntax

2018-11-04 Thread Daniel Levin
dlevin updated this revision to Diff 44885. dlevin added a comment. Changed syntax license to MIT. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16677?vs=44881=44885 REVISION DETAIL https://phabricator.kde.org/D16677 AFFECTED FILES

D16677: Add BrightScript syntax

2018-11-09 Thread Daniel Levin
dlevin added a comment. @ngraham, so I have to match commit authors in syntax-highlighting Git project against that list? Curious whether all those people have rights to push patches particularly into this project. Still it feels like this is not an easy task to do that manually, so I would

D16677: Add BrightScript syntax

2018-11-09 Thread Daniel Levin
dlevin added a comment. Thanks a lot for helping me with this! One last question: how do I know that patch was finally merged, by periodically checking the github mirror git repository? https://github.com/KDE/syntax-highlighting.git REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D16677: Add BrightScript syntax

2018-11-10 Thread Daniel Levin
dlevin added a comment. You can find my credentials at the beginning of the file I added in this patch: data/syntax/brightscript.xml REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D16677 To: dlevin, #framework_syntax_highlighting, cullmann Cc: ngraham,

D16677: Add BrightScript syntax

2018-11-08 Thread Daniel Levin
dlevin added a comment. Just double checking whether any additional actions required from my side or 'landing' a patch means it will be a part of the next release automatically. If so then where I could find a release roadmap? Thanks in advance! REPOSITORY R216 Syntax Highlighting

D16677: Add BrightScript syntax

2018-11-10 Thread Daniel Levin
dlevin updated this revision to Diff 45260. dlevin added a comment. Replaced missing "code" attribute with "g". CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16677?vs=44885=45260 REVISION DETAIL https://phabricator.kde.org/D16677 AFFECTED FILES

D16677: Add BrightScript syntax

2018-11-10 Thread Daniel Levin
dlevin added a comment. Thanks for catching this. Did re-run tests locally, seems no other issue remaining. Please check. REVISION DETAIL https://phabricator.kde.org/D16677 To: dlevin, #framework_syntax_highlighting, cullmann Cc: ngraham, dhaumann, cullmann, kwrite-devel,

D16677: Add BrightScript syntax

2018-11-09 Thread Daniel Levin
dlevin added a comment. I do not have a KDE commit account, so I guess I need your help to integrate this patch. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D16677 To: dlevin, #framework_syntax_highlighting, cullmann Cc: dhaumann, cullmann,

D16677: Add BrightScript syntax

2018-11-04 Thread Daniel Levin
dlevin created this revision. dlevin added a reviewer: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dlevin requested review of this revision. REVISION SUMMARY Accurate implementation of BrightScript

D17522: BrightScript: Add workaround for QtCreator 'endsub' highlighting

2018-12-12 Thread Daniel Levin
dlevin added a comment. Yeah, this might be another bug in the QtCreator (already fixed one crash in their highlighting implementation). They asked me to not put much effort because that code it deprecated anyway in favor or KDE lib. But they just released Creator 4.8.0 and I do not expect

D17436: BrightScript: Remove unused keyword list 'end'

2018-12-10 Thread Daniel Levin
dlevin added a comment. Thanks for the fix, yes it is valid. Previously "end" was used as a standalone keyword, but keyword requires space after the word. Now it used in StringDetect to detect cases like "end sub" and "endsub" in the same rule. REPOSITORY R216 Syntax Highlighting

D17522: BrightScript: Add workaround for QtCreator 'endsub' highlighting

2018-12-11 Thread Daniel Levin
dlevin created this revision. dlevin added a reviewer: cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dlevin requested review of this revision. REVISION SUMMARY QtCreator requires that keyword should be wrapped with white spaces

D17204: BrightScript: Allow sub to be unnamed

2018-11-30 Thread Daniel Levin
dlevin added a comment. This language does not have folding test. I did not provide validation for it before. Should I do that? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17204 To: dlevin, cullmann Cc: dfaure, kwrite-devel, kde-frameworks-devel,

D17295: BrightScript: Add function/sub folding

2018-12-01 Thread Daniel Levin
dlevin updated this revision to Diff 46667. dlevin added a comment. Increased version number. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17295?vs=4=46667 REVISION DETAIL https://phabricator.kde.org/D17295 AFFECTED FILES

D17295: BrightScript: Add function/sub folding

2018-12-01 Thread Daniel Levin
dlevin created this revision. dlevin added a reviewer: cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dlevin requested review of this revision. REVISION SUMMARY Global and local function folding, including closures. REPOSITORY

D17204: BrightScript: Allow sub to be unnamed

2018-11-27 Thread Daniel Levin
dlevin created this revision. dlevin added a reviewer: cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dlevin requested review of this revision. REVISION SUMMARY Subs and functions could be unnamed in closures. REPOSITORY R216

D17204: BrightScript: Allow sub to be unnamed

2018-11-27 Thread Daniel Levin
dlevin updated this revision to Diff 46371. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17204?vs=46369=46371 REVISION DETAIL https://phabricator.kde.org/D17204 AFFECTED FILES autotests/html/brightscript.brs.html

D17204: BrightScript: Allow sub to be unnamed

2018-11-27 Thread Daniel Levin
dlevin added a comment. Thanks for the review. Btw, is there any chance to preserve my name/email in the final commit? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D17204 To: dlevin, cullmann Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh,

D19198: BrightScript: Unary and hex numbers, @attribute

2019-02-21 Thread Daniel Levin
dlevin created this revision. dlevin added a reviewer: cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. dlevin requested review of this revision. REVISION SUMMARY Fixed small issues for rvalue highlighting: - Unary numbers,

D19198: BrightScript: Unary and hex numbers, @attribute

2019-02-21 Thread Daniel Levin
dlevin added a comment. Thanks for cleaning up the tests after me! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19198 To: dlevin, cullmann Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann