Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator

2013-09-06 Thread David Edmundson
., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/ --- (Updated Aug. 27, 2013, 9:21 p.m.) Review

Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator

2013-09-06 Thread David Edmundson
(updated) - tier1/sonnet/src/ui/spellcheckdecorator.h 5ded08d tier1/sonnet/src/ui/spellcheckdecorator.cpp 7299966 Diff: http://git.reviewboard.kde.org/r/112281/diff/ Testing --- None - my KF5 setup has no dictionaries installed. Thanks, David Edmundson

Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator

2013-09-06 Thread David Edmundson
7299966 Diff: http://git.reviewboard.kde.org/r/112281/diff/ Testing --- None - my KF5 setup has no dictionaries installed. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Review Request 112583: Steps to make KConfigWidgets compile Standalone

2013-09-07 Thread David Edmundson
/kwidgetsaddons/src/kselectaction.h 07afaa960d2be4877aeef0ff074d0fd20c7b7f40 tier1/kwidgetsaddons/src/kselectaction.cpp b388df94baa042e8230f2795f35dd378117c6ab6 Diff: http://git.reviewboard.kde.org/r/112583/diff/ Testing --- Thanks, David Edmundson

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

2013-09-10 Thread David Edmundson
--- On Sept. 7, 2013, 7:45 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112583

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

2013-09-11 Thread David Edmundson
8b3cc8f82b248cc9ed8a1f1be69cf4160f97378c tier1/kwidgetsaddons/src/kselectaction.h 07afaa960d2be4877aeef0ff074d0fd20c7b7f40 tier1/kwidgetsaddons/src/kselectaction.cpp 3aa079731cd19ccad4f6a6344ebe5d6921d0bd7e Diff: http://git.reviewboard.kde.org/r/112583/diff/ Testing --- Thanks, David

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

2013-09-11 Thread David Edmundson
8b3cc8f82b248cc9ed8a1f1be69cf4160f97378c tier1/kwidgetsaddons/src/kselectaction.h 07afaa960d2be4877aeef0ff074d0fd20c7b7f40 tier1/kwidgetsaddons/src/kselectaction.cpp 3aa079731cd19ccad4f6a6344ebe5d6921d0bd7e Diff: http://git.reviewboard.kde.org/r/112583/diff/ Testing --- Thanks, David

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

2013-09-11 Thread David Edmundson
e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112583/#review39840 --- On Sept. 11, 2013, 2:55 p.m., David Edmundson wrote: --- This is an automatically generated e-mail

Review Request 112673: Expose setStandardActionNames as public API in kacceleratormanager

2013-09-11 Thread David Edmundson
--- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112759: sonnet - improve dependencies

2013-09-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112759/#review40163 --- Ship it! Ship It! - David Edmundson On Sept. 16, 2013, 4

Re: Review Request 112583: Steps to make KConfigWidgets compile Standalone

2013-09-16 Thread David Edmundson
/kwidgetsaddons/src/kselectaction.cpp 3aa0797 Diff: http://git.reviewboard.kde.org/r/112583/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 112825: DNSSD: Adopt modules directory structure

2013-09-20 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112825/#review40391 --- Ship it! Ship It! - David Edmundson On Sept. 20, 2013, 3

Re: Review Request 112882: Split remaining KUtils into kcmutils and kprintutils

2013-09-24 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112882/#review40532 --- On Sept. 24, 2013, 12:22 p.m., David Edmundson wrote

Review Request 112918: Add index argument to KWidgetItemDelegate::createItemWidgets

2013-09-24 Thread David Edmundson
e9bbcad0b030c8d03fadeb6635bfa0d69d996ac9 tier1/itemviews/src/kwidgetitemdelegate.h b874c10e9a7ab9ee9bf756ae82ce99bd64ec92d1 Diff: http://git.reviewboard.kde.org/r/112918/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 112918: Add index argument to KWidgetItemDelegate::createItemWidgets

2013-09-24 Thread David Edmundson
, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112918: Add index argument to KWidgetItemDelegate::createItemWidgets

2013-09-24 Thread David Edmundson
cfca1f9ae3df9bec1e8a570f03b5256cc935e8bb Diff: http://git.reviewboard.kde.org/r/112918/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Review Request 112923: Make leftMargin rightMargin virtual methods in KCategoryDrawer

2013-09-24 Thread David Edmundson
tier1/itemviews/src/kcategorydrawer.h 3665457 tier1/itemviews/src/kcategorydrawer.cpp 0fb857e Diff: http://git.reviewboard.kde.org/r/112923/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 112900: Prepare KDNSSD for moving

2013-09-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112900/#review40739 --- Ship it! Ship It! - David Edmundson On Sept. 24, 2013, 11

Re: Review Request 112919: Prepare KParts for the move

2013-09-25 Thread David Edmundson
://git.reviewboard.kde.org/r/112919/#comment29973 nope. KPARTS - David Edmundson On Sept. 24, 2013, 5:21 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 112902: Start cleanup for kdewebkit

2013-09-25 Thread David Edmundson
/112902/#comment29976 again this is not KUNITCONVERSION - David Edmundson On Sept. 24, 2013, 11:19 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112902

Re: Review Request 112902: Start cleanup for kdewebkit

2013-09-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112902/#review40743 --- Ship it! Ship It! - David Edmundson On Sept. 24, 2013, 11

Re: Review Request 112915: Fix kcrash standalone build

2013-09-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112915/#review40758 --- Ship it! Ship It! - David Edmundson On Sept. 24, 2013, 1

Review Request 112932: Update superbuild to include all tiered libraries

2013-09-25 Thread David Edmundson
/CMakeLists.txt 86e3389 Diff: http://git.reviewboard.kde.org/r/112932/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Fwd: Reminder: use KF5::foo instead of ${foo_LIBRARIES} in CMakeLists

2013-09-26 Thread David Edmundson
Is there anything preventing us from using the ALIAS target right now? It's in the git version. The build guide say to get cmake from git. kdesrc-build gets it from git, and build.kde.org uses git latest. I just set KWindowSystem to have an alias and tried building knotifications. It worked

Re: [kdelibs/frameworks] staging/kio/src/widgets: Make KIOWidgets link against KWidgetsAddons as KEditListWidget is used

2013-09-26 Thread David Edmundson
to know to include KWidgetAddons headers not just to implicitly link against it. I'll happily be proved wrong if something else fixes it. Regards David On Thu, Sep 26, 2013 at 10:39 PM, Stephen Kelly steve...@gmail.com wrote: David Edmundson wrote: Make KIOWidgets link against KWidgetsAddons

Review Request 113045: Prepare KCMUtils for move to tier3

2013-10-02 Thread David Edmundson
/src/ksettings/componentsdialog.cpp 111549a staging/kcmutils/src/ksettings/dialog.cpp 131f75f staging/kcmutils/src/ksettings/dispatcher.cpp 48bb0fc staging/kcmutils/src/ksettings/pluginpage.cpp 0577908 Diff: http://git.reviewboard.kde.org/r/113045/diff/ Testing --- Thanks, David

Re: Review Request 113045: Prepare KCMUtils for move to tier3

2013-10-02 Thread David Edmundson
--- On Oct. 2, 2013, 8:06 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113045

Re: Review Request 113045: Prepare KCMUtils for move to tier3

2013-10-02 Thread David Edmundson
I haven't moved anything. Also this review is 3 different commits, one for each of the sentences in the description. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112923: Make leftMargin rightMargin virtual methods in KCategoryDrawer

2013-10-02 Thread David Edmundson
This makes everything consistent. -- This was marked as a KDE5 TODO Diffs - KDE5PORTING.html 57ecf2e tier1/itemviews/src/kcategorydrawer.h 3665457 tier1/itemviews/src/kcategorydrawer.cpp 0fb857e Diff: http://git.reviewboard.kde.org/r/112923/diff/ Testing --- Thanks, David

Review Request 113067: Fix compilation

2013-10-02 Thread David Edmundson
kdelibsLibraryTargets until each library can install itself see http://build.kde.org/job/kdelibs_frameworks_qt5/1317/console Diffs - CMakeLists.txt cdc3120 Diff: http://git.reviewboard.kde.org/r/113067/diff/ Testing --- Thanks, David Edmundson

Re: Review Request 113073: Make KColorSpaces really private

2013-10-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113073/#review41165 --- Ship it! - David Edmundson On Oct. 3, 2013, 9:32 a.m

Re: Review Request 113077: Get Kross ready for tier3

2013-10-03 Thread David Edmundson
://git.reviewboard.kde.org/r/113077/#comment30219 this becomes KrossCoreTargets - David Edmundson On Oct. 3, 2013, 4:09 p.m., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: http

Review Request 113087: Start preparing KHTML for moving

2013-10-03 Thread David Edmundson
khtml/tests/CMakeLists.txt 0a404d5 khtml/tests/testkhtml.qrc 4cfe54b khtml/tests/testkhtmlnew.h e7b7205 khtml/tests/testkhtmlnew.cpp 525c9fd staging/CMakeLists.txt 5c5c80c Diff: http://git.reviewboard.kde.org/r/113087/diff/ Testing --- Thanks, David Edmundson

Review Request 113088: Prepare kpty for moving

2013-10-03 Thread David Edmundson
kpty/kptydevice.cpp kpty/kptyprocess.h kpty/kptyprocess.cpp kpty/src/CMakeLists.txt PRE-CREATION kpty/tests/CMakeLists.txt 1f39830df5e7eacf3b64ea456c1892c62e53fde5 Diff: http://git.reviewboard.kde.org/r/113088/diff/ Testing --- Builds. Thanks, David Edmundson

Re: Review Request 113045: Prepare KCMUtils for move to tier3

2013-10-04 Thread David Edmundson
://git.reviewboard.kde.org/r/113045/#review41196 --- On Oct. 2, 2013, 8:06 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org

Review Request 113090: Move kcmutils to tier4

2013-10-04 Thread David Edmundson
/src/ksettingswidgetadaptor.h staging/kcmutils/src/ksettingswidgetadaptor.cpp tier4/CMakeLists.txt PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113090/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list

Re: Review Request 113090: Move kcmutils to tier4

2013-10-04 Thread David Edmundson
, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113088: Prepare kpty for moving

2013-10-04 Thread David Edmundson
, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113088: Prepare kpty for moving

2013-10-04 Thread David Edmundson
kpty/kptydevice.h kpty/kptydevice.cpp kpty/kptyprocess.h kpty/kptyprocess.cpp kpty/src/CMakeLists.txt PRE-CREATION kpty/tests/CMakeLists.txt 1f39830 Diff: http://git.reviewboard.kde.org/r/113088/diff/ Testing --- Builds. Thanks, David Edmundson

Re: Review Request 113088: Prepare kpty for moving

2013-10-04 Thread David Edmundson
/kptydevice.h kpty/kptydevice.cpp kpty/kptyprocess.h kpty/kptyprocess.cpp kpty/src/CMakeLists.txt PRE-CREATION kpty/tests/CMakeLists.txt 1f39830 Diff: http://git.reviewboard.kde.org/r/113088/diff/ Testing --- Builds. Thanks, David Edmundson

Re: Review Request 113105: Move KWallet to tier2

2013-10-04 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113105/#review41252 --- Ship it! Ship It! - David Edmundson On Oct. 4, 2013, 6:17

Review Request 113110: Move KNotifyConfig to staging

2013-10-04 Thread David Edmundson
/CMakeLists.txt PRE-CREATION staging/knotifyconfig/KNotifyConfigConfig.cmake.in PRE-CREATION staging/knotifyconfig/src/CMakeLists.txt PRE-CREATION staging/knotifyconfig/tests/CMakeLists.txt PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113110/diff/ Testing --- Thanks, David Edmundson

Re: Review Request 113112: Notify about fonts and palette changes

2013-10-04 Thread David Edmundson
/kfontsettingsdata.cpp http://git.reviewboard.kde.org/r/113112/#comment30257 This happens already in QApplication::setFont(); qapplication.cpp:1511 - David Edmundson On Oct. 4, 2013, 11:52 p.m., Aleix Pol Gonzalez wrote

Re: Review Request 113112: Notify about palette changes

2013-10-06 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113112/#review41293 --- Ship it! Ship It! - David Edmundson On Oct. 5, 2013, 12:14

Review Request 113142: Move KPty to tier 3

2013-10-07 Thread David Edmundson
://git.reviewboard.kde.org/r/113142/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113142: Move KPty to tier 3

2013-10-07 Thread David Edmundson
/tests/kptyprocesstest.cpp tier3/CMakeLists.txt 53fe81b Diff: http://git.reviewboard.kde.org/r/113142/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 113087: Start preparing KHTML for moving

2013-10-07 Thread David Edmundson
://git.reviewboard.kde.org/r/113087/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113174: Cleanup KJsEmbed

2013-10-09 Thread David Edmundson
actually build. (see a change stervie did in khtml) - David Edmundson On Oct. 8, 2013, 2:09 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r

Re: Review Request 113173: Reduce warnings noise when including wtf/Platform.h in KJS

2013-10-09 Thread David Edmundson
. - David Edmundson On Oct. 8, 2013, 1:20 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113173

Review Request 113182: Remove all the versioned classes of KCategoryDrawer.

2013-10-09 Thread David Edmundson
tier1/itemviews/tests/kcategorizedviewtest.cpp 116278c Diff: http://git.reviewboard.kde.org/r/113182/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 112932: Update superbuild to include all tiered libraries

2013-10-09 Thread David Edmundson
not be correct. Diffs - tier3/kunitconversion/KUnitConversionConfig.cmake.in 7bbf71c superbuild/CMakeLists.txt 86e3389 Diff: http://git.reviewboard.kde.org/r/112932/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel

Re: Review Request 112932: Update superbuild to include all tiered libraries

2013-10-09 Thread David Edmundson
it. - David Edmundson On Oct. 9, 2013, 5:22 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112932

Re: Review Request 113173: Reduce warnings noise when including wtf/Platform.h in KJS

2013-10-09 Thread David Edmundson
Can we keep all discussions on reviewboard? If you mix replying to the mailing list we lose track of messages very quickly. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113199: KHTML: KComponentData - KAboutData

2013-10-11 Thread David Edmundson
0d16716 khtml/src/khtml_global.cpp 4d7c6ca khtml/src/khtml_part.cpp 6e7f87e khtml/src/khtmlimage.h 9623a2a khtml/src/khtmlimage.cpp a074051 Diff: http://git.reviewboard.kde.org/r/113199/diff/ Testing --- Compiles. Thanks, David Edmundson

Re: Review Request 113199: KHTML: KComponentData - KAboutData

2013-10-11 Thread David Edmundson
/113199/#comment30370 To me, deleting a static member when one instance gets deleted seems rather bad. However, the original code did it and it must have worked so I've left it the same. - David Edmundson On Oct. 11, 2013, 12:16 p.m., David Edmundson wrote

Re: Review Request 113199: KHTML: KComponentData - KAboutData

2013-10-14 Thread David Edmundson
/ Testing --- Compiles. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113182: Remove all the versioned classes of KCategoryDrawer.

2013-10-14 Thread David Edmundson
solution. - David --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113182/#review41679 --- On Oct. 9, 2013, 4:45 p.m., David Edmundson

Re: Review Request 113182: Remove all the versioned classes of KCategoryDrawer.

2013-10-14 Thread David Edmundson
/itemviews/src/kcategorydrawer.h e36197b tier1/itemviews/src/kcategorydrawer.cpp 0e45e23 tier1/itemviews/tests/kcategorizedviewtest.cpp 116278c Diff: http://git.reviewboard.kde.org/r/113182/diff/ Testing --- Thanks, David Edmundson ___ Kde

Review Request 113238: Remove set _LIBRARIES calls in root CMakeLists.txt

2013-10-14 Thread David Edmundson
kio/misc/kpac/CMakeLists.txt 897de8e staging/kio/src/core/CMakeLists.txt 5d75fc9 staging/kio/src/filewidgets/CMakeLists.txt 3790250 Diff: http://git.reviewboard.kde.org/r/113238/diff/ Testing --- compiled Thanks, David Edmundson ___ Kde

Re: Review Request 113238: Remove set _LIBRARIES calls in root CMakeLists.txt

2013-10-14 Thread David Edmundson
--- compiled Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113241: Move khtml java tests into the test directory

2013-10-14 Thread David Edmundson
khtml/src/java/tests/good_sites khtml/src/java/tests/testkjavaappletserver.cpp khtml/tests/CMakeLists.txt 9a742cf Diff: http://git.reviewboard.kde.org/r/113241/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel

Re: Review Request 113241: Move khtml java tests into the test directory

2013-10-14 Thread David Edmundson
--- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113247: Port KCompletion away from KStandardAction

2013-10-14 Thread David Edmundson
/klineedit.cpp 2f70935 Diff: http://git.reviewboard.kde.org/r/113247/diff/ Testing --- Compiled in source Tried compiling standalone (it builds, but has a linker fail on something unrelated) Ran klineedittest and checked combobox was the same. Thanks, David Edmundson

Re: Review Request 113267: Install kglobalshortcutinfo_p.h

2013-10-16 Thread David Edmundson
XML service file using qt5_add_dbus_interface. - David Edmundson On Oct. 16, 2013, 1:56 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113267

Review Request 113301: Move KGlobalShortcutInfo DBus serialisation to a public header

2013-10-17 Thread David Edmundson
- tier3/xmlgui/src/kglobalshortcutinfo.h d1ccd56 tier3/xmlgui/src/kglobalshortcutinfo_p.h 57f2bd5 Diff: http://git.reviewboard.kde.org/r/113301/diff/ Testing --- Built kde-workspace (with a minor change there) Thanks, David Edmundson ___ Kde

Re: Review Request 113301: Move KGlobalShortcutInfo DBus serialisation to a public header

2013-10-17 Thread David Edmundson
change there) Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113247: Port KCompletion away from KStandardAction

2013-10-23 Thread David Edmundson
--- On Oct. 14, 2013, 5:04 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113247

Re: Review Request 113247: Port KCompletion away from KStandardAction

2013-10-23 Thread David Edmundson
klineedittest and checked combobox was the same. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113480: Move KnotifyConfig to tier 3

2013-10-28 Thread David Edmundson
/diff/ Testing --- Went through checklist. Builds. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

KHTML Icons

2013-10-28 Thread David Edmundson
KHtml tries to install icons in src/java/images and src/pics of the khtml src directory. As far as I can tell this has been broken throughout all of KDE4. kde4_install_icons simply ignores .xpm files, so they're just skipped. My main KDE4 install does not have these files. Given it's been broken

Review Request 113483: Copy KDE4 macro to install all icons in the current source dir

2013-10-28 Thread David Edmundson
not test icon installation as khtml was already broken (see other email to KF ML) Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113483: Copy KDE4 macro to install all icons in the current source dir

2013-10-29 Thread David Edmundson
--- Tried using it from within khtml. It all compiled successfully however I could not test icon installation as khtml was already broken (see other email to KF ML) Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 113480: Move KnotifyConfig to tier 3

2013-10-29 Thread David Edmundson
/tests/main.cpp tier3/CMakeLists.txt 2ad3f61 Diff: http://git.reviewboard.kde.org/r/113480/diff/ Testing --- Went through checklist. Builds. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Using KSSLSettings from KHTML

2013-10-29 Thread David Edmundson
Currently KHTMLPart uses KSSLSettings from KIOCore It uses the methods: warnOnUnencrypted setWarnOnUnencrypted This class does not have the header exported in KIOCore, so whilst it builds now it will fail when we split. The CMakeLists.txt file of KIOCore has a comment kssl/ksslsettings.cpp

Review Request 113511: Install KSslSettings header

2013-10-30 Thread David Edmundson
--- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113511: Install KSslSettings header

2013-10-31 Thread David Edmundson
/kssl/ksslsettings.cpp 8fe882c Diff: http://git.reviewboard.kde.org/r/113511/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113522: Improve documentation in ECMInstallIcons.cmake

2013-10-31 Thread David Edmundson
Description --- Improve documentation in ECMInstallIcons.cmake Diffs - modules/ECMInstallIcons.cmake 1114805 Diff: http://git.reviewboard.kde.org/r/113522/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing

Re: Review Request 113522: Improve documentation in ECMInstallIcons.cmake

2013-11-04 Thread David Edmundson
, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113625: Prepare KHTML for moving into tier4.

2013-11-04 Thread David Edmundson
--- Tidy target_link for KHTML. Diffs - khtml/src/CMakeLists.txt ed113f5 khtml/src/java/CMakeLists.txt 3dd2d88 Diff: http://git.reviewboard.kde.org/r/113625/diff/ Testing --- Builds. Thanks, David Edmundson ___ Kde-frameworks

Re: Review Request 113625: Prepare KHTML for moving into tier4.

2013-11-05 Thread David Edmundson
. Repository: kdelibs Description --- Tidy target_link for KHTML. Diffs (updated) - khtml/src/CMakeLists.txt ed113f5 khtml/src/java/CMakeLists.txt 3dd2d88 Diff: http://git.reviewboard.kde.org/r/113625/diff/ Testing --- Builds. Thanks, David Edmundson

Re: Review Request 113625: Prepare KHTML for moving into tier4.

2013-11-05 Thread David Edmundson
. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113821: Don't install kpagedialog_p.h

2013-11-13 Thread David Edmundson
://git.reviewboard.kde.org/r/113821/#comment31313 I don't think this is right. If we copy a KCMultiDialog instance, we wouldn't copy the KPageDialog d variable of the parent object, but instead create a new one. I think this would be a behavioural change. - David Edmundson On Nov. 12, 2013

Re: Review Request 113821: Don't install kpagedialog_p.h

2013-11-13 Thread David Edmundson
On Nov. 13, 2013, 11:53 a.m., David Edmundson wrote: tier4/kcmutils/src/kcmultidialog.cpp, line 262 http://git.reviewboard.kde.org/r/113821/diff/1/?file=213192#file213192line262 I don't think this is right. If we copy a KCMultiDialog instance, we wouldn't copy

Review Request 113970: KConfigDialog: Guard against editing buttons that do not exist.

2013-11-20 Thread David Edmundson
in Plasma2 Diffs - tier3/kconfigwidgets/src/kconfigdialog.cpp 23ed3ee Diff: http://git.reviewboard.kde.org/r/113970/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Reporting bugs against frameworks/plasma2

2013-11-21 Thread David Edmundson
Long term, I disagree with using the version frameworks everywhere. We want to have a split between Frameworks5.0 and Plasma2.0 and they may not be on the same release cycle. That said; you can rename a version in bugzilla with relative ease, and it will 'update' all existing reports. David

Review Request 114158: Use Sonnet::Decorator internally in KTextEdit

2013-11-27 Thread David Edmundson
, there appear to be some issues, such as not showing a context menu until a language is set, but this seems to be independent from this patch. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 114158: Use Sonnet::SpellCheckDecorator internally in KTextEdit

2013-11-27 Thread David Edmundson
://git.reviewboard.kde.org/r/114158/diff/ Testing --- I still have something wrong with my spell checker in KF5: Aurélien tested for me, there appear to be some issues, such as not showing a context menu until a language is set, but this seems to be independent from this patch. Thanks, David Edmundson

Fwd: Tracking bugs in Frameworks

2013-12-16 Thread David Edmundson
On Sat, Dec 14, 2013 at 7:00 PM, Frank Reininghaus frank7...@googlemail.com wrote: Hi, 2013/12/14 David Edmundson: As we gear Frameworks up for release we need a way to track bugs that exist in the new Frameworks. We have two options; either we copy all the bugs in kdelibs, triaging

Re: Fwd: Tracking bugs in Frameworks

2013-12-16 Thread David Edmundson
On Mon, Dec 16, 2013 at 6:08 PM, Martin Graesslin mgraess...@kde.org wrote: On Monday 16 December 2013 11:58:35 David Edmundson wrote: I think if we did that it would be a good idea to prefix the names with a common element like frameworks-coreaddons frameworks-kio etc. I don't think it needs

Review Request 114895: Guard against null QX11Info::connection()

2014-01-07 Thread David Edmundson
://git.reviewboard.kde.org/r/114895/diff/ Testing --- Opened plasmoidviewer -a org.kde.example.widgetgallery expanded the applet, then closed plasmoidviewer It used to crash, now it doesn't. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 114895: Guard against null QX11Info::connection()

2014-01-07 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114895/#review46967 --- On Jan. 7, 2014, 1:57 p.m., David Edmundson wrote

Re: Review Request 114895: Guard against null QX11Info::connection()

2014-01-08 Thread David Edmundson
has unit tests, so I would appreciate if you extend the tests for that case. David Edmundson wrote: WId seems to be valid. If I check the dialog with xwininfo before closing plasmoidviewer it shows the same ID. Here is a full backtrace of it being needed: http

Re: Review Request 114895: Guard against null QX11Info::connection()

2014-01-08 Thread David Edmundson
with dialogs open. Diffs - src/kwindoweffects_x11.cpp 72cbb71 Diff: https://git.reviewboard.kde.org/r/114895/diff/ Testing --- Opened plasmoidviewer -a org.kde.example.widgetgallery expanded the applet, then closed plasmoidviewer It used to crash, now it doesn't. Thanks, David

Re: Review Request 115004: use KDeclarative namespace for kdeclarative framework classes

2014-01-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115004/#review47353 --- Ship it! Looks good to me. - David Edmundson On Jan. 13

Re: Review Request 115225: Add runtime platform support to KWindowInfo

2014-01-22 Thread David Edmundson
/#comment34006 Why are we ref counting ourselves instead of just using QExplicitlySharedDataPointer? - David Edmundson On Jan. 22, 2014, 1:09 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 115225: Add runtime platform support to KWindowInfo

2014-01-22 Thread David Edmundson
/kwindowinfo.cpp https://git.reviewboard.kde.org/r/115225/#comment34009 This seems wrong. KWindowInfo cheese; cheese.state(); //CRASH - David Edmundson On Jan. 22, 2014, 2:03 p.m., Martin Gräßlin wrote

Review Request 115300: Fix KKeySequence shortcut types flags

2014-01-24 Thread David Edmundson
/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115300: Fix KKeySequence shortcut types flags

2014-01-26 Thread David Edmundson
cc9016b src/kkeysequencewidget.h d5d70ea Diff: https://git.reviewboard.kde.org/r/115300/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Splitting kde-workspace and kde-runtime proposal

2014-01-27 Thread David Edmundson
There is an existing page about slitting runtime here: http://community.kde.org/Frameworks/Epics/New_Runtime_Organization linked to from http://community.kde.org/Frameworks/Epics Alex's wiki page looks far more populated. We should make sure we avoid wiki duplication. David

Where to put QML Bindings for KDE frameworks?

2014-01-28 Thread David Edmundson
For a task in Plasma I've had to port KKeySequence to render on QtQuick, using QtQuickControls. I expect over time we will see more KDE widgets having QtQuick implementations as well. Same for a lot of our other frameworks, such as KIO. I can either add these components to KDeclarative, and

  1   2   3   4   5   6   7   8   9   10   >