Re: QUrl behavior and KIO

2013-09-05 Thread David Faure
://) or modify all the users to make sure a scheme is always passed? Correct porting to QUrl is the only thing that makes sense IMHO. Let's not start adding hacks for badly ported code. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: [kdelibs/frameworks] staging/kdoctools: meinproc5.shell doesn't exist anymore since now it doesn't use kde4_add_executable

2013-09-05 Thread David Faure
). -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112527: Clean up KEmoticons framework (prior to splitting)

2013-09-06 Thread David Faure
This can't possibly work. You are taking a full URL (file:///dir) in string representation and passing that to QFile::copy, which only takes local paths. Drop the QUrl usage. - David Faure On Sept. 5, 2013, 9:02 p.m., David Gil Oliva wrote

Re: Review Request 111938: Allow installing both qca2 and qca3

2013-09-06 Thread David Faure
On Sept. 1, 2013, 5:16 p.m., David Faure wrote: Looks fine to me. Ivan Romanov wrote: I don't agree with this patch. I didn't get any notification about this. So I very ask you before do any changes in cmake rules talk with me. It is important for me. Holy... and here I

Re: Plasma Frameworks 5 article

2013-09-06 Thread David Faure
. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator

2013-09-06 Thread David Faure
On Sept. 1, 2013, 8:31 a.m., David Faure wrote: tier1/sonnet/src/ui/spellcheckdecorator.h, line 42 http://git.reviewboard.kde.org/r/112281/diff/2/?file=185151#file185151line42 Missing documentation (in particular about the ownership being transferred to the decorator) hmm

Re: Review Request 112559: Port the remaining uses of KIO::NetAccess to KIO/Jobs

2013-09-06 Thread David Faure
khtml/khtml_part.cpp http://git.reviewboard.kde.org/r/112559/#comment29086 Why? If the job fails the temp file will stay around, with the current code. I'd just remove the setAutoRemove(false) and the manual-remove. - David Faure On Sept. 6, 2013, 3:10 p.m., Àlex Fiestas wrote

Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator

2013-09-06 Thread David Faure
. (the short form is /// docu, but we usually rather use the full form instead) - David Faure On Sept. 6, 2013, 5:53 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 111938: Allow installing both qca2 and qca3

2013-09-07 Thread David Faure
On Sept. 1, 2013, 5:16 p.m., David Faure wrote: Looks fine to me. Ivan Romanov wrote: I don't agree with this patch. I didn't get any notification about this. So I very ask you before do any changes in cmake rules talk with me. It is important for me. David Faure wrote

Re: Review Request 112559: Port the remaining uses of KIO::NetAccess to KIO/Jobs

2013-09-07 Thread David Faure
is *exactly* what we need. - David Faure On Sept. 7, 2013, 3:59 p.m., Àlex Fiestas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112559

Re: Review Request 112557: Remove all links to libkdeqt5staging

2013-09-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112557/#review39557 --- Ship it! Ship It! - David Faure On Sept. 6, 2013, 1:54 p.m

Re: Review Request 112545: Unify both meinproc5 binaries

2013-09-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112545/#review39558 --- Patch missing. - David Faure On Sept. 5, 2013, 5:23 p.m

Re: KCompletion and KNotification

2013-09-08 Thread David Faure
time the completion finds no results? Urgh. So, all in all, I'm actually in favour personally, but I would like to know what Sune and Aurélien think, at least. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: Review Request 112547: avoid creating jobs on urls with double slashes

2013-09-08 Thread David Faure
to be done in far too many places. I started a discussion with Thiago about fixing QUrl::setPath instead. - David Faure On Sept. 5, 2013, 6:53 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 112527: Clean up KEmoticons framework (prior to splitting)

2013-09-08 Thread David Faure
(). Hence my questions about absolute or relative paths, I don't actually know what emo contains in this method. staging/kemoticons/src/core/kemoticonstheme.h http://git.reviewboard.kde.org/r/112527/#comment29146 same - David Faure On Sept. 8, 2013, 12:58 a.m., David Gil Oliva wrote

Re: Review Request 112479: Split Bookmarks out of kio folder into own folder in staging

2013-09-08 Thread David Faure
On Sept. 3, 2013, 12:34 p.m., David Faure wrote: staging/kbookmarks/tests/CMakeLists.txt, line 9 http://git.reviewboard.kde.org/r/112479/diff/1/?file=186788#file186788line9 Isn't that only for unittests? David Edmundson wrote: If this is wrong kconfigwidgets and ktextwidgets

Re: Review Request 112281: Allow setting a custom highligher on the spell check decorator

2013-09-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112281/ --- (Updated Sept. 8, 2013, 8:54 a.m.) Review request for KDE Frameworks and

Re: Review Request 112571: enable clearButton in kpassworddialog

2013-09-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112571/#review39571 --- Ship it! Ship It! - David Faure On Sept. 6, 2013, 7:01 p.m

Re: Review Request 112574: Reorganizing knewstuff framework

2013-09-08 Thread David Faure
://git.reviewboard.kde.org/r/112574/#comment29157 entrydetailsdialog.h is not installed, right? So this is fine. But it should be named entrydetailsdialog_p.h to avoid confusion. Any private header should be _p.h. (this is for a separate commit though) - David Faure

Re: Review Request 112547: avoid creating jobs on urls with double slashes

2013-09-08 Thread David Faure
make this fix unnecessary. - David Faure On Sept. 5, 2013, 6:53 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112547

Re: Review Request 112527: Clean up KEmoticons framework (prior to splitting)

2013-09-08 Thread David Faure
On Sept. 8, 2013, 8:45 a.m., David Faure wrote: staging/kemoticons/src/core/kemoticonsprovider.cpp, line 146 http://git.reviewboard.kde.org/r/112527/diff/4/?file=188119#file188119line146 file.fileName() is the same as emo. Yes, the name of the methods in QFile are a bit confusing

Re: Review Request 112311: Port kmimetypechooser.cpp from Krun to QProcess

2013-09-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112311/#review39621 --- Ship it! Ship It! - David Faure On Sept. 2, 2013, 3:13 p.m

Re: Review Request 112527: Clean up KEmoticons framework (prior to splitting)

2013-09-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112527/#review39622 --- Ship it! Ship It! - David Faure On Sept. 9, 2013, 12:05

Re: Plugin locator performance ballpark

2013-09-09 Thread David Faure
different from e.g. network operations btw, since the order of magnitude is much bigger for those, and the timing is much less predictable. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde

Re: Review Request 112545: Unify both meinproc5 binaries

2013-09-10 Thread David Faure
/#comment29231 isn't it better to not define the option, so that the user gets unknown option --cache? Alternatively, further down, check for isSet(cache) and error out. - David Faure On Sept. 9, 2013, 2:50 p.m., Aleix Pol Gonzalez wrote

Re: installed header includes

2013-09-10 Thread David Faure
local forwarding headers, see what I did in staging/kio/src/ -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Plugin locator performance ballpark

2013-09-10 Thread David Faure
On Monday 09 September 2013 17:10:25 Martin Graesslin wrote: On Monday 09 September 2013 16:48:05 David Faure wrote: On Monday 09 September 2013 14:23:10 Sebastian Kügler wrote: Martin Grässlin asked if we could offer an async API for this. Opinions? This task is mostly I/O, and a bit

Re: Review Request 112570: Port some kde4_add_executable usages to add_executable

2013-09-10 Thread David Faure
On Sept. 8, 2013, 9:24 a.m., David Faure wrote: kinit/CMakeLists.txt, line 44 http://git.reviewboard.kde.org/r/112570/diff/1/?file=187699#file187699line44 This could also be moved out of the if, by using the proper arguments for ecm_mark_nongui_executable, so that it doesn't

Re: Review Request 112559: Port the remaining uses of KIO::NetAccess to KIO/Jobs

2013-09-10 Thread David Faure
to move on. - David Faure On Sept. 10, 2013, 1:56 p.m., Àlex Fiestas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112559

Re: Review Request 112545: Unify both meinproc5 binaries

2013-09-10 Thread David Faure
://git.reviewboard.kde.org/r/112545/#comment29303 err? don't print this on every call to meinproc, only if parser.isSet(cache) ! - David Faure On Sept. 10, 2013, 4:52 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail

Re: Review Request 112556: Move itemviews to tier2

2013-09-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112556/#review39773 --- Ship it! Ship It! - David Faure On Sept. 10, 2013, 10:45

Re: Review Request 112679: Make KTraderParseTree fit for searching in KPluginInfo::List

2013-09-12 Thread David Faure
/kservice/src/services/ktraderparsetree_p.h http://git.reviewboard.kde.org/r/112679/#comment29392 Remove the const and from here - problem solved. (same on the line above) - David Faure On Sept. 12, 2013, 1:33 a.m., Sebastian Kügler wrote

Re: Review Request 112680: KPluginTrader: QPluginLoader/metadata-based querying of Plugins

2013-09-12 Thread David Faure
. - David Faure On Sept. 12, 2013, 3:12 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112680

Re: Review Request 112660: KPluginInfo rework for KPluginTrader

2013-09-12 Thread David Faure
://git.reviewboard.kde.org/r/112660/#comment29403 I think toBool() already takes care of returning false for invalid variants. staging/kservice/src/services/kplugininfo.cpp http://git.reviewboard.kde.org/r/112660/#comment29404 space after if, while you're at it - David Faure On Sept. 10, 2013, 11

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

2013-09-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111908/#review39867 --- Ship it! OK then. - David Faure On Aug. 9, 2013, 12:38 p.m

Re: Review Request 112556: Move itemviews to tier2

2013-09-13 Thread David Faure
, what do you think? Do we plan to have a proper/final let's look at what we did API review after everything has settled? That would be good indeed, but let's do it along the way as well rather than postpone it all :) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE

Re: Review Request 112660: KPluginInfo rework for KPluginTrader

2013-09-13 Thread David Faure
. staging/kservice/src/services/kplugininfo.h http://git.reviewboard.kde.org/r/112660/#comment29479 missing docu for libraryPath staging/kservice/src/services/kplugininfo.h http://git.reviewboard.kde.org/r/112660/#comment29480 can be removed now, no? - David Faure On Sept. 12, 2013, 7:07

Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions

2013-09-13 Thread David Faure
/CMakeLists.txt. This is preparation for future splitting. The variables are necessary for that, for now, as I understand it. Let's finish moving everything into separate frameworks, then we can finally split up kdelibs and stop having to care for two ways to build stuff :) - David Faure On Sept. 12, 2013

Re: Dependency specifications

2013-09-13 Thread David Faure
distros will probably do) then there's no point in searching for QtTest. Modularity wins again, better do that inside the autotests subdir. Apart from QtTest, I agree, though. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5

Re: Review Request 112684: Don't inspect XEvent queue in KUserTimestamp::updateUserTimestamp

2013-09-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112684/#review39940 --- Ship it! Much simpler indeed - David Faure On Sept. 12

Re: Review Request 112689: Drop KI18n dependencies in KCompletion

2013-09-13 Thread David Faure
://git.reviewboard.kde.org/r/112689/#comment29488 QObject::tr ( const char * sourceText, const char * disambiguation = 0 ) - you need to swap the arguments around. - David Faure On Sept. 12, 2013, 2:47 p.m., Aleix Pol Gonzalez wrote

Re: Review Request 112681: Tests for KPluginTrader and friends

2013-09-13 Thread David Faure
it doesn't matter that much in a test, but I still don't like seeing it, it inspires other people to do it wrong. This could be a simple QObject. - David Faure On Sept. 12, 2013, 3:35 a.m., Sebastian Kügler wrote

Re: Dependency specifications

2013-09-13 Thread David Faure
On Friday 13 September 2013 13:03:29 Aleix Pol wrote: On Fri, Sep 13, 2013 at 9:43 AM, David Faure fa...@kde.org wrote: On Thursday 12 September 2013 02:32:20 Aleix Pol wrote: I'd say that all Qt dependencies in the module should be defined only once in the root CMakeLists.txt

Re: Review Request 112689: Drop KI18n dependencies in KCompletion

2013-09-13 Thread David Faure
if it still contains your question about tr()/i18nc(). - David Faure On Sept. 13, 2013, 11:01 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112689

Re: Review Request 112696: Moves KNotifications to tier2

2013-09-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112696/#review39952 --- Ship it! Ship It! - David Faure On Sept. 12, 2013, 4:25

Re: Dependency specifications

2013-09-13 Thread David Faure
On Friday 13 September 2013 13:17:47 Aleix Pol wrote: Well, but in that case you'll maybe want to find QtGui, QtWidgets or KF5::AwesomeTests. Ah yes, true, manual tests can have more deps sometimes. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE

Re: Review Request 112710: Move KIO::NetAccess to kde4support

2013-09-13 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112710/#review39953 --- Ship it! Ship It! - David Faure On Sept. 13, 2013, 11:21

Re: Review Request 112722: Juggle around Kiosk include names to avoid incorrect library linkage and for better layering

2013-09-14 Thread David Faure
. - David Faure On Sept. 13, 2013, 11:38 p.m., Eike Hein wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112722

Re: Review Request 112716: Prepare itemviews for moving

2013-09-14 Thread David Faure
the kcoreaddons dep then maybe this can be rebased on top of that, to avoid going back and forth about the kcoreaddons dep?). If it fixes a more short-term compilation issue, ship it. - David Faure On Sept. 13, 2013, 3:09 p.m., Aurélien Gâteau wrote

Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

2013-09-14 Thread David Faure
yep, we do restart the timer when necessary anyway (this answers my above question) staging/kio/src/core/slavebase.cpp http://git.reviewboard.kde.org/r/112702/#comment29614 const UDSEntry entry - David Faure On Sept. 12, 2013, 6:26 p.m., Mark Gaiser wrote

Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

2013-09-14 Thread David Faure
), but please port all of kdelibs awaya from the newly deprecated api - David Faure On Sept. 12, 2013, 6:26 p.m., Mark Gaiser wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r

Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

2013-09-15 Thread David Faure
On Sept. 14, 2013, 10:45 a.m., David Faure wrote: staging/kio/src/core/slavebase.h, line 23 http://git.reviewboard.kde.org/r/112702/diff/1/?file=189211#file189211line23 I'm pretty sure it was included already, via one of the kio/* includes below. You can just remove this. Mark

Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

2013-09-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112702/#review40047 --- Ship it! Thanks! - David Faure On Sept. 14, 2013, 10:36

Re: Review Request 112722: Juggle around Kiosk include names to avoid incorrect library linkage and for better layering

2013-09-15 Thread David Faure
namespace (or its methods, rather), and porting instructions in KDE5PORTING.html - David Faure On Sept. 15, 2013, 12:41 a.m., Eike Hein wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org

Re: Review Request 112681: Tests for KPluginTrader and friends

2013-09-15 Thread David Faure
-driven. But this is KDE, so I'll let you decide (now that you have all the data...). - David Faure On Sept. 14, 2013, 7:35 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 112745: karchive - remove unused dependency

2013-09-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112745/#review40087 --- Ship it! Ship It! - David Faure On Sept. 15, 2013, 3:09

Re: Review Request 112681: Tests for KPluginTrader and friends

2013-09-16 Thread David Faure
On Monday 16 September 2013 11:50:21 Sebastian Kügler wrote: On Sunday, September 15, 2013 08:42:31 David Faure wrote: Data-driven tests *can* be run separately (and therefore qDebugs don't get confusing), using the methodName:rowName syntax as command-line argument. Data-driven tests

Re: Review Request 112679: Make KTraderParseTree fit for searching in KPluginInfo::List

2013-09-17 Thread David Faure
http://git.reviewboard.kde.org/r/112679/#comment29695 const KPluginInfo - David Faure On Sept. 14, 2013, 6:17 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 112730: Make knewstuff build standalone

2013-09-17 Thread David Faure
? :-) Should we reintroduce kde4uic.cmake in the ki18n framework (with a better name), to have this work like in kde4? - David Faure On Sept. 17, 2013, 7:29 a.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail

Re: Review Request 112730: Make knewstuff build standalone

2013-09-17 Thread David Faure
/ --- (Updated Sept. 17, 2013, 7:29 a.m.) Review request for KDE Frameworks, Albert Astals Cid, David Faure, and Chusslove Illich. Description --- This makes it so I can mkdir build; cd build; cmake ../; make install from knewstuff

Re: Review Request 112547: avoid creating jobs on urls with double slashes

2013-09-17 Thread David Faure
On Sept. 8, 2013, 1:13 p.m., David Faure wrote: Please test https://codereview.qt-project.org/64926, it should make this fix unnecessary. Aleix Pol Gonzalez wrote: Quietness suggests that this review can be closed probably. Is that the case? Yes this should be discarded

Re: Fwd: Print Dialog - next steps

2013-09-18 Thread David Faure
judgement (more precisely, choose whichever option will lead to less effort overall, trimming down KdePrintDialog vs porting all usages). -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde

Re: Review Request 112681: Tests for KPluginTrader and friends

2013-09-18 Thread David Faure
. - David Faure On Sept. 17, 2013, 11:27 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112681

Re: Review Request 112681: Tests for KPluginTrader and friends

2013-09-18 Thread David Faure
/tests/pluginlocator/plugintest.cpp http://git.reviewboard.kde.org/r/112681/#comment29752 hehe - David Faure On Sept. 18, 2013, 12:12 p.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Splitting out a KX11Extras frameworks from KWindowSystems

2013-09-19 Thread David Faure
which classes are only available on X11, and which ones are available everywhere, I guess. I'm just a bit uneasy about making too many too small frameworks when we can avoid it, but OK, that's another not a strong veto. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE

Re: Review Request 112758: Move KCompletion to tier2

2013-09-19 Thread David Faure
from the wiki? - David Faure On Sept. 16, 2013, 3:08 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112758

Re: Review Request 112795: Move KDocTools to tier2

2013-09-19 Thread David Faure
from the wiki? tier2/kdoctools/CMakeLists.txt http://git.reviewboard.kde.org/r/112795/#comment29758 I'm curious, what does that do? - David Faure On Sept. 18, 2013, 3:34 p.m., Aleix Pol Gonzalez wrote

Re: Review Request 112785: Add ki18n_wrap_ui macro to ki18nMacros

2013-09-19 Thread David Faure
insights on how to use kdelibs-kf5-defined macros inside kdelibs-kf5. - David Faure On Sept. 17, 2013, 7:56 p.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r

Re: Review Request 112796: Move kcolorutilsdemo from kconfigwidgets/tests to kguiaddons/tests

2013-09-19 Thread David Faure
the test use higher-level public API instead of an internal header? - David Faure On Sept. 18, 2013, 4:27 p.m., Aurélien Gâteau wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r

Re: Review Request 112803: Start cleaning up KDNSSD

2013-09-19 Thread David Faure
this line is missing LINK_PUBLIC or LINK_PRIVATE (I would guess the latter?) - David Faure On Sept. 18, 2013, 6:41 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 112808: Port away from KDirWatch in KEmoticons (prior to splitting)

2013-09-19 Thread David Faure
://git.reviewboard.kde.org/r/112808/#comment29763 This test is already done internally in QFSW, remove it from here. - David Faure On Sept. 18, 2013, 10:26 p.m., David Gil Oliva wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 112803: Start cleaning up KDNSSD

2013-09-19 Thread David Faure
://git.reviewboard.kde.org/r/112803/#comment29768 still there? - David Faure On Sept. 19, 2013, 11:24 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112803

Re: Review Request 112808: Port away from KDirWatch in KEmoticons (prior to splitting)

2013-09-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112808/#review40395 --- Ship it! Ship It! - David Faure On Sept. 19, 2013, 8:37

Re: Review Request 112808: Port away from KDirWatch in KEmoticons (prior to splitting)

2013-09-21 Thread David Faure
On Sept. 19, 2013, 7:48 a.m., David Faure wrote: staging/kemoticons/src/core/kemoticons.cpp, line 110 http://git.reviewboard.kde.org/r/112808/diff/1/?file=190507#file190507line110 This test is already done internally in QFSW, remove it from here. Aleix Pol Gonzalez wrote

Re: Review Request 112921: Adjust CMakeLists.txt files in KEmoticons (prior to splitting)

2013-09-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112921/#review40906 --- Ship it! Ship It! - David Faure On Sept. 25, 2013, 8:21

Re: kde4_add_plugin on KF5

2013-09-28 Thread David Faure
solution IMHO would be a add_library( ... PLUGIN ...) or add_plugin(), in cmake itself. This is definitely not kde specific. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel

Re: Making KDocTools independent of KArchive

2013-09-29 Thread David Faure
it by hand? Or do they use .po files somehow? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 112880: Added KColorSchemeToken class.

2013-09-29 Thread David Faure
: I see that the request is correctly for 5.0 - which means less merging trouble, so it sounds good to me :) - David Faure On Sept. 24, 2013, 4:08 p.m., Denis Kuplyakov wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 112443: Native event filter porting for KModifierKeyInfoProvider

2013-09-29 Thread David Faure
On Sept. 23, 2013, 10:07 a.m., Kevin Ottens wrote: Tested the patch in my tree, works for caps lock too. Now it highlights a dependency problem... We don't want a dependency on QX11Extras from KGuiAddons. So maybe we should move KModifierKeyInfo to your proposed KX11Extras?

Re: Review Request 112929: Remove KPluginVerificationData

2013-09-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112929/#review41006 --- Ship it! Ship It! - David Faure On Sept. 25, 2013, 11:50

Re: Review Request 112929: Remove KPluginVerificationData

2013-09-29 Thread David Faure
://git.reviewboard.kde.org/r/112929/#comment30105 Ah, you can probably remove this include now. - David Faure On Sept. 25, 2013, 11:50 a.m., Sebastian Kügler wrote: --- This is an automatically generated e-mail. To reply, visit: http

KIOWidgets and KFile

2013-09-29 Thread David Faure
time... as far as I can see from the code). Help :) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 112730: Make knewstuff build standalone

2013-09-29 Thread David Faure
On Sept. 17, 2013, 7:30 a.m., David Faure wrote: knewstuff/CMakeLists.txt, line 9 http://git.reviewboard.kde.org/r/112730/diff/1/?file=189541#file189541line9 Does this really build when building all of kdelibs in one go? I thought we determined that find_package of kf5 components

Re: kcmutils linking issues

2013-09-29 Thread David Faure
about what is wrong? Is it my fault or something broke? And what's the error message? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: KIOWidgets and KFile

2013-09-30 Thread David Faure
On Sunday 29 September 2013 22:31:38 Sebastian Kügler wrote: On Sunday, September 29, 2013 20:50:28 David Faure wrote: This is clearly because kbookmarks was written as part of kio, and with konqueror in mind. I guess the question is how generic we want KBookmarks to be, i.e. should

Re: Review Request 112942: Move KDNSSD to tier2

2013-10-01 Thread David Faure
/#comment30143 That's an old macro (still in kdelibs/cmake/modules), I thought the idea was to write your own if instead, or something (check the wiki page about cmake-source-changes to make sure) - David Faure On Sept. 25, 2013, 5:35 p.m., Aleix Pol Gonzalez wrote

Re: Review Request 112966: Dispatch KInterProcessWindowing to other frameworks

2013-10-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112966/#review41067 --- Ship it! Ship It! - David Faure On Sept. 27, 2013, 1:33

Re: Review Request 113038: Move KDESu to staging + adopt standard dir scheme

2013-10-02 Thread David Faure
/r/113038/#comment30170 we can probably port this to QProcess. - David Faure On Oct. 1, 2013, 8:31 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r

Re: Switch build.kde.org to Qt stable branch

2013-10-03 Thread David Faure
branch. As far as I know, the plan is to release KF5 depending on Qt 5.2. I propose switching build.kde.org to the 'stable' Qt branch to ensure we don't accidentally depend on 5.3 features. Yes please. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

2013-10-03 Thread David Faure
to be documented in KDE5PORTING.html and in the real kstringhandler.h. - David Faure On Sept. 24, 2013, 6:08 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 113045: Prepare KCMUtils for move to tier3

2013-10-04 Thread David Faure
with KCategoryDrawerV3, in itemviews? I.e. getting rid of the two oldest ones? It should be SC since v3 derives from v2 derives from v1. - David Faure On Oct. 2, 2013, 8:06 a.m., David Edmundson wrote: --- This is an automatically

EcmQt4To5Porting

2013-10-04 Thread David Faure
be ported to the better way, before other modules copy these files too? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 113095: Use QFileDialog::setMimeTypeFilters instead of converting to globs

2013-10-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113095/#review41213 --- Ship it! Ship It! - David Faure On Oct. 4, 2013, 11:25 a.m

Re: Review Request 113097: KInit splitting

2013-10-05 Thread David Faure
the same here. Installing the .in files and in this code if not in kdelibs - get_filename_component(_INSTALLED_MODULE_PATH ${CMAKE_CURRENT_LIST_FILE} PATH) (the var name can be whatever). - David Faure On Oct. 4, 2013, 2:48 p.m., Aleix Pol Gonzalez wrote

Re: Review Request 113100: Move KDESu to tier3

2013-10-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113100/#review41266 --- Ship it! Ship It! - David Faure On Oct. 4, 2013, 5:20 p.m

Re: Review Request 113076: kcookiejar: Fix parsing of weird dates

2013-10-05 Thread David Faure
and qt. But why not just add t to the format string to include the timezone, as it used to do with %Z, instead of the removeTimeZone() function? - David Faure On Oct. 3, 2013, 4 p.m., Aurélien Gâteau wrote

Re: Review Request 113087: Start preparing KHTML for moving

2013-10-05 Thread David Faure
://git.reviewboard.kde.org/r/113087/#comment30259 not useful (this can be removed everywhere, we don't set it anymore) khtml/src/CMakeLists.txt http://git.reviewboard.kde.org/r/113087/#comment30260 this will have to become qt5_wrap_ui iirc - David Faure On Oct. 3, 2013, 10:15 p.m., David

Re: kio-related build error in plasma-framework

2013-10-05 Thread David Faure
of a sudden. But I'm not sure where it came from, before, so I'm not sure where to look... -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: KF5 Update Meeting Minutes 2013-w41

2013-10-11 Thread David Faure
. (What's not done yet is cleaning up the KFileModule stuff, but that's unrelated, as long as KEncodingFileDialog is ported away from it.) -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks

KCapacityBar's painting code

2013-10-11 Thread David Faure
a way for styles to set ce_capacityBar (and to initialize it to 0)? -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE, in particular KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

  1   2   3   4   5   6   7   8   9   10   >