Review Request 117976: Implement support for QFileDialog::setFileMode

2014-05-03 Thread David Rosca
/platformtheme/kdeplatformfiledialoghelper.cpp 777d818 Diff: https://git.reviewboard.kde.org/r/117976/diff/ Testing --- The file dialog works as expected, autotests pass. Thanks, David Rosca ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 117976: Implement support for QFileDialog::setFileMode

2014-05-03 Thread David Rosca
--- The file dialog works as expected, autotests pass. Thanks, David Rosca ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117976: Implement support for QFileDialog::setFileMode

2014-05-03 Thread David Rosca
., David Rosca wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117976/ --- (Updated May 3, 2014, 4:38 p.m.) Review request

Re: Review Request 117976: Implement support for QFileDialog::setFileMode

2014-05-04 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117976/#review57244 --- On May 3, 2014, 4:38 p.m., David Rosca wrote: --- This is an automatically

Re: Review Request 117976: Implement support for QFileDialog::setFileMode

2014-05-04 Thread David Rosca
/kfiledialog_unittest.cpp 69d474c src/platformtheme/kdeplatformfiledialoghelper.h c59bee9 src/platformtheme/kdeplatformfiledialoghelper.cpp 777d818 Diff: https://git.reviewboard.kde.org/r/117976/diff/ Testing --- The file dialog works as expected, autotests pass. Thanks, David Rosca

Re: Review request: QBluez

2015-02-17 Thread David Rosca
febrer de 2015, a les 10:40:44, David Rosca va escriure: Hi all, I'd like to ask for a review of the QBluez library [1]. Using Q* is usually frowned upon since the Qt people have made it quick clear that they reserve the right to use Q* names themselves, i'd look for a new name. Also tried

Re: Review request: QBluez

2015-02-17 Thread David Rosca
. By any chance, are you running Bluez 4? It doesn't have the DBus ObjectManager, so that call should fail like that. David On Tue, Feb 17, 2015 at 10:23 PM, Albert Astals Cid aa...@kde.org wrote: El Dimarts, 17 de febrer de 2015, a les 10:36:59, David Rosca va escriure: Using Q* is usually

Review request: QBluez

2015-02-16 Thread David Rosca
generated documentation here [4]. Thanks, David Rosca [1] http://quickgit.kde.org/?p=scratch%2Fdrosca%2Fqbluez.git [2] https://github.com/nowrep/qbluez-plasmoid [3] https://projects.kde.org/projects/kde/workspace/bluedevil/repository/show?rev=qbluez [4] http://david.rosca.cz/qbluez-apidoc/html

Re: Review request: QBluez

2015-02-17 Thread David Rosca
will modify those tests to be skipped if Bluez 4 is detected. David On Tue, Feb 17, 2015 at 11:00 PM, Albert Astals Cid aa...@kde.org wrote: El Dimarts, 17 de febrer de 2015, a les 22:39:16, David Rosca va escriure: That would work i guess, note it's not only about the project name, but also about

Re: Review Request 122970: Move added setError method to new JobViewV3 interface

2015-03-18 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122970/#review77674 --- Bump - David Rosca On March 15, 2015, 4:56 p.m., David

Re: Review Request 122970: Move added setError method to new JobViewV3 interface

2015-03-18 Thread David Rosca
On March 18, 2015, 11:26 a.m., David Rosca wrote: Ah see, it's the problem with the client-side installing the XML file, rather than the server-side. It means any new method will initially trigger not implemented compilation error in the server. Kills extensibility. But not really

Re: Review Request 122970: Move added setError method to new JobViewV3 interface

2015-03-18 Thread David Rosca
daf3902 src/org.kde.JobView.xml f64d232 src/org.kde.JobViewV2.xml 245a5f0 Diff: https://git.reviewboard.kde.org/r/122970/diff/ Testing --- plasma-workspace stable now builds fine changing V2 - V3 in CMakeFiles.txt in master branch enable the new setError method. Thanks, David Rosca

Re: Review Request 122970: Move added setError method to new JobViewV3 interface

2015-03-18 Thread David Rosca
On March 18, 2015, 11:26 a.m., David Rosca wrote: Ah see, it's the problem with the client-side installing the XML file, rather than the server-side. It means any new method will initially trigger not implemented compilation error in the server. Kills extensibility. But not really

Re: Review Request 122970: Move added setError method to org.kde.JobView.xml

2015-03-22 Thread David Rosca
marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit abafc8a6e72e4bb8d84cac2863d8513ed50aff00 by David Rosca to branch master. Repository: kjobwidgets Description --- Reuse org.kde.JobView.xml file that is no longer used

Re: Review Request 122926: Add setError method to JobViewV2 interface

2015-03-15 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122926/#review77503 --- On March 13, 2015, 7:26 p.m., David Rosca wrote: --- This is an automatically

Re: Review Request 122970: Move added setError method to org.kde.JobView.xml

2015-03-21 Thread David Rosca
f64d232 src/org.kde.JobViewV2.xml 245a5f0 Diff: https://git.reviewboard.kde.org/r/122970/diff/ Testing --- plasma-workspace stable now builds fine changing V2 - V3 in CMakeFiles.txt in master branch enable the new setError method. Thanks, David Rosca

Re: New framework: BluezQt

2015-03-12 Thread David Rosca
I'm forwarding the reply here too: The name KF5BluezQt seems inelegant, is has both a prefix and a suffix, how about just KF5Bluez? That would work, but only for cmake files, otherwise I would have to change namespace from BluezQt to just Bluez, which is obviously not a right thing. The

New framework: BluezQt

2015-03-12 Thread David Rosca
Hi all, BluezQt is a wrapper library for Bluez 5 DBus API. It will be used in Bluedevil as a replacement for libbluedevil. It is currently in playground (playground/libs/bluez-qt). It should be a Tier 1 framework (only depends on Qt libs). The code should follow all framework policies and the

Re: [kde-frameworks-devel] Review request: QBluez

2015-03-11 Thread David Rosca
On Wed, Mar 11, 2015 at 6:49 PM, Jonathan Riddell j...@jriddell.org wrote: The name KF5BluezQt seems inelegant, is has both a prefix and a suffix, how about just KF5Bluez? That would work, but only for cmake files, otherwise I would have to change namespace from BluezQt to just Bluez, which

Re: Review Request 122926: Add setError method to JobViewV2 interface

2015-03-13 Thread David Rosca
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 812d0b440e7f08e3acdd1c9bb95779bd871b75b3 by David Rosca to branch master. Repository: kjobwidgets Description --- Currently, there is no way to retrieve value of KJob::error(). This patch

Review Request 122926: Add setError method to JobViewV2 interface

2015-03-12 Thread David Rosca
(changes in kuiserver, dataengine and notifications plasmoid). Diffs - src/kuiserverjobtracker.cpp 191359b src/org.kde.JobViewV2.xml cacb5e8 Diff: https://git.reviewboard.kde.org/r/122926/diff/ Testing --- Works fine with patched plasma-workspace Thanks, David Rosca

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

2015-04-11 Thread David Rosca
://git.reviewboard.kde.org/r/123335/#review78835 --- On April 11, 2015, 6:34 p.m., David Rosca wrote: --- This is an automatically generated e-mail. To reply, visit: https

Review Request 123335: Fix native file dialogs from widgets QFileDialog

2015-04-11 Thread David Rosca
/standarddialogs works fine QFileDialog *d = new QFileDialog(parent); d-open(); works fine test app: https://paste.kde.org/psddcng5n I'm running Qt 5.4.1. Are there any other types of dialogs that I forgot (and possibly broke)? Thanks, David Rosca ___ Kde

Re: Review Request 123677: Bring back use of KEncodingFileDialog

2015-05-08 Thread David Rosca
marked as submitted. Review request for Kate and KDE Frameworks. Changes --- Submitted with commit d9eeed19cefe87e7b2d7345c12177bf89d90ff3c by David Rosca to branch master. Bugs: 343255 https://bugs.kde.org/show_bug.cgi?id=343255 Repository: ktexteditor Description

Review Request 123677: Bring back use of KEncodingFileDialog

2015-05-07 Thread David Rosca
. Thanks, David Rosca ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123677: Bring back use of KEncodingFileDialog

2015-05-07 Thread David Rosca
/diff/ Testing --- Save file dialogs are working fine and saving to different encoding works too. Thanks, David Rosca ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 123677: Bring back use of KEncodingFileDialog

2015-05-07 Thread David Rosca
On May 7, 2015, 8:48 p.m., David Rosca wrote: Sorry, didn't know of the bug. Should I discard this rr? Christoph Feck wrote: Why? What you propose here was discussed as one possible option. Yes, but from the bug discussion it seems reverting those commits is not something

Re: Review Request 123677: Bring back use of KEncodingFileDialog

2015-05-07 Thread David Rosca
? - David Rosca On May 7, 2015, 8:45 p.m., David Rosca wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123677/ --- (Updated

Review Request 123720: Fix autotests

2015-05-11 Thread David Rosca
the test pass. Diffs - autotests/kdirselectdialog_unittest.cpp bbbc958 autotests/kfiledialog_unittest.cpp 30392bf Diff: https://git.reviewboard.kde.org/r/123720/diff/ Testing --- All tests now pass Thanks, David Rosca ___ Kde

Re: Review Request 123714: Only accept existing directories in FileMode::Directory mode

2015-05-10 Thread David Rosca
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 55fba9000550c4a043961631d435069226aaea27 by David Rosca to branch master. Repository: frameworkintegration Description --- This also implements other modes for fileMode command line option

Re: Review Request 123713: KFileWidget: Don't accept files in directory only mode

2015-05-10 Thread David Rosca
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 74e7f27a41b76635dd5172f9dfd57deb882c794d by David Rosca to branch master. Repository: kio Description --- Don't accept files entered in location line edit when in directory only (KFile

Re: Review Request 123720: Fix autotests

2015-05-11 Thread David Rosca
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 6732e8f47ec7898cf73b7831e3045c1a5a822a76 by David Rosca to branch master. Repository: frameworkintegration Description --- The kfiledialog_unittest was broken by me (sorry

Review Request 123713: KFileWidget: Don't accept files in directory only mode

2015-05-10 Thread David Rosca
--- Don't accept files entered in location line edit when in directory only (KFile::Directory) mode. Diffs - src/filewidgets/kfilewidget.cpp 58dd92e Diff: https://git.reviewboard.kde.org/r/123713/diff/ Testing --- Files are no longer accepted in directory only mode Thanks, David

Review Request 123714: Only accept existing directories in FileMode::Directory mode

2015-05-10 Thread David Rosca
-existant directories are no longer accepted. Thanks, David Rosca ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

New framework: BluezQt

2015-05-12 Thread David Rosca
Hi all, I'd like to submit bluez-qt [1] for a review and then release it as part of frameworks 5.11. It is used in Bluedevil since the first release with Plasma 5.3. I have worked on API changes (it is source incompatible from the 5.3 version) and also added a new tests (including QML tests). I

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

2015-05-15 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123335/#review80415 --- On April 17, 2015, 8 a.m., David Rosca wrote

Review Request 123778: Fix crash when DBus call ends with error

2015-05-13 Thread David Rosca
the error?). Diffs - src/utils/dbusfuture_p.h 336235c Diff: https://git.reviewboard.kde.org/r/123778/diff/ Testing --- No longer crashes Thanks, David Rosca ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

2015-04-17 Thread David Rosca
marked as submitted. Review request for KDE Frameworks, David Faure and Lukáš Tinkl. Changes --- Submitted with commit 26406a9aa01d6f4f01a3f084b51451de8385c8fc by David Rosca to branch master. Repository: frameworkintegration Description --- 9814e4b773b2b34afafa0c5d242594bbb4f9a6ae

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

2015-04-12 Thread David Rosca
://git.reviewboard.kde.org/r/123341/#comment53926 You probably forgot to replace this save() with return true. - David Rosca On April 12, 2015, 7:52 a.m., Kåre Särs wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

2015-04-12 Thread David Rosca
Qt 5.4.1. Are there any other types of dialogs that I forgot (and possibly broke)? Thanks, David Rosca ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: bluez qt bic sic - soversion regression

2015-06-04 Thread David Rosca
Fixed now, sorry about that. David On Thu, Jun 4, 2015 at 6:24 PM, Harald Sitter sit...@kde.org wrote: alohas this commit http://quickgit.kde.org/?p=bluez-qt.gita=commith=7e05a4a4fae19550b1dcc11e5a363a0884b5f8d8 removed the soversion6 which is needed as the present API is incompatible

Re: New framework: BluezQt

2015-05-28 Thread David Rosca
It's been over 14 days now, so if there are no objections, I will ask sysadmins to move it to frameworks. Also, are there any other steps I should do besides moving the repository? Thanks, David On Tue, May 12, 2015 at 11:44 PM, David Rosca now...@gmail.com wrote: Hi all, I'd like to submit

Re: Review Request 123778: Fix crash when DBus call ends with error

2015-05-27 Thread David Rosca
callback is not called (maybe it would be good to somehow indicate the error?). Diffs - src/utils/dbusfuture_p.h 336235c Diff: https://git.reviewboard.kde.org/r/123778/diff/ Testing --- No longer crashes Thanks, David Rosca

Re: Review Request 123778: Fix crash when DBus call ends with error

2015-05-27 Thread David Rosca
, continuation callback is not called (maybe it would be good to somehow indicate the error?). Diffs - src/utils/dbusfuture_p.h 336235c Diff: https://git.reviewboard.kde.org/r/123778/diff/ Testing --- No longer crashes Thanks, David Rosca

Re: Review Request 124789: Respect -DBUILD_TESTING=OFF

2015-08-17 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124789/#review83950 --- Ship it! Thanks. I will commit it for you. - David Rosca

Re: Review Request 124789: Respect -DBUILD_TESTING=OFF

2015-08-17 Thread David Rosca
On Aug. 17, 2015, 3:51 p.m., David Rosca wrote: Thanks. I will commit it for you. But I need your full name. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124789

Re: Review Request 125691: KOpenWithDialog: Fix creating desktop file with empty mimetype

2015-10-22 Thread David Rosca
t: https://git.reviewboard.kde.org/r/125691/#review87244 --- On Oct. 18, 2015, 4:09 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 125691: KOpenWithDialog: Fix creating desktop file with empty mimetype

2015-10-27 Thread David Rosca
it: https://git.reviewboard.kde.org/r/125691/#review87487 ------- On Oct. 18, 2015, 4:09 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125691/ > -

Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

2015-10-29 Thread David Rosca
using QApplication::setWheelScrollLines Diffs - src/platformtheme/khintssettings.cpp 6e8313d Diff: https://git.reviewboard.kde.org/r/125863/diff/ Testing --- Qt 5.5 apps now correctly scroll by the value set in mouse kcm Thanks, David Rosca _

Re: Review Request 125691: KOpenWithDialog: Fix creating desktop file with empty mimetype

2015-10-29 Thread David Rosca
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 1771412c7cf8a8d07af4fe2687e2a698e409d73b by David Rosca to branch master. Repository: kio Description --- If qMimeType is empty, addToMimeAppsList shouldn't be called. Diffs - src

Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

2015-10-29 Thread David Rosca
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 65af8a044f1d050f5d68b7a0afb9f99b6b9f7edb by David Rosca to branch master. Bugs: 291144 https://bugs.kde.org/show_bug.cgi?id=291144 Repository: frameworkintegration Description --- Use

Review Request 125877: Fix kdeplatformtheme_unittest after last commit

2015-10-29 Thread David Rosca
Description --- see summary Diffs - autotests/kdeplatformtheme_unittest.cpp f660ffd Diff: https://git.reviewboard.kde.org/r/125877/diff/ Testing --- Thanks, David Rosca ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 125877: Fix kdeplatformtheme_unittest after last commit

2015-10-29 Thread David Rosca
> On Oct. 29, 2015, 8:26 p.m., Aleix Pol Gonzalez wrote: > > autotests/kdeplatformtheme_unittest.cpp, line 237 > > <https://git.reviewboard.kde.org/r/125877/diff/1/?file=413361#file413361line237> > > > > What does `qApp->wheelScrollLines()

Re: Review Request 125877: Fix kdeplatformtheme_unittest after last commit

2015-10-29 Thread David Rosca
utomatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125877/#review87695 --- On Oct. 29, 2015, 8:22 p.m., David Rosca wrote: > > --- > This is an

Review Request 125911: EventGenerator: Add support for sending wheel events

2015-11-01 Thread David Rosca
Description --- Add sendWheelEvent and sendWheelEventRecursive Diffs - src/qmlcontrols/kquickcontrolsaddons/eventgenerator.cpp 4026a88 src/qmlcontrols/kquickcontrolsaddons/eventgenerator.h 8e719ae Diff: https://git.reviewboard.kde.org/r/125911/diff/ Testing --- Thanks, David Rosca

Re: Review Request 125877: Fix kdeplatformtheme_unittest after last commit

2015-11-03 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125877/#review87900 --- Ping - David Rosca On Oct. 29, 2015, 8:22 p.m., David

Re: Review Request 125877: Fix kdeplatformtheme_unittest after last commit

2015-11-03 Thread David Rosca
> On Oct. 29, 2015, 8:26 p.m., Aleix Pol Gonzalez wrote: > > autotests/kdeplatformtheme_unittest.cpp, line 237 > > <https://git.reviewboard.kde.org/r/125877/diff/1/?file=413361#file413361line237> > > > > What does `qApp->wheelScrollLines()

Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

2015-10-30 Thread David Rosca
> On Oct. 30, 2015, 7:34 p.m., Luca Beltrame wrote: > > It looks like this broke mouse wheel scrolling for me (on Qt 5.5.1): how > > can I debug to ensure this is the case and not a local issue? > > David Rosca wrote: > Broke in what way? Did you try if it w

Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

2015-10-30 Thread David Rosca
> On Oct. 30, 2015, 7:34 p.m., Luca Beltrame wrote: > > It looks like this broke mouse wheel scrolling for me (on Qt 5.5.1): how > > can I debug to ensure this is the case and not a local issue? > > David Rosca wrote: > Broke in what way? Did you try if it w

Review Request 125884: Set default value for WheelScrollLines

2015-10-30 Thread David Rosca
is not in kdeglobals. Thanks, David Rosca ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125911: EventGenerator: Add support for sending wheel events

2015-11-01 Thread David Rosca
t.reviewboard.kde.org/r/125911/#review87809 --- On Nov. 1, 2015, 10:53 a.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To repl

Re: Review Request 125877: Fix kdeplatformtheme_unittest after last commit

2015-11-07 Thread David Rosca
/diff/ Testing (updated) --- Tests pass Thanks, David Rosca ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125911: EventGenerator: Add support for sending wheel events

2015-11-02 Thread David Rosca
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 2e363913cc3b2b416a98df17420820f1d1bc37f5 by David Rosca to branch master. Repository: kdeclarative Description --- Add sendWheelEvent and sendWheelEventRecursive Diffs - src

Re: Review Request 125884: Set default value for WheelScrollLines

2015-11-02 Thread David Rosca
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 70c200431e02fc00ce1e496ead9e8f0980d24525 by David Rosca to branch master. Repository: frameworkintegration Description --- Use 3 (same as mouse kcm) as default value instead of QApplication

Re: Review Request 125877: Fix kdeplatformtheme_unittest after last commit

2015-11-06 Thread David Rosca
> On Oct. 29, 2015, 8:26 p.m., Aleix Pol Gonzalez wrote: > > autotests/kdeplatformtheme_unittest.cpp, line 237 > > <https://git.reviewboard.kde.org/r/125877/diff/1/?file=413361#file413361line237> > > > > What does `qApp->wheelScrollLines()

Install UdevQt headers in Solid

2015-11-05 Thread David Rosca
Hi, I was working on udev device notifier in kcm_keyboard [1] and ended up with using libudev directly. We are using libudev in various places, either directly or through Solid's UdevQt. But in the case of UdevQt, all projects using it have its own copy [2]. I think it would be better if Solid

Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

2015-10-30 Thread David Rosca
mmit? - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125863/#review87757 --- On Oct. 29, 2015, 7:01 p.m., Da

Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

2015-10-30 Thread David Rosca
> On Oct. 30, 2015, 7:34 p.m., Luca Beltrame wrote: > > It looks like this broke mouse wheel scrolling for me (on Qt 5.5.1): how > > can I debug to ensure this is the case and not a local issue? > > David Rosca wrote: > Broke in what way? Did you try if it w

Review Request 125691: KOpenWithDialog: Fix creating desktop file with empty mimetype

2015-10-18 Thread David Rosca
correctly returns valid KService. Thanks, David Rosca ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126242: KCoreAddons: Add WheelArea

2015-12-04 Thread David Rosca
t.reviewboard.kde.org/r/126242/#review89126 ------- On Dec. 4, 2015, 2:21 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To repl

Review Request 126242: KCoreAddons: Add WheelArea

2015-12-04 Thread David Rosca
is the correct place. Thanks, David Rosca ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126804: DragArea: Implement grabbing delegate item

2016-01-18 Thread David Rosca
::grabToImage is async, not sure how safe is to delay the start of drag. It seems to work without any issues though. Thanks, David Rosca ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Review Request 126806: DragDropEvent: Add ignore() function

2016-01-18 Thread David Rosca
://git.reviewboard.kde.org/r/126806/diff/ Testing --- Thanks, David Rosca ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127201: Fix svg icon path resolving in IconItem

2016-02-28 Thread David Rosca
autotests/iconitemtest.cpp (line 234) <https://git.reviewboard.kde.org/r/127201/#comment63315> Why? autotests/iconitemtest.cpp (line 253) <https://git.reviewboard.kde.org/r/127201/#comment63316> This should be `QSize(32, 32)` as the comment says? - David Rosca On Feb. 28, 2016,

Re: Review Request 127201: Fix svg icon path resolving in IconItem

2016-02-28 Thread David Rosca
> On Feb. 28, 2016, 9:58 a.m., David Rosca wrote: > > autotests/iconitemtest.cpp, line 234 > > <https://git.reviewboard.kde.org/r/127201/diff/2/?file=445755#file445755line234> > > > > Why? > > Xuetian Weng wrote: > Actually this check is n

Review Request 127180: kdeinit: Prefer loading libraries from RUNPATH

2016-02-25 Thread David Rosca
. Thanks, David Rosca ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127180: kdeinit: Prefer loading libraries from RUNPATH

2016-02-29 Thread David Rosca
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 4120bce6ae73043eca1a47c9c54fc308ff1c01af by David Rosca to branch master. Repository: kinit Description --- Prefer loading libraries from RUNPATH instead of only as fallback. Diffs

Re: Review Request 126804: DragArea: Implement grabbing delegate item

2016-01-21 Thread David Rosca
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126804/#review91400 --- On Jan. 18, 2016, 9 p.m., David Rosca wrote: > > --

Re: Review Request 126804: DragArea: Implement grabbing delegate item

2016-01-21 Thread David Rosca
n empty image, or an outdated one? > > I'm not entirely following the code, but I think the image should be > > redrawn when the drag starts, as the data may change and we definitely want > > to show the currently dragged data. > > David Rosca wrote: > No, at thi

Review Request 126836: DropArea: Fix correctly ignoring dragEnter event with preventStealing

2016-01-21 Thread David Rosca
Description --- temporaryInhibitParent must not be called when event is ignored. Diffs - src/qmlcontrols/draganddrop/DeclarativeDropArea.cpp 20d65e4 Diff: https://git.reviewboard.kde.org/r/126836/diff/ Testing --- Thanks, David Rosca

Re: Review Request 126804: DragArea: Implement grabbing delegate item

2016-01-21 Thread David Rosca
/DeclarativeDragArea.cpp ee78ff9 Diff: https://git.reviewboard.kde.org/r/126804/diff/ Testing --- QQuickItem::grabToImage is async, not sure how safe is to delay the start of drag. It seems to work without any issues though. Thanks, David Rosca

Re: Review Request 126804: DragArea: Implement grabbing delegate item

2016-01-21 Thread David Rosca
t max 6 icons (in case the mimeData has text, html and urls). - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126804/#review91417 ---

Re: Review Request 126804: DragArea: Implement grabbing delegate item

2016-01-21 Thread David Rosca
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 8ec771632fa9a5a83edafcc81af1c2a8b389cc10 by David Rosca to branch master. Repository: kdeclarative Description --- Implement grabbing image of delegate with QQuickItem::grabToImage. Diffs

Re: Review Request 126836: DropArea: Fix correctly ignoring dragEnter event with preventStealing

2016-01-22 Thread David Rosca
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 014b8a2d263fec83da760a50ef44572a423add1e by David Rosca to branch master. Repository: kdeclarative Description --- temporaryInhibitParent must not be called when event is ignored. Diffs

Re: Review Request 126806: DragDropEvent: Add ignore() function

2016-01-19 Thread David Rosca
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit b67a1ce3a14db308685f2f07ef740bb86ad48de7 by David Rosca to branch master. Repository: kdeclarative Description --- Add ignore() function to make it possible to reject events. Diffs

Re: Review Request 127091: Fix IconItem regression in 5.19

2016-02-16 Thread David Rosca
tps://git.reviewboard.kde.org/r/127091/#comment63045> I was just about to send the same fix! You can also check here for source.canConver(), but that's just a cosmetic change. Otherwise, +1 from me. - David Rosca On Feb. 16, 2016, 4:52 p.m., Daniel Vrátil

Re: Review Request 127374: Fix taskbar flicking when opening Plasma popups

2016-03-15 Thread David Rosca
the _NET_WM_STATE hints are reset by Qt before Expose event, not in Show event. But I'm not sure about this one (didn't look in the code). My patch however fixes it correctly :) - David Rosca On March 15, 2016, 2:36 p.m., David Edmundson wrote

Re: Review Request 127587: [Kate view] Correct override cursor

2016-04-08 Thread David Rosca
> On April 8, 2016, 7:29 a.m., Kåre Särs wrote: > > What is it that needs fixing? > > > > I don't have a problem in either case listed. > > Emmanuel Pescosta wrote: > > 3. Context menu is closed > > I can reproduce this problem > > Anthony Fieroni wrote: > Drag file from

Review Request 127469: Use QQuickWidget for QML KCMs

2016-03-23 Thread David Rosca
/127469/diff/ Testing --- Popups are now in correct position in systemsettings and kcmshell Thanks, David Rosca ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127469: Use QQuickWidget for QML KCMs

2016-03-23 Thread David Rosca
/kcmoduleqml.cpp c52769b Diff: https://git.reviewboard.kde.org/r/127469/diff/ Testing --- Popups are now in correct position in systemsettings and kcmshell Thanks, David Rosca ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 127469: Use QQuickWidget for QML KCMs

2016-03-23 Thread David Rosca
y, visit: https://git.reviewboard.kde.org/r/127469/#review93895 ------- On March 23, 2016, 10:29 a.m., David Rosca wrote: > > --- > This is an automatically gener

Re: Review Request 127280: Fix memory leak in icon item test

2016-03-04 Thread David Rosca
this is needed. - David Rosca On March 4, 2016, 8:37 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 127268: Docs for IconItem

2016-03-03 Thread David Rosca
t please use your (better) wording. - David Rosca On March 3, 2016, 5:36 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revi

Re: Review Request 127534: Fallback to QCommonStyle implementation of standardIcon

2016-03-31 Thread David Rosca
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit ead5b1caa2c3790e955b1e52edcbe37d8764cd70 by David Rosca to branch master. Repository: frameworkintegration Description --- Fixes showing clear button in QLineEdit with Qt 5.7 Diffs

Review Request 127534: Fallback to QCommonStyle implementation of standardIcon

2016-03-31 Thread David Rosca
Description --- Fixes showing clear button in QLineEdit with Qt 5.7 Diffs - src/kstyle/kstyle.cpp 240625b Diff: https://git.reviewboard.kde.org/r/127534/diff/ Testing --- Thanks, David Rosca ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 127469: Use QQuickWidget for QML KCMs

2016-05-20 Thread David Rosca
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 23b6468fc2486516711ba4ce50f3492fd231d50e by David Rosca to branch master. Bugs: 359124 https://bugs.kde.org/show_bug.cgi?id=359124 Repository: kcmutils Description --- Fix position

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

2016-05-06 Thread David Rosca
tps://git.reviewboard.kde.org/r/127850/#comment64608> braces also with one line - David Rosca On May 6, 2016, 3:56 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.rev

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

2016-05-06 Thread David Rosca
-workspace.git=commit=1b6231f2e3f1de8cb5ea2540f0b8f425f6ae43a3 in Plasma/5.6 - David Rosca On May 6, 2016, 3:56 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

2016-05-10 Thread David Rosca
> On May 6, 2016, 4:08 p.m., David Rosca wrote: > > It will also need > > https://quickgit.kde.org/?p=plasma-workspace.git=commit=1b6231f2e3f1de8cb5ea2540f0b8f425f6ae43a3 > > in Plasma/5.6 > > Aleix Pol Gonzalez wrote: > No, it's already called by `

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

2016-05-10 Thread David Rosca
> On May 6, 2016, 4:08 p.m., David Rosca wrote: > > It will also need > > https://quickgit.kde.org/?p=plasma-workspace.git=commit=1b6231f2e3f1de8cb5ea2540f0b8f425f6ae43a3 > > in Plasma/5.6 > > Aleix Pol Gonzalez wrote: > No, it's already called by `ShellCoro

  1   2   >