Re: Review Request 128011: Allow using new style connect syntax with KStandardAction::create()

2016-05-25 Thread Gleb Popov
d511778 src/kstandardaction.cpp 216d3d6 Diff: https://git.reviewboard.kde.org/r/128011/diff/ Testing --- Thanks, Gleb Popov ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 128011: Allow using new style connect syntax with KStandardAction::create()

2016-05-26 Thread Gleb Popov
NDARDACTION_WITH_NEW_STYLE_CONNECT ``` - Gleb --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128011/#review95810 ---

Re: Review Request 128011: Allow using new style connect syntax with KStandardAction::create()

2016-05-26 Thread Gleb Popov
/kstandardaction.cpp 216d3d6 Diff: https://git.reviewboard.kde.org/r/128011/diff/ Testing --- Thanks, Gleb Popov ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127911: Add a CMake option to build binary Qt resource out of icons dir.

2016-06-01 Thread Gleb Popov
program to replace the symlinked files with aliases > > in the .qrc as symlinks do not work properly on windows. Are you interested > > in adding a similar program/script/... to do the same directly in > > breeze-icons.git? My application is in > > git://anongit.kde.org

Re: Review Request 128072: add missing type_traits include making sure std::enable_if is declared

2016-06-01 Thread Gleb Popov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128072/#review96121 --- Ship it! Ship It! - Gleb Popov On June 1, 2016, 11:09

Re: Review Request 128011: Allow using new style connect syntax with KStandardAction::create()

2016-05-31 Thread Gleb Popov
marked as submitted. Review request for KDE Frameworks, Alex Richardson and David Faure. Changes --- Submitted with commit 9395482e8b74d9954ea3b333eca286360688d0d4 by Gleb Popov to branch master. Repository: kconfigwidgets Description --- This is https://git.reviewboard.kde.org/r

Re: Review Request 127686: Provide a way to disable FAM and inotify use in KDirWatch.

2016-04-22 Thread Gleb Popov
--- Thanks, Gleb Popov ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2016-05-20 Thread Gleb Popov
> On April 5, 2015, 5:26 p.m., David Faure wrote: > > Well, +1 for the idea. But I wonder what the apidox will look like, the > > macro+template probably don't make it work. > > > > Also missing @since 5.10. > > > > Ship it from me once the apidox issue is resolved. What apidox issue is

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2016-05-22 Thread Gleb Popov
> On April 5, 2015, 5:26 p.m., David Faure wrote: > > Well, +1 for the idea. But I wonder what the apidox will look like, the > > macro+template probably don't make it work. > > > > Also missing @since 5.10. > > > > Ship it from me once the apidox i

Re: Review Request 127911: Add a CMake option to build binary Qt resource out of icons dir.

2016-05-17 Thread Gleb Popov
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 9948305e18b00bd282aa16a7d8e29dcd9622c29d by Gleb Popov to branch master. Repository: breeze-icons Description --- I copied icons into the binary dir, because i haven't found a way to generate

Re: Review Request 127911: Add a CMake option to build binary Qt resource out of icons dir.

2016-05-16 Thread Gleb Popov
-dark/CMakeLists.txt 36d37f1 icons/CMakeLists.txt 5ded49c Diff: https://git.reviewboard.kde.org/r/127911/diff/ Testing --- Thanks, Gleb Popov ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 127911: Add a CMake option to build binary Qt resource out of icons dir.

2016-05-16 Thread Gleb Popov
o reply, visit: https://git.reviewboard.kde.org/r/127911/#review95485 --- On May 16, 2016, 9:21 a.m., Gleb Popov wrote: > > --- > This is an automatically

Re: Review Request 127911: Add a CMake option to build binary Qt resource out of icons dir.

2016-05-16 Thread Gleb Popov
) - CMakeLists.txt 2147705 icons-dark/CMakeLists.txt 36d37f1 icons/CMakeLists.txt 5ded49c Diff: https://git.reviewboard.kde.org/r/127911/diff/ Testing --- Thanks, Gleb Popov ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 127911: Add a CMake option to build binary Qt resource out of icons dir.

2016-05-16 Thread Gleb Popov
. Diffs (updated) - icons/CMakeLists.txt 5ded49c Diff: https://git.reviewboard.kde.org/r/127911/diff/ Testing --- Thanks, Gleb Popov ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 127686: Provide a way to disable FAM and inotify use in KDirWatch.

2016-05-05 Thread Gleb Popov
marked as submitted. Review request for KDE Frameworks, Aleix Pol Gonzalez and David Faure. Changes --- Submitted with commit 359e837f6c18d528d3b5febff34e1a174448d04e by Gleb Popov to branch master. Repository: kcoreaddons Description --- This is useful for distribution package

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

2016-04-18 Thread Gleb Popov
for this: - Add another macro. If we go this route, can we put it in the same .cmake file? - Add a keyword parameter to the existing macro. Because macro uses `${ARGN}` it shouldn't break anything. - Gleb Popov On Dec. 3, 2015, 11 a.m., Kevin Funk wrote

Re: Review Request 127686: Provide a way to disable FAM and inotify use in KDirWatch.

2016-04-19 Thread Gleb Popov
, Gleb Popov ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127686: Provide a way to disable FAM and inotify use in KDirWatch.

2016-04-21 Thread Gleb Popov
://git.reviewboard.kde.org/r/127686/diff/ Testing --- Thanks, Gleb Popov ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128011: Allow using new style connect syntax with KStandardAction::create()

2016-05-25 Thread Gleb Popov
/ Testing --- Thanks, Gleb Popov ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: breeze-icons and the symlink business

2017-02-02 Thread Gleb Popov
On Thu, Feb 2, 2017 at 2:49 AM, Harald Sitter wrote: > hola > > breeze-icons uses lots of symlinks. Unfortunately, ever so often our > icon designers make a mistake and create a bad symlink. To mitigate > this I added a bunch of tests making sure everything is nice and > dandy. >

Re: Review Request 128855: Fix build on Windows

2016-09-08 Thread Gleb Popov
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 739321ad95994fde874d8e09b698c465cc52b9ec by Gleb Popov to branch master. Repository: kio Description --- Windows doesn't have `S_IRUSR` & co defines, so use what it has and stub

Review Request 128855: Fix build on Windows

2016-09-07 Thread Gleb Popov
--- Windows doesn't have `S_IRUSR` & co defines, so use what it has and stub out remainings. Diffs - src/core/slavebase.cpp 4b8f460 Diff: https://git.reviewboard.kde.org/r/128855/diff/ Testing --- Thanks, Gleb Popov

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

2016-09-15 Thread Gleb Popov
> On Sept. 15, 2016, 3:01 p.m., Gleb Popov wrote: > > autotests/kconfigtest.cpp, line 1378 > > <https://git.reviewboard.kde.org/r/128916/diff/1/?file=476914#file476914line1378> > > > > I'd put both `cgLocal.writeEntry("someLocalString", &qu

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

2016-09-15 Thread Gleb Popov
tps://git.reviewboard.kde.org/r/128916/#comment66803> getuid() isn't present on Windows. Guard this check with `#ifndef Q_OS_WIN`. - Gleb Popov On Sept. 15, 2016, 4:20 p.m., Evgeniy Sadovnik wrote: > > --- > This is an automatically g

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

2016-09-16 Thread Gleb Popov
org/r/128916/ > --- > > (Updated Sept. 16, 2016, 10:17 a.m.) > > > Review request for KDE Frameworks and Gleb Popov. > > > Repository: kconfig > > > Description > --- > > The test checks that saving a read-only config file fails. But because root > can

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

2016-10-09 Thread Gleb Popov
tps://git.reviewboard.kde.org/r/129122/#comment67101> Why search in `KDE_INSTALL` folders? `ulog-helper` comes with base and should always be in `/usr/libexec`, no? - Gleb Popov On Oct. 8, 2016, 9:37 p.m., Tobias Berner

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

2016-09-15 Thread Gleb Popov
org/r/128916/#comment66800> I'd put both `cgLocal.writeEntry("someLocalString", "whatever2");` and `QVERIFY(!cgLocal.sync());` inside else clause. - Gleb Popov On Sept. 15, 2016, 2:59 p.

Re: Review Request 128916: kconfig: Make test XFAIL when running as root

2016-09-16 Thread Gleb Popov
isit: > https://git.reviewboard.kde.org/r/128916/ > --- > > (Updated Sept. 16, 2016, 10:17 a.m.) > > > Review request for KDE Frameworks and Gleb Popov. > > > Repository: kconfig > > > Description > -

Re: Review Request 128855: Fix build on Windows

2016-09-07 Thread Gleb Popov
" ``` - Gleb --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128855/#review98981 --- On Sept. 7, 2016, 6:23 p.m

Review Request 129020: Fix find invocation in validate_svg.sh on FreeBSD.

2016-09-26 Thread Gleb Popov
://git.reviewboard.kde.org/r/129020/diff/ Testing --- Thanks, Gleb Popov

Re: Review Request 129020: Fix find invocation in validate_svg.sh on FreeBSD.

2016-09-26 Thread Gleb Popov
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 9e0466a1996717e44ca8c3842abd304d69af7ea7 by Gleb Popov to branch master. Repository: breeze-icons Description --- Without this patch the build was failing with ``` find: illegal option -- n

Re: Review Request 128112: New module: ecm_win_resolve_symlinks

2016-11-05 Thread Gleb Popov
marked as submitted. Review request for Extra Cmake Modules and KDE Frameworks. Changes --- Submitted with commit 632b8868de38e2f85fb4969bcae3dd89a2a0695c by Gleb Popov to branch master. Repository: extra-cmake-modules Description --- When git is checking out repositories with UNIX

Re: Review Request 129122: Try to use ulog-helper if utempter does not exist

2016-10-19 Thread Gleb Popov
ner wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129122/ > --- > > (Updated Oct. 19, 2016, 10:51 p.m.) > > > Review request for KDE Frameworks, Adriaan de G

Re: Review Request 129244: Make UDisks2 backend compile on FreeBSD (and, possibly, other UNIXes).

2016-10-31 Thread Gleb Popov
://git.reviewboard.kde.org/r/129244/diff/ Testing --- Thanks, Gleb Popov

Re: Review Request 129197: Fix tests on FreeBSD

2016-10-31 Thread Gleb Popov
> On Oct. 16, 2016, 4:12 p.m., Tobias Berner wrote: > > I'm kind of unsure if this is right. Yes, the tests run now, but isn't the > > issue rather in the way kpty works (or fails to work on FreeBSD)? > > Gleb Popov wrote: > From what i've und

Re: Review Request 129244: Make UDisks2 backend compile on FreeBSD (and, possibly, other UNIXes).

2016-10-31 Thread Gleb Popov
marked as submitted. Review request for KDE Frameworks and Solid. Changes --- Submitted with commit 9bca1fd1993665a2233e0155a1baf9973c7a4b6f by Gleb Popov to branch master. Repository: solid Description --- This patch makes Solid UDisks2 backend compile on FreeBSD. Diffs

Re: Review Request 129197: Fix tests on FreeBSD

2016-10-16 Thread Gleb Popov
haves different on Linux. - Gleb --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129197/#review100039 --- On Oct. 16, 2016, 2:4

Review Request 129197: Fix tests on FreeBSD

2016-10-16 Thread Gleb Popov
/kptyprocesstest.cpp 8b0b5b0 Diff: https://git.reviewboard.kde.org/r/129197/diff/ Testing --- make test on FreeBSD Thanks, Gleb Popov

Review Request 129590: KAuth: Make D-Bus dependency optional.

2016-11-30 Thread Gleb Popov
autotests/CMakeLists.txt b53d760 src/CMakeLists.txt 1b6930d Diff: https://git.reviewboard.kde.org/r/129590/diff/ Testing --- Thanks, Gleb Popov

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

2017-03-23 Thread Gleb Popov
arrowdodger accepted this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D5138 To: tcberner, adridg, arrowdodger, rakuco, dfaure Cc: #frameworks

D6087: Haskell: Add all language pragmas as keywords.

2017-06-29 Thread Gleb Popov
arrowdodger added a comment. So, can I push this? REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D6087 To: arrowdodger, #framework_syntax_hightlighting, dhaumann Cc: dhaumann, #frameworks

D6087: Haskell: Add all language pragmas as keywords.

2017-06-29 Thread Gleb Popov
This revision was automatically updated to reflect the committed changes. Closed by commit R216:d2a38d790914: Haskell: Add all language pragmas as keywords. (authored by arrowdodger). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D6087: Haskell: Add all language pragmas as keywords.

2017-06-29 Thread Gleb Popov
arrowdodger updated this revision to Diff 15981. arrowdodger added a comment. Added autotests. Not sure if .ref file should be updated, as the tests pass as they are now. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6087?vs=15772=15981

D6087: Haskell: Add all language pragmas as keywords.

2017-06-29 Thread Gleb Popov
arrowdodger updated this revision to Diff 15982. arrowdodger added a comment. Updated reference file for autotest as well. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6087?vs=15981=15982 BRANCH master REVISION DETAIL

D6430: Add syntax definition for julius language.

2017-06-29 Thread Gleb Popov
arrowdodger abandoned this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6430 To: arrowdodger Cc: #frameworks

D6430: Add syntax definition for julius language.

2017-06-29 Thread Gleb Popov
arrowdodger created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D6430 AFFECTED FILES data/syntax/julius.xml To:

D5890: Pass `--key-positions=*` to gperf instead of `-k *` because on Windows this symbol seems to have a special meaning.

2017-05-18 Thread Gleb Popov
This revision was automatically updated to reflect the committed changes. Closed by commit R313:07a8a4e6985c: Pass `--key-positions=*` to gperf instead of `-k *` because on Windows this… (authored by arrowdodger). REPOSITORY R313 KHtml CHANGES SINCE LAST UPDATE

D5890: Pass `--key-positions=*` to gperf instead of `-k *` because on Windows this symbol seems to have a special meaning.

2017-05-18 Thread Gleb Popov
arrowdodger added a comment. In https://phabricator.kde.org/D5890#110586, @bcooksley wrote: > This looks good to me. Would this also resolve https://build-sandbox.kde.org/view/Frameworks/job/Frameworks%20kcodecs%20kf5-qt5%20WindowsQt5.7/6/console ? > Invalid position value

D6087: Haskell: Add all language pragmas as keywords.

2017-06-23 Thread Gleb Popov
arrowdodger added a comment. In https://phabricator.kde.org/D6087#118963, @dhaumann wrote: > Demo for the highlighting rule - I don't think I can say anything to the auto completion issue. I am pretty sure it is unrelated to your xml file. Sure. Pragmas have following form:

D6087: Haskell: Add all language pragmas as keywords.

2017-06-23 Thread Gleb Popov
arrowdodger added a comment. In https://phabricator.kde.org/D6087#117019, @dhaumann wrote: > Also: could you provide us with a small demo code so that we can extend our unit test? The demo for added highlighting rule, or the problem with autocompletion? REPOSITORY R216 Syntax

D6087: Haskell: Add all language pragmas as keywords.

2017-06-23 Thread Gleb Popov
arrowdodger updated this revision to Diff 15772. arrowdodger added a comment. - Use WordDetect instead of StringDetect for `omport` keyword. - Pop `Pragma` context on `#-}` string, not newline. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D5890: Pass `--key-positions=*` to gperf instead of `-k *` because on Windows this symbol seems to have a special meaning.

2017-05-16 Thread Gleb Popov
arrowdodger created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Pass `--key-positions=*` to gperf instead of `-k *` because on Windows this symbol seems to have a special meaning. TEST PLAN Successfully compiled with MSVC. REPOSITORY R313 KHtml

D6087: Haskell: Add all language pragmas as keywords.

2017-06-04 Thread Gleb Popov
arrowdodger created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D6087 AFFECTED FILES data/syntax/haskell.xml To:

D6087: Haskell: Add all language pragmas as keywords.

2017-06-04 Thread Gleb Popov
arrowdodger edited the summary of this revision. arrowdodger edited the test plan for this revision. arrowdodger added a reviewer: Framework: Syntax Hightlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6087 To: arrowdodger,

D6102: KUrlRequester: Set NOTIFY signal to textChanged() for text property.

2017-06-05 Thread Gleb Popov
arrowdodger created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Having `NOTIFY textChanged` on `text` property may come useful when using KUrlRequester with KConfig. KUrlRequester field may hold paths for executables and sometimes it is more convenient

D6101: Work-around MSVC2017 compiler bug

2017-06-05 Thread Gleb Popov
arrowdodger accepted this revision. This revision is now accepted and ready to land. REPOSITORY R279 ThreadWeaver BRANCH master REVISION DETAIL https://phabricator.kde.org/D6101 To: kfunk, arrowdodger, bcooksley Cc: #frameworks

D6087: Haskell: Add all language pragmas as keywords.

2017-06-07 Thread Gleb Popov
arrowdodger added a comment. I just found that the same problem exists for `import_keywords` too - when I type `import qual`, the completion doesn't show up, and deleteting `qual` and typing it again causes it to show. So, it seems to be a coding bug. REPOSITORY R216 Syntax

D6102: KUrlRequester: Set NOTIFY signal to textChanged() for text property.

2017-06-12 Thread Gleb Popov
This revision was automatically updated to reflect the committed changes. Closed by commit R241:f7dfb713a852: KUrlRequester: Set NOTIFY signal to textChanged() for text property. (authored by arrowdodger). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D17938: Add support for passing cursor information to KRun.

2019-01-03 Thread Gleb Popov
arrowd created this revision. arrowd added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. arrowd requested review of this revision. REVISION SUMMARY This is the KIO part of https://bugs.kde.org/show_bug.cgi?id=398998 TEST PLAN

D17938: Add support for passing cursor information to KRun.

2019-01-05 Thread Gleb Popov
arrowd added a comment. In D17938#386985 , @elvisangelaccio wrote: > I don't know, "cursorRow" and "cursorColumn" are pretty editor-specific. I'm not sure they make sense in the KRun API. I'd say they are both filetype-specific and

D17938: Add support for passing cursor information to KRun.

2019-01-15 Thread Gleb Popov
arrowd abandoned this revision. arrowd added a comment. Right. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17938 To: arrowd, #frameworks Cc: aacid, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

2019-04-06 Thread Gleb Popov
arrowd added a comment. In D18296#444642 , @elvisangelaccio wrote: > Is it really necessary to copy `urlinfo.h` here? Wouldn't be enough to just create a static function and put the URL parsing logic there? I just copied this from Kate

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

2019-04-06 Thread Gleb Popov
arrowd added inline comments. INLINE COMMENTS > elvisangelaccio wrote in urlinfo.h:45-52 > Why doesn't it parse the URL if the file already exists? If the file is named `foo:123`, it refuses to search for cursor infomation and just open it. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

2019-04-10 Thread Gleb Popov
arrowd added inline comments. INLINE COMMENTS > dfaure wrote in urlinfo.h:77 > But then you can't do `kde-open5 www.google.fr` anymore, right? > > I see what you mean with typo handling, but there is no perfect solution. > Either we treat typos as URLs (but it means we also treat actual URLs

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

2019-04-10 Thread Gleb Popov
arrowd updated this revision to Diff 55879. arrowd marked 5 inline comments as done. arrowd added a comment. Address comments. REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18296?vs=54774=55879 BRANCH cursor REVISION DETAIL

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

2019-04-11 Thread Gleb Popov
This revision was automatically updated to reflect the committed changes. Closed by commit R126:8072a6acf221: Add support for passing cursor information via URL parameters when running… (authored by arrowd). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18296?vs=55879=55973#toc

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

2019-04-11 Thread Gleb Popov
arrowd marked an inline comment as done. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D18296 To: arrowd, #plasma, #ktexteditor, broulik, #frameworks, pino, cfeck, dfaure, elvisangelaccio Cc: apol, cullmann, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D18296: Add support for passing cursor information via URL parameters when running kioclient exec.

2019-04-08 Thread Gleb Popov
arrowd added a comment. In D18296#445829 , @dfaure wrote: > Is the makeURL function still used, or should it be removed now? Yep, it is still used in a bunch of other places. INLINE COMMENTS > dfaure wrote in urlinfo.h:39 > const

D20967: [UserMetaData] Add method to query which attributes are set

2019-06-10 Thread Gleb Popov
arrowd added a comment. In D20967#477314 , @bruns wrote: > Apparently, the usermetadatawritertest was not executed on *BSD before, can you check if the test succeeds on the old code? Yep, it works on master. The output with

D21720: Enable usermetadatawritertest for all UNIXes, not only Linux.

2019-06-10 Thread Gleb Popov
This revision was automatically updated to reflect the committed changes. Closed by commit R286:346918916474: Enable usermetadatawritertest for all UNIXes, not only Linux. (authored by arrowd). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D20967: [UserMetaData] Add method to query which attributes are set

2019-06-10 Thread Gleb Popov
arrowd added a comment. Now the test passes! INLINE COMMENTS > xattr_p.h:194 > +{ > +int pos; > +QList entries; variable 'pos' is uninitialized REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns, #baloo, #frameworks, astippich, ngraham

D20967: [UserMetaData] Add method to query which attributes are set

2019-06-10 Thread Gleb Popov
arrowd added a comment. It compiles now, but the test fails: * Start testing of UserMetaDataWriterTest * Config: Using QtTest library 5.12.2, Qt 5.12.2 (x86_64-little_endian-lp64 shared (dynamic) release build; by Clang 8.0.0 (tags/RELEASE_800/final 356365))

D21720: Enable usermetadatawritertest for all UNIXes, not only Linux.

2019-06-10 Thread Gleb Popov
arrowd created this revision. arrowd added reviewers: Frameworks, bruns. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. arrowd requested review of this revision. TEST PLAN The test passes on FreeBSD. REPOSITORY R286 KFileMetaData BRANCH

D20967: [UserMetaData] Add method to query which attributes are set

2019-06-10 Thread Gleb Popov
arrowd added inline comments. INLINE COMMENTS > xattr_p.h:204 > +#elif defined(Q_OS_FREEBSD) || defined(Q_OS_NETBSD) > +const ssize_t size = extattr_list_file(encodedPath, > EXTATTR_NAMESPACE_USER, attributeName, nullptr, 0); > +#endif error: use of undeclared identifier

D21380: show static word wrap marker always if requested

2019-05-24 Thread Gleb Popov
arrowd accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D21380 To: cullmann, #ktexteditor, #frameworks, arrowd Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham,

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

2019-07-20 Thread Gleb Popov
arrowd added a comment. In D22525#498393 , @dfaure wrote: > I suppose the kate developers like the fact that this currently works over FTP, SFTP, FISH, SMB, etc. > So maybe only HTTP[S]/WEBDAV should be blacklisted (because there queries

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

2019-07-20 Thread Gleb Popov
arrowd added a comment. I'm not familiar with KDE release engineering, so I'm asking to do merging someone else. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd, #frameworks, dfaure Cc: wbauer, kwrite-devel, dfaure, cfeck, plasma-devel,

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

2019-07-20 Thread Gleb Popov
This revision was automatically updated to reflect the committed changes. Closed by commit R126:6d86fd453417: kioclient: Dont convert `:x:y` to `?line=xcolumn=y` for URLs starting with… (authored by arrowd). REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

2019-07-18 Thread Gleb Popov
arrowd created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. arrowd requested review of this revision. REVISION SUMMARY BUG: 408632 TEST PLAN `kioclient5 exec http://localhost:9000` now works correctly. REPOSITORY R126 KDE CLI Utilities BRANCH

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

2019-07-18 Thread Gleb Popov
arrowd added a comment. In D22525#497332 , @cfeck wrote: > Could we only apply the `:xx` check on the filename part, not on the server part? Someone might expect that `http://path.to/file.txt:99` also works for remote files. I don't

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

2019-07-19 Thread Gleb Popov
arrowd added a comment. In D22525#497556 , @cfeck wrote: > Oh, if the latter syntax also works, then you are right. Not sure what you mean by "also works". Current code checks if the URL ends with `:x:y` and turns it into `?line=x=y`.

D22525: kioclient: Don't convert `:x:y` to `?line=x=y` for URLs starting with remote schemes.

2019-07-19 Thread Gleb Popov
arrowd added a reviewer: Frameworks. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22525 To: arrowd, #frameworks Cc: cfeck, plasma-devel, #frameworks, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed,

Re: Does FreeBSD have HAL?

2020-01-05 Thread Gleb Popov
On Sun, Jan 5, 2020 at 1:06 PM Tobias C. Berner wrote: > Moin moin > > We will replace (ancient) hal with Gleb's implementation of usdisks2 > "bsdisks2" in the near future by default. > > Hald is likely not enabled on the CI hosts -- I could enable it :) -- > or we could push the switch and make

Re: Does FreeBSD have HAL?

2020-01-05 Thread Gleb Popov
On Sun, Jan 5, 2020 at 3:37 PM Tijl Coosemans wrote: > On Sun, 5 Jan 2020 10:06:08 +0100 "Tobias C. Berner" > wrote: > > Moin moin > > > > We will replace (ancient) hal with Gleb's implementation of usdisks2 > > "bsdisks2" in the near future by default. > > > > Hald is likely not enabled on the

D17816: Support for xattrs on kio copy/move

2020-05-17 Thread Gleb Popov
arrowd updated this revision to Diff 83016. arrowd added a comment. - Fix tests on FreeBSD. - Fix bug: Move `keylist.squeeze()` call before acquiring an interator. At this stage, all tests in `jobtest` pass on FreeBSD. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D17816: Support for xattrs on kio copy/move

2020-05-15 Thread Gleb Popov
arrowd updated this revision to Diff 82960. arrowd added a comment. I decided to help with this a bit. - Fix detection of header. It requires to be included too. - Implement test helpers for BSD (extattr). At the moment, some tests fail for me, because xattrs don't seem to be

D17816: Support for xattrs on kio copy/move

2020-05-15 Thread Gleb Popov
arrowd commandeered this revision. arrowd added a reviewer: cochise. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, anthonyfieroni, tmarshall, arrowd, cfeck, bruns,

D17816: Support for xattrs on kio copy/move

2020-05-19 Thread Gleb Popov
arrowd updated this revision to Diff 83068. arrowd marked 18 inline comments as done. arrowd added a comment. - Use full paths to command line utilities and pass xattr args correctly. - Mark some stale comments as done. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D17816: Support for xattrs on kio copy/move

2020-05-24 Thread Gleb Popov
arrowd updated this revision to Diff 83143. arrowd marked 5 inline comments as done. arrowd added a comment. - Refactor common code from compareXattr() into readXattr() as requested in comments. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D17816: Support for xattrs on kio copy/move

2020-09-06 Thread Gleb Popov
arrowd updated this revision to Diff 83361. arrowd marked an inline comment as done. arrowd added a comment. - Return "true" if the file doesn't have any xattrs. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=83334=83361 BRANCH arcpatch-D17816 REVISION DETAIL

D17816: Support for xattrs on kio copy/move

2020-09-10 Thread Gleb Popov
arrowd updated this revision to Diff 83364. arrowd marked 2 inline comments as done. arrowd added a comment. - Make checkXattrFsSupport accept directory as a parameter. - Consitify QStrings. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=83361=83364 BRANCH

D17816: Support for xattrs on kio copy/move

2020-10-17 Thread Gleb Popov
arrowd added a comment. Another bump. REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham,

D17816: Support for xattrs on kio copy/move

2020-08-25 Thread Gleb Popov
arrowd added a comment. Bump. REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham, atha.kane,

D17816: Support for xattrs on kio copy/move

2020-09-16 Thread Gleb Popov
arrowd added inline comments. INLINE COMMENTS > usta wrote in file_unix.cpp:1517 > isnt this ignoring acl_from_mode part ? I mean not sure but i think we need > to check if it is nullptr or not before assigning it otherwise we will ignore > the acl_from_mode part. You seem to be right. I

D17816: Support for xattrs on kio copy/move

2020-09-16 Thread Gleb Popov
arrowd updated this revision to Diff 83365. arrowd marked an inline comment as done. arrowd added a comment. - More const QString. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=83364=83365 BRANCH arcpatch-D17816 REVISION DETAIL https://phabricator.kde.org/D17816

D17816: Support for xattrs on kio copy/move

2020-09-16 Thread Gleb Popov
arrowd added inline comments. INLINE COMMENTS > bruns wrote in jobtest.cpp:780 > And now you **only** check the source FS, but no longer the destination FS. To be honest, I was confused by your first comment. What was wrong with the first version of this code? My understanding was that we

D17816: Support for xattrs on kio copy/move

2020-05-27 Thread Gleb Popov
arrowd marked an inline comment as done. arrowd added a comment. Mark stale command as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, tmarshall, arrowd, cfeck,

D17816: Support for xattrs on kio copy/move

2020-05-27 Thread Gleb Popov
arrowd updated this revision to Diff 83166. arrowd marked an inline comment as done. arrowd added a comment. - Use std::function to store a generator function for m_setXattrCmd's arguments. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=83143=83166

D17816: Support for xattrs on kio copy/move

2020-06-01 Thread Gleb Popov
arrowd updated this revision to Diff 83192. arrowd marked 2 inline comments as done. arrowd added a comment. - Change the algorithm in FileProtocol::copyXattrs() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=83166=83192 BRANCH arcpatch-D17816

D17816: Support for xattrs on kio copy/move

2020-06-01 Thread Gleb Popov
arrowd marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: arrowd, dfaure, chinmoyr, bruns, #frameworks, tmarshall, usta, cochise Cc: usta, scheirle, tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino,

  1   2   >