D15739: [Places panel] Don't show Root by default

2018-11-08 Thread Hazem Salem
Codezela added a comment. there is 2 alternatives 1. remove the icon from devices section and keep it in places section with some icon change in the top one 2. keep it in the places section but change the label to root or system and it will always be top of all other hd with the

D15739: [Places panel] Don't show Root by default

2018-11-08 Thread Hazem Salem
Codezela added a comment. In D15739#356310 , @ndavis wrote: > In D15739#356309 , @Codezela wrote: > > > i know that the icons size is adjustable i mean make the default more bigger first time u run

D15739: [Places panel] Don't show Root by default

2018-11-08 Thread Hazem Salem
Codezela added a comment. In D15739#356269 , @ndavis wrote: > In D15739#356026 , @Codezela wrote: > > > maybe there is 2 alternatives > > > > 1. remove the icon from devices section and keep it

D17617: Display error instead of silently failing when asked to create folder that already exists

2018-12-15 Thread Hazem Salem
Codezela added a comment. can we change enter different name to just rename for simplicity REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17617 To: ngraham, #dolphin Cc: Codezela, kde-frameworks-devel, michaelh, ngraham, bruns

D18545: [breeze desktop theme/Notifications] WIP, Add rounded corners to notifications (dialogs)

2019-01-26 Thread Hazem Salem
Codezela added a comment. can i talk about other thing why the vlise button have this circle around it i think it will look cleaner with simple border strock or with only the close red circle REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

2019-02-05 Thread Hazem Salem
Codezela added a comment. how about make it global under beside add image button aligned left tow buttons disablef by default REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649 To: ngraham, #vdg, #plasma, broulik Cc: Codezela, bruns, rizzitello, ndavis,

D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

2019-02-05 Thread Hazem Salem
Codezela added a comment. another option we put the delete button only and align it to the corner of the thumbnail make it circle button and ditch the other one no need for it here what do u think REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D18649

D20367: Add alternatives icon

2019-04-09 Thread Hazem Salem
Codezela added a comment. I think in small size it will be difficult to recognize this icon because it has a lot of datils we need to use more simple version of it I found this on the web as example of what I mean we can review them as a base

D23685: Make user-trash icons look like trashcans

2019-09-03 Thread Hazem Salem
Codezela added a comment. I think they looks different The shadow on the empty one make it looks very flat Or maybe squashed The full state looks better REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23685 To: ndavis, #vdg, ngraham Cc: Codezela, ngraham,

D23650: Add an icon for the trash root and a proper label

2019-09-02 Thread Hazem Salem
Codezela added a comment. Why trash icon don't look like trash Like any other os REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D23650 To: meven, ngraham, #frameworks, broulik Cc: Codezela, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh,