Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

2015-12-25 Thread Jaime Torres Amate
> On Dec. 17, 2015, 4:16 p.m., Martin Gräßlin wrote: > > Hello, This is just a warning to know if this patch has been tested in a two monitor environment in a laptop. In a pyqt application I save and restore the size and position of the window (without additional checks), using:

Re: Review Request 126324: [MSWin/OS X] save and restore window geometry instead of only size (WIP/Suggestion)

2015-12-25 Thread Jaime Torres Amate
> On Dec. 17, 2015, 4:16 p.m., Martin Gräßlin wrote: > > > > Jaime Torres Amate wrote: > Hello, > > This is just a warning to know if this patch has been tested in a two > monitor environment in a laptop. > In a pyqt application I save and

Re: Review Request 128466: Rename Checksums tab to Integrity

2016-07-18 Thread Jaime Torres Amate
> On July 18, 2016, 12:05 p.m., Sebastian Kügler wrote: > > Please don't ship it, yet. > > > > > > I find the UI illogical. There's a groupbox grouping the checksum buttons, > > but then you can input the checksum above, so essentially, the groupbox is > > unnecessary and confusing. > > > >

Re: Review Request 128627: avoid crash starting kate with QT_FATAL_WARNINGS=1

2016-08-08 Thread Jaime Torres Amate
it::*)(QLineEdit * const, const QString &)) 0x764d34b0 <QLineEdit::textChanged(QString const&)>, sender=0x0) at /usr/include/qt5/QtCore/qobject.h:239 applying the patch, kate starts (there is no connect from null) Thanks, Jaime Torres Amate

Review Request 128627: avoid crash starting kate with QT_FATAL_WARNINGS=1

2016-08-08 Thread Jaime Torres Amate
no connect from null) Thanks, Jaime Torres Amate

Re: Review Request 128627: avoid crash starting kate with QT_FATAL_WARNINGS=1

2016-08-08 Thread Jaime Torres Amate
27/#review98199 --- On Aug. 8, 2016, 7:38 a.m., Jaime Torres Amate wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128627/ > ---

D5799: Rebase Less syntax highlighting on SCSS one

2017-08-14 Thread Jaime Torres Amate
jtamate requested changes to this revision. jtamate added a comment. This revision now requires changes to proceed. Hello, To be able to compile with the current frameworks, I have had to remove the leading/trailing spaces:

D9004: Input validation of SubJobs

2017-11-27 Thread Jaime Torres Amate
jtamate updated this revision to Diff 23049. jtamate added a comment. - Input validation of SubJobs and disconnect signals I can't reproduce the bug. Probably the job already deleted (the crash in the bug) and the signals not disconnected where the problem. It doesn't crash for me

D9004: Input validation of SubJobs

2017-11-28 Thread Jaime Torres Amate
jtamate updated this revision to Diff 23097. jtamate added a comment. - Input validation of SubJobs and disconnect signals REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9004?vs=23049=23097 BRANCH master REVISION DETAIL

D9004: Input validation of SubJobs

2017-11-26 Thread Jaime Torres Amate
jtamate updated this revision to Diff 22948. jtamate added a comment. - Improved input validation for SubJobs - Added the changes suggested by anthony - I can't reproduce now bug 364039 even without a patched kio REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D9005: fix crash during file copy after message box warning

2017-11-26 Thread Jaime Torres Amate
jtamate edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9005 To: jtamate, #frameworks, dfaure Cc: elvisangelaccio

D9001: Better handle of subjobs

2017-11-26 Thread Jaime Torres Amate
jtamate abandoned this revision. jtamate added a comment. Creating two review requests. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9001 To: jtamate, #frameworks, dfaure Cc: ngraham, anthonyfieroni, ltoscano

D9004: Input validation of SubJobs

2017-11-26 Thread Jaime Torres Amate
jtamate created this revision. jtamate added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. REVISION SUMMARY Don't remove a SubJob pointer if it is not in the list of SubJobs. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL

D9004: Input validation of SubJobs

2017-11-26 Thread Jaime Torres Amate
jtamate marked 4 inline comments as done. jtamate added a comment. I've missed to do: git add -u git commit before doing the last arc diff If I do arc land (when the ship it! comes), will it do the right thing? REPOSITORY R244 KCoreAddons REVISION DETAIL

D9005: fix crash during file copy after message box warning

2017-11-26 Thread Jaime Torres Amate
jtamate created this revision. jtamate added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. REVISION SUMMARY As a temporary workaround for the problems with nested eventloops and warning messages in the move/copy operation when it can't change the

D9004: Input validation of SubJobs

2017-11-26 Thread Jaime Torres Amate
jtamate updated this revision to Diff 22947. jtamate added a comment. - Improved input validation for SubJobs by dfaure REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9004?vs=22943=22947 BRANCH master REVISION DETAIL

D9005: fix crash during file copy after message box warning

2017-11-26 Thread Jaime Torres Amate
jtamate added a comment. The backtrace without this patch: Thread 1 (Thread 0x7f0a25cc5dc0 (LWP 18492)): [KCrash Handler] #6 0x7f0a1fe9b156 in KJob::isAutoDelete() const (this=0x1ae3410) at /g/5kde/frameworks/kcoreaddons/src/lib/jobs/kjob.cpp:333 #7 0x7f0a1fe9a826 in

D9001: Possible solution to bug 364039

2017-11-25 Thread Jaime Torres Amate
jtamate created this revision. jtamate added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. REVISION SUMMARY This is my first phabricator revision, I hope I'm doing it right. First part of the patch in kcoreaddons. Don't remove a child if it is not in

D9001: Don't remove a subjob if is not in the list of subjobs and dnoe emitResult if the job still has subjobs..

2017-11-25 Thread Jaime Torres Amate
jtamate retitled this revision from "Possible solution to bug 364039" to "Don't remove a subjob if is not in the list of subjobs and dnoe emitResult if the job still has subjobs..". jtamate edited the summary of this revision. jtamate edited the test plan for this revision. REPOSITORY R241

D9001: Better handle of subjobs

2017-11-25 Thread Jaime Torres Amate
jtamate retitled this revision from "Don't remove a subjob if is not in the list of subjobs and dnoe emitResult if the job still has subjobs.." to "Better handle of subjobs". jtamate edited the summary of this revision. jtamate edited the test plan for this revision. REPOSITORY R241 KIO

D9005: fix crash during file copy after message box warning

2017-11-30 Thread Jaime Torres Amate
jtamate abandoned this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9005 To: jtamate, #frameworks, dfaure Cc: anthonyfieroni, elvisangelaccio

D9004: Input validation of SubJobs

2017-11-30 Thread Jaime Torres Amate
This revision was automatically updated to reflect the committed changes. Closed by commit R244:5da7248517bc: Input validation of SubJobs (authored by jtamate). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9004?vs=23097=23183 REVISION DETAIL

D9004: Input validation of SubJobs

2017-11-27 Thread Jaime Torres Amate
jtamate updated this revision to Diff 23046. jtamate added a comment. - Addressed comments by dfaure and anthonyfieroni REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9004?vs=22948=23046 BRANCH master REVISION DETAIL

D9156: Fix a memory leak in KuitStaticData

2017-12-03 Thread Jaime Torres Amate
jtamate created this revision. jtamate added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY domainSetups QHash was populated in Kuit::setupForDomain, but the values of the QHash where not deleted in the default destructor. All the credit goes to

D9120: Fix a memory leak

2017-12-03 Thread Jaime Torres Amate
jtamate abandoned this revision. jtamate added a comment. The new revision is https://phabricator.kde.org/D9156 REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D9120 To: jtamate, #frameworks Cc: mpyne, anthonyfieroni, aacid, apol

D9156: Fix a memory leak in KuitStaticData

2017-12-04 Thread Jaime Torres Amate
This revision was automatically updated to reflect the committed changes. Closed by commit R249:170317278f6b: Fix a memory leak in KuitStaticData (authored by jtamate). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9156?vs=23400=23418 REVISION DETAIL

D9120: Fix a memory leak

2017-12-03 Thread Jaime Torres Amate
jtamate created this revision. jtamate added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY setup was created but never released, now changed to a member pointer to be deleted in the destructor. According to valgrind, the leak is gone. TEST

D9120: Fix a memory leak

2017-12-03 Thread Jaime Torres Amate
jtamate added a comment. As I understand the problem, the reference was created (as a pointer) in setupForDomain, but was stored in a local reference in format (line 1221). As I'm not sure about the lifetime of the reference, I just delete it in the destructor. REPOSITORY R249 KI18n

D12511: optimization of KTextEditor::DocumentPrivate::views()

2018-05-04 Thread Jaime Torres Amate
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R39:90157a222b5e: optimization of KTextEditor::DocumentPrivate::views() (authored by jtamate). REPOSITORY R39

D12511: optimization of KTextEditor::DocumentPrivate::views()

2018-05-04 Thread Jaime Torres Amate
jtamate added a comment. In D12511#258212 , @mwolff wrote: > https://phabricator.kde.org/file/data/w4qogv4brtxlc5p5bnwr/PHID-FILE-q62giymcptudpl5m6bt3/kwrite_perf_after_25_dwarf_caller.png shows ~1.5% in notifyAboutRangeChange (inclusively). Is

D12511: optimization of KTextEditor::DocumentPrivate::views()

2018-05-04 Thread Jaime Torres Amate
jtamate added a comment. In D12511#258193 , @mwolff wrote: > Actually, no. Ignore what I said. The pictures you are showing are pretty meaningless. Did you run perf with `--call-graph dwarf`? Better look at the flamegraph and search for the

D12659: two new UDS structures

2018-05-04 Thread Jaime Torres Amate
jtamate updated this revision to Diff 33607. jtamate added a comment. Removed some methods that are not used in the benchmarks. Added the asserts to check the type of the data at the beginning of every insert and replaceOrInsert. FYI: Checking the new implementation in live, so far

D12659: two new UDS structures

2018-05-04 Thread Jaime Torres Amate
This revision was automatically updated to reflect the committed changes. Closed by commit R241:01b2e536aeb3: two new UDS structures (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12659?vs=33607=33608 REVISION DETAIL

D12016: [ktexteditor] much faster positionFromCursor

2018-05-04 Thread Jaime Torres Amate
jtamate added a comment. In D12016#257862 , @cullmann wrote: > Actually, given the functionality is only used there, if that code is in the view or in that helper class makes no real difference, or? I've tried to extend KateViewInternal

D12696: Use the new uds implementation

2018-05-07 Thread Jaime Torres Amate
jtamate updated this revision to Diff 33758. jtamate marked 9 inline comments as done. jtamate edited the summary of this revision. jtamate added a comment. Hopefully, all the issues fixed. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12696?vs=33622=33758

D12865: transferjob new connect syntax

2018-05-14 Thread Jaime Torres Amate
jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Use the new connect syntax. A new

D12776: 4 more cases of empty protocol

2018-05-09 Thread Jaime Torres Amate
jtamate created this revision. jtamate added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY After browsing a compressed .xz file in dolphin,

D12371: fix always reproducible crash

2018-05-09 Thread Jaime Torres Amate
jtamate updated this revision to Diff 33872. jtamate marked an inline comment as done. jtamate edited the summary of this revision. jtamate added a comment. Restricted Application added a subscriber: kde-frameworks-devel. The crash after the redirection in fish://127.0.0.1 was due to a

D12696: Use the new uds implementation

2018-05-08 Thread Jaime Torres Amate
jtamate updated this revision to Diff 33809. jtamate added a comment. Don't use java style. As UDSEntryPrivate is private, declare public methods save, load and debugUDSEntry, otherwise I couldn't access the private d pointer from the << and >> operators. REPOSITORY R241 KIO CHANGES

D12696: Use the new uds implementation

2018-05-09 Thread Jaime Torres Amate
jtamate updated this revision to Diff 33889. jtamate edited the summary of this revision. jtamate added a comment. Restricted Application added a subscriber: kde-frameworks-devel. Direct friendship with the operators. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D12371: fix always reproducible crash

2018-04-27 Thread Jaime Torres Amate
jtamate updated this revision to Diff 33211. jtamate edited the summary of this revision. jtamate edited the test plan for this revision. jtamate added a comment. The responsible for changing smb:// into smb:/// was: void KFileWidgetPrivate::_k_enterUrl(const QUrl ) With this patch, the

D12371: fix always reproducible crash

2018-04-28 Thread Jaime Torres Amate
jtamate updated this revision to Diff 33242. jtamate edited the summary of this revision. jtamate added a comment. If I use if (!u.path().isEmpty()) or if (!u.path().isEmpty() && !u.path().endsWith('/')), as soon as I enter the url fish://127.0.0.1 (without trailing /), I'm redirected to

D12696: Use the new uds implementation

2018-05-10 Thread Jaime Torres Amate
jtamate updated this revision to Diff 33929. jtamate marked 8 inline comments as done and 3 inline comments as done. jtamate edited the summary of this revision. jtamate added a comment. Added the documentation for insert. Removed the () from the QDataStream& operators, but must be kept for

D12371: Don't redirect smb:/ to smb:// and then to smb:///

2018-05-10 Thread Jaime Torres Amate
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:2a57054a718a: Dont redirect smb:/ to smb:// and then to smb:/// (authored by jtamate). CHANGED PRIOR TO COMMIT

D12371: Don't redirect smb:/ to smb:// and then to smb:///

2018-05-10 Thread Jaime Torres Amate
jtamate retitled this revision from "fix always reproducible crash" to "Don't redirect smb:/ to smb:// and then to smb:///". jtamate edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12371 To: jtamate, dfaure, #frameworks, apol Cc:

D12696: Use the new uds implementation

2018-05-10 Thread Jaime Torres Amate
This revision was automatically updated to reflect the committed changes. Closed by commit R241:e80c31163170: Use the new uds implementation (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12696?vs=33929=33957 REVISION DETAIL

D12696: Use the new uds implementation

2018-05-08 Thread Jaime Torres Amate
jtamate updated this revision to Diff 33815. jtamate added a comment. Make some friends functions. A bad type in copy didn't allowed me the use of the module functions save/load/debugUDSEntry, REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D12696: Use the new uds implementation

2018-05-08 Thread Jaime Torres Amate
jtamate added inline comments. INLINE COMMENTS > dfaure wrote in udsentry.cpp:454 > Hmm why can't this be the friend function directly? > > I don't like the added global functions in the public header... > Hmm why can't this be the friend function directly? Because the compiler (clang++ in

D12511: optimization of KTextEditor::DocumentPrivate::views()

2018-05-04 Thread Jaime Torres Amate
jtamate updated this revision to Diff 33613. jtamate edited the test plan for this revision. jtamate added a comment. Add and remove from the list. About the tools I use to profile: - I'm used to use slow machines, I have no problems running under valgrind. - When I can run a

D12016: [ktexteditor] much faster positionFromCursor

2018-05-04 Thread Jaime Torres Amate
This revision was automatically updated to reflect the committed changes. Closed by commit R39:81996f55b1ab: [ktexteditor] much faster positionFromCursor (authored by jtamate). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D12016?vs=31853=33615#toc REPOSITORY R39 KTextEditor CHANGES

D12696: Use the new uds implementation

2018-05-04 Thread Jaime Torres Amate
jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. jtamate requested review of this revision. REVISION SUMMARY This new implementation is the fastest in the autotests. The replaceOrInsert in KFileItem::setName is due

D11604: kdirlistertest doesn't fail at random

2018-05-04 Thread Jaime Torres Amate
jtamate updated this revision to Diff 33623. jtamate edited the summary of this revision. jtamate added a comment. Add the new tests instead of replace. Use QTRY_COMPARE instead of custom loops. Reduce the number of files to 100. In my machine, the mime type of file.html is

D12945: kcoredirlister lstItems benchmark

2018-05-17 Thread Jaime Torres Amate
jtamate added a dependent revision: D11282: less expensive findByUrl in KCoreDirListerCache. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12945 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D11282: less expensive findByUrl in KCoreDirListerCache

2018-05-17 Thread Jaime Torres Amate
jtamate added a dependency: D12945: kcoredirlister lstItems benchmark. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11282 To: jtamate, #frameworks, dfaure Cc: mwolff, michaelh, ngraham, bruns

D12945: kcoredirlister lstItems benchmark

2018-05-17 Thread Jaime Torres Amate
jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Decide which data structure is best for

D12897: Reserve space for the cachedLineForRanges Qhash (optimization)

2018-05-15 Thread Jaime Torres Amate
jtamate created this revision. jtamate added reviewers: Kate, Frameworks. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. jtamate requested review of this revision. REVISION SUMMARY Most of the time was spent

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

2018-05-23 Thread Jaime Torres Amate
jtamate updated this revision to Diff 34708. jtamate edited the summary of this revision. jtamate edited the test plan for this revision. jtamate added a comment. Restricted Application added a subscriber: kde-frameworks-devel. Based on the tests done in D12945

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

2018-05-24 Thread Jaime Torres Amate
jtamate updated this revision to Diff 34775. jtamate marked 5 inline comments as done. jtamate edited the summary of this revision. jtamate added a comment. Removed m_hash, after implementing the right checks it was slower than comparing QUrls. REPOSITORY R241 KIO CHANGES SINCE LAST

D11282: less expensive findByUrl in KCoreDirListerCache

2018-05-24 Thread Jaime Torres Amate
jtamate added a comment. About the KCoreDirLister::Private::addNewItems method, benchmarking the current and sorted list implementation with 5000 fileItems: It only takes 1.5 msecs per iteration without filters and 1.9 msecs with a nameFilter and a mimeFilter. For reference, doing a

D12897: Reserve space for the cachedLineForRanges Qhash (optimization)

2018-06-10 Thread Jaime Torres Amate
jtamate added a comment. In D12897#276182 , @dhaumann wrote: > @mwolff To me this looks ok - do you see an issue with this? E.g. that KTextEditor will require much more memory for almost no gain? If there is a more constrained limit,

D12897: Reserve space for the cachedLineForRanges Qhash (optimization)

2018-06-12 Thread Jaime Torres Amate
jtamate abandoned this revision. jtamate added a comment. More numbers: The patch reserves 67 buckets in the QHash table vs. 37 by default. In my test, pasing the content of https://www.boe.es/legislacion/documentos/ConstitucionCASTELLANO.pdf from Okular, the number of items in the

D13211: Enable comparing KFileItems by url

2018-06-12 Thread Jaime Torres Amate
jtamate updated this revision to Diff 36037. jtamate marked an inline comment as done. jtamate edited the summary of this revision. jtamate added a comment. Change @since to 5.48 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13211?vs=35303=36037 REVISION

D13590: Use QUrl < instead of QString.compare

2018-06-18 Thread Jaime Torres Amate
jtamate updated this revision to Diff 36283. jtamate edited the summary of this revision. jtamate added a comment. You're right :-) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13590?vs=36279=36283 REVISION DETAIL https://phabricator.kde.org/D13590

D13590: Use QUrl < instead of QString.compare

2018-06-18 Thread Jaime Torres Amate
jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Use the available Qurl < operator (since

D13211: Enable comparing KFileItems by url

2018-06-13 Thread Jaime Torres Amate
This revision was automatically updated to reflect the committed changes. Closed by commit R241:fb3c94ed96c3: Enable comparing KFileItems by url (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13211?vs=36037=36112 REVISION DETAIL

D12696: Use the new uds implementation

2018-06-11 Thread Jaime Torres Amate
jtamate added a comment. I'm sorry, I was missing a -dev package and therefore I was not compiling kio sftp. A fix for this problem is in D13475 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12696 To: jtamate, dfaure,

D13211: Enable comparing KFileItems by url

2018-05-30 Thread Jaime Torres Amate
jtamate updated this revision to Diff 35190. jtamate marked 4 inline comments as done. jtamate added a comment. Invalid items are not less than invalid items or invalid urls, they are not like -infinite. Added the tests comparing items with urls. Changed the descriptions. REPOSITORY

D13189: [kcoredirlister] Remove as many url.toString() as possible

2018-05-30 Thread Jaime Torres Amate
This revision was automatically updated to reflect the committed changes. Closed by commit R241:ae08cc2c983c: [kcoredirlister] Remove as many url.toString() as possible (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13189?vs=35114=35201

D13211: Enable comparing KFileItems by url

2018-05-30 Thread Jaime Torres Amate
jtamate updated this revision to Diff 35192. jtamate added a comment. Taken into account invalid Items created from invalid QUrls. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13211?vs=35190=35192 REVISION DETAIL https://phabricator.kde.org/D13211

D13189: [kcoredirlister] Remove as many url.toString() as possible

2018-05-29 Thread Jaime Torres Amate
jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Change itemsInUse, itemsCached and

D13189: [kcoredirlister] Remove as many url.toString() as possible

2018-05-29 Thread Jaime Torres Amate
jtamate updated this revision to Diff 35114. jtamate marked an inline comment as done. jtamate added a comment. const added. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13189?vs=35085=35114 REVISION DETAIL https://phabricator.kde.org/D13189 AFFECTED

D13211: Enable comparing KFileItems by url

2018-05-30 Thread Jaime Torres Amate
jtamate created this revision. jtamate added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Based on QUrl comparisons (available since Qt 5.4).

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

2018-05-30 Thread Jaime Torres Amate
jtamate added a dependency: D13211: Enable comparing KFileItems by url. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10742 To: jtamate, #frameworks, dfaure Cc: bruns, kde-frameworks-devel, mwolff, markg, michaelh, ngraham

D12945: kcoredirlister lstItems benchmark

2018-05-30 Thread Jaime Torres Amate
jtamate added a dependency: D13211: Enable comparing KFileItems by url. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12945 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13211: Enable comparing KFileItems by url

2018-05-30 Thread Jaime Torres Amate
jtamate added dependent revisions: D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache, D12945: kcoredirlister lstItems benchmark. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13211 To: jtamate, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

2018-06-01 Thread Jaime Torres Amate
jtamate updated this revision to Diff 35305. jtamate marked 4 inline comments as done. jtamate edited the summary of this revision. jtamate edited the test plan for this revision. jtamate added a comment. The change in kdirmodel is not needed anymore. The methods that were const are const

D13211: Enable comparing KFileItems by url

2018-06-01 Thread Jaime Torres Amate
jtamate updated this revision to Diff 35303. jtamate added a comment. Now passes the tests and its performance for non invalid items is not degraded too much (same +3ms inserting). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13211?vs=35192=35303 REVISION

D12945: kcoredirlister lstItems benchmark

2018-06-05 Thread Jaime Torres Amate
jtamate updated this revision to Diff 35585. jtamate edited the summary of this revision. jtamate added a comment. Changed the structure QListBinaryHash to QMap Changed from KFileItems pointers to Values (it caused memory problems). Imported the parts that handle the filters to do the

D12696: Use the new uds implementation

2018-06-07 Thread Jaime Torres Amate
jtamate added a comment. In D12696#275105 , @martinkostolny wrote: > Hi! Probably after this commit sftp slave crashes when showing a directory with links. Please see my code comment. Can you also reproduce or is it on my side only?

D13211: Enable comparing KFileItems by url

2018-05-30 Thread Jaime Torres Amate
jtamate updated this revision to Diff 35188. jtamate marked 3 inline comments as done. jtamate edited the test plan for this revision. jtamate added a comment. A KFileItem without url will be the lowest, even lower than itself. Created a new test. The comparison with the QUrl is for

D13813: make this test work again with new uds implementation

2018-06-30 Thread Jaime Torres Amate
jtamate updated this revision to Diff 36975. jtamate added a comment. Updated the patch with context. It will not work with kio previous to 5.47, unless there is a way to check the kio version at compile time or runtime. REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE

D13813: make this test work again with new uds implementation

2018-06-30 Thread Jaime Torres Amate
jtamate updated this revision to Diff 36976. jtamate edited the summary of this revision. jtamate added a comment. Use 3 entries instead of replace(). Now it will work with any kio version. REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE

D13814: Speedup sort

2018-07-02 Thread Jaime Torres Amate
jtamate updated this revision to Diff 37053. jtamate marked an inline comment as done. jtamate added a comment. > In other words, the fix for that can probably be removed now. I prefer not to do it (even I've tried without any crash), because QVariant is not even reentrant. Changed

D13814: Speedup sort

2018-07-02 Thread Jaime Torres Amate
jtamate updated this revision to Diff 37056. jtamate added a comment. Undo the right number of steps from a quick experiment. :-) REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13814?vs=37053=37056 REVISION DETAIL https://phabricator.kde.org/D13814

D13674: Make it possible to go up to root again

2018-06-22 Thread Jaime Torres Amate
jtamate updated this revision to Diff 36533. jtamate marked an inline comment as done. jtamate added a comment. Removed comment and added autotest. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13674?vs=36504=36533 REVISION DETAIL

D13674: Make it possible to go up to root again

2018-06-22 Thread Jaime Torres Amate
jtamate updated this revision to Diff 36534. jtamate added a comment. Moved the comment. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13674?vs=36533=36534 REVISION DETAIL https://phabricator.kde.org/D13674 AFFECTED FILES autotests/kfilewidgettest.cpp

D13674: Make it possible to go up to root again

2018-06-24 Thread Jaime Torres Amate
This revision was automatically updated to reflect the committed changes. Closed by commit R241:1cea9463f471: Make it possible to go up to root again (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13674?vs=36534=36611 REVISION DETAIL

D13590: Use QUrl < instead of QString.compare

2018-06-19 Thread Jaime Torres Amate
This revision was automatically updated to reflect the committed changes. Closed by commit R241:bba871deced2: Use QUrl instead of QString.compare (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13590?vs=36283=36343 REVISION DETAIL

D13813: make this test work again with new uds implementation

2018-07-03 Thread Jaime Torres Amate
jtamate added a comment. In D13813#286313 , @aacid wrote: > Did we break how KIO works and we're now going after the users of KIO and fixing them or was this a "bad usage" from starters that worked by chance? We break how KIO works and

D13813: make this test work again with new uds implementation

2018-06-30 Thread Jaime Torres Amate
jtamate created this revision. jtamate added reviewers: Dolphin, Frameworks. Restricted Application added a project: Dolphin. Restricted Application added a subscriber: kfm-devel. jtamate requested review of this revision. REVISION SUMMARY With the new uds implementation, when some data is

D13814: Speedup sort

2018-06-30 Thread Jaime Torres Amate
jtamate created this revision. jtamate added reviewers: Dolphin, Frameworks. Restricted Application added a project: Dolphin. Restricted Application added a subscriber: kfm-devel. jtamate requested review of this revision. REVISION SUMMARY Use a lambda function instead of a class. This way

D13814: Speedup sort

2018-06-30 Thread Jaime Torres Amate
jtamate added a dependency: D13813: make this test work again with new uds implementation. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D13814 To: jtamate, #dolphin, #frameworks Cc: kfm-devel, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp

D13813: make this test work again with new uds implementation

2018-06-30 Thread Jaime Torres Amate
jtamate added a dependent revision: D13814: Speedup sort. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D13813 To: jtamate, #dolphin, #frameworks Cc: kfm-devel, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp

D13814: Speedup sort

2018-07-01 Thread Jaime Torres Amate
jtamate added a comment. In D13814#285686 , @bruns wrote: > In D13814#285660 , @markg wrote: > > > > I don't know if that's still an issue or if your patch re-introduces whatever the problem was

D13814: Speedup sort

2018-07-01 Thread Jaime Torres Amate
jtamate updated this revision to Diff 37010. jtamate added a comment. Remove the _ prefix. REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13814?vs=36953=37010 REVISION DETAIL https://phabricator.kde.org/D13814 AFFECTED FILES

D13814: Speedup sort

2018-07-01 Thread Jaime Torres Amate
jtamate added a comment. In D13814#285691 , @bruns wrote: > I assume you are sorting by name with "natural sorting". There may be another possibility for speedup here: > `QCollator::sortkey()`, http://doc.qt.io/qt-5/qcollator.html#sortKey

D13814: Speedup sort

2018-07-01 Thread Jaime Torres Amate
jtamate updated this revision to Diff 37019. jtamate added a comment. Can not use the name lessThan because of: error: use of ‘lessThan’ before deduction of ‘auto’ REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13814?vs=37010=37019 REVISION DETAIL

D12659: two new UDS structures

2018-05-02 Thread Jaime Torres Amate
jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. jtamate requested review of this revision. REVISION SUMMARY The two new UDS structures are similar to Frank's, but instead of using two vectors, use only one, with

D12659: two new UDS structures

2018-05-02 Thread Jaime Torres Amate
jtamate marked 9 inline comments as done. jtamate added a comment. > If anyone attempts this, please name the struct and its members, don't use QPair ;-) > But no, that cannot possibly be faster. QVariant has lots of overhead itself. I've tried, just before reading your comment :-)

D12016: [ktexteditor] much faster positionFromCursor

2018-05-02 Thread Jaime Torres Amate
jtamate added a comment. In D12016#257324 , @anthonyfieroni wrote: > Maybe i miss something, but i think if something should be extended it's view not accessible. Do you mean to extend KateViewInternal in such a way that

  1   2   3   4   5   >