Review Request 126742: Add removeAllActions() to remove every applet interface action.

/appletinterface.cpp 8e4979ae9ec89da02f68e6438b5b0ab40a2495d0 Diff: https://git.reviewboard.kde.org/r/126742/diff/ Testing --- Compile, runtime. Thanks, James Smith ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 126742: Add clearActions() to remove every applet interface action.

, James Smith ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126742: Add clearActions() to remove every applet interface action.

ion. Is there an equivalent way to do this in the plasmoid? Diffs (updated) - src/scriptengines/qml/plasmoid/appletinterface.h ad68499 src/scriptengines/qml/plasmoid/appletinterface.cpp 8e4979a Diff: https://git.reviewboard.kde.org/r/126742/diff/ Testing --- Compile, runtime. Thanks, Ja

Re: Review Request 126742: Add clearActions() to remove every applet interface action.

view91122 --- On Jan. 15, 2016, 1:52 a.m., James Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

D8098: Strip down and re-write the tags KIO slave.

smithjd updated this revision to Diff 20362. smithjd added a comment. - Fix tag navigation display labels in Dolphin. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=20320=20362 BRANCH master-nestedTags (branched from master) REVISION DETAIL

D8098: Strip down and re-write the tags KIO slave.

smithjd updated this revision to Diff 20320. smithjd added a comment. - Fix generating previews copies the file to tmp. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=20222=20320 BRANCH master-nestedTags (branched from master) REVISION DETAIL

D8098: Strip down and re-write the tags KIO slave.

smithjd added a comment. Copying/cutting file tags works both from local files and also tagged files. Breaking tags works, e.g. nested tag foo in bar can be copied or cut to foobar/barfoo tag path. Cutting and pasting a file folder results in a new tag on the folder, copying applies the

D8098: Strip down and re-write the tags KIO slave.

smithjd created this revision. smithjd added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY Allow for more operations on tag trees (e.g. rename, copy, delete) and fix some existing issues. BUG: 314373 BUG: 340098 BUG: 376229 BUG: 332214

D8098: Strip down and re-write the tags KIO slave.

smithjd added a comment. Maybe update your local repo? It is against the most recent commit in master. It was diff'ed from a non-master branch... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D8098 To: smithjd, #frameworks Cc: ngraham

D8098: Strip down and re-write the baloo tags KIO slave

smithjd updated this revision to Diff 23101. smithjd added a comment. - Fix tagged directory listing. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=22940=23101 BRANCH master-nestedTags (branched from master) REVISION DETAIL

D8098: Strip down and re-write the baloo tags KIO slave

smithjd updated this revision to Diff 22940. smithjd added a comment. - Fix for slash-less tag urls. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=22938=22940 BRANCH master-nestedTags (branched from master) REVISION DETAIL

D8098: Strip down and re-write the baloo tags KIO slave

smithjd updated this revision to Diff 22938. smithjd added a comment. - Fix valid tag calculation. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=22857=22938 BRANCH master-nestedTags (branched from master) REVISION DETAIL

D8098: Strip down and re-write the baloo tags KIO slave

smithjd added a comment. Currently known issues: Entering a tagged folder works, listing it from within the tags: protocol in the slave results in a folder cannot be entered error. Attempting to copy a tag tree with such a populated folder results in a file not found error for each

D8098: Strip down and re-write the baloo tags KIO slave

smithjd updated this revision to Diff 22792. smithjd marked 6 inline comments as done. smithjd added a comment. - Review changes. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=22712=22792 BRANCH master-nestedTags (branched from master) REVISION

D8098: Strip down and re-write the baloo tags KIO slave

smithjd added inline comments. INLINE COMMENTS > dfaure wrote in kio_tags.cpp:119 > I see an added check for "already exists" and an early return (good), but no > support for KIO::Overwrite. If the user uses dolphin to copy a tag they might > click on "overwrite" and it won't work, if copy()

D8098: Strip down and re-write the baloo tags KIO slave

smithjd updated this revision to Diff 23146. smithjd added a comment. - Fix generating previews copies the file to tmp. - Fix tag navigation display labels in Dolphin. - Stricter url validation. - Create a full url instead of only a path. - Check if the destination file already has the

D8098: Strip down and re-write the baloo tags KIO slave

This revision was automatically updated to reflect the committed changes. Closed by commit R293:16664fccb7b7: Strip down and re-write the baloo tags KIO slave (authored by smithjd). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8098?vs=23146=23147#toc REPOSITORY R293 Baloo CHANGES

D8098: Strip down and re-write the baloo tags KIO slave

smithjd added a comment. In https://phabricator.kde.org/D8098#173418, @ngraham wrote: > Excellent! @smithjd, is this ready to go in now, or are you still making more changes? There are still known problems with tagged directory copies. Overall however it's in a pretty good state

D8098: Strip down and re-write the baloo tags KIO slave

smithjd added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kio_tags.h:101 > metaData(QString{}) Doesn't work. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D8098 To: smithjd, #frameworks, vhanda, #dolphin, ngraham, dfaure Cc: anthonyfieroni, dfaure,

D8098: Strip down and re-write the baloo tags KIO slave

smithjd updated this revision to Diff 22857. smithjd marked 3 inline comments as done. smithjd added a comment. - Review suggestions. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=22792=22857 BRANCH master-nestedTags (branched from master)

D8098: Strip down and re-write the baloo tags KIO slave

smithjd retitled this revision from "Strip down and re-write the tags KIO slave." to "Strip down and re-write the baloo tags KIO slave". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D8098 To: smithjd, #frameworks, vhanda, #dolphin, ngraham, dfaure Cc: dfaure,

D8098: Strip down and re-write the baloo tags KIO slave

smithjd updated this revision to Diff 22712. smithjd added a comment. Make work with kioclient. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=22107=22712 BRANCH master-nestedTags (branched from master) REVISION DETAIL

D8098: Strip down and re-write the baloo tags KIO slave

smithjd marked 2 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D8098 To: smithjd, #frameworks, vhanda, #dolphin, ngraham, dfaure Cc: dfaure, nicolasfella, ngraham

D8098: Strip down and re-write the tags KIO slave.

smithjd updated this revision to Diff 22107. smithjd added a comment. - Merge local and tag file handling. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=21851=22107 BRANCH master-nestedTags (branched from master) REVISION DETAIL

D8098: Strip down and re-write the tags KIO slave.

smithjd marked 14 inline comments as done. smithjd added inline comments. INLINE COMMENTS > dfaure wrote in kio_tags.cpp:64 > - merge with previous line > > - can path() really contain '?' ? I thought that wasn't possible (? delimits > the query). Yes, the url is non-hierarchical scheme, so

D8098: Strip down and re-write the tags KIO slave.

smithjd updated this revision to Diff 21851. smithjd added a comment. - Fix generating previews copies the file to tmp. - Fix tag navigation display labels in Dolphin. - Stricter url validation. - Create a full url instead of only a path. - Check if the destination file already has the

D8098: Strip down and re-write the tags KIO slave.

smithjd updated this revision to Diff 21590. smithjd added a comment. - Fix generating previews copies the file to tmp. - Fix tag navigation display labels in Dolphin. - Stricter url validation. 1. Updating https://phabricator.kde.org/D8098: Strip down and re-write the tags KIO

D8098: Strip down and re-write the tags KIO slave.

smithjd updated this revision to Diff 21599. smithjd added a comment. - Create a full url instead of only a path. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8098?vs=21590=21599 BRANCH master-nestedTags (branched from master) REVISION DETAIL

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 34892. smithjd added a comment. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. - Uniformly use storageDevices. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D13216: Overhaul the file index scheduler.

smithjd added a comment. In D13216#275538 , @bruns wrote: > @smithjd You have probaly become another victim of phabricator/arc. Your commits have been squashed by arc ... > If you wan't your commits to stay separated, you have to do a `git

D13216: Overhaul the file index scheduler.

smithjd added a comment. According to the arc documentation, a --merge commit should land the commits separately. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D13216: Overhaul the file index scheduler.

smithjd added a comment. In D13216#275582 , @bruns wrote: > In D13216#275581 , @smithjd wrote: > > > According to the arc documentation, a --merge commit should land the commits separately. > >

D13216: Overhaul the file index scheduler.

smithjd edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns

D13424: On config change halt the file indexer and run a file changed check when the file watches are updated.

smithjd updated this revision to Diff 35812. smithjd added a comment. Separate out the content indexer halt on quit. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13424?vs=35811=35812 BRANCH master-scheduler-updateConfig (branched from master) REVISION

D13425: Quit the file indexer when closing.

smithjd created this revision. smithjd added reviewers: bruns, mgallien. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. smithjd requested review of this revision. REPOSITORY R293 Baloo BRANCH

D13425: Quit the file indexer when closing.

smithjd added a dependency: D13216: Overhaul the file index scheduler.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D13216: Overhaul the file index scheduler.

smithjd added a dependent revision: D13425: Quit the file indexer when closing.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns

D13216: Overhaul the file index scheduler.

smithjd updated this revision to Diff 35810. smithjd added a comment. - Re-write the the file index scheduler. - Update the balooctl tool with the changed suspend/resume behaviour. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13216?vs=35730=35810 BRANCH

D13424: On config change, halt the file indexer and run a file changed check when the file watches are updated.

smithjd added reviewers: mgallien, bruns. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd, mgallien, bruns Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D13425: Quit the file indexer when closing.

smithjd added a dependency: D13424: On config change halt the file indexer and run a file changed check when the file watches are updated.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien Cc: mgallien, kde-frameworks-devel, bruns,

D13424: On config change halt the file indexer and run a file changed check when the file watches are updated.

smithjd added a dependent revision: D13425: Quit the file indexer when closing.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd, mgallien, bruns Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D13424: On config change, halt the file indexer and run a file changed check when the file watches are updated.

smithjd created this revision. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. smithjd requested review of this revision. REPOSITORY R293 Baloo BRANCH mastger-scheduler-updateConfig (branched from master)

D13216: Overhaul the file index scheduler.

smithjd added a dependent revision: D13424: On config change, halt the file indexer and run a file changed check when the file watches are updated.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel,

D13424: On config change, halt the file indexer and run a file changed check when the file watches are updated.

smithjd added a dependency: D13216: Overhaul the file index scheduler.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D13216: Overhaul the file index scheduler.

smithjd edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns

D13424: On config change halt the file indexer and run a file changed check when the file watches are updated.

smithjd retitled this revision from "On config change, halt the file indexer and run a file changed check when the file watches are updated." to "On config change halt the file indexer and run a file changed check when the file watches are updated.". REPOSITORY R293 Baloo REVISION DETAIL

D12335: Avoid infinite loops when fetching the URL from DocumentUrlDB

smithjd added a comment. Restricted Application added a subscriber: kde-frameworks-devel. Is your report in bug https://bugs.kde.org/show_bug.cgi?id=364574 related to this diff? If so it could be marked as a duplicate. REPOSITORY R293 Baloo REVISION DETAIL

D13216: Overhaul the file index scheduler. Allow all operations except the content indexer to work when suspended. Allow manually resuming file content indexing while on battery. balooctl stop now sto

smithjd created this revision. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. smithjd requested review of this revision. REVISION SUMMARY BUG: 353559 BUG: 378597 REPOSITORY R293 Baloo BRANCH

D13216: Overhaul the file index scheduler.

smithjd updated this revision to Diff 35199. smithjd added a comment. - Minor simplification + fix: call checkUnindexedFiles when folder watches are installed instead of scheduleIndexing which can't check for changes in indexable files. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D13216: Overhaul the file index scheduler.

smithjd retitled this revision from "Overhaul the file index scheduler. Allow all operations except the content indexer to work when suspended. Allow manually resuming file content indexing while on battery. balooctl stop now stops file indexing." to "Overhaul the file index scheduler.".

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 35204. smithjd added a comment. - New DBus method updateIndex(). - Change for D13216 . REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11529?vs=34892=35204 BRANCH

D11529: Balooctl: Deindex unfound files with check command.

smithjd added a dependency: D13216: Overhaul the file index scheduler.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11529 To: smithjd, #baloo, vhanda, michaelh, broulik Cc: kde-frameworks-devel, mgallien, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns

D13216: Overhaul the file index scheduler.

smithjd added a dependent revision: D11529: Balooctl: Deindex unfound files with check command.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns

D13216: Overhaul the file index scheduler.

smithjd added a reviewer: bruns. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns

D13216: Overhaul the file index scheduler.

smithjd updated this revision to Diff 35730. smithjd added a comment. Split-up scheduler overhaul patchset. - The power state signal should only be emitted when the power state changes. - Re-write the the file index scheduler. - Update the balooctl tool with the changed suspend/resume

D13216: Overhaul the file index scheduler.

smithjd added a reviewer: mgallien. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns

D13425: file indexer closing inprovements.

smithjd updated this revision to Diff 36702. smithjd added a comment. Change git commit description. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13425?vs=36416=36702 BRANCH master-scheduler-haltonquit (branched from master) REVISION DETAIL

D13216: Overhaul the file index scheduler.

smithjd updated this revision to Diff 36701. smithjd added a comment. re-word commits. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13216?vs=36417=36701 BRANCH master-scheduler (branched from master) REVISION DETAIL https://phabricator.kde.org/D13216

D13424: Run a file changed check when the file watches are updated.

smithjd updated this revision to Diff 36703. smithjd added a comment. Change commit description. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13424?vs=36418=36703 BRANCH master-scheduler-watchesInstalled (branched from master) REVISION DETAIL

D13425: File indexer closing improvements.

smithjd retitled this revision from "file indexer closing inprovements." to "File indexer closing improvements.". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov,

D13424: Run a file changed check when the file watches are updated.

smithjd retitled this revision from "On config change halt the file indexer and run a file changed check when the file watches are updated." to "Run a file changed check when the file watches are updated.". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To:

D13424: On config change halt the file indexer and run a file changed check when the file watches are updated.

smithjd updated this revision to Diff 36415. smithjd added a comment. Run a full check for unindexed files when the watches are installed. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13424?vs=35812=36415 BRANCH master-scheduler-watchesInstalled

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 36419. smithjd added a comment. Rebase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11529?vs=35204=36419 BRANCH master-filedeindexer (branched from master) REVISION DETAIL https://phabricator.kde.org/D11529

D13216: Overhaul the file index scheduler.

smithjd removed a dependent revision: D11529: Balooctl: Deindex unfound files with check command.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D11529: Balooctl: Deindex unfound files with check command.

smithjd edited dependencies, added: D13424: Run a file changed check when the file watches are updated.; removed: D13216: Overhaul the file index scheduler.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11529 To: smithjd, #baloo, vhanda, michaelh, broulik Cc:

D13424: Run a file changed check when the file watches are updated.

smithjd added a dependent revision: D11529: Balooctl: Deindex unfound files with check command.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd, mgallien, bruns Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich,

D13216: Overhaul the file index scheduler.

smithjd updated this revision to Diff 36417. smithjd added a comment. - Re-write the the file index scheduler. - Update the balooctl tool with the changed suspend/resume behaviour. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13216?vs=35810=36417 BRANCH

D13424: Run a file changed check when the file watches are updated.

smithjd removed a dependent revision: D13425: file indexer closing inprovements.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd, mgallien, bruns Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D13425: file indexer closing inprovements.

smithjd updated this revision to Diff 36416. smithjd added a comment. Consolidate file indexer close changes into a single review. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13425?vs=35813=36416 BRANCH master-scheduler-haltonquit (branched from

D13425: file indexer closing inprovements.

smithjd retitled this revision from "Quit the file indexer when closing." to "file indexer closing inprovements.". smithjd edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien Cc: mgallien,

D13424: Run a file changed check when the file watches are updated.

smithjd updated this revision to Diff 36418. smithjd added a comment. - Remove a fixme. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13424?vs=36415=36418 BRANCH master-scheduler-watchesInstalled (branched from master) REVISION DETAIL

D13425: file indexer closing inprovements.

smithjd removed a dependency: D13424: Run a file changed check when the file watches are updated.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich,

D13216: Overhaul the file index scheduler.

smithjd removed a dependent revision: D13424: Run a file changed check when the file watches are updated.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,

D13424: Run a file changed check when the file watches are updated.

smithjd edited dependencies, added: D13425: file indexer closing inprovements.; removed: D13216: Overhaul the file index scheduler.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd, mgallien, bruns Cc: mgallien, kde-frameworks-devel, bruns, #baloo,

D13425: file indexer closing inprovements.

smithjd added a dependent revision: D13424: Run a file changed check when the file watches are updated.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13425 To: smithjd, bruns, mgallien Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh,

D8098: Strip down and re-write the tags KIO slave.

smithjd added a comment. Deep tag copies (to the filesystem and also in the slave) are known to be broken (1 or more folder deep) because of the preview fix in the first revision. REPOSITORY R293 Baloo BRANCH master-nestedTags (branched from master) REVISION DETAIL

D10106: Relocate the Baloo database to the XDG cache location.

smithjd created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. smithjd requested review of this revision. REVISION SUMMARY If the database exists in the old XDG Data location, migrate it to the XDG cache location.

D15047: Export the StorageDevices object.

smithjd created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. smithjd requested review of this revision. REPOSITORY R293 Baloo BRANCH master-storageDevicesExport (branched from master) REVISION DETAIL

D15047: Export the StorageDevices object.

smithjd added a dependent revision: D11529: Balooctl: Deindex unfound files with check command.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15047 To: smithjd, broulik Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns,

D11529: Balooctl: Deindex unfound files with check command.

smithjd edited dependencies, added: D15047: Export the StorageDevices object., D13216: Overhaul the file index scheduler.; removed: D13424: Run a file changed check when the file watches are updated.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11529 To: smithjd,

D15048: Re-write the file index scheduler. Combine content indexer suspend logic.

smithjd abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15048 To: smithjd Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D13425: File indexer closing improvements.

smithjd updated this revision to Diff 40344. smithjd added a comment. Rebase. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13425?vs=36702=40344 BRANCH master-scheduler-haltonquit (branched from master) REVISION DETAIL

D13424: Run a file changed check when the file watches are updated.

smithjd updated this revision to Diff 40345. smithjd added a comment. Rebase. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13424?vs=36703=40345 BRANCH master-scheduler-watchesInstalled (branched from master) REVISION DETAIL

D13216: Overhaul the file index scheduler.

smithjd updated this revision to Diff 40343. smithjd added a comment. - Re-write the file index scheduler. Combine content indexer suspend logic. - Update the balooctl tool with the changed suspend/resume behaviour. - Re-order and use IndexerState to prioritize the indexer thread pool. -

D15047: Export the StorageDevices object.

smithjd added a reviewer: broulik. smithjd added a comment. This was included in https://phabricator.kde.org/D11529 and is now broken out. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15047 To: smithjd, broulik Cc: kde-frameworks-devel, #baloo, ashaposhnikov,

D13216: Overhaul the file index scheduler.

smithjd added a dependent revision: D11529: Balooctl: Deindex unfound files with check command.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun,

D13424: Run a file changed check when the file watches are updated.

smithjd removed a dependent revision: D11529: Balooctl: Deindex unfound files with check command.. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13424 To: smithjd, mgallien, bruns Cc: mgallien, kde-frameworks-devel, bruns, #baloo, ashaposhnikov, michaelh, astippich,

D15047: Export the StorageDevices object.

smithjd marked an inline comment as done. smithjd added a comment. In D15047#314477 , @bruns wrote: > There is no need for this, just create a new StorageDevices where you need it. > Creating a second StorageDevices instance in a process is

D15048: Re-write the file index scheduler. Combine content indexer suspend logic.

smithjd created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. smithjd requested review of this revision. REVISION SUMMARY Update the balooctl tool with the changed suspend/resume behaviour. Re-order and use IndexerState to

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 40346. smithjd added a comment. - New DBus method updateIndex(). - Document indexing options. - Prevent a scheduler race condition. - Run de-indexing file check in parallel. - Rebase for separate statechanged functors. REPOSITORY R293 Baloo

D13216: Overhaul the file index scheduler.

smithjd edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D13216 To: smithjd, bruns, mgallien Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D13216: Overhaul the file index scheduler.

smithjd added inline comments. INLINE COMMENTS > bruns wrote in fileindexscheduler.cpp:117 > Whats that supposed to do (I have an idea, but thats ugly ...) This starts a QRunnable at a negative priority (in this case the negative integer value for NewFiles) and then calls

D15047: Export the StorageDevices object.

smithjd added a comment. In D15047#314741 , @bruns wrote: > In D15047#314485 , @smithjd wrote: > > > In D15047#314477 , @bruns wrote: > > > > > There

D11529: Balooctl: Deindex unfound files with check command.

smithjd added inline comments. INLINE COMMENTS > bruns wrote in indexcleaner.cpp:76 > Undesired detach This example will also detach with or without a const intermediate. > ...returning a copy from a method means that the copy is shared and has > negative side-effects when used with

D13216: Overhaul the file index scheduler.

smithjd updated this revision to Diff 40393. smithjd added a comment. - Revert "Re-order and use IndexerState to prioritize the indexer thread pool." Avoid setting a priority on the runnables. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D11529: Balooctl: Deindex unfound files with check command.

smithjd updated this revision to Diff 40394. smithjd added a comment. - New DBus method updateIndex(). - Document indexing options. - Prevent a scheduler race condition. - Rebase for separate statechanged functors. Re-base. Drops setting a runnable priority. REPOSITORY R293 Baloo

D11038: balooctl: Add pruneDb option to remove stale file index entries.

smithjd added a comment. In D11038#220486 , @michaelh wrote: > In D11038#219353 , @smithjd wrote: > > > All mounts must be manually made available by the user before running this option, or all

D11038: balooctl: Add pruneDb option to remove stale file index entries.

smithjd updated this revision to Diff 28987. smithjd added a comment. - balooctl: Clarify the prune option description. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11038?vs=28747=28987 BRANCH master-purgeDb (branched from master) REVISION DETAIL

D11038: balooctl: Add prune option to remove stale file index entries

smithjd retitled this revision from "balooctl: Add pruneDb option to remove stale file index entries." to "balooctl: Add prune option to remove stale file index entries". REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11038 To: smithjd, #baloo, #frameworks, michaelh

D11038: balooctl: Add prune option to remove stale file index entries

smithjd updated this revision to Diff 29280. smithjd added a comment. - Open the transaction in read-write mode. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11038?vs=29184=29280 BRANCH master-purgeDb (branched from master) REVISION DETAIL

  1   2   >