Re: Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

2014-02-23 Thread Kai Uwe Broulik
/#comment35567 There is no such parameter? - Kai Uwe Broulik On Feb. 23, 2014, 9:56 a.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115959

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2014-06-19 Thread Kai Uwe Broulik
On June 19, 2014, 8:42 p.m., David Edmundson wrote: Note: The property names don't line up 100% in the merge. flickableItem has now become contentItem (which is a default property) All instances in plasma-workspace/plasma-desktop are now updated. Kai Uwe Broulik wrote

Re: Review Request 111908: Add KConfigLoader from Plasma Framework to KConfigGui

2013-08-09 Thread Kai Uwe Broulik
On Aug. 9, 2013, 2:55 p.m., David Edmundson wrote: tier1/kconfig/src/gui/kconfigloader.cpp, line 65 http://git.reviewboard.kde.org/r/111908/diff/3/?file=177535#file177535line65 This would be best with use of QLatin1String() thoughout this file. QStringLiteral? - Kai Uwe

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

2014-08-24 Thread Kai Uwe Broulik
checkbox in battery monitor has become quite small here now. - Kai Uwe Broulik On Aug. 20, 2014, 6:51 nachm., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119846

Re: Review Request 119975: KDBusService shouldn't crash upon bad application name

2014-08-28 Thread Kai Uwe Broulik
/119975/#comment45731 objectPath.remove(QLatin1Char('-')); - Kai Uwe Broulik On Aug. 28, 2014, 3:18 nachm., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Review Request 120092: Turn KFormat into Q_GADGET and expose DurationFormat

2014-09-07 Thread Kai Uwe Broulik
Diff: https://git.reviewboard.kde.org/r/120092/diff/ Testing --- Works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120092: Turn KFormat into Q_GADGET and expose DurationFormat

2014-09-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120092/#review65987 --- On Sept. 7, 2014, 1:49 nachm., Kai Uwe Broulik wrote

Re: Review Request 120092: Turn KFormat into Q_GADGET and expose DurationFormat

2014-09-09 Thread Kai Uwe Broulik
/util/kformat.h 7a6a418 src/lib/util/kformat.cpp d62240e Diff: https://git.reviewboard.kde.org/r/120092/diff/ Testing --- Works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 120360: force layout to zero when adding page to force alignment with title widget

2014-09-25 Thread Kai Uwe Broulik
://git.reviewboard.kde.org//r/120360/#fcomment268 What is that gray are at the bottom? It's not present in the before screenshot. - Kai Uwe Broulik On Sept. 25, 2014, 12:33 nachm., Hugo Pereira Da Costa wrote

Re: Review Request 120360: force layout to zero when adding page to force alignment with title widget

2014-09-25 Thread Kai Uwe Broulik
/#comment47051 if (widget-layout()) { widget-layout()-setMargin(0); } - Kai Uwe Broulik On Sept. 25, 2014, 12:33 nachm., Hugo Pereira Da Costa wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 120887: add custom icons to KNotification

2014-10-29 Thread Kai Uwe Broulik
/knotification.h https://git.reviewboard.kde.org/r/120887/#comment48517 Maybe iconName ? To me setIcon implies it accepts a QIcon(), how is this handled in other places? src/notifybypopup.cpp https://git.reviewboard.kde.org/r/120887/#comment48520 *override - Kai Uwe Broulik On Okt. 29, 2014

Re: Review Request 120887: add custom icons to KNotification

2014-10-29 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120887/#review69424 --- Ship it! Ship It! - Kai Uwe Broulik On Okt. 29, 2014, 11

Re: Review Request 120909: in kio_smb: Set inode/directory mimetype for folders

2014-10-30 Thread Kai Uwe Broulik
into figuring out the miemtype for remotes url but now it is not Is this the reason I don't get folder icons on FTP anymore either? - Kai Uwe Broulik On Okt. 30, 2014, 10:42 nachm., Àlex Fiestas wrote: --- This is an automatically generated

Re: Supporting MSVC2010 in ktexteditor framework

2014-11-17 Thread Kai Uwe Broulik
- initializer lists Unsupported on VS2012. Again, seems to be that CTP thingie, damn. (though, again, the initializer lists should also be tested - maybe they also work if the number of arguments is less than ...) I've had problems with them even on VS2013, like return QHashint,

Re: Where are my systray icons cont'd

2014-11-27 Thread Kai Uwe Broulik
Am Donnerstag, 27. November 2014, 21:28:21 schrieb Jan Grulich: As I know, skype is only 32-bit so if you have 64-bit system, you need 32-bit version of sni-qt. I had the same problem on Fedora and installing sni-qt.i686 solved this problem. Uh! Thanks for the tip. That made Skype's tray icon

Review Request 121299: Add NET::OSD window type

2014-11-30 Thread Kai Uwe Broulik
--- In conjunction with Review 121300 these are now ontop of fullscreen windows. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121299: Add NET::OSD window type

2014-12-01 Thread Kai Uwe Broulik
16ba4b3 src/netwm.cpp 1ccba32 src/netwm_def.h 0352f33 Diff: https://git.reviewboard.kde.org/r/121299/diff/ Testing --- In conjunction with Review 121300 these are now ontop of fullscreen windows. Thanks, Kai Uwe Broulik ___ Kde

Re: Review Request 121299: Add NET::OSD window type

2014-12-06 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121299/#review71479 --- Ping? - Kai Uwe Broulik On Dez. 1, 2014, 6:49 nachm., Kai

Re: Review Request 121299: Add NET::OSD window type

2014-12-08 Thread Kai Uwe Broulik
/netwm.cpp 1ccba32 src/netwm_def.h 0352f33 Diff: https://git.reviewboard.kde.org/r/121299/diff/ Testing --- In conjunction with Review 121300 these are now ontop of fullscreen windows. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing

Re: Review Request 121299: Add NET::OSD window type

2014-12-08 Thread Kai Uwe Broulik
On Dez. 8, 2014, 9:34 vorm., Kai Uwe Broulik wrote: the autotest for NET::Supported is not extended for the new supported type Martin Gräßlin wrote: I'm still missing the extension of the autotest. In fact I'd expect that at least one autotest is currently failing. Could you be more

Re: Review Request 121299: Add NET::OSD window type

2014-12-19 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121299/#review72290 --- Ping - Kai Uwe Broulik On Dez. 9, 2014, 6:16 nachm., Kai

Re: Review Request 121299: Add NET::OSD window type

2015-01-01 Thread Kai Uwe Broulik
and I'd like to get this in for Plasma 5.2 - Kai Uwe Broulik On Dez. 9, 2014, 6:16 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121299

Re: Review Request 122360: Make FTP error messages prettier

2015-02-08 Thread Kai Uwe Broulik
Diff: https://git.reviewboard.kde.org/r/122360/diff/ Testing --- Works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 122360: Make FTP error messages prettier

2015-02-01 Thread Kai Uwe Broulik
/show_bug.cgi?id=318079 Repository: kio Description --- This is the patch from Review 110084 rebased on frameworks and using remoteEncoding Diffs - src/ioslaves/ftp/ftp.cpp b060c95 Diff: https://git.reviewboard.kde.org/r/122360/diff/ Testing --- Works. Thanks, Kai Uwe

Review Request 122590: Guard kglobalaccel against QApplication

2015-02-16 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/122590/diff/ Testing --- screenlocker no longer blows up when adding the mpris dataengine which does kglobalaccel stuff but I have no idea whether this is the right approach and what the widget is actually for. Thanks, Kai Uwe Broulik

Re: Review Request 122590: Guard kglobalaccel against QApplication

2015-02-16 Thread Kai Uwe Broulik
and what the widget is actually for. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122893: Populate KIconDialog on showEvent

2015-03-11 Thread Kai Uwe Broulik
. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122893: Populate KIconDialog on showEvent

2015-03-14 Thread Kai Uwe Broulik
--- On März 13, 2015, 6:36 vorm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122893

Review Request 122893: Populate KIconDialog on showEvent

2015-03-10 Thread Kai Uwe Broulik
/kicondialog.cpp 7a6c1f1 Diff: https://git.reviewboard.kde.org/r/122893/diff/ Testing --- Just calling show() on the KIconDialog works as expected, the icon button in kfileproperties thingie dialog still works. Thanks, Kai Uwe Broulik ___ Kde-frameworks

Re: Review Request 122893: Populate KIconDialog on showEvent

2015-03-13 Thread Kai Uwe Broulik
dialog still works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122893: Populate KIconDialog on showEvent

2015-03-12 Thread Kai Uwe Broulik
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit 1e9af6c54470e890597739f8f2189b0743a00b6f by Kai Uwe Broulik to branch master. Repository: kiconthemes Description --- Populate the dialog on showEvent, this way you can use the regular

Re: Review Request 122893: Populate KIconDialog on showEvent

2015-03-12 Thread Kai Uwe Broulik
button in kfileproperties thingie dialog still works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122590: Guard kglobalaccel against QApplication

2015-03-10 Thread Kai Uwe Broulik
marked as submitted. Review request for KDE Frameworks, David Edmundson and Martin Gräßlin. Changes --- Submitted with commit dcb5c0403c5caad901a46b2ae496078af0a90d12 by Kai Uwe Broulik to branch master. Repository: kglobalaccel Description --- KGlobalAccelPrivate uses a QWidget

Re: Review Request 122741: Prefer exposing lists to QML with QJsonArray

2015-03-02 Thread Kai Uwe Broulik
engine provides automatic type conversion between QVariantList and JavaScript arrays[…] and I haven't seen any issues with the conversion. Did you try QStringList? - Kai Uwe Broulik On März 2, 2015, 6:14 nachm., Aleix Pol Gonzalez wrote

Re: Review Request 122590: Guard kglobalaccel against QApplication

2015-02-26 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122590/#review76686 --- Ping, Frameworks people? - Kai Uwe Broulik On Feb. 16

Re: Review Request 122590: Guard kglobalaccel against QApplication

2015-02-26 Thread Kai Uwe Broulik
stuff but I have no idea whether this is the right approach and what the widget is actually for. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122029: Fix generation of KAuth DBus helper service file

2015-01-13 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122029/#review73976 --- Perhaps fixes Bug 337674 and Bug 341775 ? - Kai Uwe Broulik

Re: Review Request 123736: single QQmlEngine for all applets

2015-05-12 Thread Kai Uwe Broulik
-RequiredExtensions=LaunchApp will still have own engine You mean SharedEngine? :) - Kai Uwe Broulik On Mai 12, 2015, 3:30 nachm., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Review Request 123216: Save some memory in kglobalaccel runtime

2015-04-01 Thread Kai Uwe Broulik
/122590/ ? - Kai Uwe Broulik On April 1, 2015, 5:23 nachm., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123216

Re: Review Request 124014: Add QQC clone of KColorButton

2015-06-05 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/124014/#comment55623 You probably want to add an alias for the showAlphaChannel, title, and currentColor properties? - Kai Uwe Broulik On Juni 5, 2015, 10:46 vorm., David Edmundson wrote

Re: Review Request 124014: Add QQC clone of KColorButton

2015-06-06 Thread Kai Uwe Broulik
- 95) https://git.reviewboard.kde.org/r/124014/#comment55674 Now you get half the opacity opacity is set to the color's opacity but the color also has the opacity. Either use Qt.rgba(color.r, color.g, color.b, 1) or just drop the opacity - Kai Uwe Broulik On Juni 6, 2015, 10

Re: Review Request 124089: Connected timeout before timer start.

2015-06-12 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/124089/#comment55801 New connect syntax maybe? Also, please don't give a Ship It to yourself, that's for the maintainers. - Kai Uwe Broulik On Juni 12, 2015, 8:27 nachm., Jordan He wrote: --- This is an automatically

Re: Review Request 124212: kwindowsystem: Change source file layout

2015-06-30 Thread Kai Uwe Broulik
On Juni 30, 2015, 8:30 vorm., Kai Uwe Broulik wrote: Doesn't build on OSX: [ 24%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/osx/kkeyserver_mac.cpp.o [ 27%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/KF5WindowSystem_automoc.cpp.o In file

Re: Review Request 124212: kwindowsystem: Change source file layout

2015-06-30 Thread Kai Uwe Broulik
/kkeyserver_mac.cpp:64:13: warning: unused variable 'lastLayoutID' [-Wunused-variable] static long lastLayoutID = -1; ^ 1 warning generated. make[1]: *** [src/CMakeFiles/KF5WindowSystem.dir/all] Error 2 make: *** [all] Error 2 - Kai Uwe Broulik On Juni 30, 2015, 6:19 vorm., Martin

Re: Review Request 122893: Populate KIconDialog on showEvent

2015-07-03 Thread Kai Uwe Broulik
works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124213: Add standard shortcut for new tab action

2015-06-30 Thread Kai Uwe Broulik
that used for that purpose, just incognito mode, or new window in applications like Konsole. src/gui/kstandardshortcut.h (line 372) https://git.reviewboard.kde.org/r/124213/#comment56244 Isn't Ctrl+Tab usually next tab? - Kai Uwe Broulik On Juni 30, 2015, 9:13 vorm., Simon Persson wrote

Re: Review Request 124212: kwindowsystem: Change source file layout

2015-06-30 Thread Kai Uwe Broulik
On Juni 30, 2015, 8:30 vorm., Kai Uwe Broulik wrote: Doesn't build on OSX: [ 24%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/platforms/osx/kkeyserver_mac.cpp.o [ 27%] Building CXX object src/CMakeFiles/KF5WindowSystem.dir/KF5WindowSystem_automoc.cpp.o In file

Re: Review Request 124014: Add QQC clone of KColorButton

2015-07-02 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124014/#review82011 --- Ship it! Ship It! - Kai Uwe Broulik On Juni 7, 2015, 7:30

Re: Review Request 123890: Don't show KDE Frameworks version in the About KDE dialog

2015-05-24 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/123890/#comment55377 I suppose you can also remove the HTML stuff since KTitleWidget now uses an increased font size anyway. - Kai Uwe Broulik On Mai 24, 2015, 4:26 vorm., Albert Astals Cid wrote

Re: Minimum supported version of MSVC for frameworks

2015-08-13 Thread Kai Uwe Broulik
‎Hi, My experience with MSVC 2013 was that you even need at least Update 4 for initializer lists to work properly, which was released quite recently iirc. Cheers, Kai Uwe   Originalnachricht   Von: Kevin Funk Gesendet: Donnerstag, 13. August 2015 10:48 An: kde-frameworks-devel Antwort an:

Review Request 124872: Default to Breeze colors

2015-08-21 Thread Kai Uwe Broulik
decoration which is set in the WM section of kdeglobals by the breeze.colors but KWin defaults to highlight colors, so it stays blue. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 124872: Default to Breeze colors

2015-08-21 Thread Kai Uwe Broulik
/diff/ Testing --- Seems to look right, typos reserved :) Only thing missing now is the window decoration which is set in the WM section of kdeglobals by the breeze.colors but KWin defaults to highlight colors, so it stays blue. Thanks, Kai Uwe Broulik

Re: Review Request 124746: [KDesktopFile] add readMimeType

2015-08-19 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/124746/#review84020 --- On Aug. 15, 2015, 5:38 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org

Re: Review Request 124902: Delay starting kglobalaccel5 till it's needed

2015-08-24 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/124902/#comment58351 No non trivial global static in a lib? - Kai Uwe Broulik On Aug. 24, 2015, 11:35 vorm., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https

Review Request 124746: [KDesktopFile] add readMimeType

2015-08-15 Thread Kai Uwe Broulik
/kdesktopfile.cpp 254b59a autotests/kdesktopfiletest.cpp 1a9c1c3 src/core/kdesktopfile.h 2190051 Diff: https://git.reviewboard.kde.org/r/124746/diff/ Testing --- Test passes Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 124397: Add today button to calendar

2015-07-19 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/124397/#comment57008 ToolButton is square by default src/declarativeimports/calendar/qml/MonthView.qml (lines 161 - 164) https://git.reviewboard.kde.org/r/124397/#comment57007 ToolButton has a tooltip property, no need for a custom tooltip - Kai Uwe Broulik

Re: Review Request 124397: Add today button to calendar

2015-07-19 Thread Kai Uwe Broulik
think of this earlier :) - Kai Uwe Broulik On Juli 19, 2015, 5:06 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397

Review Request 125790: Recognize image/vnd.adobe.photoshop

2015-10-25 Thread Kai Uwe Broulik
Description --- This is the mimetype I get for .psd files Diffs - src/imageformats/psd.desktop 494b746 src/imageformats/psd.json 859eede Diff: https://git.reviewboard.kde.org/r/125790/diff/ Testing --- I still don't get any thumbnails for PSD files, though. Thanks, Kai Uwe

Review Request 125788: [kio thumbnailer] Recognize image/webp

2015-10-25 Thread Kai Uwe Broulik
, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125788: [kio thumbnailer] Recognize image/webp

2015-10-25 Thread Kai Uwe Broulik
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit b77547ad90467a7f0a37469e9a58417c4ea63b8a by Kai Uwe Broulik to branch Applications/15.08. Repository: kio-extras Description --- When I download a .webp file the system claims it to be image

Re: Review Request 125976: add an update() method

2015-11-09 Thread Kai Uwe Broulik
syntax in frameworks. src/kpackage/package.h (line 95) <https://git.reviewboard.kde.org/r/125976/#comment60485> NewerVersionAlreadyInstalledError src/kpackage/package.h (line 96) <https://git.reviewboard.kde.org/r/125976/#comment60486> +Error - Kai Uwe Broulik On Nov. 9

Re: Review Request 126087: Move the i18n context from KDeclarative

2015-11-17 Thread Kai Uwe Broulik
> On Nov. 16, 2015, 2:08 nachm., Milian Wolff wrote: > > src/klocalizedcontext.cpp, line 53 > > > > > > isNull or isEmpty? Don't we usually want to check against isEmpty and > > never against isNull? Isn't the

Re: Review Request 125790: Recognize image/vnd.adobe.photoshop

2015-11-07 Thread Kai Uwe Broulik
/125790/diff/ Testing --- I still don't get any thumbnails for PSD files, though. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125790: Recognize image/vnd.adobe.photoshop

2015-11-03 Thread Kai Uwe Broulik
/125790/diff/ Testing --- I still don't get any thumbnails for PSD files, though. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

AW: Install UdevQt headers in Solid

2015-11-05 Thread Kai Uwe Broulik
+1 but I guess we should review and cleanup that stuff whilst at it, however I don't really have time to make this stuff Frameworks ready Gesendet von meinem BlackBerry 10-Smartphone.   Originalnachricht   Von: David Rosca Gesendet: Donnerstag, 5. November 2015 14:27 An:

Re: Review Request 124963: New widget: KNewPasswordWidget

2015-10-11 Thread Kai Uwe Broulik
> On Okt. 11, 2015, 9:16 nachm., David Faure wrote: > > src/knewpasswordwidget.cpp, line 101 > > > > > > qBound(pwstrength, 0, 100) :-) qBound(0, pwstrength, 100) actually - Kai Uwe

Re: Review Request 124307: Remove Theme tree debug entry

2015-07-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124307/#review82273 --- +1 - Kai Uwe Broulik On Juli 9, 2015, 2:55 nachm., Aleix

Re: Review Request 124281: Remove KService and KIconThemes usage from KNotifications

2015-07-09 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/124281/#comment56648 Unused - Kai Uwe Broulik On Juli 9, 2015, 1:10 nachm., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124281

Re: Review Request 124941: Reparse notification config only when actually needed

2015-08-26 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/124941/#comment58447 It's 2015 now src/knotificationmanager.cpp (line 175) https://git.reviewboard.kde.org/r/124941/#comment58448 Given you already check whether the entry exists before adding it, a removeOne should be sufficient - Kai Uwe Broulik On Aug. 26, 2015, 9:05

Re: Review Request 124746: [KDesktopFile] add readMimeType

2015-09-06 Thread Kai Uwe Broulik
est passes Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124746: [KDesktopFile] add readMimeType

2015-09-07 Thread Kai Uwe Broulik
marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit f7a2eef8ac3758cce61717a74987219da6f5d94e by Kai Uwe Broulik to branch master. Repository: kconfig Description --- This allows to get the MimeType field of a desktop file to determin whether eg

Re: Review Request 125268: Fix signal-slot connections in KNewFileMenuPrivate::confirmCreatingHiddenDir(QString)

2015-09-16 Thread Kai Uwe Broulik
, so we could spot things like these easier in the future. - Kai Uwe Broulik On Sept. 16, 2015, 8:22 nachm., Frank Reininghaus wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboa

Re: Review Request 124872: Default to Breeze colors

2015-10-05 Thread Kai Uwe Broulik
marked as submitted. Review request for KDE Frameworks, Plasma and KDE Usability. Changes --- Submitted with commit 0d6cc21a5685846be4af9491e10d47bd7ee12a65 by Kai Uwe Broulik to branch master. Bugs: 351530 https://bugs.kde.org/show_bug.cgi?id=351530 Repository: kconfigwidgets

Re: [OS X/Wayland] using WIds created by a different process to create KMessageBox'es and other widgets/windows

2015-12-09 Thread Kai Uwe Broulik
‎> On OS X (and MS Windows?),  And Wayland, so it affects Linux, too. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

2015-12-13 Thread Kai Uwe Broulik
hours /o\ Do we need a respin of KF5 for this? It's pretty serious if Plasma just doesn't start for no apparent reason. - Kai Uwe Broulik On Dez. 11, 2015, 6:48 nachm., Martin Klapetek wrote: > > --- > This is an automatically ge

Re: RFC: split platformtheme plugin from frameworkintegration and move to kde/workspace

2015-12-10 Thread Kai Uwe Broulik
Hi,Mark, I think you completely misunderstood what move to kde/workspace means. This is not a repository, nobody wants to move that stuff into plasma-workspace. It just has semantic relevance, ie. no frameworks

Re: Review Request 126167: Expose QMimeType comment

2015-12-14 Thread Kai Uwe Broulik
marked as submitted. Review request for KDE Frameworks and Aleix Pol Gonzalez. Changes --- Submitted with commit aa412c02657828f68f2ac4a3a303853f255525a5 by Kai Uwe Broulik to branch master. Repository: kdeclarative Description --- This allows to show the pretty name ("text

Re: Review Request 126595: [KFileMetaData] Allow querying for a file's origin URL

2016-01-04 Thread Kai Uwe Broulik
/CommonExtendedAttributes/ Diffs (updated) - src/properties.h 64ba0be src/propertyinfo.cpp 0b298b6 src/usermetadata.h ab58e16 src/usermetadata.cpp 51c87f8 Diff: https://git.reviewboard.kde.org/r/126595/diff/ Testing --- Works. Thanks, Kai Uwe Broulik

Re: Review Request 126595: [KFileMetaData] Allow querying for a file's origin URL

2016-01-02 Thread Kai Uwe Broulik
st entry of course must stay last. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126595/#review90435 --- On Jan. 2, 2016,

Re: Review Request 126149: [Icon widget] Bring back properties dialog

2015-12-29 Thread Kai Uwe Broulik
is removed :) - Kai Uwe Broulik On Dez. 21, 2015, 11:31 nachm., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126595: [KFileMetaData] Allow querying for a file's origin URL

2016-01-01 Thread Kai Uwe Broulik
/CommonExtendedAttributes/ Diffs (updated) - src/properties.h 64ba0be src/propertyinfo.cpp 0b298b6 src/usermetadata.h ab58e16 src/usermetadata.cpp 51c87f8 Diff: https://git.reviewboard.kde.org/r/126595/diff/ Testing --- Works. Thanks, Kai Uwe Broulik

Review Request 126595: [KFileMetaData] Allow querying for a file's origin URL

2016-01-01 Thread Kai Uwe Broulik
51c87f8 Diff: https://git.reviewboard.kde.org/r/126595/diff/ Testing --- Works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126650: [WIP] Add PM/ScreenSaver Inhibition capabilities to KIdleTime

2016-01-06 Thread Kai Uwe Broulik
e will have a spurious inhibition in that case. PowerDevil tracks when an application closes but it obviously cannot detect this case. src/inhibition.cpp (line 274) <https://git.reviewboard.kde.org/r/126650/#comment62002> perhaps an error signal and have the status enum only reflect activ

Re: Review Request 126568: [KNotifyConfigWidget] Allow selecting a specific event

2015-12-29 Thread Kai Uwe Broulik
src/knotifyconfigwidget.h 9c1bbfa src/knotifyconfigwidget.cpp 4653529 src/knotifyeventlist.h 9d9804c src/knotifyeventlist.cpp 6046d2d Diff: https://git.reviewboard.kde.org/r/126568/diff/ Testing --- Works Thanks, Kai Uwe Broulik

Re: Review Request 126516: Add StatusNotifier flag

2015-12-29 Thread Kai Uwe Broulik
://git.reviewboard.kde.org/r/126516/diff/ Testing --- Works. Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 126568: [KNotifyConfigWidget] Allow selecting a specific event

2015-12-29 Thread Kai Uwe Broulik
/knotifyeventlist.h 9d9804c src/knotifyeventlist.cpp 6046d2d Diff: https://git.reviewboard.kde.org/r/126568/diff/ Testing --- Works Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-29 Thread Kai Uwe Broulik
ve at the right is a bit dated. - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126515/#review90316 ----------- On Dez. 2

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-29 Thread Kai Uwe Broulik
> On Dez. 29, 2015, 11:56 nachm., Ken Vermette wrote: > > In regards to the message displayed (as mentioned in your G+ post) how > > about: > > > > "Sorry for the inconvenience. Please report the error to help improve this > > software." > > K

Re: Review Request 126459: Add a hint to skip notifications grouping

2015-12-29 Thread Kai Uwe Broulik
n sets it anyway. :) - Kai Uwe Broulik On Dez. 29, 2015, 8:07 nachm., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-29 Thread Kai Uwe Broulik
ou didn't bother to look after it by then, you probably forgot what you did to cause the crash anyway :) Thanks, Kai Uwe Broulik ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126459: Add a hint to skip notifications grouping

2015-12-29 Thread Kai Uwe Broulik
> On Dez. 29, 2015, 9:50 nachm., Kai Uwe Broulik wrote: > > src/knotification.h, line 251 > > <https://git.reviewboard.kde.org/r/126459/diff/1/?file=425181#file425181line251> > > > > This must be 0x10! > > > > 0x10 = 0b1 (one bit s

Re: Review Request 126568: [KNotifyConfigWidget] Allow selecting a specific event

2015-12-30 Thread Kai Uwe Broulik
marked as submitted. Review request for KDE Frameworks, Martin Klapetek and Olivier Goffart. Changes --- Submitted with commit ab4684e67689fe71e11aafad1af63fc966443b75 by Kai Uwe Broulik to branch master. Repository: knotifyconfig Description --- This allows to programmatically

Re: Review Request 126681: Duplicate the file descriptor while opening

2016-01-09 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126681/#review90814 --- I think we should do a re-spin of KF 5.18? - Kai Uwe Broulik

Re: Review Request 126681: Duplicate the file descriptor while opening

2016-01-09 Thread Kai Uwe Broulik
> On Jan. 9, 2016, 1:28 nachm., Kai Uwe Broulik wrote: > > I think we should do a re-spin of KF 5.18? > > Luigi Toscano wrote: > I think it was already done: > https://mail.kde.org/pipermail/release-team/2016-January/009263.html ok, I was just wondering becaus

Re: Review Request 125158: add logic to use icons for default xdg user dirs

2016-01-01 Thread Kai Uwe Broulik
::iconNameForUrl as well - Kai Uwe Broulik On Okt. 22, 2015, 7:26 vorm., Harald Sitter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2016-01-04 Thread Kai Uwe Broulik
marked as submitted. Review request for KDE Frameworks, Plasma, KDE Usability, and Martin Gräßlin. Changes --- Submitted with commit 555ff08dc1efaeb7d1f699856347f5e0e9aff1d0 by Kai Uwe Broulik to branch master. Repository: plasma-workspace Description --- This adds a new "--pa

Re: Review Request 125619: Refactor KNewPasswordDialog class

2015-12-21 Thread Kai Uwe Broulik
message which looks quite out of place otherwise. - Kai Uwe Broulik On Nov. 19, 2015, 11:04 vorm., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126149: [Icon widget] Bring back properties dialog

2015-12-21 Thread Kai Uwe Broulik
ile, allowing to rename it. The applet reflected the changes. Dropped an application from kickoff to the desktop -> dialog from a copy of the desktop file, allowing to change its icon and description. The applet reflected the changes. Thanks, Kai Uwe B

Review Request 126516: Add StatusNotifier flag

2015-12-25 Thread Kai Uwe Broulik
--- This adds a StatusNotifier flag that starts DrKonqi with the --passive argument introduced in Review 126515 Diffs - src/kcrash.cpp 7d3b8a2 src/kcrash.h e2b59f2 Diff: https://git.reviewboard.kde.org/r/126516/diff/ Testing --- Works. Thanks, Kai Uwe Broulik

Review Request 126515: [DrKonqi] RFC: Support showing a StatusNotifierItem instead of bringing up the dialog right away

2015-12-25 Thread Kai Uwe Broulik
een, just the panel restarting. Afterwards I got a SNI which opened DrKonqi when tapped. The SNI disappears after 1 minute because if you didn't bother to look after it by then, you probably forgot what you did to cause the crash anyway :) Thanks, Kai Uwe Broulik

  1   2   3   4   5   6   7   8   9   10   >