Ktextwidget module

2014-01-15 Thread laurent Montel
Hi, I will maintain this module. I spoke this morning with David Gil and he is ok with it. This is used a lot in kdepim/kmail and I worked on it (in kdelibs) before. So I am interesting to maintain it. I will change name in wiki. Regards -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt

Re: How to port KIntSpinBox::setSuffix

2014-06-01 Thread laurent Montel
, but as far as I can see there is suitable replacement for the plural aware suffix. What is the best solution to port this without introducing regressions? This appears to be missing currently. Laurent Montel asked me the same question on May 18, and I answered: * this needs to be added

Re: How to port KIntSpinBox::setSuffix

2014-06-03 Thread laurent Montel
for 1.15? :-) Did kdelibs4 have that functionality? No it doesn’t have :) In KDoubleNumInput we use normal void setSuffix(const QString suffix); = not necessary to create it for QDoubleSpinbox Regards -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S

Need help to port to new QT5 plugins

2014-07-02 Thread laurent Montel
there is some method to debug it. Thanks Regards. -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, http://www.kdab.fr ___ Kde-frameworks-devel mailing

Re: Need help to port to new QT5 plugins

2014-07-02 Thread laurent Montel
Le mercredi 2 juillet 2014 16:25:28 David Faure a écrit : On Wednesday 02 July 2014 13:30:36 laurent Montel wrote: Plugin verification data mismatch in '/opt/kde5/lib64/plugins/akonadi_akonotes_resource.so' It *is* found, it's rather that QLibrary thinks there's a mismatch. Try

Re: Need help to port to new QT5 plugins

2014-07-03 Thread laurent Montel
another bug :) ) Thanks Regards Le mercredi 2 juillet 2014 23:48:05 laurent Montel a écrit : Le mercredi 2 juillet 2014 16:25:28 David Faure a écrit : On Wednesday 02 July 2014 13:30:36 laurent Montel wrote: Plugin verification data mismatch in '/opt/kde5/lib64/plugins

Allow to add a ActionButton in KPageDialog

2014-07-03 Thread laurent Montel
about it ? (Example when we need to add a ActionButton, it’s when we have a old User1 button). Regards -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, http://www.kdab.fr diff --git a/src

Re: Allow to add a ActionButton in KPageDialog

2014-07-04 Thread laurent Montel
Le vendredi 4 juillet 2014 16:46:24 Christoph Feck a écrit : On Thursday 03 July 2014 19:50:35 laurent Montel wrote: Hi, During kdepim porting I saw that it was not possible to add a ActionButton as QButtonBox is protected. = we can do it if we create a derived class. But it’s

Fix signal/Slot in kcmutils/dialog

2014-07-08 Thread laurent Montel
Hi, In qt4 it was a KDialog so okClicked() and applyClicked() existed. Now it’s a KPageDialog = a QDialog so we must to connect to QDialogButtonBox. This patch fixes bad signal. Can I commit it ? Thanks -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB

Re: Review Request 119388: Add KDE Frameworks 5 simple app

2014-07-22 Thread Laurent Montel
addHelpOption or addVersionOption. I tested and not added. - Laurent Montel On juil. 21, 2014, 4:16 après-midi, Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119388

Re: Review Request 119388: Add KDE Frameworks 5 simple app

2014-07-22 Thread Laurent Montel
On juil. 22, 2014, 7:42 matin, Laurent Montel wrote: templates/C++/kde-frameworks5-simple/src/main.cpp, line 43 https://git.reviewboard.kde.org/r/119388/diff/1/?file=291491#file291491line43 bool KAboutData::setupCommandLine(QCommandLineParser *parser) { if (!d

Re: Review Request 119444: Replacing also kicon.h header include

2014-07-24 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119444/#review63030 --- Ship it! Ship It! - Laurent Montel On juil. 23, 2014, 11

Re: Review Request 119435: Replacing also kaction.h header include

2014-07-24 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119435/#review63029 --- Ship it! Ship It! - Laurent Montel On juil. 23, 2014, 9

Re: KAction Warning

2014-08-05 Thread laurent Montel
::setShortcut()! See KAction documentation. ... How to fix that? Warning improved in http://commits.kde.org/kxmlgui/11cb423c0de0090ea398efa5d1bccd2a39e97987 - use KAction::setDefaultShortcut(s) s/KAction::setDefaultShortcut/KActionCollection::setDefaultShortcut/ :) -- Laurent Montel

Re: How to promote less mature Frameworks?

2014-08-20 Thread laurent Montel
. For the moment it's not done because there is still a lot of work to do. We will split soon, and we will move each module when ready to kf5 I work to make module ready soon. We will keep API/ABI stable as usual. We did it in kdepimlibs 4.0 so it will not change. Regards -- Laurent Montel

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-21 Thread Laurent Montel
/diff/ Testing --- Thanks, Laurent Montel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-22 Thread Laurent Montel
: https://git.reviewboard.kde.org/r/119895/diff/ Testing --- Thanks, Laurent Montel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-22 Thread Laurent Montel
: https://git.reviewboard.kde.org/r/119895/diff/ Testing --- Thanks, Laurent Montel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-22 Thread Laurent Montel
On août 22, 2014, 9:39 matin, Laurent Montel wrote: Just a general question: do we really want a porting class in core addons? Kdelibs4Migration is already in this addons. Where do you want to put it ? In which module ? - Laurent

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-22 Thread Laurent Montel
Diff: https://git.reviewboard.kde.org/r/119895/diff/ Testing --- Thanks, Laurent Montel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-22 Thread Laurent Montel
On août 22, 2014, 9:39 matin, Laurent Montel wrote: Just a general question: do we really want a porting class in core addons? Laurent Montel wrote: Kdelibs4Migration is already in this addons. Where do you want to put it ? In which module ? Kevin Krammer wrote: I just

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-22 Thread Laurent Montel
On août 22, 2014, 9:39 matin, Laurent Montel wrote: Just a general question: do we really want a porting class in core addons? Laurent Montel wrote: Kdelibs4Migration is already in this addons. Where do you want to put it ? In which module ? Kevin Krammer wrote: I just

split kdepimlibs

2014-08-26 Thread laurent Montel
kpimidentities kpimtextedit kpimutils ktnef kxmlrpcclient mailtransport microblog qgpgme syndication is it ok for you ? Regards -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, http

Re: split kdepimlibs

2014-08-26 Thread laurent Montel
Le mardi 26 août 2014 11:50:50 Kevin Ottens a écrit : On Tuesday 26 August 2014 11:20:25 laurent Montel wrote: Hi, I will split kdepimlibs as it akonadi (need to find another name because it's still used) akonadi-abc akonadi-calendar akonadi-contact akonadi-mime akonadi-notes

Re: split kdepimlibs

2014-08-26 Thread laurent Montel
Le mardi 26 août 2014 12:37:40 Aleix Pol a écrit : On Tue, Aug 26, 2014 at 11:20 AM, laurent Montel mon...@kde.org wrote: Hi, I will split kdepimlibs as it akonadi (need to find another name because it's still used) akonadi-abc akonadi-calendar akonadi-contact akonadi-mime

Re: split kdepimlibs

2014-08-26 Thread laurent Montel
not a problem fo me. Cheers, Kevin -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, http://www.kdab.fr ___ Kde-frameworks-devel mailing list Kde

Re: split kdepimlibs

2014-08-26 Thread laurent Montel
Le mardi 26 août 2014 17:24:24 Kevin Krammer a écrit : Looks like you forgot to add the KDE PIM list :-) On Tuesday, 2014-08-26, 11:20:25, laurent Montel wrote: Hi, I will split kdepimlibs as it akonadi (need to find another name because it's still used) akonadi-abc

Re: split kdepimlibs

2014-08-26 Thread laurent Montel
Le mardi 26 août 2014 18:25:01 Daniel Vratil a écrit : On Tuesday 26 of August 2014 12:32:48 laurent Montel wrote: Le mardi 26 août 2014 11:50:50 Kevin Ottens a écrit : On Tuesday 26 August 2014 11:20:25 laurent Montel wrote: Hi, I will split kdepimlibs as it akonadi (need

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-27 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119895/#review65350 --- So what do I do ? - Laurent Montel On août 22, 2014, 10:55

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-27 Thread Laurent Montel
PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119895/diff/ Testing --- Thanks, Laurent Montel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: split kdepimlibs

2014-08-28 Thread laurent Montel
Le mardi 26 août 2014 11:50:50 Kevin Ottens a écrit : kpimidentities Maybe deserves a better name? kidentitymanagement? Done. kpimtextedit I suspect it could get a better name, but couldn't decide yet. :-) Also I wonder if some of it could/should go in ktexteditor? But I don't know

Re: Review Request 120062: KActionCollection::setDefaultShortcuts now makes the shortcut active too.

2014-09-05 Thread Laurent Montel
:) And tomorrow you tag kf5.2 so it will good to have it in this release. - Laurent Montel On sep. 5, 2014, 8:39 matin, David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org

Re: Ksshaskpass ?

2014-11-02 Thread laurent Montel
have is where should it end up ultimately? In frameworks with/inside kwallet? in kde/workspace/plasma-desktop ? thanks, Jeremy On Sat, Nov 1, 2014 at 11:34 AM, laurent Montel mon...@kde.org wrote: Le Saturday 01 November 2014 10:29:13 Jeremy Whiting a écrit : I was wondering

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

2014-11-11 Thread Laurent Montel
://git.reviewboard.kde.org/r/121095/#comment49103 Perhaps we can remove this #if QT_VERSION no ?:) We use QT 5.0 :) - Laurent Montel On nov. 10, 2014, 3:59 après-midi, Dan Vrátil wrote: --- This is an automatically generated e-mail

Re: Review Request 121094: KCoreAddons: add KTextToHTML class for plaintext - HTML conversion

2014-11-11 Thread Laurent Montel
https://git.reviewboard.kde.org/r/121094/#comment49107 same here src/lib/text/ktexttohtml.cpp https://git.reviewboard.kde.org/r/121094/#comment49108 same here src/lib/text/ktexttohtml.cpp https://git.reviewboard.kde.org/r/121094/#comment49109 same here - Laurent Montel On nov

Re: Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

2014-11-11 Thread Laurent Montel
request) as David Faure for example. Without a specific guy I think that nobody will comment them. Regards - Laurent Montel On nov. 11, 2014, 12:12 après-midi, Daniel Vrátil wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side

2014-11-17 Thread Laurent Montel
://git.reviewboard.kde.org/r/121145/diff/ Testing --- Created a lot of unittest. I already done a lot of review code with David (thanks). This widget can be show in kmail-compositor-snipset for example (in 4.14). Thanks, Laurent Montel ___ Kde

Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side

2014-11-17 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121145/#review70515 --- On nov. 17, 2014, 3:39 après-midi, Laurent Montel wrote

Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side

2014-11-17 Thread Laurent Montel
, Laurent Montel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side

2014-11-18 Thread Laurent Montel
-CREATION src/CMakeLists.txt 059d5d9 Diff: https://git.reviewboard.kde.org/r/121145/diff/ Testing --- Created a lot of unittest. I already done a lot of review code with David (thanks). This widget can be show in kmail-compositor-snipset for example (in 4.14). Thanks, Laurent Montel

Re: Review Request 121283: Allow using new style connect in KActionCollection::add[Action]()

2014-11-30 Thread Laurent Montel
/121283/#comment49672 @since 5.5 src/kactioncollection.h https://git.reviewboard.kde.org/r/121283/#comment49673 @since 5.5 - Laurent Montel On nov. 28, 2014, 8:58 après-midi, Alexander Richardson wrote

Re: Review Request 121283: Allow using new style connect in KActionCollection::add[Action]()

2014-11-30 Thread Laurent Montel
my comment) Regards - Laurent Montel On nov. 28, 2014, 8:58 après-midi, Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121283

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2014-11-30 Thread Laurent Montel
it. By default I add dfaure :) - Laurent Montel On nov. 28, 2014, 8:02 après-midi, Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121218

Re: Review Request 122105: Fix KgDifficulty saving on app close

2015-01-17 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122105/#review74190 --- Ship it! seems good for me. Ship it - Laurent Montel

Re: Review Request 121991: New porting helper: convert-to-cmake-automoc.pl

2015-01-11 Thread Laurent Montel
://git.reviewboard.kde.org/r/121991/#comment51336 Just add K_PLUGIN_FACTORY here too for the info :) I really like this script. Just add comment and ship it. - Laurent Montel On jan. 11, 2015, 7:29 après-midi, Kevin Funk wrote

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

2015-03-17 Thread Laurent Montel
it - Laurent Montel On mars 17, 2015, 1:09 après-midi, Eugene Shalygin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

2015-03-17 Thread Laurent Montel
- Laurent Montel On mars 17, 2015, 1:05 après-midi, Eugene Shalygin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122987

Re: Review Request 122987: Allow user to specify path to myspell dictionary files

2015-03-17 Thread Laurent Montel
://git.reviewboard.kde.org/r/122987/#comment53311 #include ... we use local file. - Laurent Montel On mars 17, 2015, 1:05 après-midi, Eugene Shalygin wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [Kde-games-devel] Data migration issue

2015-03-21 Thread laurent Montel
...@kde.org https://mail.kde.org/mailman/listinfo/kde-games-devel -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, http://www.kdab.fr ___ Kde

Re: [Kde-games-devel] Data migration issue

2015-03-07 Thread laurent Montel
-- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, http://www.kdab.fr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 123095: ksnapshot: load kipi-plugins

2015-03-30 Thread Laurent Montel
but it doesn't fix bug no ? For me it's better that you create a review about a fix not just add debug and wait that it will fix no ? - Laurent Montel On mars 30, 2015, 9:22 après-midi, Gregor Mi wrote: --- This is an automatically

Re: Review Request 123095: ksnapshot: load kipi-plugins

2015-03-31 Thread Laurent Montel
On mars 31, 2015, 5:07 matin, Laurent Montel wrote: Yes but your review doesn't fix bug no ? You add more debug but it doesn't fix bug no ? For me it's better that you create a review about a fix not just add debug and wait that it will fix no ? Gregor Mi wrote: Hi Laurent

Re: Review Request 123588: Port kdelibs4configmigratortest to QStandardPaths, so it works on other platforms than XDG.

2015-05-02 Thread Laurent Montel
://git.reviewboard.kde.org/r/123588/#comment54638 You test after copy file ? It's perhaps more logical to test before no ? - Laurent Montel On mai 2, 2015, 8:17 matin, David Faure wrote: --- This is an automatically generated e

Re: Review Request 123588: Port kdelibs4configmigratortest to QStandardPaths, so it works on other platforms than XDG.

2015-05-02 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123588/#review79780 --- Ship it! Ship it - Laurent Montel On mai 2, 2015, 8:17

Re: Review Request 123588: Port kdelibs4configmigratortest to QStandardPaths, so it works on other platforms than XDG.

2015-05-02 Thread Laurent Montel
/ --- (Updated mai 2, 2015, 8:17 matin) Review request for KDE Frameworks and Laurent Montel. Repository: kcoreaddons Description --- Port kdelibs4configmigratortest to QStandardPaths, so it works on other platforms than XDG. Diffs - autotests

Re: Review Request 123390: Reorder member variables to reduce memory usage.

2015-04-16 Thread Laurent Montel
for info. - Laurent Montel On avr. 16, 2015, 7:53 après-midi, Volker Krause wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123390

Re: Review Request 123390: Reorder member variables to reduce memory usage.

2015-04-17 Thread Laurent Montel
On avr. 16, 2015, 8:43 après-midi, Laurent Montel wrote: Hi volker What did you use as program to detect it ? Thanks for info. Volker Krause wrote: The tool is called elf-packcheck, part of kde:scratch/vkrause/elf-dissector, and still in development. I'm using KF5 as testing

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

2015-04-12 Thread Laurent Montel
On avr. 12, 2015, 8:03 matin, Laurent Montel wrote: Perhaps it's time to create an unittest :) We need to be sure that it will save when we change settings no ? Kåre Särs wrote: Any hints on how to test that QSettings::setValue() is called properly (or save()) without writing

Re: Review Request 123341: Optimize reading Sonnet settings by minimizing the cals to save()

2015-04-12 Thread Laurent Montel
that it will save when we change settings no ? - Laurent Montel On avr. 12, 2015, 7:52 matin, Kåre Särs wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123341

Re: Review Request 124043: Remove unused dependency.

2015-06-08 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124043/#review81327 --- Ship it! Ship it ! - Laurent Montel On juin 8, 2015, 4:07

Re: Review Request 124071: Load correct translation catalog for kdebugdialog

2015-06-11 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124071/#review81379 --- Ship it! Seems good for me. Thanks Ship it - Laurent Montel

Re: Review Request 124065: KMimeType mimeTypeForNameAndData() - mimeTypeForFileNameAndData()

2015-06-10 Thread Laurent Montel
forgot to update script. Ship it. Thanks - Laurent Montel On juin 10, 2015, 7:51 après-midi, Jarosław Staniek wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124065

Re: Review Request 123930: Reduce temporary allocations.

2015-05-31 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123930/#review80991 --- Ship it! Seems good. Ship it - Laurent Montel On mai 30

Re: Review Request 124239: Fix KMimeType::Ptr::isNull implementation.

2015-07-03 Thread Laurent Montel
- Laurent Montel On juil. 3, 2015, 9:13 matin, Milian Wolff wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124239

Re: Review Request 123852: Optimize: Do not wipe dict cache when copying speller objects.

2015-05-23 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123852/#review80761 --- Ship it! Seems good for me. Ship it - Laurent Montel

Re: Qt version requirement in KF 5.13

2015-07-29 Thread laurent Montel
?), and by the fact that Qt 5.3 was released more than a year ago. +1 :) -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, http://www.kdab.fr ___ Kde

Review Request 125834: Generate code with QStringLiteral

2015-10-28 Thread Laurent Montel
. Repository: kdesignerplugin Description --- Use QStringLiteral Diffs - src/kgendesignerplugin.cpp a2c3869 Diff: https://git.reviewboard.kde.org/r/125834/diff/ Testing --- It works fine in kdepim :) Thanks, Laurent Montel ___ Kde

Re: Review Request 125833: Use QStringLiteral in generated code

2015-10-28 Thread Laurent Montel
are ok. Thanks, Laurent Montel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125834: Generate code with QStringLiteral

2015-10-28 Thread Laurent Montel
/kgendesignerplugin.cpp a2c3869 Diff: https://git.reviewboard.kde.org/r/125834/diff/ Testing --- It works fine in kdepim :) Thanks, Laurent Montel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 125833: Use QStringLiteral in generated code

2015-10-30 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125833/#review87712 --- Ping ?:) - Laurent Montel On oct. 28, 2015, 7:32 matin

Re: Review Request 125833: Use QStringLiteral in generated code

2015-10-30 Thread Laurent Montel
/kconfig_compiler/test_translation_qt.cpp.ref f5ae727 src/kconfig_compiler/kconfig_compiler.cpp 600d67a Diff: https://git.reviewboard.kde.org/r/125833/diff/ Testing --- All tests are ok. Thanks, Laurent Montel ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 125532: KTextEdit: fix loading Sonnet default settings, add context menu to switch spell-checking language

2015-10-06 Thread Laurent Montel
tps://git.reviewboard.kde.org/r/125532/#comment59557> Initialize to 0 (or Q_NULLPTR) - Laurent Montel On oct. 5, 2015, 3:40 après-midi, Daniel Vrátil wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 125532: KTextEdit: fix loading Sonnet default settings, add context menu to switch spell-checking language

2015-10-06 Thread Laurent Montel
:) - Laurent Montel On oct. 5, 2015, 3:40 après-midi, Daniel Vrátil wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125514: Add a web shortcut manager

2015-10-06 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/#review86442 --- What about rename class ? - Laurent Montel On oct. 4, 2015

Re: Review Request 125514: Add a web shortcut manager

2015-10-11 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/#review86688 --- Ping ?:) - Laurent Montel On oct. 10, 2015, 12:56 après

Re: Review Request 125514: Add a web shortcut manager

2015-10-12 Thread Laurent Montel
from long time in kdepim. I added autotests for it. Thanks, Laurent Montel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125514: Add a web shortcut manager

2015-10-12 Thread Laurent Montel
t; knewfilemenutest does). Ok I will try it. - Laurent --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/#review86691 -------

Re: Review Request 125514: Add a web shortcut manager

2015-10-05 Thread Laurent Montel
?) - Laurent --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/#review86373 --- On oct. 4, 2015, 2:04 après-midi, Laure

Re: Review Request 125514: Add a web shortcut manager

2015-10-10 Thread Laurent Montel
> On oct. 7, 2015, 5:27 matin, Laurent Montel wrote: > > What about rename class ? No news so I will rename it to KUriFilterSearchProviderActions - Laurent --- This is an automatically generated e-mail. To reply, vis

Re: Review Request 125514: Add a web shortcut manager

2015-10-10 Thread Laurent Montel
time in kdepim. I added autotests for it. Thanks, Laurent Montel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124226: Delete old highlighter

2015-07-11 Thread Laurent Montel
- Laurent Montel On juil. 11, 2015, 8:18 matin, Lasse Liehu wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124226

Re: Review Request 125419: Fix hunspell plugin ID for proper loading

2015-09-27 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125419/#review86007 --- Ship it! Seems logical. Ship it - Laurent Montel On sep

Re: Review Request 125484: Allow to clear completion history

2015-10-03 Thread Laurent Montel
arHistory->setEnabled(false); } } } - Laurent --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125484/#review86250 ----------

Re: Review Request 125484: Allow to clear completion history

2015-10-03 Thread Laurent Montel
from KHistoryComboBox > > then? (compare the slots to be sure it's the same logic). > > Laurent Montel wrote: > it's not totally the same logic > > it will clear the combobox + textline too. > > I will add a test application for khistorycombobox soo

Re: Review Request 125484: Allow to clear completion history

2015-10-03 Thread Laurent Montel
from KHistoryComboBox > > then? (compare the slots to be sure it's the same logic). > > Laurent Montel wrote: > it's not totally the same logic > > it will clear the combobox + textline too. > > I will add a test application for khistorycombobox soo

Review Request 125514: Add a web shortcut manager

2015-10-03 Thread Laurent Montel
autotests/CMakeLists.txt 989acd4 autotests/webshortcutmenumanagertest.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/125514/diff/ Testing --- Tested from long time in kdepim. I added autotests for it. Thanks, Laurent Montel ___ Kde

Re: Review Request 125514: Add a web shortcut manager

2015-10-04 Thread Laurent Montel
f > > headers, those that end up under KIO/ indeed I will fix it. - Laurent --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/#review86327 -

Re: Review Request 125514: Add a web shortcut manager

2015-10-04 Thread Laurent Montel
/widgets/CMakeLists.txt 820cd34 src/widgets/webshortcutsmenumanager.h PRE-CREATION src/widgets/webshortcutsmenumanager.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/125514/diff/ Testing --- Tested from long time in kdepim. I added autotests for it. Thanks, Laurent Montel

Review Request 125484: Allow to clear completion history

2015-10-02 Thread Laurent Montel
/125484/diff/ Testing --- Tested in kdepim from long time ago. Tested in klineedittest apps. Thanks, Laurent Montel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [Kde-pim] KDE PIM Split?

2015-11-30 Thread laurent Montel
t a pile of tickets in my inbox. > > Thanks, > Ben > ___ > KDE PIM mailing list kde-...@kde.org > https://mail.kde.org/mailman/listinfo/kde-pim > KDE PIM home page at http://pim.kde.org/ -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Soft

Re: KDE PIM Split?

2015-12-01 Thread laurent Montel
Le mardi 1 décembre 2015, 21:10:57 CET Ben Cooksley a écrit : > On Tue, Dec 1, 2015 at 6:50 PM, laurent Montel <mon...@kde.org> wrote: > > Le lundi 30 novembre 2015, 22:43:36 CET Ben Cooksley a écrit : > >> Hi Pim devels, > > > > Hi, > > So I reorganized

Re: KDE PIM Split?

2015-12-01 Thread laurent Montel
Le mardi 1 décembre 2015, 05:51:45 CET Nicolás Alvarez a écrit : > > El 1 dic 2015, a las 05:10, Ben Cooksley <bcooks...@kde.org> escribió: > >> On Tue, Dec 1, 2015 at 6:50 PM, laurent Montel <mon...@kde.org> wrote: > >> > >> Le lundi 30 novembre 2015,

Re: KDE PIM Split?

2015-11-30 Thread laurent Montel
de-frameworks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, http://www.kd

Re: API review: FavIconManager vs FavIconHostRequestJob

2016-01-28 Thread laurent Montel
n for the combobox icon, for the history tree (and later > on for adding as bookmark, but by then it's cached, hopefully). > In Akregator I see both BrowserFrame and Feed registering for the favicon. > > Migration strategy: the kded module will stay around until KF6, so we can > ta

Re: API review: FavIconManager vs FavIconHostRequestJob

2016-01-31 Thread laurent Montel
Le dimanche 31 janvier 2016, 10:40:12 CET David Faure a écrit : > On Thursday 28 January 2016 09:35:53 laurent Montel wrote: > > +ecm_qt_declare_logging_category(kiogui_SRCS HEADER favicons_debug.h > > IDENTIFIER FAVICONS_LOG CATEGORY_NAME kde.kio.favicons) > > In this direc

Re: Review Request 126963: New class FavIconRequestJob in new lib KIOGui, for favicons retrieval.

2016-02-02 Thread Laurent Montel
iteral(...) src/core/faviconscache.cpp (line 66) <https://git.reviewboard.kde.org/r/126963/#comment62729> QLatin1Char('/') etc. src/gui/faviconrequestjob.h (line 78) <https://git.reviewboard.kde.org/r/126963/#comment62730> Q_NULLPTR - Laurent Montel On fév. 2, 2016,

Re: Review Request 127931: Kdelibs4ConfigMigrator: skip reparsing if nothing was migrated.

2016-05-15 Thread Laurent Montel
() to qCDebug ? After fixing it ship it :) Regards. - Laurent Montel On May 15, 2016, 4:55 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 128428: KRecursiveFilterProxyModel: fix QSFPM corruption due to filtering out rowsRemoved signal

2016-07-22 Thread Laurent Montel
:) - Laurent Montel On July 12, 2016, 7:57 a.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Jenkins-kde-ci: syntax-highlighting master stable-kf5-qt5 » Linux, gcc - Build # 83 - Unstable!

2017-03-01 Thread laurent Montel
(98%)CONDITIONAL 337/520 (65%)> > > src.indexer > > > > FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 53/71 > > (75%)CONDITIONAL 73/92 (79%) > > > > src.lib > > &g

Re: Autocorrection in framework

2016-09-01 Thread laurent Montel
Le jeudi 1 septembre 2016, 00:58:28 CEST Albert Astals Cd a écrit : > El dimecres, 31 d’agost de 2016, a les 22:33:29 CEST, Burkhard Lück va > > escriure: > > Am Mittwoch, 31. August 2016, 08:48:58 CEST schrieb Kai Uwe Broulik: > > > Hi, > > > > > > Sonnet maybe? > > > > Quoting Albert Astals

  1   2   3   4   5   6   7   8   9   >