Re: Getting ecm files from the ECM package

2013-11-02 Thread Luca Beltrame
Rex Dieter wrote: I can vouche for fedora/redhat that the buildsystem does not have internet access. Likewise, the OBS for openSUSE does not have net access during building. -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79

Re: Review Request 117799: Clean up private slots in KCompletion

2014-05-02 Thread Luca Beltrame
Commit Hook wrote: 210ed36c1ae1e3ce33fbd752e460651e31d1a37d by David Gil to branch clean_up_private_slots. Was this the right branch, or a mistake? -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79 ___ Kde-frameworks

KAuth and KF5

2014-06-25 Thread Luca Beltrame
different entirely? Basically this makes KAuth non-functional. I'm hoping this is only a local issue, though, ;) -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: KAuth and KF5

2014-06-26 Thread Luca Beltrame
/libc.so.6 #12 0x7fde8337dfe5 in exit () from /lib64/libc.so.6 #13 0x7fde83367b0c in __libc_start_main () from /lib64/libc.so.6 #14 0x00402021 in _start () at ../sysdeps/x86_64/start.S:122 -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79

Re: KAuth and KF5

2014-06-26 Thread Luca Beltrame
is somewhere else. -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

kf5-config, startkde and bug 333793

2014-07-06 Thread Luca Beltrame
. -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kf5-config, startkde and bug 333793

2014-07-06 Thread Luca Beltrame
is deprecated, qtpaths replaces it. My plan was exactly to remove usage in startkde, that will also help solve the bug. -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread Luca Beltrame
://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread Luca Beltrame
=14046415122r=1w=2 Diffs - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread Luca Beltrame
--- On Lug. 6, 2014, 12:52 p.m., Luca Beltrame wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread Luca Beltrame
] it may change depending on the outcome. [1] http://lists.kde.org/?t=14046415122r=1w=2 Diffs (updated) - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread Luca Beltrame
, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 119146: Autostart KCM: update env and shutdown paths to GenericConfigLocation + plasma-workspace + [env|shutdown]

2014-07-06 Thread Luca Beltrame
, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread Luca Beltrame
://git.reviewboard.kde.org/r/119145/#review61701 --- On Lug. 6, 2014, 1:19 p.m., Luca Beltrame wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145

Re: Review Request 119146: Autostart KCM: update env and shutdown paths to GenericConfigLocation + plasma-workspace + [env|shutdown]

2014-07-06 Thread Luca Beltrame
/autostart/autostart.cpp 2559726 Diff: https://git.reviewboard.kde.org/r/119146/diff/ Testing --- Compiles. Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread Luca Beltrame
=14046415122r=1w=2 Diffs (updated) - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread Luca Beltrame
mean we should be using it once we can depend on Qt 5.4 :) For now ConfigLocation will do. Luca Beltrame wrote: I'll add a TODO so that it is not forgotten. David Faure wrote: For reference: https://codereview.qt-project.org/89209 for adding GenericConfigLocation to qtpaths

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread Luca Beltrame
://lists.kde.org/?t=14046415122r=1w=2 Diffs (updated) - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread Luca Beltrame
change depending on the outcome. [1] http://lists.kde.org/?t=14046415122r=1w=2 Diffs (updated) - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread Luca Beltrame
] http://lists.kde.org/?t=14046415122r=1w=2 Diffs - startkde/startkde.cmake 24610f4 Diff: https://git.reviewboard.kde.org/r/119145/diff/ Testing --- Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 119146: Autostart KCM: update env and shutdown paths to GenericConfigLocation + plasma-workspace + [env|shutdown]

2014-07-06 Thread Luca Beltrame
Diff: https://git.reviewboard.kde.org/r/119146/diff/ Testing --- Compiles. Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

What to do with autostart scripts? (kinit / ksmserver problem)

2014-07-09 Thread Luca Beltrame
scenarios: - Re-enable autostart for everything but desktop files in ksmserver; - Add support for scripts in kinit (does it even make sense?); - Drop autostart scripts, tell users to make .desktop files What do the gurus say on this? -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key

Call for help: possible race conditions in KAuth

2014-07-16 Thread Luca Beltrame
an explanation why this is not an issue. I think this is quite important as KAuth is a security-related framework. [1] https://bugzilla.novell.com/show_bug.cgi?id=864716#c41 -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79 signature.asc Description: This is a digitally signed

Re: Review Request 119323: fix auth race condition

2014-07-16 Thread Luca Beltrame
it runtime, will do so later hopefully. - Luca Beltrame On Lug. 16, 2014, 4:05 p.m., Martin Tobias Holmedahl Sandsmark wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323

Re: Review Request 119323: fix auth race condition

2014-07-16 Thread Luca Beltrame
is there too. I and Hrvoje are currently testing also a version for 4.x. - Luca Beltrame On Lug. 16, 2014, 4:05 p.m., Martin Tobias Holmedahl Sandsmark wrote: --- This is an automatically generated e-mail. To reply, visit: https

KXMLGUI and KParts

2014-07-17 Thread Luca Beltrame
that this is *highly* suboptimal: - Is Yakuake doing something wrong? - Is this a bug? - Or instead the code loading the KPart needs to be adjusted? -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79 ___ Kde-frameworks-devel

Re: KXMLGUI and KParts

2014-07-17 Thread Luca Beltrame
Luca Beltrame wrote: - Or instead the code loading the KPart needs to be adjusted? Just FYI: the issue was in Konsole, which did not set a component name. This was fixed in g88ffcc8 in Konsole (frameworks branch). -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79

Re: Review Request 119323: fix auth race condition

2014-07-18 Thread Luca Beltrame
without issues. Unit tests (no matter how little they are) also pass, so this should go in. IMO this should also be pushed for kdelibs, which is affected in the same manner. - Luca Beltrame On Lug. 17, 2014, 11:23 a.m., Martin Tobias Holmedahl Sandsmark wrote

Re: Review Request 119542: create qapplication before using dbus

2014-07-29 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119542/#review63482 --- +1, from what I've seen it looks fairly harmless. - Luca

Re: Review Request 119540: don't construct bogus KAuthAction objects

2014-07-30 Thread Luca Beltrame
string () useful to anyone? IMO the issue, if any, it's there, and this looks like a workaround. (But I claim no expertise on the code, so feel free to flame me :P) - Luca Beltrame On Lug. 30, 2014, 12:32 a.m., Harald Sitter wrote

Re: What to do with autostart scripts? (kinit / ksmserver problem)

2014-09-02 Thread Luca Beltrame
In data martedì 19 agosto 2014 21:48:04, David Faure ha scritto: I'd pick option 1 - do it all in ksmserver. I suppose this would mean running all but .desktop files (which are handled by kinit)? -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79 signature.asc

Re: Split kde-baseapps?

2014-09-24 Thread Luca Beltrame
Michael Palimaka wrote: Are there any plans to split frameworks-based kde-baseapps? IMO it would make sense first to consult with the various applications' maintainers and / or review what's in there and what should happen to it. -- Luca Beltrame - KDE Forums team KDE Science supporter GPG

Re: Split kde-baseapps?

2014-09-24 Thread Luca Beltrame
them used by konqueror only, but I have no experience in the area. libkonq also lives in kde-baseapps, and that lib is used by dolphin at minimum (IIRC). -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79 ___ Kde

Re: Review Request 121078: Fix exports.

2014-11-19 Thread Luca Beltrame
: fatal error: libdolphin_export.h: No such file or directory - Luca Beltrame On Nov. 20, 2014, 3:29 a.m., Andrius da Costa Ribas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Review Request 121078: Fix exports.

2014-11-20 Thread Luca Beltrame
/121078/#comment49452 This one was missing from the commit and broke the build. I fixed it in 9cd55421bdadc663c947ddac9504a8d916e87012. - Luca Beltrame On Nov. 20, 2014, 3:29 a.m., Andrius da Costa Ribas wrote

Re: Review Request 121078: Fix exports.

2014-11-20 Thread Luca Beltrame
not build tests: /srv/jenkins/workspace/kde-baseapps_frameworks_qt5/konqueror/src/konqapplication.h:28:46: error: expected initializer before ‘:’ token The line being class KONQ_TESTS_EXPORT KonquerorApplication : public KApplication - Luca Beltrame On Nov. 20, 2014, 3:29 a.m., Andrius da

Re: Review Request 121078: Fix exports.

2014-11-20 Thread Luca Beltrame
On Nov. 20, 2014, 9 a.m., Luca Beltrame wrote: Actually it's still broken: I didn't notice because I did not build tests: /srv/jenkins/workspace/kde-baseapps_frameworks_qt5/konqueror/src/konqapplication.h:28:46: error: expected initializer before ‘:’ token The line being

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-04 Thread Luca Beltrame
/kquickcontrolsaddons/qpixmapitem.cpp 6c9e3a2 Diff: https://git.reviewboard.kde.org/r/122413/diff/ Testing --- Builds. Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 122432: Add paintedRect and paintedWidth to QImageItem

2015-02-04 Thread Luca Beltrame
/qmlcontrols/kquickcontrolsaddons/qimageitem.h 3d0bc2c src/qmlcontrols/kquickcontrolsaddons/qimageitem.cpp deeb941 Diff: https://git.reviewboard.kde.org/r/122432/diff/ Testing --- Builds. Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing

Review Request 122432: Add paintedRect and paintedWidth to QImageItem

2015-02-04 Thread Luca Beltrame
/kquickcontrolsaddons/qimageitem.cpp deeb941 Diff: https://git.reviewboard.kde.org/r/122432/diff/ Testing --- Builds. Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-03 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413/#review75334 --- On Feb. 3, 2015, 8:33 p.m., Luca Beltrame wrote

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-03 Thread Luca Beltrame
/qpixmapitem.h 485d6f7 src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp 6c9e3a2 Diff: https://git.reviewboard.kde.org/r/122413/diff/ Testing --- Builds. Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-03 Thread Luca Beltrame
/diff/ Testing --- Builds. Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-03 Thread Luca Beltrame
/ Testing --- Builds. Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-03 Thread Luca Beltrame
/qmlcontrols/kquickcontrolsaddons/qpixmapitem.h 485d6f7 Diff: https://git.reviewboard.kde.org/r/122413/diff/ Testing --- Builds. Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-03 Thread Luca Beltrame
/122413/#review75332 --- On Feb. 3, 2015, 8:32 p.m., Luca Beltrame wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122413

Re: Review Request 122413: Add paintedWidth and paintedHeight to QPixmapItem

2015-02-03 Thread Luca Beltrame
://git.reviewboard.kde.org/r/122413/diff/ Testing --- Builds. Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121850: Port KRunner to categorized logging

2015-01-05 Thread Luca Beltrame
/declarative/runnermodelplugin.cpp 33539a9 src/abstractrunner.cpp 9693ed8 src/CMakeLists.txt 71d7409 Diff: https://git.reviewboard.kde.org/r/121850/diff/ Testing --- Compiles. Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 121850: Port KRunner to categorized logging

2015-01-05 Thread Luca Beltrame
33539a9 src/querymatch.cpp d22f4f0 src/runnercontext.cpp c7070ac src/runnerjobs.cpp b090821 src/runnermanager.cpp 0cf8120 Diff: https://git.reviewboard.kde.org/r/121850/diff/ Testing --- Compiles. Thanks, Luca Beltrame ___ Kde

Re: Review Request 121850: Port KRunner to categorized logging

2015-01-05 Thread Luca Beltrame
src/declarative/runnermodelplugin.cpp 33539a9 src/querymatch.cpp d22f4f0 src/runnercontext.cpp c7070ac src/runnerjobs.cpp b090821 src/runnermanager.cpp 0cf8120 Diff: https://git.reviewboard.kde.org/r/121850/diff/ Testing --- Compiles. Thanks, Luca Beltrame

Re: Review Request 121850: Port KRunner to categorized logging

2015-01-05 Thread Luca Beltrame
src/runnerjobs.cpp b090821 src/runnermanager.cpp 0cf8120 Diff: https://git.reviewboard.kde.org/r/121850/diff/ Testing --- Compiles. Thanks, Luca Beltrame ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 122774: Fix logic error in qpixmap/image item

2015-03-02 Thread Luca Beltrame
for spotting! - Luca Beltrame On Mar. 2, 2015, 2:43 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122774

Re: Review Request 122775: Make QImageItem handle non default devicePixelRatios

2015-03-02 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122775/#review76905 --- Ship it! Inviala! - Luca Beltrame On Mar. 2, 2015, 2:50

Re: Review Request 122776: Add test for qimageitem

2015-03-02 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122776/#review76904 --- +1 from me, given I touched this code recently. - Luca

Re: Proposal: move KWalletManager inside KWallet framework

2015-05-26 Thread Luca Beltrame
of kdeutils, IIRC, but feel free to correct me) has never been released. -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: 6E1A4E79 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: breeze icons default and its inheritance

2015-10-21 Thread Luca Beltrame
ata -> kaboom. -- Luca Beltrame - KDE Forums team KDE Science supporter GPG key ID: A29D259B ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125875: Fix build for Qt < 5.5

2015-10-30 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125875/#review87725 --- +1 - Luca Beltrame On Ott. 29, 2015, 7:55 p.m., David

Re: Review Request 125884: Set default value for WheelScrollLines

2015-10-30 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125884/#review87766 --- +1. - Luca Beltrame On Ott. 30, 2015, 10 p.m., David Rosca

Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

2015-10-30 Thread Luca Beltrame
> On Ott. 30, 2015, 8:34 p.m., Luca Beltrame wrote: > > It looks like this broke mouse wheel scrolling for me (on Qt 5.5.1): how > > can I debug to ensure this is the case and not a local issue? > > David Rosca wrote: > Broke in what way? Did you try if it w

Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

2015-10-30 Thread Luca Beltrame
> On Ott. 30, 2015, 8:34 p.m., Luca Beltrame wrote: > > It looks like this broke mouse wheel scrolling for me (on Qt 5.5.1): how > > can I debug to ensure this is the case and not a local issue? > > David Rosca wrote: > Broke in what way? Did you try if it w

Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

2015-10-30 Thread Luca Beltrame
5.5.1): how can I debug to ensure this is the case and not a local issue? - Luca Beltrame On Ott. 29, 2015, 8:01 p.m., David Rosca wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 125863: Fix WheelScrollLines settings with Qt >= 5.5

2015-10-30 Thread Luca Beltrame
> On Ott. 30, 2015, 8:34 p.m., Luca Beltrame wrote: > > It looks like this broke mouse wheel scrolling for me (on Qt 5.5.1): how > > can I debug to ensure this is the case and not a local issue? > > David Rosca wrote: > Broke in what way? Did you try if it works

Re: Review Request 125537: Use largest timestamp in subdirectory as resource directory timestamp.

2015-10-06 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125537/#review86407 --- +1. I hit this issue today and this patch fixes it. - Luca

Re: Review Request 126078: [OS X] modernising the KIdleTime plugin (WIP!)

2015-11-18 Thread Luca Beltrame
Il Wed, 18 Nov 2015 17:28:27 +0100, René J.V. Bertin ha scritto: > If we're starting to call names arguing indeed becomes pointless as the > apparent lack of actual reading my arguments already suggested. It In the interest of the CoC and before people heat up, Martin said: "Thus the code is

Re: Review Request 125044: Fix crash when hovering the 'Activities' context menu entry and constantly moving the mouse cursor around

2015-09-04 Thread Luca Beltrame
> On Set. 4, 2015, 1:14 p.m., Luca Beltrame wrote: > > Can you check whether it also fixes bug 351585? To me the issue seems > > related. > > Luca Beltrame wrote: > I applied the patch locally, fixes also the aforementioned bug. It just occurred to me that kac

Re: Review Request 125044: Fix crash when hovering the 'Activities' context menu entry and constantly moving the mouse cursor around

2015-09-04 Thread Luca Beltrame
> On Set. 4, 2015, 1:14 p.m., Luca Beltrame wrote: > > Can you check whether it also fixes bug 351585? To me the issue seems > > related. I applied the patch locally, fixes also the aforementione

Re: Review Request 125044: Fix crash when hovering the 'Activities' context menu entry and constantly moving the mouse cursor around

2015-09-04 Thread Luca Beltrame
the issue seems related. - Luca Beltrame On Set. 4, 2015, 1:01 p.m., Emmanuel Pescosta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 125154: Workaround 350758 with same hack in 494584ee43c20948044eb80012b69f65920b33f4

2015-09-11 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125154/#review85165 --- +1 - Luca Beltrame On Set. 11, 2015, 8:28 a.m., Xuetian

Re: Review Request 126313: Use an xcb for interaction with KStartupInfo

2016-01-25 Thread Luca Beltrame
0x008e559d in () #8 0x in () ``` I had to revert it or kdeinit would crash and prevent me from having a functional session. ;) - Luca Beltrame On Gen. 25, 2016, 3:34 p.m., Martin Gräßlin wrote: > > --- &g

Re: ECM metainfo path

2016-04-21 Thread Luca Beltrame
Il giorno Thu, 21 Apr 2016 12:26:54 +0200 Harald Sitter ha scritto: > doesn't that break compatibility with older appstreams for everything > that uses ECM? if so, I am not sure that is appropriate TBH I noticed that as well (at the same time when we were standardizing the

[Differential] [Updated] D4509: Python bindings: Some comment-only tidyups and PEP-8 fixes.

2017-02-08 Thread Luca Beltrame
lbeltrame added reviewers: Build System, skelly, Frameworks. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D4509 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: shaheed, #build_system, skelly, #frameworks Cc:

[Differential] [Updated] D4510: Python bindings: Restore handling of deprecated constructs.

2017-02-08 Thread Luca Beltrame
lbeltrame added reviewers: skelly, Build System, Frameworks. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D4510 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: shaheed, skelly, #build_system, #frameworks Cc:

Re: Sonnet: Trigram data file for Greek

2017-01-24 Thread Luca Beltrame
Il giorno Tue, 24 Jan 2017 00:01:29 -0800 John Salatas ha scritto: Hello, > I just built a trigram data file (attached) for Greek language using > a wikipedia dump as corpus. Can I just push it to sonnet's git or do > I need to generate a differential review in phabricator

Re: Scrap baloo?

2016-09-15 Thread Luca Beltrame
, I don't oppose this if it means better maintenance. Only, please ensure things won't break, I don't want to deal with the angry mobs in the forum. ;) > => Opinions? It would be nice to hear what Vishesh, Pinak and Boudhayan think about this. -- Luca Beltrame, Ph.D. Translational Genomics

Re: Scrap baloo?

2016-09-28 Thread Luca Beltrame
Il giorno Thu, 22 Sep 2016 21:54:26 +0200 (CEST) Christoph Cullmann ha scritto: > anyone had some time to take a look at Baloo and Co.? Last thing on the topic I saw was this comment to this review: https://git.reviewboard.kde.org/r/128664/ pgp3TaryU1XpJ.pgp Description:

Re: KDE Frameworks & Plasma 5.8 LTS

2016-10-23 Thread Luca Beltrame
ing (barring issues). openSUSE Leap 42.2 will *not* get any major version update, so it will stick with Plasma 5.8 and KF 5.26. -- Luca Beltrame - KDE Forums team GPG key ID: A29D259B pgp79DaGH19rA.pgp Description: Firma digitale OpenPGP

ATTN: latest changes in breeze-icons make packaging untenable

2016-10-25 Thread Luca Beltrame
Hello, recent changes in breeze broke building in openSUSE's OBS: after a discussion on IRC, it turned out that there were incorrect symlinks. Adjustments were made in order to preserve space. However, while harmless at first (I didn't notice earlier, and CI was green) these changes *break*

Re: ATTN: latest changes in breeze-icons make packaging untenable

2016-10-25 Thread Luca Beltrame
Il giorno Tue, 25 Oct 2016 16:47:40 +0200 Luca Beltrame <lbeltr...@kde.org> ha scritto: > If there's no consensus, I will revert these commits [1][2][3][4] in > breeze-icons by Sunday morning. After discussion on IRC, the commits were reverted. pgpkAXusssxMw.pgp Description: Fi

D5289: Import Find{Clang,LLVM} from KDevelop for Python bindings generation

2017-04-03 Thread Luca Beltrame
lbeltrame added a comment. +1, we have the same problem in openSUSE. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5289 To: heikobecker, #frameworks, #build_system, skelly, kfunk Cc: lbeltrame

D4847: KAuth integration in document saving

2017-04-10 Thread Luca Beltrame
lbeltrame added a comment. In https://phabricator.kde.org/D4847#101088, @ivan wrote: > @lbeltrame > > I don't really see 'reasoning' in that report more than something that sounds like 'polkit is a hack to replace suid for setting the system time and time zone'. That said,

D4847: KAuth integration in document saving

2017-04-10 Thread Luca Beltrame
lbeltrame added a comment. Notice from downstream integration: this feature is considered an "abuse" of the Polkit system and at least openSUSE will explicitly disable it. See https://bugzilla.suse.com/show_bug.cgi?id=1033055 for the reasoning. REPOSITORY R39 KTextEditor REVISION DETAIL

Problems with Python bindings in KF5

2017-04-15 Thread Luca Beltrame
ory/x86_64/ki18n/ _log [2] https://marc.info/?t=14910810231=1=2 -- Luca Beltrame - KDE Forums team GPG key ID: A29D259B signature.asc Description: This is a digitally signed message part.

Re: Problems with Python bindings in KF5

2017-04-15 Thread Luca Beltrame
In data sabato 15 aprile 2017 16:10:24 CEST, Luca Beltrame ha scritto: > https://build.opensuse.org/build/ > home:luca_b:branches:KDE:Unstable:Frameworks/openSUSE_Factory/x86_64/ki18n/ > _log As these build logs are only available to users logged in the OBS, the error is pasted her

Re: Problems with Python bindings in KF5

2017-04-15 Thread Luca Beltrame
ki18n (when it does not build) or I'd have attempted to fix it myself... -- Luca Beltrame - KDE Forums team GPG key ID: A29D259B signature.asc Description: This is a digitally signed message part.

[Differential] [Commented On] D4847: KAuth integration in document saving

2017-03-01 Thread Luca Beltrame
lbeltrame added a comment. > - Does that affect other platforms such as Windows in any way? I.e., does KAuth exist on Windows? KAuth had backends for OSX and Windows. Whether they are working or just stubs however, I don't know. REPOSITORY R39 KTextEditor REVISION DETAIL

D5646: Solve problem with microphone-sensitivity-medium

2017-04-29 Thread Luca Beltrame
lbeltrame added a reviewer: andreaska. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D5646 To: patrickelectric, #kate, andreaska Cc: #frameworks

D5631: Fix directory based search.

2017-04-29 Thread Luca Beltrame
lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. Looks fairly harmless to me. Perhaps wait one or two days more to see if anyone chimes in. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL

D5631: Fix directory based search.

2017-04-28 Thread Luca Beltrame
lbeltrame added a comment. +1, I assume there are no tests for this functionality already present? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D5631 To: xuetianweng, #frameworks Cc: lbeltrame

D5806: When building menu hyerarchies, parent menus to their containers

2017-05-17 Thread Luca Beltrame
lbeltrame added a comment. Unfortunately this change causes crashes in KPart-using applications that do stuff with their QActions with Qt 5.9. okular and kontact are affected, at least. This is a typical backtrace (got this from Eike, but I have the same): #0 QAction::setEnabled

D5900: use transientparent directly

2017-05-17 Thread Luca Beltrame
lbeltrame added a comment. I'll test this and see how it goes. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D5900 To: mart Cc: lbeltrame, #frameworks

D5900: use transientparent directly

2017-05-17 Thread Luca Beltrame
lbeltrame added a reviewer: lbeltrame. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D5900 To: mart, lbeltrame Cc: lbeltrame, #frameworks

D5900: use transientparent directly

2017-05-17 Thread Luca Beltrame
lbeltrame accepted this revision. lbeltrame added a comment. This revision is now accepted and ready to land. Tested, works (neither kontact nor okular crash with this change). REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D5900 To: mart, lbeltrame

D5981: Fix compilation of Python bindings

2017-05-27 Thread Luca Beltrame
lbeltrame added a reviewer: lbeltrame. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D5981 To: aacid, lbeltrame Cc: lbeltrame, #frameworks

D5981: Fix compilation of Python bindings

2017-05-27 Thread Luca Beltrame
lbeltrame added a comment. I'll try to test and report back. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D5981 To: aacid Cc: lbeltrame, #frameworks

D5981: Fix compilation of Python bindings

2017-05-27 Thread Luca Beltrame
lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D5981 To: aacid, lbeltrame Cc: lbeltrame, #frameworks

Re: Problems with Python bindings in KF5

2017-05-05 Thread Luca Beltrame
the code to find the problem? From a quick discussion on #opensuse-kde, it may have to do with QT_NO_CAST_FROM_ASCII and QT_NO_CAST_TO_ASCII (which means that we have strings somewhere). I'll try to test later. -- Luca Beltrame - KDE Forums team GPG key ID: A29D259B signature.asc De

Re: Problems with Python bindings in KF5

2017-05-05 Thread Luca Beltrame
In data sabato 6 maggio 2017 00:01:09 CEST, Luca Beltrame ha scritto: > I'll try rebuilding a few more times (the result is unreliable) and I'll > report back. False alarm: it wasn't the problem at all. I can't see what could be wrong from the generated files. -- Luca Beltrame - KDE

Re: Problems with Python bindings in KF5

2017-05-05 Thread Luca Beltrame
In data venerdì 5 maggio 2017 22:47:45 CEST, Luca Beltrame ha scritto: > From a quick discussion on #opensuse-kde, it may have to do with > QT_NO_CAST_FROM_ASCII and QT_NO_CAST_TO_ASCII (which means that we have My initial test suggests that indeed we have a problem somehow with s

[kdeclarative] src/calendarevents: Relicense to LGPL2.1+ (part 2)

2017-09-18 Thread Luca Beltrame
Git commit 62b8e461f2e5979180e1753651cc34dc5f3eb3b7 by Luca Beltrame. Committed on 18/09/2017 at 13:39. Pushed by lbeltrame into branch 'master'. Relicense to LGPL2.1+ (part 2) Permission granted by the author (Martin Klapetek) CCMAIL: martin.klape...@gmail.com CCMAIL: kde-frameworks-devel

Re: Request for relicense: kdeclarative/src/calendarevents/*

2017-09-18 Thread Luca Beltrame
In data lunedì 18 settembre 2017 15:32:16 CEST, Martin Klapetek ha scritto: > Absolutely, I hereby give you the permission to relicense those files to > LGPL2.1+. > CC'ing frameworks devel to retain a public record of that. Thanks a lot! -- Luca Beltrame - KDE Forums team KDE Science

  1   2   3   >