D10702: Always use a job to delete files to avoid freezing process waiting on IO

2018-05-11 Thread Méven Car
meven added a comment. Restricted Application added a subscriber: kde-frameworks-devel. In D10702#242143 , @dfaure wrote: > s/thread/process/. It's not about threads it's about two processes: the (GUI) application, and the kioslave. > > But

D10702: Always use a job to delete files to avoid freezing process waiting on IO

2018-06-03 Thread Méven Car
meven added a comment. Great suggestion Mark ! I am a C++ beginner, I did not consider this neat C++ 14 feature. This will necessitate a c++ compiler dependency change though. Like Kwin did last July https://github.com/KDE/kwin/commit/ea5d611de1bc33869c13c27d75a7827201a5139d

D10702: Always use a job to delete files to avoid freezing process waiting on IO

2018-06-03 Thread Méven Car
meven added a comment. Here is the script I have been using : https://gist.github.com/meven/f0b2a36c61240e1d6e19753afd1d3d68 My benchmark logic is : Create a folder with x files of k sizes. Copy this folder. Delete this folder using kfmclient, measuring the elapsed time I have

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

2018-02-18 Thread Méven Car
meven created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. meven requested review of this revision. REVISION SUMMARY Add a DeleteJob for the last file that was being copied/moved when pasting or dropping a file when

D10702: bug 390748 Always use a job to delete files to avoid freezing process waiting on IO

2018-02-20 Thread Méven Car
meven created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. meven requested review of this revision. REPOSITORY R241 KIO BRANCH bug-390748-make-kio-delete-asynchronous REVISION DETAIL

D10702: BUG: 390748 Always use a job to delete files to avoid freezing process waiting on IO

2018-02-20 Thread Méven Car
meven added a reviewer: Dolphin. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10702 To: meven, #frameworks, dfaure, ngraham, #dolphin Cc: ngraham, #frameworks, michaelh

D10702: bug 390748 Always use a job to delete files to avoid freezing process waiting on IO

2018-02-20 Thread Méven Car
meven edited the summary of this revision. meven edited the test plan for this revision. meven added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10702 To: meven, #frameworks, #dolphin, dfaure Cc: ngraham, #frameworks, michaelh

D10702: BUG: 390748 Always use a job to delete files to avoid freezing process waiting on IO

2018-02-20 Thread Méven Car
meven retitled this revision from "bug 390748 Always use a job to delete files to avoid freezing process waiting on IO" to "BUG: 390748 Always use a job to delete files to avoid freezing process waiting on IO". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10702 To:

D10702: bug 390748 Always use a job to delete files to avoid freezing process waiting on IO

2018-02-20 Thread Méven Car
meven edited the summary of this revision. meven edited reviewers, added: ngraham; removed: Dolphin. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10702 To: meven, #frameworks, dfaure, ngraham, #dolphin Cc: ngraham, #frameworks, michaelh

D10702: Always use a job to delete files to avoid freezing process waiting on IO

2018-02-24 Thread Méven Car
meven added a comment. In D10702#211236 , @markg wrote: > While this might give you the expected result, it feels like a workaround. > > I'm assuming the fast path is there for a reason and is really substantially faster then going through

D10702: Always use a job to delete files to avoid freezing process waiting on IO

2018-02-23 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10702 To: meven, #frameworks, dfaure, ngraham, #dolphin Cc: markg, ngraham, #frameworks, michaelh

D10702: Always use a job to delete files to avoid freezing process waiting on IO

2018-02-21 Thread Méven Car
meven retitled this revision from "BUG: 390748 Always use a job to delete files to avoid freezing process waiting on IO" to "Always use a job to delete files to avoid freezing process waiting on IO". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10702 To: meven,

D10702: Always use a job to delete files to avoid freezing process waiting on IO

2018-02-21 Thread Méven Car
meven updated this revision to Diff 27716. meven added a comment. Always use a job to delete files to avoid freezing process waiting on IOX REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10702?vs=27648=27716 BRANCH bug-390748-make-kio-delete-asynchronous

D10702: Always use a job to delete files to avoid freezing process waiting on IO

2018-02-21 Thread Méven Car
meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10702 To: meven, #frameworks, dfaure, ngraham, #dolphin Cc: ngraham, #frameworks, michaelh

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

2018-02-19 Thread Méven Car
meven added a comment. Add this to your commit message FIXED-IN: 5.44 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10663 To: dmitrio, #frameworks, #dolphin Cc: meven, #frameworks, michaelh

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

2018-02-19 Thread Méven Car
meven added a comment. In D10635#209656 , @dmitrio wrote: > I have also done some work on this issue, and my solution for this includes mechanism that should avoid deletion of existing data. I have uploaded

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

2018-02-19 Thread Méven Car
meven added a comment. It was suggested on IRC to hide this behavior behind a flag such as the jobFlag enum, so that it can be opt-in/opt-out in applications. We could consider changing the job state during the clean up, something like d->state == STATE_CLEANING_INCOMPLETE_FILE

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

2018-02-19 Thread Méven Car
meven abandoned this revision. meven added a comment. Abandoned in favor of https://phabricator.kde.org/D10663 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10635 To: meven, dfaure Cc: dmitrio, ltoscano, ngraham, #frameworks, michaelh

D10702: Always use a job to delete files to avoid freezing process waiting on IO

2018-04-07 Thread Méven Car
meven added a comment. In term of comparison to the FileCopyJob for instance, the difference I can spot with the DeleteJob implementation, is that the FileCopyJobPrivate itselft instanciates a subJob in this case a DirectCopyJob that will do the work, using internally SimpleJobPrivate.

D10702: Always use a job to delete files to avoid freezing process waiting on IO

2018-04-14 Thread Méven Car
meven added a comment. In D10702#243605 , @jtamate wrote: > This freezing process happens for me in ktorrent the first time in a day I delete a file, but not the files after, even if they are iso images (>4GiB). > Are we sure the problem is

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-02 Thread Méven Car
meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-02 Thread Méven Car
meven added a comment. After this patch I intend to update KFileItemPrivate::init to add birthtime there in the same manner. Perhaps it would be good to group the stax/QL_STAT code somewhere rather than spread. And then there is baloo-widgets and perhaps some dolphin work for this to

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-31 Thread Méven Car
meven updated this revision to Diff 55146. meven added a comment. Handle properly respective types for stat and statx syscalls REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55132=55146 BRANCH creation-date REVISION DETAIL

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-31 Thread Méven Car
meven updated this revision to Diff 55147. meven added a comment. Use time_t instead of __time_t and fix higherBound REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55146=55147 BRANCH creation-date REVISION DETAIL

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

2019-03-27 Thread Méven Car
meven updated this revision to Diff 54924. meven added a comment. fix copyright REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19824?vs=54869=54924 BRANCH arcpatch-D19824 REVISION DETAIL https://phabricator.kde.org/D19824 AFFECTED FILES

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

2019-03-27 Thread Méven Car
meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > dfaure wrote in kdiroperator.h:916 > Missing @since 5.57 Thanks REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19824 To: meven, #frameworks, #dolphin, ngraham, dfaure Cc: ngraham,

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

2019-03-26 Thread Méven Car
meven updated this revision to Diff 54868. meven marked an inline comment as done. meven added a comment. Updated after review, add another test file instead of modifying it. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19824?vs=54082=54868 BRANCH

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

2019-03-26 Thread Méven Car
meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19824 To: meven, #frameworks, #dolphin, ngraham, dfaure Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

2019-03-26 Thread Méven Car
meven updated this revision to Diff 54869. meven added a comment. update commit message REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19824?vs=54868=54869 BRANCH arcpatch-D19824 REVISION DETAIL https://phabricator.kde.org/D19824 AFFECTED FILES

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

2019-03-26 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D19824 To: meven, #frameworks, #dolphin, ngraham, dfaure Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

2019-03-21 Thread Méven Car
meven added a reviewer: dfaure. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D19824 To: meven, #frameworks, #dolphin, ngraham, dfaure Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20284: Fix l/100 km to MPG conversion

2019-04-06 Thread Méven Car
meven added inline comments. INLINE COMMENTS > fuel_efficiency.cpp:48 > +return unitMultiplier() / value; > + return UnitPrivate::toDefault(value); > } Indentation seems off here REPOSITORY R292 KUnitConversion REVISION DETAIL https://phabricator.kde.org/D20284 To:

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-06 Thread Méven Car
meven added a comment. Any suggestion ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20301: Ensure to add a trailing / at the end of fstab mounted devices.

2019-04-06 Thread Méven Car
meven added a comment. The patch is currently quite naive. Should I add a check if (!device.endsWith('/') ? Is it sound enough ? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20301 To: meven, bruns, lukas Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20301: Ensure to add a trailing / at the end of fstab mounted devices.

2019-04-06 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20301 To: meven, bruns, lukas Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20301: Ensure to add a trailing / at the end of fstab mounted devices.

2019-04-06 Thread Méven Car
meven added a reviewer: lukas. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20301 To: meven, bruns, lukas Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20301: Ensure to add a trailing / at the end of fstab mounted devices.

2019-04-06 Thread Méven Car
meven created this revision. meven added a reviewer: bruns. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY The nfs mounted device are listed without a trailing / according to my testing, preventing

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-06 Thread Méven Car
meven updated this revision to Diff 55539. meven marked an inline comment as done. meven added a comment. Use stx_mask to check for btime availability REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55183=55539 BRANCH arcpatch-D20096 REVISION

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-06 Thread Méven Car
meven added inline comments. INLINE COMMENTS > fvogt wrote in file.cpp:1033 > This check seems to be wrong with me - there can be files with legitimate > zero `tv_nsec`. > > Use `buff.stx_mask & STATX_BTIME` instead. Thanks for the feedback, I read about stx_mask after writing this.

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-06 Thread Méven Car
meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-30 Thread Méven Car
meven added a comment. In particular, is there a way to test changes in ioslaves locally (within plasma/kde) ? I would love to have some direction, is there a flag for this, a trick ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks Cc:

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-30 Thread Méven Car
meven added a comment. In D20096#440440 , @bruns wrote: > In D20096#440434 , @meven wrote: > > > In particular, is there a way to test changes in ioslaves locally (within plasma/kde) ? > > I

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-30 Thread Méven Car
meven updated this revision to Diff 55067. meven added a comment. Clean up REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55066=55067 BRANCH creation-date REVISION DETAIL https://phabricator.kde.org/D20096 AFFECTED FILES

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-30 Thread Méven Car
meven updated this revision to Diff 55074. meven added a comment. Avoid duplicating code REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55068=55074 BRANCH creation-date REVISION DETAIL https://phabricator.kde.org/D20096 AFFECTED FILES

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-30 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-30 Thread Méven Car
meven added a comment. In D20096#440443 , @bruns wrote: > I think the regular stat and statx implementations should be merged. This requires a little bit of refactoring, but avoids a lot of code duplication. I thought about it, but the

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-30 Thread Méven Car
meven updated this revision to Diff 55064. meven added a comment. Fix timestamp value REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=54997=55064 BRANCH creation-date REVISION DETAIL https://phabricator.kde.org/D20096 AFFECTED FILES

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-30 Thread Méven Car
meven edited the summary of this revision. meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-30 Thread Méven Car
meven updated this revision to Diff 55068. meven marked an inline comment as done. meven added a comment. Avoid obsolete method REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55067=55068 BRANCH creation-date REVISION DETAIL

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-30 Thread Méven Car
meven retitled this revision from "[WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28" to "Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28". meven edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-30 Thread Méven Car
meven updated this revision to Diff 55077. meven marked 2 inline comments as done. meven added a comment. Fix in case of symlinks resolution, add inlines REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55074=55077 BRANCH creation-date REVISION

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-30 Thread Méven Car
meven updated this revision to Diff 55079. meven added a comment. Rename function get_stat to STAT REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55077=55079 BRANCH creation-date REVISION DETAIL https://phabricator.kde.org/D20096 AFFECTED FILES

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-30 Thread Méven Car
meven updated this revision to Diff 55066. meven added a comment. Clean up REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55064=55066 BRANCH creation-date REVISION DETAIL https://phabricator.kde.org/D20096 AFFECTED FILES CMakeLists.txt

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-30 Thread Méven Car
meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-30 Thread Méven Car
meven added inline comments. INLINE COMMENTS > bruns wrote in file.cpp:855 > This can be up to 12 now, if I counted correctly. Conditionalize this on > details. This code was just copied, but I will be happy to take care of this along the way. REPOSITORY R241 KIO REVISION DETAIL

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-30 Thread Méven Car
meven updated this revision to Diff 55082. meven added a comment. Use switch statement, +1 to the qbound comparison of the buffer size REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55079=55082 BRANCH creation-date REVISION DETAIL

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-31 Thread Méven Car
meven updated this revision to Diff 55110. meven added a comment. Add details == 2 and correct switch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55082=55110 BRANCH creation-date REVISION DETAIL https://phabricator.kde.org/D20096 AFFECTED

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-31 Thread Méven Car
meven updated this revision to Diff 55111. meven marked 2 inline comments as done. meven added a comment. Use a better lower limit for the buffer size, add some comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55110=55111 BRANCH creation-date

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-31 Thread Méven Car
meven marked an inline comment as done. meven added a comment. In D20096#440830 , @pino wrote: > Note that, even if the system supports statx() (so with glibc >= 2.28), you must support systems without it at runtime anyway: for example, if you

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-31 Thread Méven Car
meven marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-31 Thread Méven Car
meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS > bruns wrote in file.cpp:878 > You should start with a more sensible size for lowerLimit, e.g. 256, maybe > more - the scope is local, i.e. any excess size is hardly relevant, and > allocating 1 and 256 byte

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-31 Thread Méven Car
meven updated this revision to Diff 55120. meven added a comment. Remove unused includes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55111=55120 BRANCH creation-date REVISION DETAIL https://phabricator.kde.org/D20096 AFFECTED FILES

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-31 Thread Méven Car
meven added a comment. In D20096#440868 , @fvogt wrote: > In D20096#440842 , @meven wrote: > > > In D20096#440830 , @pino wrote: > > > > > Note that,

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-28 Thread Méven Car
meven created this revision. meven added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY glibc 2.28 provides a statx function that is stubbed on old linux systems or file

D20096: [WIP/help wanted] Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-28 Thread Méven Car
meven updated this revision to Diff 54997. meven added a comment. Removed empty file. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=54996=54997 BRANCH creation-date REVISION DETAIL https://phabricator.kde.org/D20096 AFFECTED FILES

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

2019-03-28 Thread Méven Car
meven added a comment. In D19824#439896 , @dfaure wrote: > Remember to update the commit log so it doesn't keep saying "First attempt, not necessarily the right one." :-) Thanks ! REPOSITORY R241 KIO REVISION DETAIL

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

2019-03-28 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D19824 REVISION DETAIL https://phabricator.kde.org/D19824 To: meven, #frameworks, #dolphin, ngraham, dfaure Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

2019-03-28 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R241:bea5b68142e4: KFileWidget In saving single file mode an enter/return press on the… (authored by meven). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-01 Thread Méven Car
meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > bruns wrote in file.cpp:932 > statx.stx_size is __u64, and readlink uses (unsigned) size_t for the buffer > size. Let me know if I have handled this correctly. REPOSITORY R241 KIO REVISION DETAIL

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-01 Thread Méven Car
meven updated this revision to Diff 55182. meven added a comment. Add AT_SYMLINK_NOFOLLOW flag to statx call matching lstat behavior, use size_t type for readlink parameter, avoid a warning correct signedness of statx struct accessors REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-01 Thread Méven Car
meven updated this revision to Diff 55183. meven marked an inline comment as done. meven added a comment. Fix position of default in switch statement REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55182=55183 BRANCH creation-date REVISION DETAIL

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-31 Thread Méven Car
meven added a comment. In D20096#440921 , @fvogt wrote: > In D20096#440919 , @meven wrote: > > > > There are platforms out there which don't use glibc. So I suggest either handling ENOSYS properly

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-31 Thread Méven Car
meven updated this revision to Diff 55124. meven added a comment. Conditionnaly define USE_STATX REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55123=55124 BRANCH creation-date REVISION DETAIL https://phabricator.kde.org/D20096 AFFECTED FILES

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-31 Thread Méven Car
meven marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-31 Thread Méven Car
meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > fvogt wrote in file.cpp:71 > This won't work as expected, `USE_STATX` is unconditionally defined. Thanks REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks,

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-31 Thread Méven Car
meven updated this revision to Diff 55132. meven added a comment. Avoid including twice errno.h REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55124=55132 BRANCH creation-date REVISION DETAIL https://phabricator.kde.org/D20096 AFFECTED FILES

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-03-31 Thread Méven Car
meven updated this revision to Diff 55123. meven added a comment. Restrict statx use when c standard library is Glibc REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55120=55123 BRANCH creation-date REVISION DETAIL

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-07 Thread Méven Car
meven updated this revision to Diff 55709. meven marked 4 inline comments as done. meven added a comment. review feedback REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55683=55709 BRANCH arcpatch-D20096 REVISION DETAIL

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-07 Thread Méven Car
meven updated this revision to Diff 55679. meven added a comment. Use proper cmake check, fix an issue with KIO::UDSEntry::UDS_DEVICE_ID having value of stat_mode instead of stat_dev REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55644=55679 BRANCH

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-07 Thread Méven Car
meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > pino wrote in file.cpp:72-74 > TBH, instead of this static define, I'd do a proper cmake check (see > ConfigureChecks.cmake, and config-kioslave-file.h.cmake in src/ioslaves/file). It was not too easy to do.

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-07 Thread Méven Car
meven marked an inline comment as done. meven added a comment. In D20096#445410 , @ngraham wrote: > BTW Frameworks 5.57 has been tagged, so whenever folks are good with this, it can be landed at any time. :) I think this would be best to

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-07 Thread Méven Car
meven added inline comments. INLINE COMMENTS > ConfigureChecks.cmake:19 > + > +if (LIBC_IS_GLIBC) > +check_cxx_source_compiles(" I am not sure this is acceptable, this variable is set by ECM in extra-cmake-modules/kde-modules/KDECompilerSettings.cmake REPOSITORY R241 KIO BRANCH

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-07 Thread Méven Car
meven marked 2 inline comments as done. REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-07 Thread Méven Car
meven edited the summary of this revision. REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-07 Thread Méven Car
meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > pino wrote in ConfigureChecks.cmake:19 > sorry, i realized that my sentence was ambiguous: i meant to check for the > existance of statx no matter the platform We discussed previously that we would restrict

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-07 Thread Méven Car
meven updated this revision to Diff 55683. meven added a comment. Remove reference to old differential revision from the commit comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55679=55683 BRANCH arcpatch-D20096 REVISION DETAIL

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-07 Thread Méven Car
meven marked an inline comment as done. REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D19824: In saving single file mode an enter/return press on the KDirOperator triggers slotOk

2019-03-17 Thread Méven Car
meven updated this revision to Diff 54082. meven added a comment. Add deleted blank line REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19824?vs=54081=54082 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19824 AFFECTED FILES

D19824: In saving single file mode an enter/return press on the KDirOperator triggers slotOk

2019-03-17 Thread Méven Car
meven updated this revision to Diff 54081. meven added a comment. Remove blank line REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19824?vs=54080=54081 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19824 AFFECTED FILES

D19824: In saving single file mode an enter/return press on the KDirOperator triggers slotOk

2019-03-17 Thread Méven Car
meven created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY BUG: 385189 "Save dialog: Return key only bound to Save button when text field has focus" Draw inspiration from

D7423: [WIP/assistance needed] Populate UDS_CREATION_TIME on Linux if statx system call is available

2019-03-15 Thread Méven Car
meven added a comment. glibc 2.28 was released in August 2018, it is at least in (k)ubuntu 18.10, and I would expect in most other distros as well. I would be happy to help test this. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7423 To: ngraham, dfaure, broulik,

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

2019-03-18 Thread Méven Car
meven added a comment. In D19824#433831 , @ngraham wrote: > Thanks for the patch, and for adding a test! > > Question: how come the return/enter key currently works for this use case in the open dialog without all this extra code? In

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

2019-03-18 Thread Méven Car
meven retitled this revision from "In saving single file mode an enter/return press on the KDirOperator triggers slotOk" to "KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk". REPOSITORY R241 KIO REVISION DETAIL

D19824: KFileWidget In saving single file mode an enter/return press on the KDirOperator triggers slotOk

2019-03-19 Thread Méven Car
meven added a comment. In D19824#434053 , @ngraham wrote: > Makes sense, thanks. This fix works and looks sane to me. > > Maybe wait until at least one more #dolphin and/or #frameworks

D19945: Update link to fsearch project

2019-03-21 Thread Méven Car
meven created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY fsearch.org seems to be domain squatting. REPOSITORY R304 KNewStuff BRANCH update-fsearch-link REVISION DETAIL

D19945: Update link to fsearch project

2019-03-22 Thread Méven Car
meven updated this revision to Diff 54536. meven added a comment. Redoing the commit to set full name in the commit REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19945?vs=54494=54536 BRANCH fixed-arcpatch-D19945 REVISION DETAIL

D19945: Update link to fsearch project

2019-03-22 Thread Méven Car
This revision was automatically updated to reflect the committed changes. Closed by commit R304:2a3cea27ea58: Update link to fsearch project (authored by meven). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19945?vs=54536=54539 REVISION DETAIL

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-11 Thread Méven Car
meven updated this revision to Diff 55967. meven added a comment. Fix switch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20096?vs=55850=55967 BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 AFFECTED FILES

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-11 Thread Méven Car
meven marked 2 inline comments as done. REPOSITORY R241 KIO BRANCH arcpatch-D20096 REVISION DETAIL https://phabricator.kde.org/D20096 To: meven, #frameworks, dfaure, fvogt, bruns, broulik Cc: anthonyfieroni, pino, bcooksley, ngraham, kde-frameworks-devel, michaelh, bruns

D20096: Fill UDSEntry::UDS_CREATION_TIME under linux when glibc >= 2.28

2019-04-11 Thread Méven Car
meven marked an inline comment as done. meven added inline comments. INLINE COMMENTS > bruns wrote in file.cpp:890 > This is wrong in case someone uses details > 3, should be `case 0: > reserve(5)`, `case 3: default: reserve(15)` . > all checks below do e.g `if (details > 2)`, so handle 5 the

  1   2   3   4   5   6   7   8   9   10   >