Re: QUrl behavior and KIO

2013-09-05 Thread Marco Martin
that makes sense IMHO. Let's not start adding hacks for badly ported code. ok, i just wanted to make sure, since the autotest for the trash kioslave uses the wrong form all over the place, so i'll correct all there and in the kio itself Cheers, Marco Martin

Review Request 112547: avoid creating jobs on urls with double slashes

2013-09-05 Thread Marco Martin
a trailing slash it may be simpler (altough qurl documentation doesn't suggest so) Diffs - staging/kio/src/core/job.cpp e066ef4 Diff: http://git.reviewboard.kde.org/r/112547/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Marco Martin
(needs to be tested tough) experimental/kdeclarative/bindings/i18n.cpp http://git.reviewboard.kde.org/r/113086/#comment30241 this file (probably the bindings folder too) could go as well - Marco Martin On Oct. 3, 2013, 8:02 p.m., Aleix Pol Gonzalez wrote

Re: Review Request 113179: Make the runners compile again

2013-10-09 Thread Marco Martin
On Oct. 8, 2013, 9:15 p.m., Aleix Pol Gonzalez wrote: There's also runner-related code in src/declarativeimports/{core,runnermodel}, these should be reenabled as well. Possibly, they also need changes to make built. I had disabled this after a discussion with Aaron (who has refactored

Re: Build failed in Jenkins: plasma-framework_master_qt5 #862

2013-10-28 Thread Marco Martin
, and I did a completely clean build... It's as if it was building against an outdate kdelibs or ecm. build works fine here too, so can't reproduce. it seemslike the cmake macro that generates the json for the plugin from the desktop file isn't working? -- Marco Martin

Re: Review Request 115004: use KDeclarative namespace for kdeclarative framework classes

2014-01-13 Thread Marco Martin
/private/qmlobject_p.h e5b32f8 src/private/rootcontext.cpp 503b430 src/private/rootcontext_p.h 805f7fa src/qmlobject.h 5028559 src/qmlobject.cpp d00ff40 tests/kdeclarativetest.cpp dd34d88 Diff: https://git.reviewboard.kde.org/r/115004/diff/ Testing --- Thanks, Marco Martin

Re: Review Request 115004: use KDeclarative namespace for kdeclarative framework classes

2014-01-14 Thread Marco Martin
://git.reviewboard.kde.org/r/115004/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Where to put QML Bindings for KDE frameworks?

2014-01-28 Thread Marco Martin
want a KQuickAddons as well, to put the components we create to extend Qt. (for example, this component you created for bindings). thats what qtextracomponets was created for. is just to see in what repository to put it -- Marco Martin ___ Kde

Re: kf5 alpha 1 : modules, versions

2014-02-08 Thread Marco Martin
? Cheers, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kf5 alpha 1 : modules, versions

2014-02-08 Thread Marco Martin
On Saturday 08 February 2014 10:59:19 David Faure wrote: On Saturday 08 February 2014 10:55:25 Marco Martin wrote: On Saturday 08 February 2014 10:31:10 David Faure wrote: * it's not under frameworks/ in the projects.kde.org hierarchy. Shall we move it? * it declares itself

Re: kf5 alpha 1 : modules, versions

2014-02-08 Thread Marco Martin
like ecm_setup_version etc. in the subdir src/lib/core). Ivan: what do you think about it? -- Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kf5 alpha 1 : modules, versions

2014-02-08 Thread Marco Martin
://community.kde.org/Frameworks/List? This includes figuring out who to write down as maintainer :) added. I won't be around a couple of days, monday i'll start to tackle those issues. -- Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: kf5 alpha 1 : modules, versions

2014-02-10 Thread Marco Martin
to ecm_generate_headers and ecm_generate_pri_file. Do you want to look at that too? sure.. but what I need to do for that exactly? ;) Cheers, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: kf5 alpha 1 : modules, versions

2014-02-10 Thread Marco Martin
the correct ones? (how?) -- Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115713: Remove #if HAVE_X11 blocks from kstatusnotifieritem

2014-02-13 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115713/#review49701 --- Ship it! Ship It! - Marco Martin On Feb. 13, 2014, 6:53

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

2014-02-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116075/#review50910 --- +1 from me - Marco Martin On Feb. 26, 2014, 8:09 a.m

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

2014-02-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116075/#review50911 --- +1 from me - Marco Martin On Feb. 26, 2014, 8:09 a.m

QML Bindings for KDE frameworks, take 2

2014-03-18 Thread Marco Martin
. This seems still a meh solution, but i can't really think about better one. Opinions? comments? how i proceed? Cheers, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: QML Bindings for KDE frameworks, take 2

2014-03-18 Thread Marco Martin
, there is a lot of stuff using it, but conversion should be portable with a script. (depends from less stuff than KDeclarative or KQuickControls tough, KQuickControlsAddons suggests it depends from more?) -- Marco Martin ___ Kde-frameworks-devel mailing list

Re: QML Bindings for KDE frameworks, take 2

2014-03-19 Thread Marco Martin
On Tuesday 18 March 2014, Kevin Ottens wrote: On Tuesday 18 March 2014 19:37:59 Marco Martin wrote: what we currently have is: * dirmodel: is a binding to kdirmodel - KIO? (i would probably not release it yet but waiting to have folderview done so needed features are more clear) Would

Re: Plasma Next + Apps view on build.kde.org

2014-03-19 Thread Marco Martin
you tracking the state of our code. Feel free to extend it with other jobs as they become available. dude, that's awesome :D -- Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: QML Bindings for KDE frameworks, take 2

2014-03-19 Thread Marco Martin
kdeclarative or kquickcontrols repository? for plasma people: would be ok for you renaming QtExtracomponents to KQuickControlsAddons? may be cleaner even tough work and danger ;) -- Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: QML Bindings for KDE frameworks, take 2

2014-03-20 Thread Marco Martin
with a more complete one that is being developed in folderview -- Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Kioslave repos

2014-04-09 Thread Marco Martin
completely secondary behind the causing as less regressions as possible for the users. -- Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Kioslave repos

2014-04-10 Thread Marco Martin
example is the automounter, i would never use such a thing ever, never the less that's irrelevant and is an important component of a base workspace for too many users, no matter how buggy or unmaintained is) -- Marco Martin ___ Kde-frameworks-devel

Re: Kioslave repos

2014-04-11 Thread Marco Martin
it make sense? would somebody be interested in this adopt-a-pet thing? -- Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

plasma-framework in kdereview

2014-04-25 Thread Marco Martin
in the future, so it doesn't install any header, not part of the public api. * at least one plasma theme: the shipped QML components don't really work without it, so one is core * there was the plasma shell: has been removed and moved to plasma-workspace, decreasing dependencies Cheers, Marco Martin

Re: plasma-framework in kdereview

2014-04-25 Thread Marco Martin
else to take it seriously in any way. I wouldn't even manage to encourage with a straight face anyone to ever write a 3rd party plasmoid. -- Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: plasma-framework in kdereview

2014-04-25 Thread Marco Martin
would have it primarly as ligthtweight libraries i would split it at lest in 3-4 parts, but i think it's better preventing the fragmentation of little libraries in this case -- Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: plasma-framework in kdereview

2014-04-26 Thread Marco Martin
On Saturday, April 26, 2014, David Faure fa...@kde.org wrote: David is acting on the move as I'm typing that email. Stay tuned! :-) plasma-framework is now under frameworks/. kdesrc-build users, remember to do rm -rf kdereview/plasma-framework playground/libs/plasma-framework to avoid

Re: KDE Frameworks Release Cycle

2014-04-28 Thread Marco Martin
, on the other hand, I really like the discipline that this methos requires, it may well drive to a good quality increase -- Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: KF5 Maintainers: Please get ready for release

2014-04-28 Thread Marco Martin
On Sunday 27 April 2014, Kevin Ottens wrote: Marco Martin: - kdeclarative - plasma-framework I think it's pretty fine on my part, i'll take another review on the metadata files. one thing I think i need are toplevel bugzilla products for each framework, right? (if so i'll open a sysadmin

Re: KF5 Maintainers: Please get ready for release

2014-04-28 Thread Marco Martin
. That's exactly to try to catch this kind of situation that I sent the email. the kdeclarative one already exists, i just sent a sysadmin ticket for frameworks-plasma-framework (holy naming, batman :p) -- Marco Martin ___ Kde-frameworks-devel mailing

Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Marco Martin
: https://git.reviewboard.kde.org/r/118016/diff/ Testing --- screen and doActivate parameter weren't used by any, so all the currently ported software still builds and works correctly Thanks, Marco Martin ___ Kde-frameworks-devel mailing list

Re: Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Marco Martin
: https://git.reviewboard.kde.org/r/118016/#review57407 --- On May 6, 2014, 12:47 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Marco Martin
Gräßlin wrote: is it very much used outside of the workspace? probably not and ftr the ctors are SIC anyway compared to 4.x as it's now based on xcb Kevin Ottens wrote: I stand by my ship it! then. Marco Martin wrote: @Thomas: gcc 4.7.2 on opensuse the error

Re: KF5 Update Meeting Minutes 2014-w19

2014-05-06 Thread Marco Martin
and final on july 1st Just to put this on the table, so that is not overlooked, this may be a problem for the plasma release, that may make it worth revieving the schedule. -- Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Marco Martin
, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118016: Fix wrong constructor resolution

2014-05-06 Thread Marco Martin
Gräßlin wrote: is it very much used outside of the workspace? probably not and ftr the ctors are SIC anyway compared to 4.x as it's now based on xcb Kevin Ottens wrote: I stand by my ship it! then. Marco Martin wrote: @Thomas: gcc 4.7.2 on opensuse the error

Re: KIOAccessManagerFactory and QtQuick2

2014-05-14 Thread Marco Martin
things will always need, like folderview tough) any idea if kio may ever become thread safe? -- Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118153: remove unneeded file which collides with kf5plasma exports

2014-05-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118153/#review58012 --- Ship it! Ship It! - Marco Martin On May 15, 2014, 2:57

Re: Review Request 118200: [StatusNotifier] Don't set custom window flags on ContextMenu

2014-05-19 Thread Marco Martin
for menus, like kmix? - Marco Martin On May 19, 2014, 10:56 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118200

Re: Review Request 118200: [StatusNotifier] Don't set custom window flags on ContextMenu

2014-05-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118200/#review58142 --- Ship it! Ship It! - Marco Martin On May 19, 2014, 10:56

problems in http kioslave, where to debug?

2014-05-21 Thread Marco Martin
where may be the problem? -- Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 118276: give kwrite the proper dbus name in desktop file

2014-05-23 Thread Marco Martin
/CMakeLists.txt 5f461b2 kwrite/org.kde.kwrite.desktop ba8db4b Diff: https://git.reviewboard.kde.org/r/118276/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 118276: give kwrite the proper dbus name in desktop file

2014-05-26 Thread Marco Martin
for frameworks: should KRun() not freeze when such condition is encountered? Diffs - kwrite/CMakeLists.txt 5f461b2 kwrite/org.kde.kwrite.desktop ba8db4b Diff: https://git.reviewboard.kde.org/r/118276/diff/ Testing --- Thanks, Marco Martin

Re: problems in http kioslave, where to debug?

2014-06-02 Thread Marco Martin
disables the caches -- Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: problems in http kioslave, where to debug?

2014-06-02 Thread Marco Martin
On Monday 02 June 2014, Marco Martin wrote: Changing filecopyJob line 388 to m_getJob = KIO::get(m_src, Reload, HideProgressInfo /* no GUI */); make the download work correctly, even tough is obviously wrong, since it always disables the caches I don't know if is the right approach

Re: Review Request 118473: reset m_request.cacheTag dates in sendQuery()

2014-06-02 Thread Marco Martin
::file_copy seems to work correctly again Diffs - src/ioslaves/http/http.cpp c81ad41 Diff: https://git.reviewboard.kde.org/r/118473/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 118473: reset m_request.cacheTag dates in sendQuery()

2014-06-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118473/#review58997 --- On June 2, 2014, 4:41 p.m., Marco Martin wrote

Review Request 118479: Other time_t-QDateTime porting issues

2014-06-02 Thread Marco Martin
--- This ports back the other two places the cache times were resetted in kde4, in cacheParseResponseHeader and resetSessionSettings Diffs - src/ioslaves/http/http.cpp 4d1421c Diff: https://git.reviewboard.kde.org/r/118479/diff/ Testing --- Thanks, Marco Martin

Re: Review Request 118479: Other time_t-QDateTime porting issues

2014-06-02 Thread Marco Martin
://git.reviewboard.kde.org/r/118479/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

2014-06-04 Thread Marco Martin
or a screen edge - Marco Martin On June 4, 2014, 7:07 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118538

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

2014-06-04 Thread Marco Martin
On June 4, 2014, 7:30 p.m., Marco Martin wrote: what is a valid use case where qml needs to know where the dialog actually is?(not hypothetical please) doing the animation on the proper direction can be tracked completely internally also, plasmoids should never ever do a screen

Re: Review Request 118526: Provide i18nd wrappers in kdeclarative

2014-06-05 Thread Marco Martin
packages around use it - Marco Martin On June 4, 2014, 1:06 p.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118526

Re: Review Request 118547: Expose Formats as singleton

2014-06-05 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118547/#review59285 --- Ship it! Ship It! - Marco Martin On June 5, 2014, 8:23

Re: Review Request 118526: Provide i18nd wrappers in kdeclarative

2014-06-05 Thread Marco Martin
: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118526/ --- (Updated June 4, 2014, 1:06 p.m.) Review request for KDE Frameworks, Plasma and Marco

Re: Review Request 118526: Provide i18nd wrappers in kdeclarative

2014-06-05 Thread Marco Martin
/ --- (Updated June 4, 2014, 1:06 p.m.) Review request for KDE Frameworks, Plasma and Marco Martin. Repository: kdeclarative Description --- Provide i18nd wrappers in kdeclarative As QML might combine multiple modules

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

2014-06-05 Thread Marco Martin
On June 4, 2014, 7:30 p.m., Marco Martin wrote: what is a valid use case where qml needs to know where the dialog actually is?(not hypothetical please) doing the animation on the proper direction can be tracked completely internally also, plasmoids should never ever do a screen

Re: Review Request 118557: Port PlasmaFramework to i18nd + Add test checking for i18n use

2014-06-05 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118557/#review59301 --- Ship it! Ship It! - Marco Martin On June 5, 2014, 10:12

Re: Plasma 5 Beta 2 tars

2014-06-12 Thread Marco Martin
sys/stat.h in included that file redefines stat as stat64 when in 32 bits and LARGEFILE64_SOURCE is defined. moc, seeing there is a #define stat stat64 replaces it everywhere in the generated moc file, even where it shouldn't -- Marco Martin ___ Kde

Re: Review Request 118723: switch to Next wallpaper

2014-06-13 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118723/#review59962 --- Ship it! Ship It! - Marco Martin On June 13, 2014, 10:44

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

2014-06-17 Thread Marco Martin
On June 17, 2014, 4:11 p.m., Kevin Ottens wrote: Marco, any chance for a second run of review on that patch? i still not like this patch.. - Marco --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

2014-06-17 Thread Marco Martin
On June 17, 2014, 4:11 p.m., Kevin Ottens wrote: Marco, any chance for a second run of review on that patch? Marco Martin wrote: i still not like this patch.. Kevin Ottens wrote: Should be dropped then? Or it can get somewhere? Feel free to drop it if you consider

Re: Review Request 118838: Don't require mandatory subText in tooltip

2014-06-19 Thread Marco Martin
* a subtitle - Marco Martin On June 19, 2014, 12:48 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118838

git hooks for reviews mandatory?

2014-06-19 Thread Marco Martin
for not thinking about it at all, maybe I'm not the only one, an artificial enforce of discipline like that *may* make sense. opinions? would be useful, or mostly just an annoyance? -- Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

2014-06-19 Thread Marco Martin
On June 19, 2014, 8:42 p.m., David Edmundson wrote: Note: The property names don't line up 100% in the merge. flickableItem has now become contentItem (which is a default property) All instances in plasma-workspace/plasma-desktop are now updated. Kai Uwe Broulik wrote: That

Re: Review Request 118841: Add notify to colorGroup property

2014-06-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118841/#review60566 --- Ship it! Ship It! - Marco Martin On June 19, 2014, 9:34

Re: git hooks for reviews mandatory?

2014-06-20 Thread Marco Martin
On Thursday 19 June 2014 23:38:05 Luigi Toscano wrote: Marco Martin ha scritto: Hi all, I was thinking, since the policy for committing in frameworks is to always asking for a review, what about on repositories under frameworks/* adding an hook that accepts pushes only if the comment has

Re: Review Request 118842: Add reset function to QImageItem image property

2014-06-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118842/#review60578 --- Ship it! Ship It! - Marco Martin On June 20, 2014, 12:26

Review Request 118889: Use new Konqui in the about Dialog

2014-06-22 Thread Marco Martin
Attachments aboutkde.png https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/cf0875f5-52c0-429f-b852-54ea2b6f87fd__aboutkde.png Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 118889: Use new Konqui in the about Dialog

2014-06-23 Thread Marco Martin
On June 23, 2014, 10:34 a.m., Aleix Pol Gonzalez wrote: What about bringing this to VdG? They can come up with a more integrated new design for the about dialog. For the moment, I'm good with just changing the picture, but I wouldn't like to leave it there. Marco Martin wrote

Re: Review Request 118889: Use new Konqui in the about Dialog

2014-06-23 Thread Marco Martin
for the purpose Diffs - Diff: https://git.reviewboard.kde.org/r/118889/diff/ Testing --- File Attachments aboutkde.png https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/cf0875f5-52c0-429f-b852-54ea2b6f87fd__aboutkde.png Thanks, Marco Martin

Re: Review Request 118906: Fix dialog's check for isTooltip

2014-06-24 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118906/#review60886 --- Ship it! Ship It! - Marco Martin On June 23, 2014, 5:26

Re: Review Request 118962: Add api for setting download widget and dialog title. Helps with bug 336737

2014-06-27 Thread Marco Martin
://git.reviewboard.kde.org/r/118962/#comment42536 maybe a getter too for simmretry? - Marco Martin On June 26, 2014, 7:03 p.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Review Request 118972: Don't have all the Thmeme color properties in the public api

2014-06-27 Thread Marco Martin
-CREATION src/declarativeimports/core/quicktheme.cpp PRE-CREATION src/plasma/theme.h 0211f73 src/plasma/theme.cpp c193807 Diff: https://git.reviewboard.kde.org/r/118972/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing

Re: Review Request 118972: Don't have all the Thmeme color properties in the public api

2014-06-27 Thread Marco Martin
://git.reviewboard.kde.org/r/118972/#review61082 --- On June 27, 2014, 10:30 a.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Review Request 118972: Don't have all the Thmeme color properties in the public api

2014-06-27 Thread Marco Martin
/declarativeimports/core/quicktheme.h PRE-CREATION src/declarativeimports/core/quicktheme.cpp PRE-CREATION src/plasma/theme.h 0211f73 src/plasma/theme.cpp c193807 Diff: https://git.reviewboard.kde.org/r/118972/diff/ Testing --- Thanks, Marco Martin

Re: Review Request 118972: Don't have all the Thmeme color properties in the public api

2014-06-27 Thread Marco Martin
--- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118962: Add api for setting download widget and dialog title. Helps with bug 336737

2014-06-27 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118962/#review61105 --- Ship it! Ship It! - Marco Martin On June 26, 2014, 7:03

KIconLoader problem with KFontInst

2014-06-30 Thread Marco Martin
(KFI_NAME); KIconLoader::global()-reconfigure(KFI_NAME); if i put this patch in KIconThmemes, it appears to solve the issue: http://paste.opensuse.org/52060340 but still, it doesn't feel quite right.. any idea on what the issue actually is? -- Marco Martin

Re: KIconLoader problem with KFontInst

2014-06-30 Thread Marco Martin
On Monday 30 June 2014, Martin Klapetek wrote: Maybe the KFontInst shouldn't use KIconLoader::global() and have its own instance? I think KFontInst should just get away with those personalized icons.. but still seems something is wrong in kiconloader anyways.. -- Marco Martin

Review Request 119058: add a test case for KIconLoader::addAppDir()

2014-07-01 Thread Marco Martin
PRE-CREATION autotests/kiconloader_unittest.cpp d4ec842 autotests/resources.qrc 33c2510 Diff: https://git.reviewboard.kde.org/r/119058/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 119058: add a test case for KIconLoader::addAppDir()

2014-07-02 Thread Marco Martin
/CMakeLists.txt 798509d autotests/breeze.theme PRE-CREATION autotests/kiconloader_unittest.cpp d4ec842 autotests/resources.qrc 33c2510 Diff: https://git.reviewboard.kde.org/r/119058/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks

Re: Review Request 119058: add a test case for KIconLoader::addAppDir()

2014-07-02 Thread Marco Martin
() makes the test pass. Diffs - autotests/CMakeLists.txt 798509d autotests/breeze.theme PRE-CREATION autotests/kiconloader_unittest.cpp d4ec842 autotests/resources.qrc 33c2510 Diff: https://git.reviewboard.kde.org/r/119058/diff/ Testing --- Thanks, Marco Martin

KIO: thread safety commit broke Get hot new stuff

2014-07-04 Thread Marco Martin
concurrent access to KProtocolManager methods Right now frameworks are tagged, but either kio or knewstuff framework are broken. And we need the dialog working in the Plasma 5 release. Sooo, how do we proceed? -- Marco Martin ___ Kde-frameworks-devel

Re: Review Request 119110: Release Blocker - KProtocolManager: Fix double mutex locking on a non recursive mutex

2014-07-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119110/#review61611 --- I can confirm it fixes it here as well - Marco Martin

Review Request 119155: Make the desktop containment respect minimum sizes

2014-07-07 Thread Marco Martin
that was avoideed with care by the new layout engine. This may be a blocker in shipping it for 5.0 Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119155: Make the desktop containment respect minimum sizes

2014-07-07 Thread Marco Martin
://git.reviewboard.kde.org/r/119155/#review61808 --- On July 7, 2014, 12:51 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 119155: Make the desktop containment respect minimum sizes

2014-07-07 Thread Marco Martin
with care by the new layout engine. This may be a blocker in shipping it for 5.0 Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 119165: store the containment as a qpointer

2014-07-07 Thread Marco Martin
://git.reviewboard.kde.org/r/119165/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119165: store the containment as a qpointer

2014-07-08 Thread Marco Martin
happening - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119165/#review61861 --- On July 8, 2014, 8:36 a.m., Marco Martin wrote

Re: Review Request 119165: store the containment as a qpointer

2014-07-08 Thread Marco Martin
/containmentinterface.cpp f1762fe Diff: https://git.reviewboard.kde.org/r/119165/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119165: store the containment as a qpointer

2014-07-08 Thread Marco Martin
/containmentinterface.cpp f1762fe Diff: https://git.reviewboard.kde.org/r/119165/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

online kanban/todo list

2014-07-08 Thread Marco Martin
infrastructure (and yes, the lack of features is a very important feature in this case, I wouldn't like to have to touch stuff like icescrum ever again :p) I wouldn't put this as mandatory, but would be a very useful thing to have for who wants to make good use of it -- Marco Martin

Review Request 119270: Autotest for corona restore and behavior

2014-07-14 Thread Marco Martin
/plasma/private/containment_p.cpp f8b4578 Diff: https://git.reviewboard.kde.org/r/119270/diff/ Testing --- Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 119155: Make the desktop containment respect minimum sizes

2014-07-14 Thread Marco Martin
of overlapping applets, thing that was avoideed with care by the new layout engine. This may be a blocker in shipping it for 5.0 Thanks, Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request 119270: Autotest for corona restore and behavior

2014-07-14 Thread Marco Martin
generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119270/#review62294 --- On July 14, 2014, 12:30 p.m., Marco Martin wrote: --- This is an automatically generated e

Re: Review Request 119270: Autotest for corona restore and behavior

2014-07-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119270/#review62294 --- On July 14, 2014, 12:30 p.m., Marco Martin wrote

Re: Review Request 119270: Autotest for corona restore and behavior

2014-07-14 Thread Marco Martin
--- On July 14, 2014, 12:30 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119270/ --- (Updated

  1   2   3   4   5   6   7   8   9   10   >