Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-09-06 Thread Mark Gaiser
://git.reviewboard.kde.org/r/112463/#review39463 --- On Sept. 2, 2013, 7:16 p.m., Mark Gaiser wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r

Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

2013-09-12 Thread Mark Gaiser
that are there are passing though i doubt they test this case. the KIO file slave also works just fine. Compilation does give me new (expected_ deprecated errors for at least the http slave. I don't know how to test that one. It should just work fine though. Thanks, Mark Gaiser

Review Request 112702: KIO slavebase listEntry improvement and cleanups

2013-09-12 Thread Mark Gaiser
- kioslave/file/file_unix.cpp 48bd0ba staging/kio/src/core/slavebase.h b46631e staging/kio/src/core/slavebase.cpp 2e46985 Diff: http://git.reviewboard.kde.org/r/112702/diff/ Testing --- Thanks, Mark Gaiser ___ Kde-frameworks-devel mailing list

Re: Review Request 112717: Start adopting QCollator

2013-09-13 Thread Mark Gaiser
if it beats the current stuff, if it does then it should deffinately replace naturalCompare :) - Mark Gaiser On Sept. 13, 2013, 5:12 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

2013-09-14 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112702/#review40015 --- On Sept. 12, 2013, 6:26 p.m., Mark Gaiser wrote

Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

2013-09-14 Thread Mark Gaiser
--- On Sept. 12, 2013, 6:26 p.m., Mark Gaiser wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112702

Re: Review Request 112702: KIO slavebase listEntry improvement and cleanups

2013-09-14 Thread Mark Gaiser
, Mark Gaiser ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112717: Start adopting QCollator

2013-09-17 Thread Mark Gaiser
On Sept. 15, 2013, 10:29 a.m., Frank Reininghaus wrote: Thanks for your cool work on QCollator! It will be interesting to see how much we can gain by using QCollatorSortKey for sorting large sets of QStrings :-) I'm not really familiar with most of the affected code, and I couldn't

Re: Review Request 112717: Start adopting QCollator

2013-09-18 Thread Mark Gaiser
Frank and i have. That is not appreciated! - Mark Gaiser On Sept. 18, 2013, 2:58 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112717

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

2013-09-18 Thread Mark Gaiser
request. (I didn't see this one) Idea: restore naturalCompare as it was and add a collatorNaturalCompare that is taking the QCollator route. That way it's easily testable as well. I think we can all agree on that, right? - Mark Gaiser On Sept. 18, 2013, 4:55 p.m., Aleix Pol Gonzalez wrote

Re: Review Request 112717: Start adopting QCollator

2013-09-18 Thread Mark Gaiser
On Sept. 18, 2013, 3:22 p.m., Mark Gaiser wrote: How RUDE to just commit this without a addressing the concerns Frank and i have. That is not appreciated! Aleix Pol Gonzalez wrote: Alright, maybe I didn't think this through. I'll un-deprecate and bring back the KStringHandler

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

2013-09-18 Thread Mark Gaiser
On Sept. 18, 2013, 5:23 p.m., Mark Gaiser wrote: Posting the same here as i just said in your other review request. (I didn't see this one) Idea: restore naturalCompare as it was and add a collatorNaturalCompare that is taking the QCollator route. That way it's easily testable as well

Re: Review Request 112797: Bring back KStringHandler::naturalCompare()

2013-09-30 Thread Mark Gaiser
: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112797/ --- (Updated Sept. 24, 2013, 6:08 p.m.) Review request for KDE Frameworks, Frank Reininghaus and Mark

Re: Review Request 113181: Add KDebug porting notes to KDE5PORTING.html

2013-10-09 Thread Mark Gaiser
versions? I will bring this up on k-f-d as well since i think more people will have the same question as i just asked. - Mark Gaiser On Oct. 9, 2013, 12:59 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply

Review Request 113205: Make KJob::result public for the new signal/slot syntax.

2013-10-11 Thread Mark Gaiser
the new syntax and directly use a lambda as slot. Which isn't possible on this signal if it isn't public. Diffs - tier1/kcoreaddons/src/lib/jobs/kjob.h d663530 Diff: http://git.reviewboard.kde.org/r/113205/diff/ Testing --- Works just fine. Thanks, Mark Gaiser

Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

2013-10-11 Thread Mark Gaiser
On Oct. 11, 2013, 9:51 p.m., Mark Gaiser wrote: We are here making a 'hole' for people to do 'bad things' that wasn't possible in the past. I'm not sure we want that. Interesting. So that mean we simply can't use the new signal/slot syntax because of it? That would seem rather strange

Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

2013-10-12 Thread Mark Gaiser
On Oct. 11, 2013, 9:51 p.m., Mark Gaiser wrote: We are here making a 'hole' for people to do 'bad things' that wasn't possible in the past. I'm not sure we want that. Mark Gaiser wrote: Interesting. So that mean we simply can't use the new signal/slot syntax because

Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

2013-10-12 Thread Mark Gaiser
://git.reviewboard.kde.org/r/113205/diff/ Testing --- Works just fine. Thanks, Mark Gaiser ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

2013-10-12 Thread Mark Gaiser
/ Testing --- Works just fine. Thanks, Mark Gaiser ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113205: Make KJob::result public for the new signal/slot syntax.

2013-10-14 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113205/#review41670 --- On Oct. 12, 2013, 6:30 p.m., Mark Gaiser wrote

Re: Review Request 113205: Make KJob's finished/suspend/resume/result signals public for the new signal/slot syntax.

2013-10-14 Thread Mark Gaiser
. Diffs (updated) - tier1/kcoreaddons/src/lib/jobs/kjob.h d663530 tier1/kcoreaddons/src/lib/jobs/kjob.cpp f99a99f Diff: http://git.reviewboard.kde.org/r/113205/diff/ Testing --- Works just fine. Thanks, Mark Gaiser ___ Kde

Re: Review Request 113205: Make KJob's finished/suspend/resume/result signals public for the new signal/slot syntax.

2013-10-14 Thread Mark Gaiser
://git.reviewboard.kde.org/r/113205/#review41714 --- On Oct. 14, 2013, 12:46 p.m., Mark Gaiser wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 113205: Make KJob's finished/suspend/resume/result signals public for the new signal/slot syntax.

2013-10-15 Thread Mark Gaiser
tier1/kcoreaddons/src/lib/jobs/kjob.cpp f99a99f Diff: http://git.reviewboard.kde.org/r/113205/diff/ Testing --- Works just fine. Thanks, Mark Gaiser ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Re: Review Request 113181: Add KDebug porting notes to KDE5PORTING.html

2013-10-16 Thread Mark Gaiser
/#comment30538 This is not valid anymore. It should now be qCdebug/warning/notice/... and with a category. I think it;s best to just link to the wiki page and skip the other information in this area. - Mark Gaiser On Oct. 16, 2013, 7:45 a.m., Martin Klapetek wrote

Re: Review Request 113181: Add KDebug porting notes to KDE5PORTING.html

2013-10-17 Thread Mark Gaiser
On Oct. 16, 2013, 9:02 p.m., Mark Gaiser wrote: KDE5PORTING.html, lines 290-295 http://git.reviewboard.kde.org/r/113181/diff/2/?file=201374#file201374line290 This is not valid anymore. It should now be qCdebug/warning/notice/... and with a category. I think it;s best to just

Re: Dot story on KDE contributions to Qt 5.2

2013-11-24 Thread Mark Gaiser
On Sun, Nov 24, 2013 at 7:34 PM, David Faure fa...@kde.org wrote: On Saturday 16 November 2013 10:54:53 John Layt wrote: Hi, There was a discussion on the promo list a couple of weeks back about doing a Dot story to coincide with the release of Qt 5.2 highlighting KDE's contributions. Jos

Re: Dot story on KDE contributions to Qt 5.2

2013-11-24 Thread Mark Gaiser
On Sun, Nov 24, 2013 at 7:57 PM, David Faure fa...@kde.org wrote: On Sunday 24 November 2013 19:48:33 Mark Gaiser wrote: On Sun, Nov 24, 2013 at 7:34 PM, David Faure fa...@kde.org wrote: On Saturday 16 November 2013 10:54:53 John Layt wrote: Hi, There was a discussion on the promo list

Re: Cherry picking SMB changes from kde-runtime master to frameworks. Err...

2013-12-01 Thread Mark Gaiser
On Sun, Dec 1, 2013 at 10:09 AM, David Faure fa...@kde.org wrote: On Sunday 01 December 2013 03:25:08 Mark Gaiser wrote: In recent months Dawit (in cc) has added quite some nice optimizations to the SMB kioslave. He' done with those changes now so i'd like to pull those into the frameworks

Re: KF5 Update Meeting 2013-w49 Reminder

2013-12-03 Thread Mark Gaiser
On Tue, Dec 3, 2013 at 1:37 PM, Àlex Fiestas afies...@kde.org wrote: Hi there ! Just a quick reminder: The next KF5 Update Meeting will happen on #kde-devel today (Tuesday) at 4pm Barcelona (CEST / UTC+2) time. If you want me to do any announcement today in the meeting just when the

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-12-04 Thread Mark Gaiser
Bump. Can anyone look at this? On Sun, Dec 1, 2013 at 10:32 PM, Mark Gaiser mark...@gmail.com wrote: This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/ Review request for KDE Runtime and KDE Frameworks. By Mark Gaiser. *Updated Dec

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-12-05 Thread Mark Gaiser
. Thanks, Mark Gaiser ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-12-10 Thread Mark Gaiser
Bump.. Ok to push it? On Fri, Dec 6, 2013 at 12:44 AM, Mark Gaiser mark...@gmail.com wrote: This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463/ Review request for KDE Runtime and KDE Frameworks. By Mark Gaiser. *Updated Dec. 5, 2013

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-12-10 Thread Mark Gaiser
. If there still is nothing by next friday (13th dec.) then i will go ahead and push. - Mark Gaiser On Dec. 5, 2013, 11:44 p.m., Mark Gaiser wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-12-10 Thread Mark Gaiser
--- On Dec. 5, 2013, 11:44 p.m., Mark Gaiser wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-12-10 Thread Mark Gaiser
this on an actual samba share, but i kept getting a 111 error (connection refused) from kio_smb so i'm hoping that is a local issue here. If someone else could try this out and verify that it's either working or broken. Thanks, Mark Gaiser ___ Kde

Re: Frameworks Performance Question

2013-12-29 Thread Mark Gaiser
On Sun, Dec 29, 2013 at 8:07 PM, Christoph Cullmann cullm...@absint.com wrote: Hi, if I play around with Kate on KF5, it laggs like hell the whole time. I tried to profile, but guess I am stuck a bit. Interesting is that most times you see it lag and you interrupt it then, it hangs around

Re: Frameworks Performance Question

2013-12-30 Thread Mark Gaiser
On Mon, Dec 30, 2013 at 2:11 PM, Hugo Pereira Da Costa hugo.pere...@free.fr wrote: On 12/30/2013 02:08 PM, Hugo Pereira Da Costa wrote: On 12/30/2013 12:42 PM, David Faure wrote: On Sunday 29 December 2013 20:07:38 Christoph Cullmann wrote: Hi, if I play around with Kate on KF5, it laggs

Re: Where to put QML Bindings for KDE frameworks?

2014-01-28 Thread Mark Gaiser
On Tue, Jan 28, 2014 at 12:58 PM, David Edmundson da...@davidedmundson.co.uk wrote: For a task in Plasma I've had to port KKeySequence to render on QtQuick, using QtQuickControls. I expect over time we will see more KDE widgets having QtQuick implementations as well. Same for a lot of our

Re: Change the ML default reply-to address

2014-01-29 Thread Mark Gaiser
On Wed, Jan 29, 2014 at 9:01 AM, Martin Klapetek martin.klape...@gmail.com wrote: On Tue, Jan 28, 2014 at 7:04 PM, Nicolás Alvarez nicolas.alva...@gmail.com wrote: 2014-01-28 Martin Klapetek martin.klape...@gmail.com: Hey, would it be possible to change the default reply-to address for

Re: Change the ML default reply-to address

2014-01-29 Thread Mark Gaiser
On Wed, Jan 29, 2014 at 5:38 PM, Kevin Krammer kram...@kde.org wrote: On Wednesday, 2014-01-29, 14:29:42, Mark Gaiser wrote: Yeah, i've had that issue quite a few times. Now since i use gmail i either have an easy reply-to-all option or (and that's even better) a labs plugin

Re: Frameworks sprint in Barcelona

2014-01-29 Thread Mark Gaiser
On Wed, Jan 29, 2014 at 5:43 PM, Àlex Fiestas afies...@kde.org wrote: Hi there ! It is time we decide when to organize the Frameworks sprint, the main objective of this sprint is Making it releseable. The Doodle contains only Thursdays from May and April which is the day the sprint will

Re: let's get ready for Google Summer of Code 2014

2014-02-09 Thread Mark Gaiser
On Sun, Feb 9, 2014 at 1:37 PM, Lydia Pintscher ly...@kde.org wrote: On Tue, Feb 4, 2014 at 9:24 AM, Lydia Pintscher ly...@kde.org wrote: Hey everyone :) It is time to get ready for GSoC 2014. It's another great chance to get some large projects done this year and welcome new enthusiastic

Re: let's get ready for Google Summer of Code 2014

2014-02-09 Thread Mark Gaiser
On Mon, Feb 10, 2014 at 12:51 AM, Aleix Pol aleix...@kde.org wrote: On Sun, Feb 9, 2014 at 8:57 PM, Mark Gaiser mark...@gmail.com wrote: On Sun, Feb 9, 2014 at 1:37 PM, Lydia Pintscher ly...@kde.org wrote: On Tue, Feb 4, 2014 at 9:24 AM, Lydia Pintscher ly...@kde.org wrote: Hey everyone

Re: Review Request 115605: Rename plasmapkg

2014-02-10 Thread Mark Gaiser
=8fb14bba0ca3983cb3503ea780c66b932816a1a1hb=f9e5cc949ff3719ec553955fba09f4efbc189c07f=CMakeLists.txt - Mark Gaiser On Feb. 10, 2014, 11:53 a.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: let's get ready for Google Summer of Code 2014

2014-02-10 Thread Mark Gaiser
Done: http://community.kde.org/GSoC/2014/Ideas#Revive_KioFuse.2C_fuse_support_for_KIO Lets hope a student comes by and picks that project :) All we need then is someone to mentor that. On Mon, Feb 10, 2014 at 2:47 AM, Mark Gaiser mark...@gmail.com wrote: On Mon, Feb 10, 2014 at 12:51 AM, Aleix

Re: let's get ready for Google Summer of Code 2014

2014-02-10 Thread Mark Gaiser
On Mon, Feb 10, 2014 at 4:13 PM, Vishesh Handa m...@vhanda.in wrote: On Monday, February 10, 2014 01:54:36 PM Mark Gaiser wrote: Done: http://community.kde.org/GSoC/2014/Ideas#Revive_KioFuse.2C_fuse_support_for _KIO Lets hope a student comes by and picks that project :) All we need

Re: Frameworks sprint in Barcelona

2014-02-17 Thread Mark Gaiser
On Wed, Jan 29, 2014 at 5:58 PM, Mark Gaiser mark...@gmail.com wrote: On Wed, Jan 29, 2014 at 5:43 PM, Àlex Fiestas afies...@kde.org wrote: Hi there ! It is time we decide when to organize the Frameworks sprint, the main objective of this sprint is Making it releseable. The Doodle contains

Re: Sprint from 24th of April until 28th

2014-02-19 Thread Mark Gaiser
On Wed, Feb 19, 2014 at 6:20 PM, Àlex Fiestas afies...@kde.org wrote: We finally have a date for the sprint, next step is to know how many people need sponsoring, so please register yourself here: https://sprints.kde.org/sprint/224 I want to send the budget somewhere next week so please,

Re: Frameworks sprint in Barcelona

2014-02-22 Thread Mark Gaiser
On Sat, Feb 22, 2014 at 10:28 AM, David Faure fa...@kde.org wrote: On Wednesday 29 January 2014 17:58:09 Mark Gaiser wrote: I only filled in April 3rd since that makes worth to stay in barcelona after the pim sprint. Strange way of using doodle. Red is supposed to mean impossible

Re: GSoC: KioFuse

2014-02-23 Thread Mark Gaiser
On Sat, Feb 22, 2014 at 11:22 PM, Lydia Pintscher ly...@kde.org wrote: On Wed, Feb 19, 2014 at 4:13 PM, Pali Rohár pali.ro...@gmail.com wrote: Hello KDE developers! I looked at KDE GSoC wiki page [1] and there is for me interesting project KioFuse. Did I understand it correctly, that KioFuse

Re: kdesrc-build: stop after failure? --truly-verbose?

2014-02-26 Thread Mark Gaiser
On Wed, Feb 26, 2014 at 10:30 PM, Milian Wolff m...@milianw.de wrote: Hey, not sure this is the right list. I noticed that kdesrc-build happily continues building even when a module failed to build. Is this desired? I find it highly unintuitive, esp. as most modules failing at the beginning

Re: Frameworks sprint: Register now!

2014-02-27 Thread Mark Gaiser
On Thu, Feb 27, 2014 at 7:44 AM, Kevin Ottens er...@kde.org wrote: Hello all, If you didn't yet, please register for the upcoming sprint: https://sprints.kde.org/sprint/224 Especially if you're not from Barcelona, it's necessary for budgeting the sprint, booking the accommodation, etc. The

Re: Review Request 116998: Clean up kde4 stuff in knewstuff

2014-03-25 Thread Mark Gaiser
://git.reviewboard.kde.org/r/116998/#comment37842 iconurl = QUrl::fromLocalFile(xmldata.attribute(icon)); Or am i missing something obvious now? - Mark Gaiser On March 25, 2014, 2:37 p.m., Alex Merry wrote: --- This is an automatically

Re: Review Request 117080: cleanup KDirModelTest

2014-03-26 Thread Mark Gaiser
. - Mark Gaiser On March 26, 2014, 12:13 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117080

Re: Review Request 117078: Allow compiling kio on windows

2014-03-26 Thread Mark Gaiser
that. I don't know exactly what the old case was doing here. What was it doing? - Mark Gaiser On March 26, 2014, 11:16 a.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 117078: Allow compiling kio on windows

2014-03-26 Thread Mark Gaiser
On March 26, 2014, 12:57 p.m., Mark Gaiser wrote: src/widgets/kpropertiesdialog.cpp, line 3444 https://git.reviewboard.kde.org/r/117078/diff/2/?file=257291#file257291line3444 If you change it anyway, you might as well go for C++11: for(const QString userName : userNames

Re: Review Request 117080: cleanup KDirModelTest

2014-03-26 Thread Mark Gaiser
On March 26, 2014, 12:39 p.m., Mark Gaiser wrote: autotests/kdirmodeltest.cpp, lines 55-56 https://git.reviewboard.kde.org/r/117080/diff/1/?file=257310#file257310line55 Do you really have to make defines for those signals? Sure, it looks fancy in the connect lines, but i

Re: Review Request 117976: Implement support for QFileDialog::setFileMode

2014-05-03 Thread Mark Gaiser
: m_file break; I like your test! Looks a lot like the one i wrote for the view mode :) +1 from me after the default case is implemented. - Mark Gaiser On May 3, 2014, 3:27 p.m., David Rosca wrote: --- This is an automatically

Re: [kio] src/widgets: Reimplement sibling(), faster than the default impl which goes via parent()

2014-05-04 Thread Mark Gaiser
On Sun, May 4, 2014 at 1:41 PM, David Faure fa...@kde.org wrote: Git commit 23d81eb86ae45828f8a56d2b0447de0a0f20aa86 by David Faure. Committed on 04/05/2014 at 11:40. Pushed by dfaure into branch 'master'. Reimplement sibling(), faster than the default impl which goes via parent() It wasn't

Re: Review Request 118071: add a message to the assertion

2014-05-10 Thread Mark Gaiser
://git.reviewboard.kde.org/r/118071/#comment40114 You have a double ;; ;) - Mark Gaiser On May 10, 2014, 1:57 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118071

KIO directory listing - CPU slows down SSD

2014-05-11 Thread Mark Gaiser
Hi, I've been playing with KIO speed improvements for quite a while now and found some very interesting issues with KIO in combination with my SSD drive: Samsung SSD 840 PRO Series. My testcase is one directory filled with 500.000 files to test directory listing speed. Please don't comment on

Re: KIO directory listing - CPU slows down SSD

2014-05-11 Thread Mark Gaiser
On Sun, May 11, 2014 at 10:22 PM, Frank Reininghaus frank7...@googlemail.com wrote: Hi Mark, 2014-05-11 21:57 GMT+02:00 Mark Gaiser: Hi, I've been playing with KIO speed improvements for quite a while now and found some very interesting issues with KIO in combination with my SSD drive

Re: KIO directory listing - CPU slows down SSD

2014-05-12 Thread Mark Gaiser
On Mon, May 12, 2014 at 10:55 AM, David Faure fa...@kde.org wrote: On Sunday 11 May 2014 21:57:58 Mark Gaiser wrote: My theoretical solution (and i really hope to get feedback on this) is to introduce a worker thread in slavebase.cpp. First feedback: threads create complexity, so I'm very

Re: KIO directory listing - CPU slows down SSD

2014-05-12 Thread Mark Gaiser
On Mon, May 12, 2014 at 1:09 PM, Milian Wolff m...@milianw.de wrote: On Monday 12 May 2014 12:34:33 Mark Gaiser wrote: On Mon, May 12, 2014 at 10:55 AM, David Faure fa...@kde.org wrote: On Sunday 11 May 2014 21:57:58 Mark Gaiser wrote: My theoretical solution (and i really hope to get

Re: KIO directory listing - CPU slows down SSD

2014-05-14 Thread Mark Gaiser
On Wed, May 14, 2014 at 12:50 PM, Aaron J. Seigo ase...@kde.org wrote: On Sunday, May 11, 2014 21:57:58 Mark Gaiser wrote: Note: my recent incremental cleanups already made it about a second faster then it used to be. It used to be around 5.500ms. However, the current speed is still ~7x slower

Re: KIOAccessManagerFactory and QtQuick2

2014-05-14 Thread Mark Gaiser
On Wed, May 14, 2014 at 12:09 PM, Marco Martin notm...@gmail.com wrote: On Tuesday 13 May 2014 18:31:06 Aleix Pol wrote: Hi, I've been getting some error messages [1] from some QML applications and I decided to investigate a bit further. I realized then that most of it was coming from the

Re: Review Request 118128: Use actual bytes formatter for sizes in KDirModel

2014-05-14 Thread Mark Gaiser
version where the view formats it to whatever it wants. This also eases sorting. - Mark Gaiser On May 14, 2014, 2:01 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 118128: Use actual bytes formatter for sizes in KDirModel

2014-05-14 Thread Mark Gaiser
On May 14, 2014, 2:13 p.m., Mark Gaiser wrote: Ehh.. Does this mean that there is no way to get the actual byte size anymore? In that case i think it would be better to introduce a new role: HumanReadableSize which does what your patch is doing now. Note: i really think

Re: KIO directory listing - CPU slows down SSD

2014-05-14 Thread Mark Gaiser
On Wed, May 14, 2014 at 3:31 PM, Mark Gaiser mark...@gmail.com wrote: On Wed, May 14, 2014 at 12:50 PM, Aaron J. Seigo ase...@kde.org wrote: On Sunday, May 11, 2014 21:57:58 Mark Gaiser wrote: Note: my recent incremental cleanups already made it about a second faster then it used

Re: Review Request 118289: Change titlewidget from bold to increased font size

2014-05-23 Thread Mark Gaiser
in the left menu anyway so it is common sense that you get selected name settings in the right pane.. But that's just my opinion for that :) - Mark Gaiser On May 24, 2014, 12:10 a.m., Sebastian Kügler wrote: --- This is an automatically

Re: Build failed in Jenkins: kdelibs4support_master_qt5 #203

2014-05-27 Thread Mark Gaiser
I looked at this issue and it is introduced by commit: 5f4dc2973f10cd44b2c70680fee72dd8fc545d2f in kconfig. Belonging to this review request: https://git.reviewboard.kde.org/r/118039/ It removes readCheck and writeCheck. I don't know what the intended fix would be for kdelibs4support which

Re: KIO directory listing - CPU slows down SSD

2014-05-28 Thread Mark Gaiser
On Wed, May 28, 2014 at 9:59 AM, David Faure fa...@kde.org wrote: On Wednesday 14 May 2014 12:50:18 Aaron J. Seigo wrote: * one entry at a time, serialized * no changing data once put there * no getting the data back out the class would then just batch up data into its QByteArray and then

Re: KIO directory listing - CPU slows down SSD

2014-05-28 Thread Mark Gaiser
On Wed, May 28, 2014 at 7:33 PM, Aaron J. Seigo ase...@kde.org wrote: On Wednesday, May 28, 2014 16:23:31 Mark Gaiser wrote: On Wed, May 28, 2014 at 9:59 AM, David Faure fa...@kde.org wrote: On Wednesday 14 May 2014 12:50:18 Aaron J. Seigo wrote: * one entry at a time, serialized

Re: Review Request 118389: Fix Compile for kio/src/core/udsentry.cpp on Mac

2014-05-29 Thread Mark Gaiser
mac/linux. And if that's the case then i'm very sorry that i didn't spot this when making the constructor. - Mark Gaiser On May 29, 2014, 12:52 p.m., Allen Winter wrote: --- This is an automatically generated e-mail. To reply, visit

Re: KIO directory listing - CPU slows down SSD

2014-05-29 Thread Mark Gaiser
On Thu, May 29, 2014 at 12:21 AM, Aaron J. Seigo ase...@kde.org wrote: On Wednesday, May 28, 2014 21:12:43 Mark Gaiser wrote: You've written that with the assumption of backwards compatibility. It's a nice idea, but why should we even try to remain backwards compatible? The question should

Re: Review Request 118128: Use actual bytes formatter for sizes in KDirModel

2014-05-29 Thread Mark Gaiser
. I think this is the way to go and let the GUI format the number how it wants to display it. +1 from me. - Mark Gaiser On May 29, 2014, 5 p.m., Martin Klapetek wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 118452: Reduce the memory usage of UDSEntry by using QVector, rather than QHash, for the internal data storage

2014-06-01 Thread Mark Gaiser
(as it was) or QVector (as it is with this patch). Lookups would then only be required for custom fields. I'm not sure if my changes still make sense after this change lands. I will just have to do some benchmarks and see if the added complexity is worth it. - Mark Gaiser On June 1, 2014, 1:50 p.m., Frank

Re: KIO directory listing - CPU slows down SSD

2014-06-02 Thread Mark Gaiser
On Mon, Jun 2, 2014 at 6:42 PM, Aaron J. Seigo ase...@kde.org wrote: On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: On Thu, May 29, 2014 at 12:21 AM, Aaron J. Seigo ase It's just a hobby for me to optimize it to levels that match raw speed (without any KIO). meaningful speed

Re: KIO directory listing - CPU slows down SSD

2014-06-02 Thread Mark Gaiser
On Mon, Jun 2, 2014 at 11:39 PM, Frank Reininghaus frank7...@googlemail.com wrote: Hi, 2014-06-02 20:54 GMT+02:00 Mark Gaiser: On Mon, Jun 2, 2014 at 6:42 PM, Aaron J. Seigo wrote: On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: dolphin on a massive folder. In fact, those that use kio

Re: KIO directory listing - CPU slows down SSD

2014-06-02 Thread Mark Gaiser
On Mon, Jun 2, 2014 at 11:47 PM, Frank Reininghaus frank7...@googlemail.com wrote: Hi, 2014-06-02 23:39 GMT+02:00 Frank Reininghaus: Hi, 2014-06-02 20:54 GMT+02:00 Mark Gaiser: On Mon, Jun 2, 2014 at 6:42 PM, Aaron J. Seigo wrote: On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote

Re: Review Request 118547: Expose Formats as singleton

2014-06-04 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118547/#review59256 --- Ship it! Makes sense and looks nice! - Mark Gaiser

Re: KIO directory listing - CPU slows down SSD

2014-06-06 Thread Mark Gaiser
On Fri, Jun 6, 2014 at 11:10 AM, Aaron J. Seigo ase...@kde.org wrote: On Monday, June 2, 2014 20:54:11 Mark Gaiser wrote: On Mon, Jun 2, 2014 at 6:42 PM, Aaron J. Seigo ase...@kde.org wrote: On Thursday, May 29, 2014 16:32:28 Mark Gaiser wrote: On Thu, May 29, 2014 at 12:21 AM, Aaron J

kdesrc-build not honoring

2014-06-07 Thread Mark Gaiser
Hi, In my kdesrc-buildrc i have: global ... cmake-options -DKDE4_BUILD_TESTS=TRUE -DCMAKE_BUILD_TYPE=RelWithDebInfo ... end global I use that to compile frameworks. However, every CMakeCache.txt file gets: CMAKE_BUILD_TYPE:STRING=debug So it looks like the above cmake-options line is not

Re: kdesrc-build not honoring

2014-06-07 Thread Mark Gaiser
On Sat, Jun 7, 2014 at 9:40 PM, Mark Gaiser mark...@gmail.com wrote: Hi, In my kdesrc-buildrc i have: global ... cmake-options -DKDE4_BUILD_TESTS=TRUE -DCMAKE_BUILD_TYPE=RelWithDebInfo ... end global I use that to compile frameworks. However, every CMakeCache.txt file gets

Re: kdesrc-build not honoring

2014-06-07 Thread Mark Gaiser
On Sat, Jun 7, 2014 at 10:23 PM, David Faure fa...@kde.org wrote: On Saturday 07 June 2014 21:40:01 Mark Gaiser wrote: Hi, In my kdesrc-buildrc i have: global ... cmake-options -DKDE4_BUILD_TESTS=TRUE -DCMAKE_BUILD_TYPE=RelWithDebInfo ... end global I use that to compile

Re: Review Request 118985: KSharedConfig: only write to mainConfig and wasTestModeEnabled in the main thread

2014-06-27 Thread Mark Gaiser
and isTestModeEnabled is true. Fine, but it's never set back to false again. I don't know if it's an issue at all.. Just something i noticed. The same for the userWarned a few lines down. - Mark Gaiser On June 27, 2014, 10:31 p.m., David Faure wrote

Re: Review Request 118985: KSharedConfig: only write to mainConfig and wasTestModeEnabled in the main thread

2014-06-28 Thread Mark Gaiser
On June 27, 2014, 11:47 p.m., Mark Gaiser wrote: src/core/ksharedconfig.cpp, line 91 https://git.reviewboard.kde.org/r/118985/diff/1/?file=285018#file285018line91 -- slightly unrelated since it wasn't there before this patch. } else { wasTestModeEnabled

Re: Review Request 119126: KMimeTypeChooser: hide Edit button if keditfiletype5 isn't found.

2014-07-05 Thread Mark Gaiser
/119126/#comment42894 static const QString s_keditfiletypeExecutable = QStringLiteral(keditfiletype5); Then you can just use s_keditfiletypeExecutable directly instead of QString::fromLatin1... which makes the arguments a bit shorter - Mark Gaiser On July 5, 2014, 10:30 a.m., David

Re: Review Request 119126: KMimeTypeChooser: hide Edit button if keditfiletype5 isn't found.

2014-07-05 Thread Mark Gaiser
On jul 5, 2014, 11:28 a.m., Mark Gaiser wrote: src/kmimetypechooser.cpp, line 64 https://git.reviewboard.kde.org/r/119126/diff/1/?file=287325#file287325line64 static const QString s_keditfiletypeExecutable = QStringLiteral(keditfiletype5); Then you can just use

Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)

2014-07-13 Thread Mark Gaiser
. Something we should try to prevent. 3. This version and add a new constructor that takes a QFileInfo object - my preference. ... I think we need to wait for David' opinion on this. If David is OK with point 3 then i will create a patch + test and send a RR for it. - Mark Gaiser

Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)

2014-07-14 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/#review62298 --- Ship it! Ship It! - Mark Gaiser On jul 13, 2014, 8:35 a.m

Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)

2014-07-14 Thread Mark Gaiser
On jul 13, 2014, 11:17 a.m., Mark Gaiser wrote: src/core/udsentry.cpp, line 72 https://git.reviewboard.kde.org/r/119247/diff/2/?file=289937#file289937line72 I'm not sure if this is the correct approach either. When i'm looking at file.cpp (in kio/src/ioslaves/file

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

2014-07-18 Thread Mark Gaiser
://git.reviewboard.kde.org/r/119336/#comment43435 Why a timer? Just call doUpdate.. - Mark Gaiser On jul 17, 2014, 8:17 p.m., Marco Martin wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 112052: Split kwindoweffects into an x11 and dummy implementation

2013-08-13 Thread Mark Gaiser
think you need to adjust the license part in those new files. - Mark Gaiser On Aug. 13, 2013, 11:53 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112052

Re: Review Request 112052: Split kwindoweffects into an x11 and dummy implementation

2013-08-13 Thread Mark Gaiser
On Aug. 13, 2013, 12:01 p.m., Mark Gaiser wrote: Interesting: Copyright 2009 Marco Martin notm...@gmail.com. I think you need to adjust the license part in those new files. Martin Gräßlin wrote: why? The copyright is still correct. Marco has been the one who wrote that code back

Re: Review Request 112463: Port SMB kioslave to KF5/Qt5

2013-09-02 Thread Mark Gaiser
/112463/#comment28914 This will obviously go once i commit. - Mark Gaiser On Sept. 2, 2013, 7:16 p.m., Mark Gaiser wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112463

Re: KDE Frameworks 2014 Sprint Dot Article missing

2014-08-09 Thread Mark Gaiser
On Fri, Aug 8, 2014 at 9:23 PM, Albert Astals Cid aa...@kde.org wrote: El Dilluns, 28 de juliol de 2014, a les 00:48:54, Albert Astals Cid va escriure: Hi guys, please note that the Dot Article of the KDE Frameworks 2014 Sprint is missing. Can someone of the guys that was there write

Re: Breeze widget style for KF5

2014-08-11 Thread Mark Gaiser
On Mon, Aug 11, 2014 at 12:29 PM, Hugo Pereira Da Costa hugo.pere...@free.fr wrote: Hi all, For the last couple of weeks and after discussion with Nuno, Marco, Andrew and some others, I've worked on implementing most of the ideas from git://anongit.kde.org/breeze.git (more precisely from the

Re: How to promote less mature Frameworks?

2014-08-15 Thread Mark Gaiser
On Fri, Aug 15, 2014 at 12:12 AM, Àlex Fiestas afies...@kde.org wrote: Hi there At the Randa sprint we have discussed a little bit what to do with those frameworks that are still not mature (for example they can't commit on ABI/API stability) but they are ready for feedback from third party

Re: Review Request 119809: KIO: New job RestoreJob, public API KIO::restoreFromTrash().

2014-08-16 Thread Mark Gaiser
/119809/#comment45224 Copy paste error? You miss: @param urls ... (seems to be the current @param) @param flags ... @return ... - Mark Gaiser On aug 16, 2014, 10:40 p.m., David Faure wrote: --- This is an automatically

  1   2   3   4   >