,
Matthieu Gallien
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
://git.reviewboard.kde.org/r/116056/diff/
Testing
---
Not much. I do not know how to test the ioslave without something like dolphin.
Thanks,
Matthieu Gallien
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde
/KIOCore/kio/slavebase.h)
and not in kdnssd.
I have a review request to do for kio to fix that.
On Feb. 26, 2014, 12:07 p.m., Matthieu Gallien wrote:
Thanks for doing this work, and sorry for not using it!
In terms of what to do instead, I suggest one of:
- look into porting things in kde
---
Not much. I do not know how to test the ioslave without something like dolphin.
Thanks,
Matthieu Gallien
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
include/KF5/KIOCore/kio/slavebase.h is including headers from KI18N and is
publically installed.
Diffs
-
KF5KIOConfig.cmake.in 3a947b7
src/core/CMakeLists.txt d897e37
Diff: https://git.reviewboard.kde.org/r/116103/diff/
Testing
---
Thanks,
Matthieu Gallien
://git.reviewboard.kde.org/r/116103/#review50988
---
On Feb. 26, 2014, 10:44 p.m., Matthieu Gallien wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
://git.reviewboard.kde.org/r/116103/diff/
Testing
---
Thanks,
Matthieu Gallien
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
?
- Matthieu Gallien
On Jan. 15, 2017, 4:01 p.m., Matthieu Gallien wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
?
- Matthieu Gallien
On Jan. 15, 2017, 4:03 p.m., Matthieu Gallien wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
omatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129798/#review102399
---
On Jan. 15, 2017, 4:03 p.m., Matthieu Gallien wrote:
>
> ---
> This
> On Feb. 5, 2017, 10:45 a.m., David Faure wrote:
> > Patch looks ok to me, although I don't know much about all this.
> >
> > The real problem isn't tooling, but lack of active maintainership for
> > kfilemetadata. Are you interested in taking over?
>
> Ma
/diff/
Testing
---
Automatic tests are still all OK on my setup.
I have modified my music player to makes use of it and it works.
I have not yet any clear idea how to makes Baloo reindex the files to cache new
properties.
Thanks,
Matthieu Gallien
marked as submitted.
Review request for Baloo and KDE Frameworks.
Changes
---
Submitted with commit 17aaf4ec09a5bf2e3c213cdfbcd3938c6c81c2cd by Matthieu
Gallien to branch master.
Repository: kfilemetadata
Description
---
fix build of kfilemetadata with taglib version 1.9
Diffs
marked as submitted.
Review request for Baloo and KDE Frameworks.
Changes
---
Submitted with commit 35ea63920a0398aa859b2944770fd9036c271166 by Matthieu
Gallien to branch master.
Repository: kfilemetadata
Description
---
Musepack extraction of album artist was using the wrong tag
.
I have checked from taglib github repository that the API exists in 1.9 version.
Thanks,
Matthieu Gallien
Hello,
I am using Baloo to collect all audio files in its database. I would like to
keep the list up to date with the Baloo database when my application is
running.
Currently Baloo DBus interface provides two information:
* the files currently being scanned: could help discover new files ;
* a
mgallien added a reviewer: mgallien.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D4377
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: awilcox, mgallien
Cc: #frameworks
g
problem in Musepack format against Easytag and Picard applications.
Thanks,
Matthieu Gallien
Baloo reindex the files to cache new
properties.
Thanks,
Matthieu Gallien
extractors/taglibextractor.cpp 8fcad93ca4fc6572a412c1f729d1ef361dd7e8cf
Diff: https://git.reviewboard.kde.org/r/129798/diff/
Testing
---
I have tested with automatic tests of KFileMetaData and also the encoding
problem in Musepack format against Easytag and Picard applications.
Thanks,
Matthieu Gallien
mgallien added a reviewer: dfaure.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D4911
To: mgallien, vhanda, dfaure
Cc: cullmann, apol, #frameworks
mgallien reclaimed this revision.
mgallien added a comment.
Reopening since I am still convinced that getting signals from Baloo is a lot
more sane than adding workaround in each users of Baloo.
My point is that for a music player like the one I am working on (Elisa), I
have to do the
Hello all,
Sorry to exhume this old thread, but
2016-12-29 13:47 GMT+01:00 Dominik Haumann :
> Hi all,
>
> CC: plasma-devel, due to stability issues
>
> On Fri, Oct 7, 2016 at 5:56 PM, Christoph Cullmann
> wrote:
>> Hi,
>>
> [...]
>> Actually, the
mgallien added a comment.
Sorry for the long delay before any actions from me.
Could you update the patch such that one can apply it to the current
filemetadata repository (seems like you are renaming from
kfilemetadata-5.23.0/autotests/samplefiles/testexternalwriter/main.py.old to
> On mars 15, 2017, 9:55 matin, Matthieu Gallien wrote:
> > Ship It!
>
> Matthieu Gallien wrote:
> KFileMetaData being in use by itself, IMHO Baloo problematics should not
> block this correction.
I almost forgot to ask an automatic test for your fix. Please
> On mars 15, 2017, 9:55 matin, Matthieu Gallien wrote:
> > Ship It!
KFileMetaData being in use by itself, IMHO Baloo problematics should not block
this correction.
- Matthieu
---
This is an automatically generated e-mail.
> On mars 15, 2017, 9:55 matin, Matthieu Gallien wrote:
> > Ship It!
>
> Matthieu Gallien wrote:
> KFileMetaData being in use by itself, IMHO Baloo problematics should not
> block this correction.
>
> Matthieu Gallien wrote:
> I almost forgot to ask
Hello,
I am a bit lost when looking at both KFileMetaData projects under
build.kde.org. I am not able to get any coverage, cppcheck or
automatic tests results.
Am I looking at the wrong place ?
Is it expected ?
Thanks in advance for any help
Best regards
--
Matthieu Gallien
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130013/#review102851
---
Ship it!
Ship It!
- Matthieu Gallien
On mars 14, 2017
gt; http://i.imgur.com/D4Asuaa.png
>
> On Wed, Mar 15, 2017 at 10:10 AM, Matthieu Gallien
> <gallien.matth...@gmail.com> wrote:
>> Hello,
>>
>> I am a bit lost when looking at both KFileMetaData projects under
>> build.kde.org. I am not able to get any coverag
> On mars 15, 2017, 9:55 matin, Matthieu Gallien wrote:
> > Ship It!
>
> Matthieu Gallien wrote:
> KFileMetaData being in use by itself, IMHO Baloo problematics should not
> block this correction.
>
> Matthieu Gallien wrote:
> I almost forgot to ask
> On mars 15, 2017, 9:55 matin, Matthieu Gallien wrote:
> > Ship It!
>
> Matthieu Gallien wrote:
> KFileMetaData being in use by itself, IMHO Baloo problematics should not
> block this correction.
>
> Matthieu Gallien wrote:
> I almost forgot to ask
mgallien accepted this revision.
mgallien added a comment.
This revision is now accepted and ready to land.
Thanks for your contribution.
Could you check if other tests in KFileMetaData need also that ?
REPOSITORY
R286 KFileMetaData
BRANCH
master
REVISION DETAIL
mgallien created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
Let Karchive be an optional build dependency of KFileMetaData
TEST PLAN
Still build with or without KArchive
REPOSITORY
R286
mgallien updated this revision to Diff 13367.
mgallien added a comment.
update copyright
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5417?vs=13366=13367
BRANCH
qtmultimedia
REVISION DETAIL
https://phabricator.kde.org/D5417
AFFECTED FILES
mgallien created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
the new extractor is not as good as the taglib built one but depend only
on QtMultimedia
the quality of the extraction depends on
Hello,
On jeudi 13 avril 2017 19:31:37 CEST Kevin Funk wrote:
> On Thursday, 13 April 2017 18:25:19 CEST Matthieu Gallien wrote:
> > Hello,
> >
> > I am trying to use KFileMetaData on Windows with mingw-5.3 32 bits. I am
> > getting compilation errors in the automatic
mgallien added a reviewer: kfunk.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D5443
To: mgallien, kfunk
Cc: #frameworks
mgallien updated this revision to Diff 13496.
mgallien added a comment.
added a set_package_properties for KF5Archive
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5413?vs=13359=13496
BRANCH
karchive_optional
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:599e9b6489fe: makes KArchive be optional and do not build
extractors needing it (authored by mgallien).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D5413?vs=13496=13507#toc
REPOSITORY
to Microsoft compilers ?
Thanks in advance for your help
Best regards
--
Matthieu Gallien
mgallien abandoned this revision.
mgallien added a comment.
I think this review is going nowhere. I prefer to cancel it instead of
spending my energy on it.
I will limit Elisa usage of Baloo to getting an initial list of files
hopefully faster than by looking at file system. All later
mgallien added a comment.
In https://phabricator.kde.org/D4911#94076, @cullmann wrote:
> > I will limit Elisa usage of Baloo to getting an initial list of files
hopefully faster than by looking at file system.
>
> I would actually not even do that, as baloo isn't working that well
mgallien updated this revision to Diff 12137.
mgallien added a comment.
add checks that the correct signal is sent during tests of MetadataMover
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4911?vs=12134=12137
BRANCH
master
REVISION DETAIL
mgallien updated this revision to Diff 12134.
mgallien added a comment.
fix two new issues reported by apol
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4911?vs=12116=12134
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D4911
AFFECTED
mgallien marked 2 inline comments as done.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D4911
To: mgallien
Cc: apol, #frameworks
mgallien added a comment.
In https://phabricator.kde.org/D4911#92718, @cullmann wrote:
> Just my 2 cents from the sideline:
>
> 1. baloo is unmaintained and the bugs pile up, just check bugs.kde.org for
that, not sure if adding yet-an-other feature to it is a good idea
> 2. as
mgallien added a comment.
In https://phabricator.kde.org/D4911#92473, @vhanda wrote:
> I'm not the maintainer of Baloo any more, so I don't want to give it a
clear Yes / No.
>
> This patch is going to be a big CPU hog. For files this will barely have an
impact, but for folders of a
mgallien added a comment.
In https://phabricator.kde.org/D4911#92732, @mgallien wrote:
> In https://phabricator.kde.org/D4911#92718, @cullmann wrote:
>
> > Just my 2 cents from the sideline:
> >
> > 1. baloo is unmaintained and the bugs pile up, just check bugs.kde.org
for that,
mgallien removed a reviewer: kde-frameworks-devel.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D4911
To: mgallien
Cc: #frameworks
mgallien added a task: T4931: Incremental changes from Baloo (new tracks,
modified tracks, removed tracks).
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D4911
To: mgallien
Cc: #frameworks
mgallien marked 4 inline comments as done.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D4911
To: mgallien
Cc: apol, #frameworks
mgallien updated this revision to Diff 12116.
mgallien added a comment.
Fix issues reported by apol
Not sure the list iteration on quint64 needs a const auto &.
Will add automatic tests later and as soon as possible
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
mgallien created this revision.Restricted Application added a project: Frameworks.Restricted Application added a subscriber: Frameworks.
View RevisionREVISION SUMMARYAdd new DBus signals sent by Baloo indexer for removed or moved files.
I still need to extend existing automatic tests with checks
mgallien added a reviewer: kde-frameworks-devel.
View RevisionREPOSITORYR293 BalooREVISION DETAILhttps://phabricator.kde.org/D4911EMAIL PREFERENCEShttps://phabricator.kde.org/settings/panel/emailpreferences/To: mgallien, kde-frameworks-develCc: Frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:76ed16d79437: Fix Python dependency in test scripts for
KFileMetaData (bug 375472) (authored by awilcox, committed by mgallien).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
mgallien created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
in automatic tests, find python interpreter and use it for python test scripts
this way we do not use /usr/bin/env that may or may not
mgallien added a reviewer: Frameworks.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D6979
To: mgallien, aacid, awilcox, #frameworks
Cc: #frameworks
mgallien accepted this revision.
mgallien added a comment.
This revision is now accepted and ready to land.
I tested on Debian with python2 (the version for /usr/bin/python ) . It
works. Please ship your patch. Thanks for your work and sorry for the delay
from my side.
REPOSITORY
R286
mgallien updated this revision to Diff 13840.
mgallien added a comment.
fix several issues when testing on Windows with DirectShow Qt backend
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5417?vs=13367=13840
REVISION DETAIL
Hello,
On vendredi 14 avril 2017 07:54:25 CEST Matthieu Gallien wrote:
> Hello,
>
> On jeudi 13 avril 2017 19:31:37 CEST Kevin Funk wrote:
> > On Thursday, 13 April 2017 18:25:19 CEST Matthieu Gallien wrote:
> > > Hello,
> > >
> > > I am trying to use
mgallien added a reviewer: Android.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D5623
To: mgallien, #android
Cc: #frameworks
mgallien created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
fix build against Android NDK (API Level 21 is required)
TEST PLAN
Test compilation under linux and Android
REPOSITORY
R286
mgallien updated this revision to Diff 13901.
mgallien added a comment.
added a comment and also modify the commit message
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5623?vs=13887=13901
BRANCH
master
REVISION DETAIL
mgallien added a comment.
In https://phabricator.kde.org/D4911#106088, @dfaure wrote:
> Could this be made more lightweight by adding a precise subscription method
rather than signal broadcasts?
I will work on this solution.
> The interested application would register into
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:6a677507aab0: in automatic tests, find python interpreter
and use it for python test scripts (authored by mgallien).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
Le 13 mai 2017 14:18, "David Faure" <fa...@kde.org> a écrit :
On lundi 8 mai 2017 13:09:03 CEST Luigi Toscano wrote:
> Matthieu Gallien ha scritto:
> > Hello,
> >
> > Currently KFileMetaData is a tier 2 framework even when you remove all
> > op
Hello,
As a follow up of a discussion on android list, I would like to gather some
comments or point of views about the following dilemma.
Currently, the mandatory parts of KFileMetaData compile for Android using API
level 21 (Android 5.0). The class UserMetaData is relying on extended
Le 18 mai 2017 02:11, "Aleix Pol" <aleix...@kde.org> a écrit :
On Wed, May 17, 2017 at 9:57 PM, Matthieu Gallien
<gallien.matth...@gmail.com> wrote:
> Hello,
>
> As a follow up of a discussion on android list, I would like to gather
some
> comments or point of
mgallien created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
one should delete the QMediaPlayer in the owner thread to avoid crash
TEST PLAN
Tested with visual studio 2015 build on Windows
mgallien accepted this revision.
mgallien added a comment.
This revision is now accepted and ready to land.
Thanks for the help.
I did not knew this could be wrong.
REPOSITORY
R286 KFileMetaData
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6366
To: palimaka,
mgallien updated this revision to Diff 14953.
mgallien added a comment.
add a new method to register applications wanting to watch moved files and
define (via xml) the interface to implement for applications
REPOSITORY
R293 Baloo
CHANGES SINCE LAST UPDATE
mgallien created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
fix warnings from clazy with the default warning level
TEST PLAN
automatic tests still work as expected on Linux
REPOSITORY
R286 KFileMetaData
BRANCH
master
REVISION DETAIL
mgallien updated this revision to Diff 15104.
mgallien added a comment.
replaced the at(0) by constFirst
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6070?vs=15100=15104
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6070
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:187055408f59: fix warnings from clazy with the default
warning level (authored by mgallien).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
mgallien added a comment.
In https://phabricator.kde.org/D6070#113705, @apol wrote:
> I am not super sure about the struct -> class. Why?
I had missed the fact that the warnings where from clang and not clazy.
The compiler warns that the private class is first declared as a
mgallien added a reviewer: Frameworks.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D5417
To: mgallien, #frameworks
Cc: #frameworks
mgallien added a comment.
Could somebody review this as that would allow simpler build from source than
building taglib and its dependencies and allow simpler deployment on Windows
and Android ?
Thanks in advance
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
mgallien added a comment.
Ping
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D4377
To: awilcox, mgallien
Cc: #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:980d4edf2b52: add an extractor using qtmultimedia
(authored by mgallien).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5417?vs=15454=15461
REVISION DETAIL
mgallien updated this revision to Diff 15454.
mgallien marked 7 inline comments as done.
mgallien added a comment.
fix issues reported by dfaure
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5417?vs=13840=15454
BRANCH
qtmultimedia
REVISION
mgallien added a comment.
Thanks for the review.
The idea of this extractor is to have an extractor not needing taglib (ease
of build, build on platforms other than linux distributions).
QtMultimedia is not extracting a lot of metadata on linux+gstreamer but other
platforms have better
mgallien added a comment.
Ping
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D5623
To: mgallien, #android, #frameworks
Cc: apol, #frameworks
Hello,
Currently KFileMetaData is a tier 2 framework even when you remove all
optional dependencies on other frameworks due to a dependency on ki18n.
I would like to know if people think it would be possible to transition it to
depend on Qt for i18n so as to lower its tier ?
Currently, ki18n
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:ecee5fc8e3cc: fix build against Android NDK (API Level 21
is required) (authored by mgallien).
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
mgallien added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in extractor.cpp:34
> d *should* never be nullptr
If the Extractor is built using the move constructor, the other instance will
have a null d pointer. As far as I know, this is standard practice.
REPOSITORY
R286
mgallien added a comment.
I forgot to say that I do not mind modifying the patch. I am just hoping to
make steady progress on it since I am having crash very often with my music
player.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D7750
To: mgallien,
mgallien added a reviewer: dfaure.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D7750
To: mgallien, #frameworks, dfaure
Cc: dfaure, anthonyfieroni
mgallien added a comment.
Should I push the fix in its current version ?
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D7750
To: mgallien, #frameworks
Cc: anthonyfieroni
mgallien added a comment.
Ping
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D6317
To: mgallien, #frameworks
Cc: #frameworks
mgallien added a comment.
The problem is that, on Windows, internal objects of QMediaPlayer need to be
destroyed in the context of the thread where they have been created. I am not
sure making mMetadataExtractor have mRunnerThread as its parent will help on
that.
I can test but have no
mgallien added a comment.
Thanks, I tested it and it works.
I am not sure about the qWarning.
I would prefer another opinion on that.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D8330
To: davidk, #frameworks
Cc: mgallien, ngraham, #frameworks
mgallien added a reviewer: Frameworks.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D8330
To: davidk, #frameworks
Cc: ngraham, #frameworks
mgallien accepted this revision.
mgallien added a comment.
This revision is now accepted and ready to land.
Thanks
REPOSITORY
R286 KFileMetaData
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8334
To: elvisangelaccio, mgallien
Cc: #frameworks
mgallien created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
fix crash when more than one instances of ExtractorCollection are destructed
TEST PLAN
without the modification to Extractor class, the new test fails. With the
fix, valgrind does not report
mgallien edited reviewers, added: Frameworks; removed: kde-frameworks-devel.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D6317
To: mgallien, #frameworks
Cc: #frameworks
mgallien edited the test plan for this revision.
REPOSITORY
R286 KFileMetaData
REVISION DETAIL
https://phabricator.kde.org/D7750
To: mgallien, #frameworks
mgallien updated this revision to Diff 19416.
mgallien added a comment.
fix another potential memory leak
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7750?vs=19415=19416
BRANCH
fixPluginDelete
REVISION DETAIL
mgallien updated this revision to Diff 19415.
mgallien added a comment.
fix memory leak
REPOSITORY
R286 KFileMetaData
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7750?vs=19342=19415
BRANCH
fixPluginDelete
REVISION DETAIL
https://phabricator.kde.org/D7750
AFFECTED FILES
mgallien added a comment.
According to QPluginLoader, if one wants to release the memory,
In https://phabricator.kde.org/D7750#144373, @anthonyfieroni wrote:
>
1 - 100 of 255 matches
Mail list logo