Asking for recommendations on how to add a feature to KTextEditor

Thank you, Michal Srb

D12662: Add InlineNoteInterface

michalsrb created this revision. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. michalsrb requested review of this revision. REVISION SUMMARY The inline note interface provides a way to render arbitrary things in the text. The la

D12662: Add InlineNoteInterface

michalsrb added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12662 To: michalsrb, #ktexteditor Cc: #frameworks, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D12662: Add InlineNoteInterface

michalsrb added a comment. This is my first attempt to propose such API, it may not be ideal. If the inline note is placed into text, the space for it is created using QTextCharFormat's absolute spacing between the two letters. I admit it is quite a misuse, but it was the least intrusive

D12662: Add InlineNoteInterface

michalsrb added a comment. Here are screenshots from the sample plugin: F5831086: txt.png F5831085: cpp.png F5831084: qml.png The plugin provides notes that are just

D12662: Add InlineNoteInterface

michalsrb added a comment. In D12662#257342 , @brauch wrote: > Looks good from the implementation too so far. One thing I do not see is any changes to the cursorToX / xToCursor functions, is there really no change required there? No chan

D13536: Do not cancel old clipboard selection if it is same as the new one.

michalsrb created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. michalsrb requested review of this revision. REVISION SUMMARY GTK applications seem to call wl_data_device::set_selection multiple times with t

D13536: Do not cancel old clipboard selection if it is same as the new one.

michalsrb abandoned this revision. michalsrb added a comment. Already submitted: https://phabricator.kde.org/D13535 REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13536 To: michalsrb Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12662: Add InlineNoteInterface

michalsrb added a comment. Sorry, I had almost no time to work on it. I got stuck trying to figure out how to properly handle the notes at the beginning of the lines. Then I created KDevelop plugin as experiment to try if the interface is usable: https://github.com/michalsrb/kdev-sourc

D12662: Add InlineNoteInterface

michalsrb added a comment. In D12662#307752 , @brauch wrote: > I'd like to play with this a bit wrt what can be done in KDevelop with it (I want the problem popups gone). Would you mind if I do some changes along the way? I would post an updated

D14826: inline note interface wip #2

michalsrb added a comment. Thank you for working on this. This interface would work for the kdev-sourceinfo use case just as well as the old one. I think the problem with the old interface that you described is valid. This version gives more flexibility to the `InlineNotesProvider` with