D7855: Fix tags KIO-slave protocol description

2017-09-16 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. nicolasfella added a project: Frameworks. REVISION SUMMARY tags.protocol lies about what actions are implemented/available. This disables all unsupported actions in Dolphin etc until these are implemented in the

D7855: Fix tags KIO-slave protocol description

2017-09-22 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R293:8d7db8710ed6: Fix tags KIO-slave protocol description (authored by nicolasfella). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7855?vs=19598=19782 REVISION DETAIL

D7855: Fix tags KIO-slave protocol description

2017-09-21 Thread Nicolas Fella
nicolasfella added a comment. This is a workaround for issues which will be more visible when https://phabricator.kde.org/D7700 gets merged REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D7855 To: nicolasfella, #frameworks Cc: #frameworks

D8146: Don't try to override label heights - PlasmaComponents

2017-10-05 Thread Nicolas Fella
nicolasfella abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D8146 To: nicolasfella, #plasma Cc: mart, davidedmundson, plasma-devel, #frameworks, #plasma, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D8146: Don't try to override label heights - PlasmaComponents

2017-10-04 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: Plasma. nicolasfella added a project: Plasma. Restricted Application added subscribers: Frameworks, plasma-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY Same as https://phabricator.kde.org/D8129 but

D9190: TransferJob: fix for when the readChannelFinished has already been emitted before start is called()

2017-12-17 Thread Nicolas Fella
nicolasfella added a comment. Now it does. Awesome! REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9190 To: aacid, dfaure, apol, albertvaka Cc: ngraham, nicolasfella, anthonyfieroni, #frameworks

D9190: TransferJob: fix for when the readChannelFinished has already been emitted before start is called()

2017-12-14 Thread Nicolas Fella
nicolasfella added a comment. In https://phabricator.kde.org/D9190#179713, @aacid wrote: > Sorry guys i unsubscribed you by mistake when updating the summary. > > Nicolas can you check if this fixes it for you? It does for me. Will do on Monday REPOSITORY R241 KIO REVISION

D9190: TransferJob: workaround for when the readChannelFinished has already been emitted

2017-12-05 Thread Nicolas Fella
nicolasfella added a comment. > Yes it does. You don't know it but > m_reply = Daemon::instance()->networkAccessManager()->put(req, m_origin.data()); > in filetransferjob.cpp is using kio. I really didn't know that > Are you sure you know how to run kdeconnect with the

D9190: TransferJob: workaround for when the readChannelFinished has already been emitted

2017-12-05 Thread Nicolas Fella
nicolasfella added a comment. I'm sorry, but this does not resolve https://bugs.kde.org/show_bug.cgi?id=386246 for me. KDE Connect's FileTransferJob does not even use KIO's TransferJob. It just extends KJob, so it could be a (similar) bug there. REPOSITORY R241 KIO REVISION DETAIL

D12896: Add Telegram plugin

2018-05-15 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Add a "Share via Telegram plugin". It's

D12896: Add Telegram plugin

2018-05-20 Thread Nicolas Fella
nicolasfella added a comment. Can this even work with Telegram installed as sandboxed Flatpak? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D12896 To: nicolasfella, apol Cc: ngraham, kde-frameworks-devel, apol, michaelh, bruns

D12896: Add Telegram plugin

2018-05-15 Thread Nicolas Fella
nicolasfella updated this revision to Diff 34213. nicolasfella added a comment. - Use url.toLocalfile() REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12896?vs=34200=34213 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12896

D12896: Add Telegram plugin

2018-05-22 Thread Nicolas Fella
nicolasfella added a comment. I've played around with flatpaked Telegram and made it working. However: My Telegram.desktop file executes this: /usr/bin/flatpak run --branch=stable --arch=x86_64 --command=telegram-desktop --file-forwarding org.telegram.desktop -- @@u %u @@ I can share a

D12896: Add Telegram plugin

2018-05-23 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R495:6f74cbb9659f: Add Telegram plugin (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12896?vs=34737=34750 REVISION DETAIL

D12896: Add Telegram plugin

2018-05-15 Thread Nicolas Fella
nicolasfella added inline comments. INLINE COMMENTS > apol wrote in telegramplugin.cpp:61 > Instead of finding the program, we could execute using > `org.telegram.desktop.desktop`, it would allow it to work even if it's > installed from appimage/flatpak. > > I'm not sure how this would work

D12896: Add Telegram plugin

2018-05-15 Thread Nicolas Fella
nicolasfella marked 2 inline comments as done. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D12896 To: nicolasfella, apol Cc: ngraham, kde-frameworks-devel, apol, michaelh, bruns

D12896: Add Telegram plugin

2018-05-23 Thread Nicolas Fella
nicolasfella added a comment. In D12896#266713 , @apol wrote: > Then just read the Exec field and we'll add the sendpath by hand. This is ad-hoc for telegram anyway. I'm not quite sure what to do. Best I came up with is something like

D12896: Add Telegram plugin

2018-05-23 Thread Nicolas Fella
nicolasfella added a comment. I played around a bit and it turns out more difficult than expected. - telegram-desktop-bin from AUR has telegramdesktop.desktop whereas the Flatpak version has org.telegram.desktop.desktop, so we would need to look for at least those desktop files - the

D12896: Add Telegram plugin

2018-05-23 Thread Nicolas Fella
nicolasfella updated this revision to Diff 34737. nicolasfella added a comment. : - Hardcode commands and try until success REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12896?vs=34213=34737 BRANCH master REVISION DETAIL

D13124: [RFC] Add Share action to Dolphin context menu

2018-06-18 Thread Nicolas Fella
nicolasfella added inline comments. INLINE COMMENTS > elvisangelaccio wrote in CMakeLists.txt:12-13 > Please consider using json metadata and installing the plugin into the > `kf5/kfileitemaction` namespace. Sorry, I don't quite understand what I am supposed to do REPOSITORY R495 Purpose

D13124: [RFC] Add Share action to Dolphin context menu

2018-05-26 Thread Nicolas Fella
nicolasfella updated this revision to Diff 34933. nicolasfella added a comment. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. Make it a FileItemActionPlugin REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE

D13124: [RFC] Add Share action to Dolphin context menu

2018-05-26 Thread Nicolas Fella
nicolasfella marked an inline comment as done. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, #dolphin, apol, elvisangelaccio Cc: kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, michaelh, spoorun,

D13124: [RFC] Add Share action to Dolphin context menu

2018-05-26 Thread Nicolas Fella
nicolasfella updated this revision to Diff 34934. nicolasfella added a comment. - Set mimetype to */* if reported mimetype is empty REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13124?vs=34933=34934 BRANCH fiap REVISION DETAIL

D13150: Add ellipsis where appropriate

2018-05-27 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: VDG, apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Add ellipsis to actions that open up

D13151: Fix Phabricator icon

2018-05-27 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R495:65f9072a2ec7: Fix Phabricator icon (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13151?vs=34976=35002#toc REPOSITORY R495 Purpose Library CHANGES SINCE LAST

D13160: Highlight the selected device in the KDE Connect plugin

2018-05-27 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R495:956efe4cd21f: Highlight the selected device in the KDE Connect plugin (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE

D13158: Fix i18n issues in Phabricator Plugin

2018-05-27 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R495:e052c9e88fd1: Fix i18n issues in Phabricator Plugin (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13158?vs=34984=35004#toc REPOSITORY R495 Purpose Library

D13124: [RFC] Add Share action to Dolphin context menu

2018-05-27 Thread Nicolas Fella
nicolasfella added a comment. In D13124#268906 , @broulik wrote: > Have you seen D12895 ? I looked for similar patches with the #dolphin tag, but I didn't see

D13124: [RFC] Add Share action to Dolphin context menu

2018-06-02 Thread Nicolas Fella
nicolasfella added a comment. Friendly ping? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, #dolphin, apol, elvisangelaccio Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, michaelh,

D13150: Add ellipsis where appropriate

2018-05-27 Thread Nicolas Fella
nicolasfella added a comment. It's done this way in Email, KTP and KDE Connect already. If we add the ellipsis in AlternativesModel's DisplayRole we get it on every entry, even if it would be inappropriate. REPOSITORY R495 Purpose Library REVISION DETAIL

D13150: Add ellipsis where appropriate

2018-05-27 Thread Nicolas Fella
nicolasfella added a comment. Quote from VDG: If there will be further user input needed and a dialogue or similar popping up for it: needs ellipsis Therefore Pastebin would not need one, but I guess this is neglectable REPOSITORY R495 Purpose Library REVISION DETAIL

D13124: [RFC] Add Share action to Dolphin context menu

2018-05-29 Thread Nicolas Fella
nicolasfella added a comment. In D13124#269655 , @broulik wrote: > I like yours better, I can abandon mine if you want to finish this :) I would have abandoned mine because you were first, but fine with me :) REPOSITORY R495 Purpose

D13151: Fix Phabricator icon

2018-05-27 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY use the right icon name REPOSITORY

D13160: Highlight the selected device in the KDE Connect plugin

2018-05-27 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R495 Purpose Library BRANCH highlight

D12895: WIP: Add KFileItemActionsPlugin

2018-05-27 Thread Nicolas Fella
nicolasfella added inline comments. INLINE COMMENTS > sharefileitemaction.cpp:83 > +m_purposeMenu->model()->setInputData(QJsonObject{ > +{QStringLiteral("mimeType"), fileItemInfos.mimeType()}, > +{QStringLiteral("urls"), mimeType() can be empty which can cause problems (see

D13158: Fix i18n issues in Phabricator Plugin

2018-05-27 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY When the diffs combo box is empty i18n

D13158: Fix i18n issues in Phabricator Plugin

2018-05-27 Thread Nicolas Fella
nicolasfella edited the summary of this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13158 To: nicolasfella, apol Cc: kde-frameworks-devel, apol, michaelh, ngraham, bruns

D13124: Add Share action to Dolphin context menu

2018-07-02 Thread Nicolas Fella
nicolasfella retitled this revision from "[RFC] Add Share action to Dolphin context menu" to "Add Share action to Dolphin context menu". REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, apol Cc: markg, broulik, kde-frameworks-devel,

D13124: [RFC] Add Share action to Dolphin context menu

2018-07-02 Thread Nicolas Fella
nicolasfella updated this revision to Diff 37052. nicolasfella added a comment. - Rename to ShareFileItemAction REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13124?vs=36578=37052 BRANCH fiap REVISION DETAIL https://phabricator.kde.org/D13124

D13706: [KMoreTools] Enable installing tools via appstream url

2018-06-25 Thread Nicolas Fella
nicolasfella marked 9 inline comments as done. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D13706 To: nicolasfella, #frameworks, gregormi, ngraham Cc: ngraham, dhaumann, kde-frameworks-devel, michaelh, bruns

D13706: [KMoreTools] Enable installing tools via appstream url

2018-06-25 Thread Nicolas Fella
nicolasfella updated this revision to Diff 36651. nicolasfella added a comment. - Add more appstream ids REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13706?vs=36650=36651 BRANCH appstream REVISION DETAIL https://phabricator.kde.org/D13706

D13706: [KMoreTools] Enable installing tools via appstream url

2018-06-25 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R304:84432a55e969: [KMoreTools] Enable installing tools via appstream url (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13706?vs=36652=36655#toc REPOSITORY R304

D13706: [KMoreTools] Enable installing tools via appstream url

2018-06-25 Thread Nicolas Fella
nicolasfella updated this revision to Diff 36650. nicolasfella added a comment. - doc++ REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13706?vs=36620=36650 BRANCH appstream REVISION DETAIL https://phabricator.kde.org/D13706 AFFECTED FILES

D13706: [KMoreTools] Enable installing tools via appstream url

2018-06-25 Thread Nicolas Fella
nicolasfella updated this revision to Diff 36652. nicolasfella added a comment. o - Even more appstream ids. Thanks Nate REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13706?vs=36651=36652 BRANCH appstream REVISION DETAIL

D13706: [KMoreTools] Enable installing tools via appstream url

2018-06-24 Thread Nicolas Fella
nicolasfella updated this revision to Diff 36609. nicolasfella added a comment. - Add more appstream urls REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13706?vs=36606=36609 BRANCH appstream REVISION DETAIL https://phabricator.kde.org/D13706

D13706: [KMoreTools] Enable installing tools via appstream url

2018-06-24 Thread Nicolas Fella
nicolasfella updated this revision to Diff 36617. nicolasfella added a comment. - Add documentation REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13706?vs=36612=36617 BRANCH appstream REVISION DETAIL https://phabricator.kde.org/D13706 AFFECTED

D13706: [KMoreTools] Enable installing tools via appstream url

2018-06-24 Thread Nicolas Fella
nicolasfella marked 2 inline comments as done. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D13706 To: nicolasfella, #frameworks, gregormi, dhaumann Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D13706: [KMoreTools] Enable installing tools via appstream url

2018-06-24 Thread Nicolas Fella
nicolasfella updated this revision to Diff 36612. nicolasfella added a comment. - Add kmousetool url REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13706?vs=36609=36612 BRANCH appstream REVISION DETAIL https://phabricator.kde.org/D13706 AFFECTED

D13706: [KMoreTools] Enable installing tools via appstream url

2018-06-24 Thread Nicolas Fella
nicolasfella updated this revision to Diff 36620. nicolasfella added a comment. - Replace appstreamUrl with appstreamId REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13706?vs=36617=36620 BRANCH appstream REVISION DETAIL

D13706: [KMoreTools] Enable installing tools via appstream url

2018-06-24 Thread Nicolas Fella
nicolasfella added inline comments. INLINE COMMENTS > gregormi wrote in kmoretools_p.h:394 > What does the % sign do here? Can this be used to concatenate strings? Did > not try it myself. > > Otherwise ready to land. + would give the same result. What % does is acting as a QStringBuilder,

D13706: [KMoreTools] Enable installing tools via appstream url

2018-06-24 Thread Nicolas Fella
nicolasfella added inline comments. INLINE COMMENTS > nicolasfella wrote in kmoretools_p.h:394 > + would give the same result. What % does is acting as a QStringBuilder, > which is more performant in theory (not that it really matters in this case) See

D13124: [RFC] Add Share action to Dolphin context menu

2018-06-23 Thread Nicolas Fella
nicolasfella added a comment. @apol As soon as we land this we have two ways of sharing with KDE Connect. Should we just remove the FileItemActionPlugin from KDE Connect? Are there more applications than Dolphin using FIAPs? REPOSITORY R495 Purpose Library REVISION DETAIL

D13124: [RFC] Add Share action to Dolphin context menu

2018-06-23 Thread Nicolas Fella
nicolasfella updated this revision to Diff 36578. nicolasfella added a comment. Use JSON metadata and install in kf5/fileitemaction namespace REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13124?vs=34934=36578 BRANCH fiap REVISION DETAIL

D13124: [RFC] Add Share action to Dolphin context menu

2018-06-23 Thread Nicolas Fella
nicolasfella marked 3 inline comments as done. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, apol Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, michaelh, spoorun, navarromorales,

D13124: [RFC] Add Share action to Dolphin context menu

2018-07-01 Thread Nicolas Fella
nicolasfella added a comment. @apol ping? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, apol Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, michaelh, spoorun, navarromorales,

D13124: Add Share action to Dolphin context menu

2018-07-02 Thread Nicolas Fella
nicolasfella added a reviewer: Dolphin. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, apol, #dolphin Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, michaelh, spoorun, navarromorales,

D13124: Add Share action to Dolphin context menu

2018-07-03 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R495:efbb952f10b3: Add Share action to Dolphin context menu (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13124?vs=37052=37102

D10807: fileindexerconfig: Exclude Vaults by default

2018-02-24 Thread Nicolas Fella
nicolasfella added a comment. You have to hit next a couple of times REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham Cc: nicolasfella, ashaposhnikov, michaelh, kmorwinski, spoorun, alexeymin

D10807: fileindexerconfig: Exclude Vaults by default

2018-02-24 Thread Nicolas Fella
nicolasfella added a comment. Vault can also be mounted in other directories than ~/Vaults REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham Cc: nicolasfella, ashaposhnikov, michaelh, kmorwinski, spoorun, alexeymin

D10807: fileindexerconfig: Exclude Vaults by default

2018-02-24 Thread Nicolas Fella
nicolasfella added a comment. When creating a Vault you can choose any location for it. ~/Vaults is just the default REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham Cc: nicolasfella, ashaposhnikov, michaelh,

D10807: fileindexerconfig: Exclude Vaults by default

2018-02-24 Thread Nicolas Fella
nicolasfella added a comment. F5728282: Screenshot_20180224_212932.png REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham Cc: nicolasfella, ashaposhnikov, michaelh, kmorwinski,

D10807: fileindexerconfig: Exclude Vaults by default

2018-02-24 Thread Nicolas Fella
nicolasfella added a subscriber: ivan. nicolasfella added a comment. I honestly don't know. @ivan any idea? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D10807 To: michaelh, #baloo, #frameworks, ngraham Cc: ivan, nicolasfella, ashaposhnikov, michaelh,

D14472: Set Dialog flag for JobDialog

2018-07-29 Thread Nicolas Fella
nicolasfella edited the test plan for this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D14472 To: nicolasfella, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14472: Set Dialog flag for JobDialog

2018-07-29 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY The JobDialog window is treated as a

D14397: Support libcanberra for audio notification

2018-07-27 Thread Nicolas Fella
nicolasfella added a comment. Not using something because it's from a "rival GUI" is not a valid argument. FWIW plasma-pa already uses Glib and Canberra. QtMultimedia uses GStreamer as backend on Unix, so it pulls in glib anyway. The only advantage, if any, of using QtMultimedia is that it

D14397: Support libcanberra for audio notification

2018-07-31 Thread Nicolas Fella
nicolasfella added a comment. +1 for Canberra REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D14397 To: broulik, #frameworks, dfaure, davidedmundson, sitter, drosca, kfunk, rjvbb Cc: alexeymin, ngraham, nicolasfella, kde-frameworks-devel, michaelh, bruns

D13880: [KMoreTools] Reduce menu hierarchy

2018-08-13 Thread Nicolas Fella
nicolasfella added a comment. In D13880#307597 , @dhaumann wrote: > What is the current state of this? > The new private functions should move to the pimpl class behind the d-pointer. > > In general: Looking at the public classes, /all/

D14052: Add bluetooth plugin

2018-07-17 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R495:0c9bf25e18a8: Add bluetooth plugin (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14052?vs=37583=37969 REVISION DETAIL

D14052: Add bluetooth plugin

2018-07-16 Thread Nicolas Fella
nicolasfella added inline comments. INLINE COMMENTS > apol wrote in CMakeLists.txt:1 > Maybe should have `find_qmlmodule(org.kde.bluezqt 1.0)`? Makes sense. When I include it cmake tells me it's not found, although /usr/lib/qt/qml/org/kde/bluezqt exists. Am I missing something? REPOSITORY

D14107: [Telegram] Don't wait for Telegram to be closed

2018-07-13 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Unlike e.g. kdeconnect-cli telegram

D7700: Show list of tags in PlacesView

2018-07-19 Thread Nicolas Fella
nicolasfella updated this revision to Diff 38100. nicolasfella added a comment. Actually save tag bookmark and check if it already exists before adding REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7700?vs=37300=38100 BRANCH tags REVISION DETAIL

D14052: Add bluetooth plugin

2018-07-16 Thread Nicolas Fella
nicolasfella added a comment. @apol I would like your opinion before merging REPOSITORY R495 Purpose Library BRANCH bluetooth REVISION DETAIL https://phabricator.kde.org/D14052 To: nicolasfella, apol, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14107: [Telegram] Don't wait for Telegram to be closed

2018-07-16 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R495:6803b1203e46: [Telegram] Dont wait for Telegram to be closed (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE

D15375: Exclude genome files from indexing

2018-09-09 Thread Nicolas Fella
nicolasfella updated this revision to Diff 41261. nicolasfella added a comment. - Bump version REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15375?vs=41259=41261 BRANCH genome REVISION DETAIL https://phabricator.kde.org/D15375 AFFECTED FILES

D15375: Exclude genome files from indexing

2018-09-09 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R293:1f7ac8433e12: Exclude genome files from indexing (authored by nicolasfella). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15375?vs=41261=41262 REVISION DETAIL

D15375: Exclude genome files from indexing

2018-09-09 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Those files contain huge amounts of genome data that is

D13880: [KMoreTools] Reduce menu hierarchy

2018-07-04 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: gregormi, dhaumann, ngraham. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Skip 'More'

D13880: [KMoreTools] Reduce menu hierarchy

2018-07-04 Thread Nicolas Fella
nicolasfella added a comment. In D13880#286820 , @ngraham wrote: > In D13880#286818 , @nicolasfella wrote: > > > Do you know if/how we can check if there is a handler for appstream://? So we can

D13880: [KMoreTools] Reduce menu hierarchy

2018-07-04 Thread Nicolas Fella
nicolasfella edited the test plan for this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D13880 To: nicolasfella, gregormi, dhaumann, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13880: [KMoreTools] Reduce menu hierarchy

2018-07-04 Thread Nicolas Fella
nicolasfella added a comment. In D13880#286800 , @ngraham wrote: > You are the most awesome person in the world today. Yay! > Here's a radical thought: get rid of the More menu entirely and move all of its content inline, like so:

D13880: [KMoreTools] Reduce menu hierarchy

2018-07-05 Thread Nicolas Fella
nicolasfella added a comment. In D13880#287481 , @gregormi wrote: > +1 for your suggestions. Downside: higher implementation effort. I like it, too, and I am willing to put effort in it, as soon as we agree on a way forward. > A bit

D14052: Add bluetooth plugin

2018-07-11 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: apol, ngraham. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Replace Bluedevil's

D14052: Add bluetooth plugin

2018-07-11 Thread Nicolas Fella
nicolasfella added a dependent revision: D14056: Remove FileItemActionPlugin in favor of Purpose plugin. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D14052 To: nicolasfella, apol, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14052: Add bluetooth plugin

2018-07-11 Thread Nicolas Fella
nicolasfella updated this revision to Diff 37583. nicolasfella added a comment. - Revert unintended change REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14052?vs=37582=37583 BRANCH bluetooth REVISION DETAIL https://phabricator.kde.org/D14052

D7700: Show list of tags in PlacesView

2018-07-07 Thread Nicolas Fella
nicolasfella updated this revision to Diff 37300. nicolasfella added a comment. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. Add tags places in KIO REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D13880: [KMoreTools] Reduce menu hierarchy

2018-07-04 Thread Nicolas Fella
nicolasfella added a comment. In D13880#286816 , @ngraham wrote: > Or even this: > > Open SimpleScreenRecorder > - > Install Peek > Install Vokoscreen > - >

D11643: Fix crash when device emits ready read after job is finished

2018-03-28 Thread Nicolas Fella
nicolasfella added a subscriber: KDE Connect. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11643 To: aacid, #frameworks, dfaure Cc: #kde_connect, michaelh, ngraham

D11649: Fix crash in the file slave

2018-03-28 Thread Nicolas Fella
nicolasfella added a subscriber: KDE Connect. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11649 To: aacid, #frameworks, dfaure Cc: #kde_connect, michaelh, ngraham

D13706: [KMoreTools] Enable installing tools via appstream url

2018-06-24 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY When a tool is not installed add

D13706: [KMoreTools] Enable installing tools via appstream url

2018-06-24 Thread Nicolas Fella
nicolasfella updated this revision to Diff 36606. nicolasfella added a comment. - Whitespace REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13706?vs=36604=36606 BRANCH appstream REVISION DETAIL https://phabricator.kde.org/D13706 AFFECTED FILES

D13706: [KMoreTools] Enable installing tools via appstream url

2018-06-24 Thread Nicolas Fella
nicolasfella edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D13706 To: nicolasfella, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16145: Adapt autotest to new menu structure

2018-10-11 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: gregormi, dhaumann. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY D13880 changed the

D16145: Adapt autotest to new menu structure

2018-10-13 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R304:34e50636dd7b: Adapt autotest to new menu structure (authored by nicolasfella). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16145?vs=43433=43541 REVISION

D14472: Set Dialog flag for JobDialog

2018-10-29 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R495:b82b62e87a4e: Set Dialog flag for JobDialog (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14472?vs=38729=44468 REVISION

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

2018-11-05 Thread Nicolas Fella
nicolasfella added a reviewer: Frameworks. REPOSITORY R224 KDE Connect REVISION DETAIL https://phabricator.kde.org/D16692 To: eduisters, #kde_connect, #frameworks Cc: kdeconnect, shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux,

D7700: Show list of tags in PlacesView

2018-11-13 Thread Nicolas Fella
nicolasfella updated this revision to Diff 45414. nicolasfella added a comment. - Merge branch 'master' into arcpatch-D7700 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7700?vs=38100=45414 BRANCH arcpatch-D7700 REVISION DETAIL

D7700: Show list of tags in PlacesView

2018-11-13 Thread Nicolas Fella
nicolasfella added inline comments. INLINE COMMENTS > ngraham wrote in kfileplacesmodel.cpp:187 > const. But in fact, does this even need to be a variable? It's only used once. Will fix on push REPOSITORY R241 KIO BRANCH arcpatch-D7700 REVISION DETAIL https://phabricator.kde.org/D7700

D7700: Show list of tags in PlacesView

2018-11-13 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R241:2ae8a0c374cd: Show list of tags in PlacesView (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7700?vs=45414=45426#toc REPOSITORY R241 KIO CHANGES SINCE LAST

T8349: Improve Places panel usability and presentation

2018-11-13 Thread Nicolas Fella
nicolasfella updated the task description. TASK DETAIL https://phabricator.kde.org/T8349 To: ngraham, nicolasfella Cc: #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, jtamate, rkflx, #dolphin, ngraham, ggrysuk, alexde, IohannesPetros, sourabhboss, feverfew, trickyricky26,

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

2018-11-05 Thread Nicolas Fella
nicolasfella added a comment. Probably related: D16189 REPOSITORY R224 KDE Connect REVISION DETAIL https://phabricator.kde.org/D16692 To: eduisters, #kde_connect, #frameworks, albertvaka Cc: nicolasfella, albertvaka, kdeconnect, shivanshukantprasad,

  1   2   3   4   >